On 3/14/24 15:17, Mike Pattrick wrote:
> On Wed, Mar 13, 2024 at 1:29 PM Ilya Maximets wrote:
>>
>> Tunnel types are not flags, but 4-bit fields, so checking them with
>> a simple binary 'and' is incorrect and may produce false-positive
>> matches.
>>
>> While the current implementation is
On 2/23/24 04:37, Daniel Ding wrote:
> After running ovs-tcpdump and inputs multiple CTRL+C, the program will
> raise the following exception.
>
> Error in atexit._run_exitfuncs:
> Traceback (most recent call last):
> File "/usr/bin/ovs-tcpdump", line 421, in cleanup_mirror
> ovsdb =
On 3/12/24 18:37, Mike Pattrick wrote:
> Previously OVS reset the mirror contents when a packet is modified in
> such a way that the packets contents changes. However, this change
> incorrectly reset that mirror context when only metadata changes as
> well.
>
> Now we check for all metadata
On 3/16/24 01:44, Ilya Maximets wrote:
> On 3/8/24 09:32, Yuhao zhou via dev wrote:
>> From: "zhouyuhao.philozhou"
>>
>> When mod a flow table's name with table's prefix name, there
>> will be no change. Because when check whether the new and old
>> name are the same, only compare the length of
On 3/8/24 09:32, Yuhao zhou via dev wrote:
> From: "zhouyuhao.philozhou"
>
> When mod a flow table's name with table's prefix name, there
> will be no change. Because when check whether the new and old
> name are the same, only compare the length of the new name.
>
> Case:
> table 10: "good"
On 3/7/24 18:25, Aaron Conole wrote:
> Open vSwitch supports the ability to invoke a controller action by way
> of a sample action with a specified meter. In the normal case, this
> sample action is transparently generated during xlate processing. However,
> when executing via a continuation,
Some of the failure tests can make a single-node cluster to
loose leadership. In this case the next raft_run() will
trigger election with a pre-vore enabled. This is causing
an assertion when this server attempts to vote for itself.
Fix that by not using pre-voting if the is only one server.
A
Consider the following sequence of events:
1. Cluster with 2 nodes - A and B. A is a leader.
2. C connects to A and sends a join request.
3. A sends an append request to C. C is in CATCHUP phase for A.
4. A looses leadership to B. Sends join failure notification to C.
5. C sends append
Consider the following chain of events:
1. Have a cluster with 2 members - A and B. A is a leader.
2. C connects to A, sends a request to join the cluster.
3. A catches up C, creates an update for the 'servers' list and sends
it to B and C to apply. This entry is not committed yet.
4.
Issues discovered while working on:
https://github.com/ovn-org/ovn/issues/235
Ilya Maximets (5):
ovsdb: raft: Randomize leadership transfer.
ovsdb: raft: Fix time intervals for multitasking while joining.
ovsdb: raft: Fix permanent joining state on a cluster member.
ovsdb: raft: Fix
While joining, ovsdb-server may not wake up for a duration of a join
timer, which is 1 second and is by default 3x larger than a heartbeat
timer. This is causing unnecessary warnings from the cooperative
multitasking module that thinks that we missed the heartbeat time by
a lot.
Use join timer
Each cluster member typically always transfers leadership to the same
other member, which is the first in their list of servers. This may
result in two servers in a 3-node cluster to transfer leadership to
each other and never to the third one.
Randomizing the selection to make the load more
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
Exercise the drop action in the datapath. This specific tests triggers
an xlate_error.
For the kernel datapath skb drop reasons can then be seen while this
test runs.
# perf trace -e skb:kfree_skb --filter="reason >= 0x3"
0.000 ping/1275884 skb:kfree_skb(skbaddr: 0x8acd76546000, \
Verify that the explicit drop action is re-probed if the hw-offload flag
is changed.
Signed-off-by: Eric Garver
---
tests/system-offloads-traffic.at | 12
1 file changed, 12 insertions(+)
diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at
index
v12:
- new patch to verify re-probe
- don't mention hw offload in the probe
- changed log message to not mention HW offload
v11:
- move netdev and flow API check to lib
- tweaked log message
- use atomic store instead of cmpx
- copy odp in copy_support()
v10:
- fix a sparse error
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ++-
lib/dpif.h | 2 +-
ofproto/ofproto-dpif.c | 78
This avoids copying the support struct onto the stack.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h |
Thanks for this Lorenzo, looks good to me.
Acked-by: Mark Michelson
On 2/16/24 09:23, Lorenzo Bianconi wrote:
Enable automatic static route configuration when NAT is created with
--ad-route option for gw routers similar to what is currently supported
for distributed routers with
Hi Lorenzo,
Thanks for the fix.
Acked-by: Mark Michelson
When this is merged, the following should also be folded in:
---
diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml
index 17b414144..0cf1c2bb5 100644
--- a/northd/ovn-northd.8.xml
+++ b/northd/ovn-northd.8.xml
@@ -338,7
Currently, ovs-vswitchd is subscribed to all the routing changes in the
kernel. On each change, it marks the internal routing table cache as
invalid, then resets it and dumps all the routes from the kernel from
scratch. The reason for that is kernel routing updates not being
reliable in a sense
Fixes: 65f9f010b426 ("tests: Check unit tests logs for errors.")
Signed-off-by: Xavier Simonart
---
tests/ovn-macros.at | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at
index 3410afb74..5c69facd2 100644
--- a/tests/ovn-macros.at
+++
Bleep bloop. Greetings Xavier Simonart, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless (tests/ovn.at).
error: could not build fake
This patch uses the recently introduced macros defining openflow table numbers.
Signed-off-by: Xavier Simonart
---
v2: - Handled Ales' comments (i.e. fix few remaining hard-coded numbers)
- Rebase on origin/main
v3: - Rebase on origin/main
---
tests/ovn-macros.at | 4 +
tests/ovn.at
There are only two changes:
- The AT_DATA content is not double quoted between square brackets.
- All '[' have been replaced by '[[' and all ']' by ']]'
This patch will be used in subsequent patch to remove hard-coded
table numbers.
Signed-off-by: Xavier Simonart
---
v2: - Rebase on origin/main
Hi Mark
Sorry, drop this patch - missing the 1/2.
Will resend.
Thanks
Xavier
On Fri, Mar 15, 2024 at 7:03 PM Xavier Simonart wrote:
> This patch uses the recently introduced macros defining openflow table
> numbers.
>
> Signed-off-by: Xavier Simonart
>
> ---
> v2: - Handled Ales' comments
This patch uses the recently introduced macros defining openflow table numbers.
Signed-off-by: Xavier Simonart
---
v2: - Handled Ales' comments (i.e. fix few remaining hard-coded numbers)
- Rebase on origin/main
v3: - Rebase on origin/main
---
tests/ovn-macros.at | 4 +
tests/ovn.at
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#283 FILE: utilities/ovn-debug.c:87:
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Use of hardcoded table= or resubmit=(,) is discouraged
in tests. Consider using MACRO
On Fri, Mar 15, 2024 at 12:37:54PM -0400, Eric Garver wrote:
> On Fri, Mar 15, 2024 at 04:55:50PM +0100, Eelco Chaudron wrote:
> >
> >
> > On 11 Mar 2024, at 18:51, Eric Garver wrote:
> >
> > > Kernel support has been added for this action. As such, we need to probe
> > > the datapath for
On 2/13/24 02:15, Ales Musil wrote:
On Mon, Feb 12, 2024 at 5:27 PM Xavier Simonart wrote:
The test was confused as 192.168.0.1 was configured for DR-S3 port
(configured as a gateway-chassis hv4) as well as the encap_ip for hv1.
Hence packets which were supposed to be sent towards hv1 got
Use the ovn-debug commands to determine OpenFlow table numbers
based on stage name. With this there is no need to hardcode them
and it should be future proof for stage shifts/updates.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v5: Rebase on top of main.
v4: Rebase on top of main.
Add ovn-debug binary tool that can be extended with commands that
might be useful for tests/debugging of OVN environment. Currently
the tool supports only two commands:
1) "lflow-stage-to-ltable STAGE_NAME" that converts stage name into
logical flow table id.
2) "lflow-stage-to-oftable
To avoid issues with hardcoded table numbers in future add rule
into check patch. The rule is only warning because there are still
legitimate use cases and not everything can be abstracted.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v5: Rebase on top of main.
v4: Rebase on top of
There were some comments left with hardcoded numbers. Even if it
wouldn't break any test table shift/change it would just leave the
comment outdated.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v5: Rebase on top of main.
v4: Rebase on top of main.
Align the northd.at comment with
This series has the remaing patches that weren't yet
accepted with addition that fixes table numbers in comments.
A lot of tests were relying on exact table numbers for
flow comparison either logical or OpenFlows.
In order to take care of table references into OpenFlow through logical
flow
On 2/13/24 02:21, Ales Musil wrote:
On Mon, Feb 12, 2024 at 5:12 PM Xavier Simonart wrote:
Prefix delegation suffered from potential issues:
- An unicast SOLICIT message was sometimes sent instead of a RENEW.
- Pînctrl was sometimes not waking up as expected when timers such
as T1 or T2
Thanks Ales,
Acked-by: Mark Michelson
This is probably not a huge surprise given how long it has been, but
this series no longer applies cleanly to main. Can you please post a
rebased version of the series as a v5? Thanks!
On 2/12/24 10:55, Ales Musil wrote:
Use the ovn-debug commands to
On 15 Mar 2024, at 17:37, Eric Garver wrote:
> On Fri, Mar 15, 2024 at 04:55:50PM +0100, Eelco Chaudron wrote:
>>
>>
>> On 11 Mar 2024, at 18:51, Eric Garver wrote:
>>
>>> Kernel support has been added for this action. As such, we need to probe
>>> the datapath for support.
>>>
>>>
On Fri, Mar 15, 2024 at 04:55:50PM +0100, Eelco Chaudron wrote:
>
>
> On 11 Mar 2024, at 18:51, Eric Garver wrote:
>
> > Kernel support has been added for this action. As such, we need to probe
> > the datapath for support.
> >
> > Signed-off-by: Eric Garver
>
> Thanks for submitting the
On 11 Mar 2024, at 18:51, Eric Garver wrote:
> Exercise the drop action in the datapath. This specific tests triggers
> an xlate_error.
>
> For the kernel datapath skb drop reasons can then be seen while this
> test runs.
>
> # perf trace -e skb:kfree_skb --filter="reason >= 0x3"
>
I tried to apply this series just now, but patch 2 fails to apply due to
recent changes in tests/ovn.at in OVN main. Xavier, could you rebase and
post a v3 of this series? I will merge this as soon as possible afterwards.
On 2/13/24 02:39, Ales Musil wrote:
On Mon, Feb 12, 2024 at 3:48 PM
On 11 Mar 2024, at 18:51, Eric Garver wrote:
> Kernel support has been added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
Thanks for submitting the changes requested. Some comments below.
Cheers,
Eelco
> ---
>
On 2/12/24 07:00, Dumitru Ceara wrote:
On 2/6/24 10:15, Ales Musil wrote:
The fields that are not directly supported by OvS were encoded
via additional controller action that changed the required value.
This was most notably needed for ICMP need frag messages.
Encode the field value loads as
On 11 Mar 2024, at 18:51, Eric Garver wrote:
> The next commit will convert a dp feature from bool to atomic_bool. As
> such we have to add support to the macros and functions. We must pass by
> reference instead of pass by value because all the atomic operations
> require a reference.
>
>
Avoid recirculating IGMP/MLD packets more than one time from stage
ls_out_pre_lb in the egress pipeline to ovn table 37 in order to avoid
packet looping for ovn-ic deployment.
Acked-by: Mohammad Heib
Signed-off-by: Lorenzo Bianconi
---
controller/pinctrl.c | 2 ++
On 11 Mar 2024, at 18:51, Eric Garver wrote:
> This avoids copying the support struct onto the stack.
>
> Signed-off-by: Eric Garver
> ---
This change looks good to me. Thanks for catching this.
//Eelco
Acked-by: Eelco Chaudron
___
dev mailing
> Hi Lorenzo,
Hi Mohammad,
>
> i have applied and tested this change and i can confirm that it fixes the
> issue.
> if you please can rebase on top of the main.
>
>
> Acked-by: Mohammad Heib
thx for reviewing the patch. I will post v1 soon.
Regards,
Lorenzo
>
> On Thu, Oct 19, 2023 at
On 11 Mar 2024, at 18:51, Eric Garver wrote:
> This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
> action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
> to make -Werror happy we must add a case to all existing switches.
>
> Signed-off-by: Eric Garver
On Wed, Feb 28, 2024 at 5:43 AM Mohammad Heib wrote:
>
> Currently if the user sets the container parent_port:requested-chassis
> option after the VIF/CIF is bonded to the chassis, this will migrate
> the VIF/CIF flows to the new chassis but will still have the
> container flows installed in the
On 13 Mar 2024, at 10:03, Adrian Moreno wrote:
> Add a man page for ovs-flowviz as well as a topic page with some more
> detailed examples.
>
> Signed-off-by: Adrian Moreno
Thank you for including this documentation. It provides a nice insight into how
to use the ovs-flowviz tool.
I have a
On 3/15/24 12:29, Eelco Chaudron wrote:
On 13 Mar 2024, at 10:03, Adrian Moreno wrote:
Add a flow formatting framework and one implementation for console
printing using rich.
The flow formatting framework is a simple set of classes that can be
used to write different flow formatting
On 13 Mar 2024, at 10:03, Adrian Moreno wrote:
> Add a flow formatting framework and one implementation for console
> printing using rich.
>
> The flow formatting framework is a simple set of classes that can be
> used to write different flow formatting implementations. It supports
> styles to
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ': ', is over 70 characters, i.e., 82.
Subject: IC: Tansit switch don't
Crrently ovn transit switch forward mcast traffic that match an igmp
group to all ports participating in this group and to all router ports
that are connected to this TS switch and have mcast_flood enabled.
The above behavior can lead to packet duplicate if we have a VM in
a specific AZ that
Currently when we enable IGMP on OVN-IC cluster with two or more AZs
and one vm from AZ1 send IGMP report, northd will create the following
multicast_group on each AZ:
AZ1:
1. multicast_group that forward the mcast traffic from LS1 to the VM.
2. multicast_group that forward the mcast traffic
Hi Lorenzo,
i have applied and tested this change and i can confirm that it fixes the
issue.
if you please can rebase on top of the main.
Acked-by: Mohammad Heib
On Thu, Oct 19, 2023 at 7:47 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Avoid recirculating IGMP/MLD packets more
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Signed-off-by: Jakob Meng
Some comments below, you might want to consider adding a commit message.
> ---
> tests/pmd.at| 5 +
> tests/unixctl-py.at | 7 +++
> 2 files changed, 12 insertions(+)
>
> diff
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Signed-off-by: Jakob Meng
Some comments below and you might want to add a commit message to this patch.
//Eelco
> ---
> NEWS | 3 +++
> lib/unixctl.c | 4 ++--
> lib/unixctl.h | 1
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> The 'dpif/show' command now supports machine-readable JSON output in
> addition to the plain-text output for humans. An example would be:
>
> ovs-appctl --format json dpif/show
>
> Reported-at:
> From: Jakob Meng
>
> This patch introduces support for different output formats to the
> Python code, as did the previous commit for ovs-xxx tools like
> 'ovs-appctl --format json dpif/show'.
> In particular, tests/appctl.py gains a global option '-f,--format'
> which allows users to request
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> For monitoring systems such as Prometheus it would be beneficial if
> OVS would expose statistics in a machine-readable format.
>
> This patch introduces support for different output formats to ovs-xxx
> tools. They gain a
A potential race condition happened with the following 3 threads:
* PMD thread replaced the old_ukey and transitioned the state to
UKEY_DELETED.
* RCU thread is freeing the old_ukey mutex.
* While the revalidator thread is trying to lock the old_ukey mutex.
We added some timestamp to udpif_key
On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> [
>This is a treewide change. I will likely re-create this patch again in
>the second week of the merge window of v6.9 and submit it then. Hoping
>to keep the conflicts that it will
Hi,
Thanks for submitting a patch and researching the problem. I haven't had the
chance to review your patch yet, as I still need to dedicate some time to
review it, based on the complexity. However, if you've sent a new version in
the meantime, please make sure to label it with a version
A potential race condition happened with the following 3 threads:
* PMD thread replaced the old_ukey and transitioned the state to
UKEY_DELETED.
* RCU thread is freeing the old_ukey mutex.
* While the revalidator thread is trying to lock the old_ukey mutex.
Then vswitchd process aborts at the
67 matches
Mail list logo
