Ipv4 fragments.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v4->v5:
- Removed MRU argument from function declarations as MRU is now retained
in _OVS_BUFFER_CONTEXT.
v3->v4:
- Acquire read lock for read operation
- Undo "trigger cl
This patch retains the MRU value for the reassembled IP datagram in the
OvsForwardingContext when the packet is forwarded to userspace and/or
retrived from userspace.
Also retain the MRU value when there are any deferred actions for the
current NBL.
Signed-off-by: Anand Kumar <kuma
This patch adds support for Fragmenting NBL based on the MRU value.
MRU value is updated only for Ipv4 fragments, if it is non zero, then
fragment the NBL and send out the new NBL to the vnic.
v2->v3:
- Updated log message
v1->v2: No change
Signed-off-by: Anand Kumar &l
of Maximum recieved unit
from all the recieved IPv4 fragments.
v2->v3:
- Updated log messages and fixed alignment.
v1->v2: No change
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Actions.c | 16
datapath-windows/ovsext/Conn
Hi Shashank,
Thank you for reviewing the patch. I have sent out a new version of the patch
series addressing your comments.
Based on your suggestion, I’m using an event to signal the clean up thread to
free up the memory.
Regards,
Anand Kumar
From: Shashank Ram <r...@vmware.com>
Ipv4 fragments.
v2->v3:
- Use spinlock instead of RW lock
- Trigger cleanup event after reassembling the fragments.
v1->v2: No change
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Debug.h
Acked-by: Anand Kumar<kumaran...@vmware.com>
On 11/9/16, 4:34 PM, "Sairam Venugopal" <vsai...@vmware.com> wrote:
Add support for tracking ICMP code and Type in the Hyper-V Conntrack
module. This code is similar to the userspace connection tracker.
This patch adds functionalities to handle IPv4 fragments, which will be
used by Conntrack module.
Added a new structure to hold the Ipv4 fragments and a hash table to
hold Ipv4 datagram entries. Also added a clean up thread that runs
every minute to delete the expired IPv4 datagram entries.
The
This patch retains the MRU value for the reassembled IP datagram in the
OvsForwardingContext when the packet is forwarded to userspace and/or
retrived from userspace.
Also retain the MRU value when there are any deferred actions for the
current NBL.
---
datapath-windows/ovsext/Actions.c| 48
This patch adds support for Ipv4 fragments in conntrack module.
Individual fragments are not tracked, the reassembled Ipv4 datagram is treated
as a single ct entry.
Added MRU field in OvsForwardingContext, to keep track of Maximum recieved unit
from all the recieved IPv4 fragments.
---
MRU value is updated only for the Ipv4 fragments. If it is non zero,
then fragment the NBL based on MRU value and send out the new NBL to
the vnic.
---
datapath-windows/ovsext/Actions.c | 26 ++
1 file changed, 26 insertions(+)
diff --git
This patch adds support for Ipv4 fragments in conntrack module.
Individual fragments are not tracked, the reassembled Ipv4 datagram is treated
as a single ct entry.
Added MRU field in OvsForwardingContext, to keep track of Maximum recieved unit
from all the recieved IPv4 fragments.
---
This patch retains the MRU value for the reassembled IP datagram in the
OvsForwardingContext when the packet is forwarded to userspace and/or
retrived from userspace.
Also retain the MRU value when there are any deferred actions for the
current NBL.
---
datapath-windows/ovsext/Actions.c| 48
This patch adds functionalities to handle IPv4 fragments, which will be
used by Conntrack module.
Added a new structure to hold the Ipv4 fragments and a hash table to
hold Ipv4 datagram entries. Also added a clean up thread that runs
every minute to delete the expired IPv4 datagram entries.
The
MRU value is updated only for the Ipv4 fragments. If it is non zero,
then fragment the NBL based on MRU value and send out the new NBL to
the vnic.
---
datapath-windows/ovsext/Actions.c | 26 ++
1 file changed, 26 insertions(+)
diff --git
With this patch, OvsTcpSegmentNBL not only supports tcp segments but also the
IP fragments.
To reflect the new changes, renamed function name from OvsTcpSegmentNBL
to OvsFragmentNBL and created a wrapper for OvsTcpSegmentNBL.
---
datapath-windows/ovsext/BufferMgmt.c | 189
Ipv4 fragments.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v5->v6: No Change
v4->v5:
- Modified Patch 3 to retain MRU in _OVS_BUFFER_CONTEXT instead of
using it in ovsForwardingContext with minor changes in rest of the
patches.
v3->v4:
- Rebase
- Ac
using it in ovsForwardingContext with minor changes in rest of the
patches.
v3->v4:
- Rebase
- Acquire read lock for read operations.
v2->v3:
- using spinlock instead of RW lock.
- updated log messages, summary, fixed alignment issues.
v1->v2:
- Patch 4 updated to make it compile for release
With this patch, OvsTcpSegmentNBL not only supports fragmenting NBL
to TCP segments but also Ipv4 fragments.
To reflect the new changes, renamed function name from OvsTcpSegmentNBL
to OvsFragmentNBL and created a wrapper for OvsTcpSegmentNBL.
Signed-off-by: Anand Kumar <kumaran...@vmware.
This patch adds support for Fragmenting NBL based on the MRU value.
MRU value is updated only for Ipv4 fragments, if it is non zero, then
fragment the NBL and send out the new NBL to the vnic.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v5->v6: No Change
v4->v5:
This patch introduces a new field MRU(Maximum Recieved Unit) in the
_OVS_BUFFER_CONTEXT and it is used only for Ip Fragments to retain MRU for
the reassembled IP datagram when the packet is forwarded to userspace.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v5->v6: No Chan
This patch adds support for tracking Ipv4 fragments in conntrack module.
Individual fragments are not tracked and are consumed by the
fragmentation/reassembly. Only the reassembled Ipv4 datagram is tracked and
treated as a single ct entry.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
Hi Yin,
Thank you for the patches. Overall the patch looks good except for a few minor
issues.
Please find my comments inline prefixed with [AK]
Regards,
Anand Kumar
On 3/22/17, 3:12 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yin Lin"
<ovs-dev-boun...@openvswitch.org on
Hi Yin,
Thank you for the patches. The patch looks good, I only have a few comments.
Please find my comments inline prefixed with [AK]
Regards,
Anand Kumar
On 3/22/17, 3:11 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yin Lin"
<ovs-dev-boun...@openvswitch.org on
Acked-by: Anand Kumar <kumaran...@vmware.com>
On 4/20/17, 7:43 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> wrote:
Until now we only needed to compute software checksu
With this patch, OvsTcpSegmentNBL not only supports fragmenting NBL
to TCP segments but also Ipv4 fragments.
To reflect the new changes, renamed function name from OvsTcpSegmentNBL
to OvsFragmentNBL and created a wrapper for OvsTcpSegmentNBL.
Signed-off-by: Anand Kumar <kumaran...@vmware.
4 updated to make it compile for release mode.
---
Anand Kumar (5):
datapath-windows: Added a new file to support Ipv4 fragments.
datapath-windows: Added Ipv4 fragments support in Conntrack
datapath-windows: Retain MRU value in the _OVS_BUFFER_CONTEXT.
datapath-windows: Updated OvsTcpSegme
This patch adds support for tracking Ipv4 fragments in conntrack module.
Individual fragments are not tracked and are consumed by the
fragmentation/reassembly. Only the reassembled Ipv4 datagram is tracked and
treated as a single ct entry.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
Ipv4 fragments.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v6->v7: Added new memory pool tag and align function description
v5->v6: No Change
v4->v5:
- Modified Patch 3 to retain MRU in _OVS_BUFFER_CONTEXT instead of
using it in ovsForwardingContext with minor
This patch introduces a new field MRU(Maximum Recieved Unit) in the
_OVS_BUFFER_CONTEXT and it is used only for Ip Fragments to retain MRU for
the reassembled IP datagram when the packet is forwarded to userspace.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v6->v7: Increase v
nstead of doing it only once.
Testing Done:
- Verified that ICMP requests are no longer treated as replies
in Conntrack.
Change-Id: I826a164cfb9137e2167c404ff5c9bfd9dfaa33ad
Co-authored-by: Sairam Venugopal <vsai...@vmware.com>
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datap
Hi Alin,
Thanks for the review. Please find my responses inline.
Will address the review comments and send out v2 version of the patch.
Thanks,
Anand Kumar
On 8/14/17, 8:04 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote:
Hi Sai and Anand,
Thanks a lot
- Also add in some padding for the ct_endpoint's union.
Co-authored-by: Sairam Venugopal <vsai...@vmware.com>
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack.c | 11 +--
datapath-windows/ovsext/Conntrack.h | 6 --
2 files
this issue by not modifying icmp_id field during
SNAT/DNAT only for ICMP traffic
The current NAT module doesn't take the ICMP type/code into account
during the lookups. Fix this to make it similar with the other conntrack
module.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-w
Hi Alin,
Thanks for reviewing the patch. Please find my responses inline.
Will send out a v2 patch addressing the review comments.
Thanks,
Anand Kumar
On 8/14/17, 8:14 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote:
We should revisit how we do hashes a
- Update the CT comparison function to compare individual fields instead of
NdisEqualMemory.
- Add in some padding for the ct_endpoint's union.
- Update the Orig Tuple to use ICMP Type and Code instead of Port for ICMP
Co-authored-by: Sairam Venugopal <vsai...@vmware.com>
Signed-off-by:
this issue by not modifying icmp_id field during
SNAT/DNAT only for ICMP traffic
The current NAT module doesn't take the ICMP type/id/code into account
during the lookups. Fix this to make it similar with the other conntrack
module.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-w
Hi Guru,
Could you please apply this patch?
Thanks,
Anand Kumar
On 6/23/17, 3:04 PM, "Sairam Venugopal" <vsai...@vmware.com> wrote:
Acked-by: Sairam Venugopal <vsai...@vmware.com>
On 6/23/17, 2:05 PM, "ovs-dev-boun...@openvswitch.or
;
fopen_s(, "c:\\test.txt", "w");
if (fp) {
fprintf(fp, "Testing...\n");
DWORD st;
HANDLE h = (HANDLE)GetConsoleMode(fp, );
if (!h) {
cout << "fp is a console device" << endl;
}
}
r
Hi Alin,
I didn’t know that I had to get file handle from _get_osfhandle.
I have tried out the code, it works. I will ack the patch.
Thanks,
Anand Kumar
On 6/28/17, 10:30 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote:
Thanks for
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 6/20/17, 9:31 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> wrote:
A lot of tests are failing, due
Thanks for refactoring it.
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 7/24/17, 3:31 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank
Ram" <ovs-dev-boun...@openvswitch.org on behalf of r...@vmware.com> wrote:
Previously, t
- Also add some padding for the ct_endpoint's union, so that each member
of ct_endpoint's union are of same size.
Co-authored-by: Sairam Venugopal <vsai...@vmware.com>
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack.c | 11 +--
data
Hi Shashank,
Thanks for reviewing the patch. I will update the commit message and send out a
v3 patch.
For the other comment, please find my response inline.
Thanks,
Anand Kumar
On 8/16/17, 10:03 AM, "Shashank Ram" <r...@vmwa
Acked-by: Anand Kumar kumaran...@vmware.com
Thanks,
Anand Kumar
On 5/17/17, 6:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> wrote:
Update the key used by the actions
Hi Alin,
Thank you for identifying and fixing issue in fragmenatation.
Acked-by: Anand Kumar <kumaran...@vmware.com>
Regards,
Anand Kumar
On 5/17/17, 6:43 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 5/17/17, 5:57 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> wrote:
Found by inspection.
Thanks for identifying and fixing this.
Acked-by: Anand Kumar <kumaran...@vmware.com>
Regards,
Anand Kumar
On 5/17/17, 6:54 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> w
*)
should be delivered via the Netfilter netlink multicast groups.
- Send update event only when OVS_CT_ATTR_EVENTMASK attribute has the mask
of bits set for IPCT_MARK and/or IPCT_LABEL.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack.c
Thanks for the review.
I will split up the patch and send out Conntract-Nat.c changes in a separate
patch.
Regards,
Anand Kumar
On 6/23/17, 1:50 PM, "Sairam Venugopal" <vsai...@vmware.com> wrote:
Hi Anand,
Can you split this patch up instead to handle Conntrack.
-off-by: Anand Kumar <kumaran...@vmware.com>
Acked-by: Sairam Venugopal <vsai...@vmware.com>
---
datapath-windows/ovsext/Conntrack.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/datapath-windows/ovsext/Conntrack.c
b/datapath-windows/ovsext/Connt
Update OvsNatKeyAreSame() and OvsHashNatKey() to include ICMP type and code
fields, so that ICMP_ECHO_REQUEST packets are not matched with ICMP_ECHO_REPLY
packets and vice versa.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack-nat.
Thank you for the patches.
Acked-By: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 5/23/17, 10:59 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> wrote:
Th
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 5/23/17, 10:59 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> wrote:
Add two new build
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 5/23/17, 10:59 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> wrote:
This patch ad
- Minimum valid fragment size is 400 bytes, any fragment smaller
is likely to be intentionally crafted.
- Validate maximum length of an Ip datagram
- Added counters to keep track of number of fragments for a given
Ip datagram.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
da
hung at “1813: SSL db: implementation”, so
running it again.
Thanks,
Anand Kumar
From: Guru Shetty <g...@ovn.org>
Date: Friday, June 16, 2017 at 11:06 AM
To: Anand Kumar <kumaran...@vmware.com>
Cc: ovs dev <d...@openvswitch.org>
Subject: Re: [ovs-dev] [PATCH] windows: Remov
- Minimum valid fragment size is 400 bytes, any fragment smaller
is likely to be intentionally crafted (CVE-2000-0305).
- Validate maximum length of an Ip datagram
- Added counters to keep track of number of fragments for a given
Ip datagram.
Signed-off-by: Anand Kumar <kumaran...@vmware.
the service start
function and let the first log message to initialize the vlog module.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
lib/daemon-windows.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c
index 5804284..1ba714d 100644
---
- Parse netlink ct attr OVS_CT_ATTR_EVENTMASK
- Add a new CT_EVENT_TYPE, OVS_EVENT_CT_UPDATE which is triggered
only when CT_ATTR_EVENTMASK is set for MARK and LABEL updates.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/include/OvsDpInterfaceCtExt.
This patch introduces a new field MRU(Maximum Recieved Unit) in the
_OVS_BUFFER_CONTEXT and it is used only for Ip Fragments to retain MRU for
the reassembled IP datagram when the packet is forwarded to userspace.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v7->v8: No chan
messages, summary, fixed alignment issues.
v1->v2:
- Patch 4 updated to make it compile for release mode.
---
Anand Kumar (5):
datapath-windows: Added a new file to support Ipv4 fragments.
datapath-windows: Added Ipv4 fragments support in Conntrack
datapath-windows: Retain MRU value in th
This patch adds support for tracking Ipv4 fragments in conntrack module.
Individual fragments are not tracked and are consumed by the
fragmentation/reassembly. Only the reassembled Ipv4 datagram is tracked and
treated as a single ct entry.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
This patch adds support for Fragmenting NBL based on the MRU value.
MRU value is updated only for Ipv4 fragments, if it is non zero, then
fragment the NBL and send out the new NBL to the vnic.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v7->v8: No change
v6->v7: Frag
Ipv4 fragments.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
v7->v8: Address locking issues found by inspection that could resolve the
assertion observed by Alin in OvsLookupIPFrag() with verifier enabled.
v6->v7: Added new memory pool tag and align function descrip
With this patch, OvsTcpSegmentNBL not only supports fragmenting NBL
to TCP segments but also Ipv4 fragments.
To reflect the new changes, renamed function name from OvsTcpSegmentNBL
to OvsFragmentNBL and created a wrapper for OvsTcpSegmentNBL.
Signed-off-by: Anand Kumar <kumaran...@vmware.
Good catch. Thanks for fixing it.
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 9/22/17, 2:24 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank
Ram" <ovs-dev-boun...@openvswitch.org on behalf of r...@vmware.com> wrote:
Conntrack,
When checksum offload is enabled, compute checksum using the
TCP pseudo header.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Actions.c | 60 +++
1 file changed, 11 insertions(+), 49 deletions(-)
diff --git a/datapath-w
Hi Alin,
Thanks for applying the patch.
Yes, we need this on branch 2.8 as well.
Thanks,
Anand Kumar
On 10/16/17, 7:33 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote:
It looks good and I managed to test it, sorry for the delay.
I had some issues
Hi Sairam,
Thanks for the patch. Please find my comment inline.
Regards,
Anand Kumar
On 8/28/17, 4:56 PM, "ovs-dev-boun...@openvswitch.org on behalf of Sairam
Venugopal" <ovs-dev-boun...@openvswitch.org on behalf of vsai...@vmware.com>
wrote:
The current implementation
Only curNbl in the forwarding context needs to be updated with
fragmented NBL.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Actions.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/datapath-windows/ovsext/Actions.c
b/da
by conntrack.
Also update the ct packet counters when ct entry is created.
With this patch, the conntrack's packet counters behavior is similar
to linux
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack.c | 34 +-
1 file c
Acked-by: Anand Kumar <kumaran...@vmware.com>
On 8/29/17, 2:56 AM, "ovs-dev-boun...@openvswitch.org on behalf of
aserd...@ovn.org" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@ovn.org> wrote:
Acked-by: Alin Gabriel Serdean <aserd...@ovn.org>
with Alin.
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 8/23/17, 7:50 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Balutoiu" <ovs-dev-boun...@openvswitch.org on behalf of
abalut...@cloudbasesolutions.com> wrote:
Bump the secur
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 8/21/17, 2:45 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank
Ram" <ovs-dev-boun...@openvswitch.org on behalf of r...@vmware.com> wrote:
Moves function OvsCreateNewNBLsFromMultipl
Thanks for the patch.
Acked-by: Anand Kumar <kumaran...@vmware.com>
Regards,
Anand Kumar
On 8/25/17, 10:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Gabriel Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@ovn.org> wrote:
Microsoft
Set the geneve flags OVS_TNL_F_GENEVE_OPT and OVS_TNL_F_CRT_OPT
in OvsDecapGeneve, so that windows behavior is similiar to linux
https://github.com/openvswitch/ovs/blob/master/datapath/linux/compat/geneve.c#L242
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/
Hi Shashank,
I have set the tunnel key flags OVS_TNL_F_GENEVE_OPT by default to match the
linux behavior
@https://github.com/openvswitch/ovs/blob/master/datapath/linux/compat/geneve.c#L242
Thanks,
Anand Kumar
On 10/18/17, 9:07 AM, "Shashank Ram" <r...@vmware.com> wrote:
OVS_TNL_F_GENEVE_OPT
if the packet has geneve options.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Geneve.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext/Geneve.c b/datapath-windows/ovsext/Geneve.c
index 4
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 11/20/17, 3:06 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank
Ram" <ovs-dev-boun...@openvswitch.org on behalf of r...@vmware.com> wrote:
Decap functions for tunneling protocols do not
To delete a conntrack entry specified by 5-tuple pass an additional
conntrack 5-tuple parameter to flush-conntrack.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack.c | 146 +---
1 file changed, 134 insertions(
since conntrack 5-tuple is an optional parameter.
Anand Kumar (1):
datapath-windows: Add support for deleting conntrack entry by 5 tuple.
datapath-windows/ovsext/Conntrack.c | 146 +---
1 file changed, 134 insertions(+), 12 deletions(-)
--
2.9.3.windows.1
This patch series replaces existing one RW lock implemenation in
conntrack with two RW locks in conntrack and one RW lock in NAT.
Anand Kumar (3):
datapath-windows: Refactor conntrack code.
datapath-windows: Add a global level RW lock for NAT
datapath-windows: Optimize conntrack lock
reference(bucketLockRef)
to the corresponding OvsCtBucketLock of conntrack table.
We need this reference to retrieve ovsCtBucketLock from ct entry
for delete operation.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack-nat.c | 6 +
datapath-windows/
Currently NAT module relies on the existing conntrack lock.
This patch provides a basic lock implementation for NAT module
in conntrack.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack.c | 36 ++--
1 file chang
Some of the functions and code are refactored
so that new conntrack lock can be implemented
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack-nat.c | 11 +--
datapath-windows/ovsext/Conntrack.c | 170 ++--
datapath-w
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 11/1/17, 10:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Gabriel Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@ovn.org> wrote:
For some unclear and accidental reaso
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 11/1/17, 10:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Gabriel Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@ovn.org> wrote:
Unfortunately starting from VS 20
Acked-by: Anand Kumar <kumaran...@vmware.com>
Thanks,
Anand Kumar
On 11/1/17, 10:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Gabriel Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@ovn.org> wrote:
_set_output_format is deprecated
Hi Sairam,
Sure. Will update the commit message and send out V2.
Thanks,
Anand Kumar
On 4/26/18, 3:57 PM, "Sairam Venugopal" <vsai...@vmware.com> wrote:
Anand,
Thanks for the patch. Can you update the commit message to better describe
the underlying issue?
The conntrack-counters ought to be incremented only if it's a new lookup
or if it's recirculated through a different zone for the first time.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Conntrack.c | 7 ---
1 file changed, 4 insertions(+), 3 del
The Drop eligible indicator(DEI) is 1 bit wide and it is part of
Tag control information (TCI) in VLAN header, which indicates that
the frame can be dropped during congestion.
Signed-off-by: Anand Kumar <kumaran...@vmware.com>
---
datapath-windows/ovsext/Actions.c | 1 +
datapath-windows/
: 6.0Gbps
OVS: 5.1-5.75Gbps
OVS with conntrack enabled: 3.9-4.0Gbps
After optimization:
Native: 6.0Gbps
OVS: 5.1-5.75Gbps
OVS with conntrack enabled:: 4.2-4.4Gbps
Tested by loading/unloading driver with driver verifier enabled
Signed-off-by: Anand Kumar
---
v1->v2: Update commit mess
Hi Shashank,
Thanks for the review. I will address your comments and send out a V3.
Regards,
Anand Kumar
From: Shashank Ram
Date: Friday, June 8, 2018 at 10:11 AM
To: Anand Kumar
Cc: "d...@openvswitch.org"
Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Optimize conntrack
p
Hi Shashank,
Thanks for the review.
Please find my response inline.
Thanks,
Anand Kumar
From: Shashank Ram
Date: Monday, June 18, 2018 at 11:27 AM
To: Anand Kumar , "d...@openvswitch.org"
Subject: Re: [ovs-dev] [PATCH v4 1/4] datapath-windows: Use spinlock instead of
RW lock fo
Hi Shashank,
Thanks for the review. Please find my response inline.
Thanks,
Anand Kumar
On 6/18/18, 11:54 AM, "Shashank Ram" wrote:
On 06/17/2018 10:37 PM, Anand Kumar wrote:
> This patch primarily gets rid of NdisRWLock in conntrack for NAT
> fun
.
- Update 'ctTotalRelatedEntries' using interlocked functions.
- Move conntrack lock out of NAT module.
Testing:
Verified loading/unloading the driver with driver verified enabled.
Ran TCP/UDP and ICMP traffic.
Signed-off-by: Anand Kumar
---
v1->v2: Calculate the dispatch level only in cases wh
Hi Shashank,
I will address this in next version of the patch.
Thanks,
Anand Kumar
On 6/18/18, 2:36 PM, "Shashank Ram" wrote:
This patch should be combined with the patch where NAT lock is removed
from CT. Keeping this separate will cause the previous patches in this
with driver verified enabled.
Ran TCP/UDP and ICMP traffic.
Signed-off-by: Anand Kumar
---
v1->v2: Updated commit message to include testing done.
---
datapath-windows/ovsext/Conntrack.c | 228 ++--
datapath-windows/ovsext/Conntrack.h | 2 -
2 files changed,
from conntrack entry structure.
Testing:
Verified loading/unloading the driver with driver verified enabled.
Ran TCP/UDP and ICMP traffic.
Signed-off-by: Anand Kumar
---
v1->v2: Merge patch 2 and 3 so that NAT locks related changes are in a
single patch.
---
datapath-windows/ovs
1 - 100 of 183 matches
Mail list logo
