Re: [ovs-dev] [PATCH V2] Fix ovndb_servers master and VirtualIP are not on the same node.

2016-12-06 Thread Andy Zhou
On Fri, Dec 2, 2016 at 11:38 PM, Guoshuai Li wrote: > PCS man page says role=Stopped/Started/Master/Slave. > A role can be master or slave (if no role is specified, it defaults to > 'started'). > > Command line "$pcs constraint colocation add ovndb_servers-master with > master VirtualIP" > means

Re: [ovs-dev] [PATCH] ovn: fix OVNDB process is stopped when master node demote to the slave by pacemaker

2016-12-07 Thread Andy Zhou
On Tue, Dec 6, 2016 at 9:41 PM, Guoshuai Li wrote: > When the master node's OVNDB process fails, the local node demote to the > slave. > Failure cause is that the OVNDB process is stop, So the need to re-run the > process up. > if return $OCF_NOT_RUNNING will not demote the node to slave. > > Sig

Re: [ovs-dev] [PATCH] ovn: fix OVNDB process is stopped when master node demote to the slave by pacemaker

2016-12-08 Thread Andy Zhou
On Wed, Dec 7, 2016 at 11:42 PM, Guoshuai Li wrote: > > On 2016/12/8 5:36, Andy Zhou wrote: > > > > On Tue, Dec 6, 2016 at 9:41 PM, Guoshuai Li wrote: > >> When the master node's OVNDB process fails, the local node demote to the >> slave. >> Failure

[ovs-dev] [PATCH] rpms: Remove more OVN files form openvswitch rpm builds

2016-12-08 Thread Andy Zhou
OVN is packaged with openvswitch-fedora.spec.in, but not with openvswitch.spec.in. Remove OVN files from openvswitch.spec.in builds to make rpm build happy. Signed-off-by: Andy Zhou --- rhel/openvswitch.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rhel

Re: [ovs-dev] [PATCH] datapath: Linux 4.9 compat.

2016-12-08 Thread Andy Zhou
next (4.9) and 3.16. > > Signed-off-by: Jarno Rajahalme > Tested building linux 4.0-4.9. Acked-by: Andy Zhou When compiling with 4.0, I got the following warnning. It does not seem to be related to this patch. /home/azhou/projs/ovs/datapath/linux/datapath.c: In function ‘ovs_flow_cm

Re: [ovs-dev] [PATCH] rpms: Remove more OVN files form openvswitch rpm builds

2016-12-09 Thread Andy Zhou
On Fri, Dec 9, 2016 at 11:21 AM, Russell Bryant wrote: > > > On Thu, Dec 8, 2016 at 8:31 PM, Andy Zhou wrote: > >> OVN is packaged with openvswitch-fedora.spec.in, but not with >> openvswitch.spec.in. Remove OVN files from openvswitch.spec.in >> builds to make rpm

[ovs-dev] [RFC: fedora ovn packaging 1/5] rpms: Seperate ovsdb-server into its own package

2016-12-15 Thread Andy Zhou
In case a system is dedicated to run OVN southbound (or northbound) database, It only needs to run ovsdb-server. It would be nice not have to install or run ovs-vswitchd. Signed-off-by: Andy Zhou --- rhel/openvswitch-fedora.spec.in | 55 - 1 file changed

[ovs-dev] [RFC: fedora ovn packaging 0/5] RFC fedora ovn packaging

2016-12-15 Thread Andy Zhou
. ovn-central package is retained to be friendly to single host deployments. However ovn-central service is marked as exclusive with the other three services mentioned above. (I am not sure if this is necessary, and may more confusing than its worth) Andy Zhou (5): rpms: Seperate ovsdb-server into

[ovs-dev] [RFC: fedora ovn packaging 2/5] rpms: Style fixes

2016-12-15 Thread Andy Zhou
Replace a few tabs with spaces in the file to be more consistent with the rest of the file. Signed-off-by: Andy Zhou --- rhel/openvswitch-fedora.spec.in | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel

[ovs-dev] [RFC: fedora ovn packaging 3/5] rhel: Rename nrothd to central service

2016-12-15 Thread Andy Zhou
Future patch will make ovn-northd.server start and stop northd only. Rename the current service as central service to be more consistent with the package name. Signed-off-by: Andy Zhou --- rhel/automake.mk| 2 +- rhel/openvswitch-fedora.spec.in

[ovs-dev] [RFC: fedora ovn packaging 4/5] ovn-ctl: Factor out start/stop ovnsb/ovnnb

2016-12-15 Thread Andy Zhou
Current ovn-ctl starts and stops both southbound and northbound DBs at the same time. Future patches will provide services that start them individually. Signed-off-by: Andy Zhou --- ovn/utilities/ovn-ctl | 55 +++-- ovn/utilities/ovn-ctl.8.xml | 4

[ovs-dev] [RFC: fedora ovn packaging 5/5] rpms: Adding three additional OVN packages

2016-12-15 Thread Andy Zhou
Add ovn-northbound-database, ovn-southbound-database and ovn-northd as packages that can be installed independently. Signed-off-by: Andy Zhou --- rhel/automake.mk | 5 +- rhel/openvswitch-fedora.spec.in| 53 -- rhel

[ovs-dev] [PATCH] ovsdb-idl: Properly handle conditional monitor update error

2016-12-16 Thread Andy Zhou
n addition, the idl should not generate another conditional monitoring update request when there is an outstanding request. So that the requests and their reply are properly serialized. Signed-off-by: Andy Zhou --- lib/ovsdb-idl.c | 31 +++ 1 file changed, 23 i

Re: [ovs-dev] [RFC: fedora ovn packaging 0/5] RFC fedora ovn packaging

2016-12-19 Thread Andy Zhou
On Fri, Dec 16, 2016 at 6:19 PM, Russell Bryant wrote: > > > On Thu, Dec 15, 2016 at 8:35 AM, Andy Zhou wrote: > >> The goal of this series is to make it easier to set up OVN in >> a larger setup, i.e. not having all services running on a single host. >> >>

Re: [ovs-dev] [PATCH v3 01/16] ovn-controller: Don't enable IDL tracking.

2016-12-19 Thread Andy Zhou
- > poll_block(); > if (should_service_stop()) { > exiting = true; > -- > 2.10.2 > > Other than the small nits above, Acked-by: Andy Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/3] ovsdb-idl: Avoid sending redundant conditional monitoring updates

2016-12-20 Thread Andy Zhou
ion update message. Signed-off-by: Andy Zhou --- lib/ovsdb-idl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 1be1c68..218b6b3 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -345,6 +345,7 @@ ovsdb_idl_clear(struct ovsdb_idl *idl)

[ovs-dev] [PATCH 2/3] ovsdb-idl: Properly handle conditional monitor update error

2016-12-20 Thread Andy Zhou
From: andy zhou When generating conditional monitoring update request, current code failed to update idl's 'request-id'. This bug causes the reply message of the update request, regardless an ACK or a NACK, be logged as an unexpected message at the debug level and ignored by the

[ovs-dev] [PATCH 3/3] ovsdb-idl: Enhance conditional monitoring API

2016-12-20 Thread Andy Zhou
To allow client to know when the conditional monitoring changes has been accepted by the OVSDB server and the 'idl' contents has been updated to match the new conditions. Signed-off-by: Andy Zhou --- lib/ovsdb-idl.c| 49 ++--- lib/o

Re: [ovs-dev] [PATCH] ovsdb-idl: Properly handle conditional monitor update error

2016-12-20 Thread Andy Zhou
I have posted an updated version of this patch at: https://patchwork.ozlabs.org/patch/707398/ On Fri, Dec 16, 2016 at 4:55 PM, Andy Zhou wrote: > When generating conditional monitoring update request, current code > failed to update idl's 'request-id'. This bug causes t

Re: [ovs-dev] [RFC: fedora ovn packaging 0/5] RFC fedora ovn packaging

2016-12-20 Thread Andy Zhou
On Tue, Dec 20, 2016 at 8:27 AM, Guru Shetty wrote: > > > On 15 December 2016 at 05:35, Andy Zhou wrote: > >> The goal of this series is to make it easier to set up OVN in >> a larger setup, i.e. not having all services running on a single host. >> >> Curr

Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Properly handle conditional monitor update error

2016-12-22 Thread Andy Zhou
On Thu, Dec 22, 2016 at 9:21 AM, Ben Pfaff wrote: > On Tue, Dec 20, 2016 at 01:47:16AM -0800, Andy Zhou wrote: > > From: andy zhou > > > > When generating conditional monitoring update request, current code > > failed to update idl's 'request-id'. Th

Re: [ovs-dev] [PATCH] OVN: fix OCF symbolic link lost after ovn-common upgrade

2016-12-22 Thread Andy Zhou
On Thu, Dec 22, 2016 at 1:52 AM, Guoshuai Li wrote: > The directory "/usr/lib/ocf/resource.d/ovn/" is only removed on uninstall > and can not be removed while upgrading > > Signed-off-by: Guoshuai Li > Thanks, pushed to master. ___ dev mailing list d.

Re: [ovs-dev] [PATCH] packets: Simplify packet_csum_pseudoheader6().

2016-12-23 Thread Andy Zhou
On Fri, Dec 23, 2016 at 9:06 AM, Ben Pfaff wrote: > It's simpler to make two calls than eight. > > Reported-by: Eelco Chaudron > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou ___ dev mailing list d...@openvswitch.org https://mai

Re: [ovs-dev] [PATCH] ovn: fix data loss after an OVN-DB's backup node promote used pacemaker

2016-12-30 Thread Andy Zhou
ml > > Signed-off-by: Guoshuai Li > Thanks for the patch. Pushed. Acked-by: Andy Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

2017-06-07 Thread Andy Zhou
On Tue, Jun 6, 2017 at 4:55 PM, Ben Pfaff wrote: > On Fri, May 26, 2017 at 08:47:44PM -0700, Andy Zhou wrote: >> There are three methods of translating openflow layer clone action. >> Using datapath clone action, datapath sample action or using actions >> to negating the

Re: [ovs-dev] [PATCH 2/2] xlate: Use datapath clone action for patch port translation

2017-06-07 Thread Andy Zhou
On Tue, Jun 6, 2017 at 5:01 PM, Ben Pfaff wrote: > On Fri, May 26, 2017 at 08:47:45PM -0700, Andy Zhou wrote: >> When available, use datapath 'clone' for patch port translation. >> Clone provides a stronger guarantee that packet will be restored >> after going thr

Re: [ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

2017-06-07 Thread Andy Zhou
On Wed, Jun 7, 2017 at 11:40 AM, Ben Pfaff wrote: > On Wed, Jun 07, 2017 at 11:26:56AM -0700, Andy Zhou wrote: >> On Tue, Jun 6, 2017 at 4:55 PM, Ben Pfaff wrote: >> > On Fri, May 26, 2017 at 08:47:44PM -0700, Andy Zhou wrote: >> >> There are three methods of tr

Re: [ovs-dev] [PATCH v2] dp-packet: Copy trunc flag on batch clone.

2017-07-03 Thread Andy Zhou
work for dpdk ports in case batch clone > occured because invoked by the 'dp_packet_batch_apply_cutlen()'. > > CC: Andy Zhou > Fixes: 72c84bc2db23 ("dp-packet: Enhance packet batch APIs.") > Signed-off-by: Ilya Maximets

Re: [ovs-dev] OVSDB Replication: Clarifications required

2017-07-10 Thread Andy Zhou
On Tue, Jul 4, 2017 at 10:52 PM, Arunkumar Rg wrote: > Hi, > > Got few clarifications on OVSDB replication. Please let me know your inputs > on it. > > 1. From the ovsdb-server code(main_loop()), it seems that the standby > ovsdb-server becomes 'Active' if the JSONRPC session with the > active-ovs

Re: [ovs-dev] [PATCH] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

2017-07-12 Thread Andy Zhou
On Tue, Jul 11, 2017 at 7:30 AM, Ilya Maximets wrote: > If RSS hash exists in a packet it can be reused instead of > 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This > leads to increasing the performance of sending packets to > the OVS bonding in userspace datapath up to 10-15%. > > Signe

Re: [ovs-dev] [PATCH 5/6] test-conntrack: Fix dead store reported by clang.

2017-07-12 Thread Andy Zhou
> > Even with this change, batch_size is a write-only variable. Nothing > ever uses it. > > I think that the right fix is something more like this. I have not > tested it. > > Andy, it looks like you made the previous change here, does this make > sense? I think thi

Re: [ovs-dev] [PATCH v2] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

2017-07-13 Thread Andy Zhou
On Thu, Jul 13, 2017 at 8:07 AM, Ilya Maximets wrote: > If RSS hash exists in a packet it can be reused instead of > 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This > leads to increasing the performance of sending packets to > the OVS bonding in userspace datapath up to 10-15%. > > Addit

Re: [ovs-dev] [PATCH] dp-packet: Remove misleading comment for refill init function.

2017-07-14 Thread Andy Zhou
tent with other comments in the same file. > > CC: Andy Zhou > Fixes: 72c84bc2db23 ("dp-packet: Enhance packet batch APIs.") > Signed-off-by: Ilya Maximets Thanks. Applied. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] OVSDB Replication: Clarifications required

2017-07-17 Thread Andy Zhou
On Sat, Jul 15, 2017 at 10:58 PM, Arunkumar Rg wrote: > Hi Andy Zhou, > > Thanks for looking into this! > > Please find my replies inline: > > On Tue, Jul 11, 2017 at 1:30 AM, Andy Zhou wrote: >> >> On Tue, Jul 4, 2017 at 10:52 PM, Arunkumar Rg >

[ovs-dev] [clone optmization 0/7] Clone optimization

2017-07-20 Thread Andy Zhou
part of the native tunneling work. I plan to work on it after this series has been reviewed, and after the dust settles with the native tunneling patch series. Andy Zhou (7): ofproto-dpif: A new command for changing dpif support fields ofproto-dpif: Add boottime support field. ofproto-dpif

[ovs-dev] [clone optmization 1/7] ofproto-dpif: A new command for changing dpif support fields

2017-07-20 Thread Andy Zhou
new command also allow the support fields to be changed multiple times. Currently defeature commands does not allow the support level to be restored. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif.c | 133 + 1 file changed, 133 insertions

[ovs-dev] [clone optmization 2/7] ofproto-dpif: Add boottime support field.

2017-07-20 Thread Andy Zhou
support fields are the same as boot time support fields at the startup time, but can be changed via the 'ovs-appctl' command. However, each change will be checked against the corresponding boot time support field. Only feature reduction from the boot time support is allowed. Signed-off-by:

[ovs-dev] [clone optmization 3/7] ofproto-dpif: Remove dpif/disable-dp-clone command.

2017-07-20 Thread Andy Zhou
Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif-xlate.c | 11 --- ofproto/ofproto-dpif-xlate.h | 1 - ofproto/ofproto-dpif.c | 24 tests/ofproto-dpif.at| 4 +--- 4 files changed, 1 insert

[ovs-dev] [clone optmization 4/7] ofproto-dpif: Remove dpif/disable-truncate command.

2017-07-20 Thread Andy Zhou
Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif.c | 21 - tests/system-traffic.at | 8 ++-- 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index ff

[ovs-dev] [clone optmization 5/7] ofproto-dpif: Remove ofprto/tnl-push-pop command.

2017-07-20 Thread Andy Zhou
Use dpif/set-dp-features command instead. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif.c | 34 -- tests/ofproto-macros.at | 5 ++--- 2 files changed, 2 insertions(+), 37 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index

[ovs-dev] [clone optmization 6/7] xlate: Refactor compose_clone() API

2017-07-20 Thread Andy Zhou
Create a new function that hides the details of netlink encoding for the translated clone action. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif-xlate.c | 76 +++- tests/ofproto-dpif.at| 7 2 files changed, 39 insertions(+), 44 deletions

[ovs-dev] [clone optmization 7/7] xlate: Emit datapath clone only when necessary.

2017-07-20 Thread Andy Zhou
a single compose_clone() API, since the layering boundary is not obvious. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif-xlate.c | 169 --- tests/ofproto-dpif.at| 39 +- 2 files changed, 164 insertions(+), 44 deletions(-) diff --git

Re: [ovs-dev] [PATCH v2] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

2017-07-20 Thread Andy Zhou
> Acked-by: Darrell Ball Thanks llya for the patch and Darrell for the review! Pushed to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Fwd: [PATCH] bond: Unify hash functions in hash action and entry lookup.

2017-07-21 Thread Andy Zhou
Add dev mailing list. It got dropped by accident. -- Forwarded message -- From: Andy Zhou Date: Fri, Jul 21, 2017 at 2:14 PM Subject: Re: [PATCH] bond: Unify hash functions in hash action and entry lookup. To: Ilya Maximets As it turns out, we can go even further: Notice

Re: [ovs-dev] [PATCH 1/3] flow: Add packet_size option to flow_compose.

2017-07-21 Thread Andy Zhou
On Wed, Jul 19, 2017 at 7:51 AM, Ilya Maximets wrote: > This allows to compose packets with different real lenghts from > odp flows i.e. memory will be allocated for requested packet > size and all required headers like ip->tot_len filled correctly. > > Will be used in netdev-dummy to properly han

[ovs-dev] [clone optmization v2 0/7] Clone optimization

2017-07-21 Thread Andy Zhou
part of the native tunneling work. I plan to work on it after this series has been reviewed, and after the dust settles with the native tunneling patch series. --- V1->V2: Fixed system test failures notice by Joe. Andy Zhou (7): ofproto-dpif: A new command for changing dpif support fie

[ovs-dev] [clone optmization v2 1/7] ofproto-dpif: A new command for changing dpif support fields

2017-07-21 Thread Andy Zhou
new command also allow the support fields to be changed multiple times. Currently defeature commands does not allow the support level to be restored. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif.c | 134 + 1 file changed, 134 insertions

[ovs-dev] [clone optmization v2 3/7] ofproto-dpif: Remove dpif/disable-dp-clone command.

2017-07-21 Thread Andy Zhou
Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif-xlate.c | 11 --- ofproto/ofproto-dpif-xlate.h | 1 - ofproto/ofproto-dpif.c | 24 tests/ofproto-dpif.at| 4 +--- 4 files changed, 1 insert

[ovs-dev] [clone optmization v2 2/7] ofproto-dpif: Add boottime support field.

2017-07-21 Thread Andy Zhou
support fields are the same as boot time support fields at the startup time, but can be changed via the 'ovs-appctl' command. However, each change will be checked against the corresponding boot time support field. Only feature reduction from the boot time support is allowed. Signed-off-by:

[ovs-dev] [clone optmization v2 4/7] ofproto-dpif: Remove dpif/disable-truncate command.

2017-07-21 Thread Andy Zhou
Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif.c | 21 - tests/system-traffic.at | 8 ++-- 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 13

[ovs-dev] [clone optmization v2 5/7] ofproto-dpif: Remove ofprto/tnl-push-pop command.

2017-07-21 Thread Andy Zhou
Use dpif/set-dp-features command instead. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif.c | 34 -- tests/ofproto-macros.at | 5 ++--- 2 files changed, 2 insertions(+), 37 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index

[ovs-dev] [clone optmization v2 6/7] xlate: Refactor compose_clone() API

2017-07-21 Thread Andy Zhou
Create a new function that hides the details of netlink encoding for the translated clone action. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif-xlate.c | 76 +++- tests/ofproto-dpif.at| 7 2 files changed, 39 insertions(+), 44 deletions

[ovs-dev] [clone optmization v2 7/7] xlate: Emit datapath clone only when necessary.

2017-07-21 Thread Andy Zhou
a single compose_clone() API, since the layering boundary is not obvious. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif-xlate.c | 169 --- tests/ofproto-dpif.at| 39 +- 2 files changed, 164 insertions(+), 44 deletions(-) diff --git

Re: [ovs-dev] OVSDB Replication: Clarifications required

2017-07-21 Thread Andy Zhou
> > Arun: The issue I see with multiple ovsdb-servers being 'active' at the same > time > is - controller doesn't recognize these scenario and hence there is an > intermittent state > wherein the behavior is undefined. So if I have to make a patch, I'm > thinking to add > an option wherein we say s

Re: [ovs-dev] [PATCH 1/3] flow: Add packet_size option to flow_compose.

2017-07-24 Thread Andy Zhou
On Mon, Jul 24, 2017 at 6:33 AM, Ilya Maximets wrote: > On 22.07.2017 01:38, Andy Zhou wrote: >> On Wed, Jul 19, 2017 at 7:51 AM, Ilya Maximets >> wrote: >>> This allows to compose packets with different real lenghts from >>> odp flows i.e. memory will be alloca

Re: [ovs-dev] Fwd: [PATCH] bond: Unify hash functions in hash action and entry lookup.

2017-07-24 Thread Andy Zhou
On Sat, Jul 22, 2017 at 2:02 PM, Darrell Ball wrote: > > > -Original Message- > From: on behalf of Andy Zhou > Date: Friday, July 21, 2017 at 2:17 PM > To: "" > Subject: [ovs-dev] Fwd: [PATCH] bond: Unify hash functions in hash action > and ent

Re: [ovs-dev] Fwd: [PATCH] bond: Unify hash functions in hash action and entry lookup.

2017-07-24 Thread Andy Zhou
On Mon, Jul 24, 2017 at 9:23 AM, Ilya Maximets wrote: > On 23.07.2017 00:02, Darrell Ball wrote: >> >> >> -Original Message- >> From: on behalf of Andy Zhou >> >> Date: Friday, July 21, 2017 at 2:17 PM >> To: "" >> Subje

[ovs-dev] [PATCH] bond: Adjust bond hash masks

2017-07-25 Thread Andy Zhou
Commit 42781e77035d (bond: Unify hash functions in hash action and entry lookup.) changed the BM_TCP's hash function, but did not update hash mask fields accordingly. Found by inspection. CC: Ilya Maximets Signed-off-by: Andy Zhou --- ofproto/bond.c | 5 +++-- 1 file changed, 3 inser

Re: [ovs-dev] [PATCH v2 1/3] vswitch.xml: Fix L2 balancing mentioning for balance-tcp bond.

2017-07-25 Thread Andy Zhou
Thanks. I have pushed the series to master. While applying the patches. I noticed a minor issue and sent a follow up patch at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336231.html Will consider back porting after this patch is reviewed. On Tue, Jul 25, 2017 at 3:46 AM, Ilya Maxi

[ovs-dev] [PATCH] flow: Refactor flow_compose() API.

2017-07-25 Thread Andy Zhou
error detection and reporting when 'size' is unreasonably small. Signed-off-by: Andy Zhou --- lib/flow.c | 53 ++-- lib/flow.h | 3 +-- lib/netdev-dummy.c | 7 -- ofproto/ofproto-dpif-trace.c |

Re: [ovs-dev] [PATCH v2 1/3] flow: Add flow_compose_size().

2017-07-25 Thread Andy Zhou
-dummy to properly handle '--len' option. > > Suggested-by: Andy Zhou > Signed-off-by: Ilya Maximets > --- Thanks for the bug fixes. I have pushed this series to master. I think the readability can be further improved. I have a follow up patch at: https://mail.openvswitch.org

Re: [ovs-dev] [PATCH] bond: Adjust bond hash masks

2017-07-26 Thread Andy Zhou
On Wed, Jul 26, 2017 at 12:06 AM, Ilya Maximets wrote: > On 25.07.2017 21:39, Andy Zhou wrote: >> Commit 42781e77035d (bond: Unify hash functions in hash action and entry >> lookup.) changed the BM_TCP's hash function, but did not update >> hash mask fields accordi

Re: [ovs-dev] [PATCH v2 1/3] vswitch.xml: Fix L2 balancing mentioning for balance-tcp bond.

2017-07-26 Thread Andy Zhou
On Tue, Jul 25, 2017 at 11:44 AM, Andy Zhou wrote: > Thanks. I have pushed the series to master. > > While applying the patches. I noticed a minor issue and sent a follow > up patch at: > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336231.html > > Will con

Re: [ovs-dev] [PATCH] system-userspace-macros: Fix ethtool with new kernels.

2017-07-26 Thread Andy Zhou
t; fail the test due to the above. > > Signed-off-by: Joe Stringer LGTM. Acked-by: Andy Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

<    1   2   3   4