happened even if the log rotates, etc.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 30 Aug 2023, at 19:56, Aaron Conole wrote:
> In the past, during some conntrack testing a bug was uncovered in a DPDK
> PMD which didn't support an IPv4 packet with a zero checksum value.
> In order to show that the connection tracking code in userspace
> supports IPv4 UDP with a zero
t;
> Signed-off-by: Ilya Maximets
This changes looks good, and had no side effects on my systems.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 30 Aug 2023, at 11:13, Robin Jarry wrote:
> David Marchand, Aug 30, 2023 at 11:11:
>>> warnings.filterwarnings("ignore", r"(blowfish|cast5)", UserWarning)
>>
>> It means waiving more warnings than before, but I don't think it
>> really matters for this script.
>> No strong opinion against
s.
>
> Fixes: c3ed0bf34b8a ("tests/mfex: Silence Blowfish/CAST5 deprecation
> warnings.")
> Signed-off-by: David Marchand
Thanks for fixing this, verified with and without the lib installed (and
flake8)!
Cheers,
Eelco
Acked-by: Eelco Chaudron
On 25 Aug 2023, at 16:47, David Marchand wrote:
> On Wed, Aug 23, 2023 at 5:35 PM David Marchand
> wrote:
>> diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
>> index a72133fae1..de126946a0 100644
>> --- a/tests/system-dpdk-macros.at
>> +++ b/tests/system-dpdk-macros.at
On 25 Aug 2023, at 15:46, Ilya Maximets wrote:
> On 8/24/23 17:19, David Marchand wrote:
>> As reported by Ales when doing some OVN integration tests with OVS 3.2,
>> net/tap has broken L4 checksum offloads.
>>
>> Fixes are pending on DPDK side.
>> Until they get in a LTS release used by OVS,
On 25 Aug 2023, at 13:34, David Marchand wrote:
> On Fri, Aug 25, 2023 at 12:57 PM Eelco Chaudron wrote:
>>>
>>> +m4_define([OVS_DPDK_STOP_VSWITCHD],
>>> + [OVS_VSWITCHD_STOP([dnl
>>> +$1";/does not exist. The Open vSwitch kernel module is probab
On 23 Aug 2023, at 17:34, David Marchand wrote:
> As reported by Ales, net/tap has broken support for checksum offloading.
> Fixes have been sent to the DPDK side, but waiting for the fixes, simply
> disable all conntrack related tests and some IPv6 tunnel tests.
>
> Signed-off-by: David
>
> Signed-off-by: David Marchand
Thanks for the patch, this one looks good to me, and tested it in combination
with the ‘dpdk test patch series’.
Acked-by: Eelco Chaudron
> ---
> lib/netdev-dpdk.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/lib/netde
and it
was working fine.
Anyhow I’ll include my Acked-by flag, assuming it will pass the autopkgtest
mentioned by Ilya (guess you need another revision anyway :)
Acked-by: Eelco Chaudron
> ---
> tests/system-dpdk-macros.at| 85 +-
> tests/syste
On 23 Aug 2023, at 17:34, David Marchand wrote:
> Align system-dpdk existing helpers to other common OVS helpers so they
> can accept some optional arguments.
>
> Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to
> catch dpdk related logs in a centralised fashion.
>
>
en in system-dpdk tests) and
> use them in the existing tests.
>
> Signed-off-by: David Marchand
These changes also look good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
s.
> Add a DPDK_EAL_OPTIONS environment variable and use it to map all
> testpmd lcores to core 1 (and leave core 0 alone for OVS main and PMD
> threads).
>
> Signed-off-by: David Marchand
> Acked-by: Aaron Conole
Changes look good to me!
Acked-by: Eelco Chaudron
_
.
>
> Switch to --in-memory, use dynamic allocations and remove the then
> unneeded check on hugetlbfs presence.
>
> Signed-off-by: David Marchand
> Acked-by: Aaron Conole
Thanks for the patch, this one looks good to me.
Acked-by: Eelco Chaudron
gned-off-by: David Marchand
> Acked-by: Aaron Conole
> ---
> Changes since v1:
> - fixed OVS_DPDK_START_TESTPMD passed arguments evaluation:: $@ -> $1,
Thanks for sending out this series! This patch looks good to me.
Acked-by: Eelco Chaudron
_
key initialized by
> netdev_flow_key_init() is not used, so this error will not cause any
> bad behavior for now.
>
> Fixes: c82f496c3b69 ("dpif-netdev: Use unmasked key when adding datapath
> flows.")
> Signed-off-by: Zhiqi Chen
Thanks for fixing this issue, the changes
er="reason >= 0x3"
>0.000 ping/1275884 skb:kfree_skb(skbaddr: 0x8acd76546000, \
> location: 0xc0ee3634, protocol: 2048, reason: 196611)
>
> Signed-off-by: Eric Garver
This patch looks good to me. Tested with and without the kernel patches applied
(use
On 9 Aug 2023, at 16:42, Eric Garver wrote:
> Kernel support is being added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
Some comments below…
Cheers,
Eelco
> ---
> include/linux/openvswitch.h | 2 +-
> lib/dpif.c |
by: Eric Garver
Thanks for the patch, and sorry for the late response (due to PTO), but this
one looks good.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
len
> Reviewed-by: Simon Horman
These changes look good to me, one request to Ilya to double-check the ovsdb
asserts.
Acked-by: Eelco Chaudron
> ---
> lib/dp-packet.c| 1 +
> lib/odp-execute.c | 4
> lib/rtnetlink.c| 4 ++--
> lib/shash.c| 2
On 3 Aug 2023, at 18:19, James Raphael Tiovalen wrote:
> This commit adds various null pointer checks to some files in the `lib`,
> `ovsdb`, and `vtep` directories to fix several Coverity defects. These
> changes are grouped together as they perform similar checks, returning
> early, skipping
On 3 Aug 2023, at 18:19, James Raphael Tiovalen wrote:
> This commit adds zero-initializations by changing `SFL_ALLOC` from
> `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`,
> initializing a `pollfd` struct variable with zeroes, and changing some
> calls to `xmalloc` to `xzalloc`.
On 3 Aug 2023, at 18:19, James Raphael Tiovalen wrote:
> This commit adds some `ovs_assert()` checks to some return values of
> `dp_packet_data()` to ensure that they are not NULL and to prevent
> null-pointer dereferences, which might lead to unwanted crashes. We use
> assertions since it
On 24 Aug 2023, at 8:56, David Marchand wrote:
> On Wed, Aug 23, 2023 at 5:35 PM David Marchand
> wrote:
>>
>> Integrate system-traffic.at tests as part of check-dpdk.
>
> CI (thinking of Intel robot) other than GHA might not be too happy
> about this change.
> It is hard to tell what fails in
| 4 ++--
> 7 files changed, 29 insertions(+), 9 deletions(-)
All the changes look good, and they build fine on my setup.
For the series:
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 22 Aug 2023, at 11:28, David Marchand wrote:
> Following support of L3 and L4 checksum offloading, some bugs have been
> raised in different DPDK drivers.
So to clarify this a bit more we see issues with OVS 3.2 and the i40e vf driver
and net/tap driver.
Mike can you take a look at this
-by: Eelco Chaudron
---
utilities/automake.mk |4
utilities/usdt-scripts/kernel_delay.py | 1397 +++
utilities/usdt-scripts/kernel_delay.rst | 594 +
3 files changed, 1995 insertions(+)
create mode 100755 utilities/usdt-scripts
On 17 Aug 2023, at 15:25, Ilya Maximets wrote:
> According to our release process, it's time to release v3.2.0!
>
> Ilya Maximets (2):
> Set release date for 3.2.0.
> Prepare for 3.2.1.
Ack on the series!
Acked-by: Eelco Chaudron
On 16 Aug 2023, at 4:00, Peng He wrote:
> Hi, Eelco,
>
> could you take a look at this patch?
Hi Peng, yes it’s on my TODO list, but it might be a while as I’m recovering
from three weeks of PTO ;)
//Eelco
>
> Zhiqi Chen via dev 于2023年8月13日周日 17:09写道：
>
>> The 'len' of a netdev_flow_key
On 15 Aug 2023, at 13:18, Eelco Chaudron wrote:
> On 15 Aug 2023, at 11:06, Peng He wrote:
>
>> Do I need to send a new version to fix the indentation?
>
> Nope, I’ll fix it when committing the patch. Will be later this week, as I
> need to catch up on some email etc.
On 15 Aug 2023, at 11:06, Peng He wrote:
> Do I need to send a new version to fix the indentation?
Nope, I’ll fix it when committing the patch. Will be later this week, as I need
to catch up on some email etc.
//Eelco
> Eelco Chaudron 于2023年8月15日周二 15:40写道：
>
>>
>>
>
On 27 Jul 2023, at 12:53, Ilya Maximets wrote:
> On 7/27/23 04:16, Peng He wrote:
>>
>>
>> Simon Horman mailto:simon.hor...@corigine.com>>
>> 于2023年7月27日周四 01:04写道：
>>
>> On Thu, Jul 06, 2023 at 04:59:36PM +0800, Peng He wrote:
>>
>> ...
>>
>> > +dnl Replace OpenFlow rules,
nel support.")
> Signed-off-by: Ilya Maximets
This change looks good to me!
Acked-by: Eelco Chaudron
> ---
> tests/system-traffic.at | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tests/system-traffic.at b/tests/system-traffic.at
>
l side effects of this change.
I did run all the dp tests, with and without ASAN, and no problems were found.
With the above side note,
Acked-by: Eelco Chaudron
Cheers,
Eelco
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
lt case from reset_mirror_ctx()
> v5: Added prereq check for set-field
> v6: Removed wc modification from pre-req check
>
> Signed-off-by: Mike Pattrick
Thanks for making the additional changes. This patch looks good to me.
Acked-by: Eelco Chaudron
___
on the on-exit kill.
>
> Fixes: 759a29dc2d97 ("backtrace: Extend the backtrace functionality.")
> Signed-off-by: Ilya Maximets
This looks good to me. Thanks for digging into this it will save on the manual
re-runs ;)
Acked-by: Eelco Chaudron
_
ay.
>
> Fixes: fe13ccdca6a2 ("vswitchd: Add --cleanup option to the 'appctl exit'
> command")
> Signed-off-by: Ilya Maximets
Thanks Ilya for the v2, and catching the exit_args.exiting update :)
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 17 Jul 2023, at 15:22, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
Changes look good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 17 Jul 2023, at 15:22, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
Changes look good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
de the reviews as all
patches should now have my ack!
Cheers,
Eelco
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
d.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2137567
> Signed-off-by: Adrian Moreno
Thanks Adrian for making all the suggested changes!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 15 Jul 2023, at 4:49, miter wrote:
> Thank you for your reply.
>
> On 7/14/2023 11:01 PM, Ilya Maximets wrote:
>> On 7/14/23 14:20, Eelco Chaudron wrote:
>>>
>>> On 14 Jul 2023, at 13:52, Eelco Chaudron wrote:
>>>
>>>> On 1 Jul 2023, at
Send from my phone
> Op 15 jul. 2023 om 06:01 heeft miter het volgende
> geschreven:
>
> Hi Eelco,
>
>> On 7/14/2023 9:18 PM, Eelco Chaudron wrote:
>>
>>> On 14 Jul 2023, at 13:34, Ilya Maximets wrote:
>>>
>>> On 7/14/23 12:42, Ee
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress
> and egress side in kernel datapath. But the userspace datapath dosen't
> support for ingress and egress packet-per-second policing now.
>
> So,
On 14 Jul 2023, at 13:46, Ilya Maximets wrote:
> On 7/14/23 13:03, Eelco Chaudron wrote:
>>
>>
>> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>>
>>> From: Lin Huang
>>>
>>> Now srtcm_policer will free pkts, if packets are
On 14 Jul 2023, at 13:34, Ilya Maximets wrote:
> On 7/14/23 12:42, Eelco Chaudron wrote:
>>
>>
>> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>>
>>> From: Lin Huang
>>>
>>> Now, token-bucket 'last_fill' is updated by token_bucket_wi
On 14 Jul 2023, at 13:52, Eelco Chaudron wrote:
> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>
>> From: Lin Huang
>>
>> OvS has supported packet-per-second policer which can be set at ingress
>> and egress side in kernel datapath. But the userspa
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress
> and egress side in kernel datapath. But the userspace datapath doesn't
> support for ingress and egress packet-per-second policing now.
>
> So,
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
> From: Lin Huang
>
> Now srtcm_policer will free pkts, if packets are exceed rate limit.
> This patch change srtcm_policer not to free pkts, just count dropped packets.
>
Thanks for this patch Lin, however, this patch is wrongly freeing
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
> From: Lin Huang
>
> Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
> Add a new function parameter 'now' to update timestamp by caller.
>
> Signed-off-by: Lin Huang
Thank for the patch Lin,
However what about
On 13 Jul 2023, at 15:15, Eelco Chaudron wrote:
> On 13 Jul 2023, at 15:10, Ilya Maximets wrote:
>
>> On 7/12/23 15:37, Mike Pattrick wrote:
>>> Several xlate actions used in recursive translation currently store a
>>> large amount of information on the sta
ion.
>>
>> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
>> Signed-off-by: Mike Pattrick
>> Reviewed-by: Simon Horman
>> Acked-by: Eelco Chaudron
>>
>> ---
>> Since v1:
>> - Refactored code into specialized functions a
On 12 Jul 2023, at 0:34, Ilya Maximets wrote:
> On 7/11/23 12:05, Eelco Chaudron wrote:
>>
>>
>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>
>>> This commit adds assertions in the functions `shash_count`,
>>> `simap_count`, and `smap_
ng the rate function to the previous patch.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 12 Jul 2023, at 9:02, Adrian Moreno wrote:
> Instead of relying on feature bits, use the speed value directly as
> maximum rate for htb and hfsc classes.
>
> There is still a limitation with the maximum rate that we can express
> with a 32-bit number in bytes/s (~ 34.3Gbps), but using the
On 12 Jul 2023, at 9:02, Adrian Moreno wrote:
> Currently, the netdev's speed is being calculated by taking the link's
> feature bits (using netdev_get_features()) and transforming them into
> bps.
>
> This mechanism can be both inaccurate and difficult to maintain, mainly
> because we
bit rate.
>
> Also use 64bits for other burst buffer calculation functions.
>
> Signed-off-by: Adrian Moreno
Thanks Adrian for making the v3 changes. This looks good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitc
On 12 Jul 2023, at 9:02, Adrian Moreno wrote:
> Use TCA_POLICE_RATE64 if the rate cannot be expressed using 32bits.
>
> This breaks the 32Gbps barrier. The new barrier is ~4Tbps caused by
> netdev's API expressing kbps rates using 32-bit integers.
>
> Acked-by: Eelco Ch
> Signed-off-by: Mike Pattrick
> Reviewed-by: Simon Horman
> Acked-by: Eelco Chaudron
Thanks Mike for taking care of the additional nit.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 11 Jul 2023, at 22:10, Chandan Somani wrote:
> On Tue, Jul 11, 2023 at 12:38 AM Eelco Chaudron wrote:
>
>>
>>
>> On 7 Jul 2023, at 22:07, Chandan Somani wrote:
>>
>>> This narrows down spelling errors that are in the commit
>>> subject.
On 11 Jul 2023, at 16:38, Ilya Maximets wrote:
> On 7/11/23 12:17, Eelco Chaudron wrote:
>>
>>
>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>
>>> This commit adds non-null pointer assertions in some code that performs
>>> some de
On 11 Jul 2023, at 16:33, Ilya Maximets wrote:
> On 7/11/23 12:13, Eelco Chaudron wrote:
>>
>>
>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>
>>> This commit adds a few null pointer assertions and checks to some return
>>> values
> Signed-off-by: Mike Pattrick
> Reviewed-by: Simon Horman
Thanks Mike, however, I guess this was supposed to be v6, as it got me confused
;)
Small nit below, the rest looks good.
Acked-by: Eelco Chaudron
> ---
> Since v1:
> - Refactored code into specialized functions and
that is sent for output.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
> Signed-off-by: Mike Pattrick
Thanks Mike for fixing my v3 comments. This patch looks good to me.
Acked-by: Eelco Chaudron
> ---
> v2: Refactored all code into a single function
> v3: Cleaned up a
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This patch adds an assortment of `ovs_assert` statements to check for
> null pointers. We use assertions since it should be impossible for any
> of these pointers to be NULL.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by:
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds various null pointer checks to some files in the `lib`
> and the `ovsdb` directories to fix several Coverity defects. These
> changes are grouped together as they perform similar checks, returning
> early or skipping
Thank for fixing this James, this patch looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds non-null pointer assertions in some code that performs
> some decisions based on old and new input ovsdb_rows.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by: Simon Horman
What about error messages/argument
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds a few null pointer assertions and checks to some return
> values of `ovsdb_table_schema_get_column`. If a null pointer is
> encountered in these blocks, either the assertion will fail or the
> control flow will now be
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds assertions in the functions `shash_count`,
> `simap_count`, and `smap_count` to ensure that the corresponding input
> struct pointer is not NULL.
>
> This ensures that if the return values of `shash_sort`, `simap_sort`,
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds zero-initializations by changing `SFL_ALLOC` from
> `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`,
> initializing a `pollfd` struct variable with zeroes, and changing some
> calls to `xmalloc` to
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This commit adds some `ovs_assert()` checks to some return values of
> `dp_packet_data()` to ensure that they are not NULL and to prevent
> null-pointer dereferences, which might lead to unwanted crashes. We use
> assertions since it
On 7 Jul 2023, at 22:07, Chandan Somani wrote:
> This narrows down spelling errors that are in the commit
> subject. In v2, it also provides a subject if the subject
> line is missing. The provisional subject is the name of the
> patch file, which should provide some context about the patch.
>
s good, thank Chandan.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
n’t worry about it for this series. I will fix it on commit.
Acked-by: Eelco Chaudron
> ---
v2: Fixed syntax error in length comparison.
> utilities/checkpatch.py | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/utilities/checkpatch.py b/utilities/c
t; error is printed, then it is likely that the change was not
> functional anyway.
>
> Reported-at: https://bugzilla.redhat.com/1731553
> Signed-off-by: Flavio Leitner
Thanks Flavio for the patch. I verified the Windows part trough AppVeyor.
Acked-by: Eelco Chaudron
On 10 Jul 2023, at 16:26, Adrian Moreno wrote:
> On 7/10/23 16:19, Adrian Moreno wrote:
>>
>>
>> On 7/6/23 14:50, Eelco Chaudron wrote:
>>>
>>>
>>> On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
>>>
>>>> Instead of relyi
On 7 Jul 2023, at 17:04, Ilya Maximets wrote:
> On 7/6/23 18:22, Eelco Chaudron wrote:
>>
>>
>> On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
>>
>>> Use TCA_POLICE_RATE64 if the rate cannot be expressed using 32bits.
>>>
>>> This break
On 7 Jul 2023, at 16:48, Ilya Maximets wrote:
> On 7/7/23 16:42, Eelco Chaudron wrote:
>>
>>
>> On 7 Jul 2023, at 16:06, Ilya Maximets wrote:
>>
>>> On 7/7/23 15:51, Eric Garver wrote:
>>>> On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron
On 7 Jul 2023, at 16:06, Ilya Maximets wrote:
> On 7/7/23 15:51, Eric Garver wrote:
>> On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote:
>>>
>>>
>>> On 7 Jul 2023, at 13:08, Ilya Maximets wrote:
>>>
>>>> On 7/5/23 21:47, Ee
On 7 Jul 2023, at 14:19, Ilya Maximets wrote:
> On 7/7/23 14:12, Eelco Chaudron wrote:
>>
>>
>> On 7 Jul 2023, at 12:58, Ilya Maximets wrote:
>>
>>> On 7/5/23 15:54, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 4 Jul 2
On 7 Jul 2023, at 14:25, Ilya Maximets wrote:
> On 7/7/23 14:11, Eelco Chaudron wrote:
>>
>>
>> On 7 Jul 2023, at 13:03, Ilya Maximets wrote:
>>
>>> On 7/6/23 11:30, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 30 Jun 2023
On 7 Jul 2023, at 12:58, Ilya Maximets wrote:
> On 7/5/23 15:54, Eelco Chaudron wrote:
>>
>>
>> On 4 Jul 2023, at 15:11, Ilya Maximets wrote:
>>
>>> Before the cleanup option, the bridge_exit() call was fairly fast,
>>> because it didn't inclu
On 7 Jul 2023, at 13:03, Ilya Maximets wrote:
> On 7/6/23 11:30, Eelco Chaudron wrote:
>>
>>
>> On 30 Jun 2023, at 21:05, Eric Garver wrote:
>>
>> Hi Eric,
>>
>> I guess some description here would be good. Maybe add some info that this
On 7 Jul 2023, at 13:08, Ilya Maximets wrote:
> On 7/5/23 21:47, Eelco Chaudron wrote:
>>
>>
>> On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote:
>>
>> On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote:
>> >
>> >
&
On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
> Use TCA_POLICE_RATE64 if the rate cannot be expressed using 32bits.
>
> This breaks the 32Gbps barrier. The new barrier is ~4Tbps caused by
> netdev's API expressing kbps rates using 32-bit integers.
>
> Reported-at:
Reviewed-by: Simon Horman
> Signed-off-by: Adrian Moreno
Thanks Adrian, this patch looks good to me.
Acked-by: Eelco Chaudron
//Eelco
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
> It is equivalent to tc_policer_init() so remove the duplicated function.
>
> Reviewed-by: Simon Horman
> Signed-off-by: Adrian Moreno
Thanks for cleaning this up!
Acked-by: Eelco Chaudr
On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
> Currently, htb rates are capped at ~34Gbps because they are internally
> expressed as 32-bit fields.
>
> Move min and max rates to 64-bit fields and use TCA_HTB_RATE64 and
> TCA_HTB_CEIL64 to configure HTC classes to break this barrier.
>
> In
On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
> tc uses these "rtab" tables to estimate the time (ticks) that it takes
> to send a packet of different sizes. In preparation for the introduction
> of 64-bit rates, add an argument to tc_put_rtab() to allow an external
> 64-bit rate.
This patch
On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
> Instead of relying on feature bits, use the speed value directly as
> maximum rate for htb and hfsc classes.
>
> There is still a limitation with the maximum rate that we can express
> with a 32-bit number in bytes/s (~ 34.3Gbps), but using the
On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
> Currently, the netdev's speed is being calculated by taking the link's
> feature bits (using netdev_get_features()) and transforming them into
> bps.
>
> This mechanism can be both inaccurate and difficult to maintain, mainly
> because we
On 30 Jun 2023, at 21:05, Eric Garver wrote:
Hi Eric,
I guess some description here would be good. Maybe add some info that this is
added due to kernel support being added.
In general, the patch looks good, and I would ack it. However, there is a
potential issue with TC hardware offload.
On 30 Jun 2023, at 21:05, Eric Garver wrote:
> This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
> action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
> to make -Werror happy we must add a case to all existing switches.
>
> Signed-off-by: Eric Garver
>
On 6 Jul 2023, at 4:32, Peng He wrote:
> Eelco Chaudron 于2023年7月5日周三 22:16写道：
>
>>
>>
>> On 1 Jul 2023, at 4:43, Peng He wrote:
>>
>>> OVS allows overlapping megaflows, as long as the actions of these
>>> megaflows are equal. However, the c
On 6 Jul 2023, at 4:33, Peng He wrote:
> Eelco Chaudron 于2023年7月5日周三 21:24写道：
>
>>
>>
>> On 1 Jul 2023, at 7:11, Peng He wrote:
>>
>>> push_dp_ops only handles delete ops errors but ignores the modify
>>> ops results. It's better to handle all
On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote:
> On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote:
> >
> >
> > On 30 Jun 2023, at 21:05, Eric Garver wrote:
> > Hi Eric,
> >
> > I started reviewing the series, and this test was failing ev
On 30 Jun 2023, at 21:05, Eric Garver wrote:
Hi Eric,
I started reviewing the series, and this test was failing every other run for
me on ‘check-system-userspace’. I ended up making the following additional
change:
diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at
index
On 5 Jul 2023, at 16:16, Eelco Chaudron wrote:
> On 1 Jul 2023, at 4:43, Peng He wrote:
>
>> OVS allows overlapping megaflows, as long as the actions of these
>> megaflows are equal. However, the current implementation of action
>> modification relies on flow_lookup ins
501 - 600 of 2699 matches
Mail list logo
