Re: [ovs-dev] [PATCH 15/15] ovsdb: Introduce experimental support for clustered databases. (1/2)

> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: I still haven't finished, but I think there are a few items you could start looking at while I finish the review later today. > diff --git a/Documentation/ref/ovsdb.5.rst b/Documentation/ref/ovsdb.5.rst > index

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Feb 16, 2018, at 12:52 AM, Pravin Shelar wrote: > > On Wed, Feb 14, 2018 at 3:18 PM, Greg Rose wrote: >> Pull in the remaining available upstream bug fixes for the openvswitch >> Linux kernel datapath. In addition, allow building the openvswitch >>

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Feb 19, 2018, at 9:50 AM, Justin Pettit <jpet...@ovn.org> wrote: > > >> On Feb 16, 2018, at 5:32 PM, Justin Pettit <jpet...@ovn.org> wrote: >> >> >>> On Feb 16, 2018, at 5:31 PM, Pravin Shelar <pshe...@ovn.org> wrote: >>

Re: [ovs-dev] [branch-2.9] Prepare for 2.9.1.

> On Feb 19, 2018, at 3:04 PM, Aaron Conole <acon...@redhat.com> wrote: > > Justin Pettit <jpet...@ovn.org> writes: > >> Signed-off-by: Justin Pettit <jpet...@ovn.org> >> --- > > Acked-by: Aaron Conole <acon...@redhat.com> Thanks for the

[ovs-dev] Please tag v2.9.0 and v2.8.2

Hi, Ben. Can you tag "v2.9.0" on commit bd916d13db ("Set release dates for 2.9.0."), and "v2.8.2" on commit ba44001de6 ("Set release date for 2.8.2.")? Thanks! --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Feb 19, 2018, at 4:30 PM, Pravin Shelar <pshe...@ovn.org> wrote: > > On Mon, Feb 19, 2018 at 3:23 PM, Justin Pettit <jpet...@ovn.org> wrote: >> >>> On Feb 19, 2018, at 9:50 AM, Justin Pettit <jpet...@ovn.org> wrote: >>> >>

[ovs-dev] [branch-2.7 2/2] Prepare for 2.7.5.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 2c74521e07dd..ca95308bb0db 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.7.

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.4.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 ++-- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 672e712bd75d..2c74521e07dd 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.7.4 - xx xxx +v2.7.4 -

Re: [ovs-dev] [PATCH 15/15] ovsdb: Introduce experimental support for clustered databases. (2/2)

}; > +struct ovsdb_error *error = raft_save_snapshot(raft, new_log_start, > + _snapshot); > +if (error) { > +return error; > +} I think this may leak 'new_snapshot.servers'. If it doesn't under the normal circumstance, I think it can under an error. > +static void > +raft_unixctl_status(struct unixctl_conn *conn, > +int argc OVS_UNUSED, const char *argv[], > +void *aux OVS_UNUSED) > +{ > ... > +ds_put_format(, "Cluster ID: "); > +if (!uuid_is_zero(>cid)) { > +ds_put_format(, UUID_FMT"\n", UUID_ARGS(>cid)); > +} else { > +ds_put_format(, "not yet known\n"); > +} > +ds_put_format(, "Server ID: "SID_FMT" ("UUID_FMT")\n", > + SID_ARGS(>sid), UUID_ARGS(>sid)); Did you intentionally not use CID_FMT like you did for SID? > +ds_put_cstr(, "Servers:\n"); > +struct raft_server *server; > +HMAP_FOR_EACH (server, hmap_node, >servers) { > +ds_put_format(, "%s ("SID_FMT" at %s)", > + server->nickname, > + SID_ARGS(>sid), server->address); > +if (uuid_equals(>sid, >sid)) { > +ds_put_cstr(, " (me)"); raft_put_sid() seems to use "self" to describe its own SID. Do you think it's worth using the same terminology? > +static void > +raft_unixctl_leave__(struct unixctl_conn *conn, struct raft *raft) > +{ > +if (raft_left(raft)) { > +unixctl_command_reply(conn, NULL); > ... > +} else { > +raft_leave(raft); > +unixctl_command_reply(conn, NULL); > +} > +} It doesn't seem like this makes a distinction between starting to leave and already having left. It seems like it would be helpful to provide a reply that indicates the difference. > +static void > +raft_unixctl_leave(struct unixctl_conn *conn, int argc, const char *argv[], > + void *aux OVS_UNUSED) > +{ > +bool force = argc > 2 && !strcmp(argv[1], "--force"); It doesn't appear that "--force" actually does anything. Some final random things: - It might be nice to add some tests that use "tcp" instead of "unix" sockets. I thought I noticed some instances in the code that could be problematic. - I think corner cases, such as 'raft->failed' getting set to true aren't handled in the client code. - It's very difficult to determine whether an argument is consumed or not, or whether the return value should be freed. Better documentation (particularly for public functions) would help. - Should the copyright dates just be 2017 and 2018 for new files? A lot of them reference older years. Thanks for implementing this important feature! Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Feb 16, 2018, at 1:25 PM, Pravin Shelar <pshe...@ovn.org> wrote: > > On Fri, Feb 16, 2018 at 1:44 AM, Justin Pettit <jpet...@ovn.org> wrote: >> > At this point 2.9 supports 4.13, so we will need to pull in patch > series for 4.14 and 4.15 to the branc

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Feb 16, 2018, at 5:32 PM, Justin Pettit <jpet...@ovn.org> wrote: > > >> On Feb 16, 2018, at 5:31 PM, Pravin Shelar <pshe...@ovn.org> wrote: >> >> Sorry, I misread it, NSH is in 2.9. >> I think rest of patches should be easy to backpor

[ovs-dev] [branch-2.8 2/2] Prepare for 2.8.3.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 configure.ac | 2 +- debian/changelog | 8 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 48dc04daeb43..7c219f4034d4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +

[ovs-dev] [PATCH] Set release dates for 2.9.0.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 62a979e1e9f6..311f3a426cf3 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -v2.9.0 - xx xxx +v2.9.0 - 19 Fe

[ovs-dev] [branch-2.8 1/2] Set release date for 2.8.2.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 ++-- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 17495dd6e75a..48dc04daeb43 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,7 @@ -v2.8.2 - xx xxx +v2.8.2 -

[ovs-dev] [branch-2.9] Prepare for 2.9.1.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 311f3a426cf3..180099379548 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.9.

Re: [ovs-dev] [PATCH] Set release dates for 2.9.0.

> On Feb 19, 2018, at 1:38 PM, Aaron Conole <acon...@redhat.com> wrote: > > Justin Pettit <jpet...@ovn.org> writes: > >> Signed-off-by: Justin Pettit <jpet...@ovn.org> >> --- >> NEWS | 2 +- >> debian/changelog | 2 +- >>

Re: [ovs-dev] [branch-2.8 2/2] Prepare for 2.8.3.

> On Feb 19, 2018, at 1:47 PM, Flavio Leitner <f...@sysclose.org> wrote: > > On Mon, Feb 19, 2018 at 11:17:34AM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > Acked-by: Flavio Leitner <f...@sysclose.org> Thanks. I pus

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

> On Dec 28, 2017, at 3:22 PM, Gregory Rose wrote: > > SFAICT it emulates exactly what the system-traffic.at test 001 does. And it > works fine... /shrug. > > What distribution, kernel, etc are you using for your check-kmod testing? > I'll try to emulate that >

Re: [ovs-dev] [no-slow 1/6] ofproto-dpif: Add ability to look up an ofproto by UUID.

to see if you can narrow down the cause? --Justin > On Dec 26, 2017, at 10:45 AM, Gregory Rose <gvrose8...@gmail.com> wrote: > > On 12/21/2017 2:25 PM, Justin Pettit wrote: >> This will have callers in the future. >> >> Signed-off-by: Justin Pettit <jpet...

Re: [ovs-dev] [no-slow 1/6] ofproto-dpif: Add ability to look up an ofproto by UUID.

> On Dec 26, 2017, at 2:14 PM, Gregory Rose wrote: > > I'll continue to look into it. I looked at this patch more carefully, and I don't see where it would cause issues. It mostly renames a couple of things and adds a new function which isn't used in this patch. Of

Re: [ovs-dev] [PATCH v3 6/8] ovsdb-client: Add new "restore" command.

"\n backup [SERVER] [DATABASE] > DB\n" >"dump database contents in the form of a database file\n" > + "\n [--force] restore [SERVER] [DATABASE] < DB\n" > + "restore database contents from a database file\n&qu

Re: [ovs-dev] [PATCH v3 7/8] ovsdb-client: Add new "query" command.

t the only difference between "transact" and "query" is that "query" is read-only. The man page descriptions are slightly different between the commands, so it wasn't immediately obvious that was the only difference. It might be worth mak

Re: [ovs-dev] [PATCH] jsonrpc-server: Enforce uniqueness of monitor IDs.

(params->u.array.elems[1], NULL, > + "duplicate monitor ID"); > +goto error; > +} As we discussed off-line, I found the logic a bit confusing. It might be clearer with either a comment or a slight restructuring of the code. Acked-

Re: [ovs-dev] [PATCH] [RFC] coding-style: Remove caveats about mixing statements and declarations.

> On Nov 28, 2017, at 4:42 PM, Ben Pfaff <b...@ovn.org> wrote: > > OVS practice has evolved over time to mix code and data more freely. > > See also: > https://mail.openvswitch.org/pipermail/ovs-dev/2017-November/341032.html > > Signed-off-by: Ben Pfaff <b...@

Re: [ovs-dev] [PATCH] ovs-vswitchd: Allow more convenient 0x short form for specifying DPIDs.

as this one: > https://github.com/faucetsdn/faucet/blob/master/docs/README_config.rst > which tend to suggest datapath IDs like 0x1. > > CC: Josh Bailey <jo...@google.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin

Re: [ovs-dev] [PATCH] odp-util: Avoid reading wrong table in generate_all_wildcard_mask().

sec.t-labs.tu-berlin.de> > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] xcache: Handle null argument for xlate_cache_uninit().

Most other OVS libraries' delete and uninitialization functions allow a null argument, but this one would cause a segfault. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-xlate-cache.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ofproto/ofproto-dpif

[ovs-dev] [PATCH] ofproto-dpif: Fix a couple minor issues in comments.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-upcall.h | 2 +- ofproto/ofproto-dpif-xlate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.h b/ofproto/ofproto-dpif-upcall.h index efa3cd190084..cef1d34198d6

[ovs-dev] [PATCH] ofproto-dpif: Remove variable length userdata probe.

ore modern and should have support, so it's no longer necessary to probe. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 7 ofproto/ofproto-dpif.c | 85 ofproto/ofproto-dpif.h | 6 3 f

Re: [ovs-dev] [PATCH] ofp-actions: Log version, vendor, and type of unknown actions being parsed.

> On Jan 3, 2018, at 4:11 PM, Ben Pfaff <b...@ovn.org> wrote: > > This may help debugging difficult controller problems. > > Reported-by: Su Wang <suw...@vmware.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Justi

Re: [ovs-dev] [no-slow 1/6] ofproto-dpif: Add ability to look up an ofproto by UUID.

> On Jan 2, 2018, at 8:40 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Dec 21, 2017 at 02:25:10PM -0800, Justin Pettit wrote: >> This will have callers in the future. >> >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > The new comm

Re: [ovs-dev] [no-slow 4/6] ofproto: Add 'ofproto_uuid' and 'ofp_in_port' to user action cookie.

> On Jan 2, 2018, at 10:13 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Dec 21, 2017 at 02:25:13PM -0800, Justin Pettit wrote: >> Previously, the ofproto instance and OpenFlow port have been derived >> based on the datapath port number. This change explicitly d

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.4.

> On Feb 26, 2018, at 11:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Sat, Feb 24, 2018 at 11:08:38AM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > Acked-by: Ben Pfaff <b...@ovn.org> Can you tag commit 6542e817

Re: [ovs-dev] [branch-2.7 2/2] Prepare for 2.7.5.

> On Feb 26, 2018, at 11:52 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Sat, Feb 24, 2018 at 11:08:39AM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > Acked-by: Ben Pfaff <b...@ovn.org> Thanks. I push

Re: [ovs-dev] Tagging OVS 2.7.4

Hi, Miguel Angel. I pushed a release to the website, and Ben tagged "v2.7.4". Please let us know if you need anything else. --Justin > On Feb 21, 2018, at 2:44 AM, Miguel Angel Ajo Pelayo > wrote: > > Hi, I have realized that deployment of openstack with

Re: [ovs-dev] Automated robotic reply. Re: ...

> On Jun 20, 2018, at 8:47 AM, Ben Pfaff wrote: > >> On Wed, Jun 20, 2018 at 08:20:19AM -0700, Justin Pettit wrote: >> >>> On Jun 20, 2018, at 8:15 AM, Aaron Conole wrote: >>> >>> 0-day Robot writes: >>> >>>> Bleep

Re: [ovs-dev] Automated robotic reply. Re: ...

> On Jun 20, 2018, at 8:15 AM, Aaron Conole wrote: > > 0-day Robot writes: > >> Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out >> your patch >> with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> >&

Re: [ovs-dev] [PATCH] ovn-northd: Apply pre ACLs when using Port Groups

> On Jun 21, 2018, at 7:45 PM, Han Zhou wrote: > > As pointed out by Justin in today's ovn meeting, the "ovs-appctl -t > ovn-controller inject-pkt" already takes care of checksum calculation, which > can be used to replace the dummy/receive tool in tests when checksum is > needed. > So I

Re: [ovs-dev] [PATCH 0/4] Kernel backports from net-next

> On Jul 16, 2018, at 5:55 PM, Yi-Hung Wei wrote: > > This patch series backports the following patches from net-next that modify > ./net/openvswitch/* from the previous backport commit, > 46e371f0 ("openvswitch: fix vport packet length check."). > > 1) b2d6cee1 Merge

Re: [ovs-dev] [ACL Meters 3/7] ovn-controller: Add "group-table-list" ovs-appctl command.

> On Jul 30, 2018, at 10:43 AM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:34PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Thanks for the patches! > > I think that group_table_list() is very similar or identical to > meter_tabl

Re: [ovs-dev] [PATCHv2 2/2] dpif-netlink: Add meter support.

> On Jul 30, 2018, at 12:59 PM, Ben Pfaff wrote: > > On Fri, Jul 27, 2018 at 02:19:13PM -0700, Justin Pettit wrote: >> From: Andy Zhou >> >> To work with kernel datapath that supports meter. >> >> Signed-off-by: Andy Zhou >> Co-authored-by: J

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

> On Jul 30, 2018, at 11:26 AM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:35PM -0700, Justin Pettit wrote: >> Add support for configuring meters through the Meter and Meter_Band >> tables in the Northbound database. This commit also has ovn-northd >>

Re: [ovs-dev] [ACL Meters 5/7] ovn: Support configuring meters through SB Meter table.

> On Jul 30, 2018, at 11:44 AM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:36PM -0700, Justin Pettit wrote: >> Add the ability to configure meters through the newly introduced Meter >> table in the Southbound database. Previously, meters were configured by

Re: [ovs-dev] [ACL Meters 6/7] ofproto: Add support for specifying a meter in controller actions.

> On Jul 30, 2018, at 12:49 PM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:37PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > In ofproto_check_ofpacts(), the other checks, if they fail, return an > error and prevent the flow from being add

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

> On Jul 30, 2018, at 12:55 PM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:38PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Besides the comments I gave on patch 6 (oops), I suggest the following > for more consistent formatting: > >

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

> On Jul 30, 2018, at 11:40 AM, Mark Michelson wrote: > > Hi Justin, > > I took a look through the patch series, and this is the only one that I had > some immediate feedback on. > > First, it would be nice if we could refer to Meters by name when issuing DB > commands. For instance

[ovs-dev] [PATCH] ovn: Clean up log() action parsing errors.

This also add some OVN action parsing tests. Suggested-by: Ben Pfaff Signed-off-by: Justin Pettit --- ovn/lib/actions.c | 9 - tests/ovn.at | 19 +++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c index

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

> On Jul 25, 2018, at 11:29 PM, Simon Horman wrote: > > Sorry about this. I agree a revert was the correct course of action. Thanks. I pushed the series to master. --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

> On Jul 31, 2018, at 5:07 AM, Mark Michelson wrote: > > I figured more than anything I should bring this to your attention in case > you had not noticed it. Given that you provide an 'ovn-nbctl meter-add' > command, it strikes me that most people will probably add meters this way. If >

Re: [ovs-dev] [PATCH] ovn: Clean up log() action parsing errors.

> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote: > > The 0-day Robot needs to lay off the pipe. Yeah, I'm not sure what was happening there. I emailed Aaron about it. > Acked-by: Mark Michelson Thanks! I pushed this to master and branch-2.10. --Justin

Re: [ovs-dev] [patch v8 2/9] flow: Enhance parse_ipv6_ext_hdrs.

> On Jul 16, 2018, at 7:39 PM, Darrell Ball wrote: > > diff --git a/lib/flow.c b/lib/flow.c > index 76a8b9a..e84a40d 100644 > --- a/lib/flow.c > +++ b/lib/flow.c > @@ -453,9 +453,14 @@ invalid: > return true; > } > > +/* datap points to the first extension header and advances as parsing >

Re: [ovs-dev] [patch v8 4/9] conntrack: Reword conntrack_execute() description.

> On Jul 16, 2018, at 7:39 PM, Darrell Ball wrote: > > Use 'must' instead of 'should'. > > Signed-off-by: Darrell Ball > --- > lib/conntrack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/conntrack.c b/lib/conntrack.c > index 682feb9..3f50fc8 100644 > ---

Re: [ovs-dev] [PATCH] ovn: Clean up log() action parsing errors.

> On Jul 31, 2018, at 9:58 AM, Ben Pfaff wrote: > > On Tue, Jul 31, 2018 at 09:13:37AM -0700, Justin Pettit wrote: >> >>> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote: >>> >>> The 0-day Robot needs to lay off the pipe. >> >> Y

Re: [ovs-dev] [PATCH] ofctrl: Placate GCC.

c:35:0: >./include/openvswitch/ofp-meter.h:53:14: note: ‘flags’ declared here > uint16_t flags; > ^ > > With it, it passes. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit Thanks! --Justin ___ d

Re: [ovs-dev] [patch v8 7/9] ipf: Add set minimum fragment size command.

> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote: > diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h > index bd6234d..6eb55b4 100644 > --- a/lib/ct-dpif.h > +++ b/lib/ct-dpif.h > @@ -17,6 +17,7 @@ > #ifndef CT_DPIF_H > #define CT_DPIF_H > > +#include "ipf.h" I don't think it's necessary to add

Re: [ovs-dev] [patch v8 6/9] ipf: Add command to disable fragmentation handling.

> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote: > > diff --git a/lib/dpctl.man b/lib/dpctl.man > index 5d987e6..a1eb026 100644 > --- a/lib/dpctl.man > +++ b/lib/dpctl.man > @@ -272,3 +272,18 @@ Only supported for userspace datapath. > \*(DX\fBct\-get\-nconns\fR [\fIdp\fR] > Prints the

Re: [ovs-dev] [patch v8 5/9] Userspace datapath: ipf_count

> On Jul 16, 2018, at 7:39 PM, Darrell Ball wrote: > > +static void > +ipf_expiry_list_add(struct ipf_list *ipf_list, long long now) > +OVS_REQUIRES(ipf_lock) > +{ > +enum { > +IPF_FRAG_LIST_TIMEOUT_DEFAULT = 15000, > +}; > + > +ipf_list->expiration = now +

Re: [ovs-dev] [patch v8 8/9] ipf: Add set maximum fragments supported command.

> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote: > > diff --git a/lib/dpctl.man b/lib/dpctl.man > index a75fc77..f5a36b0 100644 > --- a/lib/dpctl.man > +++ b/lib/dpctl.man > @@ -296,3 +296,11 @@ must be specified. The default v4 value is 1200 and the > clamped minimum is > 400. The

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

> On Jul 30, 2018, at 5:58 PM, Justin Pettit wrote: > > Thanks for the review! I've pushed this series to master. I also just pushed this to branch-2.10. The rate-limiting is implemented using meters. Unfortunately, there's a bug in the current kernels that prevents meters fro

[ovs-dev] [ACL Meters 6/7] ofproto: Add support for specifying a meter in controller actions.

Signed-off-by: Justin Pettit --- include/openvswitch/ofp-actions.h | 8 ++ lib/ofp-actions.c | 27 +-- ofproto/ofproto-dpif-xlate.c | 24 + ofproto/ofproto-dpif.c| 1 + ofproto/ofproto.c | 44

[ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

Add support for configuring meters through the Meter and Meter_Band tables in the Northbound database. This commit also has ovn-northd sync those tables between the Northbound and Southbound databases. Add support for configuring meters with ovn-nbctl. Signed-off-by: Justin Pettit --- ovn

[ovs-dev] [ACL Meters 5/7] ovn: Support configuring meters through SB Meter table.

are references to names in the Meter table. The old behavior is still supported if the extended meter table entry begins with "__string: " Signed-off-by: Justin Pettit --- ovn/controller/ofctrl.c | 124 +++- ovn/controller/ofctrl.h | 3 +- ovn/cont

[ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

Signed-off-by: Justin Pettit --- include/ovn/actions.h | 1 + ovn/lib/actions.c | 56 +-- ovn/northd/ovn-northd.c | 4 ++ ovn/ovn-nb.ovsschema | 5 ++- ovn/ovn-nb.xml| 9 + ovn/utilities/ovn-nbctl.8.xml | 6

[ovs-dev] [ACL Meters 2/7] ovn-controller: Add "meter-table-list" ovs-appctl command.

Signed-off-by: Justin Pettit --- ovn/controller/ovn-controller.8.xml | 5 + ovn/controller/ovn-controller.c | 30 + 2 files changed, 35 insertions(+) diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml index 0eff2113f52e

[ovs-dev] [ACL Meters 1/7] ovn: Use C strings instead of ds for extended tables.

Dynamic strings are not needed for the most part and are introduing additional conversions back and forth with C strings. Signed-off-by: Justin Pettit --- ovn/controller/ofctrl.c | 4 ++-- ovn/lib/actions.c | 20 ovn/lib/extend-table.c | 22

[ovs-dev] [ACL Meters 3/7] ovn-controller: Add "group-table-list" ovs-appctl command.

Signed-off-by: Justin Pettit --- ovn/controller/ovn-controller.8.xml | 5 + ovn/controller/ovn-controller.c | 30 + 2 files changed, 35 insertions(+) diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml index 7d8fa66d7313

[ovs-dev] [PATCHv2 2/2] dpif-netlink: Add meter support.

From: Andy Zhou To work with kernel datapath that supports meter. Signed-off-by: Andy Zhou Co-authored-by: Justin Pettit Signed-off-by: Justin Pettit Acked-by: Alin Gabriel Serdean --- v1->v2: Addressed Ben's comments. --- Documentation/faq/releases.rst | 1 + lib/dpif-netlin

[ovs-dev] [PATCHv2 1/2] dpif: Move common meter checks into the dpif layer.

Another dpif provider will soon add support for meters, so move some of the common sanity checks up into the dpif layer so that each provider doesn't need to re-implement them. Signed-off-by: Justin Pettit --- v2: This patch is new to the series. --- lib/dpif-netdev.c | 15 +++ lib

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

> On Jul 26, 2018, at 7:29 AM, Gavi Teitz wrote: > > From: Justin Pettit, sent: Thursday, July 26, 2018 12:02 AM: >> Commit ab15e70eb587 ("dpctl: Expand the flow dump type filter") had a number >> of issues with style, build breakage, and failing unit tests. &g

Re: [ovs-dev] [PATCH] unixctl: Style fix.

> On Aug 8, 2018, at 1:31 PM, Ben Pfaff wrote: > > Reported-by: Aaron Conole > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

an error. This commit follows the existing implementations and makes the API somewhat cleaner. Signed-off-by: Justin Pettit --- lib/dpif-netdev.c | 4 ++-- lib/dpif-netlink.c | 13 - lib/dpif-provider.h| 9 - lib/dpif.c | 14 ++ lib/dpif.h

[ovs-dev] [PATCH 2/2] dpif-netlink: Probe for broken Linux meter implementations.

. Signed-off-by: Justin Pettit --- lib/dpif-netlink.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index bf94e5413e71..60ce1a6d22a3 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -2926,6

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

> On Aug 8, 2018, at 8:12 AM, Ben Pfaff wrote: > > Justin, I already applied this as a straightforward backport. Hope it > doesn't disrupt your work. > > On Tue, Aug 07, 2018 at 08:31:35PM -0700, Justin Pettit wrote: >> Thanks, Greg. I actually have this queu

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

> On Aug 7, 2018, at 10:19 PM, Gregory Rose wrote: > > > On 8/7/2018 8:31 PM, Justin Pettit wrote: >> Thanks, Greg. I actually have this queued up with another patch that will >> disable meters entirely on broken kernels. I plan to send that out tomorrow. >> &

Re: [ovs-dev] [patch v8 9/9] ipf: Add fragmentation status reporting.

> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote: > > void > ct_dpif_entry_uninit(struct ct_dpif_entry *entry) > { > diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h > index f886ab9..2ff7e26 100644 > --- a/lib/ct-dpif.h > +++ b/lib/ct-dpif.h > @@ -204,6 +204,15 @@ int ct_dpif_get_nconns(struct dpif

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

bottom and give ACL rate-limiting a try, I'd love to get some initial feedback. Thanks, --Justin -=-=-=-=-=-=-=-=-=- commit bc89eebb0e918d2e9a903d7e4a24ab1b5b522eab (HEAD -> meter-datapath) Author: Justin Pettit Date: Thu Jul 26 22:28:11 2018 -0700 datapath: Fix setting meter id for n

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

Thanks, Greg. I actually have this queued up with another patch that will disable meters entirely on broken kernels. I plan to send that out tomorrow. --Justin > On Aug 7, 2018, at 4:45 PM, Greg Rose wrote: > > From: Justin Pettit > > Upstream commit: >From: Justin

Re: [ovs-dev] [PATCH v3 07/11] ct-dpif: Helper functions for conntrack zone limit

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > +/* The caller takes ownership of 'struct ct_dpif_zone_limit *', and is > + * responsible to free that struct. */ > +struct ct_dpif_zone_limit * > +ct_dpif_pop_zone_limit(struct ovs_list *zone_limits) > +{ > +struct ct_dpif_zone_limit

Re: [ovs-dev] [PATCH v3 06/11] dpif: Support conntrack zone limit.

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h > index 09e7698cf2bc..4e83bc555e03 100644 > --- a/lib/ct-dpif.h > +++ b/lib/ct-dpif.h > @@ -191,6 +191,13 @@ struct ct_dpif_dump_state { > struct dpif *dpif; > }; > > +struct

Re: [ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

> On Aug 14, 2018, at 1:55 PM, Ben Pfaff wrote: > > On Wed, Aug 08, 2018 at 05:35:21PM -0700, Justin Pettit wrote: >> The original intent of the API appears to be that the underlying DPIF >> implementaion would choose a local meter id. However, neither of the >&

Re: [ovs-dev] [PATCH v3 08/11] dpif-netlink: Implement conntrack zone limit

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: I only had a few very minor suggestions. > +static int > +dpif_netlink_get_limits(struct dpif *dpif OVS_UNUSED, uint32_t > *default_limit, > +const struct ovs_list *zone_limits_request, > +

Re: [ovs-dev] 2.10 release date?

The plan is to package everything tomorrow (Friday) and release on Monday. Does that work or do you need it tomorrow? --Justin > On Aug 16, 2018, at 4:49 PM, Flavio Leitner wrote: > > > Hi, > > According with our internal release process[1] the 2.10 should have > been released on Aug, 15

Re: [ovs-dev] [PATCH v3 10/11] dpctl: Implement dpctl commands for conntrack per zone limit

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > > diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c > index a772799fe347..bb809d9920b5 100644 > --- a/lib/ct-dpif.c > +++ b/lib/ct-dpif.c > @@ -629,3 +629,70 @@ ct_dpif_free_zone_limits(struct ovs_list *zone_limits) > ... > +/* Parses a

Re: [ovs-dev] [PATCH v3 11/11] system-traffic: Add conntrack per zone limit test case

These look great. Thanks for writing some tests. --Justin > On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > Signed-off-by: Yi-Hung Wei > --- > tests/system-traffic.at | 75 + > 1 file changed, 75 insertions(+) > > diff --git

Re: [ovs-dev] [PATCH v3 09/11] dpctl: Refactor opt_dpif_open().

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > Make opt_dpif_open() to support mulitple optional arguments. It will > be useful for the following patches. > > Signed-off-by: Yi-Hung Wei > --- > lib/dpctl.c | 58 ++ > 1 file

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix recently introduced Python 3 tests.

8-August/351311.html > Reported-by: Simon Horman > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.10 1/2] Set release dates for 2.10.0.

> On Aug 18, 2018, at 11:51 AM, Ben Pfaff wrote: > > On Sat, Aug 18, 2018 at 10:40:38AM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to branch-2.10. I'll package this over the weekend, so that we

[ovs-dev] [branch-2.10 1/2] Revert "Prepare for 2.10.1."

There are a couple more patches that we'd like to apply as part of 2.10.0. This reverts commit c491d2d095756bd3499b1061adce0deeba55ffdd. Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 -- 3 files changed, 1 insertion(+), 11

[ovs-dev] [branch-2.10 2/2] Prepare for 2.10.1.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8e21180537db..04de80781dc4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.10.1 - xx xxx

Re: [ovs-dev] [ovs-dev, v4, 07 of 11] ct-dpif: Helper functions for conntrack zone limit

Thank you, 0-day Robot. I fixed this directly in my branch. --Justin > On Aug 17, 2018, at 3:08 AM, 0-day Robot wrote: > > Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't

Re: [ovs-dev] [ovs-dev, v4, 08 of 11] dpif-netlink: Implement conntrack zone limit

I went ahead and addressed this directly in my branch, too. --Justin > On Aug 17, 2018, at 3:10 AM, 0-day Robot wrote: > > Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't

Re: [ovs-dev] [patch v8 9/9] ipf: Add fragmentation status reporting.

> On Aug 13, 2018, at 2:19 PM, Darrell Ball wrote: > > > diff --git a/lib/dpctl.c b/lib/dpctl.c > > index 5ec36bd..b3e7ce7 100644 > > --- a/lib/dpctl.c > > +++ b/lib/dpctl.c > > .. > > +static int > > +dpctl_ct_ipf_get_status(int argc, const char *argv[], > > +struct

Re: [ovs-dev] [PATCH v4 00/11] conntrack zone limitation

> On Aug 17, 2018, at 2:05 AM, Yi-Hung Wei wrote: > > This patch series implements connection tracking zone limitation to > limit the maximum number of conntrack entries in the conntrack table > for every zone. This feature aims to resolve a problem that if one > of the VM/container under

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Make -generate send packets to controller again.

and in the commit message? Thanks for fixing this! Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 2/2] dpif-netdev: Prevent unsafe access when retrieving meter stats.

. Found by inspection. Signed-off-by: Justin Pettit --- lib/dpif-netdev.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 8b0b3745860b..7c0300cc554a 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -5243,20

[ovs-dev] [PATCH 1/2] dpif-netdev: Don't check if xcalloc() failed when creating meter.

xcalloc() can't return null. Signed-off-by: Justin Pettit --- lib/dpif-netdev.c | 64 +++ 1 file changed, 31 insertions(+), 33 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 807a462503ee..8b0b3745860b 100644 --- a/lib/dpif

Re: [ovs-dev] [PATCH] ofp-group: Fix memory leak in error cases parsing group requests.

gth - sizeof *ogds - bucket_list_len); > if (error) { > -ofputil_bucket_list_destroy(>buckets); > +ofputil_uninit_group_desc(gd); This isn't related to this patch per se, but should ofputil_group_properties_destroy() shoul

Re: [ovs-dev] [PATCH] ovsdb-client: Make "wait" command logging more sensible.

.at to suppress all > logging related to the timeval module. This commit drops the special > log levels from the "wait" command and puts equivalents into the tests > themselves. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin _

Re: [ovs-dev] [PATCH] ofp-actions: Avoid assertion failure for clone(ct(...bad actions...)).

error path. Instead, this commit just makes the problem go > away by always saving and restoring 'ofpact->data' if a decode fails. > > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9862 > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___

Re: [ovs-dev] [PATCH] ofp-port: Fix null dereference parsing Intel custom statistics.

> On Aug 10, 2018, at 12:30 PM, Ben Pfaff wrote: > > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9788 > Fixes: 7333c3b1ce02 ("ofp-port: Fix buffer overread parsing Intel custom > statistics.") > Signed-off-by: Ben Pfaff A

<    1   2   3   4   5   6   7   8   >