-by: Mike Pattrick
---
utilities/ovs-tcpdump.in | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in
index 5ec02383c..9be39827e 100755
--- a/utilities/ovs-tcpdump.in
+++ b/utilities/ovs-tcpdump.in
@@ -52,7 +52,6
, that is specified by the user when the group is
created, just how traffic is distributed across buckets.
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif.c | 4 ++--
utilities/ovs-ofctl.8.in | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b
a DPDK
enabled network card, then into a different OVS bridge, and finally
into another port.
Using the dummy driver resulted in the following impact to performance
compared to no ovs-tcpdump.
Kernel datapath - 5%
Usermode datapath - 10%
DPDK datapath - 17%
Signed-off-by: Mike Pattrick
for
compatibility with older kernels.
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 21 ++---
tests/system-offloads-traffic.at | 20 +---
2 files changed, 23 insertions(+), 18 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index
Currently ingress policing uses the basic classifier to apply traffic
control filters.
However, cls_basic was removed from the upcoming RHEL9. Basic is probably
not the proper classifier to use when the more efficient matchall
classifier is available and already in use in the code base. Switching
Currently when a user creates an open flow group with with multiple
buckets without specifying a selection type, the efficient dp_hash is
only selected if there are fewer than 64 buckets. But when dp_hash is
explicitly selected, up to 256 buckets are supported.
While 64 buckets seems like a lot,
, certain OVN/Open Stack workloads
could result in more than 64 buckets. For example, when using OVN to
load balance. This patch increases the maximum default from 64 to 256.
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif.c | 4 ++--
utilities/ovs-ofctl.8.in | 2 +-
2 files changed, 3
Looks good to me!
Acked-by: Mike Pattrick
On Sat, 2021-11-27 at 03:39 +, Peng He wrote:
> From: Peng He
>
> ipf_postprocess will emit packets into the datapath pipeline ignoring
> the conntrack context, this might casuse weird issues when a packet
> batch has less sp
-by: Mike Pattrick
Acked-by: Eelco Chaudron
---
lib/netdev-linux.c | 32 +---
tests/system-offloads-traffic.at | 20 +---
2 files changed, 30 insertions(+), 22 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index
On Fri, Dec 3, 2021 at 9:29 AM Ilya Maximets wrote:
>
> On 11/12/21 18:49, Mike Pattrick wrote:
> > Currently ingress policing uses the basic classifier to apply traffic
> > control filters if hardware offload is not enabled, else it uses
> > matchall. This chan
; So ignore userspace tunnel port ioctl(SIOCGIFINDEX) operation, just
> return -ENODEV.
>
>
Thanks for taking care of the previous issues.
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, 2021-12-01 at 14:46 +0100, Eelco Chaudron wrote:
>
> On 29 Nov 2021, at 22:02, Aaron Conole wrote:
>
> > This reverts commit c645550bb249 ("odp-util: Always report
> > ODP_FIT_TOO_LITTLE for IGMP.")
> >
> > Always forcing a slow path action can result in some over-broad
> > flows which
l 10.1.1.2, length 28
Thread 1 "ovs-vswitchd" hit Breakpoint 1, fast_path_processing ...
12:01:05.981214 ARP, Ethernet (len 6), IPv4 (len 4), Reply 10.1.1.1
is-at a6:0f:c3:f0:5f:bd (oui Unknown), length 28
Signed-off-by: Mike Pattrick
---
utilities/automake.mk| 1 +
utilities/
On Tue, Jan 4, 2022 at 1:12 PM Ilya Maximets wrote:
>
> On 11/30/21 17:20, Mike Pattrick wrote:
> > Recently there has been a lot of press about the "trojan source" attack,
> > where Unicode characters are used to obfuscate the true functionality of
> > c
Hello Flavio,
Great patch, I think you really did a lot to improve the code here and
I think that's borne out by the consistent performance improvements
across multiple tests.
Regarding the 4% regression that Intel detected, I found the following
white paper to describe the "scatter" test:
data.
>
> Also fix improper style for sizeof with expressions.
>
> Fixes: bfee9f6c0115 ("netlink: Add support for parsing link layer address.")
> Signed-off-by: Frode Nordahl
Looks great Frode, very nice solution without needing to worry about
manually conv
Hello Ilya,
For some reason, the included test fails for me when I try to run it.
The diff is:
./tunnel-push-pop.at:751: tail -2 stdout
--- -2021-11-15 12:09:05.838890065 -0500
+++ /root/ovs/tests/testsuite.dir/at-groups/782/stdout2021-11-15
12:09:05.836652743 -0500
@@ -1,3 +1,3 @@
Recently there has been a lot of press about the "trojan source" attack,
where Unicode characters are used to obfuscate the true functionality of
code. This attack didn't effect OVS, but adding the check here will help
guard against it sneaking in later.
Signed-off-by: Mike Pattrick
-
, that is specified by the user when the group is
created, just how traffic is distributed across buckets.
---
Changes in v2:
- Clarified change in manpage
Changes in v3:
- Updated NEWS file
Signed-off-by: Mike Pattrick
---
NEWS | 4
ofproto/ofproto-dpif.c | 4
On Wed, Nov 17, 2021 at 10:11 PM 贺鹏 wrote:
>
> Hi, Michael,
>
> thanks for the suggestion!
> the patch looks good to me, did you do the test in the patch?
I wouldn't say that I did anything fancy to test it, but I did make
sure that it still works, and has similar throughput.
Ch
feed characters, which this code base uses to cluster
functionality.
To retain a very similar functionality to what exists now, we will
split on "\r?\n" and strip off the other characters that previously
splitlines was splitting on.
Signed-off-by: Mike Pattrick
---
utilities/checkpa
Looks good to me.
Acked-by: Mike Pattrick
On Mon, Nov 15, 2021 at 1:08 PM Ilya Maximets wrote:
>
> On 11/15/21 18:28, Mike Pattrick wrote:
> > Hello Ilya,
> >
> > For some reason, the included test fails for me when I try to run it.
> > The diff is:
> >
&
No, you have made the good point here. Patch looks good.
Acked-by: Mike Pattrick
On Wed, Nov 17, 2021 at 11:28 AM Salvatore Daniele wrote:
>
> Hi Mike,
>
> Good point. I believe this was discussed previously when this parsing
> issue was first addressed [1].
>
> IIUC the r
Hello Salvatore,
Why remove support for printing igmp instead of adding support for parsing igmp?
-M
On Thu, Nov 4, 2021 at 3:40 PM Salvatore Daniele wrote:
>
> From: Adrian Moreno
>
> The match keyword "igmp" is not supported in ofp-parse, which means
> that flow dumps cannot be restored.
l 10.1.1.2, length 28
Thread 1 "ovs-vswitchd" hit Breakpoint 1, fast_path_processing ...
12:01:05.981214 ARP, Ethernet (len 6), IPv4 (len 4), Reply 10.1.1.1 is-at
a6:0f:c3:f0:5f:bd (oui Unknown), length 28
Signed-off-by: Mike Pattrick
---
utilities/gdb/ovs_gdb.py | 114 ++
Hello Peng,
Great patch! How do you feel about a patch like this to get away from
recursion?
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index fa56d86e0..935e416ea 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -8303,6 +8303,8 @@ dp_execute_cb(void *aux_, struct dp_packet_batch
On Wed, Nov 10, 2021 at 6:30 AM Gaëtan Rivet wrote:
>
> On Tue, Nov 2, 2021, at 19:43, Mike Pattrick wrote:
> > Recently there has been a lot of press about the "trojan source" attack,
> > where Unicode characters are used to obfuscate the true functionality of
> &g
| 9 ---
> 9 files changed, 86 insertions(+), 84 deletions(-)
>
Looks good to me!
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
actions. This
can cause OVS to call abort() when it attempts to re-serialize the flow
actions.
This change will validate the size with every call to ofpacts_verify,
which should cover all remaining code paths.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2020770
Signed-off-by: Mike
Recently there has been a lot of press about the "trojan source" attack,
where Unicode characters are used to obfuscate the true functionality of
code. This attack didn't effect OVS, but adding the check here will help
guard against it sneaking in later.
Signed-off-by: Mike Pattrick
-
Hello linhuang,
This is a good idea, but I've run into a few issues with this patch.
There's still one instance of "type" that needs to be changed to
dpif_type to fix compile.
Also, the behaviour of strcmp is undefined if one of the pointers is
NULL. On my system, it throws SIGSEGV. This causes
1.1.1 tell 10.1.1.2, length 28
Thread 1 "ovs-vswitchd" hit Breakpoint 1, fast_path_processing ...
12:01:05.981214 ARP, Ethernet (len 6), IPv4 (len 4), Reply 10.1.1.1 is-
at a6:0f:c3:f0:5f:bd (oui Unknown), length 28
Signed-off-by: Mike Pattrick
---
utilities/gdb/ovs_gdb.py | 114 +
for
compatibility with older kernels.
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 28 +++-
tests/system-offloads-traffic.at | 20 +---
2 files changed, 28 insertions(+), 20 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
Hello Frode,
This patch does appear to fix the test case on big-endian systems.
On Fri, 2021-11-19 at 06:08 +0100, Frode Nordahl wrote:
> The netlink policy unit test contains test fixture data that is
> subject to endianness and currently fails on big endian systems.
>
> Add helper that
ve had
an issue when this was submitted, but it does pass the
tests.
I see previously there was a discussion about how this
might affect human readability, but I think the ability
to pipe unsorted JSON into command line prettifiers like
"python -m json.tool" should cover most manual inspec
Recently there has been a lot of press about the "trojan source" attack,
where Unicode characters are used to obfuscate the true functionality of
code. This attack didn't effect OVS, but adding the check here will help
guard against it sneaking in later.
Signed-off-by: Mik
1:bb:29:f3:1b
Thread 1 "ovs-vswitchd" hit Breakpoint 1, fast_path_processing ...
5a:e3:39:9b:b7:e0 -> 9e:11:bb:29:f3:1b ARP: 10.1.1.2 is at
5a:e3:39:9b:b7:e0
Signed-off-by: Mike Pattrick
---
utilities/gdb/ovs_gdb.py | 161 +++
1 file cha
) - 16%
DPDK ports in use - 29%
Signed-off-by: Mike Pattrick
---
utilities/ovs-tcpdump.in | 54 ++--
1 file changed, 36 insertions(+), 18 deletions(-)
diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in
index 5ec02383c..82d1bedfa 100755
.1.1
tell 10.1.1.2, length 28
Thread 1 "ovs-vswitchd" hit Breakpoint 1, fast_path_processing ...
12:01:05.981214 ARP, Ethernet (len 6), IPv4 (len 4), Reply 10.1.1.1 is-at
a6:0f:c3:f0:5f:bd (oui Unknown), length 28
Signed-off-by: Mike Pattrick
---
utilities/gdb/ovs_gdb.py | 102 +
On Wed, 2021-11-03 at 16:53 +0100, Ilya Maximets wrote:
> On 10/27/21 17:48, Mike Pattrick wrote:
> > Currently the ovs-tcpdump utility creates a virtual tunnel to send
> > packets to. This method functions perfectly fine, however, it can
> > greatly impact performance
Impact on Throughput
Kernel datapath- 65%
Usermode datapath - 26%
DPDK datapath - 37%
New Script
==
Category Impact on Throughput
Kernel datapath- 5%
Usermode datapath - 16%
DPDK datapath - 29%
Signed-off-by: Mike Pattrick
---
utilities/ovs
Hello Terry,
On Thu, Dec 2, 2021 at 3:52 PM Terry Wilson wrote:
>
> On Thu, Dec 2, 2021 at 2:38 PM 0-day Robot wrote:
> >
> > Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out
> > your patch.
> > Thanks for your contribution.
> >
> > I encountered some error that I wasn't
On Tue, Dec 7, 2021 at 8:54 AM Ilya Maximets wrote:
>
> On 11/19/21 15:35, Mike Pattrick wrote:
> > This commit adds a basic packet metadata macro to the already existing
> > macros in ovs_gdb.py, ovs_dump_packets will print out information about
> > one or more p
l 10.1.1.2, length 28
Thread 1 "ovs-vswitchd" hit Breakpoint 1, fast_path_processing ...
12:01:05.981214 ARP, Ethernet (len 6), IPv4 (len 4), Reply 10.1.1.1
is-at a6:0f:c3:f0:5f:bd (oui Unknown), length 28
Signed-off-by: Mike Pattrick
---
utilities/automake.mk| 1 +
utilities/
Recently there has been a lot of press about the "trojan source" attack,
where Unicode characters are used to obfuscate the true functionality of
code. This attack didn't effect OVS, but adding the check here will help
guard against it sneaking in later.
Signed-off-by: Mike Pattrick
-
feed characters, which this code base uses to cluster
functionality.
Signed-off-by: Mike Pattrick
---
utilities/checkpatch.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index bf95358d5..caf10537b 100755
--- a/utilities
On Fri, Dec 3, 2021 at 8:15 PM Ilya Maximets wrote:
>
> On 11/30/21 22:31, Mike Pattrick wrote:
> > If anonymous memory mapping is supported by the kernel, it's better
> > to run OVS entirely in memory rather than creating shared data
> > structures. OVS doesn't work i
Hello Nobuhiro,
Good find!
Acked-by: Mike Pattrick
On Tue, Nov 30, 2021 at 1:03 AM Nobuhiro MIKI wrote:
>
> Signed-off-by: Nobuhiro MIKI
> ---
> Documentation/intro/install/afxdp.rst | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/intro/i
ull of
old memory.
Here is an example of these crashes:
https://inbox.dpdk.org/dev/20200910162407.12669-1-david.march...@redhat.com/
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1949849
Signed-off-by: Rosemarie O'Riorden
Signed-off-by: Mike Pattrick
---
NEWS | 1 +
acincl
On Fri, Jan 14, 2022 at 4:13 PM Flavio Leitner wrote:
>
> On Fri, Jan 14, 2022 at 03:50:52PM -0500, Mike Pattrick wrote:
> > On Fri, Jan 14, 2022 at 3:33 PM Flavio Leitner wrote:
> > >
> > >
> > > Hi Mike,
> > >
> > > Thanks for working
s-monitor-ipsec.
>
> This patch adds a list-commands alias name to'help' operation.
>
> Signed-off-by: Mohammad Heib
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
lso, update function comments to make it's operation clearer.
>
> Fixes: 6193e03267c1 ("dpif-netdev: Allow pin rxq and non-isolate PMD.")
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
, we now suppress these messages at
the INFO level and display exact byte count at the debug level.
Since v2:
- Normalized log capitalization and periods
- Summarized info level hash transfers
- Added log if bond members were significantly deviant
Signed-off-by: Mike Pattrick
---
lib/lacp.c
lso, update function comments to make it's operation clearer.
>
> Fixes: 6193e03267c1 ("dpif-netdev: Allow pin rxq and non-isolate PMD.")
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
string, now we just keep
track of the 16 byte flow map.
Signed-off-by: Mike Pattrick
---
lib/dpctl.c| 13 +++--
lib/dpif-netdev-private-flow.h | 2 +-
lib/dpif-netdev.c | 15 +--
lib/dpif-netlink.c | 2 +-
lib/dpif.h
On Thu, Mar 17, 2022 at 7:36 AM Mohammad Heib wrote:
>
> IPsec unit tests uses tcpdump to capture and validate the ESP
> traffic so the test must be skipped in environment that don't
> have the tcpdump tool installed.
>
> Signed-off-by: Mohammad Heib
Doesn't system-traffic.at also use tcpdump?
cking valid key/value pairs.
>
> Signed-off-by: Andreas Karis
Acked-by: Mike Pattrick
> ---
> Documentation/tutorials/ipsec.rst | 45 +++
> ipsec/ovs-monitor-ipsec.in| 17 +++-
> vswitchd/vswitch.xml | 4 ++-
>
On Wed, Feb 16, 2022 at 9:31 AM Adrian Moreno wrote:
>
> It seems versions older than 0.6.2 generate false positives. Bump the
> recommended version and make sure we uset the headers from the
>
> Suggested-by: Dumitru Ceara
> Signed-off-by: Adrian Moreno
> ---
>
: warning: 'value' may be used
uninitialized [-Wmaybe-uninitialized]
The caller doesn't happen to use the variables in these cases because
an error is set. But checking for the error resolves this warning.
Signed-off-by: Mike Pattrick
---
lib/ofp-packet.c | 8 ++--
1 file changed, 6
On Fri, Feb 25, 2022 at 4:43 PM Gregory Rose wrote:
>
>
>
> On 2/25/2022 12:02 PM, Mike Pattrick wrote:
> > GCC 11.2.1-2.2 emits a false-positive warnings like:
> >
> > lib/ofp-packet.c: In function 'ofputil_decode_packet_in':
> > lib/ofp-packet.c:1
On Thu, 2022-01-20 at 16:33 +0100, Andreas Karis wrote:
> Both LibreSwan and OpenSwan allow administrators to unconditionally
> force enable NAT-T for ESP. This may help to surmount restrictive
> firewalls in scenarios where IP protocol number 50 is blocked, but
> where
> NAT autodetection fails.
n for this port
> and ignores the request output which can contain an error message.
>
> This patch captures the request output and prints
> the error message to the ovs logs.
>
> Signed-off-by: Mohammad Heib
Acked-by: Mike Pattrick
_
)
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1776816
Signed-off-by: Mike Pattrick
---
acinclude.m4 | 7
include/linux/automake.mk | 1 +
include/linux/gen_stats.h | 82 +++
lib/tc.c | 12 +-
4 files ch
"netdev-vport: Fix userspace tunnel ioctl(SIOCGIFINDEX) info
> logs.")
> Signed-off-by: Wan Junjie
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ICMP echo request, id 1, seq 10, length 40
>
> Reported-at:openvswitch/ovs-issues#244
> Signed-off-by: Frank Guo
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e last numa used when successfully finding a non-local numa
> with available pmds, so the numa RR state is kept for subsequent rxqs.
>
> Fixes: f577c2d046b2 ("dpif-netdev: Rework rxq scheduling code.")
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Mike Pattric
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> Rename pmd_reblance_dry_run_needed() to
> pmd_rebalance_dry_run_needed().
>
> Fixes: a83a406096e9 ("dpif-netdev: Sync PMD ALB state with user commands.")
>
> Signed-off-by: Kevin Traynor
detection fails. Add a switch --force-encapsulation to expose
> this feature to users of ovs-monitor-ipsec
>
> Signed-off-by: Andreas Karis
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
, we now suppress these messages at
the INFO level and display exact byte count at the debug level.
Signed-off-by: Mike Pattrick
---
lib/lacp.c | 15 +++
ofproto/bond.c | 72 --
2 files changed, 73 insertions(+), 14 deletions(-)
diff
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> There are currently some checks for cross-numa polling cases to
> ensure that they won't effect the accuracy of the PMD ALB.
>
> If an rxq is pinned to a pmd core by the user it will not be
> reassigned by OVS, so even if it is non-local
On Wed, Mar 2, 2022 at 11:32 AM Kevin Traynor wrote:
>
> Hi Mike, thanks for reviewing,
>
> On 02/03/2022 15:41, Mike Pattrick wrote:
> > On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
> >>
> >> There are currently some checks for cross-numa polling
On Wed, Mar 2, 2022 at 10:50 AM Adrian Moreno wrote:
>
> Thanks Mike,
>
> On 3/1/22 20:14, Mike Pattrick wrote:
> > Add additional logging for debug and info level with a focus on code
> > related to bond members coming up, go down, and changing.
> >
> >
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> PMD auto load balance currently only operates when the polling pmd core
> will not change numa after reassignment. Add a unit test for this.
>
> Signed-off-by: Kevin Traynor
> ---
Acked
n error message.
>
> This patch captures the request output and prints
> the error message to the ovs logs.
>
> Signed-off-by: Mohammad Heib
This should make it easier to debug IPSec issues.
Acked-by: Mike Pattrick
___
dev mailing l
: warning: 'value' may be used
uninitialized [-Wmaybe-uninitialized]
Modifying callers of ofpprop_parse_* functions to always check
the return value before using the value from these functions.
Signed-off-by: Mike Pattrick
---
lib/ofp-actions.c | 4 +++-
lib/ofp-packet.c | 12
In glibc 2.32 sys_siglist is no longer exported. The MT-safe function
sigdescr_np() is now available for the same purpose.
Signed-off-by: Mike Pattrick
---
configure.ac | 1 +
lib/signals.c | 5 +
2 files changed, 6 insertions(+)
diff --git a/configure.ac b/configure.ac
index 298ea85ab
On Wed, Mar 23, 2022 at 4:23 AM David Marchand
wrote:
>
> On Tue, Mar 22, 2022 at 6:43 PM Mike Pattrick wrote:
> >
> > In glibc 2.32 sys_siglist is no longer exported. The MT-safe function
> > sigdescr_np() is now available for the same purpose.
>
> I am not f
Add new option --dump-hugepages option in ovs-ctl to enable the addition
of hugepages in the core dump filter.
Signed-off-by: Mike Pattrick
---
NEWS | 4
utilities/ovs-ctl.in | 15 +++
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
On Mon, Mar 28, 2022 at 7:11 AM Eelco Chaudron wrote:
>
> This change implements support for the check_pkt_len
> action using the TC police action, which supports MTU
> checking.
>
> Signed-off-by: Eelco Chaudron
Hello Eelco, I've run into a few problems with this patch.
I've found that the
On Mon, Mar 28, 2022 at 7:10 AM Eelco Chaudron wrote:
>
> Move handling of the individual actions in the netdev_tc_flow_put()
> function to a separate function that will make recursive action handling
> easier.
>
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
&
On Mon, Mar 28, 2022 at 7:10 AM Eelco Chaudron wrote:
>
> Move handling of the individual actions in the parse_tc_flower_to_match()
> function to a separate function that will make recursive action handling
> easier.
>
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattr
On Thu, Mar 17, 2022 at 11:54 AM Christophe Fontaine
wrote:
>
> This config param allows the delivery of broadcast and multicast packets
> to the secondary interface of non-lacp bonds, identical to the same option
> for kernel bonds.
>
> Tested with an ovs-dpdk balance-slb bond with 2 virtual
On Wed, Mar 23, 2022 at 10:09 AM Kevin Traynor wrote:
>
> Ensure that if there are no local numa PMD thread
> cores available that pmd cores from all other non-local
> numas will be used.
>
> Signed-off-by: Kevin Traynor
Acked-by: Mike Pattrick
> ---
gt; of RCU to protect ofproto:
>
> https://patchwork.ozlabs.org/project/openvswitch/patch/1638530715-44436-1-git-send-email-wangyunj...@huawei.com/
>
> In this patch, I have merged guohongzhi's patch and mine, and fixes
> accoring to the previous comm
On Fri, Feb 4, 2022 at 8:37 AM Adrian Moreno wrote:
>
>
>
> On 1/18/22 16:01, Peng He wrote:
> > From hepeng:
> > https://patchwork.ozlabs.org/project/openvswitch/patch/20200717015041.82746-1-hepeng.0...@bytedance.com/#2487473
> >
> > also from guohongzhi :
> >
On Thu, Jan 20, 2022 at 6:52 PM Limaye, Namrata
wrote:
>
> Hi,
>
> We are working on adding P4 support to OVS and we have recently open-sourced
> the patches on the IPDK github -
>https://github.com/ipdk-io/ovs/tree/ovs-with-p4
Hello Namrata,
I've been trying to compile this,
: Antonin Bas
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Dec 2, 2021 at 7:37 AM Roi Dayan via dev
wrote:
>
> A datapath flow generated for traffic from vxlan port to another vxlan port
> looks like this:
>
> tunnel(tun_id=0x65,src=10.10.11.3,dst=10.10.11.2,ttl=0/0,tp_dst=4789,flags(+key)),...,in_port(vxlan_sys_4789),...,
>
>
On Fri, Jan 14, 2022 at 3:33 PM Flavio Leitner wrote:
>
>
> Hi Mike,
>
> Thanks for working on this issue.
>
> On Fri, Jan 14, 2022 at 10:45:35AM -0500, Mike Pattrick wrote:
> > Formerly when userspace TSO was enabled but with a non-DKDK interface
> > without su
On Tue, Jan 18, 2022 at 11:53 AM Flavio Leitner wrote:
>
> On Mon, Jan 17, 2022 at 09:47:18AM -0500, Mike Pattrick wrote:
> > On Fri, Jan 14, 2022 at 4:13 PM Flavio Leitner wrote:
> > >
> > > On Fri, Jan 14, 2022 at 03:50:52PM -0500, Mike Pattrick wrote:
> >
On Tue, Jan 18, 2022 at 2:24 PM Flavio Leitner wrote:
>
> On Tue, Jan 18, 2022 at 12:27:21PM -0500, Mike Pattrick wrote:
> > On Tue, Jan 18, 2022 at 11:53 AM Flavio Leitner wrote:
> > >
> > > On Mon, Jan 17, 2022 at 09:47:18AM -0500, Mike Pattrick wrote:
> >
On Fri, Jan 21, 2022 at 1:03 PM Ilya Maximets wrote:
>
> On 1/7/22 21:41, Mike Pattrick wrote:
> >> diff --git a/ovsdb/relay.c b/ovsdb/relay.c
> >> index ef0e44d34..2df393403 100644
> >> --- a/ovsdb/relay.c
> >> +++ b/ovsdb/relay.c
> >> @@ -22
Hello Ilya,
LGTM!
Acked-by: Mike Pattrick
On Sun, 2021-12-19 at 15:09 +0100, Ilya Maximets wrote:
> Current code doesn't use the last id received in the monitor reply.
> That may result in re-downloading the database content if the
> re-connection happened after receiving the initia
Signed-off-by: Ilya Maximets
> ---
> ovsdb/transaction.c | 6 --
> tests/ovsdb-server.at | 16 +---
> 2 files changed, 13 insertions(+), 9 deletions(-)
>
Acked-by: Mike Pattrick
> diff --git a/ovsdb/transaction.c b/ovsdb/transaction.
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
Looks good to me!
Acked-by: Mike Pattrick
> diff --git a/ovsdb/row.c b/ovsdb/row.c
> index e83c60a21..40f53b0a5 100644
> --- a/ovsdb/row.c
> +++ b/ovsdb/row.c
> @@ -244,24 +244,18 @@ ovsdb_row_update_columns(
On Thu, 2021-12-30 at 08:03 +, Peng He wrote:
> considering a multi-thread PMD setting, when the frags are
> reassembled
> in one PMD, another thread might call *ipf_execute_reass_pkts* and
> 'steal'
> the reassembled packets into its ipf ctx, then this reassembled
> packet will enter into
On Sun, 2021-12-19 at 15:09 +0100, Ilya Maximets wrote:
> Even though relays can be scaled to the big number of servers to
> handle a lot more clients, lack of transaction history may cause
> significant load if clients are re-connecting.
> E.g. in case of the upgrade of a large-scale OVN
lya Maximets
Signed-off-by: Mike Pattrick
---
lib/conntrack.c | 8 +++-
lib/ipf.c | 36
2 files changed, 19 insertions(+), 25 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 33a1a9295..dfb2606a6 100644
--- a/lib/conntrack.c
+
function.")
> Fixes: 7617d0583c73 ("netdev-offload-dpdk: Add support for matching on gre
> fields.")
> Signed-off-by: David Marchand
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
w->in_port into odp_port.
>
> Fixes: 1df7f7aac8 ("ofproto-dpif: Restore packet metadata when a
> continuation is resumed.")
> Signed-off-by: Peng He
Looks good!
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
1 - 100 of 643 matches
Mail list logo
