On Mon, Oct 22, 2018 at 11:21 PM Mark Michelson wrote:
> On 10/22/2018 11:49 AM, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > The test "ovn-nbctl: LBs - daemon" fails when it runs the command
> > "ovn-nbctl lb-add lb0 30.0.0.1a 192.1
On Tue, Oct 23, 2018 at 3:54 AM Mary Manohar
wrote:
> This patch series implements policy-based routing.
> Policy-based routing (PBR) provides a mechanism to configure permit/deny
> and reroute policies on the router.
> Permit/deny policies are similar to OVN ACLs, but exist on the
>
On Wed, Oct 17, 2018 at 5:39 PM Numan Siddique wrote:
>
>
>
> On Fri, Oct 12, 2018 at 9:52 PM Ben Pfaff wrote:
>
>> On Fri, Aug 24, 2018 at 10:35:16AM -0700, Ben Pfaff wrote:
>> > When the status of a port changes, ofproto calls into connmgr to notify
>> &
On Fri, Oct 12, 2018 at 9:52 PM Ben Pfaff wrote:
> On Fri, Aug 24, 2018 at 10:35:16AM -0700, Ben Pfaff wrote:
> > When the status of a port changes, ofproto calls into connmgr to notify
> > controllers. Sometimes, particular changes are only visible to
> controllers
> > running specific
ils before working
on the fix :)
Thanks
Numan
>
>
>
> On Wed, Oct 17, 2018 at 2:08 PM wrote:
>
>> From: Numan Siddique
>>
>> We see the below trace when a port is added to a bridge and the configured
>> controller is down
>>
>> 0x7fb002f8
On Tue, Oct 23, 2018 at 10:20 PM Ben Pfaff wrote:
> On Tue, Oct 23, 2018 at 09:49:15AM -0700, Ben Pfaff wrote:
> > On Tue, Oct 23, 2018 at 11:48:58AM +0530, nusid...@redhat.com wrote:
> > > From: Numan Siddique
> > >
> > > The test "ovn-nbctl: LBs
On Wed, Oct 31, 2018 at 3:21 AM Ben Pfaff wrote:
> Makes the code easier to read.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> ovn/northd/ovn-northd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovn/northd/ov
On Wed, Oct 31, 2018 at 3:36 AM Ben Pfaff wrote:
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> ovn/northd/ovn-northd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-no
AT_CHECK times out after 10 seconds. So I am not sure what should
be the default timeout in dns_resolve__().
[1] - https://github.com/openvswitch/ovs/blob/master/tests/ovn-nbctl.at#L553
Thanks
Numan
> Thanks,
> Yifeng
>
> On Tue, Oct 30, 2018 at 9:34 PM Numan Siddique
> wrote:
&
needlessly inefficient. (And if there's only one per chassis then why do
> we bother allocating them at all?)
>
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> ovn/northd/ovn-northd.c | 18 +-
> 1 file changed
; > > > Thanks,
> > > > Yifeng
> > > >
> > > > On Wed, Oct 31, 2018 at 1:59 PM Ben Pfaff wrote:
> > > >
> > > > > On Thu, Oct 25, 2018 at 03:27:41PM +0530, nusid...@redhat.com
> wrote:
> > > > > > From: Numan Sidd
can drop this patch.
Thanks
Numan
> Thanks,
> Yifeng
>
> On Thu, Oct 25, 2018 at 2:58 AM wrote:
>
>> From: Numan Siddique
>>
>> When 'make check' is called by the mock rpm build (which disables
>> networking),
>> the test "ovn-nbctl: LBs - daemon" f
I am not sure
how NATting would be handled there.
https://ovsfall2018.sched.com/event/IO9w/connectivity-for-external-networks-on-the-overlay?iframe=no=100%=yes=no
>
> =======
>
> Please feel free to point, if I missed something here.
&
On Sat, Nov 3, 2018 at 5:55 PM Numan Siddique wrote:
> Hi Ankur,
> Thanks for the review and for the comments. Please see below
>
> Thanks
> Numan
>
>
> On Fri, Nov 2, 2018 at 6:21 AM Ankur Sharma
> wrote:
>
>> Hi Numan, Mark,
>>
>> Thanks fo
On Fri, Nov 2, 2018 at 10:40 PM Ben Pfaff wrote:
> In some cases the code didn't set these columns.
>
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> ovn/northd/ovn-northd.c | 6 ++
> 1 file changed, 6 insertions(+)
On Tue, Nov 6, 2018, 2:26 AM Ben Pfaff On Mon, Nov 05, 2018 at 09:45:10PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > This patch adds a new action 'check_pkt_larger' which checks if the
> > packet is larger than the given size and stores the resul
Thanks for the review Guru.
Please see below for the comments.
On Fri, Oct 5, 2018 at 12:09 AM Guru Shetty wrote:
>
>
> On Mon, 17 Sep 2018 at 02:24, wrote:
>
>> From: Numan Siddique
>>
>> When a child vlan interface is created inside a VM, the below kernel
ked issue without having to re-think the
> implementation? What do you think?
>
Hi Mark,
I will be addressing the issue you mentioned in the v3 of this patch. I am
working in it now.
Thanks
Numan
> On 09/19/2018 01:27 PM, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
&g
On Fri, Oct 5, 2018 at 2:32 AM Guru Shetty wrote:
>
>
> On Thu, 4 Oct 2018 at 13:29, Numan Siddique wrote:
>
>>
>> Thanks for the review Guru.
>>
>> Please see below for the comments.
>>
>>
>>
>> On Fri, Oct 5, 2018 at 12:09 AM Gur
On Wed, Oct 10, 2018 at 3:42 AM aginwala wrote:
> When starting OVN DBs in HA using pacemaker with ssl, we need to pass ssl
> certs for starting standby DBs. Hence, we need this change.
>
> Signed-off-by: aginwala
> Acked-by: Han Zhou
>
Acked-by: Numan Siddique
> ---
&
On Tue, Oct 9, 2018 at 6:11 AM Han Zhou wrote:
> >>
> >> Giving a second thought, it seems there is still a problem.
> >>
> >> There should be two sets of SSL related parameters we should consider in
> the active-standby scenario.
> >> - One set of parameters is for the server side. For ipaddr2
On Tue, Oct 9, 2018 at 2:18 PM wrote:
> From: Numan Siddique
>
> With this commit the users can override the default values of
> the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
> This can be useful to debug any issues related to BFD (like
> frequent
On Mon, Oct 8, 2018 at 11:53 PM Ben Pfaff wrote:
> On Sat, Oct 06, 2018 at 08:04:09PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > With this commit the users can override the default values of
> > the BFD params - min_rx, min_tx, decay
nts ) and neutron + OVN. With the new redirect chassis support, we could
add the floating ip support for the VMs with distributed routing (instead
of centralized routing) and also later- HA support for centralized routing.
I have submitted a patch series as an alternate solution to solve this
issue
On Wed, Oct 3, 2018 at 2:46 PM zhang hao wrote:
> Hello,
>
> My name is Zhanghao and I am a student major in software engineering of
> Tsinghua university. I am learning SDN and very interested in ovs. I want
> to do some contribution to it but meet some difficulties.
>
> To be exactly, I want
On Fri, Sep 21, 2018 at 11:06 PM Guru Shetty wrote:
> >
> >
> > I have tried to make sense of this patch series a few times. I think
> > adding increasing complications like this will make gateway code
> > unmaintainable. The whole gateway redirect chassis already makes it
> > un-understandable
M Anil Venkata
> wrote:
>
>> On Mon, Sep 24, 2018 at 3:12 PM wrote:
>>
>> > From: Numan Siddique
>> >
>> > With this commit the users can override the default BFD params -
>> > min_rx, min_tx and decay_min_rx if desired. This can be useful
&g
On Thu, Sep 27, 2018 at 12:53 PM Miguel Angel Ajo Pelayo <
majop...@redhat.com> wrote:
>
>
> On Wed, Sep 26, 2018 at 11:08 PM Ben Pfaff wrote:
>
>> On Wed, Sep 26, 2018 at 04:14:18PM +0530, nusid...@redhat.com wrote:
>> > From: Numan Siddique
>> >
&g
's passing locally for me.
Thanks
Numan
>
> On Tue, Jan 15, 2019 at 12:09 PM wrote:
> >
> > From: Numan Siddique
> >
> > In the case of OpenStack + OVN, when the VMs are booted on
> > hypervisors supporting SR-IOV nics, there are no OVS ports
> > fo
On Thu, Jan 17, 2019 at 10:57 PM Han Zhou wrote:
> On Tue, Jan 15, 2019 at 10:24 AM Numan Siddique
> wrote:
> >
> >
> >
> > On Tue, Jan 15, 2019 at 5:42 AM Han Zhou wrote:
> >>
> >> Hi Numan,
> >>
> >> The feature looks very
On Fri, Jan 18, 2019 at 12:21 AM Han Zhou wrote:
> Hi Numan,
>
> With v5 the new test case "external logical port" fails.
> And please see more comments inlined.
>
> On Tue, Jan 15, 2019 at 12:09 PM wrote:
> >
> > From: Numan Siddique
> >
&g
On Fri, Jan 18, 2019 at 2:11 AM Han Zhou wrote:
> On Thu, Jan 17, 2019 at 11:32 AM Han Zhou wrote:
> >
> > On Thu, Jan 17, 2019 at 11:25 AM Numan Siddique
> wrote:
> > >
> > >
> > >
> > > On Fri, Jan 18, 2019 at 12:21 AM Han Zhou wrote:
On Sat, Jan 19, 2019, 12:32 AM Han Zhou On Fri, Jan 18, 2019 at 10:16 AM Numan Siddique
> wrote:
> >
> >
> >
> > On Fri, Jan 18, 2019 at 2:11 AM Han Zhou wrote:
> >>
> >> On Thu, Jan 17, 2019 at 11:32 AM Han Zhou wrote:
> >> >
> &
> On Thu, Jan 10, 2019 at 12:37 PM wrote:
> >
> > From: Numan Siddique
> >
> > In the case of OpenStack + OVN, when the VMs are booted on
> > hypervisors supporting SR-IOV nics, there are no OVS ports
> > for these VMs. When these VMs sends DHCPv4, DHPCv6
after adding the HA support. I think this would be better
as we won't add
more options in OVN (first requested-chassis for external ports and then
later HA chassis support).
Thoughts?
Thanks
Numan
On Sat, Jan 19, 2019 at 12:42 AM Numan Siddique wrote:
>
>
> On Sat, Jan 19, 2019, 12:32 AM
converts '::1' into ';1'.
>
> Use IPv6 long form instead of its short variant.
>
> Signed-off-by: Alin Gabriel Serdean
>
Acked-by: Numan Siddique
We generally tend to use the short form and we don't even realize it
breaks windows. Probably checkpatch can check it and flag
@Guru - Gentle ping if you have any plans to review it.
Thanks
Numan
On Tue, Nov 27, 2018 at 12:55 PM wrote:
> From: Numan Siddique
>
> In the case of OpenStack + OVN, when the VMs are booted on
> hypervisors supporting SR-IOV nics, there are no OVS ports
> for these VMs.
On Tue, Dec 18, 2018 at 6:13 AM Ben Pfaff wrote:
> On Mon, Dec 17, 2018 at 09:49:44PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > When an IPv6 packet enters a router pipeline and it needs to be routed
> via
> > the nexthop IP address set in t
On Wed, Dec 19, 2018 at 4:23 PM Miguel Angel Ajo Pelayo
wrote:
> Oh, if requested chassis matches the chasis of the SRIOV instance, then we
> don't need HA. Ignore my comments regarding multiple chassis.
>
> And yes it's my understanding that the traffic will bounce to the host
> interface
Oops. Sorry. I accidently removed the ovs-dev ML.
Added it back.
Thanks
Numan
On Wed, Dec 5, 2018 at 6:23 PM Numan Siddique wrote:
>
>
> On Mon, Dec 3, 2018 at 11:52 PM Gregory Smith wrote:
>
>> Hi Numan,
>>
>> Just a gentle reminder about this patch, in case it
> +
> > +ovs-vsctl add-port br-int vif0 -- set Interface vif0
> external-ids:iface-id=lp0
> > +ovs-vsctl add-port br-int vif1 -- set Interface vif1
> external-ids:iface-id=lp1
> > +
> > +ovn-nbctl lsp-add sw0 lp0
> > +ovn-nbctl
On Wed, Dec 5, 2018 at 4:05 PM Lorenzo Bianconi
wrote:
> Add the capability to IPAM/MACAM framework to specify a static ip address
> and get the L2 one allocated dynamically using the following syntax:
>
> $ovn-nbctl lsp-set-addresses " dynamic"
>
Until now, the usage of dynamic is
-
On Tue, Nov 20, 2018 at 1:37 AM Gregory Smith wrote:
> Numan Siddique wrote:
> > On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith
> wrote:
> >
> > > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the
> > > server should validate th
On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith wrote:
> See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the
> server should validate that the client's requested IP matches the
> offered IP. If not, the server should reply with a DHCPNAK. The client's
> requested IP is either
ef0::800:ff:fe00:1"
> > enabled : []
> > external_ids: {}
> > name: "sw0-port2"
> > options : {}
> > parent_name : []
> > port_security : []
> > tag : []
> > t
Thanks Guru for the review and comments. I have addressed the comments and
submitted v2 here - https://patchwork.ozlabs.org/patch/999893/
Thanks
Numan
On Thu, Nov 15, 2018 at 11:33 PM Guru Shetty wrote:
>
>
> On Fri, 5 Oct 2018 at 10:15, wrote:
>
>> From: Numan Sidd
On Tue, Nov 27, 2018 at 12:48 AM Guru Shetty wrote:
>
>
> On Mon, 19 Nov 2018 at 08:18, wrote:
>
>> From: Numan Siddique
>>
>> An OVN deployment can have multiple logical switches each with a
>> localnet port connected to a distributed logical router in whi
On Fri, Jan 11, 2019 at 12:07 AM Han Zhou wrote:
>
>
>
> On Thu, Dec 20, 2018 at 5:34 AM Numan Siddique
> wrote:
> >
> >
> >
> > On Wed, Dec 19, 2018 at 4:23 PM Miguel Angel Ajo Pelayo <
> majop...@redhat.com> wrote:
> >>
> >>
On Fri, Jan 11, 2019 at 12:09 AM Numan Siddique wrote:
>
>
> On Fri, Jan 11, 2019 at 12:07 AM Han Zhou wrote:
>
>>
>>
>>
>> On Thu, Dec 20, 2018 at 5:34 AM Numan Siddique
>> wrote:
>> >
>> >
>> >
>> > On Wed, D
t it.
>
>
Thanks Timothy for the review and comments.
I have addressed all your comments and submitted v2 -
https://patchwork.ozlabs.org/patch/1021915/
Thanks
Numan
> > From: Numan Siddique
> >
> > Up until now, OVN rpms were generated as sub packages of OpenvSwitch.
> > T
Hi Ted,
This patch is failing the below test cases for me. All are python3 related.
Can you please
take a look if that's the case with you as well ?
**
2139: simple idl, writing via IDL with unicode - Python3 FAILED (
ovsdb-idl.at:456)
2141: simple idl, writing via IDL with unicode - Python3
On Fri, Jan 11, 2019 at 4:54 AM Ben Pfaff wrote:
> This is needed to make OVS work with flake8 3.6.
>
>
Tested all the patches in this series on fedora 29 with flake8 3.7 and it
fixes all
the flake8 issues.
Ack for the whole series.
Acked-by: Numan Siddique
Tested-by: Numan Siddique
On Fri, Jan 4, 2019 at 5:26 PM Numan Siddique wrote:
> Hi Ted,
>
> This patch is failing the below test cases for me. All are python3
> related. Can you please
> take a look if that's the case with you as well ?
> **
> 2139: simple idl, writing via IDL with unicode - Pyt
On Tue, Sep 11, 2018 at 12:56 AM Han Zhou wrote:
> On Mon, Sep 10, 2018 at 12:56 AM wrote:
> >
> > From: Numan Siddique
> >
> > The present code resets the database when it is in the state -
> > 'RPL_S_SCHEMA_REQUESTED' and repopulates the database when it
&g
On Tue, Sep 18, 2018 at 1:49 PM Ben Pfaff wrote:
> On Mon, Sep 10, 2018 at 11:49:06PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > In the case of OpenStack + OVN, when the VMs are booted on
> > hypervisors supporting SR-IOV nics, there are no
On Tue, Sep 18, 2018 at 1:41 PM Ben Pfaff wrote:
> On Tue, Sep 11, 2018 at 10:55:56AM -0700, Han Zhou wrote:
> > On Tue, Sep 11, 2018 at 10:30 AM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > The present code resets the database when it is
On Mon, Apr 1, 2019 at 1:15 AM Han Zhou wrote:
> From: Han Zhou
>
> In the main loop, if the SB DB is disconnected when there is a pending
> transaction, there can be busy loop causing 100% CPU of ovn-controller,
> until SB DB is connected again.
>
> The root cause is that when a transaction is
On Wed, Apr 3, 2019 at 10:05 AM Han Zhou wrote:
> Thanks Numan for the review. Please see my response below.
>
> On Tue, Apr 2, 2019 at 3:59 AM Numan Siddique wrote:
> >
> >
> >
> > On Mon, Apr 1, 2019 at 1:15 AM Han Zhou wrote:
> >>
> >> Fr
incremented in the case of Database table
> updates.
>
> Signed-off-by: Ted Elhourani
>
Acked-by: Numan Siddique
Numan
---
>
> v4 -> v5
>
> * Increase test timeout.
> * Spell out list of files to cat for shell compatibility.
>
> v3 -> v4
> ---
On Wed, Mar 27, 2019 at 10:39 AM Han Zhou wrote:
> On Thu, Mar 14, 2019 at 12:33 PM wrote:
> >
>
> > diff --git a/ovn/controller/bfd.h b/ovn/controller/bfd.h
> > index e36820afb..789f7b269 100644
> > --- a/ovn/controller/bfd.h
> > +++ b/ovn/controller/bfd.h
> > @@ -24,16 +24,17 @@ struct
On Wed, Mar 27, 2019 at 12:32 AM Han Zhou wrote:
> On Tue, Mar 26, 2019 at 11:08 AM Numan Siddique
> wrote:
> >
> >
> >
> > On Tue, Mar 26, 2019 at 11:21 PM Han Zhou wrote:
> >>
> >> On Tue, Mar 26, 2019 at 9:59 AM Numan Siddique
> wrote
On Wed, Mar 27, 2019 at 10:54 AM Han Zhou wrote:
> On Thu, Mar 14, 2019 at 12:33 PM wrote:
> >
>
> > diff --git a/NEWS b/NEWS
> > index 89d0f19d6..74adb2562 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -24,6 +24,7 @@ Post-v2.11.0
> > protocol extension.
> > - OVN:
> > * Select
On Tue, Mar 26, 2019 at 3:15 AM Ben Pfaff wrote:
> On Sat, Mar 16, 2019 at 11:27:06AM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > This series attempts to add a new thread in pinctrl module. This thread
> > will handle the packe
On Wed, Mar 27, 2019 at 11:24 PM Han Zhou wrote:
> On Wed, Mar 27, 2019 at 3:00 AM Numan Siddique
> wrote:
> >
> >
> >
> > On Wed, Mar 27, 2019 at 12:32 AM Han Zhou wrote:
> >>
> >> On Tue, Mar 26, 2019 at 11:08 AM Numan Siddique
> wrote:
>
On Wed, Mar 27, 2019 at 11:48 PM Han Zhou wrote:
> On Wed, Mar 27, 2019 at 6:10 AM wrote:
>
> > @@ -2195,18 +2191,37 @@ ovn_port_update_sbrec(struct northd_context *ctx,
> > if (op->derived) {
> > const char *redirect_chassis = smap_get(>nbrp->options,
> >
On Tue, Mar 26, 2019 at 11:21 PM Han Zhou wrote:
> On Tue, Mar 26, 2019 at 9:59 AM Numan Siddique
> wrote:
> >
> >
> > Thanks Han for the review. I will address them
> > Please see comments inline
> >
> > Thanks
> > Numan
> >
&
Thanks Han for the review. I will address them
Please see comments inline
Thanks
Numan
On Tue, Mar 26, 2019 at 8:07 AM Han Zhou wrote:
> Mostly looks good to me, just minor comments.
>
> On Thu, Mar 14, 2019 at 12:32 PM wrote:
> >
> > +static void
> > +build_lrouter_groups__(struct hmap
On Fri, Mar 22, 2019 at 9:10 PM Gregory Rose wrote:
>
> On 3/22/2019 2:58 AM, Numan Siddique wrote:
>
>
>
> On Fri, Mar 22, 2019 at 6:16 AM Gregory Rose wrote:
>
>>
>>
>> On 3/21/2019 5:38 PM, Gregory Rose wrote:
>> >
>&
On Mon, Mar 25, 2019 at 12:07 AM Numan Siddique wrote:
>
>
> On Fri, Mar 22, 2019 at 9:10 PM Gregory Rose wrote:
>
>>
>> On 3/22/2019 2:58 AM, Numan Siddique wrote:
>>
>>
>>
>> On Fri, Mar 22, 2019 at 6:16 AM Gregory Rose
>> wrote:
&
e and run it
> whenever br_int is not NULL, and not care about chassis because this
> function doesn't depend on it.
>
> Note: the changes of this patch is better to be shown with "-w" because
> most of them are indent changes.
>
> Signed-off-by: Han Zhou
>
Acke
DB, there are already additional checks making sure ovnsb_idl_txn
> is not NULL.
>
> Signed-off-by: Han Zhou
>
Acked-by: Numan Siddique
> ---
>
> Notes:
> v1->v2: Updates according to Numan's comments.
>
> ovn/controller/chassis.c | 9 -
> 1 file cha
On Thu, Mar 28, 2019 at 3:34 PM Lucas Alvares Gomes Martins <
lmart...@redhat.com> wrote:
> On Thu, Mar 28, 2019 at 9:19 AM Numan Siddique
> wrote:
> >
> >
> > Thanks Lucas for the patch. The patch looks good to me.
> > Just a few comments inline.
> >
&
Thanks Lucas for the patch. The patch looks good to me.
Just a few comments inline.
Thanks
Numan
On Tue, Mar 26, 2019 at 11:55 PM Mark Michelson wrote:
> Thanks Lucas, looks good to me.
>
> Acked-by: Mark Michelson
>
> On 3/25/19 2:24 PM, lmart...@redhat.com wrote:
> > From: Lucas Alvares
On Thu, Mar 28, 2019 at 1:23 AM Han Zhou wrote:
> On Wed, Mar 27, 2019 at 12:06 PM Han Zhou wrote:
> >
> > On Wed, Mar 27, 2019 at 11:34 AM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > This patch series adds a generic HA chassis
> The solution is to introduce a function to reset table formatting. This
> way, the first time after resetting table formatting, no newline is
> prepended.
>
> Signed-off-by: Mark Michelson
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> lib/table.c
issue by not parsing the table formatting options
> in nbctl_client. Instead, the table formatting options are passed to the
> server loop and parsed there instead.
>
> Signed-off-by: Mark Michelson
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> ovn/utilit
On Thu, Feb 21, 2019 at 4:10 AM Ankur Sharma
wrote:
> Background:
> [1]
> https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
> [2]
> https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
>
> This Series:
> Layer 2, Layer 3 E-W and
Hi Ankur,
Few comments below.
Thanks
Numan
On Thu, Feb 21, 2019 at 4:08 AM Ankur Sharma
wrote:
> Background:
> [1]
> https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
> [2]
>
On Wed, Feb 27, 2019 at 8:08 AM Han Zhou wrote:
> On Mon, Feb 18, 2019 at 11:26 AM wrote:
> >
> > From: Numan Siddique
> >
> > This patch series adds a generic HA chassis group support in OVN
> > deprecating the existing Gateway chassis support. The f
On Wed, Feb 27, 2019 at 4:48 PM 0-day Robot wrote:
> Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out
> your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatc
OVN deployments share the same
> broadcast domain.
> Remove MAC_ADDR_PREFIX definitions/occurrences since now mac_prefix is
> always provided to ovn-northd
>
> Tested-by: Miguel Duarte de Mora Barroso
> Signed-off-by: Lorenzo Bianconi
>
Acked-by: Numan Siddique
> ---
>
Hi Greg,
Please see one comment below
Thanks
Numan
On Thu, Feb 14, 2019 at 6:42 AM Numan Siddique wrote:
>
>
> On Thu, Feb 14, 2019, 2:58 AM Gregory Rose wrote:
>
>> Norman,
>>
>> I couldn't find your original email to reply to so I just copied in you
it's "chasss". Also, in
> ovn/controller/physical.c, I noticed that the "Gateway_Chassis" is still
> referenced in an error message instead of HA_Chassis. Other than that, I
> didn't see anything that was jumped out as wrong.
>
>
Thanks I will address that.
Nu
Hi Ben and Greg,
Please see one comment below inline
Thanks
Numan
On Tue, Feb 12, 2019 at 7:57 AM Ben Pfaff wrote:
> Greg, I recommend that you take a look at this one.
>
> (More commentary below.)
>
> On Thu, Jan 10, 2019 at 11:29:48PM +0530, nusid...@redhat.com wrote:
k we need anything extra
here.
Thanks
Numan
> On 2/17/19 11:42 PM, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > If the integration bridge is deleted, ovn-controller recreates it
> > but the previous datapath-type value is lost if it was set. Th
On Tue, Feb 26, 2019 at 11:41 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Select a random IPAM mac_prefix if it has not been provided by the user.
> With this patch the admin can avoid to configure mac_prefix in order to
> avoid L2 address collisions if multiple OVN deployments
ix/rfc_v4_p4 for your
testing.
Thanks
Numan
- Greg
>
> On 2/21/2019 10:42 AM, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > [Please note, this patch is submitted as RFC in ovs-dev ML to
> > get feedback before submitting to netdev ML. You need net-next tr
On Tue, Mar 5, 2019 at 2:10 PM parameswaran krishnamurthy <
parkr...@gmail.com> wrote:
> Hi,
>
> With the attached patch I'm able to avert the crash.Can you please review
> and suggest if the patch is fine ?
>
> Thanks and regards,
> Parameswaran
>
Hi Parameswaran,
I don't see any patch
On Tue, Mar 5, 2019 at 6:30 PM parameswaran krishnamurthy <
parkr...@gmail.com> wrote:
> Problem Description:
> The ovs-vswitchd is crashing while invoking flow-mod with upsupported
> action(Tested with ovs2.10.1)
>
>
Ideally the patches are submitted against the master branch. Once the
patch is
On Tue, Mar 5, 2019 at 2:00 PM Han Zhou wrote:
> On Thu, Feb 28, 2019 at 12:59 AM Numan Siddique
> wrote:
> >
> >
> >
> > On Thu, Feb 28, 2019 at 1:50 AM Han Zhou wrote:
> >>
> >> On Wed, Feb 27, 2019 at 2:45 AM wrote:
> >> >
On Tue, Mar 5, 2019 at 5:29 AM Ben Pfaff wrote:
> "controller_id" was written as "controller-id" in one place. This spells
> it consistently.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> lib/ovs-actions.xml | 2 +-
>
On Thu, Feb 28, 2019 at 1:50 AM Han Zhou wrote:
> On Wed, Feb 27, 2019 at 2:45 AM wrote:
> >
> > From: Numan Siddique
> >
> > This patch adds the tables - 'HA_Chassis_Group' and 'HA_Chassis' in
> > both OVN Northbound and Southbound DBs to support generic HA C
On Tue, Mar 5, 2019 at 11:34 PM Han Zhou wrote:
> > > +
> > > +static void
> > > +add_to_ha_ref_chassis_info(struct ha_ref_chassis_info *ref_ch_info,
> > > + const struct sbrec_chassis *chassis)
> > > +{
> > > +for (size_t j = 0; j < ref_ch_info->n_ref_chassis; j++)
On Thu, Mar 7, 2019, 10:46 PM Han Zhou wrote:
> On Thu, Mar 7, 2019 at 8:37 AM Numan Siddique wrote:
> >
> >
> >
> > On Tue, Mar 5, 2019 at 11:34 PM Han Zhou wrote:
> >>
> >> > > +
> >> > > +static void
> >&
On Tue, Feb 12, 2019 at 8:41 AM Ben Pfaff wrote:
> On Thu, Jan 10, 2019 at 11:30:58PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > In order to support OVN specific fields (which are not yet
> > supported in OpenvSwitch to set or modify valu
Hi Ben,
Few comments inline.
Thanks
Numan
On Wed, Feb 13, 2019 at 10:53 PM Numan Siddique wrote:
>
> Thanks Ben for providing the review comments.
>
> I will address all the comments.
>
> A couple of comments inline.
>
> Thanks
> Numan
>
>
> On Tue, Feb
On Mon, Mar 18, 2019 at 1:45 PM Vasiliy Tolstov wrote:
> Hi. I'm try to modify/write/improve golang ovn binding. And i'm stuck
> at dhcpv4_options in logical_switch_port.
> As i see its is weak reference, i think that it is string, but as i
> see in returned results via libovsdb it is OvsSet
On Mon, Mar 18, 2019 at 7:35 AM taoyunupt wrote:
> Dear all,
>As far as I know , ovn/networking-ovn(support) dose not support
> fwaas and vpnaas.So, does have any plan or blueprint to support fwaas
> and vpnaas in ovn/networking-ovn(openstack)?
>
>
I think openstack ML is more
On Tue, Mar 12, 2019 at 6:16 PM Mark Michelson wrote:
> On 3/11/19 6:11 PM, Han Zhou wrote:
> > On Mon, Mar 11, 2019 at 9:29 AM wrote:
> >>
> >> From: Numan Siddique
> >>
> >> Prior to this patch, ovn-controller was single threaded and everytime
&
Hi,
On my Fedora 29 when ever I run all the ovs tests with "-j5", I see few
core dumps generated for ovsdb-server and python2.
Here's the back trace
[root@nusiddiq ovsdb]# gdb ./ovsdb-server
/opt/core_dumps/core.ovsdb-server.24604
GNU gdb (GDB) Fedora 8.2-6.fc29
...
...
Core was
201 - 300 of 2788 matches
Mail list logo