Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

On Tue, Feb 07, 2017 at 02:30:46PM -0800, Joe Stringer wrote: > On 7 February 2017 at 09:44, Joe Stringer <j...@ovn.org> wrote: > > On 6 February 2017 at 16:46, Yang, Yi Y <yi.y.y...@intel.com> wrote: > >> Joe, I checked current ovs and net-next kernel, obviously so

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

On Wed, Jan 18, 2017 at 01:29:14PM -0800, Joe Stringer wrote: > On 18 January 2017 at 11:54, Eric Garver <e...@erig.me> wrote: > > On Tue, Jan 17, 2017 at 12:37:19AM +, Yang, Yi Y wrote: > >> What userspace do "802.1ad patches" depend on? Per Pravin's stateme

Re: [ovs-dev] [PATCH net-next] openvswitch: fix VxLAN-gpe port can't be created in ovs compat mode

On Thu, Dec 08, 2016 at 12:37:56PM +0100, Jiri Benc wrote: > On Thu, 8 Dec 2016 18:57:51 +0800, Yang, Yi wrote: > > So ovs out of tree modules need to adapt to upstream kernel, any > > kernel-related changes must be accepted by Linux kernel at first. > > I'm perfectly aware o

Re: [ovs-dev] [PATCH] datapath: enable vxlangpe creation in compat mode

On Tue, Dec 13, 2016 at 08:41:18PM -0800, Pravin Shelar wrote: > On Thu, Dec 8, 2016 at 9:41 PM, Yi Yang wrote: > > > > if (vport->dev->flags & IFF_LOOPBACK || > > - vport->dev->type != ARPHRD_ETHER || > > + (vport->dev->type != ARPHRD_ETHER && > >

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Tue, Dec 06, 2016 at 03:51:03PM +0100, Jiri Benc wrote: > On Tue, 6 Dec 2016 07:17:20 +0000, Yang, Yi Y wrote: > > So my advice about this is we can push patch [2] to Linux net-next > > first, then apply patch series > > https://mail.openvswitch.org/pipermail/ovs-dev/

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Tue, Dec 06, 2016 at 03:51:03PM +0100, Jiri Benc wrote: > On Tue, 6 Dec 2016 07:17:20 +0000, Yang, Yi Y wrote: > > So my advice about this is we can push patch [2] to Linux net-next > > first, then apply patch series > > https://mail.openvswitch.org/pipermail/ovs-dev/

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Tue, Dec 06, 2016 at 09:38:09AM -0500, Eric Garver wrote: > On Tue, Dec 06, 2016 at 07:17:20AM +0000, Yang, Yi Y wrote: > > Hi, guys > > Hi Yi, > > > This patch isn't updated from June on, Cascardo said he/Eric is still > > working on this, but six months pass

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Thu, Dec 08, 2016 at 03:24:35PM -0500, Eric Garver wrote: > On Wed, Dec 07, 2016 at 08:47:56AM +0800, Yang, Yi wrote: > > > > I notice if we fallback to ovs compat modules to create vxlan, it will > > use generic netlink but not rtnetlink, do you meam you're changin

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 11:19:21AM +0200, Jiri Benc wrote: > Please always CC reviewers of the previous versions, thanks. Jiri, thank you for quick review. Sorry, I made a mistake on sending and missed all the CCs, will indeed do this in next version. > > + __be16 ver_flags_len; > > + u8

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

On Tue, Aug 15, 2017 at 12:09:14AM +0800, Eric Garver wrote: > On Thu, Aug 10, 2017 at 09:21:15PM +0800, Yi Yang wrote: > > Hi Yi, > > In general I'd like to echo Jiri's comments on the netlink attributes. > I'd like to see the metadata separate. > > I have a few other comments below. > >

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

On Fri, Aug 11, 2017 at 10:24:18AM +0200, Jiri Benc wrote: > On Thu, 10 Aug 2017 21:21:15 +0800, Yi Yang wrote: > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can support > > NSH in 2.8 release

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

On Fri, Aug 11, 2017 at 11:44:49AM +0200, Jiri Benc wrote: > On Fri, 11 Aug 2017 09:24:25 +0000, Yang, Yi Y wrote: > > So far, we're not clear how we can support MD type 2 better, as I > > explained before, we need to reuse tun_metadata in struct flow_tnl > > which is the

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 11:15:28PM +0800, Eric Garver wrote: > On Wed, Aug 16, 2017 at 01:35:30PM +0800, Yi Yang wrote: > > + > > +#define NSH_DST_PORT4790 /* UDP Port for NSH on VXLAN. */ > > +#define ETH_P_NSH 0x894F /* Ethertype for NSH. */ > > ETH_P_NSH probably belongs in

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 10:03:22PM +0800, Jiri Benc wrote: > On Wed, 16 Aug 2017 17:31:30 +0800, Yang, Yi wrote: > > On Wed, Aug 16, 2017 at 11:19:21AM +0200, Jiri Benc wrote: > > > > --- a/include/uapi/linux/openvswitch.h > > > > +++ b/include/uapi/linux/openvswit

Re: [ovs-dev] [PATCH v2 0/2] nsh: rework NSH netlink keys and actions

On Sat, Aug 19, 2017 at 01:36:57AM +0800, Ben Pfaff wrote: > On Fri, Aug 18, 2017 at 07:38:56AM +0800, Yi Yang wrote: > > v1->v2 > > - Rework per kernel datapath review comments > > - Add new NSH key ttl > > - Add many helpers in nsh.h and replace much code > > with these helpers > > -

Re: [ovs-dev] [PATCH v2 0/2] nsh: rework NSH netlink keys and actions

On Sat, Aug 19, 2017 at 01:36:57AM +0800, Ben Pfaff wrote: > On Fri, Aug 18, 2017 at 07:38:56AM +0800, Yi Yang wrote: > > v1->v2 > > - Rework per kernel datapath review comments > > - Add new NSH key ttl > > - Add many helpers in nsh.h and replace much code > > with these helpers > > -

Re: [ovs-dev] [PATCH v2 1/2] nsh: rework NSH netlink keys and actions

On Fri, Aug 18, 2017 at 11:02:35PM +0800, Jan Scheurich wrote: > > diff --git a/datapath/linux/compat/include/linux/openvswitch.h > > b/datapath/linux/compat/include/linux/openvswitch.h > > index bc6c94b..d7f9029 100644 > > --- a/datapath/linux/compat/include/linux/openvswitch.h > > +++

Re: [ovs-dev] [PATCH net-next v4] openvswitch: enable NSH support

On Fri, Aug 18, 2017 at 09:26:01PM +0800, Jiri Benc wrote: > On Fri, 18 Aug 2017 15:24:31 +0800, Yi Yang wrote: > > +struct nsh_md2_tlv { > > + __be16 md_class; > > + u8 type; > > + u8 length; > > + /* Followed by variable-length data. */ > > +}; > > What was wrong with the u8[] field

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Thu, Sep 14, 2017 at 05:09:02PM +0800, Jiri Benc wrote: > On Thu, 14 Sep 2017 16:37:59 +0800, Yi Yang wrote: > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can support > > NSH in compat mode

Re: [ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

On Wed, Aug 30, 2017 at 01:02:07AM +0800, Jan Scheurich wrote: > Hi Yi, > > Some more comments below. > > /Jan > > > -Original Message- > > From: Yang, Yi [mailto:yi.y.y...@intel.com] > > Sent: Tuesday, 29 August, 2017 08:31 > > To: Jan Scheur

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 08:57:44PM +0800, Jiri Benc wrote: > On Mon, 4 Sep 2017 20:09:07 +0800, Yang, Yi wrote: > > So we must do many changes if we want to break this assumption. > > We may do as many changes as we want to. This is uAPI we're talking > about and we need to

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 09:12:09PM +0800, Hannes Frederic Sowa wrote: > "Yang, Yi" <yi.y.y...@intel.com> writes: > > > We can change this later if we really find a better way to handle this > > because it isn't defined in include/uapi/linux/openvswitch.h,

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Wed, Sep 06, 2017 at 04:03:29PM +0800, Hannes Frederic Sowa wrote: > "Yang, Yi" <yi.y.y...@intel.com> writes: > >> > >> > If you check GENEVE implementation, tun_metadata* can be set or matched > >> > as any other match field. > >>

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 06:42:16PM +0800, Jiri Benc wrote: > On Mon, 4 Sep 2017 16:00:05 +0800, Yang, Yi wrote: > > how can we know next push_nsh uses the same nsh header as previous > > one? > > We store the prepopulated header together with the action. > I checked so

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Thu, Aug 31, 2017 at 06:45:16PM +0800, Jiri Benc wrote: > On Wed, 30 Aug 2017 20:39:12 +0800, Yi Yang wrote: > > + nsh->md1.context[i] = > > + OVS_MASKED(nsh->md1.context[i], key->context[i], > > + mask->context[i]); > > +

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Wed, Sep 27, 2017 at 04:59:36AM +0800, Eric Garver wrote: > On Tue, Sep 26, 2017 at 01:02:15PM +0800, Yang, Yi wrote: > > On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > > > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > > > + > &

Re: [ovs-dev] [PATCH net-next v10] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 10:42:40PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 21:52:41 +0800, Yang, Yi wrote: > > > + return ((ret != 0) ? false : true); > > > > But I don't think this is a problematic line from my understanding, > > Why not: > >

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 02:14:39AM +0800, Jiri Benc wrote: > On Mon, 25 Sep 2017 22:16:09 +0800, Yi Yang wrote: > > + return err; > > + > > + key->eth.type = htons(ETH_P_NSH); > > I wonder why you have this assignment here. The key is invalidated, > thus nothing should rely on

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > + > > + length = nsh_hdr_len(nsh_hdr); > > + skb_pull(skb, length); > > Do you need to verify you can actually pull length bytes? I don't see > any guarantee. I have

Re: [ovs-dev] [PATCH net-next v10] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 07:05:34PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 12:47:16 +0800, Yi Yang wrote: > > + return ((ret != 0) ? false : true); Jiri, I appriciate your review very carefully and professionally from my heart for 10 versions, that is really very very big effort. I

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Fri, Sep 29, 2017 at 07:10:52AM +, Jan Scheurich wrote: > > From: Yang, Yi [mailto:yi.y.y...@intel.com] > > Sent: Friday, 29 September, 2017 08:41 > > To: Pravin Shelar <pshe...@ovn.org> > > Cc: Jiri Benc <jb...@redhat.com>; net...@vger.kernel.org; &g

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Fri, Sep 29, 2017 at 02:28:38AM +0800, Pravin Shelar wrote: > On Tue, Sep 26, 2017 at 6:39 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Tue, Sep 26, 2017 at 06:49:14PM +0800, Jiri Benc wrote: > >> On Tue, 26 Sep 2017 12:55:39 +0800, Yang, Yi wrote: > >> &

Re: [ovs-dev] [PATCH v2 0/2] nsh: rework NSH netlink keys and actions

On Fri, Aug 25, 2017 at 01:39:29AM +0800, Ben Pfaff wrote: > > do the below changes: > > > > 1. change ecanp_nsh and decap_nsh to push_nsh and pop_nsh > > 2. Use nested OVS_KEY_ATTR_NSH to handle push_nsh. > > > > Patch 1 is precisely doing this way. > > Since this is targeted at 2.8, I'm only

Re: [ovs-dev] [PATCH net-next v4] openvswitch: enable NSH support

On Mon, Aug 21, 2017 at 05:47:13PM +0800, Jiri Benc wrote: > On Mon, 21 Aug 2017 17:15:42 +0800, Yang, Yi wrote: > > The issue is it is used union in > > > > struct nsh_hdr { > > ovs_be16 ver_flags_ttl_len; > > uint8_t md_type; > > uint8_t

Re: [ovs-dev] [PATCH net-next v4] openvswitch: enable NSH support

On Mon, Aug 21, 2017 at 05:47:13PM +0800, Jiri Benc wrote: > > > I don't know how we can support this, is it a must-have thing? > > What would happen if you get a GSO packet? Ports of an ovs bridge claim > GSO support, thus they may get a GSO packet. You have to handle it one > way or the other:

Re: [ovs-dev] [PATCH v2 0/2] nsh: rework NSH netlink keys and actions

On Thu, Aug 24, 2017 at 04:24:07PM -0700, Ben Pfaff wrote: > > > > Ok, I'll send patch 1 without datapath actions name change and netlink > > change, but it isn't a good result if people see encap_nsh and decep_nsh > > in 2.8 and see they are changed to push_nsh and pop_nsh in 2.9 and > > later.

Re: [ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

On Tue, Aug 29, 2017 at 07:31:22AM +0800, Jan Scheurich wrote: > Hi Yi, > > Thanks for the fixes. Please find my individual comments inline. > > BR, Jan > > > -Original Message- > > -#define OVS_ENCAP_NSH_MAX_MD_LEN 16 > > /* > > * struct ovs_action_encap_nsh -

Re: [ovs-dev] [PATCH v5 1/2] nsh: add new flow key 'ttl'

On Thu, Aug 31, 2017 at 09:27:36AM -0700, Ben Pfaff wrote: > On Thu, Aug 31, 2017 at 09:23:34AM -0700, Ben Pfaff wrote: > > On Wed, Aug 30, 2017 at 02:21:01AM +0800, Yi Yang wrote: > > > IETF NSH draft will be approved by end of August, NSH header > > > format has been finalized and won't be

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 12:42:16PM +0200, Jiri Benc wrote: > On Mon, 4 Sep 2017 16:00:05 +0800, Yang, Yi wrote: > > I think we have had similiar discussion about this, the issue is we have > > no way to handle both MD type 1 and MD type 2 by using a common flow key > > struct

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Thu, Aug 31, 2017 at 06:45:16PM +0800, Jiri Benc wrote: > > + mask->context[i]); > > + } > > + memcpy(flow_key->nsh.context, nsh->md1.context, > > + sizeof(nsh->md1.context)); > > Do you follow the discussion that Hannes

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Wed, Aug 30, 2017 at 05:53:27PM +0800, Hannes Frederic Sowa wrote: > Hello, > > Yi Yang writes: > > [...] > > > +struct ovs_key_nsh { > > + u8 flags; > > + u8 ttl; > > + u8 mdtype; > > + u8 np; > > + __be32 path_hdr; > > + __be32

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 07:22:26PM +0800, Hannes Frederic Sowa wrote: > Hello, > > "Yang, Yi" <yi.y.y...@intel.com> writes: > > > On Wed, Aug 30, 2017 at 05:53:27PM +0800, Hannes Frederic Sowa wrote: > >> Hello, >

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 12:30:09PM +0200, Hannes Frederic Sowa wrote: > "Yang, Yi" <yi.y.y...@intel.com> writes: > > > I'm not sure what new action you expect to bring here, I think group > > action is just for this, as you said it isn't only bound to N

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 11:47:41AM +0200, Jiri Benc wrote: > On Tue, 5 Sep 2017 14:37:05 +0800, Yang, Yi wrote: > > I checked source code but can't find where we can prepopulate it and how > > we can deliver the prepopulated header to push_nsh, can you expand it in > > orde

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 11:46:45AM +0200, Jiri Benc wrote: > On Tue, 5 Sep 2017 13:51:45 +0800, Yang, Yi wrote: > > But if we follow your way, how does nla_for_each_nested handle such > > pattern? > > > > attribute1 > > attribute1_mask > > attrib

Re: [ovs-dev] [PATCH net-next v12] openvswitch: enable NSH support

On Thu, Oct 19, 2017 at 05:19:55AM +0800, Jiri Benc wrote: > On Mon, 16 Oct 2017 21:53:29 +0800, Yi Yang wrote: > > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key, > > + const struct nlattr *a) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + int

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Sat, Nov 04, 2017 at 10:29:46PM +0800, Pravin Shelar wrote: > On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > > +{ > > + struct nshhdr *nh; > > + size_t length = nsh_hdr_len(pushed_nh); >

Re: [ovs-dev] [PATCH] nsh: Fix packet format to match IETF NSH draft.

On Thu, Nov 02, 2017 at 04:51:52AM +0800, Ben Pfaff wrote: > The NSH draft added a TTL field. This adds basic support. > > CC: Yi Yang > CC: Jan Scheurich > Signed-off-by: Ben Pfaff > --- > include/openvswitch/nsh.h | 11

Re: [ovs-dev] [PATCH v5 1/2] nsh: add new flow key 'ttl'

On Thu, Nov 02, 2017 at 04:53:15AM +0800, Ben Pfaff wrote: > On Wed, Aug 30, 2017 at 02:21:01AM +0800, Yi Yang wrote: > > IETF NSH draft will be approved by end of August, NSH header > > format has been finalized and won't be change anymore, so we > > need to follow this final spec to implement

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > > > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang <yi.y.y...@intel.co

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc <jb...@redhat.com&g

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 05:01:28AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi <yi.y.y...@intel.com>

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: > >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > >> > +{ > >> > + struct

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang <yi.y.y...@intel.co

Re: [ovs-dev] [PATCH v6 0/4] nsh: add new nsh key ttl and action dec_nsh_ttl

On Sat, Dec 09, 2017 at 12:42:32AM +0800, Gregory Rose wrote: > On 12/8/2017 6:04 AM, Yi Yang wrote: > > v5->v6 > >- Rebase v5 to master > >- Refactor netlink message format to align to NSH kernel > > implementation > >- Add dec_nsh_ttl unit test into tests/nsh.at > >- Fix

Re: [ovs-dev] [PATCH v6 0/4] nsh: add new nsh key ttl and action dec_nsh_ttl

On Tue, Dec 12, 2017 at 03:15:49AM +0800, Gregory Rose wrote: > On 12/11/2017 10:55 AM, Ben Pfaff wrote: > > On Mon, Dec 11, 2017 at 10:25:54AM -0800, Gregory Rose wrote: > >> On 12/10/2017 4:39 PM, Yang, Yi wrote: > >>> On Sat, Dec 09, 2017 at 12:42:32AM +0800, Greg

Re: [ovs-dev] [PATCH net-next v13] openvswitch: enable NSH support

On Mon, Oct 30, 2017 at 10:01:34AM +0900, David Miller wrote: > From: Yi Yang > Date: Thu, 26 Oct 2017 15:45:16 +0800 > > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can

Re: [ovs-dev] [PATCH net-next v14] openvswitch: enable NSH support

On Wed, Nov 01, 2017 at 04:08:22AM +0800, Jiri Benc wrote: > On Mon, 30 Oct 2017 09:29:34 +0800, Yi Yang wrote: > > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key, > > + const struct nlattr *a) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + int

Re: [ovs-dev] [PATCH net-next v14] openvswitch: enable NSH support

On Wed, Nov 01, 2017 at 03:57:41AM +0800, Eric Garver wrote: > On Mon, Oct 30, 2017 at 09:29:34AM +0800, Yi Yang wrote: > [...] > > +int nsh_pop(struct sk_buff *skb) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + __be16 inner_proto; > > + > > + if (!pskb_may_pull(skb,

Re: [ovs-dev] [PATCH v2 1/2] userspace datapath: Add GTP-U tunnel support

On Thu, May 17, 2018 at 05:11:24AM +0800, Aaron Conole wrote: > Yi Yang writes: > > Hi Yi, > > Thanks for the patch! Just a brief review. > Aaron, thank you so much for your quick review. > > > > Signed-off-by: Feng Yang > > Signed-off-by: Jiannan

Re: [ovs-dev] [PATCH net-next v12] openvswitch: enable NSH support

On Thu, Oct 19, 2017 at 02:43:47PM +0200, Jiri Benc wrote: > On Thu, 19 Oct 2017 19:40:53 +0800, Yang, Yi wrote: > > Actually mdtype can't be set, only push_nsh can set mdtype, so set_nsh > > won't have mdtype flow key, we can't get it from flow_key in set_nsh, > > only ttl, f

Re: [ovs-dev] [PATCH net-next v12] openvswitch: enable NSH support

On Thu, Oct 19, 2017 at 03:41:18PM +0200, Jiri Benc wrote: > On Thu, 19 Oct 2017 21:12:15 +0800, Yang, Yi wrote: > > flow_key in set_nsh is got from netlink message which is set by > > commit_nsh in user space, here is code. > > Isn't this the 'key' local variable that you're

Re: [ovs-dev] [PATCH net-next v12] openvswitch: enable NSH support

On Fri, Oct 20, 2017 at 04:05:35PM +0800, Jiri Benc wrote: > On Fri, 20 Oct 2017 05:53:12 +0800, Yang, Yi wrote: > > For push_nsh, my typical use scinario is push_nsh then set then output > > to vxlangpe port. > > Okay. Then I just need to do the below change against v

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > > > Signed-off-by: Yi Yang > > > In odp_execute_actions(), this looks bogus: there is nothing to > guarantee that 'buffer' is properly aligned for

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > Signed-off-by: Yi Yang > > This fails to build with Clang (and, I would guess, MSVC): > ../lib/odp-execute.c:497:21: error: fields must have a

Re: [ovs-dev] [PATCH v7 4/4] nsh: add dec_nsh_ttl action

On Tue, Jan 09, 2018 at 08:14:07AM +0800, Ben Pfaff wrote: > On Sat, Jan 06, 2018 at 01:47:54PM +0800, Yi Yang wrote: > > NSH ttl is a 6-bit field ranged from 0 to 63, it should be > > decremented by 1 every hop, if it is 0 or it is so after > > decremented, the packet should be dropped and a

Re: [ovs-dev] [PATCH v7 2/4] nsh: add new flow key 'ttl'

On Tue, Jan 09, 2018 at 08:11:15AM +0800, Ben Pfaff wrote: > On Sat, Jan 06, 2018 at 01:47:52PM +0800, Yi Yang wrote: > > IETF NSH draft added a new filed ttl in NSH header, this patch > > is to add new nsh key 'ttl' for it. > > > > Signed-off-by: Yi Yang > > Thanks for v7!

Re: [ovs-dev] [PATCH v8 1/3] nsh: add new flow key 'ttl'

On Thu, Jan 11, 2018 at 06:50:35AM +0800, Ben Pfaff wrote: > On Tue, Jan 09, 2018 at 09:56:16PM +0800, Yi Yang wrote: > > IETF NSH draft added a new filed ttl in NSH header, this patch > > is to add new nsh key 'ttl' for it. > > > > Signed-off-by: Yi Yang > > Thanks for the

Re: [ovs-dev] [PATCH v8 3/3] nsh: add dec_nsh_ttl action

On Thu, Jan 11, 2018 at 06:52:00AM +0800, Ben Pfaff wrote: > On Tue, Jan 09, 2018 at 09:56:18PM +0800, Yi Yang wrote: > > NSH ttl is a 6-bit field ranged from 0 to 63, it should be > > decremented by 1 every hop, if it is 0 or it is so after > > decremented, the packet should be dropped and a

Re: [ovs-dev] [PATCH v8 3/3] nsh: add dec_nsh_ttl action

On Thu, Jan 11, 2018 at 07:02:29AM +0800, Ben Pfaff wrote: > On Wed, Jan 10, 2018 at 02:52:00PM -0800, Ben Pfaff wrote: > > On Tue, Jan 09, 2018 at 09:56:18PM +0800, Yi Yang wrote: > > > NSH ttl is a 6-bit field ranged from 0 to 63, it should be > > > decremented by 1 every hop, if it is 0 or it

Re: [ovs-dev] [PATCH v9 1/3] nsh: add new flow key 'ttl'

On Fri, Jan 12, 2018 at 03:50:17AM +0800, Ben Pfaff wrote: > On Thu, Jan 11, 2018 at 01:24:01PM +0800, Yi Yang wrote: > > IETF NSH draft added a new filed ttl in NSH header, this patch > > is to add new nsh key 'ttl' for it. > > > > Signed-off-by: Yi Yang > > Thanks, I

Re: [ovs-dev] [PATCH v2 0/5] datapath: enable NSH support in kernel compat mode

On Thu, Feb 08, 2018 at 05:17:56AM +0800, Gregory Rose wrote: > On 2/7/2018 10:46 AM, Ben Pfaff wrote: > > On Fri, Feb 02, 2018 at 10:23:04AM -0800, Gregory Rose wrote: > >> On 1/31/2018 5:53 AM, Yi Yang wrote: > >>> v1->v2 > >>> - Fix compilation error in linux-3.10.107 > >>> > >>> This patch

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

*a) case OFPACT_WRITE_METADATA: case OFPACT_DEBUG_RECIRC: case OFPACT_DEBUG_SLOW: +case OFPACT_ENCAP: +case OFPACT_DECAP: +case OFPACT_DEC_NSH_TTL: return false; default: OVS_NOT_REACHED(); On Mon, Mar 26, 2018 at 12:45:46AM +, Yang, Yi Y wrote: >

[ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

Hi, guys A NSH user found OVS will hit the below assert in function commit_set_nsh_action in file lib/odp-util.c if encap(nsh) is done in bucket of group ovs_assert(flow->nsh.mdtype == base_flow->nsh.mdtype && flow->nsh.np == base_flow->nsh.np); But it isn't an issue if

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

ow br-int in_port=4,icmp,actions=group:111 Then I run ping by this cmd "sudo ip netns exec app ping -c 1 192.168.2.2", it will hit flow "in_port=4,icmp,actions=group:111", then result in this assert. > > > -Original Message- > > From: Yang, Yi [m

Re: [ovs-dev] [PATCH v1 1/2] userspace datapath: Add GTP-U tunnel support

On Mon, Mar 05, 2018 at 04:19:58AM +0800, Joe Stringer wrote: > ?On 2 March 2018 at 04:32, Yi Yang wrote: > > > > Signed-off-by: Feng Yang > > Signed-off-by: Yi Yang > > --- > > Hi Yi, thanks for this work. Some minor comments

Re: [ovs-dev] [PATCH v1 1/2] userspace datapath: Add GTP-U tunnel support

On Sun, Mar 04, 2018 at 07:40:49PM -0800, Joe Stringer wrote: > On 4 March 2018 at 18:48, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Mon, Mar 05, 2018 at 04:19:58AM +0800, Joe Stringer wrote: > >> ?On 2 March 2018 at 04:32, Yi Yang <yi.y.y...@intel.com> wrote

Re: [ovs-dev] [PATCH v1 1/2] userspace datapath: Add GTP-U tunnel support

On Sun, Mar 04, 2018 at 09:59:18PM -0800, Joe Stringer wrote: > On 4 March 2018 at 19:58, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Sun, Mar 04, 2018 at 07:40:49PM -0800, Joe Stringer wrote: > >> On 4 March 2018 at 18:48, Yang, Yi <yi.y.y...@intel.com> wrote: >

Re: [ovs-dev] [PATCH v1 1/2] userspace datapath: Add GTP-U tunnel support

On Mon, Mar 05, 2018 at 04:19:58AM +0800, Joe Stringer wrote: > ?On 2 March 2018 at 04:32, Yi Yang wrote: > > From: Feng Yang > > > > + > > +csum = csum_continue(csum, udp, ip_tot_size); > > +udp->udp_csum = csum_finish(csum); > > + > > +

Re: [ovs-dev] [PATCH 0/3] Backport 802.1ad patches

, Yi Y Sent: Friday, February 3, 2017 11:12 PM To: d...@openvswitch.org Cc: pshe...@ovn.org; Yang, Yi Y <yi.y.y...@intel.com> Subject: [PATCH 0/3] Backport 802.1ad patches This patch set is to backport 802.1ad patches Eric Garver did to ovs, per discussion in ovs-dev mailing list, this fix

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

[mailto:j...@ovn.org] Sent: Tuesday, February 7, 2017 8:34 AM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: ovs dev <d...@openvswitch.org>; Yi-Hung Wei <yihung@gmail.com> Subject: Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs On 6 February 2017 at 05:04, Yi Yang &l

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

6:50 PM To: Yang, Yi Y <yi.y.y...@intel.com>; d...@openvswitch.org Cc: Zoltán Balogh <zoltan.bal...@ericsson.com>; Jarno Rajahalme (ja...@ovn.org) <ja...@ovn.org> Subject: RE: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs Hi Yi, Three of the user-space patches o

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

Then, are you merging https://mail.openvswitch.org/pipermail/ovs-dev/2017-February/328492.html or do I need to do anything else for it? -Original Message- From: Joe Stringer [mailto:j...@ovn.org] Sent: Thursday, February 9, 2017 9:44 AM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: o

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

To: Yang, Yi Y <yi.y.y...@intel.com> Cc: ovs dev <d...@openvswitch.org>; Yi-Hung Wei <yihung@gmail.com> Subject: Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs On 7 February 2017 at 09:44, Joe Stringer <j...@ovn.org> wrote: > On 6 February 2017 a

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

will merge them in. I can only focus on userspace support for vxlan-gpe if ovs maintainers really merge your patches first. -Original Message- From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] Sent: Thursday, February 9, 2017 5:50 PM To: Yang, Yi Y <yi.y.y...@intel.com>

Re: [ovs-dev] [PATCH v2 3/4] datapath: backport: vlan: Check for vlan ethernet types for 8021.q or 802.1ad

Thanks Eric, I see, they were missing, I'll add them as you said. -Original Message- From: Eric Garver [mailto:e...@erig.me] Sent: Thursday, February 9, 2017 11:37 PM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 3/4] datapath: ba

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

Ok, let me push 802.1 ad backport patches first. -Original Message- From: Jan Scheurich [mailto:jan.scheur...@web.de] Sent: Friday, February 10, 2017 7:04 AM To: Yang, Yi Y <yi.y.y...@intel.com>; Jan Scheurich <jan.scheur...@ericsson.com>; Joe Stringer <j...@ovn.org&g

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

missed something. -Original Message- From: Joe Stringer [mailto:j...@ovn.org] Sent: Friday, February 10, 2017 8:01 AM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: ovs dev <d...@openvswitch.org>; Yi-Hung Wei <yihung@gmail.com> Subject: Re: [ovs-dev] [PATCH v3 00/16] p

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

Eric and Joe, thank you so much for your verification and fix, I'll resubmit a new version including this fix and missing part. -Original Message- From: Eric Garver [mailto:e...@erig.me] Sent: Saturday, February 11, 2017 9:22 PM To: Joe Stringer <j...@ovn.org>; Yang, Yi Y &

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

Joe, got it, thanks a lot. -Original Message- From: Joe Stringer [mailto:j...@ovn.org] Sent: Saturday, February 11, 2017 5:38 AM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: Multanen, Eric W <eric.w.multa...@intel.com>; ovs dev <d...@openvswitch.org>; Yi-Hung Wei <

Re: [ovs-dev] [PATCH v2 15/17] datapath: enable vxlangpe creation in compat mode

Make sense, will change it in v3. -Original Message- From: Jiri Benc [mailto:jb...@redhat.com] Sent: Wednesday, January 18, 2017 12:37 AM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 15/17] datapath: enable vxlangpe creation in

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

sted in ovs-dev, I can help with this if you have no time. -Original Message- From: Pravin Shelar [mailto:pshe...@ovn.org] Sent: Monday, January 9, 2017 5:33 PM To: Yang, Yi Y <yi.y.y...@intel.com>; Eric Garver <e...@erig.me> Cc: ovs dev <d...@openvswitch.org>; Jarno Ra

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

org>; Jan Scheurich <jan.scheur...@web.de> Subject: Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames On Thu, Jan 19, 2017 at 03:12:20PM -0800, Joe Stringer wrote: > On 19 January 2017 at 12:17, Pravin Shelar <pshe...@ovn.org> wrote: > > On We

[ovs-dev] Can we use ovs to implement load balancer by openflow?

Hi, all Can we use ovs to implement load balancer? Our target is to let ovs distribute the traffic to different service VMs based on 5 tuple (src ip, dst ip, src port, dst port, transport protocol). ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] Can we use ovs to implement load balancer by openflow?

tions=group:100" -Original Message- From: Jarno Rajahalme [mailto:ja...@ovn.org] Sent: Wednesday, March 1, 2017 3:02 AM To: Han Zhou <zhou...@gmail.com> Cc: Yang, Yi Y <yi.y.y...@intel.com>; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] Can we use ovs to implement load bal

Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

l3 patches and vxlangpe patches and resubmit them based on your tree. -Original Message- From: Joe Stringer [mailto:j...@ovn.org] Sent: Thursday, March 2, 2017 11:43 AM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: ovs dev <d...@openvswitch.org>; Jarno Rajahalme <ja...@ovn.o

[ovs-dev] FW: OVS 2.6.1 DPDK 16.07 issue: pthread_mutex_lock failed (Resource deadlock avoided) in

Hi, all I found this issue when I use ovs 2.6.1 and dpdk 16.07, the error is located in the line "ovs_mutex_lock(>mutex);" in get_stats() in lib/netdev-vport.c, it looks like a deadlock is detected, so resulted in ovs-vswitchd coredump, anybody noticed this issue? How can we fix it? this has

Re: [ovs-dev] FW: OVS 2.6.1 DPDK 16.07 issue: pthread_mutex_lock failed (Resource deadlock avoided) in

, 2016 9:01 AM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: d...@openvswitch.org Subject: Re: [ovs-dev] FW: OVS 2.6.1 DPDK 16.07 issue: pthread_mutex_lock failed (Resource deadlock avoided) in 2016-11-15 6:34 GMT-08:00 Yang, Yi Y <yi.y.y...@intel.com<mailto:yi.y.y...@intel.com>>

Re: [ovs-dev] [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

Got it, thanks, I'll follow your discussion thread. -Original Message- From: Thadeu Lima de Souza Cascardo [mailto:casca...@cascardo.eti.br] Sent: Wednesday, November 16, 2016 3:01 AM To: Yang, Yi Y <yi.y.y...@intel.com>; Jiri Benc <jb...@redhat.com>; net...@vger.kern

  1   2   >