[ovs-dev] [PATCH] ofproto: Uses the VLOG_WARN_RL instead of VLOG_WARN.

2017-02-06 Thread nickcooper-zhangtonghao
There are a lot of logs when OvS bridges, connected to controllers, can't find the right routes. So we may use the VLOG_WARN_RL instead of VLOG_WARN to limit the log messages. The netdev-open and arp-lookingup are in the same case in this function. Signed-off-by: nickcooper-zhangtonghao &l

[ovs-dev] [PATCH 2/3] ofproto/bond: balance-tcp mode fallbacks to active-backup mode.

2017-02-07 Thread nickcooper-zhangtonghao
-backup mode is used. But if users configure the bond port to balance-slb and lacp (unsuccessfully), active-backup mode is also used. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-)

[ovs-dev] [PATCH 1/3] ofproto/bond: Drops traffic in balance-tcp mode without lacp.

2017-02-07 Thread nickcooper-zhangtonghao
The balance-tcp mode requires the upstream switch to support 802.3ad with successful LACP negotiation. When bond ports are configured to balance-tcp mode without lacp or lacp is disabled, drop the traffic. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.

Re: [ovs-dev] [BUG] upcall handler thread crash

2017-02-04 Thread nickcooper-zhangtonghao
Hi, what’s the OvS version you tested. I didn’t get the crash with master version. The test script is described as below. ovs-vsctl add-br br0 ovs-vsctl add-port br0 eth1 for i in `seq 0 1000`; do ovs-vsctl add-port br0 eth2 ovs-vsctl del-port br0 eth2 done Thanks. Nick > On Feb 4,

[ovs-dev] [PATCH] doc: Fix issues.rst formatting typo.

2017-02-20 Thread nickcooper-zhangtonghao
The preformatted block is only finished when the text falls back to the same indentation level as a paragraph prior to the preformatted block. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- Documentation/faq/issues.rst | 4 +++- 1 file changed, 3 insertions(+), 1 de

Re: [ovs-dev] [PATCH] ofproto/bond: Fix bond/show when all interfaces are disabled

2017-02-16 Thread nickcooper-zhangtonghao
> On Feb 17, 2017, at 4:49 AM, Andy Zhou wrote: > > Without this patch, when all slaves are disabled, the 'bond/show' > command still shows the mac address of last active slave in > 'active slave mac' output. This patch clears them to zeros. > > Signed-off-by: Andy Zhou

[ovs-dev] [PATCH 3/4] ofproto/bond: balance-slb mode fallbacks to active-backup mode.

2017-02-13 Thread nickcooper-zhangtonghao
-backup mode is used. But if users configure the bond port to balance-slb and lacp (unsuccessfully), active-backup mode is also used. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-)

[ovs-dev] [PATCH 4/4] doc: Updates bonding.rst because of api changed.

2017-02-13 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- Documentation/topics/bonding.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/topics/bonding.rst b/Documentation/topics/bonding.rst index 2f67cbb..461935a 100644 --- a/Documen

[ovs-dev] [PATCH 2/4] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

2017-02-13 Thread nickcooper-zhangtonghao
The balance-tcp mode requires the upstream switch to support 802.3ad with successful LACP negotiation. When bond ports are configured to balance-tcp mode without lacp or lacp is disabled, drop the traffic. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.

[ovs-dev] [PATCH 1/4] ofproto/bond: Validate active-slave mac.

2017-02-13 Thread nickcooper-zhangtonghao
and mac in the ovsdb is also zero. The active_slave_mac and active_slave_changed should be initialized when created. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ofproto/bond.c b/o

[ovs-dev] [PATCH] dpdk: Improve manpage for dpdk memory configuration.

2017-02-09 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/vswitch.xml | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 146a816..a3beafd 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswit

Re: [ovs-dev] [PATCH 3/4] ofproto/bond: balance-slb mode fallbacks to active-backup mode.

2017-02-15 Thread nickcooper-zhangtonghao
> On Feb 15, 2017, at 12:01 PM, Andy Zhou <az...@ovn.org> wrote: > > On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao > <n...@opencloud.tech <mailto:n...@opencloud.tech>> wrote: >> lacp-fallback-ab determines the behavior of OvS bond in LACP

Re: [ovs-dev] [PATCH 2/4] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

2017-02-14 Thread nickcooper-zhangtonghao
> On Feb 15, 2017, at 11:51 AM, Andy Zhou <az...@ovn.org> wrote: > > On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao > <n...@opencloud.tech <mailto:n...@opencloud.tech>> wrote: >> The balance-tcp mode requires the upstream switch to support 802.3ad

[ovs-dev] [PATCH] ovs-appctl: Print lacp_fallback_ab info in "bond/show".

2017-02-16 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.c | 3 +++ tests/lacp.at | 9 + 2 files changed, 12 insertions(+) diff --git a/ofproto/bond.c b/ofproto/bond.c index 2e018aa..de75f87 100644 --- a/ofproto/bond.c +++ b/ofproto/bond.c @@ -1325,6 +

[ovs-dev] [PATCH v2] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

2017-02-15 Thread nickcooper-zhangtonghao
The balance-tcp mode requires the upstream switch to support 802.3ad with successful LACP negotiation. When bond ports are configured to balance-tcp mode without lacp or lacp is disabled, drop the traffic. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond

[ovs-dev] [PATCH] dpif-netdev: Avoids repeated addition of DP_STAT_LOST.

2017-01-16 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/dpif-netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 08167b5..3901129 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4258,7 +4258,6 @@ fast_path_proc

[ovs-dev] [PATCH 2/3] dpdk: Improve manpage for dpdk memory configuration.

2017-03-02 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/vswitch.xml | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 782417f..a91be59 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswit

[ovs-dev] [PATCH 1/3] doc: Fix issues.rst formatting typo.

2017-03-02 Thread nickcooper-zhangtonghao
The preformatted block is only finished when the text falls back to the same indentation level as a paragraph prior to the preformatted block. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- Documentation/faq/issues.rst | 4 +++- 1 file changed, 3 insertions(+), 1 de

[ovs-dev] [PATCH 3/3] lacp: Fix formatting typo.

2017-03-02 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/lacp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/lacp.c b/lib/lacp.c index 64c9849..7716387 100644 --- a/lib/lacp.c +++ b/lib/lacp.c @@ -337,7 +337,7 @@ lacp_process_packet(struct lacp

[ovs-dev] [PATCH 4/4] ovs-tcpdump: destroy_mirror should really destroy the mirror.

2016-11-07 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index d03568d..4b114f2 100755 --- a/utilities/ovs-tcpdump.in +++ b/utiliti

Re: [ovs-dev] [PATCH 2/4] ovs-tcpdump: should't halt when dumping traffic.

2016-11-08 Thread nickcooper-zhangtonghao
> On Nov 9, 2016, at 1:43 AM, Aaron Conole <acon...@redhat.com> wrote: > > nickcooper-zhangtonghao <n...@opencloud.tech <mailto:n...@opencloud.tech>> > writes: > >> when sys.stdin is passed to tcpdump via pipe, >> it will cause tcpdump to halt. >

[ovs-dev] [PATCH 1/4] ovs-tcpdump: Remove the newline from readline().

2016-11-07 Thread nickcooper-zhangtonghao
When using ovs-tcpdump, we always get the white line. Remove newline from readline() and ovs-tcpdump will format the output as tcpdump tool. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[ovs-dev] [PATCH 1/4] ovs-tcpdump: Remove the newline from readline().

2016-11-07 Thread nickcooper-zhangtonghao
When using ovs-tcpdump, we always get the white line. Remove newline from readline() and ovs-tcpdump will format the output as tcpdump tool. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[ovs-dev] [PATCH 3/4] ovs-tcpdump: Fix error handling when parsing parameter.

2016-11-07 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index c189bc8..d03568d 100755 --- a/utilities/ovs-tcpdump.in +++ b/utiliti

[ovs-dev] [PATCH 3/4] ovs-tcpdump: Fix error handling when parsing parameter.

2016-11-07 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index c189bc8..d03568d 100755 --- a/utilities/ovs-tcpdump.in +++ b/utiliti

[ovs-dev] [PATCH 2/4] ovs-tcpdump: should't halt when dumping traffic.

2016-11-07 Thread nickcooper-zhangtonghao
when sys.stdin is passed to tcpdump via pipe, it will cause tcpdump to halt. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index 01e1f6d..c

[ovs-dev] [PATCH 0/4] Fix ovs-tcpdump bugs

2016-11-07 Thread nickcooper-zhangtonghao
Each patch fixes a different issue. nickcooper-zhangtonghao (4): ovs-tcpdump: Remove the newline from readline(). ovs-tcpdump: should't halt when dumping traffic. ovs-tcpdump: Fix error handling when parsing parameter. ovs-tcpdump: destroy_mirror should really destroy the mirror

[ovs-dev] [PATCH v2 3/4] ovs-tcpdump: destroy_mirror should really destroy the mirror.

2016-11-14 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index c189bc8..96aa1e2 100755 --- a/utilities/ovs-tcpdump.in +++ b/utiliti

Re: [ovs-dev] [PATCH 2/4] ovs-tcpdump: should't halt when dumping traffic.

2016-11-14 Thread nickcooper-zhangtonghao
, >> it will cause tcpdump to halt. >> >> Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> >> --- > > Can you give an example of the keys you pressed that elicit the >

[ovs-dev] [PATCH v2 0/4] Fix ovs-tcpdump bugs.

2016-11-14 Thread nickcooper-zhangtonghao
Each patch fixes a different issue. nickcooper-zhangtonghao (4): ovs-tcpdump: Remove the newline from readline(). ovs-tcpdump: should't halt when dumping traffic. ovs-tcpdump: destroy_mirror should really destroy the mirror. ovs-tcpdump: Fix error handling when parsing parameter

[ovs-dev] [PATCH v2 2/4] ovs-tcpdump: should't halt when dumping traffic.

2016-11-14 Thread nickcooper-zhangtonghao
when sys.stdin is passed to tcpdump via pipe, it will cause tcpdump to halt. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index 01e1f6d..c

[ovs-dev] [PATCH v2 1/4] ovs-tcpdump: Remove the newline from readline().

2016-11-14 Thread nickcooper-zhangtonghao
When using ovs-tcpdump, we always get the white line. Remove newline from readline() and ovs-tcpdump will format the output as tcpdump tool. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- utilities/ovs-tcpdump.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [ovs-dev] [CudaMailTagged] [PATCH 1/4] ovn: Support DNAT with port.

2016-11-14 Thread nickcooper-zhangtonghao
Hi Guru Shetty Because of public ip restrictions , I have different private IPs sharing a single outbound internet IP. The VMs with different private IPs will run different services(e.g. web, email, dns service). I hope OVN will support that feature. The patches I submitted may be not good

Re: [ovs-dev] [PATCH 1/4] ovn: Support DNAT with port.

2016-11-15 Thread nickcooper-zhangtonghao
Hi Guru Shetty. LB may support DNAT with port. But in some case, there is only a public ip address set on the gateway router, which is connected to multiple VMs. Thus this public ip address need to be projected to multiple private ip address. They denote a one to many relationship not one to

Re: [ovs-dev] [PATCH 3/4] ovs-tcpdump: Fix error handling when parsing parameter.

2016-11-13 Thread nickcooper-zhangtonghao
Hi Aaron You ignore an error case. Run the tcpdump with invalid option or argument. In this case, process will raise directly KeyboardInterrupt exception, not run the while loop any more. We should return an error code with sys.exit(1). What’s more, in this error case, the subprocess has exited

Re: [ovs-dev] [PATCH 4/4] ovs: optimize 'ip_parse_port' function.

2016-11-21 Thread nickcooper-zhangtonghao
Hi Guru Shetty I folded in the following minor incremental just because ovs_scan_len() is only really meant for situations where the 'n' offset is being incremented over several calls. Thanks. Nick > On Nov 19, 2016, at 2:35 AM, Guru Shetty wrote: > > Can you tell why one is

Re: [ovs-dev] [PATCH 1/4] ovn: Support DNAT with port.

2016-11-15 Thread nickcooper-zhangtonghao
I got it. Thank you explaining this. Can you review the v1 of NAT command, and other patches ? Thanks very much. http://patchwork.ozlabs.org/patch/680778/ http://patchwork.ozlabs.org/patch/680777/

Re: [ovs-dev] [PATCH 1/4] ovs-vswitchd: Avoid segfault for "netdev" datapath.

2016-12-07 Thread nickcooper-zhangtonghao
Hi Ben and Daniele, Thanks for your tips. I submitted the patch again. The test has been added. May I also add “Signed-off-by: Daniele Di Proietto ” ? Thanks. Nick > On Dec 7, 2016, at 7:51 AM, Daniele Di Proietto wrote: > > Thanks for the patch >

Re: [ovs-dev] request for assistance with Debian maintenance

2016-12-07 Thread nickcooper-zhangtonghao
Hi Ben. If there were not better man for this job,i may make a contribution to openvswitch and do a good job with it . It is a really intersting job and probably is the most worthwhile to invest more time developing and learning . I submited patches for openvswitch and ovn. However if

[ovs-dev] [PATCH v2 1/2] ovs-sandbox: add '--vswitchd-unforced-dummy' option.

2016-12-07 Thread nickcooper-zhangtonghao
The ovs-sandbox runs in the "dummy mode" by default. In this mode of testing, no packets travel across physical or virtual networks. But sometimes, we may create veth network devices and add them to ovs bridge for developing and testing. It's necessary to add an option. Signed-off-by:

Re: [ovs-dev] [PATCH 1/3] datapath: Checks the MTU for netdev-internal ports.

2016-12-12 Thread nickcooper-zhangtonghao
Thanks Jarno, I will try it. Thanks. Nick > On Dec 13, 2016, at 4:58 AM, Jarno Rajahalme wrote: > > We should first backport this upstream commit and see if there is anything > left to fix. Either way, Linux kernel datapath fixes should be first fixed on > the upstream net-next

[ovs-dev] [PATCH 1/3] datapath: Checks the MTU for netdev-internal ports.

2016-12-11 Thread nickcooper-zhangtonghao
We should check the MTU before changing it. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- datapath/vport-internal_dev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c index 482af37..5

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

2017-01-09 Thread nickcooper-zhangtonghao
Yes, but this patch looks good to me. > On Jan 9, 2017, at 11:35 PM, Aaron Conole <acon...@redhat.com> wrote: > > nickcooper-zhangtonghao <n...@opencloud.tech <mailto:n...@opencloud.tech>> > writes: > >> hi Daniele, >> I reviewed thi

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

2017-01-09 Thread nickcooper-zhangtonghao
Thank you for explaining this to me. I got it. > On Jan 10, 2017, at 10:09 AM, Daniele Di Proietto > wrote: > >> >> >> >> hi Daniele, >> I reviewed this patch. One question to ask: should we check the >> hugepage mm before calling the rte_eal_init()? improvement on

Re: [ovs-dev] [PATCH v2] netdev-dummy: Limits the number of tx/rx queues.

2017-01-09 Thread nickcooper-zhangtonghao
may be appropriate, >> because the dpdk uses it as an default max value. >> >> Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> >> --- > > I don't understand how this change impacts the ovs_rcu warning,

Re: [ovs-dev] [PATCH 2/4] datapath: Limits the number of tx/rx queues for netdev-dummy.

2017-01-09 Thread nickcooper-zhangtonghao
Thanks, I got it. :) > On Jan 10, 2017, at 10:11 AM, Daniele Di Proietto <diproiet...@ovn.org> wrote: > > 2017-01-08 20:02 GMT-08:00 nickcooper-zhangtonghao <n...@opencloud.tech > <mailto:n...@opencloud.tech>>: >> Thanks Daniele, >> Yes, it’s a small

[ovs-dev] [PATCH v3] netdev-dummy: Limits the number of tx/rx queues.

2017-01-09 Thread nickcooper-zhangtonghao
This patch avoids the ovs_rcu to report WARN, caused by blocked for a long time, when ovs-vswitchd processes a port with many rx/tx queues. The number of tx/rx queues per port may be appropriate, because the dpdk uses it as an default max value. Signed-off-by: nickcooper-zhangtonghao &l

[ovs-dev] [PATCH 1/4] ovs-vswitchd: Avoid segfault for "netdev" datapath.

2016-12-06 Thread nickcooper-zhangtonghao
bridge_run__ vswitchd/bridge.c:2875 #15 0x0040f145 bridge_run vswitchd/bridge.c:2938 #16 0x004062e5 main vswitchd/ovs-vswitchd.c:111 Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/dpif-netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[ovs-dev] [PATCH 4/4] ovs-appctl: Add usage content to "upcall/set-flow-limit" command.

2016-12-06 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif-upcall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 84f1de2..6cb9c2e 100644 --- a/ofproto/ofproto-dpif-up

[ovs-dev] [PATCH 2/4] ovs-sandbox: add '-u, --disable-dummy' options.

2016-12-06 Thread nickcooper-zhangtonghao
The ovs-sandbox runs in the "dummy mode" by default. In this mode of testing, no packets travel across physical or virtual networks. But sometimes, we may create veth network devices and add them to ovs bridge for developing and testing. It's necessary to add an option. Signed-off-by:

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

2017-01-09 Thread nickcooper-zhangtonghao
hi Daniele, I reviewed this patch. One question to ask: should we check the hugepage mm before calling the rte_eal_init()? improvement on next version? Thanks. Nick > On Jan 9, 2017, at 11:21 AM, Daniele Di Proietto > wrote: > > With this commit, we allow the user to

[ovs-dev] [PATCH v2] netdev-dummy: Limits the number of tx/rx queues.

2017-01-09 Thread nickcooper-zhangtonghao
This patch avoids the ovs_rcu to report WARN, caused by blocked for a long time, when ovs-vswitchd processes a port with many rx/tx queues. The number of tx/rx queues per port may be appropriate, because the dpdk uses it as an default max value. Signed-off-by: nickcooper-zhangtonghao &l

[ovs-dev] [PATCH 4/4] datapath: Uses the OVS_CORE_UNSPEC instead of magic numbers.

2017-01-08 Thread nickcooper-zhangtonghao
This patch uses OVS_CORE_UNSPEC for the queue unpinned instead of "-1". More important, the "-1" casted to unsigned int is equal to NON_PMD_CORE_ID. We make the distinction between them. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/dpif-netdev.c

[ovs-dev] [PATCH 3/4] datapath: Uses the NR_QUEUE instead of magic numbers.

2017-01-08 Thread nickcooper-zhangtonghao
The NR_QUEUE is defined in "lib/dpif-netdev.h", netdev-dpdk uses it instead of magic number. netdev-dummy should be in the same case. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/netdev-dummy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[ovs-dev] [PATCH 1/4] datapath: Fix formatting typo.

2017-01-08 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 625f425..376aa4d 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -738,7

Re: [ovs-dev] [PATCH 2/4] datapath: Limits the number of tx/rx queues for netdev-dummy.

2017-01-08 Thread nickcooper-zhangtonghao
Di Proietto <diproiet...@ovn.org> wrote: > > 2017-01-08 17:30 GMT-08:00 nickcooper-zhangtonghao <n...@opencloud.tech > <mailto:n...@opencloud.tech>>: >> This patch avoids the ovs_rcu to report WARN, caused by blocked >> for a long time, when ovs-vswitchd

[ovs-dev] [PATCH] openvswitch: FTBFS with dpkg-buildpackage.

2016-12-19 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- debian/rules | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 4c34b07..12fb94a 100755 --- a/debian/rules +++ b/debian/rules @@ -48,7 +48,7 @@ override_dh_auto_clean:

[ovs-dev] [PATCH] ofproto: Limit log rate when controller disconnected.

2017-03-24 Thread nickcooper-zhangtonghao
There are a lot of logs when OvS bridges can’t connect to controllers. The controller may stop or something causes a disruption in network traffic. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rconn.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[ovs-dev] [PATCH v2] stp: Fix stp tests and make them more stable.

2017-03-23 Thread nickcooper-zhangtonghao
). This patch has been tested for 3 hours. This patch may make the stp tests more stable. Fixes: 427e9751f300 ("tests: Add and improve stp tests.") Reported-at: http://paste.ubuntu.com/24215426 Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/330032.html Signed-off-by:

Re: [ovs-dev] [PATCH] tests: Add and improve stp tests.

2017-03-23 Thread nickcooper-zhangtonghao
Hi, the new patch has been submitted. It fixes the issue on ubuntu and newer kernel (4.10.4). You can review and tested it. http://patchwork.ozlabs.org/patch/742517/ ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] tests: Add and improve stp tests.

2017-03-20 Thread nickcooper-zhangtonghao
I tested it via command as below for a long time. while true; do make check TESTSUITEFLAGS='-k stp'; done But it’s ok. I try to find what might cause this. Thanks. Nick > On Mar 21, 2017, at 5:24 AM, Joe Stringer wrote: > > Right, Travis seems happy too so most likely it's

[ovs-dev] [PATCH] stp: Fix stp test.

2017-03-21 Thread nickcooper-zhangtonghao
e stp tests.") Reported-at: http://paste.ubuntu.com/24215426 Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- tests/stp.at | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/stp.at b/tests/stp.at index 20f7940..542e700 100644 --- a/tests/st

Re: [ovs-dev] [PATCH 2/4] stp: Add the stp/show command.

2017-03-18 Thread nickcooper-zhangtonghao
Thanks very much, I submitted v2 and added the “Co-authored-by". Nick > On Mar 18, 2017, at 2:37 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Mar 07, 2017 at 05:11:28AM -0800, nickcooper-zhangtonghao wrote: >> The stp/show command will help users and developers get

Re: [ovs-dev] [PATCH] stp: Set time of BPDU packet.

2017-03-18 Thread nickcooper-zhangtonghao
I was wrong. Thanks. Nick > On Mar 18, 2017, at 6:56 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Mar 08, 2017 at 03:53:10AM -0800, nickcooper-zhangtonghao wrote: >> The OvS BPDU packets have not right format. The STP works >> well in OvS bridges when st

[ovs-dev] [PATCH 1/2] stp: Change the api for next patch.

2017-03-18 Thread nickcooper-zhangtonghao
This patch changes the stp_port_get_role and removes the stp_port_get_id, because stp/show has locked the mutex before calling the stp_port_get_role, and stp_port_get_id will not be used. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Acked-by: Ben Pfaff <b...@ovn.org&

[ovs-dev] [PATCH 2/2] stp: Add the 'ovs-appctl stp/show' command.

2017-03-18 Thread nickcooper-zhangtonghao
The stp/show command will help users and developers to get more details about stp. This patch works together with the previous patch "stp: Change the api for next patch." Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Co-authored-by: Ben Pfaff <b...

[ovs-dev] [PATCH 2/6] stp: Use OpenFlow port number for stp ports.

2017-03-31 Thread nickcooper-zhangtonghao
port may belong to other one. This patch uses the OpenFlow port numbers instead of sequence numbers to avoid it. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- tests/stp.at | 90 ++- vswitchd/bridge.c | 10 +-- 2

[ovs-dev] [PATCH 5/6] rstp: Add rstp port name for human reading.

2017-03-31 Thread nickcooper-zhangtonghao
This patch is useful to debug rstp subsystem and log the port name instead of port number. This patch will also be used to display rstp info for next patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp-common.h | 1 + lib/rstp.c

[ovs-dev] [PATCH 4/6] rstp: Init a recursive mutex for rstp.

2017-03-31 Thread nickcooper-zhangtonghao
This patch will be used for next patch. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp.c | 15 --- lib/rstp.h | 6 -- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/rstp.c b/lib/rstp.c index 907a907..6f1c1e3 100644 --- a/lib/

[ovs-dev] [PATCH 1/6] rstp/stp: Unref the rstp/stp when bridges destroyed.

2017-03-31 Thread nickcooper-zhangtonghao
struct in the 'destruct' of ofproto-dpif provider. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 523adad..4beacda 100644 --- a/ofproto/ofproto-

[ovs-dev] [PATCH 3/6] stp: Add link-state checking support for stp ports.

2017-03-31 Thread nickcooper-zhangtonghao
When bridge stp enabled, we enable the stp ports despite ports are down. When initializing, this patch checks link-state of ports and enable or disable them according to their link-state. This patch also allow user to enable and disable a port when bridge stp is running. Signed-off-by: nickcooper

[ovs-dev] [PATCH 6/6] rstp: Add the 'ovs-appctl rstp/show' command.

2017-03-31 Thread nickcooper-zhangtonghao
The rstp/show command will help users and developers to get more details about rstp. This patch works together with the previous patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- NEWS | 4 +- lib/rstp.c

Re: [ovs-dev] [PATCH 2/6] stp: Use OpenFlow port number for stp ports.

2017-04-21 Thread nickcooper-zhangtonghao
> On Apr 21, 2017, at 8:34 AM, Jarno Rajahalme <ja...@ovn.org> wrote: > >> >> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> wrote: >> >> When a bridge stp enabled, we assign se

Re: [ovs-dev] [PATCH 4/6] rstp: Init a recursive mutex for rstp.

2017-04-21 Thread nickcooper-zhangtonghao
> On Apr 21, 2017, at 8:59 AM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: > >> >> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> wrote: >> >> This p

Re: [ovs-dev] [PATCH 4/6] rstp: Init a recursive mutex for rstp.

2017-04-21 Thread nickcooper-zhangtonghao
> On Apr 21, 2017, at 8:59 AM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: > >> >> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> wrote: >> >> This p

Re: [ovs-dev] [PATCH 6/6] rstp: Add the 'ovs-appctl rstp/show' command.

2017-04-21 Thread nickcooper-zhangtonghao
> On Apr 21, 2017, at 9:08 AM, Jarno Rajahalme <ja...@ovn.org> wrote: > > I’d like to see one of the existing RSTP test cases modified to use this new > feature. > > One more comment below, > > Jarno > > >> On Mar 31, 2017, at 8:11 PM, ni

Re: [ovs-dev] [PATCH 1/6] rstp/stp: Unref the rstp/stp when bridges destroyed.

2017-04-20 Thread nickcooper-zhangtonghao
org/patch/745885/> ofproto: http://patchwork.ozlabs.org/patch/743155/ <http://patchwork.ozlabs.org/patch/743155/> Thanks. Nick > On Apr 1, 2017, at 11:11 AM, nickcooper-zhangtonghao <n...@opencloud.tech> > wrote: > > When bridges destroyed, which stp enabled, you c

[ovs-dev] [PATCH] debian: Rewrite "ifconfig" to "ip" command.

2017-03-08 Thread nickcooper-zhangtonghao
Some debian distribution may not contain the ifconfig. We use the ip command instead of ifconfig in debian/ifupdown.sh Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329503.html CC: prochazka <procha...@cortex.cz> Signed-off-by: nickcooper-zhangtong

Re: [ovs-dev] [PATCH] debian; Avoid installing ovs-vswitchd.conf.db manpage as "db" language.

2017-03-08 Thread nickcooper-zhangtonghao
I have tested it. It is ok now. Simon, what do you think about it? Tested-by: nickcooper-zhangtonghao <n...@opencloud.tech> > On Mar 9, 2017, at 2:22 AM, Ben Pfaff <b...@ovn.org> wrote: > > Simon, would you mind reviewing this, since it's about t

Re: [ovs-dev] [PATCH 1/4] stp: Change the api for next patch.

2017-03-13 Thread nickcooper-zhangtonghao
work.ozlabs.org/patch/736159/> http://patchwork.ozlabs.org/patch/736229/ <http://patchwork.ozlabs.org/patch/736229/> http://patchwork.ozlabs.org/patch/736548/ <http://patchwork.ozlabs.org/patch/736548/> Thanks. Nick > On Mar 7, 2017, at 9:11 PM, nickcooper-zhangtongh

[ovs-dev] [PATCH] stp: Set time of BPDU packet.

2017-03-08 Thread nickcooper-zhangtonghao
The OvS BPDU packets have not right format. The STP works well in OvS bridges when stp enabled, because they set the time(e.g. max age, hello time and forward delay) in ticks. But they should be sec. If so, OvS STP can work well with other type of bridge using STP. Signed-off-by: nickcooper

[ovs-dev] [PATCH 1/4] stp: Change the api for next patch.

2017-03-07 Thread nickcooper-zhangtonghao
This patch changes the stp_port_get_role and removes the stp_port_get_id, because stp/show has locked the mutex before calling the stp_port_get_role, and stp_port_get_id will not be used. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/stp.c

[ovs-dev] [PATCH 2/4] stp: Add the stp/show command.

2017-03-07 Thread nickcooper-zhangtonghao
The stp/show command will help users and developers get more details about stp. This patch works together with the previous patch "stp: Change the api for next patch." Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> ---

[ovs-dev] [PATCH 3/4] stp: Set BPDU max age exactly.

2017-03-07 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 2e10013..961ebe6 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -1538,7 +

[ovs-dev] [PATCH 4/4] stp: Don't wait a hello-time before sending BPDU.

2017-03-07 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/stp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stp.c b/lib/stp.c index d90b400..d828c64 100644 --- a/lib/stp.c +++ b/lib/stp.c @@ -306,7 +306,7 @@ stp_create(const char *name, stp_iden

[ovs-dev] [PATCH] mcast-snooping: Add and improve mcast-snooping tests.

2017-03-03 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- tests/mcast-snooping.at | 112 1 file changed, 112 insertions(+) diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at index c03aba3..90de8b3 100644 --- a/tests

[ovs-dev] [PATCH 1/2] mcast-snooping: Flush ports mdb when VLAN configuration changed.

2017-03-03 Thread nickcooper-zhangtonghao
If VLAN configuration(e.g. id, mode) change occurs, the IGMP snooping-learned multicast groups from this port on the VLAN are deleted. This avoids a MCAST_ENTRY_DEFAULT_IDLE_TIME delay before mdb is updated again. Hardware switches (e.g. cisco) also do that. Signed-off-by: nickcooper-zhangtonghao

[ovs-dev] [PATCH 2/2] mcast-snooping: Avoid segfault for vswitchd.

2017-03-03 Thread nickcooper-zhangtonghao
port, Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 366b7a2..1e1b107 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c

[ovs-dev] [PATCH v2 1/2] mcast-snooping: Flush ports mdb when VLAN configuration changed.

2017-03-03 Thread nickcooper-zhangtonghao
If VLAN configuration(e.g. id, mode) change occurs, the IGMP snooping-learned multicast groups from this port on the VLAN are deleted. This avoids a MCAST_ENTRY_DEFAULT_IDLE_TIME delay before mdb is updated again. Hardware switches (e.g. cisco) also do that. Signed-off-by: nickcooper-zhangtonghao

[ovs-dev] [PATCH v2 2/2] mcast-snooping: Avoid segfault for vswitchd.

2017-03-03 Thread nickcooper-zhangtonghao
pif.c:4781 process_command lib/unixctl.c:313 run_connection lib/unixctl.c:347 unixctl_server_run lib/unixctl.c:400 main vswitchd/ovs-vswitchd.c:112 Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[ovs-dev] [PATCH] rstp/stp: Unref the rstp/stp when bridges destroyed.

2017-03-21 Thread nickcooper-zhangtonghao
struct in the 'destruct' of ofproto-dpif provider. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 523adad..4beacda 100644 --- a/ofproto/ofproto-

Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

2017-07-13 Thread nickcooper-zhangtonghao
amount of code duplication, but > it is easier to see that it avoids a null dereference. Looks good to me. Thanks. Acked-by: nickcooper-zhangtonghao <n...@opencloud.tech> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

2017-07-09 Thread nickcooper-zhangtonghao
Who can help me to review this patch. Thanks. > On Jun 20, 2017, at 11:04 AM, nickcooper-zhangtonghao <n...@opencloud.tech> > wrote: > > When we use the 'ovs-appctl rstp/show', the root bridge > of rstp is always 'unknown root port'. We don't expect > that. The reas

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-18 Thread nickcooper-zhangtonghao
> On Jul 19, 2017, at 7:32 AM, Justin Pettit wrote: > >> >> On Jul 18, 2017, at 4:15 AM, Eelco Chaudron wrote: >> >> On 18/07/17 08:28, Justin Pettit wrote: On Jul 17, 2017, at 10:06 PM, Numan Siddique wrote: On Tue,

[ovs-dev] [PATCH v2 3/5] rstp: Add the 'ovs-appctl rstp/show' command.

2017-05-10 Thread nickcooper-zhangtonghao
The rstp/show command will help users and developers to get more details about rstp. This patch works together with the previous patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- NEWS | 3 +- lib/rstp.c

[ovs-dev] [PATCH v2 2/5] rstp: Add rstp port name for human reading.

2017-05-10 Thread nickcooper-zhangtonghao
This patch is useful to debug rstp subsystem and log the port name instead of port number. This patch will also be used to display rstp info for next patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Acked-by: Jarno Rajahalme <ja...@ovn.org> --- lib/rstp-common

[ovs-dev] [PATCH v2 4/5] rstp: Increment the rstp port num counter.

2017-05-10 Thread nickcooper-zhangtonghao
OvS only supports RSTP_MAX_PORTS rstp ports while max port num of stp is STP_MAX_PORTS. This patch increments the rstp port num counter, otherwise the counter is 0 and the checking above will always fail. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/bridge

[ovs-dev] [PATCH v2 5/5] stp: Add link-state checking support for stp ports.

2017-05-10 Thread nickcooper-zhangtonghao
is in disable state, it can forward packets. If its link is down and this patch sets it to disable, there is no L2 loop. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 41 - tests/stp.at

[ovs-dev] [PATCH v2 1/5] rstp: Init a recursive mutex for rstp.

2017-05-10 Thread nickcooper-zhangtonghao
creating the rstp and stp also do that, otherwise tests fail. * This patch remove the rstp_mutex in header file and make it static in c file because we only use it in lib/rstp.c Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp.c | 15 --- lib/rstp.

[ovs-dev] [PATCH] rstp: Show root bridge info.

2017-06-19 Thread nickcooper-zhangtonghao
' in the same case. If we check only rstp root port, the root info will not shown any more. CC: Ben Pfaff <b...@ovn.org> Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rstp.c b/lib/rstp.c i

  1   2   >