dpif-netdev.c:8899
> 0x13e691f8 in dp_netdev_input at lib/dpif-netdev.c:8908
> 0x13e600e4 in dp_netdev_process_rxq_port at lib/dpif-netdev.c:5660
> 0x13e649a8 in pmd_thread_main at lib/dpif-netdev.c:7295
> 0x13f44b2c in ovsthread_wrapper at lib/ovs-thread.c:423
>
> CC: Mike Pattrick
>
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Signed-off-by: Mike Pattrick
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v8:
- Corrected code from v7 related to sequence and in_port. Mirrors
reject filters with an in_port set
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v8:
- Corrected code from v7 related to sequence and in_port. Mirrors
reject filters with an in_port set
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Signed-off-by: Mike Pattrick
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off
ls whenever we get election timer
> from the log.
>
> Fixes: 14b2b0aad7ae ("raft: Reintroduce jsonrpc inactivity probes.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://m
-establish the connection eventually.
>
> Since probe intervals also depend on the joining state now, update
> them when the server joins the cluster.
>
> Fixes: 14b2b0aad7ae ("raft: Reintroduce jsonrpc inactivity probes.")
> Reported-by: Terry Wilson
> Reported-a
On Wed, Mar 27, 2024 at 1:39 PM Simon Horman wrote:
>
> On Tue, Feb 20, 2024 at 11:08:55PM -0500, Mike Pattrick wrote:
> > When sending packets that are flagged as requiring segmentation to an
> > interface that doens't support this feature, send the packet to the TSO
>
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
v3: NEWS file merge conflict
v4: Better comments, new test
v5: Addressed identified nit's
---
NEWS | 4
lib/netdev-native-tnl.c | 2 +-
lib
09:36:53.862230 68:05:ca:21:d6:e5 > 52:54:00:67:d5:61, ethertype IPv4
> (0x0800), length 98: (tos 0x0, ttl 63, id 22176, offset 0, flags [none],
> proto ICMP (1), length 84)
> 1.1.70.2 > 11.11.70.1: ICMP echo reply, id 15498, seq 18, length 64
>
> -邮件原件-
> 发件人
address is different then
this would be the expected behavior, the collection of the packet as
it enters, and then as it exists modified.
Thank you,
Mike
>
> -邮件原件-
> 发件人: Mike Pattrick [mailto:m...@redhat.com]
> 发送时间: 2024年3月13日 1:37
> 收件人: d...@openvswitch.org
ic test.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2024-March/053014.html
> Signed-off-by: Ilya Maximets
> ---
I have tested this, and it does fix the segfault here.
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
v3: NEWS file merge conflict
v4: Better comments, new test
---
NEWS | 4
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c| 17
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
v2: Don't extract variables from ipsec script
v3: Removed use of packaging
---
ipsec/ovs-monitor-ipsec.in | 20 ++--
1 file c
On Wed, Mar 20, 2024 at 2:05 PM Mike Pattrick wrote:
>
> In v4.0, LibreSwan changed a default paths that had been hardcoded in
> ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> support for both old and newer versions by auto detecting the version
&g
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
v2: Don't extract variables from ipsec script
---
ipsec/ovs-monitor-ipsec.in | 16 ++--
1 file changed, 14 insertions(+), 2
On Tue, Mar 19, 2024 at 5:35 PM Ilya Maximets wrote:
>
> On 3/13/24 22:54, Mike Pattrick wrote:
> > In v4.0, LibreSwan changed a default paths that had been hardcoded in
> > ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> > support for both old an
unexpected
> tunnel types in case something goes wrong.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
"userspace: Add Generic Segmentation Offloading.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
; Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
ipsec/ovs-monitor-ipsec.in | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --g
resetting the mirror context.
Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are modified.")
Reported-by: Zhangweiwei
Signed-off-by: Mike Pattrick
---
include/openvswitch/meta-flow.h | 1 +
lib/meta-flow.c | 109
ofproto/of
084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/321
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
, returning immediately. One notable change in
functionality is not performing the RBAC check in this condition, as no
mutation actually takes place.
Reported-by: Terry Wilson
Reported-at: https://issues.redhat.com/browse/FDP-359
Signed-off-by: Mike Pattrick
---
v2: Added additional non-rbac tests
ed-By: Luca Czesla
> Signed-off-by: Luca Czesla
> Co-Authored-By: Max Lamprecht
> Signed-off-by: Max Lamprecht
> Signed-off-by: Felix Huettner
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Mar 4, 2024 at 3:22 AM Felix Huettner via dev
wrote:
>
> Extract checking for a given kernel version to a separate function.
> It will be used also in the next patch.
>
> Signed-off-by: Felix Huettner
> ---
Acked-by: Mike Pattrick
_
ot;)
> Signed-off-by: Xavier Simonart
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Feb 28, 2024 at 8:41 AM Ilya Maximets wrote:
>
> On 2/22/24 17:37, Mike Pattrick wrote:
> > Previously when an empty mutation was used to count the number of rows
> > in a table, OVSDB would iterate over all rows twice. First to perform an
> > RBAC ch
On Mon, Feb 26, 2024 at 4:22 AM Felix Huettner via dev
wrote:
>
> Extract checking for a given kernel version to a separate function.
> It will be used also in the next patch.
>
> Signed-off-by: Felix Huettner
> ---
> v4->v5:
> - fix wrong ifdef that broke on macos
> - fix
tead.
>
> 1., 2. & 3. Found by inspection
> 4. Flagged by check-docs
>
> Signed-off-by: Simon Horman
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote:
>
> Update link to OCF Resource Agents documentation as the existing link
> is broken. Also, use HTTPS.
>
> Broken link flagged by make check-docs
>
> Signed-off-by: Simon Horman
Ac
rf/en/latest/release/release-notes/release-notes.html
>
> Signed-off-by: Simon Horman
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 27, 2024 at 10:37 AM Simon Horman wrote:
>
> Correct spelling errors in .rst files flagged by codespell.
>
> Signed-off-by: Simon Horman
> ---
These look correct to me.
Acked-by: Mike Pattrick
___
dev mailing list
d...@
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote:
>
> IANAL, but I think we can extend the copyright attached
> to documentation to cover the current year: we are still
> actively working on the documentation.
>
> Signed-off-by: Simon Horman
Acked-by: Mike Pattrick
I wo
On Mon, Feb 26, 2024 at 5:50 AM Xavier Simonart wrote:
>
> On netdev datapath, when a ct element was cleaned, the cmap
> could be shrinked, potentially causing some elements to be skipped
> in the flush iteration.
>
> Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
> Signed-off-by: Xavier
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v7:
- Make sure filter mask is added to masks of non-matching flows.
- Added additional tests
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Signed-off-by: Mike Pattrick
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
---
ofproto
offload inner either.
Reported-at: https://issues.redhat.com/browse/FDP-363
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
nb: I also tested a more complex patch that only resolved the inner
checksum and offloaded the UDP layer. This didn't
, returning immediately. One notable change in
functionality is not performing the RBAC check in this condition, as no
mutation actually takes place.
Reported-by: Terry Wilson
Reported-at: https://issues.redhat.com/browse/FDP-359
Signed-off-by: Mike Pattrick
---
v2: Added additional non-rbac tests
On Tue, Feb 20, 2024 at 11:09 PM Mike Pattrick wrote:
>
> When sending packets that are flagged as requiring segmentation to an
> interface that doens't support this feature, send the packet to the TSO
> software fallback instead of dropping it.
>
> Signed-off-by: Mike Pattrick
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
v3: NEWS file merge conflict
---
NEWS| 3 +++
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c | 13 +++--
lib/netdev.h| 9
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
---
NEWS| 5 -
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c | 13 +++--
lib/netdev.h| 9 -
ofproto/tunnel.c
sually and less error
> prone by requesting port numbers for all the ports.
>
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 20, 2024 at 8:56 PM Mike Pattrick wrote:
>
> This patch adopts the proposed RFC 6935 by allowing null UDP checksums
> even if the tunnel protocol is IPv6. This is already supported by Linux
> through the udp6zerocsumtx tunnel option. It is disabled by default and
&g
On Tue, Feb 20, 2024 at 10:07 AM Mike Pattrick wrote:
>
> Some network cards support inner checksum offloading but not outer
> checksum offloading. Currently OVS will resolve that outer checksum but
> allows the network card to resolve the inner checksum, invalidating the
>
When sending packets that are flagged as requiring segmentation to an
interface that doens't support this feature, send the packet to the TSO
software fallback instead of dropping it.
Signed-off-by: Mike Pattrick
---
lib/dp-packet-gso.c | 73 +
lib/dp
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c | 13 +++--
lib/netdev.h| 9 -
ofproto/tunnel.c| 11 +--
tests/tunnel.at | 6 +++---
vswitchd/vswitch.xml| 8
read system during testing, with the number
> of threads reduced from 95 to 0.
>
> Signed-off-by: Eelco Chaudron
> ---
I tested this out a bit, and it seems to work well.
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.or
/openvswitch/patch/20240209161718.1149494-1-i.maxim...@ovn.org/
>
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/319
> Co-authored-by: Ilya Maximets
> Signed-off-by: Ilya Maximets
> Signed-off-by: Adrian Moreno
> ---
Looks reasonable to me.
Acked-by: Mike
offload inner either.
Reported-at: https://issues.redhat.com/browse/FDP-363
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
nb: I also tested a more complex patch that only resolved the inner
checksum and offloaded the UDP layer. This didn't
On Fri, Feb 16, 2024 at 3:23 PM Ilya Maximets wrote:
>
> On 2/15/24 23:53, Mike Pattrick wrote:
> > Previously a gap existed in the tunnel system tests where only ICMP and
> > TCP traffic was tested. However, the code paths using for UDP traffic is
> > different then ei
VXLAN and GENEVE TSO.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
v4: Corrected packet to pkt
---
lib/dp-packet.h | 19 +--
lib/netdev-native-tnl.c | 10 --
lib/packets.c | 8
3 files changed, 29 insertions(+), 8 deletions(-)
an appropriate check for ncat support. That check was
added to these tests.
Signed-off-by: Mike Pattrick
---
tests/system-traffic.at | 118 +---
1 file changed, 111 insertions(+), 7 deletions(-)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index
h TSO.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h| 18 +-
lib/netdev-linux.c | 9 +
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 802d3f385..770ddc1b9 100644
--- a/lib/dp-packet.h
tunnel not checksum offloading properly.
Fixes: 85bcbbed839a ("userspace: Enable tunnel tests with TSO.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
nb: The first patch was removed from the v2 version of this series,
which was not explicitly a bug fix.
---
lib/netd
On Thu, Feb 15, 2024 at 4:59 PM Mike Pattrick wrote:
>
> Previously some packets were excluded from the tunnel mark if they
> weren't L4. However, this causes problems with multi encapsulated
> packets like arp.
>
> Due to these flags being set, additional checks are re
VXLAN and GENEVE TSO.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h | 19 +--
lib/netdev-native-tnl.c | 10 --
lib/packets.c | 8
3 files changed, 29 insertions(+), 8 deletions(-)
diff --git a/lib/dp-packet.
an appropriate check for ncat support. That check was
added to these tests.
Signed-off-by: Mike Pattrick
---
tests/system-traffic.at | 118 +---
1 file changed, 111 insertions(+), 7 deletions(-)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index
h TSO.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h| 18 +-
lib/netdev-linux.c | 9 +
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 802d3f385..770ddc1b9 100644
--- a/lib/dp-packet.h
tunnel not checksum offloading properly.
Fixes: 85bcbbed839a ("userspace: Enable tunnel tests with TSO.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
nb: The first patch was removed from the v2 version of this series,
which was not explicitly a bug fix.
---
lib/netd
On Wed, Feb 14, 2024 at 12:09 PM David Marchand
wrote:
>
> Hello Mike,
>
> On Mon, Feb 12, 2024 at 8:50 PM Mike Pattrick wrote:
> >
> > Previously if an OVS configuration nested multiple layers of UDP tunnels
> > like VXLAN or GENEVE on top of each other throu
Note, this failed github CI with the following error message:
../../tests/testsuite: line 4034: ./atconfig: No such file or directory
This appears to be a false negative.
-M
On Mon, Feb 12, 2024 at 2:50 PM Mike Pattrick wrote:
>
> Previously if an OVS configuration nested multiple
right after its generation. So, there is no point in
> creating it with restricted permissions in the first place.
>
> Fixes: 99e5e05db37a ("ovs-pki: Create private keys with restricted
> permissions.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
On Tue, Feb 13, 2024 at 2:42 PM Ilya Maximets wrote:
>
> It's not an executable file.
>
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Feb 12, 2024 at 10:04 AM Ilya Maximets wrote:
>
> On 2/12/24 15:19, Mike Pattrick wrote:
> > On Mon, Feb 12, 2024 at 7:52 AM Ilya Maximets wrote:
> >>
> >> On 2/12/24 09:13, Mike Pattrick wrote:
> >>> When sending packets that are flagged as re
tunnel not checksum offloading properly.
Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/
an appropriate check for ncat support. That check was
added to these tests.
Signed-off-by: Mike Pattrick
---
v2: Start the ncat listener before pings, so the socket has a better
chance of being ready to accept connections when the ncat client starts.
Signed-off-by: Mike Pattrick
---
tests/system
t;)
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 7a156cc28..51517854b 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -7191,8 +7191,8 @@ netdev_linux_prepen
When sending packets that are flagged as requiring segmentation to an
interface that doens't support this feature, send the packet to the TSO
software fallback instead of dropping it.
Signed-off-by: Mike Pattrick
---
v2: Start the ncat listener before pings, so the socket has a better
chance
On Mon, Feb 12, 2024 at 7:52 AM Ilya Maximets wrote:
>
> On 2/12/24 09:13, Mike Pattrick wrote:
> > When sending packets that are flagged as requiring segmentation to an
> > interface that doens't support this feature, send the packet to the TSO
> > software fall
Previously a gap existed in the tunnel system tests where only ICMP and
TCP traffic was tested. However, the code paths using for UDP traffic is
different then either of those and should also be tested.
Signed-off-by: Mike Pattrick
---
tests/system-traffic.at | 50
t;)
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 7a156cc28..51517854b 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -7191,8 +7191,8 @@ netdev_linux_prepen
tunnel not checksum offloading properly.
Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/
When sending packets that are flagged as requiring segmentation to an
interface that doens't support this feature, send the packet to the TSO
software fallback instead of dropping it.
Signed-off-by: Mike Pattrick
---
Note: Previously this patch failed gitlab ci, however, I was not able
Currently the monitor will call dp_packet_clear() on the dp_packet that
is shared amongst BFD, LLDP, and CFM. However, all of these packets are
created with eth_compose(), which already calls dp_packet_clear().
Reviewed-by: David Marchand
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif
Include inner offsets in functions where l3 and l4 offsets are either
modified or checked.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
v2:
- Prints out new offsets in autovalidator
- Extends resize_l2 change to avx512
v3:
-
t;bfd: Implement Bidirectional Forwarding Detection.")
Signed-off-by: Mike Pattrick
---
v2: Corrected formatting, and just calculate checksum up front
v3: Extended patch comment
---
lib/bfd.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/lib/bfd.c b
as long as
the flags of the packet are correct.
Fixes: 85bcbbed839a ("userspace: Enable tunnel tests with TSO.")
Reviewed-by: David Marchand
Signed-off-by: Mike Pattrick
---
v2: Corrected patch subject
---
lib/dp-packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
as long as
the flags of the packet are correct.
Fixes: 85bcbbed839a ("userspace: Enable tunnel tests with TSO.")
Reviewed-by: David Marchand
Signed-off-by: Mike Pattrick
---
v2: Corrected patch subject
---
lib/dp-packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
t;bfd: Implement Bidirectional Forwarding Detection.")
Signed-off-by: Mike Pattrick
---
v2: Corrected formatting, and just calculate checksum up front
v3: Extended patch comment
---
lib/bfd.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/lib/bfd.c b
Currently the monitor will call dp_packet_clear() on the dp_packet that
is shared amongst BFD, LLDP, and CFM. However, all of these packets are
created with eth_compose(), which already calls dp_packet_clear().
Reviewed-by: David Marchand
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif
Include inner offsets in functions where l3 and l4 offsets are either
modified or checked.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
v2:
- Prints out new offsets in autovalidator
- Extends resize_l2 change to avx512
v3:
-
, returning immediately. One notable change in
functionality is not performing the RBAC check in this condition, as no
mutation actually takes place.
Reported-by: Terry Wilson
Reported-at: https://issues.redhat.com/browse/FDP-359
Signed-off-by: Mike Pattrick
---
ovsdb/execution.c | 9
On Wed, Jan 31, 2024 at 10:04 AM David Marchand
wrote:
>
> On Tue, Jan 30, 2024 at 11:15 PM Mike Pattrick wrote:
> >
> > Include inner offsets in functions where l3 and l4 offsets are either
> > modified or checked.
> >
> > Fixes: 084c8087292c (&quo
Include inner offsets in functions where l3 and l4 offsets are either
modified or checked.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
v2:
- Prints out new offsets in autovalidator
- Extends resize_l2 change to avx512
Signed-of
Currently the monitor will call dp_packet_clear() on the dp_packet that
is shared amongst BFD, LLDP, and CFM. However, all of these packets are
created with eth_compose(), which already calls dp_packet_clear().
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif-monitor.c | 3 ---
1 file
Previously the BFD packet creation code did not appropriately set
offsets or flags. This contributed to issues involving encapsulation and
the TSO code.
Fixes: ccc096898c46 ("bfd: Implement Bidirectional Forwarding Detection.")
Signed-off-by: Mike Pattrick
---
v2: Corrected formatting
as long as
the flags of the packet are correct.
Fixes: 85bcbbed839a ("userspace: Enable tunnel tests with TSO.")
Signed-off-by: Mike Pattrick
---
v2: Corrected patch subject
---
lib/dp-packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/d
-at: https://issues.redhat.com/browse/FDP-300
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h | 3 +++
lib/packets.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 939bec5c8..dceb701e8 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
as long as
the flags of the packet are correct.
Fixes: 85bcbbed839a ("userspace: Enable tunnel tests with TSO.")
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index dceb701e8..802d3f
Currently the monitor will call dp_packet_clear() on the dp_packet that
is shared amongst BFD, LLDP, and CFM. However, all of these packets are
created with eth_compose(), which already calls dp_packet_clear().
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif-monitor.c | 3 ---
1 file
Include inner offsets in functions where l3 and l4 offsets are either
modified or checked.
Signed-off-by: Mike Pattrick
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
---
lib/dp-packet.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/dp-
Previously the BFD packet creation code did not appropriately set
offsets or flags. This contributed to issues involving encapsulation and
the TSO code.
Signed-off-by: Mike Pattrick
Fixes: ccc096898c46 ("bfd: Implement Bidirectional Forwarding Detection.")
Signed-off-by: Mike Pattrick
On Wed, Jan 24, 2024 at 1:14 PM Mike Pattrick wrote:
>
> When sending packets that are flagged as requiring segmentation to an
> interface that doens't support this feature, send the packet to the TSO
> software fallback instead of dropping it.
>
> Signed-off-by: Mike Pattrick
When sending packets that are flagged as requiring segmentation to an
interface that doens't support this feature, send the packet to the TSO
software fallback instead of dropping it.
Signed-off-by: Mike Pattrick
---
lib/dp-packet-gso.c | 73 +
lib/dp
On Tue, Jan 23, 2024 at 7:41 AM Ilya Maximets wrote:
>
> On 1/22/24 23:24, Mike Pattrick wrote:
> > On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote:
> >>
> >> On 1/22/24 21:33, Mike Pattrick wrote:
> >>> On Mon, Jan 22, 2024 at 1:47 PM Ilya Maxim
("userspace: Add Generic Segmentation Offloading.")
Fixes: 85bcbbed839a ("userspace: Enable tunnel tests with TSO.")
Reported-by: Dumitru Ceara
Reported-at: https://issues.redhat.com/browse/FDP-300
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h | 4 +++-
1 file changed
On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote:
>
> On 1/22/24 21:33, Mike Pattrick wrote:
> > On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets wrote:
> >>
> >> On 1/22/24 18:51, Mike Pattrick wrote:
> >>> The OVN test suite identified a bug in dp_pac
On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets wrote:
>
> On 1/22/24 18:51, Mike Pattrick wrote:
> > The OVN test suite identified a bug in dp_packet_ol_send_prepare() where
> > a double encapsulated BFD packet would trigger a seg fault. This
> > happened because w
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h | 10 --
lib/packets.c | 6 +++---
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 939bec5c8..81b01f331 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -537,7 +537,7 @@ dp_packe
1 - 100 of 623 matches
Mail list logo
