Yong Xu
> [simon: reworked changelog]
> Signed-off-by: Simon Horman
> Signed-off-by: Louis Peens
> ---
This patch LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
involved ofproto was already deallocated:
>
> (gdb) print *ofproto
> $1 = ..., name = 0x55d907602820 "nsx-managed", ..., ports = {...,
> one = 0x0, mask = 63, n = 0}, ..., connmgr = 0x0, ...
>
> This patch fixes it.
>
> VMware-BZ: #2700626
> Signed-off-by: Yifeng Sun
> ---
LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 2, 2021 at 9:32 AM Ilya Maximets wrote:
>
> On 1/21/21 7:51 PM, Yi-Hung Wei wrote:
> > This patch adds an RPMBUILD_OPT so that user can enable
> > AF_XDP support in the rpm package by:
> >
> > $ make rpm-fedora RPMBUILD_OPT="--with afxdp"
>
This patch adds an RPMBUILD_OPT so that user can enable
AF_XDP support in the rpm package by:
$ make rpm-fedora RPMBUILD_OPT="--with afxdp"
Signed-off-by: Yi-Hung Wei
---
Documentation/intro/install/fedora.rst | 7 +++
rhel/openvswitch-fedora.spec.in| 8
2 fil
This patch adds an RPMBUILD_OPT so that user can enable
AF_XDP support in the rpm package by:
$ make rpm-fedora RPMBUILD_OPT="--with afxdp"
Signed-off-by: Yi-Hung Wei
---
rhel/openvswitch-fedora.spec.in | 8
1 file changed, 8 insertions(+)
diff --git a/rhel/openvswitch-fedo
ated
> packets.
>
> Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
> Signed-off-by: Tonghao Zhang
> ---
> v2:
> 1. add test case
> 2. change the commit message, and title
> 3. change the fix tag
> ---
Thanks for v2. LGTM.
Acked-by: Yi-Hung Wei
On Tue, Jan 19, 2021 at 6:45 AM Aaron Conole wrote:
>
> The fixes tag for this should be:
>
> Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
Yes, commit a867c010ee91 ("conntrack: Fix conntrack new state") is the
right one to fix. Commit a867c010ee91 only takes care of TCP, UDP
(connt
On Wed, Dec 16, 2020 at 1:24 AM Ilya Maximets wrote:
>
> On 12/16/20 12:41 AM, Yi-Hung Wei wrote:
> > On userspace datapath, geneve option flag FLOW_TNL_F_UDPIF should only
> > be set when the geneve option is available. However, currently, we always
> > set FLOW_TNL_F_UD
On Mon, Nov 23, 2020 at 6:45 AM Cpp Code wrote:
>
> I would expect such checks to be commented as indeed it was not clear why
> it was there. I looked in similar places where FLOW_TNL_F_UDPIF is used
> and there is no such check. The commit which created this condition is
> quite large so I am no
s not expected because of the deleted
flow. It also does not happen with VXLAN.
Reported-by: Antonin Bas
Reported-at: https://github.com/vmware-tanzu/antrea/issues/897
Fixes: 6b241d645291 ("netdev-vport: Factor-out tunnel Push-pop code into
separate module.")
Signed-off-by: Yi-Hung We
On Wed, Dec 9, 2020 at 7:50 AM Harold Huang wrote:
>
> When I use ```ovs-appctl dpctl/ct-set-limits default=6``` to set the
> default zone limit, the max connection limit of all zones is set to 6. I
> think it is not resonable. First, the max connection limit can be set with
> ```ovs-appctl dpct
> Fixes: 9ba57fc7 ("datapath: Add hash info to upcall")
> Signed-off-by: Greg Rose
>
> ---
> V2 - Just removes l4_rxhash and ends support for RHEL 7.x < 7.2
> ---
Thanks for v2. Looks good to me.
Acked-by: Yi-Hung Wei
> diff --git a/datapath/linux/compat/inclu
+ kernels")
> Signed-off-by: Greg Rose
>
> ---
> V2 No change
> ---
LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
; ---
> V2 Separate out stale code removal to it's own patch as per suggestion
>from Yi-Hung
> ---
Looks good to me. Thanks.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Nov 3, 2020 at 4:06 PM Gregory Rose wrote:
> On 11/3/2020 2:17 PM, Yi-Hung Wei wrote:
> > On Tue, Oct 20, 2020 at 10:07 AM Greg Rose wrote:
> >>
> >> RHEL 7.7 has a KABI fixup in struct sk_buff to backport the member
> >> name change of l4_rxhash t
+ kernels")
> Signed-off-by: Greg Rose
> ---
LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Oct 20, 2020 at 10:07 AM Greg Rose wrote:
>
> RHEL 7.7 has a KABI fixup in struct sk_buff to backport the member
> name change of l4_rxhash to l4_hash. This exposed a couple of
> issues in patch 8063e0958780 which was intended to remove support
> for kernels older than 3.10.
>
> Remove st
On Wed, Oct 14, 2020 at 8:41 AM Ilya Maximets wrote:
>
> On 10/12/20 10:24 PM, Greg Rose wrote:
> > This patch set will add support for Linux kernels up to 5.8. In
> > addition there are quite a few patches for openvswitch on the Linux
> > kernel mailing list that have not been backported - here i
;
> Added additional compat layer fixup for WRITE_ONCE()
>
> Cc: Tonghao Zhang
> Reviewed-by: Tonghao Zhang
> Signed-off-by: Greg Rose
>
> ---
> V4 - Simplify the WRITE_ONCE macro implemention as suggested by
> Yihung.
> ---
Looks good to me. Thanks!
Acked
d add compat
> layer fixup for the DECLARE_STATIC_KEY_FALSE macro.
>
> Cc: Paul Blakey
> Signed-off-by: Greg Rose
>
> ---
> V4 - Add in portion of commit for ovs_dp_cmd_set which was missed
> in first patch.
> ---
Thanks Greg for this new version. It looks good t
; diff --git a/NEWS b/NEWS
> index 2f67d5047..2cd0a7cbf 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,5 +1,7 @@
> Post-v2.14.0
> -
> + - Linux datapath:
> + * Support for kernel versions up to 5.8.x.
T
On Wed, Sep 16, 2020 at 10:34 AM Greg Rose wrote:
>
> Update the list to more closely track the LTS releases on kernel.org.
>
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.
On Wed, Sep 16, 2020 at 10:34 AM Greg Rose wrote:
>
> Allow building openvswitch against Linux kernels up to and including
> version 5.8.
>
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@ope
avid S. Miller
>
> Compat fixup - OVS doesn't support lockdep_ovsl_is_held() yet
>
> Cc: Tonghao Zhang
> Reviewed-by: Tonghao Zhang
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt; Cc: Jason A. Donenfeld
> Signed-off-by: Greg Rose
LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
- clarify the commit message
> - clean the skb and report the error (DaveM)
>
> Fixes: ccb1352e76cf ("net: Add Open vSwitch kernel components.")
> Signed-off-by: Paolo Abeni
> Signed-off-by: David S. Miller
| const struct ovs_key_ipv4 *ipv4_key;
> | ^~~~
>
> [1] https://bugs.llvm.org/show_bug.cgi?id=44916
>
> Signed-off-by: Kees Cook
> Signed-off-by: David S. Miller
>
> Cc: Kees Cook
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
with nat.")
> signed-off-by: aaron conole
> signed-off-by: david s. miller
>
> Fixes: c5f6c06b58d6 ("datapath: Interface with NAT.")
> Cc: aaron conole
> Acked-by: Aaron Conole
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
tioned commit.
>
> v1 -> v2:
> - do not leak an skb on error
>
> Fixes: aed067783e50 ("openvswitch: Minimize ovs_flow_cmd_del critical
> section.")
> Signed-off-by: Paolo Abeni
> Signed-off-by: Davi
_dp_cmd_new
>
> use the specified functions to init resource.
>
> Signed-off-by: Tonghao Zhang
> Tested-by: Greg Rose
> Acked-by: Pravin B Shelar
> Signed-off-by: David S. Miller
>
> Cc: Tonghao Zhang
> Reviewed-by: Tonghao Zhang
> S
On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote:
>
> From: Tonghao Zhang
>
> Upstream commit:
> commit 50b0e61b32ee890a75b4377d5fbe770a86d6a4c1
> Author: Tonghao Zhang
> Date: Fri Nov 1 22:23:52 2019 +0800
>
> net: openvswitch: fix possible memleak on destroy flow-table
>
>
by: Pravin B Shelar
> Signed-off-by: David S. Miller
>
> Cc: Tonghao Zhang
> Reviewed-by: Tonghao Zhang
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
vid S. Miller
>
> Cc: Tonghao Zhang
> Reviewed-by: Tonghao Zhang
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt;
> Cc: Tonghao Zhang
> Reviewed-by: Tonghao Zhang
> Signed-off-by: Greg Rose
> ---
LGTM
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
low command message
> size.
>
> Fixes: 74ed7ab9264c ("openvswitch: Add support for unique flow IDs.")
> Reported-by: Qi Jun Ding
> Signed-off-by: Paolo Abeni
> Signed-off-by: David S. Miller
>
> Cc: Paolo Abeni
> Signed-off-by: Greg Rose
>
-by: Tonghao Zhang
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ecirc_id from tc chain
> index")
> Cc: Paul Blakey
> Signed-off-by: Tonghao Zhang
> Tested-by: Greg Rose
> Acked-by: William Tu
> Acked-by: Pravin B Shelar
> Signed-off-by: David S. Miller
>
> Cc: Tonghao Zhang
27;t optimize slow or control path, still using ma->max
> to traverse. Slow path:
> * tbl_mask_array_realloc
> * ovs_flow_tbl_lookup_exact
> * flow_mask_find
>
> Signed-off-by: Tonghao Zhang
> Tested-by: Greg Rose
> Ack
t; ovs_vport_cmd_fill_info() call.
>
> Found by code inspection.
>
> Fixes: 9a9634545c70 ("netns: notify netns id events")
> Signed-off-by: Guillaume Nault
> Acked-by: Nicolas Dichtel
> Acked-by: Pravin B Shelar
> Signed-off-by: David S.
old headroom size,
> updating routine is unnecessary.
>
> Signed-off-by: Taehee Yoo
> Tested-by: Greg Rose
> Reviewed-by: Greg Rose
> Signed-off-by: David S. Miller
>
> Cc: Taehee Yoo
> Signed-off-by: Greg Rose
> ---
LGTM.
Acked-by: Yi-H
er
> Signed-off-by: David S. Miller
>
> Cc: Eelco Chaudron
> Acked-by: Eelco Chaudron
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
likely() call around IS_ERR()
>
> IS_ERR() already calls unlikely(), so this extra likely() call
> around the !IS_ERR() is not needed.
>
> Signed-off-by: Enrico Weigelt
> Signed-off-by: David S. Miller
>
> Cc: Enrico Weigelt
>
On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote:
>
> From: Paul Blakey
>
> Upstream commit:
> commit 95a7233c452a58a4c2310c456c73997853b2ec46
> Author: Paul Blakey
> Date: Wed Sep 4 16:56:37 2019 +0300
>
> net: openvswitch: Set OvS recirc_id from tc chain index
>
> Offload
helar
>
> Signed-off-by: David S. Miller
>
> Cc: Yifeng Sun
> Reviewed-by: Yifeng Sun
> Signed-off-by: Greg Rose
> ---
LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
-off-by: Yi-Hung Wei
---
ovsdb/log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovsdb/log.c b/ovsdb/log.c
index 41af77679178..4a28fa3db6da 100644
--- a/ovsdb/log.c
+++ b/ovsdb/log.c
@@ -212,7 +212,7 @@ ovsdb_log_open(const char *name, const char *magic,
if (!strcmp(name
2633995
> Signed-off-by: Gurucharan Shetty
> ---
Thanks for the patch. I think it does fix a case when --monitor is
specified and ovs crash during "ovs-appctl exit".
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ot;modprobe" path="/usr/lib/modules/4.18.0-193.el8.x86_64/modules.dep.bin"
dev="dm-0" ino=624258 scontext=system_u:system_r:openvswitch_load_module_t:s0
tcontext=unconfined_u:object_r:modules_dep_t:s0 tclass=file permissive=0
VMWare-BZ: #2633569
Signed-off-by: Yi-Hu
=64725,tp_dst=6081,
geneve({class=0x102,type=0x7,len=4,0x3}),flags(df|key))),5
VMWare-BZ: 2617696
Reported-by: Ran Gu
Signed-off-by: Yi-Hung Wei
---
https://travis-ci.org/github/YiHungWei/ovs/builds/719445339
---
ofproto/ofproto-dpif-rid.h| 8 ++--
ofproto/ofproto-dpif-upcall.c | 16
really only for debugging anyway.
>
> Signed-off-by: Greg Rose
> ---
>
> V2 - As per Yi-Hung's suggestion change exit code to zero.
> ---
LGTM
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Aug 20, 2020 at 11:00 AM Greg Rose wrote:
>
> The script itself says which versions the script is needed for but
> it is run on RHEL 8.x as well where it is not needed. Disable the
> warning since it may unnecessarily alarm users and is really only
> for debugging anyway.
>
> Signed-off-b
t/brp-mangle-shebangs
>
> I also updated the copyright notices as needed.
>
> 1. https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error
>
> Signed-off-by: Greg Rose
> ---
Thanks for the patch. LGTM.
Acked-by: Yi-Hung Wei
On Mon, Jul 13, 2020 at 1:46 PM William Tu wrote:
>
> The patch fixes two errors due to type mismatched, when converting
> between str and bytes:
> File "/usr/local/sbin/ovs-bugtool", line 649, in main
> cmd_output(CAP_NETWORK_STATUS, [OVS_DPCTL, 'dump-flows', '-m', d])
> File "/usr/local/
upport")
Signed-off-by: Yi-Hung Wei
---
Travis CI: https://travis-ci.org/github/YiHungWei/ovs/builds/705960203
---
acinclude.m4 | 12
configure.ac | 1 +
lib/netdev-linux.c | 8
3 files changed, 21 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m
3cae678bca ("ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy
tables")
Reported-by: Yang Song
Signed-off-by: Yi-Hung Wei
---
Travis CI: https://travis-ci.org/github/YiHungWei/ovs/builds/699829754
Please backport this fix to branch-2.13.
---
tests/ovs-vsctl.at| 8
utilit
75c4d2e
> - ac23d20fc90da3b1c9b2117d1e22102e99fba006
>
> Signed-off-by: Rui Cao
>
Thanks for porting this patch to windows datapath. It looks good from
conntrack's perspective. I do not have a windows environment to test
it tho.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jun 17, 2020 at 11:37 AM William Tu wrote:
>
> Add support for RHEL7.8 GA release with kernel 3.10.0-1127.
>
> VMware-BZ: #2582834
> Signed-off-by: William Tu
> ---
Looks good to me.
Acked-by: Yi-Hung Wei
___
Hi William,
Thanks for the patch. Should we update
rhel/openvswitch-kmod-fedora.spec.in so that the ovs-kmod-manage.sh
will be invoked in the post installation stage? I.e. 391b52f3c33a
("rhel: Support RHEL 7.8 kernel module rpm build")
Thanks,
-Yi-Hung
On Wed, Jun 17, 2020 at 8:43 AM William T
Add notes about some configuration issues when enabling AF_XDP
support.
Signed-off-by: Yi-Hung Wei
---
Documentation/intro/install/afxdp.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/intro/install/afxdp.rst
b/Documentation/intro/install/afxdp.rst
index
On Thu, May 14, 2020 at 8:37 AM William Tu wrote:
>
> On Wed, May 13, 2020 at 01:11:17PM -0700, Yi-Hung Wei wrote:
> > From man ovs-fields(7), the conntrack origin tuple fields
> > ct_nw_src/dst, ct_ipv6_src/dst, and ct_tp_src/dst are supposed
> > to be bitwise maskable,
ig tuple key.")
Reported-by: Wenying Dong
Signed-off-by: Yi-Hung Wei
---
Travis CI: https://travis-ci.org/github/YiHungWei/ovs/builds/686707703
---
lib/meta-flow.c | 30 +--
tests/ofproto-dpif.at | 56 +++
2 file
conntrack-tp.c
> - s/tpid/tp_id/
> - add default timeout value to CT_DPIF_TP_*_ATTRs
> - reduce the CT_CLEAN_INTERVAL from 5 to 3s, to make the tests
> run faster.
> - add more tests to system-traffic.at
> - code refactoring and renaming
> ---
Thanks for this ne
right function.
Related patch in
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
b9f3e457098e ("net: ipv6_stub: use ip6_dst_lookup_flow instead of
ip6_dst_lookup")
Signed-off-by: Yi-Hung Wei
---
Travis test: https://travis-ci.org/github/YiHungWei/
l
>
> Signed-off-by: William Tu
Given that each NIC has different implementation on their rx, tx,
combined queue as mentioned in
https://mail.openvswitch.org/pipermail/ovs-dev/2020-January/366631.html
I think it is a good idea to at log that in the bugtool.
Acked-by: Yi-Hung Wei
___
;>/usr/share/openvswitch/scripts/ovs-bugtool-get-dpdk-nic-numa
> ip -s -s link
> show
> filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-get-port-stats
> --
Thanks for this patch. It will be useful to debug geneve tlv issue.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Apr 27, 2020 at 8:42 AM William Tu wrote:
>
> Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout
> policy support") adds conntrack timeout policy for kernel datapath.
> This patch enables support for the userspace datapath. I tested
> using the 'make check-system-userspace
(reply && conn->state == ICMPS_FIRST) {
> + conn->state = ICMPS_REPLY;
> +}
> +
> +conn_update_expiration(ct, &conn->up, icmp_timeouts[conn->state], now);
> return CT_UPDATE_VALID;
> }
>
> --
Thanks for the patch. Looks good to me.
Acked-by: Yi-Hung Wei
On Sun, Apr 19, 2020 at 9:05 AM William Tu wrote:
>
> Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout
> policy support") adds conntrack timeout policy for kernel datapath.
> This patch enables support for the userspace datapath. I tested
> using the 'make check-system-userspace
tion.pic.o): In function
`ovsdb_function_from_string':
./lib/ovsdb-condition.c:24: multiple definition of `ovsdb_function_to_string'
./libovsdb.a(condition.pic.o):/proc/self/cwd/external/openvswitch_repo/ovsdb/condition.c:335
Reported-by: Harold Lim
Signed-off-by: Yi-Hung Wei
---
Travi
l4 checksum not calculated in packet header,
> and at conntrack, return invalid conntrack state.
>
> Suggested-by: Yi-Hung Wei
> Signed-off-by: William Tu
> ---
LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.op
l4 checksum not calculated in packet header,
> and at conntrack, return invalid conntrack state.
>
> Suggested-by: Yi-Hung Wei
> Signed-off-by: William Tu
> ---
> lib/conntrack.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> in
, the OpenFlow
syntax to delete tun_metadata1 is:
actions=delete_field:tun_metadata1
Signed-off-by: Yi-Hung Wei
---
Travis CI: https://travis-ci.org/github/YiHungWei/ovs/builds/674955333
---
NEWS | 1 +
include/openvswitch/ofp-actions.h | 13 +-
lib/nx
On Sat, Apr 11, 2020 at 8:10 AM William Tu wrote:
>
> Hi Yi-Hung,
>
> I read through the patch and have some questions and comments.
>
> On Fri, Apr 10, 2020 at 01:05:24PM -0700, Yi-Hung Wei wrote:
> > This patch adds a new OpenFlow action, delete field, to delet
On Tue, Apr 7, 2020 at 2:08 PM William Tu wrote:
>
> Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout
> policy support") adds conntrack timeout policy for kernel datapath.
> This patch enables support for the userspace datapath. I tested
> using the 'make check-system-userspace'
syntax is:
actions: delete_field:tun_metadata1
Signed-off-by: Yi-Hung Wei
---
Travis CI: https://travis-ci.org/github/YiHungWei/ovs/builds/673081110
---
NEWS | 1 +
include/openvswitch/ofp-actions.h | 13 +-
lib/nx-match.c| 20
On Tue, Apr 7, 2020 at 2:50 PM Yifeng Sun wrote:
>
> Tun_metadata can be referened by flow and frozen_state at the same
> time. When ovs-vswitchd handles TLV table mod message, the involved
> tun_metadata gets freed. The call trace to free tun_metadata is
> shown as below:
>
> ofproto_run
> - hand
On Tue, Mar 24, 2020 at 8:42 AM Greg Rose wrote:
>
> The extra development repo for RHEL 8 has changed. Document it.
>
> Signed-off-by: Greg Rose
>
> ---
> V2 - Break long line
> ---
> Documentation/intro/install/fedora.rst | 4
> 1 file changed, 4 insertion
y: Greg Rose
> ---
LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Mar 4, 2020 at 3:04 PM Greg Rose wrote:
>
> We are adding support for Linux kernels up to 5.5 so update the
> Travis test list, NEWS and FAQ.
>
> Signed-off-by: Greg Rose
>
> ---
> V3 - Squash separate commits for Travis, NEWS and FAQ
> ---
> .travis.yml| 2 +-
> Docu
is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva
> Signed-off-by: David S. Miller
>
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
strict validation for any new command.
>
> Signed-off-by: Johannes Berg
> Signed-off-by: David S. Miller
>
> Backport portions of this commit applicable to openvswitch and
> added necessary compatibility layer changes to support older
> kernels.
>
> Signed-off-by: Greg Rose
> ---
> V3 - As per Yi-Hung's suggestion just backport the upstream patch
> to stay in sync with upstream kernel code.
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
nge that would take a lot of work to implement.
>
> We could ask the Linux kernel maintainers to provide some
> way for out-of-tree kernel modules to include their own header
> files first in a proper manner. I consider that to be a very
> low probability of success but something we could
David Miller # for net
>
> Also added a compatibility layer macro for older kernels that still
> use SIZEOF_FIELD
>
> Signed-off-by: Greg Rose
> ---
> V3 - As suggested by Yi-Hung go ahead and just do the sizeof_field
> backport rather than the cheap and easy way done i
On Wed, Mar 4, 2020 at 3:04 PM Greg Rose wrote:
>
> Flex array support is removed since kernel 5.1. Convert to use
> kvmalloc_array instead.
>
> Signed-off-by: Greg Rose
> ---
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@ope
to the
> genl_family structure. Add necessary compat layer infrastructure
> to still support older kernels.
>
> Signed-off-by: Greg Rose
> ---
> V3 - Add policy back to genl_family instead of completely removing
> it.
> ---
Thanks for the patch. LGTM.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
and atomic_add functions are replaced with their
> equivalent long counterparts.
>
> Signed-off-by: Greg Rose
> ---
> V3 - Use HAVE_CORRECT_MRU_HANDLING instead of less reliable kernel
> version check for compile time handling of the rb_fragments
> change.
> ---
L
we should update the version number in the
AC_ERROR message as well. Somehow I did not find it in the previous
review.
With the version number update.
Acked-by: Yi-Hung Wei
-Yi-Hung
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ask about.
>
> For now we cheat and take the easy way out.
>
> Reported-by: David Ahern
> Signed-off-by: Greg Rose
> ---
Thanks for this patch. It must be a lot of effort to figure this out.
Acked-by: Yi-Hung Wei
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
>
> Changes for in kernel generated netlink attribute parsing functions
> require our out of tree driver to use the deprecated forms of those
> functions. Otherwise the message parsing will return -EINVAL because
> NLA_F_NESTED is not set in the nl
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
>
> The FIELD_SIZEOF macro is removed in Linux kernel release 5.5 but
> is still needed in our out of tree kernel module for compatibility
> with older kernels.
>
> Signed-off-by: Greg Rose
> ---
> datapath/linux/compat/include/linux/kernel.h | 4
On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote:
>
> Flex array support is removed since kernel 5.1. Convert to use
> kvmalloc_array instead.
>
> Signed-off-by: Greg Rose
> ---
Thanks for the patch. Looks good to me.
Acked-by: Yi-Hung Wei
_
On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote:
>
> The policy field of the genl_ops structure has been removed in recent
> kernels.
>
> Signed-off-by: Greg Rose
> ---
> acinclude.m4 | 3 +++
> datapath/conntrack.c | 8
> datapath/datapath.c | 32
On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote:
>
> Since Linux kernel release 5.1 the fragments field of the inet_frag_queue
> structure is removed and now only the rb_fragments structure with an
> rb_node pointer is used for both ipv4 and ipv6. In addition, the
> atomic_sub and atomic_add func
Patch a867c010ee91 ("conntrack: Fix conntrack new state") fixes
the userspace conntrack behavior. This patch updates the
corresponding conntrack state description.
Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
Reported-by: Roni Bar Yanai
Signed-off-by: Yi-
On Thu, Feb 20, 2020 at 4:42 AM Roni Bar Yanai wrote:
>
> Hi Yi-Hung,
>
> From the man page, it looks like the +est is the result of committing action
> and not related to the TCP state machine itself.
> I'm aware that this is not how it works in kernel conntrack, if you want to
> align both , t
Signed-off-by: Yi-Hung Wei
---
Documentation/faq/openflow.rst | 2 +-
Documentation/faq/qos.rst | 2 +-
Documentation/howto/selinux.rst| 2 +-
Documentation/howto/tunneling.rst | 2 +-
Documentation/intro/install/rhel.rst | 2 +-
Documentation/topics/userspace
("conntrack: Fix conntrack new state")
Reported-by: Dumitru Ceara
Signed-off-by: Yi-Hung Wei
---
Please backport to branch 2.13.
---
lib/conntrack-tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/conntrack-tcp.c b/lib/conntrack-tcp.c
index 416cb769d22f..47
On Fri, Jan 31, 2020 at 2:07 AM Dumitru Ceara wrote:
>
> On 1/29/20 7:58 PM, William Tu wrote:
> > On Fri, Dec 20, 2019 at 01:16:39PM -0800, Ben Pfaff wrote:
> >> On Fri, Dec 20, 2019 at 09:51:08AM -0800, Yi-Hung Wei wrote:
> >>> In connection tracking system,
On Thu, Jan 9, 2020 at 5:39 AM Ilya Maximets wrote:
> On 06.01.2020 22:48, William Tu wrote:
> > On Mon, Dec 23, 2019 at 11:34 AM Yi-Hung Wei wrote:
> >>
> >> This patches detects the number of combined channels on a AF_XDP port
> >> via using ethtool i
anks,
-Yi-Hung
On Mon, Jan 6, 2020 at 2:15 PM Ben Pfaff wrote:
>
> On Mon, Dec 23, 2019 at 11:33:57AM -0800, Yi-Hung Wei wrote:
> > This patches detects the number of combined channels on a AF_XDP port
> > via using ethtool interface. If the number of combined channels
> >
domain
is different from the main thread's NUMA domain, we will have two
cross-NUMA memory accesses (netdev <-> memory, memory <-> CPU).
This patch addresses the aforementioned issue by allocating
the memory in the net device's NUMA domain.
Signed-off-by: Yi-Hung Wei
---
v9:
1 - 100 of 561 matches
Mail list logo
