Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

> On Jul 19, 2017, at 7:32 AM, Justin Pettit wrote: > >> >> On Jul 18, 2017, at 4:15 AM, Eelco Chaudron wrote: >> >> On 18/07/17 08:28, Justin Pettit wrote: On Jul 17, 2017, at 10:06 PM, Numan Siddique wrote: On Tue,

Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

amount of code duplication, but > it is easier to see that it avoids a null dereference. Looks good to me. Thanks. Acked-by: nickcooper-zhangtonghao <n...@opencloud.tech> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

Who can help me to review this patch. Thanks. > On Jun 20, 2017, at 11:04 AM, nickcooper-zhangtonghao <n...@opencloud.tech> > wrote: > > When we use the 'ovs-appctl rstp/show', the root bridge > of rstp is always 'unknown root port'. We don't expect > that. The reas

Re: [ovs-dev] [PATCH v9] netdev-dpdk: Increase pmd thread priority.

If we fail to set the priority, we should return the err code and not return 0. > On Jun 23, 2017, at 4:51 AM, Bhanuprakash Bodireddy > wrote: > > Increase the DPDK pmd thread scheduling priority by lowering the nice > value. This will advise the kernel

[ovs-dev] [PATCH] rstp: Show root bridge info.

' in the same case. If we check only rstp root port, the root info will not shown any more. CC: Ben Pfaff <b...@ovn.org> Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rstp.c b/lib/rstp.c i

Re: [ovs-dev] [PATCH v2 02/12] openvswitch.h: Use odp_port_t for port numbers in userspace-only structs.

Reviewed-by: nickcooper-zhangtonghao <n...@opencloud.tech> > On Jun 19, 2017, at 7:29 AM, Ben Pfaff <b...@ovn.org> wrote: > > Using the correct type reduces the need for type conversions. > > Signed-off-by: Ben Pfaff <b...@ovn.org <mailto:b...@ovn.org>>

Re: [ovs-dev] [PATCH v2 01/12] ofp-util: Remove prototype for unimplemented function.

Reviewed-by: nickcooper-zhangtonghao <n...@opencloud.tech> > On Jun 19, 2017, at 7:29 AM, Ben Pfaff <b...@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <b...@ovn.org <mailto:b...@ovn.org>> > --- > include/openvswitch/ofp-util.h | 2 -- > 1 file changed

[ovs-dev] [PATCH] doc: Add more details for in_port.

When I test OvS openflow, I confuse the 'in_port' with 'output:in_port'. I doc the openflow.rst and it may help others to avoid it. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- Documentation/faq/openflow.rst | 4 1 file changed, 4 insertions(+) diff

Re: [ovs-dev] why ovs can't send packets to in_port.

Thanks. > On Jun 10, 2017, at 12:44 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Fri, Jun 09, 2017 at 08:28:41PM +0800, nickcooper-zhangtonghao wrote: >> Why OvS does not support that we output a packet to a port which it is >> coming from. >> In the case,

Re: [ovs-dev] [PATCH v3 1/5] rstp: Init a recursive mutex for rstp.

> On Jun 1, 2017, at 7:01 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Fri, May 19, 2017 at 12:20:39AM -0700, nickcooper-zhangtonghao wrote: >> * This patch will be used for next patch. The 'rstp/show' command, >> which uses the mutex, calls functions which also use t

[ovs-dev] [PATCH v4 1/3] rstp: Add rstp port name for human reading.

This patch is useful to debug rstp subsystem and log the port name instead of port number. This patch will also be used to display rstp info for next patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Acked-by: Jarno Rajahalme <ja...@ovn.org> --- lib/rstp-common

[ovs-dev] [PATCH v4 3/3] rstp: Add the 'ovs-appctl rstp/show' command.

The rstp/show command will help users and developers to get more details about rstp. This patch works together with the previous patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- NEWS | 3 +- lib/rstp.c

[ovs-dev] [PATCH v4 2/3] rstp: Add internal functions without locks.

This patch adds some internal functions which does not use the locks. This patch is used for next patch. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp.c | 63 +- lib/rstp.h | 2 +- 2 files chang

[ovs-dev] [PATCH v3 2/5] rstp: Add rstp port name for human reading.

This patch is useful to debug rstp subsystem and log the port name instead of port number. This patch will also be used to display rstp info for next patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Acked-by: Jarno Rajahalme <ja...@ovn.org> --- lib/rstp-common

[ovs-dev] [PATCH v3 5/5] stp: Add link-state checking support for stp ports.

is in disable state, it can forward packets. If its link is down and this patch sets it to disable, there is no L2 loop. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 41 - tests/stp.at

[ovs-dev] [PATCH v3 4/5] rstp: Increment the rstp port num counter.

OvS only supports RSTP_MAX_PORTS rstp ports while max port num of stp is STP_MAX_PORTS. This patch increments the rstp port num counter, otherwise the counter is 0 and the checking above will always fail. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/bridge

[ovs-dev] [PATCH v3 3/5] rstp: Add the 'ovs-appctl rstp/show' command.

The rstp/show command will help users and developers to get more details about rstp. This patch works together with the previous patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- NEWS | 3 +- lib/rstp.c

[ovs-dev] [PATCH v3 1/5] rstp: Init a recursive mutex for rstp.

with ovstest, does not run rstp_init in the bridge_init. We should call rstp_init when creating the rstp and stp also do that, otherwise tests fail. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp.c | 54 ++--- lib/rstp.h

Re: [ovs-dev] [PATCH v2 1/5] rstp: Init a recursive mutex for rstp.

> On May 19, 2017, at 6:47 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, May 10, 2017 at 04:15:02AM -0700, nickcooper-zhangtonghao wrote: >> * This patch will be used for next patch. The 'rstp/show' command, >> which uses the mutex, calls functions which also use t

[ovs-dev] [PATCH v2 5/5] stp: Add link-state checking support for stp ports.

is in disable state, it can forward packets. If its link is down and this patch sets it to disable, there is no L2 loop. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 41 - tests/stp.at

[ovs-dev] [PATCH v2 3/5] rstp: Add the 'ovs-appctl rstp/show' command.

The rstp/show command will help users and developers to get more details about rstp. This patch works together with the previous patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- NEWS | 3 +- lib/rstp.c

[ovs-dev] [PATCH v2 4/5] rstp: Increment the rstp port num counter.

OvS only supports RSTP_MAX_PORTS rstp ports while max port num of stp is STP_MAX_PORTS. This patch increments the rstp port num counter, otherwise the counter is 0 and the checking above will always fail. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/bridge

[ovs-dev] [PATCH v2 2/5] rstp: Add rstp port name for human reading.

This patch is useful to debug rstp subsystem and log the port name instead of port number. This patch will also be used to display rstp info for next patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Acked-by: Jarno Rajahalme <ja...@ovn.org> --- lib/rstp-common

[ovs-dev] [PATCH v2 1/5] rstp: Init a recursive mutex for rstp.

creating the rstp and stp also do that, otherwise tests fail. * This patch remove the rstp_mutex in header file and make it static in c file because we only use it in lib/rstp.c Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp.c | 15 --- lib/rstp.

Re: [ovs-dev] [PATCH 6/6] rstp: Add the 'ovs-appctl rstp/show' command.

> On Apr 21, 2017, at 9:08 AM, Jarno Rajahalme <ja...@ovn.org> wrote: > > I’d like to see one of the existing RSTP test cases modified to use this new > feature. > > One more comment below, > > Jarno > > >> On Mar 31, 2017, at 8:11 PM, ni

Re: [ovs-dev] [PATCH 4/6] rstp: Init a recursive mutex for rstp.

> On Apr 21, 2017, at 8:59 AM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: > >> >> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> wrote: >> >> This p

Re: [ovs-dev] [PATCH 4/6] rstp: Init a recursive mutex for rstp.

> On Apr 21, 2017, at 8:59 AM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: > >> >> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> wrote: >> >> This p

Re: [ovs-dev] [PATCH 2/6] stp: Use OpenFlow port number for stp ports.

> On Apr 21, 2017, at 8:34 AM, Jarno Rajahalme <ja...@ovn.org> wrote: > >> >> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> wrote: >> >> When a bridge stp enabled, we assign se

Re: [ovs-dev] [PATCH 1/6] rstp/stp: Unref the rstp/stp when bridges destroyed.

org/patch/745885/> ofproto: http://patchwork.ozlabs.org/patch/743155/ <http://patchwork.ozlabs.org/patch/743155/> Thanks. Nick > On Apr 1, 2017, at 11:11 AM, nickcooper-zhangtonghao <n...@opencloud.tech> > wrote: > > When bridges destroyed, which stp enabled, you c

[ovs-dev] [PATCH 6/6] rstp: Add the 'ovs-appctl rstp/show' command.

The rstp/show command will help users and developers to get more details about rstp. This patch works together with the previous patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- NEWS | 4 +- lib/rstp.c

[ovs-dev] [PATCH 3/6] stp: Add link-state checking support for stp ports.

When bridge stp enabled, we enable the stp ports despite ports are down. When initializing, this patch checks link-state of ports and enable or disable them according to their link-state. This patch also allow user to enable and disable a port when bridge stp is running. Signed-off-by: nickcooper

[ovs-dev] [PATCH 5/6] rstp: Add rstp port name for human reading.

This patch is useful to debug rstp subsystem and log the port name instead of port number. This patch will also be used to display rstp info for next patches. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp-common.h | 1 + lib/rstp.c

[ovs-dev] [PATCH 4/6] rstp: Init a recursive mutex for rstp.

This patch will be used for next patch. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rstp.c | 15 --- lib/rstp.h | 6 -- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/rstp.c b/lib/rstp.c index 907a907..6f1c1e3 100644 --- a/lib/

[ovs-dev] [PATCH 2/6] stp: Use OpenFlow port number for stp ports.

port may belong to other one. This patch uses the OpenFlow port numbers instead of sequence numbers to avoid it. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- tests/stp.at | 90 ++- vswitchd/bridge.c | 10 +-- 2

[ovs-dev] [PATCH 1/6] rstp/stp: Unref the rstp/stp when bridges destroyed.

struct in the 'destruct' of ofproto-dpif provider. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 523adad..4beacda 100644 --- a/ofproto/ofproto-

[ovs-dev] [PATCH] ofproto: Limit log rate when controller disconnected.

There are a lot of logs when OvS bridges can’t connect to controllers. The controller may stop or something causes a disruption in network traffic. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/rconn.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [ovs-dev] [PATCH] tests: Add and improve stp tests.

Hi, the new patch has been submitted. It fixes the issue on ubuntu and newer kernel (4.10.4). You can review and tested it. http://patchwork.ozlabs.org/patch/742517/ ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH v2] stp: Fix stp tests and make them more stable.

). This patch has been tested for 3 hours. This patch may make the stp tests more stable. Fixes: 427e9751f300 ("tests: Add and improve stp tests.") Reported-at: http://paste.ubuntu.com/24215426 Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/330032.html Signed-off-by:

[ovs-dev] [PATCH] rstp/stp: Unref the rstp/stp when bridges destroyed.

struct in the 'destruct' of ofproto-dpif provider. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 523adad..4beacda 100644 --- a/ofproto/ofproto-

[ovs-dev] [PATCH] stp: Fix stp test.

e stp tests.") Reported-at: http://paste.ubuntu.com/24215426 Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- tests/stp.at | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/stp.at b/tests/stp.at index 20f7940..542e700 100644 --- a/tests/st

Re: [ovs-dev] [PATCH] tests: Add and improve stp tests.

I tested it via command as below for a long time. while true; do make check TESTSUITEFLAGS='-k stp'; done But it’s ok. I try to find what might cause this. Thanks. Nick > On Mar 21, 2017, at 5:24 AM, Joe Stringer wrote: > > Right, Travis seems happy too so most likely it's

[ovs-dev] [PATCH 1/2] stp: Change the api for next patch.

This patch changes the stp_port_get_role and removes the stp_port_get_id, because stp/show has locked the mutex before calling the stp_port_get_role, and stp_port_get_id will not be used. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Acked-by: Ben Pfaff <b...@ovn.org&

[ovs-dev] [PATCH 2/2] stp: Add the 'ovs-appctl stp/show' command.

The stp/show command will help users and developers to get more details about stp. This patch works together with the previous patch "stp: Change the api for next patch." Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Co-authored-by: Ben Pfaff <b...

Re: [ovs-dev] [PATCH] stp: Set time of BPDU packet.

I was wrong. Thanks. Nick > On Mar 18, 2017, at 6:56 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Mar 08, 2017 at 03:53:10AM -0800, nickcooper-zhangtonghao wrote: >> The OvS BPDU packets have not right format. The STP works >> well in OvS bridges when st

Re: [ovs-dev] [PATCH 2/4] stp: Add the stp/show command.

Thanks very much, I submitted v2 and added the “Co-authored-by". Nick > On Mar 18, 2017, at 2:37 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Mar 07, 2017 at 05:11:28AM -0800, nickcooper-zhangtonghao wrote: >> The stp/show command will help users and developers get

Re: [ovs-dev] [PATCH 1/4] stp: Change the api for next patch.

work.ozlabs.org/patch/736159/> http://patchwork.ozlabs.org/patch/736229/ <http://patchwork.ozlabs.org/patch/736229/> http://patchwork.ozlabs.org/patch/736548/ <http://patchwork.ozlabs.org/patch/736548/> Thanks. Nick > On Mar 7, 2017, at 9:11 PM, nickcooper-zhangtongh

Re: [ovs-dev] [PATCH] debian; Avoid installing ovs-vswitchd.conf.db manpage as "db" language.

I have tested it. It is ok now. Simon, what do you think about it? Tested-by: nickcooper-zhangtonghao <n...@opencloud.tech> > On Mar 9, 2017, at 2:22 AM, Ben Pfaff <b...@ovn.org> wrote: > > Simon, would you mind reviewing this, since it's about t

[ovs-dev] [PATCH] debian: Rewrite "ifconfig" to "ip" command.

Some debian distribution may not contain the ifconfig. We use the ip command instead of ifconfig in debian/ifupdown.sh Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329503.html CC: prochazka <procha...@cortex.cz> Signed-off-by: nickcooper-zhangtong

[ovs-dev] [PATCH] stp: Set time of BPDU packet.

The OvS BPDU packets have not right format. The STP works well in OvS bridges when stp enabled, because they set the time(e.g. max age, hello time and forward delay) in ticks. But they should be sec. If so, OvS STP can work well with other type of bridge using STP. Signed-off-by: nickcooper

[ovs-dev] [PATCH 4/4] stp: Don't wait a hello-time before sending BPDU.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/stp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stp.c b/lib/stp.c index d90b400..d828c64 100644 --- a/lib/stp.c +++ b/lib/stp.c @@ -306,7 +306,7 @@ stp_create(const char *name, stp_iden

[ovs-dev] [PATCH 3/4] stp: Set BPDU max age exactly.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 2e10013..961ebe6 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -1538,7 +

[ovs-dev] [PATCH 2/4] stp: Add the stp/show command.

The stp/show command will help users and developers get more details about stp. This patch works together with the previous patch "stp: Change the api for next patch." Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> ---

[ovs-dev] [PATCH 1/4] stp: Change the api for next patch.

This patch changes the stp_port_get_role and removes the stp_port_get_id, because stp/show has locked the mutex before calling the stp_port_get_role, and stp_port_get_id will not be used. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/stp.c

[ovs-dev] [PATCH] mcast-snooping: Add and improve mcast-snooping tests.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- tests/mcast-snooping.at | 112 1 file changed, 112 insertions(+) diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at index c03aba3..90de8b3 100644 --- a/tests

[ovs-dev] [PATCH v2 1/2] mcast-snooping: Flush ports mdb when VLAN configuration changed.

If VLAN configuration(e.g. id, mode) change occurs, the IGMP snooping-learned multicast groups from this port on the VLAN are deleted. This avoids a MCAST_ENTRY_DEFAULT_IDLE_TIME delay before mdb is updated again. Hardware switches (e.g. cisco) also do that. Signed-off-by: nickcooper-zhangtonghao

[ovs-dev] [PATCH v2 2/2] mcast-snooping: Avoid segfault for vswitchd.

pif.c:4781 process_command lib/unixctl.c:313 run_connection lib/unixctl.c:347 unixctl_server_run lib/unixctl.c:400 main vswitchd/ovs-vswitchd.c:112 Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[ovs-dev] [PATCH 1/2] mcast-snooping: Flush ports mdb when VLAN configuration changed.

If VLAN configuration(e.g. id, mode) change occurs, the IGMP snooping-learned multicast groups from this port on the VLAN are deleted. This avoids a MCAST_ENTRY_DEFAULT_IDLE_TIME delay before mdb is updated again. Hardware switches (e.g. cisco) also do that. Signed-off-by: nickcooper-zhangtonghao

[ovs-dev] [PATCH 2/2] mcast-snooping: Avoid segfault for vswitchd.

port, Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 366b7a2..1e1b107 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c

[ovs-dev] [PATCH 2/3] dpdk: Improve manpage for dpdk memory configuration.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/vswitch.xml | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 782417f..a91be59 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswit

[ovs-dev] [PATCH 3/3] lacp: Fix formatting typo.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/lacp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/lacp.c b/lib/lacp.c index 64c9849..7716387 100644 --- a/lib/lacp.c +++ b/lib/lacp.c @@ -337,7 +337,7 @@ lacp_process_packet(struct lacp

[ovs-dev] [PATCH 1/3] doc: Fix issues.rst formatting typo.

The preformatted block is only finished when the text falls back to the same indentation level as a paragraph prior to the preformatted block. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- Documentation/faq/issues.rst | 4 +++- 1 file changed, 3 insertions(+), 1 de

[ovs-dev] [PATCH] doc: Fix issues.rst formatting typo.

The preformatted block is only finished when the text falls back to the same indentation level as a paragraph prior to the preformatted block. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- Documentation/faq/issues.rst | 4 +++- 1 file changed, 3 insertions(+), 1 de

Re: [ovs-dev] [PATCH] ofproto/bond: Fix bond/show when all interfaces are disabled

> On Feb 17, 2017, at 4:49 AM, Andy Zhou wrote: > > Without this patch, when all slaves are disabled, the 'bond/show' > command still shows the mac address of last active slave in > 'active slave mac' output. This patch clears them to zeros. > > Signed-off-by: Andy Zhou

[ovs-dev] [PATCH] ovs-appctl: Print lacp_fallback_ab info in "bond/show".

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.c | 3 +++ tests/lacp.at | 9 + 2 files changed, 12 insertions(+) diff --git a/ofproto/bond.c b/ofproto/bond.c index 2e018aa..de75f87 100644 --- a/ofproto/bond.c +++ b/ofproto/bond.c @@ -1325,6 +

[ovs-dev] [PATCH v2] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

The balance-tcp mode requires the upstream switch to support 802.3ad with successful LACP negotiation. When bond ports are configured to balance-tcp mode without lacp or lacp is disabled, drop the traffic. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond

Re: [ovs-dev] [PATCH 3/4] ofproto/bond: balance-slb mode fallbacks to active-backup mode.

> On Feb 15, 2017, at 12:01 PM, Andy Zhou <az...@ovn.org> wrote: > > On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao > <n...@opencloud.tech <mailto:n...@opencloud.tech>> wrote: >> lacp-fallback-ab determines the behavior of OvS bond in LACP

Re: [ovs-dev] [PATCH 2/4] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

> On Feb 15, 2017, at 11:51 AM, Andy Zhou <az...@ovn.org> wrote: > > On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao > <n...@opencloud.tech <mailto:n...@opencloud.tech>> wrote: >> The balance-tcp mode requires the upstream switch to support 802.3ad

[ovs-dev] [PATCH 4/4] doc: Updates bonding.rst because of api changed.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- Documentation/topics/bonding.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/topics/bonding.rst b/Documentation/topics/bonding.rst index 2f67cbb..461935a 100644 --- a/Documen

[ovs-dev] [PATCH 3/4] ofproto/bond: balance-slb mode fallbacks to active-backup mode.

-backup mode is used. But if users configure the bond port to balance-slb and lacp (unsuccessfully), active-backup mode is also used. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-)

[ovs-dev] [PATCH 2/4] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

The balance-tcp mode requires the upstream switch to support 802.3ad with successful LACP negotiation. When bond ports are configured to balance-tcp mode without lacp or lacp is disabled, drop the traffic. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.

[ovs-dev] [PATCH 1/4] ofproto/bond: Validate active-slave mac.

and mac in the ovsdb is also zero. The active_slave_mac and active_slave_changed should be initialized when created. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ofproto/bond.c b/o

[ovs-dev] [PATCH] dpdk: Improve manpage for dpdk memory configuration.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- vswitchd/vswitch.xml | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 146a816..a3beafd 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswit

[ovs-dev] [PATCH 2/3] ofproto/bond: balance-tcp mode fallbacks to active-backup mode.

-backup mode is used. But if users configure the bond port to balance-slb and lacp (unsuccessfully), active-backup mode is also used. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-)

[ovs-dev] [PATCH 1/3] ofproto/bond: Drops traffic in balance-tcp mode without lacp.

The balance-tcp mode requires the upstream switch to support 802.3ad with successful LACP negotiation. When bond ports are configured to balance-tcp mode without lacp or lacp is disabled, drop the traffic. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/bond.

[ovs-dev] [PATCH] ofproto: Uses the VLOG_WARN_RL instead of VLOG_WARN.

There are a lot of logs when OvS bridges, connected to controllers, can't find the right routes. So we may use the VLOG_WARN_RL instead of VLOG_WARN to limit the log messages. The netdev-open and arp-lookingup are in the same case in this function. Signed-off-by: nickcooper-zhangtonghao &l

Re: [ovs-dev] [BUG] upcall handler thread crash

Hi, what’s the OvS version you tested. I didn’t get the crash with master version. The test script is described as below. ovs-vsctl add-br br0 ovs-vsctl add-port br0 eth1 for i in `seq 0 1000`; do ovs-vsctl add-port br0 eth2 ovs-vsctl del-port br0 eth2 done Thanks. Nick > On Feb 4,

[ovs-dev] [PATCH] dpif-netdev: Avoids repeated addition of DP_STAT_LOST.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/dpif-netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 08167b5..3901129 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4258,7 +4258,6 @@ fast_path_proc

[ovs-dev] [PATCH v3] netdev-dummy: Limits the number of tx/rx queues.

This patch avoids the ovs_rcu to report WARN, caused by blocked for a long time, when ovs-vswitchd processes a port with many rx/tx queues. The number of tx/rx queues per port may be appropriate, because the dpdk uses it as an default max value. Signed-off-by: nickcooper-zhangtonghao &l

Re: [ovs-dev] [PATCH 2/4] datapath: Limits the number of tx/rx queues for netdev-dummy.

Thanks, I got it. :) > On Jan 10, 2017, at 10:11 AM, Daniele Di Proietto <diproiet...@ovn.org> wrote: > > 2017-01-08 20:02 GMT-08:00 nickcooper-zhangtonghao <n...@opencloud.tech > <mailto:n...@opencloud.tech>>: >> Thanks Daniele, >> Yes, it’s a small

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

Thank you for explaining this to me. I got it. > On Jan 10, 2017, at 10:09 AM, Daniele Di Proietto > wrote: > >> >> >> >> hi Daniele, >> I reviewed this patch. One question to ask: should we check the >> hugepage mm before calling the rte_eal_init()? improvement on

Re: [ovs-dev] [PATCH v2] netdev-dummy: Limits the number of tx/rx queues.

may be appropriate, >> because the dpdk uses it as an default max value. >> >> Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech >> <mailto:n...@opencloud.tech>> >> --- > > I don't understand how this change impacts the ovs_rcu warning,

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

Yes, but this patch looks good to me. > On Jan 9, 2017, at 11:35 PM, Aaron Conole <acon...@redhat.com> wrote: > > nickcooper-zhangtonghao <n...@opencloud.tech <mailto:n...@opencloud.tech>> > writes: > >> hi Daniele, >> I reviewed thi

[ovs-dev] [PATCH v2] netdev-dummy: Limits the number of tx/rx queues.

This patch avoids the ovs_rcu to report WARN, caused by blocked for a long time, when ovs-vswitchd processes a port with many rx/tx queues. The number of tx/rx queues per port may be appropriate, because the dpdk uses it as an default max value. Signed-off-by: nickcooper-zhangtonghao &l

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

hi Daniele, I reviewed this patch. One question to ask: should we check the hugepage mm before calling the rte_eal_init()? improvement on next version? Thanks. Nick > On Jan 9, 2017, at 11:21 AM, Daniele Di Proietto > wrote: > > With this commit, we allow the user to

Re: [ovs-dev] [PATCH 2/4] datapath: Limits the number of tx/rx queues for netdev-dummy.

Di Proietto <diproiet...@ovn.org> wrote: > > 2017-01-08 17:30 GMT-08:00 nickcooper-zhangtonghao <n...@opencloud.tech > <mailto:n...@opencloud.tech>>: >> This patch avoids the ovs_rcu to report WARN, caused by blocked >> for a long time, when ovs-vswitchd

[ovs-dev] [PATCH 4/4] datapath: Uses the OVS_CORE_UNSPEC instead of magic numbers.

This patch uses OVS_CORE_UNSPEC for the queue unpinned instead of "-1". More important, the "-1" casted to unsigned int is equal to NON_PMD_CORE_ID. We make the distinction between them. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/dpif-netdev.c

[ovs-dev] [PATCH 3/4] datapath: Uses the NR_QUEUE instead of magic numbers.

The NR_QUEUE is defined in "lib/dpif-netdev.h", netdev-dpdk uses it instead of magic number. netdev-dummy should be in the same case. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/netdev-dummy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[ovs-dev] [PATCH 1/4] datapath: Fix formatting typo.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 625f425..376aa4d 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -738,7

[ovs-dev] [PATCH] openvswitch: FTBFS with dpkg-buildpackage.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- debian/rules | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 4c34b07..12fb94a 100755 --- a/debian/rules +++ b/debian/rules @@ -48,7 +48,7 @@ override_dh_auto_clean:

Re: [ovs-dev] [PATCH 1/3] datapath: Checks the MTU for netdev-internal ports.

Thanks Jarno, I will try it. Thanks. Nick > On Dec 13, 2016, at 4:58 AM, Jarno Rajahalme wrote: > > We should first backport this upstream commit and see if there is anything > left to fix. Either way, Linux kernel datapath fixes should be first fixed on > the upstream net-next

[ovs-dev] [PATCH 1/3] datapath: Checks the MTU for netdev-internal ports.

We should check the MTU before changing it. Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- datapath/vport-internal_dev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c index 482af37..5

Re: [ovs-dev] request for assistance with Debian maintenance

Hi Ben. If there were not better man for this job，i may make a contribution to openvswitch and do a good job with it . It is a really intersting job and probably is the most worthwhile to invest more time developing and learning . I submited patches for openvswitch and ovn. However if

[ovs-dev] [PATCH v2 1/2] ovs-sandbox: add '--vswitchd-unforced-dummy' option.

The ovs-sandbox runs in the "dummy mode" by default. In this mode of testing, no packets travel across physical or virtual networks. But sometimes, we may create veth network devices and add them to ovs bridge for developing and testing. It's necessary to add an option. Signed-off-by:

Re: [ovs-dev] [PATCH 1/4] ovs-vswitchd: Avoid segfault for "netdev" datapath.

Hi Ben and Daniele, Thanks for your tips. I submitted the patch again. The test has been added. May I also add “Signed-off-by: Daniele Di Proietto ” ? Thanks. Nick > On Dec 7, 2016, at 7:51 AM, Daniele Di Proietto wrote: > > Thanks for the patch >

[ovs-dev] [PATCH 2/4] ovs-sandbox: add '-u, --disable-dummy' options.

The ovs-sandbox runs in the "dummy mode" by default. In this mode of testing, no packets travel across physical or virtual networks. But sometimes, we may create veth network devices and add them to ovs bridge for developing and testing. It's necessary to add an option. Signed-off-by:

[ovs-dev] [PATCH 4/4] ovs-appctl: Add usage content to "upcall/set-flow-limit" command.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- ofproto/ofproto-dpif-upcall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 84f1de2..6cb9c2e 100644 --- a/ofproto/ofproto-dpif-up

[ovs-dev] [PATCH 1/4] ovs-vswitchd: Avoid segfault for "netdev" datapath.

bridge_run__ vswitchd/bridge.c:2875 #15 0x0040f145 bridge_run vswitchd/bridge.c:2938 #16 0x004062e5 main vswitchd/ovs-vswitchd.c:111 Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> --- lib/dpif-netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

Re: [ovs-dev] [PATCH 4/4] ovs: optimize 'ip_parse_port' function.

Hi Guru Shetty I folded in the following minor incremental just because ovs_scan_len() is only really meant for situations where the 'n' offset is being incremented over several calls. Thanks. Nick > On Nov 19, 2016, at 2:35 AM, Guru Shetty wrote: > > Can you tell why one is

Re: [ovs-dev] [PATCH 1/4] ovn: Support DNAT with port.

I got it. Thank you explaining this. Can you review the v1 of NAT command, and other patches ? Thanks very much. http://patchwork.ozlabs.org/patch/680778/ http://patchwork.ozlabs.org/patch/680777/

Re: [ovs-dev] [PATCH 1/4] ovn: Support DNAT with port.

Hi Guru Shetty. LB may support DNAT with port. But in some case, there is only a public ip address set on the gateway router, which is connected to multiple VMs. Thus this public ip address need to be projected to multiple private ip address. They denote a one to many relationship not one to

  1   2   >