Re: [ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK v21.11.
On 09/12/2021 16:35, Stokes, Ian wrote: On 12/9/21 16:24, Stokes, Ian wrote: On Thu, Dec 9, 2021 at 1:27 PM Ian Stokes wrote: This commit adds support for DPDK v21.11, it includes the following changes. 1. ci: Install python elftools for DPDK 21.02. 2. ci: Update meson requirement for DPDK 21.05. 3. netdev-dpdk: Fix build with 21.05. 4. ci: Compile DPDK in non developer mode. http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480=* 5. netdev-dpdk: Remove access to DPDK internals. 6. netdev-dpdk: Remove unused attribute from rte_flow rule. 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1. 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2. http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040=* In addition documentaion and DPDK unit tests were also updated in this commit for use with DPDK v21.11. For credit all authors of the original commits to 'dpdk-latest' with the above changes have been added as co-authors for this commit. Signed-off-by: David Marchand Co-authored-by: David Marchand Reviewed-by: Maxime Coquelin Signed-off-by: Ian Stokes --- RFC -> V1 * Add telemetry warning to OVS DPDK unit tests. * Update TSO documentation link to 21.11. * Update fedora spec to use 21.11. --- .ci/linux-build.sh | 6 +- .ci/linux-prepare.sh | 4 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 16 +- Documentation/topics/dpdk/phy.rst| 8 +- Documentation/topics/dpdk/vdev.rst | 2 +- Documentation/topics/dpdk/vhost-user.rst | 2 +- Documentation/topics/testing.rst | 2 +- Documentation/topics/userspace-tso.rst | 2 +- NEWS | 1 + lib/dp-packet.h | 26 +- lib/netdev-dpdk.c| 115 +++ rhel/openvswitch-fedora.spec | 515 +++ You should update rhel/openvswitch-fedora.spec.in not the generated rhel/openvswitch-fedora.spec. Ah, apologies, I've spun a v2 and corrected this + rebased on master. [snip] This log is displayed when DPDK is compiled without libjansson (in this case, the metrics library register no "legacy" callbacks, hence the log..). Ok for waiving it for now. I'll submit a patch on DPDK side to lower it to INFO level because I find it useless. Rest lgtm. Thanks Ian! Thanks David, as I said, I've sent a v2. @Ilya Maximets Are there any blockers you see or am I good to merge this? On a brief look-through I didn't notice anything blocking in v2. Though, I didn't try to use it. So, if David and Kevin are OK with the patch, then it should be good to go. Best regards, Ilya Maximets. Thanks Ilya, @Kevin Traynor any blockers your side on above? No blockers, just a few nits on the commit message. Replied directly to the v2 patch https://mail.openvswitch.org/pipermail/ovs-dev/2021-December/390066.html thanks, Kevin. Thanks Ian Thanks Ian -- David Marchand ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK v21.11.
> On 12/9/21 16:24, Stokes, Ian wrote: > >> On Thu, Dec 9, 2021 at 1:27 PM Ian Stokes wrote: > >>> > >>> This commit adds support for DPDK v21.11, it includes the following > >>> changes. > >>> > >>> 1. ci: Install python elftools for DPDK 21.02. > >>> 2. ci: Update meson requirement for DPDK 21.05. > >>> 3. netdev-dpdk: Fix build with 21.05. > >>> 4. ci: Compile DPDK in non developer mode. > >>> > >>> > >> > http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480=* > >>> > >>> 5. netdev-dpdk: Remove access to DPDK internals. > >>> 6. netdev-dpdk: Remove unused attribute from rte_flow rule. > >>> 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1. > >>> 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2. > >>> > >>> > >> > http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040=* > >>> > >>> In addition documentaion and DPDK unit tests were also updated in this > >>> commit for use with DPDK v21.11. > >>> > >>> For credit all authors of the original commits to 'dpdk-latest' with the > >>> above > >>> changes have been added as co-authors for this commit. > >>> > >>> Signed-off-by: David Marchand > >>> Co-authored-by: David Marchand > >>> Reviewed-by: Maxime Coquelin > >>> Signed-off-by: Ian Stokes > >>> > >>> --- > >>> RFC -> V1 > >>> * Add telemetry warning to OVS DPDK unit tests. > >>> * Update TSO documentation link to 21.11. > >>> * Update fedora spec to use 21.11. > >>> --- > >>> .ci/linux-build.sh | 6 +- > >>> .ci/linux-prepare.sh | 4 +- > >>> Documentation/faq/releases.rst | 2 +- > >>> Documentation/intro/install/dpdk.rst | 16 +- > >>> Documentation/topics/dpdk/phy.rst| 8 +- > >>> Documentation/topics/dpdk/vdev.rst | 2 +- > >>> Documentation/topics/dpdk/vhost-user.rst | 2 +- > >>> Documentation/topics/testing.rst | 2 +- > >>> Documentation/topics/userspace-tso.rst | 2 +- > >>> NEWS | 1 + > >>> lib/dp-packet.h | 26 +- > >>> lib/netdev-dpdk.c| 115 +++ > >>> rhel/openvswitch-fedora.spec | 515 > >> +++ > >> > >> You should update rhel/openvswitch-fedora.spec.in not the generated > >> rhel/openvswitch-fedora.spec. > > > > Ah, apologies, I've spun a v2 and corrected this + rebased on master. > > > > [snip] > > > >> This log is displayed when DPDK is compiled without libjansson (in > >> this case, the metrics library register no "legacy" callbacks, hence > >> the log..). > >> Ok for waiving it for now. > >> I'll submit a patch on DPDK side to lower it to INFO level because I > >> find it useless. > >> > >> > >> Rest lgtm. > >> > >> Thanks Ian! > > > > Thanks David, as I said, I've sent a v2. > > > > @Ilya Maximets Are there any blockers you see or am I good to merge this? > > On a brief look-through I didn't notice anything blocking in v2. > Though, I didn't try to use it. So, if David and Kevin are OK with > the patch, then it should be good to go. > > Best regards, Ilya Maximets. Thanks Ilya, @Kevin Traynor any blockers your side on above? Thanks Ian > > > > > Thanks > > Ian > >> > >> > >> -- > >> David Marchand > > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK v21.11.
On 12/9/21 16:24, Stokes, Ian wrote: >> On Thu, Dec 9, 2021 at 1:27 PM Ian Stokes wrote: >>> >>> This commit adds support for DPDK v21.11, it includes the following >>> changes. >>> >>> 1. ci: Install python elftools for DPDK 21.02. >>> 2. ci: Update meson requirement for DPDK 21.05. >>> 3. netdev-dpdk: Fix build with 21.05. >>> 4. ci: Compile DPDK in non developer mode. >>> >>> >> http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480=* >>> >>> 5. netdev-dpdk: Remove access to DPDK internals. >>> 6. netdev-dpdk: Remove unused attribute from rte_flow rule. >>> 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1. >>> 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2. >>> >>> >> http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040=* >>> >>> In addition documentaion and DPDK unit tests were also updated in this >>> commit for use with DPDK v21.11. >>> >>> For credit all authors of the original commits to 'dpdk-latest' with the >>> above >>> changes have been added as co-authors for this commit. >>> >>> Signed-off-by: David Marchand >>> Co-authored-by: David Marchand >>> Reviewed-by: Maxime Coquelin >>> Signed-off-by: Ian Stokes >>> >>> --- >>> RFC -> V1 >>> * Add telemetry warning to OVS DPDK unit tests. >>> * Update TSO documentation link to 21.11. >>> * Update fedora spec to use 21.11. >>> --- >>> .ci/linux-build.sh | 6 +- >>> .ci/linux-prepare.sh | 4 +- >>> Documentation/faq/releases.rst | 2 +- >>> Documentation/intro/install/dpdk.rst | 16 +- >>> Documentation/topics/dpdk/phy.rst| 8 +- >>> Documentation/topics/dpdk/vdev.rst | 2 +- >>> Documentation/topics/dpdk/vhost-user.rst | 2 +- >>> Documentation/topics/testing.rst | 2 +- >>> Documentation/topics/userspace-tso.rst | 2 +- >>> NEWS | 1 + >>> lib/dp-packet.h | 26 +- >>> lib/netdev-dpdk.c| 115 +++ >>> rhel/openvswitch-fedora.spec | 515 >> +++ >> >> You should update rhel/openvswitch-fedora.spec.in not the generated >> rhel/openvswitch-fedora.spec. > > Ah, apologies, I've spun a v2 and corrected this + rebased on master. > > [snip] > >> This log is displayed when DPDK is compiled without libjansson (in >> this case, the metrics library register no "legacy" callbacks, hence >> the log..). >> Ok for waiving it for now. >> I'll submit a patch on DPDK side to lower it to INFO level because I >> find it useless. >> >> >> Rest lgtm. >> >> Thanks Ian! > > Thanks David, as I said, I've sent a v2. > > @Ilya Maximets Are there any blockers you see or am I good to merge this? On a brief look-through I didn't notice anything blocking in v2. Though, I didn't try to use it. So, if David and Kevin are OK with the patch, then it should be good to go. Best regards, Ilya Maximets. > > Thanks > Ian >> >> >> -- >> David Marchand > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK v21.11.
> On Thu, Dec 9, 2021 at 1:27 PM Ian Stokes wrote: > > > > This commit adds support for DPDK v21.11, it includes the following > > changes. > > > > 1. ci: Install python elftools for DPDK 21.02. > > 2. ci: Update meson requirement for DPDK 21.05. > > 3. netdev-dpdk: Fix build with 21.05. > > 4. ci: Compile DPDK in non developer mode. > > > > > http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480=* > > > > 5. netdev-dpdk: Remove access to DPDK internals. > > 6. netdev-dpdk: Remove unused attribute from rte_flow rule. > > 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1. > > 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2. > > > > > http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040=* > > > > In addition documentaion and DPDK unit tests were also updated in this > > commit for use with DPDK v21.11. > > > > For credit all authors of the original commits to 'dpdk-latest' with the > > above > > changes have been added as co-authors for this commit. > > > > Signed-off-by: David Marchand > > Co-authored-by: David Marchand > > Reviewed-by: Maxime Coquelin > > Signed-off-by: Ian Stokes > > > > --- > > RFC -> V1 > > * Add telemetry warning to OVS DPDK unit tests. > > * Update TSO documentation link to 21.11. > > * Update fedora spec to use 21.11. > > --- > > .ci/linux-build.sh | 6 +- > > .ci/linux-prepare.sh | 4 +- > > Documentation/faq/releases.rst | 2 +- > > Documentation/intro/install/dpdk.rst | 16 +- > > Documentation/topics/dpdk/phy.rst| 8 +- > > Documentation/topics/dpdk/vdev.rst | 2 +- > > Documentation/topics/dpdk/vhost-user.rst | 2 +- > > Documentation/topics/testing.rst | 2 +- > > Documentation/topics/userspace-tso.rst | 2 +- > > NEWS | 1 + > > lib/dp-packet.h | 26 +- > > lib/netdev-dpdk.c| 115 +++ > > rhel/openvswitch-fedora.spec | 515 > +++ > > You should update rhel/openvswitch-fedora.spec.in not the generated > rhel/openvswitch-fedora.spec. Ah, apologies, I've spun a v2 and corrected this + rebased on master. [snip] > This log is displayed when DPDK is compiled without libjansson (in > this case, the metrics library register no "legacy" callbacks, hence > the log..). > Ok for waiving it for now. > I'll submit a patch on DPDK side to lower it to INFO level because I > find it useless. > > > Rest lgtm. > > Thanks Ian! Thanks David, as I said, I've sent a v2. @Ilya Maximets Are there any blockers you see or am I good to merge this? Thanks Ian > > > -- > David Marchand ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK v21.11.
On Thu, Dec 9, 2021 at 1:27 PM Ian Stokes wrote:
>
> This commit adds support for DPDK v21.11, it includes the following
> changes.
>
> 1. ci: Install python elftools for DPDK 21.02.
> 2. ci: Update meson requirement for DPDK 21.05.
> 3. netdev-dpdk: Fix build with 21.05.
> 4. ci: Compile DPDK in non developer mode.
>
>http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480=*
>
> 5. netdev-dpdk: Remove access to DPDK internals.
> 6. netdev-dpdk: Remove unused attribute from rte_flow rule.
> 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1.
> 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2.
>
>http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040=*
>
> In addition documentaion and DPDK unit tests were also updated in this
> commit for use with DPDK v21.11.
>
> For credit all authors of the original commits to 'dpdk-latest' with the above
> changes have been added as co-authors for this commit.
>
> Signed-off-by: David Marchand
> Co-authored-by: David Marchand
> Reviewed-by: Maxime Coquelin
> Signed-off-by: Ian Stokes
>
> ---
> RFC -> V1
> * Add telemetry warning to OVS DPDK unit tests.
> * Update TSO documentation link to 21.11.
> * Update fedora spec to use 21.11.
> ---
> .ci/linux-build.sh | 6 +-
> .ci/linux-prepare.sh | 4 +-
> Documentation/faq/releases.rst | 2 +-
> Documentation/intro/install/dpdk.rst | 16 +-
> Documentation/topics/dpdk/phy.rst| 8 +-
> Documentation/topics/dpdk/vdev.rst | 2 +-
> Documentation/topics/dpdk/vhost-user.rst | 2 +-
> Documentation/topics/testing.rst | 2 +-
> Documentation/topics/userspace-tso.rst | 2 +-
> NEWS | 1 +
> lib/dp-packet.h | 26 +-
> lib/netdev-dpdk.c| 115 +++
> rhel/openvswitch-fedora.spec | 515
> +++
You should update rhel/openvswitch-fedora.spec.in not the generated
rhel/openvswitch-fedora.spec.
> tests/system-dpdk.at | 16 +-
> 14 files changed, 624 insertions(+), 93 deletions(-)
> create mode 100644 rhel/openvswitch-fedora.spec
>
[snip]
> diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at
> index e0e750fde..d0f6ee394 100644
> --- a/tests/system-dpdk.at
> +++ b/tests/system-dpdk.at
> @@ -15,7 +15,8 @@ AT_CHECK([grep "DPDK Enabled - initialized"
> ovs-vswitchd.log], [], [stdout])
> OVS_VSWITCHD_STOP(["/Global register is changed during/d
> /EAL: Invalid NUMA socket, default to 0/d
> /EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable
> clock cycles !/d
> -/EAL: No free hugepages reported in hugepages-1048576kB/d"])
> +/EAL: No free hugepages reported in hugepages-1048576kB/d
> +/TELEMETRY: No legacy callbacks, legacy socket not created/d"])
> AT_CLEANUP
> dnl
> --
>
> @@ -37,12 +38,12 @@ sleep 2
>
> dnl Clean up
> AT_CHECK([ovs-vsctl del-port br10 phy0], [], [stdout], [stderr])
> -OVS_VSWITCHD_STOP("/does not exist. The Open vSwitch kernel module is
> probably not loaded./d
> +OVS_VSWITCHD_STOP(["/does not exist. The Open vSwitch kernel module is
> probably not loaded./d
> /Failed to enable flow control/d
> /Global register is changed during/d
> /EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable
> clock cycles !/d
> /EAL: No free hugepages reported in hugepages-1048576kB/d
> -")
> +/TELEMETRY: No legacy callbacks, legacy socket not created/d"])
This log is displayed when DPDK is compiled without libjansson (in
this case, the metrics library register no "legacy" callbacks, hence
the log..).
Ok for waiving it for now.
I'll submit a patch on DPDK side to lower it to INFO level because I
find it useless.
Rest lgtm.
Thanks Ian!
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK v21.11.
This commit adds support for DPDK v21.11, it includes the following changes. 1. ci: Install python elftools for DPDK 21.02. 2. ci: Update meson requirement for DPDK 21.05. 3. netdev-dpdk: Fix build with 21.05. 4. ci: Compile DPDK in non developer mode. http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480=* 5. netdev-dpdk: Remove access to DPDK internals. 6. netdev-dpdk: Remove unused attribute from rte_flow rule. 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1. 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2. http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040=* In addition documentaion and DPDK unit tests were also updated in this commit for use with DPDK v21.11. For credit all authors of the original commits to 'dpdk-latest' with the above changes have been added as co-authors for this commit. Signed-off-by: David Marchand Co-authored-by: David Marchand Reviewed-by: Maxime Coquelin Signed-off-by: Ian Stokes --- RFC -> V1 * Add telemetry warning to OVS DPDK unit tests. * Update TSO documentation link to 21.11. * Update fedora spec to use 21.11. --- .ci/linux-build.sh | 6 +- .ci/linux-prepare.sh | 4 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 16 +- Documentation/topics/dpdk/phy.rst| 8 +- Documentation/topics/dpdk/vdev.rst | 2 +- Documentation/topics/dpdk/vhost-user.rst | 2 +- Documentation/topics/testing.rst | 2 +- Documentation/topics/userspace-tso.rst | 2 +- NEWS | 1 + lib/dp-packet.h | 26 +- lib/netdev-dpdk.c| 115 +++ rhel/openvswitch-fedora.spec | 515 +++ tests/system-dpdk.at | 16 +- 14 files changed, 624 insertions(+), 93 deletions(-) create mode 100644 rhel/openvswitch-fedora.spec diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index 863f02388..ff6ae4b10 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -159,6 +159,10 @@ function install_dpdk() # Disable building DPDK unit tests. Not needed for OVS build or tests. DPDK_OPTS="$DPDK_OPTS -Dtests=false" +# Disable DPDK developer mode, this results in less build checks and less +# meson verbose outputs. +DPDK_OPTS="$DPDK_OPTS -Ddeveloper_mode=disabled" + # Install DPDK using prefix. DPDK_OPTS="$DPDK_OPTS --prefix=$(pwd)/build" @@ -216,7 +220,7 @@ fi if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then if [ -z "$DPDK_VER" ]; then -DPDK_VER="20.11.1" +DPDK_VER="21.11" fi install_dpdk $DPDK_VER if [ "$CC" = "clang" ]; then diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh index 360c0a68e..b3addf404 100755 --- a/.ci/linux-prepare.sh +++ b/.ci/linux-prepare.sh @@ -21,8 +21,8 @@ make -j4 HAVE_LLVM= HAVE_SQLITE= install cd .. pip3 install --disable-pip-version-check --user \ -flake8 hacking sphinx wheel setuptools -pip3 install --user 'meson==0.47.1' +flake8 hacking sphinx wheel setuptools pyelftools +pip3 install --user 'meson==0.49.2' if [ "$M32" ]; then # Installing 32-bit libraries. diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 64bc577e0..59d55202d 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@ -225,7 +225,7 @@ Q: Are all the DPDK releases that OVS versions work with maintained? The latest information about DPDK stable and LTS releases can be found at `DPDK stable`_. -.. _DPDK stable: http://doc.dpdk.org/guides-20.11/contributing/stable.html +.. _DPDK stable: http://doc.dpdk.org/guides-21.11/contributing/stable.html Q: I get an error like this when I configure Open vSwitch: diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst index d554409fc..d9f44055d 100644 --- a/Documentation/intro/install/dpdk.rst +++ b/Documentation/intro/install/dpdk.rst @@ -42,7 +42,7 @@ Build requirements In addition to the requirements described in :doc:`general`, building Open vSwitch with DPDK will require the following: -- DPDK 20.11.1 +- DPDK 21.11 - A `DPDK supported NIC`_ @@ -59,8 +59,8 @@ vSwitch with DPDK will require the following: Detailed system requirements can be found at `DPDK requirements`_. -.. _DPDK supported NIC: https://doc.dpdk.org/guides-20.11/nics/index.html -.. _DPDK requirements: https://doc.dpdk.org/guides-20.11/linux_gsg/sys_reqs.html +.. _DPDK supported NIC: https://doc.dpdk.org/guides-21.11/nics/index.html +.. _DPDK requirements: https://doc.dpdk.org/guides-21.11/linux_gsg/sys_reqs.html .. _dpdk-install: @@ -73,9 +73,9 @@ Install DPDK #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: $ cd /usr/src/ - $ wget https://fast.dpdk.org/rel/dpdk-20.11.1.tar.xz - $ tar xf dpdk-20.11.1.tar.xz - $
