[ovs-dev] ABI versioning (was Re: [PATCH] rhel: Support...)

>> > Should we bump the libtool version now? We're nearing a release, so >> > it's about the right time. >> >> Sorry for the late response. I think it's probably appropriate to bump >> at least the libtool 'age'. I'm not sure what kinds of ABI changes have >> happened since introduction

Re: [ovs-dev] [PATCH v5 1/3] netdev-dpdk: add hotplug support

On Thu, 2017-01-05 at 10:42 +, Ciara Loftus wrote: > From: Mauricio Vásquez > > In order to use dpdk ports in ovs they have to be bound to a DPDK > compatible driver before ovs is started. > > This patch adds the possibility to hotplug (or

Re: [ovs-dev] [PATCH v6] ovn-ctl: add support for SSL nb/sb db connections

On Tue, Jan 03, 2017 at 01:29:10PM -0500, Lance Richardson wrote: > Add support for SSL connections to OVN northbound and/or > southbound databases. Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] tunneling: Combining actions to avoid packet recirculation in tunnel encapsulation.

Hi Jarno, Thank you for looking into the path, Please find my answers inline blow. Regards _Sugesh > -Original Message- > From: Jarno Rajahalme [mailto:ja...@ovn.org] > Sent: Wednesday, January 4, 2017 12:00 AM > To: Chandran, Sugesh > Cc:

Re: [ovs-dev] Questions about implementation of meters in ovs

On Thu, Jan 05, 2017 at 08:15:06AM +, Hsu YuTing wrote: > As far as i know that currently meters is not available in latest > ovs release. Are there any alternative ways for experimenting the > meters in ovs? Does anyone know when meters will be officially > supported in ovs? Thanks!

Re: [ovs-dev] [PATCH 1/9] expr: Rename "macros" to "addr_sets".

On Wed, Jan 04, 2017 at 06:13:03PM -0800, Justin Pettit wrote: > Macro is a very generic term, but the arguments are only ever address > sets, so rename for clarity. > > Signed-off-by: Justin Pettit Still some hits for "macro": ovn/lib/expr.c:911:/* Adds a macro named 'name'

Re: [ovs-dev] [PATCH 2/9] ovn-controller: Expose address sets to the main loop.

On Wed, Jan 04, 2017 at 06:13:04PM -0800, Justin Pettit wrote: > Other functions in the main loop will need access to address sets in a > future commit. > > Signed-off-by: Justin Pettit I'd prefer to limit the actual scope of the data structure, because that makes it clear

Re: [ovs-dev] [PATCH 6/9] ofproto-macros: Quote "$@".

On Wed, Jan 04, 2017 at 06:13:08PM -0800, Justin Pettit wrote: > Quote "$@" so that arguments aren't split when being called. > > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list

Re: [ovs-dev] [PATCH 8/9] ovn-test: Add 'expr-to-packets' command.

On Wed, Jan 04, 2017 at 06:13:10PM -0800, Justin Pettit wrote: > Parses OVN expressions from stdin and prints out matching packets in > hexadecimal on stdout. > > Signed-off-by: Justin Pettit '\0' looks weird here, a flow is not a character string: struct flow uflow;

Re: [ovs-dev] [PATCH] python: Add TCP/SSL probes for OVSDB python lib

On Thu, Jan 05, 2017 at 09:58:11AM -0500, Russell Bryant wrote: > On Wed, Jan 4, 2017 at 6:41 PM, Ben Pfaff wrote: > > > On Sun, Jan 01, 2017 at 07:04:55PM +0800, Guoshuai Li wrote: > > > stream_or_pstream_needs_probes always return 0. This causes TCP/SSL > > > connection not be

Re: [ovs-dev] [PATCH 5/9] ovs-sim: Quote "$@".

On Wed, Jan 04, 2017 at 06:13:07PM -0800, Justin Pettit wrote: > Quote "$@" so that arguments aren't split when being called. > > Signed-off-by: Justin Pettit It must have been nightmarish finding this. Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH 4/9] flow: Fix small typo in comment describing flow_compose().

On Wed, Jan 04, 2017 at 06:13:06PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 7/9] ovn-controller: Introduce "inject-pkt" ovs-appctl command.

On Wed, Jan 04, 2017 at 06:13:09PM -0800, Justin Pettit wrote: > Add the ability to inject a packet into the connected Open vSwitch > instance. This is primarily useful for testing when a test requires > side-effects from an actual packet, so ovn-trace won't do. > > Signed-off-by: Justin Pettit

Re: [ovs-dev] [PATCH] doc: Use ovs theme

On Wed, 2017-01-04 at 10:32 -0800, Joe Stringer wrote: > On 4 January 2017 at 01:03, Stephen Finucane > wrote: > > On Tue, 2017-01-03 at 21:33 +, Stephen Finucane wrote: > > > The recently published 'ovs' theme [1] copies the styling of the > > > Open > > > vSwitch website.

Re: [ovs-dev] [PATCH] python: Add TCP/SSL probes for OVSDB python lib

On Wed, Jan 4, 2017 at 6:41 PM, Ben Pfaff wrote: > On Sun, Jan 01, 2017 at 07:04:55PM +0800, Guoshuai Li wrote: > > stream_or_pstream_needs_probes always return 0. This causes TCP/SSL > > connection not be probed, and no reconnect when the connection > > is aborted > > > >

Re: [ovs-dev] ovn support DPDK?

I'm glad to hear that. I have not heard reports before from OVN users who run it on DPDK, so it is good to know that it works. On Thu, Jan 05, 2017 at 04:35:00PM +0800, 赵占旭 wrote: > Thanks very much! > With your advice, I resolve the problem. > I thought ovn only support one bridge: br-int, now

Re: [ovs-dev] [PATCH] util: Remove obsolete comment.

On Thu, Jan 05, 2017 at 09:17:22AM +0100, Simon Horman wrote: > On Wed, Jan 04, 2017 at 09:23:54AM -0800, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > Acked-by: Simon Horman Thanks, applied. ___ dev

Re: [ovs-dev] [PATCH 3/9] ovn-controller: Remove "_p" from pointer arguments in lflow.c.

On Wed, Jan 04, 2017 at 06:13:05PM -0800, Justin Pettit wrote: > This more closely follows our coding standards. > > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH net-next] net: make ndo_get_stats64 a void function

The network device operation for reading statistics is only called in one place, and it ignores the return value. Having a structure return value is potentially confusing because some future driver could incorrectly assume that the return value was used. Fix all drivers with ndo_get_stats64 to

Re: [ovs-dev] [PATCH] Windows tests: Applications abort when using threading (ovs_rwlock_init)

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, January 4, 2017 7:21 PM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] Windows tests: Applications abort when > using threading

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

Ok, this makes sense now. Ive updated and tested the patch: From 93bc4c59b4eb814ed4bc3da3b7459498863add1e Mon Sep 17 00:00:00 2001 From: John Hurley Date: Thu, 5 Jan 2017 17:08:37 + Subject: [PATCH 1/1] ensure correct checksum when a packet is sent to NAT ---

Re: [ovs-dev] [PATCH net-next] net: make ndo_get_stats64 a void function

From: Stephen Hemminger Date: Thu, 5 Jan 2017 09:31:36 -0800 > The network device operation for reading statistics is only called > in one place, and it ignores the return value. Having a structure > return value is potentially confusing because some future driver

Re: [ovs-dev] [PATCH ovs V2 09/21] dpif-netlink: Dump netdevs flows on flow dump

On 25 December 2016 at 03:39, Paul Blakey wrote: > While dumping flows, dump flows that were offloaded to > netdev and parse them back to dpif flow. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > --- > lib/dpif-netlink.c |

Re: [ovs-dev] [PATCH ovs V2 20/21] netdev-linux: always add ingress qdisc

On 25 December 2016 at 03:39, Paul Blakey wrote: > flow offloading by tc needs ingress qdisc on the device. > Deleting the ingress qdisc was done in order to flush > policing filters, so instead we just flush the filter and > leave the ingress added (and add it if there wasn't

Re: [ovs-dev] [PATCH ovs V2 19/21] dpctl: read vswitch config on start

On 25 December 2016 at 03:39, Paul Blakey wrote: > Use Open vSwitch IDL pattern to read OVS configuration on dpctl start, > needed as some functionality is dependent on that configuration. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan

Re: [ovs-dev] [PATCH 9/9] ovn.at: Rewrite a test using ovn-controller 'inject-pkt' command.

> On Jan 5, 2017, at 7:48 AM, Ben Pfaff wrote: > > On Wed, Jan 04, 2017 at 06:13:11PM -0800, Justin Pettit wrote: >> Provide an example of using ovn-controller 'inject-pkt' and ovn-test >> 'expr-to-packets' commands to generate and verify proper handling of >> packets. Tests

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

John, This looks functionally OK, but could you repost this with the following changes: - Include a commit message explaining what was broken and how it is fixed. - Refer to the commit that introduced the deleted code with a "Fixes: (“Title”)” line. - Include a "Signed-off-by:” -line. > On

Re: [ovs-dev] [PATCH] tunneling: Combining actions to avoid packet recirculation in tunnel encapsulation.

> On Jan 5, 2017, at 6:57 AM, Chandran, Sugesh > wrote: > > Hi Jarno, > > Thank you for looking into the path, > Please find my answers inline blow. > > > Regards > _Sugesh > > >> -Original Message- >> From: Jarno Rajahalme [mailto:ja...@ovn.org] >>

[ovs-dev] [PATCH 2/2] ofctrl: Fix warning from sparse.

We've used sparse "bitwise" annotations to make ofp_ports into a different type, so this is required to avoid a sparse warning. CC: Justin Pettit Fixes: 714651c7db6a ("ovn-controller: Introduce "inject-pkt" ovs-appctl command.") Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH] python: Fix nroff indentation for XML .

On 5 January 2017 at 17:08, Ben Pfaff wrote: > On Thu, Jan 05, 2017 at 03:48:22PM -0800, Joe Stringer wrote: >> When XML is used for writing manpages, the nroff python utility indents >> the tags an extra level which is unnecessary and makes the >> formatting inconsistent between

[ovs-dev] [PATCH 1/5] ovs-ofctl: Document the "clone" action.

This was overlooked when "clone" was introduced. Fixes: 7ae62a676d3a ("ofp-actions: Add clone action.") Signed-off-by: Ben Pfaff --- NEWS | 1 + utilities/ovs-ofctl.8.in | 8 2 files changed, 9 insertions(+) diff --git a/NEWS b/NEWS index

[ovs-dev] [PATCH] xml2nroff: Port to python3.

Signed-off-by: Joe Stringer --- build-aux/xml2nroff | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/build-aux/xml2nroff b/build-aux/xml2nroff index df1df28d56cc..bd4e87928e4f 100755 --- a/build-aux/xml2nroff +++ b/build-aux/xml2nroff @@ -24,7

Re: [ovs-dev] Issues with the use of the clone action for resubmission to the pipeline

On Thu, Jan 5, 2017 at 4:28 PM, Ben Pfaff wrote: > On Tue, Jan 03, 2017 at 02:55:19AM -0800, Mickey Spiegel wrote: > > One of the motivations for clone is to use it as a lightweight way to > > resubmit to an earlier table at the beginning of the pipeline, without > > incurring all

Re: [ovs-dev] ovs-vswitch kernel panic randomly started after 400+ days uptime

Hey Joe, Thank you so much for responding! After 10 days of trying to figure this out I'm at a loss. root@node-8:~# modinfo openvswitch filename: /lib/modules/3.13.0-106-generic/kernel/net/openvswitch/openvswitch.ko license:GPL description:Open vSwitch switching datapath srcversion:

Re: [ovs-dev] [PATCH ovs V2 12/21] dpif-netlink: Use netdev flow put api to insert a flow

On 25 December 2016 at 03:39, Paul Blakey wrote: > Using the new netdev flow api operate will now try and > offload flows to the relevant netdev of the input port. > Other operate methods flows will come in later patches. > > Signed-off-by: Paul Blakey >

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

> On Jan 5, 2017, at 4:48 PM, Ben Pfaff wrote: > > On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: >> >>> On Jan 4, 2017, at 11:03 PM, Ben Pfaff wrote: >>> >>> On Wed, Jan 04, 2017 at 07:21:44PM -0800, Jarno Rajahalme wrote: > On Dec 21,

Re: [ovs-dev] [PATCH] docs: Fix formatting of patch comments line.

On 5 January 2017 at 01:28, Stephen Finucane wrote: > On Wed, 2017-01-04 at 13:58 -0800, Joe Stringer wrote: >> Sphinx was formatting the `---` as an extended dash, not verbatim as >> three hyphens (which is what is necessary for git to determine that >> it's >> a comment, and

Re: [ovs-dev] [PATCHv2] ovs-ofctl.8: Document automatic helper assignment.

On 3 January 2017 at 11:41, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] xlate: Recirculate also when MPLS POP is implicit.

'ctx->was_mpls' is used to flag when an MPLS packet has been popped to a non-MPLS packet, but it was not set when the MPLS POP is implicit due to the 'ctx->xin->flow' being restored after a patch port traversal to group bucket execution. If MPLS push on a non-MPLS packet is followed by an MPLS

Re: [ovs-dev] [PATCH 1/5] ovs-ofctl: Document the "clone" action.

On Thu, Jan 5, 2017 at 4:28 PM, Ben Pfaff wrote: > This was overlooked when "clone" was introduced. > > Fixes: 7ae62a676d3a ("ofp-actions: Add clone action.") > Signed-off-by: Ben Pfaff > Acked-by: Mickey Spiegel

[ovs-dev] [PATCH] python: Add TCP/SSL probes for OVSDB python lib

stream_or_pstream_needs_probes always return 0. This causes TCP/SSL connection not be probed, and no reconnect when the connection is aborted Signed-off-by: Guoshuai Li --- python/ovs/stream.py | 32 +++- 1 file changed, 23 insertions(+), 9

Re: [ovs-dev] [PATCH v2] dpcls: Avoid one 8-byte chunk in subtable mask.

> On Jan 5, 2017, at 1:03 AM, antonio.fische...@intel.com wrote: > > This patch allows to skip the chunk comprising of dp_hash and in_port > in the subtable mask when the packet is not recirculated. This will > slightly speed up the hash computation as one expensive function call > to

[ovs-dev] [PATCH 5/5] New action "ct_clear".

This is being introduced specifically to allow a user of the "clone" action to clear the connection tracking state, but it's implemented as a separate action as a matter of clean design and in case another use case arises later. Reported-by: Mickey Spiegel Reported-at:

[ovs-dev] [PATCH 4/5] ofproto-dpif-xlate: Make clone save "was_mpls".

This seems like it's an optimization rather than a correctness issue, but in general it's best to make "clone" like patch ports where there is no reason to depart from its design, since we know that patch ports work well. Reported-by: Mickey Spiegel Reported-at:

[ovs-dev] ovs-vswitch kernel panic randomly started after 400+ days uptime

Hi, Since about 10 days ago, every few hours, one of our 10 compute nodes on our Openstack cluster kernel panics at the host level kernel panics (captured through netconsole). The kernel panic is identical across all 10 nodes and happens at random times but at least 1 node kernel panics every

Re: [ovs-dev] Issues with the use of the clone action for resubmission to the pipeline

> On Jan 5, 2017, at 4:28 PM, Ben Pfaff wrote: > > On Tue, Jan 03, 2017 at 02:55:19AM -0800, Mickey Spiegel wrote: >> One of the motivations for clone is to use it as a lightweight way to >> resubmit to an earlier table at the beginning of the pipeline, without >> incurring all of

[ovs-dev] [PATCHv2] python: Fix nroff indentation for after .

When XML is used for writing manpages, in the case that there is a tag followed by , the nroff python utility indents the tag (and children) an extra level which is unnecessary and makes the formatting inconsistent between manpages written directly in nroff vs manpages written in XML and

Re: [ovs-dev] [PATCH 3/5] ofproto-dpif-xlate: Make "clone" save action set and stack.

On Thu, Jan 5, 2017 at 4:28 PM, Ben Pfaff wrote: > This is a design decision but it seems conceptually cleaner than having > them leak through into the clone. > I agree that saving and restoring is a good thing. Whether to clear, as Jarno brought up, that is a good question. I

Re: [ovs-dev] [PATCH] python: Add TCP/SSL probes for OVSDB python lib

On Thu, Jan 05, 2017 at 09:58:11AM -0500, Russell Bryant wrote: On Wed, Jan 4, 2017 at 6:41 PM, Ben Pfaff wrote: On Sun, Jan 01, 2017 at 07:04:55PM +0800, Guoshuai Li wrote: stream_or_pstream_needs_probes always return 0. This causes TCP/SSL connection not be probed, and no

Re: [ovs-dev] [PATCH] ovn: Support ARP proxy in logical switches.

On Wed, Jan 4, 2017 at 3:29 PM, Ben Pfaff wrote: > > [adding Bruce to leverage his knowledge of networking, if he's willing] Thanks! It would be great to get some views from networking experts. > > It seems like the mechanics of this patch are mostly OK. There is at > least one

[ovs-dev] [PATCH v2] dpcls: Avoid one 8-byte chunk in subtable mask.

This patch allows to skip the chunk comprising of dp_hash and in_port in the subtable mask when the packet is not recirculated. This will slightly speed up the hash computation as one expensive function call to hash_add64() can be skipped. For each new netdev flow we wildcard in_port in the mask,

Re: [ovs-dev] [PATCH] dpcls: Avoid one 8-byte chunk in subtable mask.

Thanks Jarno, will create a v2. Antonio > -Original Message- > From: Jarno Rajahalme [mailto:ja...@ovn.org] > Sent: Wednesday, January 4, 2017 9:43 PM > To: Fischetti, Antonio > Cc: d...@openvswitch.org; Bodireddy, Bhanuprakash >

Re: [ovs-dev] ovn support DPDK?

Thanks very much! With your advice, I resolve the problem. I thought ovn only support one bridge: br-int, now I add one. At 2017-01-05 01:44:26, "Ben Pfaff" wrote: >On Tue, Jan 03, 2017 at 05:25:26PM +0800, 赵占旭 wrote: >> I installed ovn and ovs-dpdk. when I created two VMs

Re: [ovs-dev] [PATCH] util: Remove obsolete comment.

On Wed, Jan 04, 2017 at 09:23:54AM -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Simon Horman > --- > include/openvswitch/util.h | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH] docs: Fix formatting of patch comments line.

On Wed, 2017-01-04 at 13:58 -0800, Joe Stringer wrote: > Sphinx was formatting the `---` as an extended dash, not verbatim as > three hyphens (which is what is necessary for git to determine that > it's > a comment, and ignore it when applying the patch). > > Signed-off-by: Joe Stringer

[ovs-dev] Questions about implementation of meters in ovs

Hello All, As far as i know that currently meters is not available in latest ovs release. Are there any alternative ways for experimenting the meters in ovs? Does anyone know when meters will be officially supported in ovs? Thanks! Best Regards , YT Hsu

[ovs-dev] [PATCH v5 1/3] netdev-dpdk: add hotplug support

From: Mauricio Vásquez In order to use dpdk ports in ovs they have to be bound to a DPDK compatible driver before ovs is started. This patch adds the possibility to hotplug (or hot-unplug) a device after ovs has been started. The implementation adds

[ovs-dev] [PATCH v5 3/3] netdev-dpdk: Add support for virtual DPDK PMDs (vdevs)

Prior to this commit, the 'dpdk' port type could only be used for physical DPDK devices. Now, virtual devices (or 'vdevs') are supported. 'vdev' devices are those which use virtual DPDK Poll Mode Drivers eg. null, pcap. To add a DPDK vdev, a valid 'dpdk-devargs' must be set for the given dpdk

[ovs-dev] [PATCH v5 2/3] netdev-dpdk: Arbitrary 'dpdk' port naming

'dpdk' ports no longer have naming restrictions. Now, instead of specifying the dpdk port ID as part of the name, the PCI address of the device must be specified via the 'dpdk-devargs' option. eg. ovs-vsctl add-port br0 my-port ovs-vsctl set Interface my-port type=dpdk

[ovs-dev] [PATCH v6 1/7] ovn: specify addresses of type "router" lsps as "router"

Currently in OVN, when a logical switch port of type "router" is created, the MAC and optionally IP addresses of the peer logical router port must be specified again as the addresses of the logical switch port. This patch allows the logical switch port's addresses to be specified as the string

[ovs-dev] [PATCH v6 3/7] ovn: Introduce "chassisredirect" port binding

Currently OVN handles all logical router ports in a distributed manner, creating instances on each chassis. The logical router ingress and egress pipelines are traversed locally on the source chassis. In order to support advanced features such as one-to-many NAT (aka IP masquerading), where

[ovs-dev] [PATCH v6 0/7] ovn: add distributed NAT capability

Currently OVN supports NAT functionality by connecting each distributed logical router to a centralized "l3gateway" router that resides on a single chassis. NAT is only carried out in the "l3gateway" router. This patch set introduces NAT capability in the distributed logical router itself,

[ovs-dev] [PATCH v6 2/7] ovn: add is_chassis_resident match expression component

This patch introduces a new match expression component is_chassis_resident(). Unlike match expression comparisons, is_chassis_resident is not pushed down to OpenFlow. It is a conditional that is evaluated in the controller during expr_simplify(), when it is replaced by a boolean expression. The

[ovs-dev] [PATCH v6 6/7] ovn: avoid snat recirc only on gateway routers

Currently, for performance reasons on gateway routers, ct_snat that does not specify an IP address does not immediately trigger recirculation. On gateway routers, ct_snat that does not specify an IP address happens in the UNSNAT pipeline stage, which is followed by the DNAT pipeline stage that

Re: [ovs-dev] *** SPAM *** [PATCH v4 2/3] netdev-dpdk: Arbitrary 'dpdk' port naming

On 01/05/2017 12:23 AM, Daniele Di Proietto wrote: > 2017-01-04 7:31 GMT-08:00 Ciara Loftus : >> > 'dpdk' ports no longer have naming restrictions. Now, instead of >> > specifying the dpdk port ID as part of the name, the PCI address of the >> > device must be specified via

[ovs-dev] how ovn-controller translates lflow into openflow?

hi, all: is it a big question? ^_^. i am viewing the source code, a little difficult. could you explain the logic behind? thanks very much. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Auditoría - 12 Temas Inéditos

12 conferencias pregrabadas / Durante 3 meses Póliza indispensable para los responsables de AUDITORíA Y CONTROL INTERNO 12 conferencias en cada póliza, pregrabadas, inéditas, para capacitar a todo su personal Ponemos a su alcance y por tiempo limitado, una exclusiva Póliza de

Re: [ovs-dev] [PATCH 1/5] ovs-ofctl: Document the "clone" action.

On Thu, Jan 05, 2017 at 06:33:53PM -0800, Mickey Spiegel wrote: > On Thu, Jan 5, 2017 at 4:28 PM, Ben Pfaff wrote: > > > This was overlooked when "clone" was introduced. > > > > Fixes: 7ae62a676d3a ("ofp-actions: Add clone action.") > > Signed-off-by: Ben Pfaff > > >

Re: [ovs-dev] [PATCH 2/2] ofctrl: Fix warning from sparse.

On Thu, Jan 05, 2017 at 07:15:07PM -0800, Justin Pettit wrote: > > > On Jan 5, 2017, at 5:03 PM, Ben Pfaff wrote: > > > > We've used sparse "bitwise" annotations to make ofp_ports into a different > > type, so this is required to avoid a sparse warning. > > > > CC: Justin Pettit

Re: [ovs-dev] [PATCH 5/5] New action "ct_clear".

On Thu, Jan 05, 2017 at 07:19:21PM -0800, Mickey Spiegel wrote: > On Thu, Jan 5, 2017 at 4:28 PM, Ben Pfaff wrote: > > > This is being introduced specifically to allow a user of the "clone" action > > to clear the connection tracking state, but it's implemented as a separate > >

Re: [ovs-dev] [PATCH] python: Add TCP/SSL probes for OVSDB python lib

On Fri, Jan 06, 2017 at 11:25:36AM +0800, Guoshuai Li wrote: > stream_or_pstream_needs_probes always return 0. This causes TCP/SSL > connection not be probed, and no reconnect when the connection > is aborted > > Signed-off-by: Guoshuai Li Thanks, applied to branch-2.6.

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

On Thu, Jan 05, 2017 at 05:45:29PM -0800, Jarno Rajahalme wrote: > > > On Jan 5, 2017, at 4:48 PM, Ben Pfaff wrote: > > > > On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: > >> > >>> On Jan 4, 2017, at 11:03 PM, Ben Pfaff wrote: > >>> > >>> On

Re: [ovs-dev] [PATCH v5 2/3] netdev-dpdk: Arbitrary 'dpdk' port naming

If new_port_id == -1 I think it's better to return failure from set_config(), rather than return failure from a later reconfigure(), so I squashed the following incremental: diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index e66ff2711..038f79b80 100644 --- a/lib/netdev-dpdk.c +++

Re: [ovs-dev] [PATCH v5 3/3] netdev-dpdk: Add support for virtual DPDK PMDs (vdevs)

2017-01-05 2:42 GMT-08:00 Ciara Loftus : > Prior to this commit, the 'dpdk' port type could only be used for > physical DPDK devices. Now, virtual devices (or 'vdevs') are supported. > 'vdev' devices are those which use virtual DPDK Poll Mode Drivers eg. > null, pcap. To

Re: [ovs-dev] [PATCHv2] python: Fix nroff indentation for after .

On Thu, Jan 05, 2017 at 06:09:35PM -0800, Joe Stringer wrote: > When XML is used for writing manpages, in the case that there is a > tag followed by , the nroff python utility indents the tag (and > children) an extra level which is unnecessary and makes the formatting > inconsistent between

[ovs-dev] [PATCH v2 1/4] ofproto-dpif-xlate: Make "clone" save action set and stack.

This is a design decision but it seems conceptually cleaner than having them leak through into the clone. Reported-by: Mickey Spiegel Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-January/326981.html Fixes: 7ae62a676d3a ("ofp-actions: Add clone

Re: [ovs-dev] [PATCH 2/5] ofproto-dpif-xlate: Make clone save whether conntracking has occurred.

On Thu, Jan 05, 2017 at 06:40:09PM -0800, Mickey Spiegel wrote: > On Thu, Jan 5, 2017 at 4:28 PM, Ben Pfaff wrote: > > > The rest of the conntrack state (in the flow) is saved and restored, so > > this should be also. > > > > Reported-by: Mickey Spiegel > >

Re: [ovs-dev] [PATCH] xml2nroff: Port to python3.

On Thu, Jan 05, 2017 at 06:01:08PM -0800, Joe Stringer wrote: > Signed-off-by: Joe Stringer Works for me. Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] Issues with the use of the clone action for resubmission to the pipeline

On Thu, Jan 05, 2017 at 05:54:46PM -0800, Jarno Rajahalme wrote: > > > On Jan 5, 2017, at 4:28 PM, Ben Pfaff wrote: > > > > On Tue, Jan 03, 2017 at 02:55:19AM -0800, Mickey Spiegel wrote: > >> One of the motivations for clone is to use it as a lightweight way to > >> resubmit to

Re: [ovs-dev] *** SPAM *** [PATCH 1/2] ofctrl: Fix version check in ofctrl_inject_packet().

On Thu, Jan 05, 2017 at 07:13:53PM -0800, Justin Pettit wrote: > > > On Jan 5, 2017, at 5:03 PM, Ben Pfaff wrote: > > > > "enum ofp_version" is unsigned in the System V ABI used by Linux, so > > it will never be less than 0, so an rconn with an unnegotiated version will > > never

[ovs-dev] [PATCH v2 3/4] New action "ct_clear".

This is being introduced specifically to allow a user of the "clone" action to clear the connection tracking state, but it's implemented as a separate action as a matter of clean design and in case another use case arises later. Reported-by: Mickey Spiegel Reported-at:

[ovs-dev] [PATCH v2 2/4] ofproto-dpif-xlate: Make clone save "was_mpls".

This seems like it's an optimization rather than a correctness issue, but in general it's best to make "clone" like patch ports where there is no reason to depart from its design, since we know that patch ports work well. Reported-by: Mickey Spiegel Reported-at:

[ovs-dev] [PATCH v2 4/4] ovn-controller: Clear conntrack state inside clone action.

ovn-controller implements traversal from one OVN logical network to another using the Open vSwitch "clone" action. The "clone" action preserves connection tracking state, which is confusing for passing from one logical datapath to another because this state is only relevant for a single logical

Re: [ovs-dev] [PATCH ovs V2 12/21] dpif-netlink: Use netdev flow put api to insert a flow

On 25 December 2016 at 03:39, Paul Blakey wrote: > Using the new netdev flow api operate will now try and > offload flows to the relevant netdev of the input port. > Other operate methods flows will come in later patches. > > Signed-off-by: Paul Blakey >

[ovs-dev] [PATCH] python: Fix nroff indentation for XML .

When XML is used for writing manpages, the nroff python utility indents the tags an extra level which is unnecessary and makes the formatting inconsistent between manpages written directly in nroff vs manpages written in XML and converted to nroff. Fix the indentation by removing the extraneous

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

> On Jan 4, 2017, at 11:03 PM, Ben Pfaff wrote: > > On Wed, Jan 04, 2017 at 07:21:44PM -0800, Jarno Rajahalme wrote: >> >>> On Dec 21, 2016, at 2:36 PM, Ben Pfaff wrote: >>> >>> On Wed, Dec 07, 2016 at 04:49:00PM -0800, Jarno Rajahalme wrote: Always storing

Re: [ovs-dev] ovs-vswitch kernel panic randomly started after 400+ days uptime

On 5 January 2017 at 17:13, Uri Foox wrote: > Hi, > > Since about 10 days ago, every few hours, one of our 10 compute nodes on > our Openstack cluster kernel panics at the host level kernel panics > (captured through netconsole). The kernel panic is identical across all 10 > nodes

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif: Unhide structure contents.

> On Dec 22, 2016, at 9:58 AM, Ben Pfaff wrote: > > Until now, ofproto-dpif.c has hidden the definitions of several structures, > such as struct ofproto_dpif and struct rule_dpif. This kind of information > hiding is often beneficial, because it forces code outside the file with

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: > > > On Jan 4, 2017, at 11:03 PM, Ben Pfaff wrote: > > > > On Wed, Jan 04, 2017 at 07:21:44PM -0800, Jarno Rajahalme wrote: > >> > >>> On Dec 21, 2016, at 2:36 PM, Ben Pfaff wrote: > >>> > >>> On

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

I sent a patch to do this fix on OVS master. IMO we should also make the datapath more flexible so that it would be able to POP back to IP after PUSH actions on an IP packet in the same action list. But that will not make it to OVS 2.7. I would appreciate if Thomas could apply the and test!

Re: [ovs-dev] [PATCH 2/2] ofctrl: Fix warning from sparse.

> On Jan 5, 2017, at 5:03 PM, Ben Pfaff wrote: > > We've used sparse "bitwise" annotations to make ofp_ports into a different > type, so this is required to avoid a sparse warning. > > CC: Justin Pettit > Fixes: 714651c7db6a ("ovn-controller: Introduce

[ovs-dev] [PATCH] ovn-nbctl: Specify the range of the tag for "ovn-nbctl lsp-add" command.

When configuring the wrong tag for "ovn-nbctl lsp-add" command， it shows "invalid tag". The range of the tag is not known. Signed-off-by: zhaojingjing --- ovn/utilities/ovn-nbctl.8.xml | 4 +++- ovn/utilities/ovn-nbctl.c | 2 +- 2 files changed, 4 insertions(+), 2

[ovs-dev] [PATCH] ovn-nbctl:The range of "PRIORITY" for "ovn-nbctl acl-add " command is wrong.

The range of "PRIORITY" for "ovn-nbctl acl-add " command is 1 to 65534 in ovn-nbctl.8.xml",When configuring this command, it indicates that " priority must in range 0...32767".The range of priority is inconsistent in "ovn-nbctl.8.xml" and "ovn-nbctl.c". Signed-off-by: zhaojingjing

Re: [ovs-dev] [PATCH] ovsdb-data: Add support for integer ranges in database commands

On Thu, Dec 29, 2016 at 03:55:46PM -0700, Lukasz Rzasik wrote: > Adding / removing a range of integers to a column accepting a set of > integers requires enumarating all of the integers. This patch simplifies > it by introducing 'range' concept to the database commands. Two integers > separated by

Re: [ovs-dev] ABI versioning (was Re: [PATCH] rhel: Support...)

On Thu, Jan 05, 2017 at 10:52:00AM -0500, Aaron Conole wrote: > I'm uncomfortable with bumping this and just 'let the chips fall where > they may,' since having a version that hasn't changed is the virtually > the same as not having a version. The instant we bump, we state that > the version