Re: [ovs-dev] [PATCH v3] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

On Mon, Jul 17, 2017 at 02:39:57AM +, Zhenyu Gao wrote: > Sendmmsg can reduce cpu cycles in sending packets to kernel. > Replace sendmsg with sendmmsg in function netdev_linux_send to send > batch packets if sendmmsg is available. Thanks for the patch. I like the idea but I found the details

Re: [ovs-dev] [PATCH v2 0/6] Generic Encap & Decap based NSH implementation

On Thu, Aug 03, 2017 at 04:56:51AM +0800, Yi Yang wrote: > v1->v2 > - Rebase to current master > - Fix comments By Joe and Jiri Benc I took a very quick first pass on this series, really just applying and building them. Can you fix them up for a v3? Thanks, Ben.

[ovs-dev] [PATCH v3 6/6] NSH unit test cases using encap and decap actions

From: Jan Scheurich With the support of generic encap and decap actions for Ethernet and NSH it is now possible to build test cases that mimic realistic OVS configurations and OF pipelines for Service Function Chaining. Packets are being encapsulated in NSH, forwarded

[ovs-dev] [PATCH v3 5/6] Generic encap and decap support for NSH

From: Jan Scheurich This commit adds translation and netdev datapath support for generic encap and decap actions for the NSH MD1 header. The generic encap and decap actions are mapped to specific encap_nsh and decap_nsh actions in the datapath. The translation

Re: [ovs-dev] [PATCH v2 0/6] Generic Encap & Decap based NSH implementation

Hi, Ben I have fixed all the errors and warnings reported by checkpatch as well as a comment you mentioned and posted out v3, please use the new one for review or merge. -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Thursday, August 3, 2017 6:40 AM To: Yang, Yi Y

Re: [ovs-dev] [PATCH v2 1/6] userspace: Add support for NSH MD1 match fields

On Thu, Aug 03, 2017 at 04:56:52AM +0800, Yi Yang wrote: > From: Jan Scheurich > > This patch adds support for NSH packet header fields to the OVS > control plane and the userspace datapath. Initially we support the > fields of the NSH base header as defined in >

[ovs-dev] Multiple ARP cache entries for one same dest IP?

Hello, In OVS userspace implementation(See below), looks like, given a dest IP, multiple ARP entries are allowed as long as bridge-names are different for the same dest IP. But, is there real scenario where multiple ARP entries for the same dest IP (because of different bridge-name)? int

Re: [ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

On Wed, Aug 02, 2017 at 05:25:36PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Tue, Aug 01, 2017 at 06:05:40PM -0400, Aaron Conole wrote: > >> When intermediary files are generated, the destination directory is assumed > >> to exist. This has worked so far because most

[ovs-dev] [PATCH v3 1/6] userspace: Add support for NSH MD1 match fields

From: Jan Scheurich This patch adds support for NSH packet header fields to the OVS control plane and the userspace datapath. Initially we support the fields of the NSH base header as defined in https://www.ietf.org/id/draft-ietf-sfc-nsh-13.txt and the fixed context

[ovs-dev] [PATCH v3 2/6] userspace: enable set_field support for nsh fields

From: Jan Scheurich Signed-off-by: Yi Yang Signed-off-by: Jan Scheurich --- lib/odp-execute.c | 66 +++ lib/odp-util.c| 33 2 files

Re: [ovs-dev] [PATCH 1/2] bond: Fix broken rebalancing after link state changes.

On Thu, Jul 20, 2017 at 10:21 AM, Ilya Maximets wrote: > There are 3 constraints for moving hashes from one slave to another: > > 1. The load difference is larger than ~3% of one slave's load. > 2. The load difference between slaves exceeds 10 bytes. >

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Eliminate duplicate read of xcfgp.

On Wed, Aug 2, 2017 at 8:56 AM, Ben Pfaff wrote: > This inner 'xcfg' shadowed the outer one and could have read a different > value if 'xcfgp' was changing, so this is possibly a bug fix. > > Found by -Wshadow=local in GCC 7. > > Signed-off-by: Ben Pfaff Acked-by:

Re: [ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

Ben Pfaff writes: > On Tue, Aug 01, 2017 at 06:05:40PM -0400, Aaron Conole wrote: >> When intermediary files are generated, the destination directory is assumed >> to exist. This has worked so far because most files are built prior to >> the dist-packaging step. However, any

Re: [ovs-dev] [PATCH v3] ofproto-dpif-ipfix: add support for per-flow drop counters

On Fri, Jul 28, 2017 at 07:17:44AM +0100, Przemyslaw Szczerbik wrote: > Patch based on RFC 5102, section 5.10. It implements per-flow drop counters: > - droppedPacketDeltaCount > - droppedPacketTotalCount > - droppedOctetDeltaCount > - droppedOctetTotalCount > > In order to determine if packet is

[ovs-dev] [PATCH v3 0/6] Generic Encap & Decap based NSH implementation

v2->v3 - Rebase to current master - Fix warnings reported by checkpatch - Correct commit log with right encap syntax v1->v2 - Rebase to current master - Fix comments By Joe and Jiri Benc This patch series implemented NSH (Network Service Header,

Re: [ovs-dev] [PATCH v3] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

It looks better to this independent function netdev_linux_tap_batch_send. Thanks for working on it. Thanks Zhenyu Gao 2017-08-03 5:59 GMT+08:00 Ben Pfaff : > On Mon, Jul 17, 2017 at 02:39:57AM +, Zhenyu Gao wrote: > > Sendmmsg can reduce cpu cycles in sending packets to

Re: [ovs-dev] [PATCH v2 2/6] userspace: enable set_field support for nsh fields

On Thu, Aug 03, 2017 at 04:56:53AM +0800, Yi Yang wrote: > From: Jan Scheurich > > Signed-off-by: Yi Yang > Signed-off-by: Jan Scheurich There's one checkpatch warning, will you take a look? WARNING: Line length

[ovs-dev] [PATCH v3 3/6] Adding nsh.at for NSH unit tests

From: Jan Scheurich First basic NSH test case implemented and working. Unconditionally show matched packet_type in megaflows, even when matching on eth. Signed-off-by: Jan Scheurich --- lib/match.c | 6 --

[ovs-dev] [PATCH v3 4/6] userspace: add NSH support to vxlan-gpe tunnels

From: Jan Scheurich Signed-off-by: Yi Yang Signed-off-by: Jan Scheurich --- lib/netdev-native-tnl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c index

[ovs-dev] [PATCH 2/2] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

From: Zhenyu Gao Sendmmsg can reduce cpu cycles in sending packets to kernel. Replace sendmsg with sendmmsg in function netdev_linux_send to send batch packets if sendmmsg is available. If kernel side doesn't support sendmmsg, will fallback to sendmsg. netserver

Re: [ovs-dev] incorrect revalidated action for igmp

Thanks for verifying the fix. I applied this to master. I think you're right that there's a remaining mismatch here. If you have time to figure out a full and proper solution, then please do so; I'd appreciate it. On Sat, Jul 15, 2017 at 11:11:40AM +0800, Huanle Han wrote: > This patch can

[ovs-dev] 答复: Re: [PATCH 1/2] ovn-controller: fix vlan_trunk bug

ok Ben Pfaff 2017/08/03 04:38 收件人：wang.qia...@zte.com.cn, 抄送： d...@openvswitch.org 主题： Re: [ovs-dev] [PATCH 1/2] ovn-controller: fix vlan_trunk bug On Fri, Jul 14, 2017 at 10:24:17AM +0800, wang.qia...@zte.com.cn wrote: > The bug

Re: [ovs-dev] [PATCH v2] datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

On Mon, Jul 24, 2017 at 03:31:38PM -0700, Shashank Ram wrote: > Previously, the function would take the curNbl and nextNbl > as inputs, and modify the linked list, and merge the input > linked list with the newly generated newNbl list. > > This is confusing for the caller, and the function has >

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

On Thu, Jul 13, 2017 at 11:44:51PM -0700, Han Zhou wrote: > This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. > > The commit introduced a problem that "File exists" will be reported > when trying to open br0. Earlier today I applied Eelco's additional fix (appended below). I hope

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Fix key attr iteration.

On 07/31/2017 04:54 PM, Joe Stringer wrote: This call is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across these

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

On 07/31/2017 04:54 PM, Joe Stringer wrote: This calls is operating on messages generated by the datapath. If a s/calls/call datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating

Re: [ovs-dev] Multiple ARP cache entries for one same dest IP?

On Wed, Aug 2, 2017 at 3:51 PM, Joo Kim wrote: > Hello, > > In OVS userspace implementation(See below), looks like, given a dest IP, > multiple ARP entries are allowed as long as bridge-names are different for > the same dest IP. > But, is there real scenario where multiple

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

On Fri, Jul 14, 2017 at 04:40:51AM +, Alin Serdean wrote: > The following patches are fixes found with the WDK 8.1 and 10 > static code analysis. I applied most of this series to master. The patches that I didn't apply are the ones where Shashank had some requests. (Alin, you should be able

[ovs-dev] [PATCH v2 4/6] userspace: add NSH support to vxlan-gpe tunnels

From: Jan Scheurich Signed-off-by: Yi Yang Signed-off-by: Jan Scheurich --- lib/netdev-native-tnl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c index

Re: [ovs-dev] [PATCH v5 0/2] basic encap/decap

Thanks for all the revisions! I applied these patches to master. On Wed, Aug 02, 2017 at 04:04:11PM +0800, Yi Yang wrote: > This series is a continuation of other patch series initiated by Jan Scheurich > before. > > The main purpose of this series is to add support for the OpenFlow actions >

[ovs-dev] [PATCH] rhel: Use systemd Restart option for ovn-controllers.

This change stops the use of OVS's monitor for the ovn-controller and ovn-controller-vtep systemd services. Instead, the services use the systemd Restart option to restart the services automatically if they fail. This patch changes the ovn-controller service Type from "oneshot" to "forking". The

[ovs-dev] [PATCH v2 1/6] userspace: Add support for NSH MD1 match fields

From: Jan Scheurich This patch adds support for NSH packet header fields to the OVS control plane and the userspace datapath. Initially we support the fields of the NSH base header as defined in https://www.ietf.org/id/draft-ietf-sfc-nsh-13.txt and the fixed context

Re: [ovs-dev] [PATCH 1/1] netdev: Fix netdev_open() to track and recreate classless interfaces

On Fri, Jul 14, 2017 at 02:33:27PM +0200, Eelco Chaudron wrote: > Due to commit 67ac844 an existing issue with OVS persisten ports > surfaced. If we revert the commit we no longer get the error, and > basic traffic will flow. However the wrong netdev class is used, hence > the wrong callbacks get

Re: [ovs-dev] [PATCH] rhel: Use systemd Restart option for ovn-controllers.

> From: "Mark Michelson" > To: d...@openvswitch.org > Sent: Wednesday, 2 August, 2017 2:43:04 PM > Subject: [ovs-dev] [PATCH] rhel: Use systemd Restart option for > ovn-controllers. > > This change stops the use of OVS's monitor for the ovn-controller and >

Re: [ovs-dev] [PATCH] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Thanks for the revision. I have some more comments. On Mon, Jun 19, 2017 at 01:14:40PM +0530, SatyaValli wrote: > commit 49a3592b2878a33033e5fd2e6e5ce82ebccef780 > Author: Satya Valli > Co-authored-by: Lavanya Harivelam > Co-authored-by:

Re: [ovs-dev] [PATCH] hash: Add "fall through" annotations for 32-bit builds as well.

On Wed, Aug 02, 2017 at 01:55:35PM -0700, Andy Zhou wrote: > On Wed, Aug 2, 2017 at 1:34 PM, Ben Pfaff wrote: > > This still needs a review. > > > > On Thu, Jul 13, 2017 at 10:15:42AM -0700, Ben Pfaff wrote: > >> Commit 73c7216a5329 ("Fix some -Wimplicit-fallthrough warnings

Re: [ovs-dev] [PATCH 2/2] Eliminate most shadowing for local variable names.

On Wed, Aug 2, 2017 at 8:56 AM, Ben Pfaff wrote: > Shadowing is when a variable with a given name in an inner scope hides a > different variable with the same name in a surrounding scope. This is > generally undesirable because it can confuse programmers. This commit > eliminates

Re: [ovs-dev] [PATCH] bridge: Avoid read of uninitialized data configuring Auto-Attach.

This still needs a (trivial) review. On Thu, Jul 06, 2017 at 02:33:42PM -0700, Ben Pfaff wrote: > Reported-by: "qintao (F)" > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2017-April/044309.html > Signed-off-by: Ben Pfaff > --- >

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

This bug fix still needs a review. Also, Kevin, if you can verify that it fixes the behavior you see, that would also be helpful. On Thu, Jul 06, 2017 at 04:40:30PM -0700, Ben Pfaff wrote: > The ovs-ofctl "diff-flows" and "replace-flows" command compare the flows > in two flow tables. Until

[ovs-dev] CORRECT QUOTATION

Dear Sir, Please find attached our corrected quotation after discussion with our end buyer customers. Await your response soon Best regards, Khatri KONG HING AGENCY LTD. Shenzhen Office: Room 1408, Cosco Tower, Room 1717-1719, 17 / F Kerry Center, Unit 3304, North Tower, World Trade

Re: [ovs-dev] [PATCH v2 0/4] Output packet batching.

Hi Bhanuprakash, Thanks for testing. Comments inline. Best regards, Ilya Maximets. On 01.08.2017 18:33, Bodireddy, Bhanuprakash wrote: >> This patch-set inspired by [1] from Bhanuprakash Bodireddy. >> Implementation of [1] looks very complex and introduces many pitfalls for >> later code

Re: [ovs-dev] [PATCH RFC v2 4/4] dpif-netdev: Time based output batching.

On 01.08.2017 18:45, Bodireddy, Bhanuprakash wrote: >>On 28.07.2017 10:20, Darrell Ball wrote: >>> I have not tested yet >>> >>> However, I would have expected something max latency config. to be >> specific to netdev-dpdk port types >> >>IMHO, if we can make it generic, we

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix false errors on interfaces without tunnel config

On Tue, Aug 01, 2017 at 04:48:02PM -0700, Joe Stringer wrote: > On 1 August 2017 at 13:57, Joe Stringer wrote: > > On 28 July 2017 at 05:43, Simon Horman wrote: > >> On Thu, Jul 27, 2017 at 02:40:02PM +0300, Roi Dayan wrote: > >>> When we skip adding a

[ovs-dev] [PATCH] tnl-ports: Open tunnel type if device name has special prefix

From: Paul Blakey There is a race between listening on route changes from route-table netlink which then calls ovs_router_insert() where it adds the involved netdev to the tnl-ports map (tnl_port_map_insert_ipdev()), and netdev_open from from normal opening of the port.

[ovs-dev] how packet sends out from tunnel

Dear all, I noticed that the send and rx_recv callbacks of all vport type netdevs are all  NULLs. So I am wondering how packet could be sent out via tunnel interface? Could anyone explain that to me? Br, Ted Sent from Mail for Windows 10 ___ dev

Re: [ovs-dev] [PATCH 0/4] netdev-dpdk: Support multi-queue for ovs-dpdk QoS

I am very grateful to you for your advice. I made a v2 patchset series as below, I am sorry for sending it late, but I hope you can help me reviewing it and giving me more advice. v2: patch 0: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336184.html patch 1:

Re: [ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

On Wed, Aug 02, 2017 at 09:41:34PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Wed, Aug 02, 2017 at 05:25:36PM -0400, Aaron Conole wrote: > >> Ben Pfaff writes: > >> > >> > On Tue, Aug 01, 2017 at 06:05:40PM -0400, Aaron Conole wrote: > >> >> When

Re: [ovs-dev] [PATCH 2/2] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

Thanks for working on it. LGTM. Could you please add inline for function netdev_linux_tap_batch_send? That makes it looks like function netdev_linux_sock_batch_send. Or eliminate inline for function netdev_linux_sock_batch_send. Thanks Zhenyu Gao 2017-08-03 5:58 GMT+08:00 Ben Pfaff

Re: [ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

Ben Pfaff writes: > On Wed, Aug 02, 2017 at 05:25:36PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Tue, Aug 01, 2017 at 06:05:40PM -0400, Aaron Conole wrote: >> >> When intermediary files are generated, the destination directory is >> >> assumed >>

[ovs-dev] [PATCH] Incremental patch for v3 5/6 Generic encap and decap support for NSH

Hi, Ben I just noticed a compiling warn in current master for NSH patches, this increment patch is for v3 5/6 Generic encap and decap support for NSH Signed-off-by: Yi Yang --- ofproto/ofproto-dpif-ipfix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [ovs-dev] [PATCH 2/2] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

Thanks for the review. I removed inline from netdev_linux_sock_batch_send() and applied these patches to master. On Thu, Aug 03, 2017 at 09:40:36AM +0800, Gao Zhenyu wrote: > Thanks for working on it. LGTM. > > Could you please add inline for function netdev_linux_tap_batch_send? That > makes

Re: [ovs-dev] RFC: publishing per-release roadmaps

> On Tue, Aug 01, 2017 at 07:53:18PM -0400, Russell Bryant wrote: > > On Tue, Aug 1, 2017 at 6:47 PM, Ben Pfaff wrote: > > > Hello everyone. Last week I spent an afternoon with the OVS-DPDK > > > folks at Intel in Shannon, Ireland. One of the ideas that came out > > > of it was a

Re: [ovs-dev] DPDK Merge Repo

Hi Darrell and Ben. > Hi All > > As mentioned before, I am using a repo for DPDK patch merging. > The repo is here: > https://github.com/darball/ovs/ > > There are still some outstanding patches from Bhanu that have not completed > review yet: > > util: Add PADDED_MEMBERS_CACHELINE_MARKER

Re: [ovs-dev] [PATCH v6 0/2] conntrack : Add support for rx checksum offload.

Hi Sugesh, It's not a review. Just general patch style comment. Please limit lines in the patch description to 75 characters in width as described in contribution guide. Long lines looks bad. Darrell, Ban, I saw that these patches applied to darball/ovs github and I'm asking to not merge until

[ovs-dev] [PATCH v2] ovn: Fix the failing "2335: ovn -- ACL logging" test case

From: Numan Siddique The test case is failing mainly because of timing issue. Looking into the ovn-controller.log it is evident that the last packet injected just before the AT_CHECK, is still not processed by ovn-controller. Fixes: d383eed59589 ("ovn: Add support for ACL

Re: [ovs-dev] [PATCH v4 1/2] OF support and translation of generic encap and decap

All of those seem fine to me. I like getting rid of the extra "hdr=nsh". I think that this should be much more usable and readable. On Wed, Aug 02, 2017 at 01:04:39AM +, Yang, Yi Y wrote: > Maybe > encap(nsh(md_type=2,tlv(0x1000,10,0x12345678),tlv(0x2000,20,0xfedcba9876543210)) > is

Re: [ovs-dev] [PATCH v4 1/2] OF support and translation of generic encap and decap

Sounds nice. I'll take a look. On Wed, Aug 02, 2017 at 08:14:20AM +, Yang, Yi Y wrote: > Hi, Ben > > I have posted v5 which included your incremental patch and encap reformat, > here they are: > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/336594.html >

Re: [ovs-dev] DPDK Merge Repo

>> Hi Darrell and Ben. >> >> > Hi All >> > >> > As mentioned before, I am using a repo for DPDK patch merging. >> > The repo is here: >> > https://github.com/darball/ovs/ >> > >> > There are still some outstanding patches from Bhanu that have not >> completed review yet: >> > >> > util: Add

Re: [ovs-dev] RFC: Let's branch for 2.8 today

> On Aug 1, 2017, at 3:00 PM, Russell Bryant wrote: > > Yes, my reasoning is that a time based release schedule is only > valuable if we stick to it as closely as possible. When dates are > reliable, more downstream advance planning can be done. > > If we stray too far from

Re: [ovs-dev] [PATCH v3 6/6] redhat: allow dpdk to also run as non-root user

Sergio Gonzalez Monroy writes: > Hi Aaron, Hi Sergio, > On 01/08/2017 23:05, Aaron Conole wrote: >> After this commit, users may start a dpdk-enabled ovs setup as a >> non-root user. This is accomplished by exporting the $HOME directory, >> which dpdk uses to

Re: [ovs-dev] DPDK Merge Repo

On Wed, Aug 02, 2017 at 06:03:07AM +, Darrell Ball wrote: > Hi All > > As mentioned before, I am using a repo for DPDK patch merging. > The repo is here: > https://github.com/darball/ovs/ Hi Darrell. Thanks for working on this. When a patch is applied to a repo, for submission, the person

Re: [ovs-dev] DPDK Merge Repo

-Original Message- From: Ben Pfaff Date: Wednesday, August 2, 2017 at 8:09 AM To: Darrell Ball Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] DPDK Merge Repo On Wed, Aug 02, 2017 at 06:03:07AM +, Darrell Ball wrote:

Re: [ovs-dev] DPDK Merge Repo

Ilya Maximets writes: > Hi Darrell and Ben. > >> Hi All >> >> As mentioned before, I am using a repo for DPDK patch merging. >> The repo is here: >> https://github.com/darball/ovs/ >> >> There are still some outstanding patches from Bhanu that have not >> completed

Re: [ovs-dev] DPDK Merge Repo

On Wed, Aug 02, 2017 at 04:35:13PM +0300, Ilya Maximets wrote: > In addition I have a few general thoughts about merging via pull requests: > > 1. There is a requirement described in contribution guide that submitter >must sign-off the patch. But merges on github doesn't work this way. >

Re: [ovs-dev] [PATCH v3 6/6] redhat: allow dpdk to also run as non-root user

Hi Aaron, On 01/08/2017 23:05, Aaron Conole wrote: After this commit, users may start a dpdk-enabled ovs setup as a non-root user. This is accomplished by exporting the $HOME directory, which dpdk uses to fill in it's semi-persistent RTE configuration. This change may be a bit controversial

Re: [ovs-dev] [PATCH] ovn: Fix the failing "2335: ovn -- ACL logging" test case

On Wed, Aug 2, 2017 at 7:37 PM, Lance Richardson wrote: > > From: nusid...@redhat.com > > To: d...@openvswitch.org > > Sent: Monday, 31 July, 2017 2:20:53 PM > > Subject: [ovs-dev] [PATCH] ovn: Fix the failing "2335: ovn -- ACL > logging"test case > > > > From: Numan

Re: [ovs-dev] [PATCH v2] ovn: Fix the failing "2335: ovn -- ACL logging" test case

> On Aug 2, 2017, at 9:20 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > The test case is failing mainly because of timing issue. Looking into the > ovn-controller.log it is evident that the last packet injected just before the > AT_CHECK, is still not

Re: [ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

On Mon, Jul 31, 2017 at 09:21:36AM +0200, Andreas Schultz wrote: > Hi Jiannan, > > - On Jul 13, 2017, at 2:44 AM, Jiannan Ouyang ouya...@fb.com wrote: > > [...] > > > -static int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb, > > - unsigned int hdrlen, unsigned int

Re: [ovs-dev] [PATCH] ovn: Fix the failing "2335: ovn -- ACL logging" test case

> From: nusid...@redhat.com > To: d...@openvswitch.org > Sent: Monday, 31 July, 2017 2:20:53 PM > Subject: [ovs-dev] [PATCH] ovn: Fix the failing "2335: ovn -- ACL logging" > test case > > From: Numan Siddique > > The test case is failing mainly because of timing issue.

Re: [ovs-dev] DPDK Merge Repo

> Hi Darrell and Ben. > > > Hi All > > > > As mentioned before, I am using a repo for DPDK patch merging. > > The repo is here: > > https://github.com/darball/ovs/ > > > > There are still some outstanding patches from Bhanu that have not > completed review yet: > > > > util: Add

Re: [ovs-dev] RFC: Let's branch for 2.8 today

We'd very much like for 2.8 to include NSH support. We are already about a month late on branching, and NSH support is one of the main reasons we've delayed branching this long. But we need to keep approximately to schedule, so we can't wait forever. On Wed, Aug 02, 2017 at 01:49:00AM +,

[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Eliminate duplicate read of xcfgp.

This inner 'xcfg' shadowed the outer one and could have read a different value if 'xcfgp' was changing, so this is possibly a bug fix. Found by -Wshadow=local in GCC 7. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 1 - 1 file changed, 1 deletion(-) diff --git

[ovs-dev] [PATCH 2/2] Eliminate most shadowing for local variable names.

Shadowing is when a variable with a given name in an inner scope hides a different variable with the same name in a surrounding scope. This is generally undesirable because it can confuse programmers. This commit eliminates most of it. Found with -Wshadow=local in GCC 7. The repo is not really

Re: [ovs-dev] DPDK Merge Repo

On Wed, Aug 02, 2017 at 11:23:06AM -0400, Aaron Conole wrote: > Ilya Maximets writes: > > > Hi Darrell and Ben. > > > >> Hi All > >> > >> As mentioned before, I am using a repo for DPDK patch merging. > >> The repo is here: > >> https://github.com/darball/ovs/ > >> > >>

Re: [ovs-dev] [PATCH v2 3/5] dpif-netdev: Skip EMC lookup/insert for recirc packets.

> -Original Message- > From: O Mahony, Billy > Sent: Tuesday, August 1, 2017 11:51 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH v2 3/5] dpif-netdev: Skip EMC lookup/insert for > recirc packets. > > Hi Antonio, > >

Re: [ovs-dev] DPDK Merge Repo

On Wed, Aug 02, 2017 at 03:18:51PM +, Darrell Ball wrote: > > > -Original Message- > From: Ben Pfaff > Date: Wednesday, August 2, 2017 at 8:09 AM > To: Darrell Ball > Cc: "d...@openvswitch.org" > Subject: Re: [ovs-dev] DPDK

Re: [ovs-dev] DPDK Merge Repo

-Original Message- From: Ben Pfaff Date: Wednesday, August 2, 2017 at 10:54 AM To: Darrell Ball Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] DPDK Merge Repo On Wed, Aug 02, 2017 at 03:18:51PM +, Darrell Ball wrote:

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

On Tue, Aug 1, 2017 at 9:21 PM, Numan Siddique wrote: > > > On Wed, Aug 2, 2017 at 1:18 AM, Russell Bryant wrote: >> >> On Tue, Aug 1, 2017 at 3:26 PM, Han Zhou wrote: >> > >> > >> > On Tue, Aug 1, 2017 at 9:19 AM, Russell Bryant