[ovs-dev] [RFC PATCH V4 5/9] dp-packet: init specific mbuf fields to 0

dp_packets are created using xmalloc(); in the case of OvS-DPDK, it's possible the the resultant mbuf portion of the dp_packet contains random data. For some mbuf fields, specifically those related to multi-segment mbufs and/or offload features, random values may cause unexpected behaviour, should

[ovs-dev] [RFC PATCH V4 4/9] dp-packet: Fix data_len issue with multi-seg mbufs

From: Michael Qiu When a packet is from DPDK source, and it contains multiple segments, data_len is not equal to the packet size. This patch fixes this issue. Co-authored-by: Mark Kavanagh Co-authored-by: Przemyslaw Lal

[ovs-dev] [RFC PATCH V4 6/9] dp-packet: copy mbuf info for packet copy

From: Michael Qiu Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Co-authored-by: Mark Kavanagh

[ovs-dev] [PATCH v6 2/8] dpif-netdev: Register packet processing cores to KA framework.

This commit registers the packet processing PMD threads to keepalive framework. Only PMDs that have rxqs mapped will be registered and actively monitored by KA framework. This commit spawns a keepalive thread that will dispatch heartbeats to PMD threads. The pmd threads respond to heartbeats by

[ovs-dev] [PATCH v6 4/8] keepalive: Retrieve PMD status periodically.

This commit implements APIs to retrieve the PMD thread status and return the status in the below format for each PMD thread. Format: pmdid="status,core id,last_seen_timestamp(epoch)" eg: pmd62="ALIVE,2,150332575" pmd63="GONE,3,150332525" The status is periodically

Re: [ovs-dev] [PATCH V6 2/2] netdev-dpdk: vHost IOMMU support

: [ovs-dev][PATCH V6 2/2] netdev-dpdk: vHost IOMMU support > > DPDK v17.11 introduces support for the vHost IOMMU feature. > This is a security feature, which restricts the vhost memory that a virtio > device may access. > > This feature also enables the vhost REPLY_ACK protocol, the

Re: [ovs-dev] two possible bugs about ipv6 multicast

On Wed, Nov 15, 2017 at 11:03:10AM -0800, Ben Pfaff wrote: > On Mon, Sep 04, 2017 at 11:40:01PM +0800, Huanle Han wrote: > > I'm just learning ipv6. When I go through ovs code about ipv6 normal > > forwarding, I find 2 possible "bugs". Could you explain some for me? Thanks. > > > > 1. In fucntion

[ovs-dev] [RFC PATCH V4 0/9] netdev-dpdk: support multi-segment mbufs

Overview This patchset introduces support for multi-segment mbufs to OvS-DPDK. Multi-segment mbufs are typically used when the size of an mbuf is insufficient to contain the entirety of a packet's data. Instead, the data is split across numerous mbufs, each carrying a portion, or

[ovs-dev] [PATCH v6 8/8] NEWS: Add keepalive support information in NEWS.

Signed-off-by: Bhanuprakash Bodireddy --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index 188a075..6fa69ed 100644 --- a/NEWS +++ b/NEWS @@ -15,6 +15,8 @@ Post-v2.8.0 * Add support for compiling OVS with the latest Linux 4.13

[ovs-dev] [PATCH v6 7/8] Documentation: Update DPDK doc with Keepalive feature.

Keepalive feature is aimed at achieving Fastpath Service Assurance in OVS-DPDK deployments. It adds support for monitoring the packet processing threads by dispatching heartbeats at regular intervals. The implementation uses OvSDB for reporting the health of the PMD threads. Any external

[ovs-dev] [PATCH v6 5/8] bridge: Update keepalive status in OVSDB.

This commit allows vswitchd thread to update the OVSDB with the status of all registered PMD threads. The status can be monitored using ovsdb-client and the sample output is below. $ ovsdb-client monitor Open_vSwitch Open_vSwitch keepalive rowaction keepalive

[ovs-dev] [PATCH v6 6/8] keepalive: Add support to query keepalive status and statistics.

This commit adds support to query keepalive status and statistics. $ ovs-appctl keepalive/status keepAlive Status: Enabled $ ovs-appctl keepalive/pmd-health-show Keepalive status keepalive status : Enabled keepalive interva l: 1000 ms keepalive init time: 21 Aug

Re: [ovs-dev] [PATCH V6 1/2] netdev-dpdk: DPDK v17.11 upgrade

Sorry for the late comments. I'm still not happy with the proposed documentation changes (see below). /Jan > -Original Message- > From: Mark Kavanagh [mailto:mark.b.kavan...@intel.com] > Sent: Friday, 08 December, 2017 11:54 > To: d...@openvswitch.org > Cc: ktray...@redhat.com;

[ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

This patch changes OVS_KEY_ATTR_NSH to nested attribute and adds three new NSH sub attribute keys: OVS_NSH_KEY_ATTR_BASE: for length-fixed NSH base header OVS_NSH_KEY_ATTR_MD1: for length-fixed MD type 1 context OVS_NSH_KEY_ATTR_MD2: for length-variable MD type 2 metadata Its

[ovs-dev] [RFC PATCH V4 7/9] dp-packet: copy data from multi-seg. DPDK mbuf

From: Michael Qiu When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Co-authored-by: Mark Kavanagh Signed-off-by: Michael Qiu

[ovs-dev] [PATCH v6 3/4] nsh: fix nested mask for OVS_KEY_ATTR_NSH

NSH kernel implementation used nested mask for OVS_KEY_ATTR_NSH, so NSH userspace must adapt to it, OVS hasn't used nested mask for any key attribute so far, OVS_KEY_ATTR_NSH is the first use case. Signed-off-by: Yi Yang --- lib/odp-execute.c | 54 +--

[ovs-dev] [PATCH v6 0/4] nsh: add new nsh key ttl and action dec_nsh_ttl

v5->v6 - Rebase v5 to master - Refactor netlink message format to align to NSH kernel implementation - Add dec_nsh_ttl unit test into tests/nsh.at - Fix unit test unstable issue v4->v5 - Remove fix patch 1 in v4 because it is merged - Fix several comments by Jan Scheurich v3->v4

Re: [ovs-dev] [PATCH] dpif-netdev: Optimize the exact match lookup.

Hi Tonghao, >On Thu, Jul 27, 2017 at 11:38:00PM -0700, Tonghao Zhang wrote: >> When inserting or updating (e.g. emc_insert) a flow to EMC, we compare >> (e.g the hash and miniflow ) the netdev_flow_key. >> If the key is matched, we will update it. If we didn’t find the >> miniflow in the cache,

Re: [ovs-dev] [PATCH] tunnel: fix tnl_find() after packet_type changed

Hello Jan, Thank you for the review. The recirc_id_node, and thus the frozen_state with the the ofproto_uuid can be retrieved from recirc ID via recirc_id_node_find(). So I think, it would be feasible to get the ofproto from the recirc ID without calling tnl_find(). In addition we would need

[ovs-dev] [RFC PATCH V4 2/9] dp-packet: fix reset_packet for multi-seg mbufs

When adjusting the size of a dp_packet, dp_packet_set_data() should be invoked before dp_packet_set_size(),since for DPDK multi-segment mbufs, the former will use the segments's data_off and buf_len to derive the frame size that should be set (this behaviour is introduced in a subsequent commit).

[ovs-dev] [RFC PATCH V4 1/9] netdev-dpdk: fix mbuf sizing

There are numerous factors that must be considered when calculating the size of an mbuf: - the data portion of the mbuf must be sized in accordance With Rx buffer alignment (typically 1024B). So, for example, in order to successfully receive and capture a 1500B packet, mbufs with a data

Re: [ovs-dev] [PATCH v4 0/2] vHost Dequeue Zero Copy

> > > > Can you comment on that? Can a user also reduce the problem by > > > configuring > > > a) a larger virtio Tx queue size (up to 1K) in Qemu, or > > > > Is this possible right now without modifying QEMU src? I think the size is > hardcoded to 256 at the moment although it may become > >

Re: [ovs-dev] [PATCH V6 1/2] netdev-dpdk: DPDK v17.11 upgrade

> This commit adds support for DPDK v17.11: > - minor updates to accomodate DPDK API changes > - update references to DPDK version in Documentation > - update DPDK version in travis' linux-build script > - document DPDK v17.11 virtio driver bug > > Signed-off-by: Mark Kavanagh

Re: [ovs-dev] [PATCH V6 1/2] netdev-dpdk: DPDK v17.11 upgrade

>From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] >Sent: Friday, December 8, 2017 1:22 PM >To: Kavanagh, Mark B ; d...@openvswitch.org >Cc: ktray...@redhat.com; maxime.coque...@redhat.com; i.maxim...@samsung.com; >Mooney, Sean K ; Stokes,

[ovs-dev] [PATCH v6 4/4] nsh: add dec_nsh_ttl action

NSH ttl is a 6-bit field ranged from 0 to 63, it should be decremented by 1 every hop, if it is 0 or it is so after decremented, the packet should be dropped and a packet-in message is sent to main controller. Signed-off-by: Yi Yang --- include/openvswitch/ofp-actions.h |

[ovs-dev] [RFC PATCH V4 9/9] netdev-dpdk: support multi-segment jumbo frames

Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain an entire jumbo frame of a user-defined size. Typically, for each user-defined MTU, 'requested_mtu', a new mempool is created,

[ovs-dev] [RFC PATCH V4 8/9] netdev-dpdk: copy large packet to multi-seg. mbufs

From: Michael Qiu Currently, packets are only copied to a single segment in the function dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames, particularly when multi-segment mbufs are involved. This patch calculates the number of segments needed by a packet

Re: [ovs-dev] [PATCH] tunnel: fix tnl_find() after packet_type changed

At first glance I would try to skip or enhance the port and bridge lookup in upcall_receive() or xlate_lookup() if flow->recirc_id != 0. The code in xlate_actions() actually already today restores bridge and flow.in_port from the thawed frozen_state. We need to make sure that prior to reaching

[ovs-dev] [PATCH v6 2/4] nsh: add new flow key 'ttl'

IETF NSH draft added a new filed ttl in NSH header, this patch is to add new nsh key 'ttl' for it. Signed-off-by: Yi Yang --- datapath/linux/compat/include/linux/openvswitch.h | 2 +- include/openvswitch/flow.h| 6 +-

Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

Hi Bhanu, Perhaps we can aim at fine-tuning the layout of performance-critical structs once at the end of a release cycle when all development is completed. That way we don't hinder productivity during the release cycle and still won't unnecessarily loose performance. And we should definitely

Re: [ovs-dev] [PATCH] tunnel: fix tnl_find() after packet_type changed

Hi Zoltan, My feeling here is that it is conceptually wrong to do another tunnel lookup if the packet is recirculated after it has already been de-tunneled. You are trying to fix the symptoms and I am not sure that the more liberal check on packet type won't lead to incorrect proper tunnel

[ovs-dev] [PATCH V6 0/2] DPDK v17.11 Support

This patchset adds support for DPDK v17.11: - the first patch introduces minor code updates to accomodate DPDK API changes, and also updates Documentation and travis scripts. - the second patch adds a new global configuration option, vhost-iommu-support; this is required in order to take

[ovs-dev] [PATCH V6 1/2] netdev-dpdk: DPDK v17.11 upgrade

This commit adds support for DPDK v17.11: - minor updates to accomodate DPDK API changes - update references to DPDK version in Documentation - update DPDK version in travis' linux-build script - document DPDK v17.11 virtio driver bug Signed-off-by: Mark Kavanagh

Re: [ovs-dev] [PATCH V5 1/2] netdev-dpdk: DPDK v17.11 upgrade

>From: Bie, Tiwei >Sent: Friday, December 8, 2017 4:19 AM >To: Kavanagh, Mark B >Cc: d...@openvswitch.org; ktray...@redhat.com; maxime.coque...@redhat.com; >i.maxim...@samsung.com; jan.scheur...@ericsson.com; Mooney, Sean K >; Stokes, Ian

[ovs-dev] [PATCH V6 2/2] netdev-dpdk: vHost IOMMU support

DPDK v17.11 introduces support for the vHost IOMMU feature. This is a security feature, which restricts the vhost memory that a virtio device may access. This feature also enables the vhost REPLY_ACK protocol, the implementation of which is known to work in newer versions of QEMU (i.e. v2.10.0),

Re: [ovs-dev] [PATCH V6 1/2] netdev-dpdk: DPDK v17.11 upgrade

On 12/08/2017 10:53 AM, Mark Kavanagh wrote: > This commit adds support for DPDK v17.11: > - minor updates to accomodate DPDK API changes > - update references to DPDK version in Documentation > - update DPDK version in travis' linux-build script > - document DPDK v17.11 virtio driver bug > >

Re: [ovs-dev] [PATCH V6 2/2] netdev-dpdk: vHost IOMMU support

On 12/08/2017 10:53 AM, Mark Kavanagh wrote: > DPDK v17.11 introduces support for the vHost IOMMU feature. > This is a security feature, which restricts the vhost memory > that a virtio device may access. > > This feature also enables the vhost REPLY_ACK protocol, the > implementation of which is

Re: [ovs-dev] [PATCH V5 1/2] netdev-dpdk: DPDK v17.11 upgrade

> From: Mark Kavanagh [mailto:mark.b.kavan...@intel.com] > Sent: Thursday, 07 December, 2017 18:46 > > #. (Optional) Configure DPDK as a shared library > @@ -583,7 +583,21 @@ Limitations >The latest list of validated firmware versions can be found in the `DPDK >release notes`_. > > -..

Re: [ovs-dev] [PATCH v6 1/2] netdev-dpdk: extend netdev_dpdk_get_status to include if_type and if_descr

> This commit extends netdev_dpdk_get_status API to include additional > driver-related information: if_type and if_descr. > Thanks for working on this Michal, looks LGTM, have verified and validated. Will put this in the queue for the DPDK merge branch. Thanks Ian > v2->v3: Code rebase. >

Re: [ovs-dev] [PATCH V5 1/2] netdev-dpdk: DPDK v17.11 upgrade

> This commit adds support for DPDK v17.11: > - minor updates to accomodate DPDK API changes > - update references to DPDK version in Documentation > - update DPDK version in travis' linux-build script > - document DPDK v17.11 virtio driver bug > > Signed-off-by: Mark Kavanagh

Re: [ovs-dev] [PATCH 2/2] Adding configuration option to whitelist DPDK physical ports.

I can confirm that using other_config:dpdk-extra is indeed already effective to change the hugepage file prefix (admittedly without inserting a ref to the pid) and specify a pci whitelist. Regards, Billy. > -Original Message- > From: Mooney, Sean K > Sent: Thursday, December 7, 2017

[ovs-dev] [PATCH] tunnel: fix tnl_find() after packet_type changed

During xlate, it can happen that tnl_find() is invoked when flow packet_type has been already changed. For instance, pop_mpls and resubmit actions should be applied to the packet in overlay bridge after packet was received on a legacy_l3 tunnel port. In this case, packet is recirculated after

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

Hi Ben, Thanks for the clarification. My comments are inline. -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Wednesday, December 06, 2017 11:10 PM To: Vishal Deep Ajmera Cc: d...@openvswitch.org; Keshav Gupta

Re: [ovs-dev] [PATCH V5 1/2] netdev-dpdk: DPDK v17.11 upgrade

>From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] >Sent: Friday, December 8, 2017 10:01 AM >To: Kavanagh, Mark B ; d...@openvswitch.org >Cc: ktray...@redhat.com; maxime.coque...@redhat.com; i.maxim...@samsung.com; >Mooney, Sean K ; Stokes,

[ovs-dev] [PATCH v5 1/2] netdev-dpdk: Helper function for vHost device setup

dpdkvhostuser and dpdkvhostuserclient ports share a lot of the same setup & configuration code. Create a common function they can share in order to remove some duplication of code. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 122

[ovs-dev] [PATCH v5 0/2] vHost Dequeue Zero Copy

This patch enables optional dequeue zero copy for vHost ports. This gives a performance increase for some use cases. I'm using the cover letter to report my results. vhost (vm1) -> vhost (vm2) Using testpmd to source (txonly) in vm1 and sink (rxonly) in vm2. 4C1Q 64B packets: 5.05Mpps -> 5.52Mpps

Re: [ovs-dev] [PATCH] dpif-netdev: Allocate dp_netdev_pmd_thread struct by xzalloc_cacheline.

> >On 08.12.2017 16:45, Stokes, Ian wrote: >>> All instances of struct dp_netdev_pmd_thread are allocated by xzalloc >>> and therefore doesn't guarantee memory allocation aligned on >>> CACHE_LINE_SIZE boundary. Due to this any padding done inside the >>> structure with this assumption might

Re: [ovs-dev] [PATCH v2 1/3] vswitchd: Document netdev-dpdk commands.

>From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Friday, December 8, 2017 3:26 PM >To: Kavanagh, Mark B ; ovs-dev@openvswitch.org >Cc: Heetae Ahn ; Fischetti, Antonio >; Loftus, Ciara

Re: [ovs-dev] [PATCH] dpif-netdev: Allocate dp_netdev_pmd_thread struct by xzalloc_cacheline.

On 08.12.2017 18:44, Bodireddy, Bhanuprakash wrote: >> >> On 08.12.2017 16:45, Stokes, Ian wrote: All instances of struct dp_netdev_pmd_thread are allocated by xzalloc and therefore doesn't guarantee memory allocation aligned on CACHE_LINE_SIZE boundary. Due to this any padding done

Re: [ovs-dev] [PATCH] tunnel: fix tnl_find() after packet_type changed

Hi Zoltan, Please find answers below. Regards, Jan > -Original Message- > From: Zoltán Balogh > Sent: Friday, 08 December, 2017 12:56 > To: Jan Scheurich ; d...@openvswitch.org > Cc: Ben Pfaff > Subject: RE: [PATCH] tunnel: fix tnl_find() after

[ovs-dev] [PATCH v3 2/2] netdev-dpdk: Add debug appctl to get mempool information.

New appctl 'netdev-dpdk/get-mempool-info' implemented to get result of 'rte_mempool_list_dump()' function if no arguments passed and 'rte_mempool_dump()' if DPDK netdev passed as argument. Could be used for debugging mbuf leaks and other mempool related issues. Most useful in pair with `grep -v

Re: [ovs-dev] [PATCH] AUTHORS: Update email address for Thadeu Lima de Souza Cascardo.

On Fri, Dec 08, 2017 at 07:51:08AM -0800, Ben Pfaff wrote: > CC: Thadeu Lima de Souza Cascardo > Signed-off-by: Ben Pfaff Acked-by: Thadeu Lima de Souza Cascardo > --- > AUTHORS.rst | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH V6 1/2] netdev-dpdk: DPDK v17.11 upgrade

> > > >What happened to my request to add here that running OVS 2.9 with DPDK > >datapath in a VM with virtio interfaces may itself suffer from the DPDK 17.11 > >bug in OVS' own virtio PMD? The work-around for this could be to enable the > >mrg_rxbuf feature in Qemu for the OVS VM as that would

Re: [ovs-dev] [PATCH v2 1/3] vswitchd: Document netdev-dpdk commands.

On 08.12.2017 17:44, Kavanagh, Mark B wrote: >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Friday, November 10, 2017 7:12 AM >> To: ovs-dev@openvswitch.org >> Cc: Heetae Ahn ; Fischetti, Antonio >> ; Loftus, Ciara

[ovs-dev] [PATCH v3 0/2] netdev-dpdk: Mempool creation failure + Appctl

Second patch adds debug appctl to obtain mempool information from DPDK including names, numbers of available mbufs, object sizes and memory pointers. First patch introduces common place for 'netdev-dpdk' unixctl commands documentation in man pages. Version 3: * Dropped patch about mempool

Re: [ovs-dev] two possible bugs about ipv6 multicast

On Fri, Dec 08, 2017 at 12:14:45PM -0200, Thadeu Lima de Souza Cascardo wrote: > Ben, Flavio brought me this email to my attention. As I am not receiving > emails from casca...@redhat.com anymore, should there be an update to > AUTHORS? Not sure if it tracks the original email, which may indicate

[ovs-dev] [PATCH] AUTHORS: Update email address for Thadeu Lima de Souza Cascardo.

CC: Thadeu Lima de Souza Cascardo Signed-off-by: Ben Pfaff --- AUTHORS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS.rst b/AUTHORS.rst index 075b2f72d47d..446a43925878 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -310,7

Re: [ovs-dev] [PATCH v3 2/2] netdev-dpdk: Add debug appctl to get mempool information.

>From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Friday, December 8, 2017 3:38 PM >To: ovs-dev@openvswitch.org >Cc: Heetae Ahn ; Fischetti, Antonio >; Loftus, Ciara ; >Kavanagh, Mark B

Re: [ovs-dev] [PATCH v2 1/3] vswitchd: Document netdev-dpdk commands.

>From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Friday, November 10, 2017 7:12 AM >To: ovs-dev@openvswitch.org >Cc: Heetae Ahn ; Fischetti, Antonio >; Loftus, Ciara ; >Kavanagh, Mark B

[ovs-dev] [PATCH v5 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

Enabled per port like so: ovs-vsctl set Interface dpdkvhostuserclient0 options:dq-zero-copy=true The feature is disabled by default and can only be enabled/disabled when a vHost port is down. When packets from a vHost device with zero copy enabled are destined for a 'dpdk' port, the number of tx

Re: [ovs-dev] [PATCH] dpif-netdev: Allocate dp_netdev_pmd_thread struct by xzalloc_cacheline.

> >On 08.12.2017 18:44, Bodireddy, Bhanuprakash wrote: >>> >>> On 08.12.2017 16:45, Stokes, Ian wrote: > All instances of struct dp_netdev_pmd_thread are allocated by > xzalloc and therefore doesn't guarantee memory allocation aligned > on CACHE_LINE_SIZE boundary. Due to this any

Re: [ovs-dev] [PATCH v6 0/4] nsh: add new nsh key ttl and action dec_nsh_ttl

On 12/8/2017 6:04 AM, Yi Yang wrote: v5->v6 - Rebase v5 to master - Refactor netlink message format to align to NSH kernel implementation - Add dec_nsh_ttl unit test into tests/nsh.at - Fix unit test unstable issue v4->v5 - Remove fix patch 1 in v4 because it is merged -

Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

> >On 07/12/17 14:28, Ilya Maximets wrote: > >> Thanks for review, comments inline. > >> > >> On 07.12.2017 15:49, Eelco Chaudron wrote: > >>> On 01/12/17 16:44, Ilya Maximets wrote: > This is preparation for 'struct dp_netdev_pmd_thread' modification > in upcoming commits. Needed to

Re: [ovs-dev] [RFC PATCH V4 3/9] dp-packet: fix put_uninit for multi-seg mbufs

Regards _Sugesh > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, December 8, 2017 12:02 PM > To: d...@openvswitch.org; qiud...@chinac.com > Cc: Stokes, Ian ; Loftus, Ciara > ; > santosh.shu...@caviumnetworks.com; Chandran,

Re: [ovs-dev] [PATCH v3 1/2] vswitchd: Document netdev-dpdk commands.

On Fri, Dec 08, 2017 at 06:38:10PM +0300, Ilya Maximets wrote: > netdev-dpdk appctl commands added to man pages. > > Signed-off-by: Ilya Maximets > Acked-by: Antonio Fischetti > --- > NEWS| 2 ++ > lib/automake.mk

Re: [ovs-dev] [RFC PATCH V4 6/9] dp-packet: copy mbuf info for packet copy

Regards _Sugesh > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, December 8, 2017 12:02 PM > To: d...@openvswitch.org; qiud...@chinac.com > Cc: Stokes, Ian ; Loftus, Ciara > ; > santosh.shu...@caviumnetworks.com; Chandran,

Re: [ovs-dev] [RFC PATCH V4 8/9] netdev-dpdk: copy large packet to multi-seg. mbufs

Regards _Sugesh > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, December 8, 2017 12:02 PM > To: d...@openvswitch.org; qiud...@chinac.com > Cc: Stokes, Ian ; Loftus, Ciara > ; > santosh.shu...@caviumnetworks.com; Chandran,

Re: [ovs-dev] [PATCH V6 1/2] netdev-dpdk: DPDK v17.11 upgrade

> > > > > >What happened to my request to add here that running OVS 2.9 with > > >DPDK datapath in a VM with virtio interfaces may itself suffer from > > >the DPDK 17.11 bug in OVS' own virtio PMD? The work-around for this > > >could be to enable the mrg_rxbuf feature in Qemu for the OVS VM as > >

Re: [ovs-dev] [PATCH] tests: add-del-add sequence for interface

On Tue, Dec 5, 2017 at 9:23 AM, Ashish Varma wrote: > added a unit test case for testing the condition when a tap interface > is added to br0 and then the tap interface is deleted from the > system and added back with the same name. > > Signed-off-by: Ashish Varma

Re: [ovs-dev] [RFC PATCH V4 5/9] dp-packet: init specific mbuf fields to 0

Regards _Sugesh > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, December 8, 2017 12:02 PM > To: d...@openvswitch.org; qiud...@chinac.com > Cc: Stokes, Ian ; Loftus, Ciara > ; > santosh.shu...@caviumnetworks.com; Chandran,

Re: [ovs-dev] [RFC PATCH V4 0/9] netdev-dpdk: support multi-segment mbufs

Thank you Mark & Michael Qiu for this work. I had looked at the patch series and have some high level comments as inline. I would like to test these patch on some of the test scenarios. so please send a proper patch series once the DPDK17.11 support is added in OVS. Regards _Sugesh >

Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

Hi Jan, I had problems applying later patches in this series so just reviewing this one for now. I tried several revisions to apply them. The second patch ([ovs-dev,v3,2/3] dpif-netdev: Detailed performance stats for PMDs ) fails with fatal: patch fragment without header at line 708: @@

Re: [ovs-dev] [RFC PATCH V4 1/9] netdev-dpdk: fix mbuf sizing

Regards _Sugesh > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, December 8, 2017 12:02 PM > To: d...@openvswitch.org; qiud...@chinac.com > Cc: Stokes, Ian ; Loftus, Ciara > ; > santosh.shu...@caviumnetworks.com; Chandran,

Re: [ovs-dev] [RFC PATCH V4 9/9] netdev-dpdk: support multi-segment jumbo frames

Hi Mark, For some reason, I could not apply this patch cleanly. I couldn't do much of testing on the feature as such. Can you please send a proper Patch after rebase. Regards _Sugesh > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, December 8, 2017 12:02 PM > To:

Re: [ovs-dev] [PATCH] AUTHORS: Update email address for Thadeu Lima de Souza Cascardo.

On Fri, Dec 08, 2017 at 02:09:30PM -0200, Thadeu Lima de Souza Cascardo wrote: > On Fri, Dec 08, 2017 at 07:51:08AM -0800, Ben Pfaff wrote: > > CC: Thadeu Lima de Souza Cascardo > > Signed-off-by: Ben Pfaff > > Acked-by: Thadeu Lima de Souza Cascardo

Re: [ovs-dev] [PATCH v3 2/2] netdev-dpdk: Add debug appctl to get mempool information.

On Fri, Dec 08, 2017 at 06:38:11PM +0300, Ilya Maximets wrote: > New appctl 'netdev-dpdk/get-mempool-info' implemented to get result > of 'rte_mempool_list_dump()' function if no arguments passed and > 'rte_mempool_dump()' if DPDK netdev passed as argument. > > Could be used for debugging mbuf

[ovs-dev] [PATCH] ovsdb-data: Add OVS_WARN_UNUSED_RESULT annotations to function definitions.

The function prototypes in ovsdb-data.h already have these, but it seems more complete to have the annotation on the definitions too. Signed-off-by: Ben Pfaff --- lib/ovsdb-data.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-data.c

[ovs-dev] Argumentación Jurídica

Conozca, interprete y aplique la ley a su favor Argumentación jurídica para las áreas contable y financiera 18 de Diciembre - L.C. y L.D. Jacobo Meraz Sotelo 9am-6pm Es de suma importancia que los empresarios y los encargados de las áreas contables y administrativas conozcan la interpretación y

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

On Fri, Dec 08, 2017 at 10:03:06AM +, Vishal Deep Ajmera wrote: > On Wed, Dec 06, 2017 at 11:57:48AM +, Vishal Deep Ajmera wrote: > > Hi Ben,> From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Tuesday, December 05, 2017 12:52 AM > > To: Vishal Deep Ajmera >

[ovs-dev] [PATCH] stream-unix: Give accepted sockets distinct names for log messages.

At least on Linux, when process A connects to process B over a Unix domain socket, unless process A bound its socket to a name before it made the connection, process B gets an empty peer name. Until now, OVS has just reported the name of the connection as "unix". This is not meaningful, of

[ovs-dev] [PATCH 1/2] test-ovsdb: Simplify code in do_trigger().

Signed-off-by: Ben Pfaff --- tests/test-ovsdb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-ovsdb.c b/tests/test-ovsdb.c index 553a4f6a5bf1..ae679c1319e9 100644 --- a/tests/test-ovsdb.c +++ b/tests/test-ovsdb.c @@ -1531,10 +1531,10 @@

[ovs-dev] [PATCH 2/5] ovsdb-idl: Fix indentation in a couple of places.

White space changes only. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 7e3abdee8e62..aede751412fb 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@

[ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

This change documents the IDL state machine, adds other comments, and fixes a spelling error in a comment. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 57 ++--- 1 file changed, 46 insertions(+), 11 deletions(-) diff --git

[ovs-dev] [PATCH 4/5] ovsdb-idl: Remove 'uuid' member of struct ovsdb_idl.

This was used to uniquely identify the monitor, but there's no need for that. A fixed monitor name works fine. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c

[ovs-dev] [PATCH 5/5] ovsdb-idl: Tolerate initialization races for singleton tables.

By verifying that singleton tables (that is, tables that should have exactly one row) are empty when they emit transactions that insert into them, ovs-vsctl and similar tools tolerate initialization races, where more than one client at a time tries to initialize a singleton table. The upshot is

[ovs-dev] [PATCH] tests: Always ignore "Broken pipe" and "Connection reset" log messages.

Until now, the ovn-controller-vtep, ovn-nbctl, and ovn-sbctl tests have ignored "Broken pipe" and "Connection reset" messages. The same rationale that applies to them also applies to ovs-vsctl and other utilities. It seems easier to just always ignore them. Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] ovsdb-data: Add OVS_WARN_UNUSED_RESULT annotations to function definitions.

On 12/8/2017 11:22 AM, Ben Pfaff wrote: The function prototypes in ovsdb-data.h already have these, but it seems more complete to have the annotation on the definitions too. Signed-off-by: Ben Pfaff --- lib/ovsdb-data.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[ovs-dev] [PATCH] ovsdb: Improve documentation.

Signed-off-by: Ben Pfaff --- Documentation/automake.mk| 5 +- Documentation/conf.py| 6 + Documentation/ref/index.rst | 3 + Documentation/ref/ovsdb-server.7.rst | 393 + Documentation/ref/ovsdb.5.rst| 125

Re: [ovs-dev] [PATCH] ovsdb-data: Add OVS_WARN_UNUSED_RESULT annotations to function definitions.

On Fri, Dec 08, 2017 at 01:37:29PM -0800, Gregory Rose wrote: > On 12/8/2017 11:22 AM, Ben Pfaff wrote: > >The function prototypes in ovsdb-data.h already have these, but it seems > >more complete to have the annotation on the definitions too. > > > >Signed-off-by: Ben Pfaff > >---

Re: [ovs-dev] [PATCH] tests: Always ignore "Broken pipe" and "Connection reset" log messages.

> On Dec 8, 2017, at 1:28 PM, Ben Pfaff wrote: > > Until now, the ovn-controller-vtep, ovn-nbctl, and ovn-sbctl tests have > ignored "Broken pipe" and "Connection reset" messages. The same rationale > that applies to them also applies to ovs-vsctl and other utilities. It > seems

[ovs-dev] [PATCH v2] ovsdb: Improve documentation.

Signed-off-by: Ben Pfaff --- v1->v2: Rebase with minor changes. Documentation/automake.mk| 5 +- Documentation/conf.py| 6 + Documentation/ref/index.rst | 3 + Documentation/ref/ovsdb-server.7.rst | 393 +

Re: [ovs-dev] [PATCH] ovsdb: Improve documentation.

On Fri, Dec 08, 2017 at 01:37:44PM -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff There were minor patch rejects so I fixed them and sent v2: https://patchwork.ozlabs.org/patch/846495/ ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] doc: Correct path of kernel system tests results directory.

On Fri, Dec 08, 2017 at 03:18:42PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > Documentation/topics/testing.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/topics/testing.rst > b/Documentation/topics/testing.rst

[ovs-dev] [patch v1] conntrack: Fix alg expectation cleanup.

Presently, alg expectations are removed by being time expired. This was intended to happen before the control connections and was intended to minimize the extra work involved for tracking and removing the expectations. This is not the best option and conceptually an expectation should not exist

Re: [ovs-dev] [PATCH] doc: Correct path of kernel system tests results directory.

> On Dec 8, 2017, at 3:28 PM, Ben Pfaff wrote: > > On Fri, Dec 08, 2017 at 03:18:42PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit >> --- >> Documentation/topics/testing.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: [ovs-dev] [PATCH v2 2/3] conntrack: Support conntrack flush by ct 5-tuple

On 12/6/17, 2:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of Justin Pettit" wrote: > On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei wrote: > > diff --git a/lib/conntrack.c

Re: [ovs-dev] [PATCH] jsonrpc-server: Report monitor session ID properly in error message.

On Fri, Dec 08, 2017 at 02:40:58PM -0800, Justin Pettit wrote: > > > > On Dec 8, 2017, at 1:01 PM, Ben Pfaff wrote: > > > > The error message in question is about the monitor session ID but it > > actually reports the JSON-RPC request ID instead, which is surprising. > > > >

Re: [ovs-dev] [PATCH] ovsdb-server: Document monitor_cond_change behavior for unmentioned tables.

On Fri, Dec 08, 2017 at 02:39:36PM -0800, Justin Pettit wrote: > > > On Dec 8, 2017, at 12:53 PM, Ben Pfaff wrote: > > > > It seems best to be explicit about this. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks! Applied to

Re: [ovs-dev] [PATCH v2 2/3] conntrack: Support conntrack flush by ct 5-tuple

> On Dec 8, 2017, at 6:23 PM, Darrell Ball wrote: > > >I believe the kernel clears out expectations. As we discussed off-line, I > think it would make sense to follow similar behavior, since presumably if the > control channel is being flushed, the related flows

Re: [ovs-dev] [PATCH v2] ofproto, ovsdb, vswitchd: Avoid using protected as variable name

On Mon, Dec 04, 2017 at 02:37:57PM -0800, Yi-Hung Wei wrote: > In C++, 'protected' is a keyword. This patch renames 'protected' > to 'protected_' in a couple files so that C++ compiler will > not get confused. > > Signed-off-by: Yi-Hung Wei > --- > ofproto/ofproto-dpif.c |

  1   2   >