[ovs-dev] [patch v3 8/9] tests: Add missed local stack check.

Signed-off-by: Darrell Ball --- tests/system-traffic.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..aee7391 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +2093,7 @@

Re: [ovs-dev] [patch v3 2/9] Userspace datapath: Add v4 fragmentation handling.

On 1/25/18, 6:07 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell Ball" wrote: Fragmentation handling is added for supporting conntrack. Presently, only v4 is supported, with v6 coming soon. Fragmentation

[ovs-dev] Darlehen Geld für Einzelpersonen und Fachleute in weniger als 72 Stunden

Hallo, Sind Sie in einer schwierigen Situation, für die Sie sich für ein Darlehen suchen? Benötigen Sie eine Finanzierung, um eine Schuld zu begleichen oder eine Aktivität zu finanzieren? Haben Sie einen Verbraucherkredit, eine Hypothek, einen persönlichen Kredit, eine Hypothek, Investition

[ovs-dev] [patch v3 0/9] Userspace datapath: Add fragmentation support.

Fragmentation support for userspace datapath conntrack is added; see patches for additional details. v2->v3: Patch 2 was updated: Remove "XXX" todo items by implementing the ones needed, including realloc frag_list contexts to save memory. Fix related bug with

[ovs-dev] [patch v3 2/9] Userspace datapath: Add v4 fragmentation handling.

Fragmentation handling is added for supporting conntrack. Presently, only v4 is supported, with v6 coming soon. Fragmentation handling is disabled by default and enabled via a user command implemented in a subsequent patch. Signed-off-by: Darrell Ball --- lib/automake.mk | 2

[ovs-dev] [patch v3 5/9] ipf: Add set minimum fragment size command.

A new command "ovs-appctl dpctl/ipf-set-minfragment" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31

[ovs-dev] [patch v3 7/9] ipf: Add command to get fragmentation handling status.

A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status as well as fragment counters. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 15

[ovs-dev] [patch v3 6/9] ipf: Add set maximum fragments supported command.

A new command "ovs-appctl dpctl/ipf-set-maxfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31

[ovs-dev] [patch v3 4/9] ipf: Add command to enable fragmentation handling.

A new command "ovs-appctl dpctl/ipf-set-enabled" is added to enable/disable userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31

[ovs-dev] [patch v3 3/9] conntrack: Support v4 fragmentation.

The conntrack module now calls fragmentation support apis. Signed-off-by: Darrell Ball --- NEWS| 3 ++- lib/conntrack.c | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index d7d585b..137c511 100644 --- a/NEWS +++ b/NEWS @@ -1,6

[ovs-dev] [patch v3 1/9] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(struct

[ovs-dev] [PATCH] openvswitch/types.h: Drop the member name in initializer macro

MSVC++ compiler does not allow initializing a struct while explicitly initializing a member in the struct. Not allowed: static const struct eth_addr a = {{ .ea= { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }}}; Alowed: static const struct eth_addr b = {{{

Re: [ovs-dev] [PATCH] gre: strip gre-tso offload flags

On 12/28/2017 8:45 PM, we...@ucloud.cn wrote: From: wenxu if the gro enable, ipgre receive a gre-tso package. After pop the gre-tunnel the encapsulation and GSO_ENCAP flags should be striped. or the packet encap again and will be dropped in ovs_iptunnel_handle_offloads

Re: [ovs-dev] [PATCH] gre: strip gre-tso offload flags

On Thu, Jan 25, 2018 at 10:16:23AM -0800, Gregory Rose wrote: > On 12/28/2017 8:45 PM, we...@ucloud.cn wrote: > >From: wenxu > > > >if the gro enable, ipgre receive a gre-tso package. After pop > >the gre-tunnel the encapsulation and GSO_ENCAP flags should be > >striped. or the

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

> > On Jan 24, 2018, at 9:14 AM, Ben Pfaff wrote: > > > > On Wed, Jan 24, 2018 at 01:55:18PM +, Stokes, Ian wrote: > >>> -Original Message- > >>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > >>> boun...@openvswitch.org] On Behalf Of Justin Pettit > >>> Sent:

Re: [ovs-dev] [PATCH] openvswitch/types.h: Drop the member name in initializer macro

On Thu, Jan 25, 2018 at 10:12:08AM -0800, Shashank Ram wrote: > MSVC++ compiler does not allow initializing a struct while > explicitly initializing a member in the struct. > > Not allowed: > static const struct eth_addr a = {{ .ea= { 0xff, 0xff, 0xff, 0xff, >

Re: [ovs-dev] [PATCH v2] Fix incorrect handling of return value.

On Thu, Jan 25, 2018 at 09:12:36AM +0800, huanglili wrote: > From: Lili Huang > > The value cookie_offset should be 'size_t' type. > > Signed-off-by: Lili Huang Applied, thanks. ___ dev mailing

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

> On Jan 25, 2018, at 10:26 AM, Stokes, Ian wrote: > >> Yes, this was my thinking too. I don't think we should have a prohibition >> against using "xxx", but I do usually see it in patches as something that >> was left behind unintentionally. That said, my personal

[ovs-dev] [PATCH] ovs-atomic: Fix typo in comment.

Signed-off-by: Ben Pfaff --- lib/ovs-atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h index 75560935f963..4664eefaf3a1 100644 --- a/lib/ovs-atomic.h +++ b/lib/ovs-atomic.h @@ -300,7 +300,7 @@ * bool

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

Justin Pettit writes: >> On Jan 25, 2018, at 10:26 AM, Stokes, Ian wrote: >> >>> Yes, this was my thinking too. I don't think we should have a prohibition >>> against using "xxx", but I do usually see it in patches as something that >>> was left behind

[ovs-dev] Hardware Acceleration in OVS-DPDK

Hi All, As discussed in the last hardware acceleration meeting, I am setting up the follow up call to discuss about submitting a RFC patch series on OVS-DPDK full hardware acceleration solution. This time I am scheduling the call at PRC time zone friendly. Agenda for the Call 1) DPDK

Re: [ovs-dev] [PATCH] rhel: Change depmod configuration

Hi Greg, Greg Rose writes: > A previous patch added post install and post uninstall scripts which > use the weak-modules utility to make sure that openvswitch kernel > modules are copied to the correct kernel directory. While this > patch did fix some issues there are two

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

> On Jan 25, 2018, at 12:36 PM, Aaron Conole wrote: > > Because more voices of support are better - I am in favor of this > change. > > I agree with the sentiment that checkpatch is meant to help bring things > to light that humans sometimes glaze over (we all develop our

Re: [ovs-dev] [PATCH] rhel: Change depmod configuration

On 1/25/2018 12:58 PM, Aaron Conole wrote: Hi Greg, Greg Rose writes: A previous patch added post install and post uninstall scripts which use the weak-modules utility to make sure that openvswitch kernel modules are copied to the correct kernel directory. While this

Re: [ovs-dev] [RFC] netdev-dpdk: Update amount of mbufs requested.

> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, January 23, 2018 6:43 PM > To: d...@openvswitch.org; Wojciechowicz, RobertX > ; venkatesan.prad...@ericsson.com; > jan.scheur...@ericsson.com; Stokes, Ian

[ovs-dev] Finanzas prácticas para no financieros

Conozca y dirija sus finanzas de su empresa con éxito Finanzas prácticas para no financieros 14 de Febrero- CP. Hugo Coca Chávez - 9am- 8pm Fundamentar la toma de decisiones financieras a través del conocimiento de distintas herramientas que permiten resolver problemas personales y

[ovs-dev] Actualización para compradores profesionales

En línea y en Vivo / Para todo su Equipo con una sola Conexión Cómo ser el mejor COMPRADOR Actualización para compradores profesionales 08 de febrero - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs En el pasado, un comprador solo adquiría mercancía…pero ahora ya no. Se espera

Re: [ovs-dev] mbuf pool sizing

On 01/24/2018 10:19 AM, Venkatesan Pradeep wrote: > Hi Kevin, > > My primary concern is that someone upgrading to OVS2.9 may find that > configurations that were previously working fine no longer do because the > memory dimensioned for OVS may not be sufficient. It could be argued that > since

[ovs-dev] [PATCH 1/5] ofproto: Fix double-unref of temporary rule when learning.

When ofproto_flow_mod_init() accepts a rule, it takes ownership of it and either unrefs it on error or transfers ownership to the struct it initializes on success, but ofproto_flow_mod_init_for_learn() was unref-ing it a second time if it reported an error. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH 5/5] ovs-vswitchd: Avoid or suppress memory leak warning for glibc aio.

The asynchronous IO library in glibc starts threads that show up as memory leaks in valgrind. This commit attempts to avoid the warnings by flushing all the asynchronous I/O to the log file before exiting. This only does part of the job for glibc since it keeps the threads around for some

[ovs-dev] [PATCH branch-2.8 1/1] tc flower: reorder tunnel encap/decap actions

The tc_flower conversion struct does not consider the order of actions. If an OvS rule matches on a tunnel (decap) and outputs to a new tunnel, the netlink conversion to TC will add the set tunnel key action before the unset, leading to an incorrect TC rule. This patch reorders the netlink

Re: [ovs-dev] [PATCH v2 0/4] Check size of packets before sending

On Thu, Jan 25, 2018 at 03:31:05PM +1100, Daniel Axtens wrote: > There are a few ways we can send packets that are too large to a > network driver. > > When non-GSO packets are forwarded, we validate their size, based on > the MTU of the destination device. However, when GSO packets are >

[ovs-dev] [PATCH 2/5] ofproto: Avoid use-after-free on error path in ofproto_flow_mod_learn().

In the case where the learned flow limit has been reached (below_limit == false), ofproto_flow_mod_uninit() would unref ofm->temp_rule (which is also in the 'rule' local variable) before dereferencing rule->flow_cookie for the log message. This fixes the problem. (The greatest likely consequence

[ovs-dev] [PATCH 4/5] ovs-vswitchd: Fire RCU callbacks before exit to reduce memory leak warnings.

ovs-vswitchd makes extensive use of RCU to defer freeing memory past the latest time that it could be in use by a thread. Until now, ovs-vswitchd has not waited for RCU callbacks to fire before exiting. This meant that in many cases, when ovs-vswitchd exits, many blocks of memory are stuck in

[ovs-dev] [PATCH 3/5] ovs-vsctl, vtep-ctl: Free 'args' string on exit.

This avoids a memory leak warning from valgrind. ovn-sbctl and ovn-nbctl already followed this pattern. Signed-off-by: Ben Pfaff --- utilities/ovs-vsctl.c | 12 vtep/vtep-ctl.c | 12 2 files changed, 16 insertions(+), 8 deletions(-) diff --git

Re: [ovs-dev] [PATCH] gre: strip gre-tso offload flags

On 1/25/2018 10:22 AM, Ben Pfaff wrote: On Thu, Jan 25, 2018 at 10:16:23AM -0800, Gregory Rose wrote: On 12/28/2017 8:45 PM, we...@ucloud.cn wrote: From: wenxu if the gro enable, ipgre receive a gre-tso package. After pop the gre-tunnel the encapsulation and GSO_ENCAP flags

[ovs-dev] Gastos no deducibles

Gastos de Viaje, Viáticos y su Régimen Fiscal Febrero 08 - webinar Interactivo Dirigido a: -Encargados de elaborar las políticas relacionadas con los gastos de viaje. - A quienes tienen la responsabilidad de efectuar los pagos de viáticos. -A quienes registran en contabilidad los gastos de

Re: [ovs-dev] [PATCH] ovs-atomic: Fix typo in comment.

> On Jan 25, 2018, at 11:51 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > lib/ovs-atomic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h > index 75560935f963..4664eefaf3a1 100644 > ---

[ovs-dev] [patch v2 1/9] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(struct

[ovs-dev] [patch v2 0/9] Userspace datapath: Add fragmentation support.

Fragmentation support for userspace datapath conntrack is added; see patches for additional details. v1->v2: Few fixes, improvements and cleanups. Darrell Ball (9): dp-packet: Add const qualifiers for checksum apis. Userspace datapath: Add v4 fragmentation handling. conntrack: Support v4

[ovs-dev] [patch v2 6/9] ipf: Add set maximum fragments supported command.

A new command "ovs-appctl dpctl/ipf-set-maxfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31

[ovs-dev] [patch v2 7/9] ipf: Add command to get fragmentation handling status.

A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status as well as fragment counters. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 15

[ovs-dev] [patch v2 4/9] ipf: Add command to enable fragmentation handling.

A new command "ovs-appctl dpctl/ipf-set-enabled" is added to enable/disable userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31

[ovs-dev] [patch v2 5/9] ipf: Add set minimum fragment size command.

A new command "ovs-appctl dpctl/ipf-set-minfragment" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31

[ovs-dev] [patch v2 2/9] Userspace datapath: Add v4 fragmentation handling.

Fragmentation handling is added for supporting conntrack. Presently, only v4 is supported, with v6 coming soon. Fragmentation handling is disabled by default and enabled via a user command implemented in a subsequent patch. Signed-off-by: Darrell Ball --- lib/automake.mk | 2

[ovs-dev] [patch v2 3/9] conntrack: Support v4 fragmentation.

The conntrack module now calls fragmentation support apis. Signed-off-by: Darrell Ball --- NEWS| 3 ++- lib/conntrack.c | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index d7d585b..137c511 100644 --- a/NEWS +++ b/NEWS @@ -1,6

[ovs-dev] [patch v2 8/9] tests: Add missed local stack check.

Signed-off-by: Darrell Ball --- tests/system-traffic.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..aee7391 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +2093,7 @@

[ovs-dev] [patch v2 9/9] tests: Enable v4 fragmentation for userspace datapath.

Signed-off-by: Darrell Ball --- tests/system-kmod-macros.at | 14 +++--- tests/system-traffic.at | 27 +-- tests/system-userspace-macros.at | 36 3 files changed, 60 insertions(+), 17

Re: [ovs-dev] [PATCH] ofproto-dpif: Delete system tunnel interface when remove ovs bridge

On Wed, Jan 24, 2018 at 12:48:38PM -0800, Ben Pfaff wrote: > On Wed, Jan 24, 2018 at 09:31:32AM -0500, Eric Garver wrote: > > On Tue, Jan 23, 2018 at 07:46:47PM -0800, Ben Pfaff wrote: > > > On Thu, Oct 26, 2017 at 10:24:46AM -0400, Eric Garver wrote: > > > > On Wed, Oct 25, 2017 at 11:41:27AM

Re: [ovs-dev] [ovs-dev, v3] netdev-dpdk: Configurable Link State Change (LSC) detection mode

Not a full review. Comments inline. Best regards, Ilya Maximets. On 24.01.2018 17:35, Róbert Mulik wrote: > It is possible to change LSC detection mode to polling or interrupt mode > for DPDK interfaces. The default is polling mode. To set interrupt mode, > option dpdk-lsc-interrupt has to be

Re: [ovs-dev] [ovs-dev, v3] netdev-dpdk: Configurable Link State Change (LSC) detection mode

Hi Ilya, Thanks for the review! For this question: "Is there a reason why we should be able to configure default value in runtime? I think that we could make this boot-time option and move all the related code to lib/dpdk.{c,h} just like for vhost iommu support. IMHO, user should know if most

Re: [ovs-dev] [PATCH v2 0/4] Check size of packets before sending

Hi Eric, > May I ask which tree are you targeting ? > > ( Documentation/networking/netdev-FAQ.txt ) I have been targeting net-next, but I haven't pulled for about two weeks. I will rebase and if there are conflicts I will resend early next week. > Anything touching GSO is very risky and should

Re: [ovs-dev] [PATCH v2 0/4] Check size of packets before sending

On Thu, 2018-01-25 at 15:31 +1100, Daniel Axtens wrote: > There are a few ways we can send packets that are too large to a > network driver. > > When non-GSO packets are forwarded, we validate their size, based on > the MTU of the destination device. However, when GSO packets are > forwarded, we

Re: [ovs-dev] [PATCH v2 0/4] Check size of packets before sending

On Fri, 2018-01-26 at 00:44 +1100, Daniel Axtens wrote: > Hi Eric, > > > May I ask which tree are you targeting ? > > > > ( Documentation/networking/netdev-FAQ.txt ) > > I have been targeting net-next, but I haven't pulled for about two > weeks. I will rebase and if there are conflicts I will

Re: [ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

On Wed, Jan 24, 2018 at 05:29:45PM +, Stokes, Ian wrote: > > -Original Message- > > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > > Sent: Wednesday, December 20, 2017 2:45 PM > > To: d...@openvswitch.org > > Cc: Finn Christensen ; Darrell Ball ;