Re: [ovs-dev] [v2] odp: Add datapath clone action parser.

On Wed, Feb 01, 2017 at 01:36:33PM -0800, Andy Zhou wrote: > When adding userspace datapath clone action, the corresponding odp > actions parser and unit tests were missing. This patch adds them. > > Reported-by: Ben Pfaff <b...@ovn.org> > Signed-off-by: Andy Zhou <az..

Re: [ovs-dev] [PATCH 0/6] Fix tunnel information destination port

itch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Thursday, February 2, 2017 10:53 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/6] Fix tunnel information destination port >

Re: [ovs-dev] [PATCH] ofp-actions: Fix tunnel meatdata subfield length in flow action

ng > > On Thu, Feb 2, 2017 at 10:45 AM, Ben Pfaff <b...@ovn.org> wrote: > > > On Mon, Jan 09, 2017 at 06:09:33PM -0800, Yi-Hung Wei wrote: > > > Previously, if a flow action that involves a tunnel metadata subfield is > > > dumpped from vswitchd, the replied

Re: [ovs-dev] [PATCH 0/6] Fix tunnel information destination port

On Tue, Jan 10, 2017 at 04:48:28PM +, Alin Serdean wrote: > Deploying a simple environment using VXLAN encapsulation at the moment > does not work under Hyper-V. The tunnel information sent > by the userspace is not fully treated in the datapath. > > To be more specific every packet that

Re: [ovs-dev] [PATCH 3/3] rhel: Fix ifup and ifdown after DPDK naming change.

On Tue, Jan 24, 2017 at 06:21:53PM -0800, Daniele Di Proietto wrote: > Names like dpdk0 and dpdk1 are not enough to identify a DPDK interface. > We could update README.RHEL.rst and add > > OVS_EXTRA='set Interface ${DEVICE} options:dpdk-devargs=:01:00.0' > > but a better solution is to add

Re: [ovs-dev] [PATCH] ofp-actions: Fix tunnel meatdata subfield length in flow action

On Mon, Jan 09, 2017 at 06:09:33PM -0800, Yi-Hung Wei wrote: > Previously, if a flow action that involves a tunnel metadata subfield is > dumpped from vswitchd, the replied subfield length in the OXM header is > filled with the maximum possible field length, instead of the length > configured in

Re: [ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

Great, I'll have a look. On Thu, Feb 02, 2017 at 11:50:17PM +, John McDowall wrote: > Ben, > > Posted an updated patch – then downloaded it from patchwork and applied to > top to tree and ran make check and all tests passed. > > Regards > > John > > On 1/

[ovs-dev] [PATCH 1/2] netdev: Reject empty names in netdev_open().

for those devices and every other kind. Reported-by: Gabor Locsei <gabor.loc...@ericsson.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-February/043613.html Signed-off-by: Ben Pfaff <b...@ovn.org> --- lib/netdev.c | 10 +- 1 file changed, 9 inse

[ovs-dev] [PATCH 2/2] ovs-vsctl: Disallow empty bridge, port, and interface names.

Reported-by: Gabor Locsei <gabor.loc...@ericsson.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-February/043613.html Signed-off-by: Ben Pfaff <b...@ovn.org> --- tests/ovs-vsctl.at| 12 utilities/ovs-vsctl.c | 12 2 files

Re: [ovs-dev] [ovs-dev, RFC] ovn: support for service function chaining

:17:05PM +, John McDowall wrote: > Ben, > > Thanks for the thorough review, I will update the code and resubmit the > patch. Any thoughts on the general approach to service chaining etc? > > Regards > > John > > On 2/3/17, 2:10 PM, "Ben Pfaff" <b

Re: [ovs-dev] [PATCH 2/2] ovs-vsctl: Disallow empty bridge, port, and interface names.

On Fri, Feb 03, 2017 at 01:58:14PM -0800, Andy Zhou wrote: > On Fri, Feb 3, 2017 at 9:06 AM, Ben Pfaff <b...@ovn.org> wrote: > > Reported-by: Gabor Locsei <gabor.loc...@ericsson.com> > > Reported-at: > > https://mail.openvswitch.org/pipermail/ovs-discuss/2017-Fe

Re: [ovs-dev] [ovs-dev, RFC] ovn: support for service function chaining

On Thu, Feb 02, 2017 at 03:22:56PM -0800, jmcdow...@paloaltonetworks.com wrote: > From: John McDowall > > This patchset is the first round at having Service Function Chaining > functionality through OVN. The implementation is done entirely > on the northbound side

Re: [ovs-dev] [PATCH] ovn: fix slave node can not connect to the master node using SSL, for pacemaker

On Tue, Jan 31, 2017 at 03:44:38PM -0800, Andy Zhou wrote: > On Wed, Jan 11, 2017 at 4:11 AM, Guoshuai Li wrote: > > The default slave node connect to the master node using TCP, and the > > pacemaker > > can not modify the protocol and port of the connection. > > Add pacemaker

Re: [ovs-dev] [PATCH v3 1/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On Thu, Jan 26, 2017 at 03:22:24PM +, Zoltán Balogh wrote: > From: Sugesh Chandran > > Openvswitch datapath recirculates packets for tunneling, i.e. > the incoming packets are encapsulated at first pass. Further actions are > applied on encapsulated packets on the

Re: [ovs-dev] [PATCH] netlink-socket: Fix possiblity of nl_transact dereferncing null pointer

On Tue, Jan 31, 2017 at 08:40:08AM +0200, Roi Dayan wrote: > Many nl_transact callers and its wrapper tc_transact pass NULL for replyp > which is being accessed in error flow without being checked if null or not. > > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey

Re: [ovs-dev] [PATCH v2] packet: proper return type for vlan_tci_to_pcp()

nge of this patch is in lib/packets.h, where the return type of > vlan_tci_to_pcp() and vlan_tci_to_cfi() are changed from int to uint8_t. > > Changes to the format specifiers are for portability to mac OS and > consistency use of PRIu* specifiers. > > On Sat, Jan 14, 2017 at 8:47 AM, Be

[ovs-dev] [PATCH 1/2] ovn-controller: Fix memory leak and bug in setup_qos().

The caller of netdev_get_qos() is responsible for freeing its 'details' smap. Also, the previous qdisc details, for some arbitrary previous type of QoS, aren't relevant for changing the type of QoS. Signed-off-by: Ben Pfaff <b...@ovn.org> --- ovn/controller/binding.c | 7 +-- 1 file c

Re: [ovs-dev] [branch-2.7] Prepare for 2.7.0.

On Tue, Jan 31, 2017 at 05:47:45PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] odp: Add datapath clone action parser.

On Tue, Jan 31, 2017 at 08:24:02PM -0800, Andy Zhou wrote: > When adding userspace datapath clone action, the corresponding odp > actions parser and unit tests were missing. This patch adds them. > > Reported-by: Ben Pfaff <b...@ovn.org> > Signed-off-by: Andy Zhou <az...@

[ovs-dev] [PATCH 2/2] ovn-controller: Configure interface QoS only if it would actually be used.

s/2017-February/043564.html Signed-off-by: Ben Pfaff <b...@ovn.org> --- ovn/controller/binding.c | 41 +++-- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c index 1c02efd..2d2da16 100644 --

Re: [ovs-dev] [PATCH v2] windows: wmi add include

On Wed, Feb 01, 2017 at 12:56:44AM +, Alin Serdean wrote: > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Tuesday, January 31, 2017 11:35 PM > > To: Alin Serdean <aserd...@cloudbasesolutions.com> > > Cc: d...@op

[ovs-dev] [PATCH 3/4] jsonrpc: Fix capitalization of parameter name.

Signed-off-by: Ben Pfaff <b...@ovn.org> --- lib/jsonrpc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/jsonrpc.h b/lib/jsonrpc.h index 5f46e3b..982017a 100644 --- a/lib/jsonrpc.h +++ b/lib/jsonrpc.h @@ -125,7 +125,7 @@ void jsonrpc_session_enable_reconnect(

[ovs-dev] [PATCH] ofctrl: Free contents of symbol table in ofctrl_destroy().

This fixes a memory leak, although it was not a significant leak because the symbol table is in use until shortly before ovn-controller exits. Reported-by: William Tu <u9012...@gmail.com> Signed-off-by: Ben Pfaff <b...@ovn.org> --- ovn/controller/ofctrl.c | 1 + 1 file changed,

Re: [ovs-dev] how ovs implements QoS funtion

On Wed, Feb 08, 2017 at 06:27:59PM +0800, lg.yue wrote: > Ben Pfaff, Hi: > i have to make it clear that QoS here refers to bandwidth > limitation(TC), rather than dscp or tos. what i want to do is to limit the > bandwidth of vif and ovn's router port. > allocate_

Re: [ovs-dev] [PATCH] ofctrl: Free contents of symbol table in ofctrl_destroy().

Thanks, applied to master and branch-2.7. On Wed, Feb 08, 2017 at 10:46:29AM -0800, William Tu wrote: > thanks! I tested it and found no problem. > > On Wed, Feb 8, 2017 at 8:40 AM, Ben Pfaff <b...@ovn.org> wrote: > > This fixes a memory leak, although it was not a sig

Re: [ovs-dev] [PATCHv2 2/2] ovs-ofctl: fix memory leak reported by valgrind.

On Wed, Feb 08, 2017 at 11:24:28AM -0800, Andy Zhou wrote: > On Wed, Feb 8, 2017 at 7:03 AM, William Tu wrote: > > Testcase 1057 ofproto-dpif - fragment handling - upcall reports > > the following leak: > > xrealloc (util.c:123) > > vconn_dump_flows (vconn.c:1030) > >

Re: [ovs-dev] [PATCH 4/4] uuid: New macro UUID_ZERO for an all-zero expression or initializer.

On Wed, Feb 08, 2017 at 11:29:19AM -0800, Andy Zhou wrote: > On Wed, Feb 8, 2017 at 8:32 AM, Ben Pfaff <b...@ovn.org> wrote: > > This is convenient in expressions, e.g. "uuid = x ? *x : UUID_ZERO;". > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> &g

Re: [ovs-dev] [PATCH 2/3] ovsdb: Add OVSDB server per instance UUID.

replicating itself. > > Signed-off-by: Andy Zhou <az...@ovn.org> I don't think I'd bother with ovsdb_server_get_uuid() being inline, since it's not a fast path. Maybe it's not worth having a helper, in fact. Acked-by: Ben Pfaff <b...@ovn.org>

Re: [ovs-dev] [PATCH 3/3] ovsdb: Prevent OVSDB server from replicating itself.

On Wed, Feb 08, 2017 at 03:15:51PM -0800, Andy Zhou wrote: > On Wed, Feb 8, 2017 at 11:40 AM, Ben Pfaff <b...@ovn.org> wrote: > > In replication_init(), I'd use "=" to copy the uuid, instead of > > memcpy(). > > > O.K. I will use the brand spanking new

Re: [ovs-dev] [PATCH 1/1] OVN: Firewall service files for OVN

On Wed, Feb 01, 2017 at 09:59:22AM +0100, Marcin Mirecki wrote: > From adeba4e31c616f2212a0d8f5bac173ed1d42552a Mon Sep 17 00:00:00 2001 > From: Marcin Mirecki > Date: Tue, 31 Jan 2017 16:33:36 +0100 > Subject: [PATCH] Firewall service files for OVN > > Firewall service

Re: [ovs-dev] [PATCH] ofproto: Uses the VLOG_WARN_RL instead of VLOG_WARN.

On Mon, Feb 06, 2017 at 05:38:07AM -0800, nickcooper-zhangtonghao wrote: > There are a lot of logs when OvS bridges, connected to controllers, > can't find the right routes. So we may use the VLOG_WARN_RL instead > of VLOG_WARN to limit the log messages. The netdev-open and > arp-lookingup are in

[ovs-dev] OVS 2.7 release coming up Feb. 17

According to our previous discussion: https://mail.openvswitch.org/pipermail/ovs-dev/2016-December/326025.html the OVS 2.7 release should happen around Feb. 17, which is 10 days from today. I don't currently know of problems that would hold up the release. If anyone knows of them, please

Re: [ovs-dev] [urgent] is there anyway to enable multi-vlan for one vm upon ovs ?

ble multi-vlan for one vm upon > openvswitch" :) > > > regards! > > > -- Original -- > From: "Ben Pfaff";<b...@ovn.org>; > Date: Tue, Jan 24, 2017 00:21 AM > To: "xiucai"<hualing...@foxmail.com>; > Cc: "ovs-dev"<

Re: [ovs-dev] [PATCH 2/4 v4] lib:Data structures: Skiplist implementation

On Wed, Dec 28, 2016 at 07:41:46PM +, Rodriguez Betancourt, Esteban wrote: > Skiplist implementation intended for the IDL compound indexes > feature. > > Signed-off-by: Esteban Rodriguez Betancourt Thanks! Is there a value to having max_levels as a configurable parameter

Re: [ovs-dev] [PATCH v2] windows: wmi add include

On Mon, Jan 30, 2017 at 07:42:31AM +, Alin Serdean wrote: > Add 'util.h' to includes otherwise the result of the function > 'ovs_format_message' will be unknown and be converted to int, > triggering an abort of vswitchd. Is there a way to make MSVC fail the compile if a function is called

Re: [ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

On Fri, Jan 27, 2017 at 11:49:25AM -0800, Mickey Spiegel wrote: > On Fri, Jan 27, 2017 at 11:16 AM, Guru Shetty wrote: > > > > >> > >> I should clarify that statement. It is a good thing if the chassis > >> changes, for example if doing simple high availability. The GARP > >>

Re: [ovs-dev] [PATCH] appveyor: Bump OpenSSL version

On Tue, Jan 31, 2017 at 10:00:51PM +, Alin Serdean wrote: > The URL https://slproweb.com/download/Win32OpenSSL-1_0_2j.exe is > no longer valid. > > Bump to the variables to the latest version of OpenSSL version. > > Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

wrote: > Ben, > > Let me create a new patch set against the top of tree. > > Regards > > John > > On 1/31/17, 1:46 PM, "Ben Pfaff" <b...@ovn.org> wrote: > > On Tue, Dec 27, 2016 at 02:11:43PM -0800, John McDowall wrote: > > This is the

Re: [ovs-dev] [PATCH] ovn: Support ARP proxy in logical switches.

On Thu, Jan 05, 2017 at 12:33:51AM -0800, Han Zhou wrote: > On Wed, Jan 4, 2017 at 3:29 PM, Ben Pfaff <b...@ovn.org> wrote: > > However, I'm concerned about the general utility here. I usually think > > of proxy ARP as being used for the kinds of applications you see in the &

Re: [ovs-dev] [PATCH v2] ovn-controller: Provide the option to set Encap.options:csum

On Sun, Jan 15, 2017 at 12:36:09PM +0530, Numan Siddique wrote: > ovn-controller by default enables tunnel encapsulation checksums > for geneve tunnels. With this patch user can set the desired value > in Open_vSwitch.external_ids:ovn_encap_csum. > > This option will be useful in cases where

[ovs-dev] branching commits

Hi Justin. We branched a couple of weeks ago but at the time we forgot to update NEWS, etc. either on master or the branch. Usually you submit those patches; do you want to do the honors this time too? Thanks, Ben. ___ dev mailing list

Re: [ovs-dev] [PATCH 3/4 v4] ovsdb-idl: IDL Compound Indexes Implementation

On Wed, Dec 28, 2016 at 07:41:48PM +, Rodriguez Betancourt, Esteban wrote: > In the C IDL, allows to create multicolumn indexes in the > tables, that are keep synched with the data in the replica. > > Signed-off-by: Esteban Rodriguez Betancourt "git am" refuses to apply

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Fix memory leak and bug in setup_qos().

On Thu, Feb 02, 2017 at 12:44:02PM +0530, Numan Siddique wrote: > On Wed, Feb 1, 2017 at 10:52 PM, Ben Pfaff <b...@ovn.org> wrote: > > > The caller of netdev_get_qos() is responsible for freeing its 'details' > > smap. > > > > > Is this patch a good candida

Re: [ovs-dev] [PATCH] ovn-trace: Style improvements.

On Thu, Feb 02, 2017 at 02:18:31AM -0500, Russell Bryant wrote: > On Fri, Jan 13, 2017 at 2:30 PM, Ben Pfaff <b...@ovn.org> wrote: > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > --- > > ovn/utilities/ovn-trace.c | 12 +--- > > 1

Re: [ovs-dev] [PATCH v2] ovn-controller: Provide the option to set Encap.options:csum

On Thu, Feb 02, 2017 at 10:40:31AM -0500, Russell Bryant wrote: > On Thu, Feb 2, 2017 at 10:32 AM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Wed, Feb 1, 2017 at 4:31 AM, Ben Pfaff <b...@ovn.org> wrote: > > > > > On Sun, Jan 15, 2017 at

Re: [ovs-dev] [PATCH] ovn: Add missing netdev_close in setup_qos.

"ovn-controller: Configure interface QoS only if it > would actually be used.") > Signed-off-by: Russell Bryant <russ...@ovn.org> Thank you! Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] docs: Add OVS and OVN headings to pages.

e" page as it seems quite relevant > there. > > Signed-off-by: Russell Bryant <russ...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Configure interface QoS only if it would actually be used.

On Thu, Feb 02, 2017 at 01:33:36AM -0500, Russell Bryant wrote: > On Wed, Feb 1, 2017 at 12:22 PM, Ben Pfaff <b...@ovn.org> wrote: > > > Until now, ovn-controller has unconditionally configured linux-htb on > > physical interfaces. QoS is pretty much always tro

Re: [ovs-dev] [PATCH] tests: MPLS translate causes issues on slow systems

On Wed, Feb 01, 2017 at 02:39:36PM +, Alin Serdean wrote: > On slow systems ofproto/trace in combination with a recirculation ID > causes issues because the flow is evicted before the second packet > can reach it. Thanks, applied to master, branch-2.7, and branch-2.6.

Re: [ovs-dev] [PATCH] system-ovn.at: Fix race conditions.

.@ovn.org> > Reported-by: Joe Stringer <j...@ovn.org> > Signed-off-by: Gurucharan Shetty <g...@ovn.org> Seems reasonable, thank you! Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC PATCH 1/5] OVN: SFC Implemnentation - documentation for SFC ACL Action

On Tue, Dec 27, 2016 at 02:11:42PM -0800, John McDowall wrote: > This is minor changes to documentation to support additional ACL action. > > Co-authored-by: Flavio Fernandes > Reported at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2016-March/040381.html > Reported at: >

[ovs-dev] Zong Kai Li's patches

Hi Justin, I believe that you were planning to review Zong Kai Li's OVN patches that have been languishing since October: https://patchwork.ozlabs.org/project/openvswitch/list/?submitter=69084 Are you still planning to review them? ___ dev

Re: [ovs-dev] [RFC PATCH] Pipeline packet processing in OVS using FVL flow director.

> > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Friday, January 13, 2017 5:06 PM > > To: Chandran, Sugesh <sugesh.chand...@intel.com> > > Cc: 'd...@openvswitch.org' <d...@openvswitch.org>; 'ro...@mellanox.com' &g

Re: [ovs-dev] [PATCH] documentation: Windows support multiple VTEP/NICs

Applied, thanks Sairam and Alin! On Fri, Jan 27, 2017 at 07:58:09AM +, Sairam Venugopal wrote: > Acked-by: Sairam Venugopal > > > > > > On 1/26/17, 6:30 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin > Serdean"

Re: [ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

On Tue, Dec 27, 2016 at 02:11:43PM -0800, John McDowall wrote: > This is the major body of code that implements SFC. There is a new L2 stage > added to > perform the chaining operations and modifications to the ACL stage to direct > flows > to the service chain. > > Co-authored-by: Flavio

Re: [ovs-dev] [PATCH V2] netdev-dpdk: fix ifindex assignment for DPDK ports

On Thu, Dec 08, 2016 at 01:16:22PM +0100, Przemyslaw Lal wrote: > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index de78ddd..ef99eb3 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -2075,7 +2075,13 @@ netdev_dpdk_get_ifindex(const struct netdev *netdev) > int ifindex;

Re: [ovs-dev] [PATCH] ofproto-dpif: Reduce the time of creating large mount of bridges

On Tue, Jan 17, 2017 at 12:45:00PM +, zhangsha (A) wrote: > From e7623970cd71f8af7c3849a5beff87fd31fbdf68 Mon Sep 17 00:00:00 2001 > From: Sha Zhang > Date: Tue, 17 Jan 2017 11:34:24 +0800 > Subject: [PATCH] ofproto-dpif: Reduce the time of creating large mount of >

[ovs-dev] [PATCH v3 3/8] actions: Add new OVN action "clone".

Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 5 ++-- ovn/lib/actions.c | 61 --- ovn/ovn-sb.xml| 10 ovn/utilities/ovn-

[ovs-dev] [PATCH v3 4/8] actions: Separate action structures for "next" and "ct_next".

These actions aren't very similar but until now they both had the same action structure. These structures are going to diverge in an upcoming commit, so separate them now. Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/ac

[ovs-dev] [PATCH v3 7/8] actions: Make "next" action able to jump from egress to ingress pipeline.

This feature is useful for centralized gateways. Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 63 -- ovn/controller/lflow.c| 7 +++-- ovn/lib/actions.c

[ovs-dev] [PATCH v3 5/8] actions: Omit table number when possible for formatting "next" action.

ng it would be distracting. So it's better to store some context to help with formatting. This commit begins adopting that policy for the existing table number field. Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h

Re: [ovs-dev] [PATCH v3 1/8] ovn-trace: Fix selection of table that "next" jumps to.

On Sat, Jan 21, 2017 at 12:17:42PM -0800, Mickey Spiegel wrote: > On Sat, Jan 21, 2017 at 11:13 AM, Ben Pfaff <b...@ovn.org> wrote: > > > The common case is that "next" advances to the next table, but it can > > jump to any table. > > > > Repo

Re: [ovs-dev] [PATCH v3 7/8] actions: Make "next" action able to jump from egress to ingress pipeline.

On Sat, Jan 21, 2017 at 12:18:59PM -0800, Mickey Spiegel wrote: > On Sat, Jan 21, 2017 at 11:13 AM, Ben Pfaff <b...@ovn.org> wrote: > > > This feature is useful for centralized gateways. > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > Acked

Re: [ovs-dev] [PATCH v2 4/7] actions: Omit table number when possible for formatting "next" action.

On Fri, Jan 20, 2017 at 04:27:04PM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 2:48 PM, Ben Pfaff <b...@ovn.org> wrote: > > > Until now, formatting the "next" action has always required including > > the table number, because the action struct di

Re: [ovs-dev] [PATCH v2 6/7] actions: Make "next" action able to jump from egress to ingress pipeline.

On Fri, Jan 20, 2017 at 04:59:57PM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 2:48 PM, Ben Pfaff <b...@ovn.org> wrote: > > > This feature is useful for centralized gateways. > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > > >

Re: [ovs-dev] [PATCH 00/10] Add actions for egress loopback

On Fri, Jan 20, 2017 at 04:00:34PM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 3:33 PM, Ben Pfaff <b...@ovn.org> wrote: > > > On Fri, Jan 20, 2017 at 03:17:19PM -0800, Mickey Spiegel wrote: > > > On Fri, Jan 20, 2017 at 2:43 PM, Ben Pfaff <b...@ovn.org>

[ovs-dev] [PATCH v3 8/8] actions: Add new "ct_clear" action.

Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 1 + ovn/lib/actions.c | 16 ovn/ovn-sb.xml| 4 ovn/utilities/ovn-trace.c | 1 + tests/ovn.at | 4 +

Re: [ovs-dev] [urgent] is there anyway to enable multi-vlan for on vm upon ovs ?

On Sun, Jan 22, 2017 at 05:18:48PM +0800, xiucai wrote: > hi, > everyone :) > > > in my case, there is one vm for storage sharing, we name it SVM, and > several VMs as testing client. > for historic reasons, i can not modify the network which uses vlan upon > ovs. > > > the

Re: [ovs-dev] [PATCH] doc: Remove tutorials/ovn-basics.

On Mon, Jan 23, 2017 at 09:02:07AM -0500, Russell Bryant wrote: > On Thu, Jan 19, 2017 at 6:01 PM, Ben Pfaff <b...@ovn.org> wrote: > > > On Thu, Jan 19, 2017 at 02:17:09PM -0500, Russell Bryant wrote: > > > The only thing worse than a lack of documentation is inc

Re: [ovs-dev] [PATCH v2] ovn: Document upgrade procedure.

On Mon, Jan 23, 2017 at 09:50:02AM -0500, Russell Bryant wrote: > Signed-off-by: Russell Bryant <russ...@ovn.org> Thanks Russell! s/its/it's/ here: > +You should start by upgrading ovn-controller on each host its running on. Acked-by: Ben Pfaff &

[ovs-dev] [PATCH] ovs-fields.7: Use a more general approach to groff encodings.

It turns out that, since groff 1.20 around 2009, groff comes with a preprocessor named "preconv" that can fix encoding issues. Use it instead of the existing hack. Signed-off-by: Ben Pfaff <b...@ovn.org> --- build-aux/extract-ofp-fields | 8 lib/automake.mk

Re: [ovs-dev] [PATCH] Add ovs-fields.7 to lib/.gitignore

On Thu, Jan 26, 2017 at 06:37:42PM +, Alin Serdean wrote: > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean Thanks, applied to master and branch-2.7. ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH] ovs-fields: Eliminate non-ASCII characters from groff input.

It's difficult to make groff portably accept non-ASCII characters. It's easier to replace them by groff escapes for the same characters, which this commit does. Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.") Signed-off-by: Ben Pfaff <

Re: [ovs-dev] [PATCH 2/2] ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.

On Tue, Jan 24, 2017 at 05:13:15PM -0800, Justin Pettit wrote: > > > On Jan 24, 2017, at 5:11 PM, Justin Pettit wrote: > > > > This was a lot of work. Thanks for doing it! > > > > --Justin > > Whoops! > > Acked-by: Justin Pettit Thanks. I applied these

Re: [ovs-dev] [PATCH] extract-ofp-fields: Define .TQ directive in nroff output.

On Wed, Jan 25, 2017 at 11:10:19PM -0800, Daniele Di Proietto wrote: > 2017-01-25 20:31 GMT-08:00 Ben Pfaff <b...@ovn.org>: > > This missing directive caused groff warnings and probably some erroneous > > output too. > > > > Fixes: 96fee5e0a2a0 ("ovs-fields

[ovs-dev] [PATCH] extract-ofp-fields: Define .TQ directive in nroff output.

This missing directive caused groff warnings and probably some erroneous output too. Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.") Reported-by: Daniele Di Proietto <diproiet...@ovn.org> Signed-off-by: Ben Pfaff <b...@ovn.org>

Re: [ovs-dev] [PATCH 00/10] Add actions for egress loopback

On Fri, Jan 20, 2017 at 03:17:19PM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 2:43 PM, Ben Pfaff <b...@ovn.org> wrote: > > > On Fri, Jan 20, 2017 at 12:29:49PM -0800, Mickey Spiegel wrote: > > > On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff <b...@ovn.org&g

Re: [ovs-dev] [PATCH 05/10] actions: Add new OVN action "clone".

On Fri, Jan 20, 2017 at 11:17:53AM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff <b...@ovn.org> wrote: > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > > > Acked-by: Mickey Spiegel <mickeys@gmail.com> > > One comme

Re: [ovs-dev] [PATCH 00/10] Add actions for egress loopback

On Fri, Jan 20, 2017 at 12:29:49PM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff <b...@ovn.org> wrote: > > > I believe that, with these patches, egress loopback as proposed by Mickey's > > patches can be implemented with: > > clo

[ovs-dev] [PATCH v2 3/7] actions: Separate action structures for "next" and "ct_next".

These actions aren't very similar but until now they both had the same action structure. These structures are going to diverge in an upcoming commit, so separate them now. Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/ac

Re: [ovs-dev] [PATCH 07/10] actions: Omit table number when possible for formatting "next" action.

I did a bad job on this patch. I've rewritten it and will repost. On Fri, Jan 20, 2017 at 11:51:56AM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff <b...@ovn.org> wrote: > > > Until now, formatting the "next" action has always required in

Re: [ovs-dev] [PATCH 03/10] actions: Make "arp { drop; }; " acceptable.

On Fri, Jan 20, 2017 at 09:16:25AM -0800, Ben Pfaff wrote: > Before this commit, the OVN action parser would accept "arp {};" and then > the formatter would format it back as "arp { drop; };", but the parser > didn't accept the latter. There were basically two choi

[ovs-dev] [PATCH v2 0/7] Add actions for egress loopback

and 3 applied and dropped. - Acks applied to other patches. - Typo fixed in patch 5 (now patch 2). - Stupid bugs fixed in patch 7 (now patch 4). Ben Pfaff (7): actions: Make "free" functions per-struct, not per-action. actions: Add new OVN action "clone". actions: Sep

[ovs-dev] [PATCH v2 6/7] actions: Make "next" action able to jump from egress to ingress pipeline.

This feature is useful for centralized gateways. Signed-off-by: Ben Pfaff <b...@ovn.org> --- include/ovn/actions.h | 63 -- ovn/controller/lflow.c| 7 +++-- ovn/lib/actions.c | 70 --- o

[ovs-dev] [PATCH v2 5/7] actions: Introduce enum ovnact_pipeline.

This isn't used yet by the actions code, but an upcoming commit will introduce a user. This commit just adjusts ovn-trace to use this common type instead of its own local type. Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- include/o

Re: [ovs-dev] [PATCH] lib: Remove generated ovs-fields.7 manpage on make clean.

On Thu, Jan 26, 2017 at 02:36:41PM -0800, Joe Stringer wrote: > On 26 January 2017 at 11:28, Ben Pfaff <b...@ovn.org> wrote: > > Found by travis. > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > Acked-by: Joe Stringer <j...@ovn.org&

Re: [ovs-dev] [PATCH] ovs-appctl: Document -T and --timeout options.

On Thu, Feb 23, 2017 at 04:16:41PM -0500, Russell Bryant wrote: > On Thu, Feb 23, 2017 at 4:09 PM, Ben Pfaff <b...@ovn.org> wrote: > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > --- > > utilities/ovs-appctl.8.in | 12 ++-- > > 1 f

Re: [ovs-dev] [PATCH] ofproto: Remove 'ofproto/self-check' from ovs-vswitchd manpage

On Tue, Feb 21, 2017 at 12:13:42PM +0100, Timothy Redaelli wrote: > ofproto/self-check was removed in commit e79a6c83, so this patch > removes the man page item. > > Signed-off-by: Timothy Redaelli Thanks, I applied this to master and backported it as far as branch-2.4.

[ovs-dev] [PATCH] ovs-appctl: Document -T and --timeout options.

Signed-off-by: Ben Pfaff <b...@ovn.org> --- utilities/ovs-appctl.8.in | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-appctl.8.in b/utilities/ovs-appctl.8.in index 645b62b4be99..43c9a9517a86 100644 --- a/utilities/ovs-appctl.8.in +++ b/utiliti

Re: [ovs-dev] [PATCH] [RFC] ovsdb: Add aspirational documentation for clustering.

On Thu, Feb 23, 2017 at 12:02:04PM -0800, Han Zhou wrote: > On Fri, Feb 17, 2017 at 5:10 PM, Ben Pfaff <b...@ovn.org> wrote: > > > + > > +Clusters larger than 5 servers will also work, with every 2 added > > +servers allowing the clus

Re: [ovs-dev] [branch-2.7] Set release date for 2.7.0.

On Tue, Feb 21, 2017 at 01:59:23PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.5 1/2] Set release date for 2.5.2.

On Tue, Feb 21, 2017 at 02:42:35PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.5 2/2] Prepare for 2.5.3.

On Tue, Feb 21, 2017 at 02:42:36PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] manpages in rst?

On Fri, Feb 17, 2017 at 07:34:10AM -0500, Stephen Finucane wrote: > On Thu, 2017-02-16 at 09:24 -0800, Ben Pfaff wrote: > > Currently, we have some manpages written directly in nroff.  This is > > an > > awful format, that is difficult to read and difficult to > >

Re: [ovs-dev] [PATCH] Remove build-time generated files when "make clean" is run.

kind of change, it's helpful to try "make distcheck". If that passes: Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] OVN: Preserving state between logical datapaths

On Thu, Feb 16, 2017 at 08:46:34PM +0500, Valentine Sinitsyn wrote: > Imagine you want to mark a packet in logical switch datapath then use this > mark in logical router datapath somehow (an artificial use-case would be > policy routing based on VM port, not destination IP address). > > Is there

Re: [ovs-dev] OVN: Preserving state between logical datapaths

On Fri, Feb 17, 2017 at 12:44:09AM +0500, Valentine Sinitsyn wrote: > On 16.02.2017 21:24, Ben Pfaff wrote: > >On Thu, Feb 16, 2017 at 08:46:34PM +0500, Valentine Sinitsyn wrote: > >>Imagine you want to mark a packet in logical switch datapath then use this > >>mark

Re: [ovs-dev] [PATCH] faq: Document OVS packet buffering.

Thanks, applied to master. On Wed, Jan 18, 2017 at 03:12:19PM -0800, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme <ja...@ovn.org> > > > On Jan 18, 2017, at 2:43 PM, Ben Pfaff <b...@ovn.org> wrote: > > > > We get questions about this sometimes.

Re: [ovs-dev] [PATCH] ovn-nbctl: Ability to bootstrap CA certificate.

thout having to > copy over the certificate being used by ovsdb-server > backing OVN NB. > > Signed-off-by: Gurucharan Shetty <g...@ovn.org> Seems like a good idea. Acked-by: Ben Pfaff <b...@ovn.org> ___ dev mailing list d...@openvswi

Re: [ovs-dev] [PATCH 2/2] libX: add new release / version info tags

> (0x7f733b7a3000) > libssl.so.10 => /lib64/libssl.so.10 (0x7f733b53) > ... > > Note the library name and version information. > > Signed-off-by: Aaron Conole <acon...@redhat.com> > --- > RFC to patch: > Incorporated feedback from

  1   2   3   4   5   6   7   8   9   10   >