[ovs-dev] [PATCH] [RFC] localport type support

PI support which relies on a local agent running on every hypervisor and serving metadata to VM's locally. This service is described in detail at [0]. TODO: write a test case for localport ports [0] https://review.openstack.org/#/c/452811/ Signed-off-by: Daniel Alvarez <dalva...@redhat.com> ---

[ovs-dev] [PATCH v3] netdev: check for NULL fields in netdev_get_addrs

checks that ifa_netmask is not NULL for coherence with the existing code so that it doesn't allocate more memory than needed if this field is NULL. Note, that these checks are already being done later in the function so it should be done in both places. Signed-off-by: Daniel Alvarez <da

[ovs-dev] [PATCH v4] OVN localport type support

p1 but not p2 - lp on HV2 should be able to reach p2 but not p1 Explicit drop rules are inserted in table 32 with priority 150 in order to prevent traffic originated at a localport to go over a tunnel. [0] https://review.openstack.org/#/c/452811/ Signed-off-by: Daniel Alvarez <dalva...@redhat.com&

[ovs-dev] [PATCH v3] OVN localport type support

tadata API support which relies on a local agent running on every hypervisor and serving metadata to VM's locally. This service is described in detail at [0]. [0] https://review.openstack.org/#/c/452811/ Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- ovn/controller/binding.c

[ovs-dev] [PATCH v5] OVN localport type support

p1 but not p2 - lp on HV2 should be able to reach p2 but not p1 Explicit drop rules are inserted in table 32 with priority 150 in order to prevent traffic originated at a localport to go over a tunnel. [0] https://docs.openstack.org/developer/networking-ovn/design/metadata_api.html Signed-off-by: Dan

[ovs-dev] [PATCH v3] Copy external_ids from Logical_Switch_Port to SB database

by networking-ovn-metadata-agent without the need of maintaining a connection to NB database. This data would include the CIDR's of a port or the project and device ID's which are needed when talking to Nova to request metadata. Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- ovn/nort

[ovs-dev] [PATCH v2 3/3] OVN localport type support

tadata API support which relies on a local agent running on every hypervisor and serving metadata to VM's locally. This service is described in detail at [0]. [0] https://review.openstack.org/#/c/452811/ Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- ovn/controller/binding.c

[ovs-dev] [PATCH v2 1/3] simap: New function simap_equal().

From: Ben Pfaff This will acquire a user in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/simap.c | 23 +-- lib/simap.h | 3 ++- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/lib/simap.c b/lib/simap.c index

[ovs-dev] [PATCH v2 2/3] physical: Simplify updating localvif_to_ofport map in physical_run()

From: Ben Pfaff These two loops were updating 'localvif_to_ports' to be the same as 'new_localvif_to_ports' and setting physical_map_changed if there had been any differences. This is more work than necessary, so this commit simplifies it. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH] Add dl_type to flow metadata for correct interpretation of conntrack metadata

can be interpreted correctly when packets are resumed. Reported-by: Daniel Alvarez Sanchez <dalva...@redhat.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-October/339868.html Signed-off-by: Daniel Alvarez <dalva...@redhat.com> Signed-off-by: Numan Siddique <nusi

[ovs-dev] [PATCH] Fix datapath compilation on RHEL >= 7.5

On RHEL 7.5 we get compilation errors due to field ndo_change_mtu missing. This patch checks the RHEL version and redefines it to ndo_change_mtu_rh74. Reported-by: Lucas Alvares <lucasago...@gmail.com> Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- datapath/datapath.h | 5 +

Re: [ovs-dev] [PATCH] Fix datapath compilation on RHEL >= 7.5

Yes, let’s go with that one then. Thanks a lot! Daniel > On 10 May 2018, at 23:15, Gregory Rose <gvrose8...@gmail.com> wrote: > >> On 5/10/2018 7:11 AM, Daniel Alvarez wrote: >> On RHEL 7.5 we get compilation errors due to field ndo_change_mtu >> missing. This

[ovs-dev] [PATCH] ovn-northd: Apply pre ACLs when using Port Groups

When using Port Groups, the pre ACLs were not applied so the conntrack action was not performed. This patch takes Port Groups into account when processing the pre ACLs. Signed-off-by: Daniel Alvarez --- ovn/northd/ovn-northd.c | 100 +++- 1 file

[ovs-dev] [PATCH v2] ovn-northd: Apply pre ACLs when using Port Groups

When using Port Groups, the pre ACLs were not applied so the conntrack action was not performed. This patch takes Port Groups into account when processing the pre ACLs. As a follow up, we could enhance this patch by creating an index from lswitch to port groups. Signed-off-by: Daniel Alvarez

[ovs-dev] [PATCH v2] Add dl_type to flow metadata for correct interpretation of conntrack metadata

Ethertypes (IPv4 and IPv6 currently), so we need to add it as a kind of prerequisite. (This isn't ideal; maybe we didn't think through the ct_state mechanism carefully enough.) Reported-by: Daniel Alvarez Sanchez <dalva...@redhat.com> Reported-at: https://mail.openvswitch.org/pipermail/o

[ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

avoids adding duplicate lflows into SB database so that ovn-controller doesn't have to process them. Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- This patch is needed as part of the consistency work we're doing in the OpenStack integration [0]. In our effort to ensure consistency

[ovs-dev] [PATCH] ovn-controller: Change duplicate flows trace from INFO to DBG

When ovn-controller detects that a flow is duplicated, it will print an INFO trace. Even though it's rate limited, this patch is changing the trace level back to DEBUG to reduce noise. Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- In our effort to ensure consistency across o

[ovs-dev] [PATCH v2] netdev: Retry getting interfaces on inconsistent dumps from kernel

is not changing the current behavior. [0] https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4 Signed-off-by: Daniel Alvarez Co-authored-by: Jiri Benc --- lib/netdev.c | 16 1 file changed, 16 insertions(+) Signed-off-by: Daniel Alvarez --- lib

[ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

is not changing the current behavior. [0] https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4 Signed-off-by: Daniel Alvarez Co-authored-by: Jiri Benc --- lib/netdev.c | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/netdev.c b/lib

[ovs-dev] [PATCH] netdev: Retry getting interfaces on inconsistent dumps from kernel

is not changing the current behavior. [0] https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4 Signed-off-by: Daniel Alvarez Signed-off-by: Jiri Benc --- lib/netdev.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/netdev.c b/lib/netdev.c

[ovs-dev] [PATCH] ovn-controller: add new external_id 'ovn-cms-options' to Chassis table

This patch makes ovn-controller sets the external_ids key 'ovn-cms-options' to its own Chassis table entry copying its contents from the same external_ids key in the local OpenvSwitch database. The idea behind this patch is to allow setting general options from the CMS Plugin to a particular

[ovs-dev] [PATCH v2] ovn-controller: add new external_id 'ovn-cms-options' to Chassis table

o schedule a router on. Similarly, this new key would allow to specify additional options to be consumed by the CMS. Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- ovn/controller/chassis.c| 13 - ovn/controller/ovn-controller.8.xml | 7 +++

[ovs-dev] [PATCH] ovsdb: Fix time in log traces when compacting database

seconds old, 951 transactions) Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- ovsdb/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/file.c b/ovsdb/file.c index 90c2b9d20..4b7ad52ab 100644 --- a/ovsdb/file.c +++ b/ovsdb/file.c @@ -655,7

[ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

. This patch eliminates it and now the time remains consant regardless of the database contents improving performance and scaling. Reported-by: Daniel Alvarez Sanchez <dalva...@redhat.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-February/046263.html Signed-off-by:

Re: [ovs-dev] [PATCH v2] python: avoid useless JSON conversion to enhance performance

Thanks! Would it be also possible to get it in in 2.9 branch as well please? > On 28 Feb 2018, at 22:09, Ben Pfaff <b...@ovn.org> wrote: > >> On Wed, Feb 28, 2018 at 10:11:09AM +0100, Daniel Alvarez wrote: >> This patch removes a useless conversion to/from JSON in

[ovs-dev] [PATCH v2] ovsdb: Fix database compaction check

-by: Daniel Alvarez <dalva...@redhat.com> --- ovsdb/file.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ovsdb/file.c b/ovsdb/file.c index 02e0e8b76..40192e30d 100644 --- a/ovsdb/file.c +++ b/ovsdb/file.c @@ -590,7 +590,7 @@ ovsdb_file_commit(struct ovsdb_r

[ovs-dev] [PATCH] ovsdb: Fix database compaction check

-by: Daniel Alvarez <dalva...@redhat.com> --- ovsdb/file.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ovsdb/file.c b/ovsdb/file.c index 02e0e8b76..333cd00a6 100644 --- a/ovsdb/file.c +++ b/ovsdb/file.c @@ -611,12 +611,12 @@ ovsdb_file_commit(struct ovsdb_r

Re: [ovs-dev] [PATCH v2] ovsdb: Fix database compaction check

Thanks Ben! Sorry for the confusion with the previous version, I forgot to commit the changes and sent the wrong version. > On 14 Mar 2018, at 23:21, Ben Pfaff <b...@ovn.org> wrote: > >> On Sat, Mar 10, 2018 at 02:50:14PM +0100, Daniel Alvarez wrote: >> We want

[ovs-dev] [PATCH] python: Trivial fix flake8 error

make flake8-check fails due to missing whitespaces around arithmetic operator. Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- utilities/ovs-pipegen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-pipegen.py b/utilities/ovs-pipegen.py index 8a2

[ovs-dev] [PATCH v2] python: avoid useless JSON conversion to enhance performance

. This patch eliminates it and now the time remains consant regardless of the database contents improving performance and scaling. Reported-by: Daniel Alvarez <dalva...@redhat.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-February/046263.html Signed-off-by: Daniel A

[ovs-dev] [PATCH] netdev: Add comment to allow removing a workaround in the future

=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4 [1] https://github.com/openvswitch/ovs/commit/3434d306866d825084d2d186d1f8dd98662ff650 Signed-off-by: Daniel Alvarez --- lib/netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/netdev.c b/lib/netdev.c index 84874408a..45b50f26c 100644 --- a/lib

Re: [ovs-dev] [PATCH] ovn: Fix indentation in TODO.

Thanks a lot folks! How about getting it into 2.10 branch? Would that be ok? > On 12 Dec 2018, at 21:08, Ben Pfaff wrote: > >> On Thu, Sep 20, 2018 at 04:44:11PM -0700, Ben Pfaff wrote: >> Some items listed under ovsdb-server should have been top-level items. >> >> Signed-off-by: Ben Pfaff >

[ovs-dev] [PATCH v2] ovn-controller: Inject GARPs to logical switch pipeline to update neighbors

. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047604.html Signed-off-by: Daniel Alvarez --- v1->v2 Fix VLAN tests to account for the GARPs received by the local pipeline. Remove localnet_ofports parameter as it's not used anymore. ovn/controller/pinctrl.c |

[ovs-dev] [PATCH] ovn-controller: Inject GARPs to logical switch pipeline to update neighbors

. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047604.html Signed-off-by: Daniel Alvarez --- ovn/controller/pinctrl.c | 62 ++-- tests/ovn.at | 100 +++ 2 files changed, 125 insertions(+), 37 deletions

[ovs-dev] [RFC] ovn-controller: Inject GARPs to logical switch pipeline to update neighbours

. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047604.html Signed-off-by: Daniel Alvarez --- ovn/controller/pinctrl.c | 61 +--- 1 file changed, 26 insertions(+), 35 deletions(-) diff --git a/ovn/controller/pinctrl.c b/ovn/controller

[ovs-dev] [PATCH] ovn: change load balancer references to weak in NB schema

the references manually. In particular, this will make things easier for networking-ovn, the OpenStack integration project as it'll save some calculations upon load balancer deletion. The update path has been successfully from the previous version of the schema. Signed-off-by: Daniel Alvarez --- ovn

[ovs-dev] [PATCH branch2.11] ovsdb-server: drop all connections on read/write status change

Signed-off-by: Daniel Alvarez Signed-off-by: Ben Pfaff --- ovsdb/jsonrpc-server.c | 2 +- tests/ovn.at | 21 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index 7c7a277f0..739e0e72e 100644 --- a/ovsdb

[ovs-dev] [PATCH] ovsdb-server: drop all connections on read/write status change

Signed-off-by: Daniel Alvarez --- ovsdb/jsonrpc-server.c | 2 +- tests/ovn.at | 21 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index 4dda63a9d..ddbbc2e94 100644 --- a/ovsdb/jsonrpc-server.c +++ b/ovsdb

[ovs-dev] [PATCH v2 branch-2.11] ovsdb-server: drop all connections on read/write status change

Signed-off-by: Daniel Alvarez Signed-off-by: Ben Pfaff --- ovsdb/jsonrpc-server.c | 2 +- tests/ovn.at | 21 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index 7c7a277f0..739e0e72e 100644 --- a/ovsdb

[ovs-dev] [PATCH branch-2.12] [ovn-northd] Don't emit ICMP need to frag on LRP with no IPv4 address

IPv4 address. Signed-off-by: Daniel Alvarez --- ovn/northd/ovn-northd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index ae09cf338..21e546d38 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -7855,7

[ovs-dev] [PATCH] [ovn-northd] Don't emit ICMP need to frag on LRP with no IPv4 address

IPv4 address. Signed-off-by: Daniel Alvarez --- ovn/northd/ovn-northd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index eb6c47cad..3542ba72f 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -7705,7

[ovs-dev] [PATCH] ovs-ctl: Don't set hostname as external-id

entities to configure it (unlike now), and 2) it's optional. In the case of OVN, if the external-id doesn't exist, it'll default to its hostname so nothing should get broken by this change. [0] https://mail.openvswitch.org/pipermail/ovs-dev/2016-March/312054.html Signed-off-by: Daniel Alvarez

Re: [ovs-dev] [PATCH] ovs-ctl: Don't set hostname as external-id

Thanks a lot Terry! > On 22 May 2020, at 23:28, Terry Wilson wrote: > >  > > >> On Wed, May 20, 2020 at 10:52 AM Daniel Alvarez wrote: >> ovs-ctl started to add the hostname as external-id [0] at some point. >> >> However, this can be problemati

[ovs-dev] [PATCH] ovs-ctl: Don't overwrite external-id hostname

://mail.openvswitch.org/pipermail/ovs-dev/2016-March/312054.html [1] https://mail.openvswitch.org/pipermail/ovs-dev/2020-May/370813.html Signed-off-by: Daniel Alvarez --- utilities/ovs-ctl.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index

Re: [ovs-dev] [PATCH v3] python: Allow tuning the session probe_interval from IDL

Acked-by: Daniel Alvarez <dalva...@redhat.coml> Looks good to me. Just a minor comment in case you need to submit another version of the patch: comments say that it will default to at least 1000 ms. In fact, it'll default to OVS minimum default value. If this changes at some point (un

Re: [ovs-dev] [PATCH v4 2/7] ovn: l3ha, NBDB and SBDB changes and documentation

Super nit comments while trying to go through the code. Very good work btw! Thanks a lot Miguel and Anil! On Wed, Jul 12, 2017 at 3:12 PM, Miguel Angel Ajo wrote: > From: "majop...@redhat.com" > > This commit introduces the north and south db changes

[ovs-dev] [PATCH] netdev: check for iface_name not NULL in netdev_get_addrs

, that this check is already being done later in the function so it should be done in both places. Signed-off-by: Daniel Alvarez <dalva...@redhat.com> --- I've been debugging a coredump produced by a segmentation fault of ovs-vswitchd. It seems to be caused by a NULL pointer passed to s

[ovs-dev] [PATCH v2] netdev: check for NULL fields in netdev_get_addrs

checks that ifa_netmask is not NULL for coherence with the existing code so that it doesn't allocate more memory than needed if this field is NULL. Note, that these checks are already being done later in the function so it should be done in both places. Signed-off-by: Daniel Alvarez <da

Re: [ovs-dev] [PATCH] netdev: check for iface_name not NULL in netdev_get_addrs

, Aaron Conole <acon...@redhat.com> wrote: > Daniel Alvarez Sanchez <dalva...@redhat.com> writes: > > > When the interfaces list is retrieved through getiffaddrs(), there > > might be elements with iface_name set to NULL. > > This patch checks iface_

Re: [ovs-dev] Revisit OVN meeting schedule?

On Wed, Jul 26, 2017 at 5:13 PM, Ben Pfaff wrote: > On July 26, 2017 8:07:57 AM PDT, Russell Bryant wrote: > >It has been difficult for some of our newer contributors in Europe to > >make our weekly OVN IRC meeting, so I wanted to revisit the schedule. > >Roughly

Re: [ovs-dev] [PATCH] OVN localport type support

e=14, priority=100,reg15=0x1,metadata=0x7 actions=load:0x7->NXM_NX_TUN_ID[0..23],set_field:0x1->tun_metadata0,move:NXM_NX_REG14[0..14]->NXM_NX_TUN_METADATA0[16..30],output:40 > On Tue, May 09, 2017 at 05:09:43PM +0200, Daniel Alvarez Sanchez wrote: > > Hi, > > > &g

Re: [ovs-dev] [PATCH] OVN localport type support

less it comes from lp1 (reg14=0x1) when it'll be dropped. On Fri, May 5, 2017 at 5:51 PM, Ben Pfaff <b...@ovn.org> wrote: > [oops, adding back the list] > > On Fri, May 05, 2017 at 08:51:01AM -0700, Ben Pfaff wrote: > > On Fri, May 05, 2017 at 02:58:45PM +0200, Daniel Al

Re: [ovs-dev] [PATCH v4] OVN localport type support

to drop output/forwarding > of packets? > > I like the idea... let's see what others say about this, I don't know how strict we want to be consuming bits from registers. Thanks Miguel for the suggestion :) > Best, > Miguel Ángel Ajo > > > > On Fri, May 19, 2017 at

Re: [ovs-dev] [PATCH v4] OVN localport type support

. Thanks once again! Daniel On Fri, May 26, 2017 at 6:46 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, May 23, 2017 at 03:13:08PM +0200, Daniel Alvarez Sanchez wrote: > > On Tue, May 23, 2017 at 10:01 AM, Miguel Angel Ajo Pelayo < > > majop...@redhat.com> wrote: >

Re: [ovs-dev] [PATCH v5] OVN localport type support

Great! Thanks a lot Ben :) On Tue, May 30, 2017 at 6:57 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, May 26, 2017 at 12:08:43PM +0000, Daniel Alvarez wrote: > > This patch introduces a new type of OVN ports called "localport". > > These ports will be present i

Re: [ovs-dev] ovs-vswitchd is resetting the MTU of a bridge when a patch port is deleted.

Yes, thanks Numan for the patch :) Another option would be that ovn-controller sets explicitly the MTU to 1450. Not sure which of the two is the best or would have less side effects. Cheers, Daniel On Tue, Sep 12, 2017 at 10:43 AM, Numan Siddique wrote: > Hello, > > Daniel

[ovs-dev] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

System information: === OS: CentOS Linux release 7.3.1611 (Core) Kernel version: 3.10.0-693.2.2.el7.x86_64 #1 SMP OVS version: v2.8.1 (git tag) #ovs-vswitchd --version ovs-vswitchd (Open vSwitch) 2.8.1 Bug description: Right now, OVN doesn't work using OVS 2.8.1 on

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

Acked-by: Daniel Alvarez <dalva...@redhat.com> >From [0] one can expect this column to be present in all tables. [0] https://github.com/openvswitch/ovs/blob/v2.8.1/ovn/ovn-nb.xml#L19 On Mon, Dec 4, 2017 at 2:16 PM, <lmart...@redhat.com> wrote: > From: Lucas Alvares Gomes <

Re: [ovs-dev] [ovs-discuss] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

Hi guys, Great job Numan! As we discussed over IRC, the patch below may make more sense. It essentially sets the dl_type so that when packet comes from the controller, it matches a valid type and OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV4 is not added. Maybe what Numan proposed and this patch could be a

Re: [ovs-dev] [ovs-discuss] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

On Tue, Oct 24, 2017 at 11:35 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Oct 24, 2017 at 02:27:59PM -0700, Ben Pfaff wrote: > > On Tue, Oct 24, 2017 at 11:07:58PM +0200, Daniel Alvarez Sanchez wrote: > > > Hi guys, > > > > > > Great job Numan! >

Re: [ovs-dev] [PATCH] ovn: Add a new action 'nd_na_router' to handle NS requests for router IPs

On Tue, May 8, 2018 at 3:26 PM, Mark Michelson wrote: > On 05/08/2018 05:36 AM, Numan Siddique wrote: > >> >> >> On Tue, May 8, 2018 at 1:20 PM, Miguel Angel Ajo Pelayo < >> majop...@redhat.com > wrote: >> >> Thank you Numan! >> >> It took

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

an OVS internal port connected to br-ex, then I don't see the checksum problems. Acked-by: Daniel Alvarez <dalva...@redhat.com> Tested-by: Daniel Alvarez <dalva...@redhat.com> On Thu, May 17, 2018 at 1:27 PM, <lucasago...@gmail.com> wrote: > From: Lucas Alvares Gomes &

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

> majop...@redhat.com> > > wrote: > > > >> Acked-by: Miguel Angel Ajo > >> > >> On Wed, Feb 28, 2018 at 9:13 AM Daniel Alvarez Sanchez < > >> dalva...@redhat.com> wrote: > >> > >>> Thanks Terry and Han for the reviews! >

Re: [ovs-dev] [PATCH] ovn-northd: Apply pre ACLs when using Port Groups

Thanks a lot Han for the review. Just sent the v2 with the test fixed. I'll leave the hash index for a follow up as I'm short in time but if you want to edit my patch feel free to do it or send another one. Thanks again for the Port Groups implementation! :) Cheers, Daniel On Wed, Jun 20, 2018

Re: [ovs-dev] [ovs-discuss] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

d, Oct 25, 2017 at 3:09 PM, Daniel Alvarez Sanchez < > dalva...@redhat.com > > > wrote: > > > > > > > > > > > On Tue, Oct 24, 2017 at 11:35 PM, Ben Pfaff <b...@ovn.org> wrote: > > > > > >> On Tue, Oct 24, 2017 at 02:27:59PM

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

dhat.com > > > > wrote: > > > > > > > Right! > > > > > > > > We didn't hit that issue, but it'd make sense to fix in this patch I > > guess. > > > > > > > > We could modify the hashing function to not include th

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

Thanks for the patch, Ben. Looks good to me. Acked-by: Daniel Alvarez <dalva...@redhat.com> On Sat, Feb 3, 2018 at 12:16 AM, Ben Pfaff <b...@ovn.org> wrote: > Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd > due to a similar patch. > > Rep

[ovs-dev] [OVN][Request] New OVS 2.8 tag

Hi folks, It'd be great if we could have 2.8.2 tag so that we can benefit from some patches that we would require in OVN and its OpenStack integration such as: * OVN: Add external_ids to NAT and Logical_Router_Static_Route tables [0] * ovn-northd; Treat logical ports of router type as always

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

+1 for the split of the ML On Mon, Aug 13, 2018 at 11:17 AM Lucas Alvares Gomes wrote: > Hi, > > > Before starting in-depth technical discussions on this list or the > > ovs-dev list, I'm curious if people would be interested in splitting off > > a separate OVN list for this and future

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

Mon, Aug 13, 2018 at 05:39:07PM -0700, Ben Pfaff wrote: > > On Mon, Aug 13, 2018 at 02:07:45PM +0200, Daniel Alvarez wrote: > > > This patch in glibc [0] is fixing a bug where we may be getting > > > inconsistent dumps from the kernel when listing interfaces du

Re: [ovs-dev] [PATCH v3] ovn.at: Add stateful test for ACL on port groups.

ied packet expr and removed > > debug information. > > - Renamed test_ip to test_icmp. > > v2->v3: > > - Updated comments. > > > > tests/ovn.at | 69 > ++-- > > 1 file changed, 48 i

Re: [ovs-dev] [PATCH] ovsdb: Correctly log time since last compaction.

to be computed relative to that clock, not against wall clock time. > > > > This only affected the log message, not the decision about when to > > compact. > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > Reported-by: Daniel Alvarez Sanchez <dalva...@re

Re: [ovs-dev] [PATCH 2/2] ovn: Support address sets generated from port groups

tapath_binding > +as hv1 ovn-sbctl list port_group > +as hv1 ovn-sbctl list address_set > +as hv1 ovn-sbctl dump-flows > +as hv1 ovs-ofctl dump-flows br-int > nit: We can remove this block. > + > +# Send IP packets between all pairs of source and destination ports, > +#

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

;> set table. This way it will also benefit for a follow up patch that > > >> enables generating address sets automatically from port groups to > > >> avoid a lot a trouble from client perspective [2]. > > >> > > >> [1] https://mail.openvswitch.org/

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

also benefit for a follow up patch that > enables generating address sets automatically from port groups to > avoid a lot a trouble from client perspective [2]. > > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2016-August/077118.html > [2] https://mail.openvswitch.org/pip

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

enefit for a follow up patch that > enables generating address sets automatically from port groups to > avoid a lot a trouble from client perspective [2]. > > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2016-August/077118.html > [2] https://mail.openvswitch.org/pip

Re: [ovs-dev] [PATCH 2/2] ovn: Support address sets generated from port groups

sbctl list port_binding > +as hv1 ovn-sbctl list datapath_binding > +as hv1 ovn-sbctl list port_group > +as hv1 ovn-sbctl list address_set > +as hv1 ovn-sbctl dump-flows > +as hv1 ovs-ofctl dump-flows br-int > + > +# Send IP packets between all pairs of source and destination p

Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

Done: https://patchwork.ozlabs.org/patch/884143/ Thanks a lot again for taking a look. I'd appreciate the backport into 2.9 as well if you all agree. Regards, Daniel On Sat, Mar 10, 2018 at 1:35 PM, Daniel Alvarez Sanchez <dalva...@redhat.com > wrote: > Thanks a lot Ben and Mark. &g

Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

one small finding and have noted it > in-line > > down below. > > > > On 03/08/2018 04:20 PM, Daniel Alvarez wrote: > > >Before this patch, the databases were automatically compacted when a > > >transaction is logged when: > > > > > >* It's b

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

Thanks Han! On Thu, Apr 5, 2018 at 2:58 AM, Han Zhou wrote: > On Wed, Apr 4, 2018 at 4:58 PM, Ben Pfaff wrote: > > > I see that there was a lot of feedback on this series, which seems to > > have resulted in some constructive design decisions. But I don't see

Re: [ovs-dev] [PATCH v1] Fix AUTHORS.rst

Acked-by: Daniel Alvarez <dalva...@redhat.com> Just as a note, normally v1 is not used in the subject, that you can avoid it by using "git send-email -1 --to=d...@openvswitch.org" and it will send just the latest commit without adding the v1 tag to the email subject. On Wed, Ap

Re: [ovs-dev] [PATCH v2 1/2] ovn: Support port groups in ACLs

Acked-by: Daniel Alvarez <dalva...@redhat.com> Thanks Han! Everything LGTM and the test pass okay against current master. On Thu, Apr 5, 2018 at 2:51 AM, Han Zhou <zhou...@gmail.com> wrote: > This patch enables using port group names in ACL match conditions. > Users can c

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

Acked-by: Daniel Alvarez <dalva...@redhat.com> Thanks Han! Everything LGTM and the tests pass okay against current master. On Thu, Apr 5, 2018 at 2:51 AM, Han Zhou <zhou...@gmail.com> wrote: > Address sets are automatically generated from corresponding port > groups, and ca

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

t;> > >> >> >> There was a similar attempt by Zong Kai Li in 2016 [1]. This patch > >> >> >> takes a slightly different approach by using weak refs instead of > >> >> >> strings, which requires a new

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

Reviewed-by: Daniel Alvarez <dalva...@redhat.com> On Mon, Mar 12, 2018 at 8:41 PM, Han Zhou <zhou...@gmail.com> wrote: > Thanks Daniel and Mark for the review. I will fix these in V2. > > On Mon, Mar 12, 2018 at 7:01 AM, Daniel Alvarez Sanchez < > dalva...@redhat.

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

; This patch is generic and not only for OVN, so I suggest to remove the > "OVN" keyword in commit title. > > Acked-by: Han Zhou <hzh...@ebay.com> > > On Tue, Feb 27, 2018 at 12:44 PM, Terry Wilson <twil...@redhat.com> wrote: > >> On Tue, Feb 27, 2018

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

On Fri, Mar 2, 2018 at 3:22 PM, Mark Michelson <mmich...@redhat.com> wrote: > On 03/02/2018 05:57 AM, Daniel Alvarez Sanchez wrote: > >> >> >> On Fri, Mar 2, 2018 at 12:49 AM, Mark Michelson <mmich...@redhat.com >> <mailto:mmich...@redhat.com>

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

atch >> takes a slightly different approach by using weak refs instead of >> strings, which requires a new table instead of reusing the address >> set table. This way it will also benefit for a follow up patch that >> enables generating address sets automatically from port groups to >&

Re: [ovs-dev] [PATCH v2 3/3] OVN: add protocol unreachable support to OVN router ports

Hi all, We are hitting issues with this patch on OpenStack CI in this particular test [0]. The scenario is one VM trying to ping the router interface; replies are sent by the router interface but never reached the instance back as the last NAT action doesn't happen. Stopping northd and deleting

Re: [ovs-dev] [PATCH v2 3/3] OVN: add protocol unreachable support to OVN router ports

Yes, let's hope we can get it in soon... expecting an v3 from Darrell apparently. Thanks! On Fri, Jun 29, 2018 at 2:15 PM Lucas Alvares Gomes wrote: > Hi, > > > this should be the same issue reported by Darrell ('ovn: Fix gateway > > load balancing') > > Regards, > > > > Yeah that's right, I

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

I forgot about this, sorry. Just sent the patch with the comment. Thanks a lot, Daniel On Sat, Aug 18, 2018 at 5:41 PM Ben Pfaff wrote: > > On August 18, 2018 8:18:51 AM PDT, Daniel Alvarez Sanchez > wrote: >> >> Thanks a lot Ben. >> It was fixed in glibc 2.28.

Re: [ovs-dev] [PATCH] ovn-ctl: Fix the wrong pidfile argument passed to ovsdb-servers

dfile_is_running $db_pid_file; then > return > fi > > @@ -169,7 +169,7 @@ $cluster_remote_port > > set ovsdb-server > set "$@" $log --log-file=$logfile > -set "$@" --remote=punix:$sock --pidfile=$pid > +

Re: [ovs-dev] [PATCH] Un-revert Work around Python/C JSON unicode differences

Thanks for this! On Tue, Jan 15, 2019 at 8:48 PM Ben Pfaff wrote: > > On Mon, Jan 14, 2019 at 08:15:36AM -0600, Terry Wilson wrote: > > This fix was reverted because it depended on a small bit of code > > in a patch that was reverted that changed some python/ovs testing > > and build. The fix is

Re: [ovs-dev] [PATCH] ovn-controller: Inject GARPs to logical switch pipeline to update neighbors

tch/ovs/commit/85706c34d53d4810f54bec1de662392a3c06a996 On Mon, Dec 3, 2018 at 6:54 PM Daniel Alvarez wrote: > > Prior to this patch, GARPs announcing NAT addresses or new VIFs > were sent out to localnet ofport through an output action. > This can lead to problems since local datapath

Re: [ovs-dev] [PATCH v3] OVN: Add support for Transport Zones

Tested-by: Daniel Alvarez On Thu, Mar 28, 2019 at 11:37 AM wrote: > > From: Lucas Alvares Gomes > > This patch is adding support for Transport Zones. Transport zones (a.k.a > TZs) is way to enable users of OVN to separate Chassis into different > logical groups that will

Re: [ovs-dev] [PATCH] ofp-packet: Fix NXT_RESUME with geneve tunnel metadata

We have hit this issue as well on 2.9, would it be possible to backport it? On Mon, Oct 8, 2018 at 7:17 PM Ben Pfaff wrote: > > On Fri, Oct 05, 2018 at 09:19:54AM -0700, Yi-Hung Wei wrote: > > The patch address vswitchd crash when it receives NXT_RESUME with geneve > > tunnel metadata. The

Re: [ovs-dev] [PATCH branch2.11] ovsdb-server: drop all connections on read/write status change

On Fri, Jul 12, 2019 at 4:17 PM Daniel Alvarez wrote: > > Prior to this patch, only db change aware connections were dropped > on a read/write status change. However, current schema in OVN does > not allow clients to monitor whether a particular DB changes this > status. In orde

Re: [ovs-dev] [PATCH] ovsdb-server: drop all connections on read/write status change

On Wed, Jul 10, 2019 at 10:24 PM Ben Pfaff wrote: > > On Tue, Jul 09, 2019 at 12:16:30PM +0200, Daniel Alvarez wrote: > > Prior to this patch, only db change aware connections were dropped > > on a read/write status change. However, current schema in OVN does > > not

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

+ocf_log debug "ovndb_servers: Promotion of $host_name as the master > completed" > # Record ourselves so that the agent has a better chance of doing > # the right thing at startup > ${CRM_ATTR_REPL_INFO} -v "$host_name" > -- > 2.21.0 Acked-By: Daniel Alvarez &

Re: [ovs-dev] [PATCH v2] OVN: fix DVR Floating IP support

Even I successfully tested this before getting merged, I just hit some scenario where traffic goes to the gateway node. If we have logical port lp1 with a dnat_and_snat NAT rule to fip1 and from lp1 you ping fip1, the traffic is leaving the hypervisor to the gateway node and comes back to lp1.

  1   2   >