tically, so those
tests either had to be altered or removed.
Signed-off-by: Mark Michelson
---
ovn/northd/ovn-northd.c | 367 ++--
tests/ovn.at| 97 +
2 files changed, 338 insertions(+), 126 deletions(-)
diff --git a/ovn/north
s/remov/remove/
Signed-off-by: Mark Michelson
---
lib/db-ctl-base.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/db-ctl-base.xml b/lib/db-ctl-base.xml
index 6ff08e52c..a5fcc901c 100644
--- a/lib/db-ctl-base.xml
+++ b/lib/db-ctl-base.xml
@@ -252,7 +252,7
So far all I've reviewed is the documentation. See my comments below.
On 06/08/2018 05:59 PM, Ben Pfaff wrote:
The design of the compound index feature in the C OVSDB IDL was unusual.
Indexes were generally referenced only by name rather than by pointer, and
could be obtained only from the top-l
Hi Lorenzo, the patch looks good to me. I have one comment on the test
you added, though. See below.
On 06/05/2018 11:57 AM, Lorenzo Bianconi wrote:
Using icmp4 action, send an ICMP time exceeded frame whenever
an OVN logical router receives an IPv4 packets whose TTL has
expired (ip.ttl == {0,
Acked-by: Mark Michelson
On 06/14/2018 03:36 PM, Ben Pfaff wrote:
This makes the comment more meaningful.
Signed-off-by: Ben Pfaff
---
ovn/controller/binding.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/ovn/controller/binding.c b/ovn/controller
On 06/13/2018 11:29 PM, Han Zhou wrote:
On Wed, Jun 13, 2018 at 3:37 PM, Ben Pfaff wrote:
To make ovn-controller recompute incrementally, we need accurate
dependencies for each function that reads or writes a table. It's
currently difficult to be sure about these dependencies, and certainly
d
On 06/16/2018 12:53 AM, Ben Pfaff wrote:
On Fri, Jun 15, 2018 at 10:11:41AM -0400, Mark Michelson wrote:
On 06/13/2018 11:29 PM, Han Zhou wrote:
On Wed, Jun 13, 2018 at 3:37 PM, Ben Pfaff wrote:
To make ovn-controller recompute incrementally, we need accurate
dependencies for each function
Hi Ben,
The first two patches in this series aren't necessary. ovn_datapaths are
allocated from scratch and then all destroyed during each loop of
ovn-northd. They never survive multiple loops. When entering
init_ipam_info_for_datapath(), you can assert that od->ipam_info == NULL
[1].
For p
Hi Ben,
Just a couple of findings in-line below.
On 06/15/2018 07:11 PM, Ben Pfaff wrote:
Until now, the ipam_info struct for a datapath has been allocated on
demand. This leads to slightly complication in the code in places, and
there is hardly any benefit since ipam_info is only about 48 byt
Acked-by: Mark Michelson
On 06/18/2018 02:45 PM, Ben Pfaff wrote:
Until now, the ipam_info struct for a datapath has been allocated on
demand. This leads to slightly complication in the code in places, and
there is hardly any benefit since ipam_info is only about 48 bytes anyway.
This commit
Hi Ben,
This fixes an issue that is being experienced by users in version 2.9 as
well. Can this please be backported there as well?
Thanks,
Mark Michelson
On 06/15/2018 07:27 PM, Ben Pfaff wrote:
On Tue, May 29, 2018 at 09:15:52AM -0400, Mark Michelson wrote:
Hi Ben,
Thanks for having a
tically, so those
tests either had to be altered or removed.
Signed-off-by: Mark Michelson
---
v1 -> v2:
Rebased based off Ben's changes to how IPAM info is allocated on an OVN
datapath.
---
ovn/northd/ovn-northd.c | 368 ++--
tests/ovn.at
tically, so those
tests either had to be altered or removed.
Signed-off-by: Mark Michelson
---
v2->v3:
Fixed a checkpatch problem (line too long)
v1->v2:
Rebased
---
ovn/northd/ovn-northd.c | 369 ++--
tests/ovn.at| 97
On 06/25/2018 04:08 PM, Aaron Conole wrote:
0-day Robot writes:
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
== Checking a417a98
Thank you very much, Ben!
On 06/25/2018 04:22 PM, Ben Pfaff wrote:
Done.
On Mon, Jun 25, 2018 at 08:08:02AM -0400, Mark Michelson wrote:
Hi Ben,
This fixes an issue that is being experienced by users in version 2.9 as
well. Can this please be backported there as well?
Thanks,
Mark Michelson
Acked-by: Mark Michelson
On 06/22/2018 03:00 PM, Ben Pfaff wrote:
It's not a problem but it looks odd in output.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 6553d17
Acked-by: Mark Michelson
On 06/22/2018 01:23 PM, Ben Pfaff wrote:
Nothing read or wrote this member, and "struct ldatapath" wasn't defined
anywhere.
Signed-off-by: Ben Pfaff
---
ovn/controller/ovn-controller.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/ovn
For the series:
Acked-by: Mark Michelson
Really great job on the test code! You made something that could be very
obtuse into something easily readable and understandable.
On 06/07/2018 06:38 AM, Jakub Sitnicki wrote:
(This patch set depends on v3 of the "ovn-controller increm
rule was only being installed for IPv4 load balancers.
This change adds the same rule for IPv6 load balancers as well.
Signed-off-by: Mark Michelson
---
ovn/northd/ovn-northd.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn
A note: if approved, this patch will also need to go into version 2.9
On 06/26/2018 02:42 PM, Mark Michelson wrote:
When configuring a router port to have a redirect-chassis and using an
IPv6 load balancer rule that specifies a TCP/UDP port, load balancing
would not work as expected. This is
Hi Darrell,
I'm not 100% sure this is correct. I think this change would only be
correct if the router's IP addresses are also load balancer VIPs. In the
case where the VIPs do not overlap with the router IP addresses, I think
we'd want to have the ICMP responses still in place.
On 06/28/201
e to cover this particular scenario?
On Thu, Jun 28, 2018 at 9:41 AM, Mark Michelson <mailto:mmich...@redhat.com>> wrote:
Hi Darrell,
I'm not 100% sure this is correct. I think this change would only be
correct if the router's IP addresses are also load balancer VI
On 06/28/2018 02:26 PM, Darrell Ball wrote:
On Thu, Jun 28, 2018 at 9:41 AM, Mark Michelson <mailto:mmich...@redhat.com>> wrote:
Hi Darrell,
I'm not 100% sure this is correct. I think this change would only be
correct if the router's IP addresses are also loa
A couple of notes:
1) This is actually v3 of the patch, but I messed up the subject line. Oops.
2) Justin was asking for patches that should be considered for 2.10. I
would like to have this patch considered.
Thanks
On 06/25/2018 04:09 PM, Mark Michelson wrote:
OVN offers a method of IP
I'm not sure why you went with a different approach on this compared to
the other functions. I would have expected you would change
get_row_by_id() to return a string (NULL if no error, otherwise an error
string). Then return the row as an output parameter.
On 07/02/2018 06:50 AM, Jakub Sitnic
Hi Jakub,
Your cover letter still hasn't come through, so feel free to tell me if
my comments here are misguided.
I'm guessing that you did not remove ctl_fatal() calls from
parse_commands() and ctl_parse_commands() because there is no
ctl_context present. However, it's not clear why the ctl
On 07/06/2018 06:36 PM, Ben Pfaff wrote:
On Mon, Jun 25, 2018 at 04:09:53PM -0400, Mark Michelson wrote:
OVN offers a method of IP address management that allows for an IPv4 subnet or
IPv6 prefix to be specified on a logical switch. Then by specifying a
switch port's address as "d
Hi Ben,
Thanks for applying this patch to master. Can you please apply the patch
to the 2.9 branch as well?
Thank you,
Mark
On 06/26/2018 02:45 PM, Mark Michelson wrote:
A note: if approved, this patch will also need to go into version 2.9
On 06/26/2018 02:42 PM, Mark Michelson wrote
Thanks, Ben!
Acked-by: Mark Michelson
On 07/10/2018 06:24 PM, Ben Pfaff wrote:
This is a partial backport of commit 396d492cfa8d ("Don't shadow
variables.") to fix a build break due to backporting a different commit
that depended on it.
CC: Mark Michelson
Fixes: 15fbc3ba
On 07/12/2018 09:40 AM, Jakub Sitnicki wrote:
If IDL was created with monitoring and alerts turned on by default for
all columns, then there is no harm in allowing the API users to ask
again for monitoring and alerts to be enabled for any given column.
This allows us to run prerequisites handler
On 07/12/2018 09:40 AM, Jakub Sitnicki wrote:
Make ovn-nbctl act as a unixctl server if we were asked to detach. This
turns ovn-nbctl into a long-lived process that acts a proxy for
interacting with NB DB. The main difference to regular mode of ovn-nbctl
is that in the daemon mode, a local copy o
This is tough. The problem with a test like this is that you can't
really tell that the sync is working as intended. It's possible that the
ovn-nbctl is not actually waiting, but by coincidence, the database has
its values updated before you check them.
You'd need something internal to ovn-nbc
tically, so those
tests either had to be altered or removed.
Signed-off-by: Mark Michelson
---
v3->v4:
Print warning when multiple dynamic addresses are configured on a
switch port. Ensure that dynamic addresses beyond the first on a switch
port are ignored. Found by Ben Pfaff.
v2->v3:
I've had a look through again and this series addresses the findings I
previously had, so in short:
Acked-by: Mark Michelson
I decided to do some testing to see what sort of performance gain we see
with this patch. I'm attaching four scripts that I used for testing.
In all of th
Looks good!
Acked-by: Mark Michelson
On 07/17/2018 09:36 AM, Jakub Sitnicki wrote:
(Cover-letter awaits moderator approval. Reposting here.)
This is a continuation of an earlier series that aims to replace calls
to ctl_fatal() in command handlers in ovn-nbctl. The motivation is to
handle
I've had a look through and have some notes in-line. I know some of them
will be a bit nit-picky, but...sometimes that's just how I am :)
On 06/25/2018 03:53 PM, vkomm...@redhat.com wrote:
From: venkata anil
When a vm on a vlan tenant network sends traffic to an external network,
it is tunnel
This patch had some compilation errors. It may be due to changes in
master since this patchset was posted:
ovn/controller/pinctrl.c: In function ‘send_garp_run’:
ovn/controller/pinctrl.c:2303:48: error: passing argument 8 of
‘get_nat_addresses_and_keys’ discards ‘const’ qualifier from pointer
d the main benefit from the daemon mode is that the contents of
NB database have to be obtained only once, when the first command is ran. On big
databases (1000's of logical ports) this results in a speed up per command in
the range of 100's of milliseconds.
Mark Michelson has benchmarked
On 07/20/2018 08:06 AM, Jakub Sitnicki wrote:
On Fri, Jul 13, 2018 at 06:45 PM GMT, Mark Michelson wrote:
OVN offers a method of IP address management that allows for an IPv4 subnet or
IPv6 prefix to be specified on a logical switch. Then by specifying a
switch port's address as "d
tically, so those
tests either had to be altered or removed.
Signed-off-by: Mark Michelson
Acked-by: Jakub Sitnicki
---
v4->v5:
Cleanups suggested by Jakub Sitnicki + rebase
* Add some convenience pointers for shortened code.
* Separate checking of updates of dynamic addresses and reg
. This way, during a restart, traffic can still flow freely
while ovn-controller is down.
Mark Michelson (2):
ovn: Add '--restart' flag to ovn-controller exit.
ovn: Modify restart_controller in ovn-ctl to use --restart
ovn/controller/ovn-controller.c | 92 +++-
ovn/uti
o remain up and allow for traffic not to be
interrupted during the restart. When ovn-controller is started again, it
picks back up from where it was.
Signed-off-by: Mark Michelson
---
ovn/controller/ovn-controller.c | 92 +++-
tests/ovn.at
The --restart flag allows for uninterrupted packet flowage when exiting
ovn-controller. This patch modifies the restart_controller argument to
ovn-ctl to use --restart.
Signed-off-by: Mark Michelson
---
ovn/utilities/ovn-ctl | 4 ++--
utilities/ovs-lib.in | 2 +-
2 files changed, 3 insertions
Hi Lorenzo,
I have some comments inline below.
Also, I think there should be a test for this. You could start OVN, run
`ovn-appctl -t ovn-controller connection-status` and make sure it
returns "connected". Then you could run `ovn-sbctl set-connection random TCP port>`, and then ensure that whe
Better late than never
Acked-by: Mark Michelson
On 06/18/2018 02:36 PM, Ben Pfaff wrote:
This new function makes it possible to create an instance of the IDL
without connecting it to a remote OVSDB server. The caller can then
connect and disconnect using ovsdb_idl_set_remote(); the ability
The --restart flag allows for uninterrupted packet flowage when exiting
ovn-controller. This patch modifies the restart_controller argument to
ovn-ctl to use --restart.
Signed-off-by: Mark Michelson
---
ovn/utilities/ovn-ctl | 4 ++--
utilities/ovs-lib.in | 2 +-
2 files changed, 3 insertions
. This way, during a restart, traffic can still flow freely
while ovn-controller is down.
---
v1 -> v2: Modified patch 2 to pass $@ instead of $1 to stop_daemon when
restarting ovn_controller.
Mark Michelson (2):
ovn: Add '--restart' flag to ovn-controller exit.
ovn: Modify restart_
o remain up and allow for traffic not to be
interrupted during the restart. When ovn-controller is started again, it
picks back up from where it was.
Signed-off-by: Mark Michelson
---
ovn/controller/ovn-controller.c | 92 +++-
tests/ovn.at
For the series (aside from Han's finding):
Acked-by: Mark Michelson
On 07/26/2018 06:51 AM, Jakub Sitnicki wrote:
This series addresses two issues noticed with Port Groups:
(1) Port Group name cannot be used to refer to a row in NB DB.
(2) LSP dynamic addresses don't get copied to
Wow bad timing on my part for my review of v1.
Acked-by: Mark Michelson
On 07/30/2018 10:37 AM, Jakub Sitnicki wrote:
This series addresses two issues noticed with Port Groups:
(1) Port Group name cannot be used to refer to a row in NB DB.
(2) LSP dynamic addresses don't get copied to
Looks good to me. Ship it!
Acked-by: Mark Michelson
On 07/30/2018 11:10 AM, Lorenzo Bianconi wrote:
Add 'connection-status' command to ovs-appctl utility in order to check
if a given chassis is currently connected to SB db
Co-authored-by: aginwala
Signed-off-by: aginwala
Sig
Hi Justin,
I took a look through the patch series, and this is the only one that I
had some immediate feedback on.
First, it would be nice if we could refer to Meters by name when issuing
DB commands. For instance `ovn-nbctl add Meter bands UUID>`.
Second, I noticed that the algorithm for
On 07/30/2018 09:00 PM, Justin Pettit wrote:
On Jul 30, 2018, at 11:40 AM, Mark Michelson wrote:
Hi Justin,
I took a look through the patch series, and this is the only one that I had
some immediate feedback on.
First, it would be nice if we could refer to Meters by name when issuing DB
The 0-day Robot needs to lay off the pipe.
Acked-by: Mark Michelson
On 07/31/2018 02:03 AM, Justin Pettit wrote:
This also add some OVN action parsing tests.
Suggested-by: Ben Pfaff
Signed-off-by: Justin Pettit
---
ovn/lib/actions.c | 9 -
tests/ovn.at | 19
Hi Han,
I've given this patchset a look, and I was following along pretty well
until I got to about patch 11. From that point on, I had to re-read the
code more times than I care to admit before I finally understood what
was going on :)
What you have is a structure (lflow_ref_list_node) that
tically, so those
tests either had to be altered or removed.
Signed-off-by: Mark Michelson
Acked-by: Jakub Sitnicki
---
v5->v6:
* Rebased
v4->v5:
Cleanups suggested by Jakub Sitnicki + rebase
* Add some convenience pointers for shortened code.
* Separate checking of updates of dyna
tically, so those
tests either had to be altered or removed.
Signed-off-by: Mark Michelson
Acked-by: Jakub Sitnicki
---
v6->v7:
* Alter port group address set generation test to pass
v5->v6:
* Rebased
v4->v5:
Cleanups suggested by Jakub Sitnicki + rebase
* Add some convenience poi
On 08/02/2018 08:48 AM, Jakub Sitnicki wrote:
Hi Mark,
On Thu, 2 Aug 2018 08:18:12 -0400
Mark Michelson wrote:
OVN offers a method of IP address management that allows for an IPv4
subnet or IPv6 prefix to be specified on a logical switch. Then by
specifying a switch port's addre
On 08/01/2018 08:16 AM, vkomm...@redhat.com wrote:
From: venkata anil
Previous patches in the series doesn't address issue 1 explained in [1]
i.e
1) removal of router gateway port MAC address on external switches
after expiring of aging time.
2) then external switches unable to learn the ga
For the series:
Acked-by: Mark Michelson
I have a couple of small notes in-line below on this particular commit
message.
On 07/26/2018 01:09 PM, Ben Pfaff wrote:
A previous commit to improve timing also caused the cluster torture test to
be skipped (unless it failed early). This is
Acked-by: Mark Michelson
On 07/26/2018 06:43 PM, Ben Pfaff wrote:
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9424
Signed-off-by: Ben Pfaff
---
lib/nx-match.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
8 03:11 PM, Han Zhou wrote:
Hi Mark,
Thanks for the review and very valuable comments! (I was on vacation
last week so sorry for slow response).
On Tue, Jul 31, 2018 at 3:47 AM, Mark Michelson <mailto:mmich...@redhat.com>> wrote:
>
> Hi Han,
>
> I've given this
On 08/06/2018 01:58 PM, Anil Venkata wrote:
Thanks Mark. Kindly look at my comment inline.
On Fri, Aug 3, 2018 at 2:17 AM, Mark Michelson <mailto:mmich...@redhat.com>> wrote:
On 08/01/2018 08:16 AM, vkomm...@redhat.com
<mailto:vkomm...@redhat.com> wrote:
Fro
On 08/03/2018 01:54 PM, Ben Pfaff wrote:
This will allow selected options to be interpreted locally and others to
be passed to the daemon, when the daemon is in use.
Signed-off-by: Ben Pfaff
---
lib/command-line.c| 108 ++
lib/command-line.
Acked-by: Mark Michelson
On 08/03/2018 01:54 PM, Ben Pfaff wrote:
Acked-by: Alin Gabriel Serdean
Signed-off-by: Ben Pfaff
---
lib/unixctl.c | 52
lib/unixctl.h | 2 ++
tests/daemon.at | 4 ++--
3 files changed, 32 insertions
Acked-by: Mark Michelson
On 08/03/2018 01:54 PM, Ben Pfaff wrote:
This makes ovn-nbctl transparently use daemon mode if an appropriate
environment variable is set.
It also transforms ovn-nbctl.at so that it runs each ovn-nbctl test in
"direct" mode and in daemon mode. It uses a c
Looks good to me.
Acked-by: Mark Michelson
On 08/06/2018 05:35 PM, Ben Pfaff wrote:
raft_store_snapshot() constructs a new snapshot in a local variable then
destroys the current snapshot and replaces it by the new one. Until now,
it has not cloned the data in the new snapshot until it did
Acked-by: Mark Michelson
On 08/06/2018 05:45 PM, Ben Pfaff wrote:
v1->v2:
- Applied patches 1 and 2; added ack for patch 3 (thanks Alin!)
- Polished up the daemon mode so that it works actually quite well
and added tests that show that it behaves equivalently.
v2->v3:
- F
Acked-by: Mark Michelson
On 08/06/2018 10:44 PM, Han Zhou wrote:
Remove the redundant members that's already in nb_pg.
Signed-off-by: Han Zhou
---
ovn/northd/ovn-northd.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn/n
Nice find, Han!
Acked-by: Mark Michelson
On 08/06/2018 10:44 PM, Han Zhou wrote:
Currently in has_stateful_acl(), to check if a datapath has stateful ACLs,
it needs to iterate all port groups and check if the current datapath is
related to each port group, and then iterate the ACLs on the
Acked-by: Mark Michelson
With a patch like this, I like to look at it and ask myself "What will
this break?" In this case, I believe nothing will actually be broken.
On 08/06/2018 10:44 PM, Han Zhou wrote:
When port group is used, ovn-trace may print warnings like this:
$ ovn
Hi Numan, See below.
On 08/07/2018 07:37 AM, nusid...@redhat.com wrote:
From: Numan Siddique
The python function ovs.socket_util.check_connection_completion() uses select()
(provided by python) to monitor the socket file descriptor. The select()
returns 1 when the file descriptor becomes ready
On 08/08/2018 03:24 AM, Numan Siddique wrote:
On Wed, Aug 8, 2018 at 2:58 AM Ben Pfaff <mailto:b...@ovn.org>> wrote:
On Tue, Aug 07, 2018 at 05:12:32PM -0400, Mark Michelson wrote:
> On 08/07/2018 07:37 AM, nusid...@redhat.com
<mailto:nusid...@redhat.com> w
On Thu, Sep 21, 2017 at 11:12 AM wrote:
> From: Numan Siddique
>
> In the router ingress pipeline, if the destination mac is unresolved
> by the time the packet reaches the ARP_REQUEST stage, OVN should generate
> an
> IPv6 Neighbor Solicitation packet to learn the MAC address. This feature is
>
db would purge the existing DB without writing
> anything in the logs.
>
> Signed-off-by: Matteo Croce
>
Acked-by: Mark Michelson
> ---
> utilities/ovs-lib.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utilities/ovs-lib.in b/utilities/ovs-li
On Thu, Sep 21, 2017 at 11:10 AM wrote:
> From: Numan Siddique
>
> This patch adds a new OVN action 'put_nd_ra_opts' to support native
> IPv6 Router Advertisement in OVN. This action can be used to respond
> to the IPv6 Router Solicitation requests.
>
> ovn-controller parses this action and adds
update the NB DB only
> when state has not been set yet or current state is different.
>
> Signed-off-by: Jakub Sitnicki
>
Acked-by: Mark Michelson
> ---
> ovn/northd/ovn-northd.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/ovn/no
router ports appear as being down (with the exception of ones linking to
> gateway routers, which are bound).
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2017-August/045202.html
> Signed-off-by: Jakub Sitnicki
>
Acked-by: Mark Michelson
> ---
> ov
o store
> the IPv6 ND RA options in 'struct gen_opts_map'.
>
> Signed-off-by: Numan Siddique
> Acked-by: Miguel Angel Ajo
>
Acked-by: Mark Michelson
> ---
> include/ovn/actions.h| 16 +++
> ovn/controller/lflow.c | 2
SB DB since there are only 3 ND RA options.
>
> Co-authored-by: Zongkai LI
> Signed-off-by: Zongkai LI
> Signed-off-by: Numan Siddique
>
Acked-by: Mark Michelson
> ---
> include/ovn/actions.h | 14 +++-
> ovn/controller/lflow.c| 13 +++-
> ovn/control
ot;ipv6_ra_configs" is added in the Logical_Router_Port
> table, which the CMS is expected to configure IPv6 RA
> configurations - "address_mode" and "mtu" for adding these flows.
>
> Co-authored-by: Numan Siddique
> Signed-off-by: Zongkai LI
> Sign
e eth.dst is zero which applies this action. This
> action is
> similar to the IPv4 counterpart "arp" action.
>
> OVN already has the support to learn the MAC from the IPv6 Neighbor
> Advertisement
> packets and storing in the south bound MAC_Binding table.
>
> Signe
attempting to send
out those multicast packets, and so each should only be responsible for
delivering those packets to their local ports.
Signed-off-by: Mark Michelson
---
ovn/controller/physical.c | 15 +++
ovn/lib/logical-fields.h | 6 ++
2 files changed, 21 insertions(+)
diff
the function public or duplicate it. Given that the
function is so small, I see no reason why it would be modified, I went
with the duplication choice. However, if it should be done the other
way, let me know and I'll go that direction instead.
Mark Michelson (2):
OVN: Add multicast ke
ovn-controller can use this information
to know when to send periodic RAs and what to send in them.
Because periodic RAs originate from each ovn-controller, the new
keep-local flag is set on the packet so that ports don't receive an
overabundance of RAs.
Signed-off-by: Mark Michelson
to this document in
the future.
Signed-off-by: Mark Michelson
---
Documentation/automake.mk | 1 +
Documentation/topics/index.rst | 1 +
Documentation/topics/role-based-access-control.rst | 97 ++
3 files changed, 99 insertions
to this document in
the future.
Signed-off-by: Mark Michelson
---
Version 2 changes:
* There were references to a table called RBAC_Permissions. These have
been changed to the correct "RBAC_Permission".
* Fixed a grammatical error in the final section.
---
Documentation/a
Firewalld service files for OVN have been in the source for several
months. This adds instructions for how to use these service files with
firewalld.
Signed-off-by: Mark Michelson
---
Documentation/automake.mk | 1 +
Documentation/howto/firewalld.rst | 110
Since other code is already equipped to deal with this,
this poses no problem.
Signed-off-by: Mark Michelson
---
ovn/northd/ovn-northd.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 2db23807
On Wed, Oct 25, 2017 at 4:16 PM Yifeng Sun wrote:
> I feel that unbound stands out in the available open source DNS resolver.
>
> Below is the summary for unbound:
> * The actual resolving work is done by a background process or thread. A
> background process or thread seems unavoidable. Linux's
anism to watch for changes of ip addresses that were already resolved
> and being used.
>
> Thanks,
> Yifeng
>
> On Thu, Oct 26, 2017 at 12:10 PM, Mark Michelson
> wrote:
>
>> On Wed, Oct 25, 2017 at 4:16 PM Yifeng Sun
>> wrote:
>>
>>> I feel th
t for associating a load balancer to a
> logical router with gateway router port which was missing earlier.
>
> Signed-off-by: Numan Siddique
>
Acked-by: Mark Michelson
> ---
> ovn/northd/ovn-northd.8.xml | 70 +++---
> ovn/northd/ovn-northd.c | 82 ++
27, 2017 at 10:19 AM Ben Pfaff wrote:
> Does it make sense to cache the entry until its declared TTL expires?
>
> On Fri, Oct 27, 2017 at 01:30:41PM +, Mark Michelson wrote:
> > This opens the can of worms that is DNS caching.
> >
> > On one end of the spectrum, you
7;ll merge it.
>
> Do you have a preference on ordering?
>
> On Fri, Oct 27, 2017 at 03:26:56PM +, Mark Michelson wrote:
> > I've had a look over this and it looks fine by me. Ben, do you plan to
> > merge this soon? If so, I'll need to update my IPv6 load ba
ifeng Sun wrote:
> Mark, thanks a lot for the detailed and thorough explanation.
>
> Do you happen to know any other projects that we can take a peek?
>
> On Fri, Oct 27, 2017 at 8:57 AM, Mark Michelson
> wrote:
>
>> Yep, that makes good sense. I'd recommend having so
pointer in_dhcp_opt passing to memcmp.
> This might due to dp_packet_get_udp_payload retuning null. Fix it
> by adding ovs_assert.
>
> Signed-off-by: William Tu
>
Acked-by: Mark Michelson
> ---
> ovn/controller/pinctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff
Looks good to me.
On Sat, Oct 28, 2017 at 12:34 PM William Tu wrote:
> Clang reports possible optarg as null pointer passed to atoi.
> Fix it by adding ovs_assert check before.
>
> Signed-off-by: William Tu
>
Acked-by: Mark Michelson
> ---
> utilities/ovs-appctl.c | 1 +
Looks good to me.
On Sat, Oct 28, 2017 at 12:35 PM William Tu wrote:
> Clang reports possible null pointer due to process_register could
> take the name from argv[0]. Fix it by adding ovs_assert check.
>
> Signed-off-by: William Tu
>
Acked-by: Mark Michelson
> ---
&g
Looks good to me.
On Sat, Oct 28, 2017 at 12:35 PM William Tu wrote:
> Clang reports possible null pointer of optarg as argument to strtoul.
> Fix it by adding ovs_assert check.
>
> Signed-off-by: William Tu
>
Acked-by: Mark Michelson
> ---
> utilities/ovs-ofctl.c | 1 +
This is not the proper solution. If you start ovn-northd and do not add any
logical switches or routers, then there will be no logical flows created.
Currently, if you run `ovs-sbctl lflow-list` in this circumstance, it lists
nothing and exits cleanly. With this change, the command hits the asserti
1 - 100 of 2376 matches
Mail list logo
