[GitHub] [hadoop-ozone] Simon0806 closed pull request #1041: HDDS-3725. Ozone sh volume client support quota option

2020-07-17 Thread GitBox
Simon0806 closed pull request #1041: URL: https://github.com/apache/hadoop-ozone/pull/1041 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (HDDS-3964) Ratis config key mismatch

2020-07-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-3964: --- Fix Version/s: 0.7.0 > Ratis config key mismatch > - > >

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1204: HDDS-3964. Ratis config key mismatch

2020-07-17 Thread GitBox
adoroszlai merged pull request #1204: URL: https://github.com/apache/hadoop-ozone/pull/1204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1204: HDDS-3964. Ratis config key mismatch

2020-07-17 Thread GitBox
adoroszlai commented on pull request #1204: URL: https://github.com/apache/hadoop-ozone/pull/1204#issuecomment-659887007 Thanks @cku328 and @lokeshj1703 for the review. This is an automated message from the Apache Git

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1207: HDDS-3973. Update main feature design status.

2020-07-17 Thread GitBox
ChenSammi commented on a change in pull request #1207: URL: https://github.com/apache/hadoop-ozone/pull/1207#discussion_r456268272 ## File path: hadoop-hdds/docs/content/design/decommissioning.md ## @@ -3,7 +3,7 @@ title: Decommissioning in Ozone summary: Formal process to

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1207: HDDS-3973. Update main feature design status.

2020-07-17 Thread GitBox
ChenSammi commented on a change in pull request #1207: URL: https://github.com/apache/hadoop-ozone/pull/1207#discussion_r456268272 ## File path: hadoop-hdds/docs/content/design/decommissioning.md ## @@ -3,7 +3,7 @@ title: Decommissioning in Ozone summary: Formal process to

[GitHub] [hadoop-ozone] captainzmc closed pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-17 Thread GitBox
captainzmc closed pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] elek merged pull request #1142: HDDS-3855. Add upgrade smoketest

2020-07-17 Thread GitBox
elek merged pull request #1142: URL: https://github.com/apache/hadoop-ozone/pull/1142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HDDS-3978) Switch log4j to log4j2 to avoid deadlock

2020-07-17 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated HDDS-3978: - Description: We met dead lock related to log4j, the jstack information has been attached. For the

[GitHub] [hadoop-ozone] elek commented on pull request #1142: HDDS-3855. Add upgrade smoketest

2020-07-17 Thread GitBox
elek commented on pull request #1142: URL: https://github.com/apache/hadoop-ozone/pull/1142#issuecomment-660032297 > I had started out without the network/ip settings, but the containers did not always get the same address after down/up, nor would they reuse volumes. You mean that I

[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #1207: HDDS-3973. Update main feature design status.

2020-07-17 Thread GitBox
sodonnel commented on a change in pull request #1207: URL: https://github.com/apache/hadoop-ozone/pull/1207#discussion_r456365260 ## File path: hadoop-hdds/docs/content/design/decommissioning.md ## @@ -3,7 +3,7 @@ title: Decommissioning in Ozone summary: Formal process to

[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #1147: HDDS-3892. Datanode initialization is too slow when there are thousan…

2020-07-17 Thread GitBox
sodonnel commented on a change in pull request #1147: URL: https://github.com/apache/hadoop-ozone/pull/1147#discussion_r456372422 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerCache.java ## @@ -117,30 +119,57

[jira] [Updated] (HDDS-3978) Switch log4j to log4j2 to avoid deadlock

2020-07-17 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated HDDS-3978: - Description: We met dead lock related to log4j, the jstack information has been attached. For the

[jira] [Created] (HDDS-3978) Switch log4j to log4j2 to avoid deadlock

2020-07-17 Thread runzhiwang (Jira)
runzhiwang created HDDS-3978: Summary: Switch log4j to log4j2 to avoid deadlock Key: HDDS-3978 URL: https://issues.apache.org/jira/browse/HDDS-3978 Project: Hadoop Distributed Data Store Issue

[jira] [Updated] (HDDS-3978) Switch log4j to log4j2 to avoid deadlock

2020-07-17 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated HDDS-3978: - Attachment: jstack-deadlock-log.txt > Switch log4j to log4j2 to avoid deadlock >

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1207: HDDS-3973. Update main feature design status.

2020-07-17 Thread GitBox
elek commented on a change in pull request #1207: URL: https://github.com/apache/hadoop-ozone/pull/1207#discussion_r456362660 ## File path: hadoop-hdds/docs/content/design/decommissioning.md ## @@ -3,7 +3,7 @@ title: Decommissioning in Ozone summary: Formal process to shut

[GitHub] [hadoop-ozone] captainzmc removed a comment on pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-17 Thread GitBox
captainzmc removed a comment on pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-658717829 > > Thanks @captainzmc for updating the PR based on #1195. I would like to suggest waiting until that PR is merged before updating this one again, to avoid

[GitHub] [hadoop-ozone] ChenSammi commented on pull request #1147: HDDS-3892. Datanode initialization is too slow when there are thousan…

2020-07-17 Thread GitBox
ChenSammi commented on pull request #1147: URL: https://github.com/apache/hadoop-ozone/pull/1147#issuecomment-660072042 > > > These changes with the striped lock LGTM, +1. > > One question - have you been able to test this change on your DNs with a large number of

[GitHub] [hadoop-ozone] ChenSammi edited a comment on pull request #1147: HDDS-3892. Datanode initialization is too slow when there are thousan…

2020-07-17 Thread GitBox
ChenSammi edited a comment on pull request #1147: URL: https://github.com/apache/hadoop-ozone/pull/1147#issuecomment-660072042 > > > These changes with the striped lock LGTM, +1. > > One question - have you been able to test this change on your DNs with a large number of

[jira] [Updated] (HDDS-3978) Switch log4j to log4j2 to avoid deadlock

2020-07-17 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated HDDS-3978: - Description: We met dead lock related to log4j, the jstack information has been attached. (was: We met

[jira] [Updated] (HDDS-3978) Switch log4j to log4j2 to avoid deadlock

2020-07-17 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated HDDS-3978: - Description: We met dead lock related to log4j, the jstack information has been attached. > Switch log4j

[jira] [Updated] (HDDS-3855) Add upgrade smoketest

2020-07-17 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-3855: -- Fix Version/s: 0.6.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Add

[jira] [Commented] (HDDS-3545) MR Jobhistory cannot work well with o3fs hadoop compatible file system

2020-07-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159871#comment-17159871 ] Steve Loughran commented on HDDS-3545: -- could the timestamping be done with some marker file which is

[GitHub] [hadoop-ozone] captainzmc commented on pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-17 Thread GitBox
captainzmc commented on pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-660046911 > > Thanks @captainzmc for updating the PR based on #1195. I would like to suggest waiting until that PR is merged before updating this one again, to avoid having to

[GitHub] [hadoop-ozone] captainzmc removed a comment on pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-17 Thread GitBox
captainzmc removed a comment on pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-660045943 > > Thanks @captainzmc for updating the PR based on #1195. I would like to suggest waiting until that PR is merged before updating this one again, to avoid

[GitHub] [hadoop-ozone] captainzmc commented on pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-17 Thread GitBox
captainzmc commented on pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-660045943 > > Thanks @captainzmc for updating the PR based on #1195. I would like to suggest waiting until that PR is merged before updating this one again, to avoid having to

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1147: HDDS-3892. Datanode initialization is too slow when there are thousan…

2020-07-17 Thread GitBox
ChenSammi commented on a change in pull request #1147: URL: https://github.com/apache/hadoop-ozone/pull/1147#discussion_r456398538 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerCache.java ## @@ -117,30

[GitHub] [hadoop-ozone] elek commented on pull request #1142: HDDS-3855. Add upgrade smoketest

2020-07-17 Thread GitBox
elek commented on pull request #1142: URL: https://github.com/apache/hadoop-ozone/pull/1142#issuecomment-660033887 Other random thoughts: I plan to enable acceptance tests for k8s cluster definitions, too. 1. I would like to be sure that those configs are up-to-date and

[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #1207: HDDS-3973. Update main feature design status.

2020-07-17 Thread GitBox
sodonnel commented on a change in pull request #1207: URL: https://github.com/apache/hadoop-ozone/pull/1207#discussion_r456365260 ## File path: hadoop-hdds/docs/content/design/decommissioning.md ## @@ -3,7 +3,7 @@ title: Decommissioning in Ozone summary: Formal process to

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1142: HDDS-3855. Add upgrade smoketest

2020-07-17 Thread GitBox
adoroszlai commented on pull request #1142: URL: https://github.com/apache/hadoop-ozone/pull/1142#issuecomment-660090635 Thanks @avijayanhwx for the review, and @elek for reviewing and merging this. This is an automated

[jira] [Commented] (HDDS-3855) Add upgrade smoketest

2020-07-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159907#comment-17159907 ] Attila Doroszlai commented on HDDS-3855: CC [~sammichen] for backport to 0.6.0. > Add upgrade

[jira] [Updated] (HDDS-3855) Add upgrade smoketest

2020-07-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-3855: --- Labels: (was: pull-request-available) > Add upgrade smoketest > - > >

[jira] [Updated] (HDDS-3976) KeyValueBlockIterator#nextBlock skips valid blocks

2020-07-17 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-3976: - Description: HDDS-3854 fixed a bug in KeyValueBlockIterator#hasNext, but introduced another one in

[GitHub] [hadoop-ozone] sodonnel commented on pull request #1147: HDDS-3892. Datanode initialization is too slow when there are thousan…

2020-07-17 Thread GitBox
sodonnel commented on pull request #1147: URL: https://github.com/apache/hadoop-ozone/pull/1147#issuecomment-660110616 > > These changes with the striped lock LGTM, +1. > > One question - have you been able to test this change on your DNs with a large number of containers, and did it

[GitHub] [hadoop-ozone] maobaolong opened a new pull request #1214: HDDS-3981. Add more debug level log to XceiverClientGrpc for debug purpose

2020-07-17 Thread GitBox
maobaolong opened a new pull request #1214: URL: https://github.com/apache/hadoop-ozone/pull/1214 ## What changes were proposed in this pull request? When I profile the s3g performance, i find in some log of XceiverClientGrpc, I cannot find the related datanode ip, so i use datanode

[jira] [Created] (HDDS-3979) Clarify the ObjectEndpoint code of s3g

2020-07-17 Thread maobaolong (Jira)
maobaolong created HDDS-3979: Summary: Clarify the ObjectEndpoint code of s3g Key: HDDS-3979 URL: https://issues.apache.org/jira/browse/HDDS-3979 Project: Hadoop Distributed Data Store Issue

[jira] [Updated] (HDDS-3981) Add more debug level log to XceiverClientGrpc for debug purpose

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3981: - Labels: pull-request-available (was: ) > Add more debug level log to XceiverClientGrpc for debug

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1147: HDDS-3892. Datanode initialization is too slow when there are thousan…

2020-07-17 Thread GitBox
adoroszlai commented on a change in pull request #1147: URL: https://github.com/apache/hadoop-ozone/pull/1147#discussion_r456456312 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerCache.java ## @@ -43,6 +44,7

[jira] [Commented] (HDDS-3976) KeyValueBlockIterator#nextBlock skips valid blocks

2020-07-17 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160023#comment-17160023 ] Ethan Rose commented on HDDS-3976: -- Implementing seekLast() correctly and efficiently with a filter

[jira] [Created] (HDDS-3981) Add more debug level log to XceiverClientGrpc for debug purpose

2020-07-17 Thread maobaolong (Jira)
maobaolong created HDDS-3981: Summary: Add more debug level log to XceiverClientGrpc for debug purpose Key: HDDS-3981 URL: https://issues.apache.org/jira/browse/HDDS-3981 Project: Hadoop Distributed Data

[jira] [Created] (HDDS-3980) Correct the toString of RangeHeader

2020-07-17 Thread maobaolong (Jira)
maobaolong created HDDS-3980: Summary: Correct the toString of RangeHeader Key: HDDS-3980 URL: https://issues.apache.org/jira/browse/HDDS-3980 Project: Hadoop Distributed Data Store Issue Type:

[GitHub] [hadoop-ozone] maobaolong commented on pull request #1096: HDDS-3833. Use Pipeline choose policy to choose pipeline from exist pipeline list

2020-07-17 Thread GitBox
maobaolong commented on pull request #1096: URL: https://github.com/apache/hadoop-ozone/pull/1096#issuecomment-660178707 @xiaoyuyao Please take a look at this PR, thanks. This is an automated message from the Apache Git

[jira] [Updated] (HDDS-3979) Clarify the ObjectEndpoint code of s3g

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3979: - Labels: pull-request-available (was: ) > Clarify the ObjectEndpoint code of s3g >

[GitHub] [hadoop-ozone] maobaolong opened a new pull request #1212: HDDS-3979. Use chunkSize as bufferSize for stream copy

2020-07-17 Thread GitBox
maobaolong opened a new pull request #1212: URL: https://github.com/apache/hadoop-ozone/pull/1212 ## What changes were proposed in this pull request? Use chunkSize as bufferSize for stream copy, so that we can reduce the readChunk count from s3g to datanodes. For example,

[jira] [Updated] (HDDS-3980) Correct the toString of RangeHeader

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3980: - Labels: pull-request-available (was: ) > Correct the toString of RangeHeader >

[GitHub] [hadoop-ozone] maobaolong opened a new pull request #1213: HDDS-3980. Correct the toString of RangeHeader

2020-07-17 Thread GitBox
maobaolong opened a new pull request #1213: URL: https://github.com/apache/hadoop-ozone/pull/1213 ## What changes were proposed in this pull request? Correct the toString format of RangeHeader ## What is the link to the Apache JIRA HDDS-3980 ## How was this patch

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
bharatviswa504 commented on pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#issuecomment-660250249 Rebased with latest apache main branch. This is an automated message from the Apache Git Service.

[jira] [Updated] (HDDS-3955) Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread Arpit Agarwal (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDDS-3955: Status: Patch Available (was: Open) > Unable to list intermediate paths on keys created using S3G.

[jira] [Assigned] (HDDS-3983) Ozone RocksDB Iterator wrapper should not expose key() and value() API.

2020-07-17 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan reassigned HDDS-3983: --- Assignee: (was: Aravindan Vijayan) > Ozone RocksDB Iterator wrapper should not

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456631086 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java ## @@ -327,7 +344,164 @@

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456630734 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java ## @@ -327,7 +344,164 @@

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456633686 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/TestNormalizePaths.java ## @@ -0,0 +1,109 @@ +/* + *

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
bharatviswa504 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456660788 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java ## @@ -265,4 +273,72 @@

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
bharatviswa504 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r45267 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/TestNormalizePaths.java ## @@ -0,0 +1,109 @@ +/* +

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
bharatviswa504 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r45760 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java ## @@ -327,7

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
bharatviswa504 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456675451 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java ## @@ -91,6 +99,19 @@

[GitHub] [hadoop-ozone] umamaheswararao edited a comment on pull request #1215: HDDS-3982. Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread GitBox
umamaheswararao edited a comment on pull request #1215: URL: https://github.com/apache/hadoop-ozone/pull/1215#issuecomment-660398646 @smengcl Thank you for working on it. This is a good idea. - But the below log message from could confuse people? ``` fs.rename(path,

[GitHub] [hadoop-ozone] umamaheswararao commented on pull request #1215: HDDS-3982. Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread GitBox
umamaheswararao commented on pull request #1215: URL: https://github.com/apache/hadoop-ozone/pull/1215#issuecomment-660398646 This is a good idea. - But the below log message from could confuse people? ``` fs.rename(path, trashPath, Rename.TO_TRASH);

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
bharatviswa504 commented on pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#issuecomment-660355893 > Few minor comments, and couple of questions on the expected normalizations. > > Overall the change looks good. Thanks for adding comprehensive test cases.

[GitHub] [hadoop-ozone] umamaheswararao commented on a change in pull request #1215: HDDS-3982. Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread GitBox
umamaheswararao commented on a change in pull request #1215: URL: https://github.com/apache/hadoop-ozone/pull/1215#discussion_r456730693 ## File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java ## @@ -397,6 +398,32 @@ public

[GitHub] [hadoop-ozone] smengcl commented on pull request #1215: HDDS-3982. Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread GitBox
smengcl commented on pull request #1215: URL: https://github.com/apache/hadoop-ozone/pull/1215#issuecomment-660403477 @umamaheswararao Thanks for the review. One question about the `fs.trash.classname` though: I actually thought about overriding it. But once this is configured to a

[GitHub] [hadoop-ozone] smengcl edited a comment on pull request #1215: HDDS-3982. Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread GitBox
smengcl edited a comment on pull request #1215: URL: https://github.com/apache/hadoop-ozone/pull/1215#issuecomment-660403477 @umamaheswararao Thanks for the review. One question about the `fs.trash.classname` though: I actually thought about overriding it. But once this is

[GitHub] [hadoop-ozone] smengcl edited a comment on pull request #1215: HDDS-3982. Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread GitBox
smengcl edited a comment on pull request #1215: URL: https://github.com/apache/hadoop-ozone/pull/1215#issuecomment-660403477 @umamaheswararao Thanks for the review. One question about the `fs.trash.classname` though: I actually thought about overriding it. But once this is

[jira] [Resolved] (HDDS-3965) SCM failed to start up for duplicated pipeline detected

2020-07-17 Thread Nanda kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda kumar resolved HDDS-3965. --- Fix Version/s: 0.6.0 Resolution: Fixed > SCM failed to start up for duplicated pipeline

[GitHub] [hadoop-ozone] smengcl opened a new pull request #1215: HDDS-3982. Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread GitBox
smengcl opened a new pull request #1215: URL: https://github.com/apache/hadoop-ozone/pull/1215 ## What changes were proposed in this pull request? A proper server-side trash cleanup solution (HDDS-3915) might not land any time soon. This jira aims to completely disable "move

[jira] [Updated] (HDDS-3982) Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3982: - Labels: pull-request-available (was: ) > Disable moveToTrash in o3fs and ofs temporarily >

[jira] [Updated] (HDDS-3982) Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3982: - Description: A proper server-side trash cleanup solution (HDDS-3915) might not land any time soon. This

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456633185 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java ## @@ -327,7 +344,164 @@

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456625155 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java ## @@ -141,7 +141,6 @@ public

[jira] [Updated] (HDDS-3976) KeyValueBlockIterator#nextBlock skips valid blocks

2020-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3976: - Labels: pull-request-available (was: ) > KeyValueBlockIterator#nextBlock skips valid blocks >

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456631870 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java ## @@ -327,7 +344,164 @@

[jira] [Updated] (HDDS-3982) Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3982: - Description: A proper server-side trash cleanup solution (HDDS-3915) might not land any time soon. This

[GitHub] [hadoop-ozone] hanishakoneru merged pull request #1129: HDDS-3741. Reload old OM state if Install Snapshot from Leader fails

2020-07-17 Thread GitBox
hanishakoneru merged pull request #1129: URL: https://github.com/apache/hadoop-ozone/pull/1129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (HDDS-3982) Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread Siyao Meng (Jira)
Siyao Meng created HDDS-3982: Summary: Disable moveToTrash in o3fs and ofs temporarily Key: HDDS-3982 URL: https://issues.apache.org/jira/browse/HDDS-3982 Project: Hadoop Distributed Data Store

[jira] [Created] (HDDS-3983) Ozone RocksDB Iterator wrapper should not expose key() and value() API.

2020-07-17 Thread Aravindan Vijayan (Jira)
Aravindan Vijayan created HDDS-3983: --- Summary: Ozone RocksDB Iterator wrapper should not expose key() and value() API. Key: HDDS-3983 URL: https://issues.apache.org/jira/browse/HDDS-3983 Project:

[jira] [Updated] (HDDS-3983) Ozone RocksDB Iterator wrapper should not expose key() and value() API.

2020-07-17 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan updated HDDS-3983: Description: While investigating HDDS-3965 with [~nanda619], it was found that there is

[jira] [Updated] (HDDS-3983) Ozone RocksDB Iterator wrapper should not expose key() and value() API.

2020-07-17 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan updated HDDS-3983: Description: While investigating HDDS-3965 with [~nanda619], it was found that there is

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456625606 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java ## @@ -265,4 +273,72 @@ public

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456625982 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java ## @@ -91,6 +99,19 @@ public

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456631086 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java ## @@ -327,7 +344,164 @@

[GitHub] [hadoop-ozone] errose28 opened a new pull request #1216: HDDS-3976. KeyValueBlockIterator#nextBlock skips valid blocks

2020-07-17 Thread GitBox
errose28 opened a new pull request #1216: URL: https://github.com/apache/hadoop-ozone/pull/1216 ## What changes were proposed in this pull request? 1. Fix the bug in KeyValueBlockIterator#nextBlocks that skips keys passing the prefix filter when all prefixed keys do not occur at the

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
bharatviswa504 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r45947 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java ## @@ -327,7

[jira] [Commented] (HDDS-3965) SCM failed to start up for duplicated pipeline detected

2020-07-17 Thread Nanda kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160141#comment-17160141 ] Nanda kumar commented on HDDS-3965: --- Thanks [~avijayan] for the contribution. Thank you [~Sammi] for

[GitHub] [hadoop-ozone] nandakumar131 merged pull request #1210: HDDS-3965. SCM failed to start up for duplicated pipeline detected.

2020-07-17 Thread GitBox
nandakumar131 merged pull request #1210: URL: https://github.com/apache/hadoop-ozone/pull/1210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Comment Edited] (HDDS-3976) KeyValueBlockIterator#nextBlock skips valid blocks

2020-07-17 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160023#comment-17160023 ] Ethan Rose edited comment on HDDS-3976 at 7/17/20, 7:00 PM: Implementing

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
arp7 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456622410 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java ## @@ -265,4 +273,72 @@ public

[jira] [Updated] (HDDS-3982) Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3982: - Description: A proper server-side trash cleanup solution (HDDS-3915) might not land any time soon. This

[jira] [Updated] (HDDS-3982) Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3982: - Status: Patch Available (was: Open) > Disable moveToTrash in o3fs and ofs temporarily >

[jira] [Updated] (HDDS-3982) Disable moveToTrash in o3fs and ofs temporarily

2020-07-17 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3982: - Description: A proper server-side trash cleanup solution (HDDS-3915) might not land any time soon. This

[jira] [Updated] (HDDS-3915) Simple trash emptier on OM

2020-07-17 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3915: - Description: Implementation something similar to HDFS's {{NameNode#startTrashEmptier}} in OzoneManager

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1196: HDDS-3955. Unable to list intermediate paths on keys created using S3G.

2020-07-17 Thread GitBox
bharatviswa504 commented on a change in pull request #1196: URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r456668701 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java ## @@ -327,7