[Bug 1885430] Review Request: qatlib - Intel® QuickAssist Technology Library

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1885430 --- Comment #7 from Carl George 鸞 --- > as the code contains some snippets of OpenSSL libcrypto. If this package is going to bundle openssl (even if only partially), there are two MUST requirements [0]. 1. Add the line `Provides:

[Bug 1887621] Review Request: folly - An open-source C++ library developed and used at Facebook

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1887621 --- Comment #11 from Neal Gompa --- (In reply to Davide Cavalca from comment #10) > (In reply to Neal Gompa from comment #9) > > You'd want to adjust the build script to set the soversion to match version. > > Otherwise the generated

[Bug 1889105] Review Request: dialect - A translation app for GNOME based on Google Translate

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889105 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dialect -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1887621] Review Request: folly - An open-source C++ library developed and used at Facebook

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1887621 --- Comment #10 from Davide Cavalca --- (In reply to Neal Gompa from comment #9) > You'd want to adjust the build script to set the soversion to match version. > Otherwise the generated dependency would be broken or otherwise wrong. > > You

[Bug 1889387] Review Request: rust-alacritty - GPU-accelerated terminal emulator

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889387 --- Comment #4 from Fabio Valentini --- Okay, fedora-review is busted, because somebody broke rawhide. Last question: why only "Recommends: ncurses-base >= 6.2" and not "Requires"? Does the ncurses-base package only provide optional

[Bug 1886458] Review Request: rust-serial_test_derive - Helper crate for serial_test

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1886458 --- Comment #3 from Fabio Valentini --- Sure, I'll do the other review once this package has been imported and built. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this

[Bug 1889387] Review Request: rust-alacritty - GPU-accelerated terminal emulator

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889387 --- Comment #3 from Fabio Valentini --- I have one question: %if !%{build_terminfo} tic -xe alacritty,alacritty-direct %{crate}-%{version_no_tilde}/extra/alacritty.info \ -o %{buildroot}%{_datadir}/terminfo %endif This means that "if

[Bug 1887621] Review Request: folly - An open-source C++ library developed and used at Facebook

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1887621 --- Comment #9 from Neal Gompa --- (In reply to Michel Alexandre Salim from comment #8) > (In reply to Neal Gompa from comment #6) > > (In reply to Davide Cavalca from comment #4) > > > > > > About the static libraries: folly doesn't have a

[Bug 1867290] Review Request: editline - A small compatible replacement for readline

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1867290 --- Comment #17 from Fedora Update System --- FEDORA-EPEL-2020-c508531951 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here:

[Bug 1867290] Review Request: editline - A small compatible replacement for readline

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1867290 --- Comment #16 from Fedora Update System --- FEDORA-EPEL-2020-10f5ee1341 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here:

[Bug 1867290] Review Request: editline - A small compatible replacement for readline

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1867290 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from

[Bug 1887621] Review Request: folly - An open-source C++ library developed and used at Facebook

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1887621 --- Comment #8 from Michel Alexandre Salim --- (In reply to Neal Gompa from comment #6) > (In reply to Davide Cavalca from comment #4) > > > > About the static libraries: folly doesn't have a stable ABI, by design, so > > it doesn't seem

[Bug 1889104] Review Request: python-googletrans - Google Translate API for Python

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889104 --- Comment #9 from Lyes Saadi --- > I recommend relaxing the dependency in setup.py instead and submitting a pull > request / patch upstream. I can see why. I'll make sure to patch the setup.py to do that before importing. We can never be

[Bug 1888973] Review Request: golang-github-common-nighthawk-figure - Prints ASCII art from text

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888973 --- Comment #1 from Andy Mender --- Looks good in general, but the "docs" dir is too big and should be split off into its own -doc subpackage. Full review below: Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not

[Bug 1888973] Review Request: golang-github-common-nighthawk-figure - Prints ASCII art from text

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888973 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug 1888975] Review Request: golang-github-akamensky-argparse- Argparse for Golang

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888975 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review?

[Bug 1888975] Review Request: golang-github-akamensky-argparse- Argparse for Golang

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888975 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug 1888963] Review Request: crlfuzz - Tool to scan CRLF vulnerability

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888963 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review?

[Bug 1888452] Review Request: python-nuheat - Python library for NuHeat Signature radiant floor thermostats

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888452 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review?

[Bug 1867290] Review Request: editline - A small compatible replacement for readline

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1867290 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2020-10f5ee1341 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-10f5ee1341 -- You are receiving this mail because: You are

[Bug 1888963] Review Request: crlfuzz - Tool to scan CRLF vulnerability

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888963 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug 1888452] Review Request: python-nuheat - Python library for NuHeat Signature radiant floor thermostats

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888452 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug 1889072] Review Request: argyllcms - ICC compatible color management system

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889072 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review?

[Bug 1885430] Review Request: qatlib - Intel® QuickAssist Technology Library

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1885430 --- Comment #6 from giovanni.cabi...@intel.com --- Spec URL: https://raw.githubusercontent.com/intel/qatlib/v20_08/rpm/qatlib.spec SRPM URL: https://raw.githubusercontent.com/intel/qatlib/v20_08/rpm/qatlib-20.08.0-1.fc32.src.rpm >The license

[Bug 1867290] Review Request: editline - A small compatible replacement for readline

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1867290 --- Comment #13 from Fedora Update System --- FEDORA-EPEL-2020-c508531951 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-c508531951 -- You are receiving this mail because: You are

[Bug 1867290] Review Request: editline - A small compatible replacement for readline

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1867290 --- Comment #12 from Fedora Update System --- FEDORA-2020-bce6bf5d10 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-bce6bf5d10 -- You are receiving this mail because: You are on the CC

[Bug 1886458] Review Request: rust-serial_test_derive - Helper crate for serial_test

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1886458 --- Comment #2 from Javier Martinez Canillas --- (In reply to Fabio Valentini from comment #1) Thanks a lot for the review! [snip] > > SHOULD: > > [!]: If the source package does not include license text(s) as a separate > file from

[Bug 1867290] Review Request: editline - A small compatible replacement for readline

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1867290 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #11 from

[Bug 1889768] New: Review Request: oraculum - Backend and API for Fedora QA Dashboard

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889768 Bug ID: 1889768 Summary: Review Request: oraculum - Backend and API for Fedora QA Dashboard Product: Fedora Version: rawhide Status: NEW Component: Package

[Bug 1889387] Review Request: rust-alacritty - GPU-accelerated terminal emulator

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889387 --- Comment #2 from Stefano Figura --- Thanks for the review but especially for all the advice! Thanks to your guidance I have learned so much in the last couple of days. I have updated the spec file and the source RPM. Hopefully I have

[Bug 1889362] Review Request: python-fastjsonschema - Fastest Python implementation of JSON schema

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889362 --- Comment #6 from Tomáš Hrnčiar --- Updated Spec: https://download.copr.fedorainfracloud.org/results/thrnciar/python-fastjsonschema/fedora-rawhide-x86_64/01713797-python-fastjsonschema/python-fastjsonschema.spec SRPM:

[Bug 1889705] New: Review Request: perl-Test-Net-LDAP - Net::LDAP subclass for testing

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889705 Bug ID: 1889705 Summary: Review Request: perl-Test-Net-LDAP - Net::LDAP subclass for testing Product: Fedora Version: rawhide Hardware: All OS: Linux

[Bug 1889362] Review Request: python-fastjsonschema - Fastest Python implementation of JSON schema

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889362 --- Comment #5 from Miro Hrončok --- Now %pypi_name is python-fastjsonschema which is also not consistent with reality, because the pypi_name is fastjsonschema. Also, the package name is python3-python-fastjsonschema whch is not what the

[Bug 1889652] Review Request: python-adafruit-pureio - Python access to Linux IO including I2C and SPI

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889652 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Doc Type|---

[Bug 1889652] New: Review Request: python-adafruit-pureio - Python access to Linux IO including I2C and SPI

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889652 Bug ID: 1889652 Summary: Review Request: python-adafruit-pureio - Python access to Linux IO including I2C and SPI Product: Fedora Version: rawhide Hardware: All

[Bug 1889634] Review Request: python-zeep - Modern and fast Python SOAP client

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889634 Fabian Affolter changed: What|Removed |Added Depends On||1889431 Doc Type|---

[Bug 1889431] Review Request: python-pytest-httpx - Send responses to httpx

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889431 Fabian Affolter changed: What|Removed |Added Blocks||1889634 Referenced Bugs:

[Bug 1889634] New: Review Request: python-zeep - Modern and fast Python SOAP client

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889634 Bug ID: 1889634 Summary: Review Request: python-zeep - Modern and fast Python SOAP client Product: Fedora Version: rawhide Hardware: All OS: Linux

[Bug 1889072] Review Request: argyllcms - ICC compatible color management system

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889072 --- Comment #4 from Vitaly Zaitsev --- > Is the fork just a different URL or is it a different project? From the > GitHub page it seems like it's a thin wrapper around the original argyllcms > located here: http://www.argyllcms.com/ You

[Bug 1889625] New: Review Request: python-respx - Utility for mocking out the HTTPX and HTTP Core libraries

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889625 Bug ID: 1889625 Summary: Review Request: python-respx - Utility for mocking out the HTTPX and HTTP Core libraries Product: Fedora Version: rawhide Hardware: All

[Bug 1889619] Review Request: python-adext - Python module to extend AlarmDecoder module

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889619 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Depends On|

[Bug 1889611] Review Request: python-alarmdecoder - Python interface for the AlarmDecoder (AD2) devices

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889611 Fabian Affolter changed: What|Removed |Added Blocks||1889619 Referenced Bugs:

[Bug 1889619] New: Review Request: python-adext - Python module to extend AlarmDecoder module

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889619 Bug ID: 1889619 Summary: Review Request: python-adext - Python module to extend AlarmDecoder module Product: Fedora Version: rawhide Hardware: All OS:

[Bug 1889611] Review Request: python-alarmdecoder - Python interface for the AlarmDecoder (AD2) devices

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889611 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Doc Type|---

[Bug 1889611] New: Review Request: python-alarmdecoder - Python interface for the AlarmDecoder (AD2) devices

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889611 Bug ID: 1889611 Summary: Review Request: python-alarmdecoder - Python interface for the AlarmDecoder (AD2) devices Product: Fedora Version: rawhide Hardware: All

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 Bug 1465889 depends on bug 1880848, which changed state. Bug 1880848 Summary: Review Request: golang-github-rickb777-date - A Go package for working with dates https://bugzilla.redhat.com/show_bug.cgi?id=1880848 What|Removed

[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1880848 Robin Lee changed: What|Removed |Added Status|POST|CLOSED Fixed In Version|

[Bug 1889606] Review Request: python-pygrocy - Python API client for grocy

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889606 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Doc Type|---

[Bug 1889606] New: Review Request: python-pygrocy - Python API client for grocy

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889606 Bug ID: 1889606 Summary: Review Request: python-pygrocy - Python API client for grocy Product: Fedora Version: rawhide Hardware: All OS: Linux

[Bug 1889362] Review Request: python-fastjsonschema - Fastest Python implementation of JSON schema

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889362 --- Comment #4 from Tomáš Hrnčiar --- Updated spec file and SRPM. Spec: https://download.copr.fedorainfracloud.org/results/thrnciar/python-fastjsonschema/fedora-rawhide-x86_64/01713447-python-fastjsonschema/python-fastjsonschema.spec SRPM:

[Bug 1889362] Review Request: python-fastjsonschema - Fastest Python implementation of JSON schema

2020-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1889362 --- Comment #3 from Tomáš Hrnčiar --- (In reply to Miro Hrončok from comment #2) > Curiosity question: > > %pytest -m "not benchmark" > > This looks copy-pasted-adapted from tox.ini. Since you use > %pyproject_buildrequires -t, I'd consider