[Bug 1833741] Review Request: python-colcon-lcov-result - Extension for colcon to provide test results using LCOV
https://bugzilla.redhat.com/show_bug.cgi?id=1833741 --- Comment #8 from Fedora Update System --- FEDORA-2020-078fd6a431 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-078fd6a431 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-078fd6a431 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833745] Review Request: python-colcon-ed - Extension for colcon to edit a file within a package
https://bugzilla.redhat.com/show_bug.cgi?id=1833745 --- Comment #8 from Fedora Update System --- FEDORA-2020-84cf8d20b2 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-84cf8d20b2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-84cf8d20b2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834496] Review Request: python-colcon-coveragepy-result - Extension for colcon to collect coverage.py results
https://bugzilla.redhat.com/show_bug.cgi?id=1834496 --- Comment #8 from Fedora Update System --- FEDORA-2020-a1b70feb8c has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a1b70feb8c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a1b70feb8c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833745] Review Request: python-colcon-ed - Extension for colcon to edit a file within a package
https://bugzilla.redhat.com/show_bug.cgi?id=1833745 --- Comment #7 from Fedora Update System --- FEDORA-EPEL-2020-e0db4e4fcc has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-e0db4e4fcc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833741] Review Request: python-colcon-lcov-result - Extension for colcon to provide test results using LCOV
https://bugzilla.redhat.com/show_bug.cgi?id=1833741 --- Comment #7 from Fedora Update System --- FEDORA-EPEL-2020-8ac7fd1c04 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8ac7fd1c04 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834496] Review Request: python-colcon-coveragepy-result - Extension for colcon to collect coverage.py results
https://bugzilla.redhat.com/show_bug.cgi?id=1834496 --- Comment #7 from Fedora Update System --- FEDORA-EPEL-2020-6beba110a6 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6beba110a6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833745] Review Request: python-colcon-ed - Extension for colcon to edit a file within a package
https://bugzilla.redhat.com/show_bug.cgi?id=1833745 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-b3d9acc24b has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-b3d9acc24b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b3d9acc24b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818945] Review Request: lib3mf - Implementation of the 3D Manufacturing Format file standard
https://bugzilla.redhat.com/show_bug.cgi?id=1818945 --- Comment #13 from Fedora Update System --- FEDORA-EPEL-2020-6ecb9adca3 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834496] Review Request: python-colcon-coveragepy-result - Extension for colcon to collect coverage.py results
https://bugzilla.redhat.com/show_bug.cgi?id=1834496 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-0f3edb67c9 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-0f3edb67c9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0f3edb67c9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819148] Review Request: act - Automatic Component Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1819148 --- Comment #13 from Fedora Update System --- FEDORA-EPEL-2020-6ecb9adca3 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833741] Review Request: python-colcon-lcov-result - Extension for colcon to provide test results using LCOV
https://bugzilla.redhat.com/show_bug.cgi?id=1833741 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-4fc6b2fdea has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-4fc6b2fdea \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4fc6b2fdea See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833473] Review Request: ocaml-ppxlib - Base library and tools for ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1833473 Bug 1833473 depends on bug 1833472, which changed state. Bug 1833472 Summary: Review Request: ocaml-compiler-libs-janestreet - OCaml compiler libraries repackaged https://bugzilla.redhat.com/show_bug.cgi?id=1833472 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833472] Review Request: ocaml-compiler-libs-janestreet - OCaml compiler libraries repackaged
https://bugzilla.redhat.com/show_bug.cgi?id=1833472 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-21 02:52:40 --- Comment #6 from Fedora Update System --- FEDORA-2020-362803c457 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835263] Review Request: perl-Crypt-PWSafe3 - Read and write Passwordsafe v3 files
https://bugzilla.redhat.com/show_bug.cgi?id=1835263 Charles R. Anderson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-05-21 01:03:46 --- Comment #6 from Charles R. Anderson --- Build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=44747424 and f32: https://koji.fedoraproject.org/koji/taskinfo?taskID=44747511 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838306] New: Review Request: golang-github-graph-gophers-graphql - GraphQL server with a focus on ease of use
https://bugzilla.redhat.com/show_bug.cgi?id=1838306 Bug ID: 1838306 Summary: Review Request: golang-github-graph-gophers-graphql - GraphQL server with a focus on ease of use Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-graph-gophers-graphql.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-graph-gophers-graphql-0-0.1.20200520gitdae41bd.fc31.src.rpm Project URL: https://github.com/graph-gophers/graphql-go Description: GraphQL server with a focus on ease of use. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44741337 rpmlint output: $ rpmlint golang-github-graph-gophers-graphql-0-0.1.20200520gitdae41bd.fc31.src.rpm golang-github-graph-gophers-graphql.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-graph-gophers-graphql-devel-0-0.1.20200520gitdae41bd.fc31.noarch.rpm golang-github-graph-gophers-graphql-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/graph-gophers/graphql-go/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834977] Review Request: python-cchardet - High speed universal character encoding detector
https://bugzilla.redhat.com/show_bug.cgi?id=1834977 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cchardet -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833741] Review Request: python-colcon-lcov-result - Extension for colcon to provide test results using LCOV
https://bugzilla.redhat.com/show_bug.cgi?id=1833741 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2020-078fd6a431 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-078fd6a431 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833741] Review Request: python-colcon-lcov-result - Extension for colcon to provide test results using LCOV
https://bugzilla.redhat.com/show_bug.cgi?id=1833741 --- Comment #5 from Fedora Update System --- FEDORA-EPEL-2020-8ac7fd1c04 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8ac7fd1c04 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833745] Review Request: python-colcon-ed - Extension for colcon to edit a file within a package
https://bugzilla.redhat.com/show_bug.cgi?id=1833745 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2020-84cf8d20b2 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-84cf8d20b2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833745] Review Request: python-colcon-ed - Extension for colcon to edit a file within a package
https://bugzilla.redhat.com/show_bug.cgi?id=1833745 --- Comment #5 from Fedora Update System --- FEDORA-EPEL-2020-e0db4e4fcc has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-e0db4e4fcc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834496] Review Request: python-colcon-coveragepy-result - Extension for colcon to collect coverage.py results
https://bugzilla.redhat.com/show_bug.cgi?id=1834496 --- Comment #5 from Fedora Update System --- FEDORA-EPEL-2020-6beba110a6 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6beba110a6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834496] Review Request: python-colcon-coveragepy-result - Extension for colcon to collect coverage.py results
https://bugzilla.redhat.com/show_bug.cgi?id=1834496 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2020-0f3edb67c9 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0f3edb67c9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818176] Review Request: calls - A phone dialer and call handler.
https://bugzilla.redhat.com/show_bug.cgi?id=1818176 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/calls -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838033] Review Request: jakarta-activation - Jakarta Activation Specification and Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1838033 Fabio Valentini changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-20 17:33:19 --- Comment #4 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1509081 Submitted to F32 and F31 to replace the botch-retired jaf: https://bodhi.fedoraproject.org/updates/FEDORA-2020-bae32b4167 https://bodhi.fedoraproject.org/updates/FEDORA-2020-078132ba99 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #5 from Erich Eickmeyer --- Thanks, Artur. Either way, I made the correction in the above-posted links (Comment 3). :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824156] Review Request: exfatprogs - Userspace utilities for exFAT filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1824156 --- Comment #26 from Eric Sandeen --- (to put a finer point on it, I'd drop the whole -devel package; make install does not install headers, they aren't meant for public consumption) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #30 from Kelly Brazil --- Let me know if there is anything I need to do. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 --- Comment #3 from Paul Dufresne --- Created attachment 1690304 --> https://bugzilla.redhat.com/attachment.cgi?id=1690304=edit Paul Dufresne... version 1 (for this bug) of 7kaa.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 Paul Dufresne changed: What|Removed |Added CC||dufres...@zoho.com --- Comment #2 from Paul Dufresne --- Hi! I am in a similar situation as you do... not a developer... yet... and having resurrected (at least for me) 7kaa, about 1 or 2 months ago. I had/have the feeling that you have to come with your own package to request to become a Fedora developer, rathern than unretire... so as to show your skills. So I was/am still searching a project to package... and got entangled with the release of Fedora 32, and trying to catch up with the devel mailing list. I did use other distros info when I made my 7kaa package... in part for the description... that I stole from OpenSuse ... I think. Anyway... I think I will just attach my spec file here... as a point of comparison ... I did not even try to compare with yours yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824156] Review Request: exfatprogs - Userspace utilities for exFAT filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1824156 --- Comment #25 from Eric Sandeen --- If upstream is not building shared libraries or providing a stable API, Fedora should not try to do on its own. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818176] Review Request: calls - A phone dialer and call handler.
https://bugzilla.redhat.com/show_bug.cgi?id=1818176 Jared Smith changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Jared Smith --- Your package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838027] Review Request: zuul - Trunk Gating System
https://bugzilla.redhat.com/show_bug.cgi?id=1838027
--- Comment #4 from Miro Hrončok ---
8)
%files doc
%doc build/html LICENSE README.fedora
LICENSE should be marked as %license, not %doc.
Other (sub)packages don't have LICENSE packaged at all.
9) rpmlint screams with problems. I've picked some I don't understand, are they
expected?
zuul.noarch: W: non-standard-gid /etc/zuul/zuul.conf zuul
zuul.noarch: E: non-readable /etc/zuul/zuul.conf 640
zuul.noarch: W: non-standard-uid /usr/lib64/zuul zuul
zuul.noarch: W: non-standard-gid /usr/lib64/zuul zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/.ssh zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/.ssh zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/keys zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/keys zuul
zuul.noarch: W: non-standard-uid /var/log/zuul zuul
zuul.noarch: W: non-standard-gid /var/log/zuul zuul
zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul
zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul
zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/executor zuul
zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/executor zuul
And some that should probably be fixed:
zuul.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/zuul/ansible/base/library/command.py 644
/usr/bin/python3
zuul.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/zuul/ansible/base/library/zuul_console.py 644
/usr/bin/python3
zuul.noarch: W: log-files-without-logrotate ['/var/log/zuul']
zuul-scheduler.noarch: W: empty-%postun
zuul-merger.noarch: W: empty-%postun
zuul-web.noarch: W: empty-%postun
zuul-executor.noarch: W: empty-%postun
zuul-fingergw.noarch: W: empty-%postun
zuul-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zuul-doc/LICENSE
Those can (and should) be deleted:
zuul-doc.noarch: W: hidden-file-or-dir /usr/share/doc/zuul-doc/html/.buildinfo
zuul-doc.noarch: W: hidden-file-or-dir /usr/share/doc/zuul-doc/html/.doctrees
zuul.src:307: W: libdir-macro-in-noarch-package (main package) %dir %attr(0755,
zuul, zuul) %{_libdir}/zuul
This is a warning, but will actually break things if built on 64bit builder but
installed on 32bit system, %{_libdir} is /usr/lib64 on 64bits. Either the
package needs to be arched, or this needs to be hardcoded to %{_prefix}/lib.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838033] Review Request: jakarta-activation - Jakarta Activation Specification and Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1838033 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jakarta-activation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838027] Review Request: zuul - Trunk Gating System
https://bugzilla.redhat.com/show_bug.cgi?id=1838027
--- Comment #3 from Miro Hrončok ---
> Done, but I was unable to use the macro neither to find it.
The macro is in python3-rpm-macros since yesterday:
https://src.fedoraproject.org/rpms/python-rpm-macros/pull-request/58 -- going
with a direct pathfix.py call is OK (unless you feel very leading edge).
> /usr/bin/pathfix.py -i /usr/bin/python3 -p -n -k zuul/ansible
Could you please use %{python3} over hardcoded /usr/bin/python3?
BTW zuul-webui has no dependency on zuul, that is intentional? I haven't
checked the Fedora README yet.
I'll run fedora-review now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838033] Review Request: jakarta-activation - Jakarta Activation Specification and Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1838033 --- Comment #2 from Fabio Valentini --- Thanks for the review! Two comments for posterity: Yes, I plan to update to the latest version once we have Java 11 by default. This package is still available on f32 due to the botched retirement, so I don't really need to push it there as well ... but since jaf failed to build since fedora 31, I could just push it in f31 and f32 too. /shrug In both the upstream git repo and the official website, the project is referred to as "Jakarta Activation", and on the website they write that the project was previously named JAF (JavaBean Activation Framework), which is why I went with jakarta-activation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838033] Review Request: jakarta-activation - Jakarta Activation Specification and Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1838033 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |POST CC||zbys...@in.waw.pl Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek --- We have https://fedoraproject.org/wiki/Changes/Java11, so 1.2.2 could be packaged. But I assume that you want this for F32 too, so holding back seems appropriate. Once the new java is the default, the update should be pushed to rawhide. Original review: #1649574 + package name is OK (I guess, it seems better than jaf) + license is OK: BSD + builds and installs OK + BR: maven-local is present + BR/P/R look OK + P/O look OK + latest version (see the discussion above) + rpmlint and fedora-review are happy Package is RE-APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838027] Review Request: zuul - Trunk Gating System
https://bugzilla.redhat.com/show_bug.cgi?id=1838027
--- Comment #2 from Fabien Boucher ---
(In reply to Miro Hrončok from comment #1)
> spec sanity:
>
>
> 1) %global srcname zuul -> consider dropping this, I don't see it used
> anywhere in the spec
done
>
> 2) 0001-Remove-another-shebang-and-remove-useless-exec-bits.patch -> is the
> mode thing supported by regular patch, or is %autosetup -S git needed for
> this?
Looking the buildroot yes the file mode is correct so I assume autosetup w/o
-S git is sufficient
>
> 3) %package webui etc. -> should they all (except maybe doc) have: Requires:
> %{name} = %{?epoch:%{epoch}:}%{version}-%{release} ?
Done
>
> 4) Requires: git -> is git-core not good enough?
Yes it seems sufficient, so I've switch for git-core.
>
> 5) various manual Requires on python3-... -> is the dependency generator
> not working? I see you rm requirements.txt, why is that?
>
Ok so I'll have a deeper look into that in the next round.
>
> 6) # Fix non compliant shebangs ... -> the complex fins+sed can be replaced
> with a single pathfix.py call (see /usr/bin/pathifx.py, also macronized as
> %py3_shebang_fix in rawhide, backports in progress)
>
Done, but I was unable to use the macro neither to find it.
>
> 7) %{python3_sitelib}/zuul-*.egg-info -> consider adding trailing slash to
> assert this is a directory
Done
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820850] Review Request: golang-github-jpillora-tld - TLD parser
https://bugzilla.redhat.com/show_bug.cgi?id=1820850 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-jpillora-tld -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838027] Review Request: zuul - Trunk Gating System
https://bugzilla.redhat.com/show_bug.cgi?id=1838027
--- Comment #1 from Miro Hrončok ---
spec sanity:
1) %global srcname zuul -> consider dropping this, I don't see it used anywhere
in the spec
2) 0001-Remove-another-shebang-and-remove-useless-exec-bits.patch -> is the
mode thing supported by regular patch, or is %autosetup -S git needed for this?
3) %package webui etc. -> should they all (except maybe doc) have: Requires:
%{name} = %{?epoch:%{epoch}:}%{version}-%{release} ?
4) Requires: git -> is git-core not good enough?
5) various manual Requires on python3-... -> is the dependency generator not
working? I see you rm requirements.txt, why is that?
6) # Fix non compliant shebangs ... -> the complex fins+sed can be replaced
with a single pathfix.py call (see /usr/bin/pathifx.py, also macronized as
%py3_shebang_fix in rawhide, backports in progress)
7) %{python3_sitelib}/zuul-*.egg-info -> consider adding trailing slash to
assert this is a directory
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833405] Review Request: python-ufoLib2 - A library to deal with UFO font sources
https://bugzilla.redhat.com/show_bug.cgi?id=1833405 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ufoLib2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 --- Comment #9 from Honggang LI --- 1 Package Review 2 == 3 4 Legend: 5 [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated 6 [ ] = Manual review needed 7 8 9 Issues: 10 === 11 - Development (unversioned) .so files in -devel subpackage, if present. 12Note: Unversioned so-files directly in %_libdir. 13See: https://docs.fedoraproject.org/en-US/packaging- 14guidelines/#_devel_packages That's OK, as the libvma-9.0.2-1.fc33.x86_64.rpm/usr/lib64/libvma.so file is used as PRE_LOAD. So, it should be included in the main sub-package. 15 - Package does not use a name that already exists. 16Note: A package with this name already exists. Please check 17https://src.fedoraproject.org/rpms/libvma 18See: https://docs.fedoraproject.org/en-US/packaging- 19guidelines/Naming/#_conflicting_package_names It's OK, as we are import libvma again for fedora. See https://bugzilla.redhat.com/show_bug.cgi?id=1826439#c3 . 20 21 22 = MUST items = 23 24 C/C++: 25 [ ]: Package does not contain kernel modules. PASS 26 [ ]: Package contains no static executables. PASS 27 [x]: If your application is a C or C++ application you must list a 28 BuildRequires against gcc, gcc-c++ or clang. 29 [x]: Header files in -devel subpackage, if present. 30 [x]: ldconfig not called in %post and %postun for Fedora 28 and later. 31 [x]: Package does not contain any libtool archives (.la) 32 [x]: Rpath absent or only used for internal libs. 33 34 Generic: 35 [ ]: Package is licensed with an open-source compatible license and meets 36 other legal requirements as defined in the legal section of Packaging 37 Guidelines. PASS 38 [ ]: License field in the package spec file matches the actual license. 39 Note: Checking patched sources after %prep for licenses. Licenses 40 found: "Unknown or generated", "BSD (unspecified) GPL (v2)", "BSD 41 3-clause "New" or "Revised" License", "GPL (v3 or later)", "BSD 42 2-clause "Simplified" License GPL (v2)", "Expat License". 113 files 43 have unknown license. Detailed output of licensecheck in 44 /home/honli/fedora/libvma/1826439-libvma/licensecheck.txt PASS 45 [ ]: License file installed when any subpackage combination is installed. PASS. 46 [ ]: If the package is under multiple licenses, the licensing breakdown 47 must be documented in the spec. PASS 48 [ ]: Package requires other packages for directories it uses. PASS 49 Note: No known owner of /usr/share/doc/libvma, /usr/include/mellanox Please fix this. /usr/share/doc/libvma should be owned by sub-package "libvma". /usr/include/mellanox should be owned by sub-package "libvma-devel". 50 [ ]: Package must own all directories that it creates. 51 Note: Directories without known owners: /etc/security/limits.d, 52 /etc/security, /usr/include/mellanox, /usr/share/doc/libvma PASS. The first two directories are co-owned. The last two are duplicated of line 49. 53 [ ]: %build honors applicable compiler flags or justifies otherwise. PASS 54 [ ]: Package contains no bundled libraries without FPC exception. PASS 55 [ ]: Changelog in prescribed format. PASS 56 [ ]: Sources contain only permissible code or content. PASS 57 [ ]: Package contains desktop file if it is a GUI application. PASS. Not GUI application. 58 [ ]: Development files must be in a -devel package PASS 59 [ ]: Package uses nothing in %doc for runtime. PASS 60 [ ]: Package consistently uses macros (instead of hard-coded directory 61 names). Except the doc dir. Others looks good. 62 [ ]: Package is named according to the Package Naming Guidelines. PASS 63 [ ]: Package does not generate any conflict. PASS 64 [ ]: Package obeys FHS, except libexecdir and /usr/target. PASS 65 [ ]: If the package is a rename of another package, proper Obsoletes and 66 Provides are present. PASS 67 [ ]: Requires correct, justified where necessary. PASS 68 [ ]: Spec file is legible and written in American English. PASS 69 [ ]: Package contains systemd file(s) if in need. PASS. Yes, it does. 70 [ ]: Useful -debuginfo package or justification otherwise. PASS 71 [ ]: Package is not known to require an ExcludeArch tag. PASS, see inline comments in spec file. 72 [ ]: Large documentation must go in a -doc subpackage. Large could be size 73 (~1MB) or number of files. 74 Note: Documentation size is 184320 bytes in 3 files. PASS 75 [ ]: Package complies to the Packaging Guidelines PASS 76 [x]: Package successfully compiles and builds
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 --- Comment #8 from Honggang LI --- Functional smoke test verified libvma works as expected. Performance significantly improved. +--+---+ |Socket over IPoIB |6.97 Gb/s | +--+---+ |libvma|24.4 Gb/s | +--+---+ [root@rdma-dev-21 ~]$ ibstat CA 'ibp130s0f1' CA type: MT4115 Number of ports: 1 Firmware version: 12.23.1020 Hardware version: 0 Node GUID: 0x248a07030049d4f1 System image GUID: 0x248a07030049d4f0 Port 1: State: Active Physical state: LinkUp Rate: 56 Base lid: 32 LMC: 0 SM lid: 1 Capability mask: 0x2659e848 Port GUID: 0x248a07030049d4f1 Link layer: InfiniBand CA 'rocep4s0' CA type: MT4115 Number of ports: 1 Firmware version: 12.23.1020 Hardware version: 0 Node GUID: 0x248a0703004bf094 System image GUID: 0x248a0703004bf094 Port 1: State: Active Physical state: LinkUp Rate: 100 Base lid: 0 LMC: 0 SM lid: 0 Capability mask: 0x0001 Port GUID: 0x268a07fffe4bf094 Link layer: Ethernet CA 'ibp130s0f0' CA type: MT4115 Number of ports: 1 Firmware version: 12.23.1020 Hardware version: 0 Node GUID: 0x248a07030049d4f0 System image GUID: 0x248a07030049d4f0 Port 1: State: Active Physical state: LinkUp Rate: 56 Base lid: 15 LMC: 0 SM lid: 13 Capability mask: 0x2659e848 Port GUID: 0x248a07030049d4f0 Link layer: InfiniBand [root@rdma-dev-21 ~]$ ip addr show mlx5_ib0 7: mlx5_ib0: mtu 2044 qdisc mq state UP group default qlen 256 link/infiniband 00:00:0e:27:fe:80:00:00:00:00:00:00:24:8a:07:03:00:49:d4:f0 brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff inet 172.31.0.121/24 brd 172.31.0.255 scope global dynamic noprefixroute mlx5_ib0 valid_lft 2861sec preferred_lft 2861sec inet6 fe80::268a:703:49:d4f0/64 scope link noprefixroute valid_lft forever preferred_lft forever [root@rdma-dev-21 ~]$ iperf -s Server listening on TCP port 5001 TCP window size: 128 KByte (default) [ 4] local 172.31.0.121 port 5001 connected with 172.31.0.122 port 58464 [ ID] Interval Transfer Bandwidth [ 4] 0.0-10.0 sec 8.12 GBytes 6.97 Gbits/sec [root@rdma-dev-22 ~]$ iperf -c 172.31.0.121 Client connecting to 172.31.0.121, TCP port 5001 TCP window size: 612 KByte (default) [ 3] local 172.31.0.122 port 58464 connected with 172.31.0.121 port 5001 [ ID] Interval Transfer Bandwidth [ 3] 0.0-10.0 sec 8.12 GBytes 6.98 Gbits/sec [root@rdma-dev-21 ~]$ VMA_SPEC=latency LD_PRELOAD=libvma.so iperf -s VMA INFO: --- VMA INFO: VMA_VERSION: 9.0.2-0 Release built on Apr 17 2020 00:00:00 VMA INFO: Cmd Line: iperf -s VMA INFO: --- VMA INFO: VMA Spec Latency[VMA_SPEC] VMA INFO: Log Level INFO [VMA_TRACELEVEL] VMA INFO: Ring On Device Memory TX 16384 [VMA_RING_DEV_MEM_TX] VMA INFO: Tx QP WRE 256 [VMA_TX_WRE] VMA INFO: Tx QP WRE Batching 4 [VMA_TX_WRE_BATCHING] VMA INFO: Rx QP WRE 256 [VMA_RX_WRE] VMA INFO: Rx QP WRE Batching 4 [VMA_RX_WRE_BATCHING] VMA INFO: Rx Poll Loops -1 [VMA_RX_POLL] VMA INFO: Rx Prefetch Bytes Before Poll 256 [VMA_RX_PREFETCH_BYTES_BEFORE_POLL] VMA INFO: GRO max streams0 [VMA_GRO_STREAMS_MAX] VMA INFO: Select Poll (usec) -1 [VMA_SELECT_POLL] VMA INFO: Select Poll OS Force Enabled [VMA_SELECT_POLL_OS_FORCE] VMA INFO: Select Poll OS Ratio 1 [VMA_SELECT_POLL_OS_RATIO] VMA INFO: Select Skip OS 1 [VMA_SELECT_SKIP_OS] VMA INFO: CQ Drain Interval (msec) 100
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439
--- Comment #7 from Honggang LI ---
$ cat -n libvma.spec
.
4 %{!?make_build: %global make_build %{__make} %{?_smp_mflags} %{?mflags}
V=1}
It was my bad. I should told you to delete line 4.
5 %{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}}
Why you think line 5 is necessary? Can we just delete it too?
40 This package includes headers for building programs with libvma's
interface
41 directly, as opposed to loading it dynamically with LD_PRELOAD.
Line 40 and 41 are in the base sub-package libvma's %description section. The
base sub-package
dose not include any header. It seems line 40 and 41 belongs to sub-package
libvma-devel's
%description section. Is it right?
52 Summary: Libvma utilities
57 analyzing Libvma statistic.
Please replace "Libvma" with "libvma" for line 52 and 57.
68 %configure --docdir=%{_pkgdocdir} \
^^
"--docdir=%{_pkgdocdir}" is unnecessary. Should be removed?
85%{?ldconfig}
92%{?ldconfig}
Why you need line 85 and 92?
105 %license COPYING
Should append "LICENSE" in line 105.
$ tar -tf libvma-9.0.2.tar.gz | grep -i license
libvma-9.0.2/LICENSE
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838056] Review Request: rubygem-ipaddr - A class to manipulate an IP address in ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1838056 Pavel Valena changed: What|Removed |Added Summary|Review Request: -|manipulate an IP address in ||ruby -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838056] New: Review Request: -
https://bugzilla.redhat.com/show_bug.cgi?id=1838056 Bug ID: 1838056 Summary: Review Request: - Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pval...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01392920-rubygem-ipaddr/rubygem-ipaddr.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01392920-rubygem-ipaddr/rubygem-ipaddr-1.2.2-1.fc33.src.rpm Description: IPAddr provides a set of methods to manipulate an IP address. Both IPv4 and IPv6 are supported. Fedora Account System Username: pvalena Copr build: https://copr.fedorainfracloud.org/coprs/pvalena/rubygems/build/1392920/ Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44643341 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838033] Review Request: jakarta-activation - Jakarta Activation Specification and Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1838033 Fabio Valentini changed: What|Removed |Added Blocks||1837685 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1837685 [Bug 1837685] F33FailsToInstall: jackson-module-jaxb-annotations -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 --- Comment #6 from Honggang LI --- (In reply to igor.ivanov.va from comment #5) > Thank you for review > > libvma.spec has been updated accordingly. > > There are a couple of notes: > 1. After applying changes to meet > https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets > requirements > rpmlint reports error: > libvma.x86_64: E: postin-without-ldconfig /usr/lib64/libvma.so.9.0.2 > This package contains a library and its %post scriptlet doesn't call > ldconfig. > > libvma.x86_64: E: postun-without-ldconfig /usr/lib64/libvma.so.9.0.2 > This package contains a library and its %postun doesn't call ldconfig. > That's OK, as it is a rpmlint bug. > I am using rpmlint version 1.10 on fc30 > > 2. I would like to avoid putting man page for executable 'vma_stats' at the > moment unless it must be done. Yes, it is necessary. Please try search with key words " Man page scan results" in bugzilla. It gives 441 bugs for me. That means 441 bugs had been opened to handle manpage like this. https://pagure.io/ManualPageScan/ $ rpm -qpl libvma*rpm | grep bin /usr/sbin/vma /usr/sbin/vmad /usr/bin/vma_stats /usr/sbin/vma is a bash script. It is OK to ignore manpage for it. But vmad and vma_stats are executables, we should provide manpage for them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838027] Review Request: zuul - Trunk Gating System
https://bugzilla.redhat.com/show_bug.cgi?id=1838027 Fabien Boucher changed: What|Removed |Added CC||fbouc...@redhat.com, ||mhron...@redhat.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838033] New: Review Request: jakarta-activation - Jakarta Activation Specification and Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1838033 Bug ID: 1838033 Summary: Review Request: jakarta-activation - Jakarta Activation Specification and Implementation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://decathorpe.fedorapeople.org/packages/jakarta-activation.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/jakarta-activation-1.2.1-5.fc32.src.rpm Description: Jakarta Activation lets you take advantage of standard services to: determine the type of an arbitrary piece of data; encapsulate access to it; discover the operations available on it; and instantiate the appropriate bean to perform the operation(s). Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=44727016 Note 1: Version 1.2.2 is available upstream, but it requires Java 9+. Note 2: This package has previously been packaged as "jaf", but was retired (even if the retirement was botched, e.g. retirement commit merged back to stable branches ...) The last build of "jaf" that is available on fedora 30-32 is jaf-1.2.1-4.fc30, which is why this new package will "Obsoletes: jaf < 1.2.1-5". See: https://koji.fedoraproject.org/koji/buildinfo?buildID=1189610 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838027] New: Review Request: zuul - Trunk Gating System
https://bugzilla.redhat.com/show_bug.cgi?id=1838027 Bug ID: 1838027 Summary: Review Request: zuul - Trunk Gating System Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fbouc...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fbo.fedorapeople.org/zuul/zuul.spec SRPM URL: https://fbo.fedorapeople.org/zuul/zuul-3.18.0-2.fc33.src.rpm Description: Zuul is a program that drives continuous integration, delivery, and deployment systems with a focus on project gating and interrelated projects. Fedora Account System Username: fbo Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44726648 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824156] Review Request: exfatprogs - Userspace utilities for exFAT filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1824156 --- Comment #24 from Simone Caronni --- Thanks for the review. I'm updating to 1.0.3, upstream has disabled building shared libraries: https://github.com/exfatprogs/exfatprogs/commit/9d5bb880e3c310012c75f590f53e0f70a8173cef#diff-e8acc63b1e238f3255c900eed37254b8 But headers are installed anyway. Shall I revert the relevant commits so we have a shared library again or just remove the library part? I think the library might come handy. > libexfat.x86_64: E: script-without-shebang > /usr/share/licenses/libexfat/COPYING I will fix this in the spec file for 1.0.3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #21 from Neil Horman --- sure, I'll take this offline though, so we don't confuse the review with troubleshooting this. I'll send you email shortly -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Artur Iwicki changed: What|Removed |Added Flags|needinfo?(fed...@svgames.pl | |) | --- Comment #4 from Artur Iwicki --- >There is nothing in that link that says that `rm -rf $RPM_BUILD_ROOT` should >not be used. It says this: >The contents of the buildroot SHOULD NOT be removed in the first line of >%install I'd argue that nuking the directory counts as "removing its contents". ;) >Besides, that was part of the default rpm spec template, so does that mean >there's a bug in the template? I guess so. Since some time ago, templates are no longer active by default (i.e. "vim some_new_package.spec" opens with an empty file), so it's possible they've been neglected a bit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807365] Review Request: nuspell - Free and open source C++ spell checking library
https://bugzilla.redhat.com/show_bug.cgi?id=1807365 --- Comment #15 from Pander --- Sorry, one more minor fix. Thanks for updating it. Summary: Fast and safe spellchecking C++ library and command-line tool -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #3 from Erich Eickmeyer --- Spec URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01398558-mudita24/mudita24.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01398558-mudita24/mudita24-1.1.0-1.20160218gite38b1a3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #20 from ArunPrabhu Vijayan --- (In reply to Neil Horman from comment #18) > In regards to your koji issue, the build system uses kerberos to > authenticate, and you need to configure the FEDORAPROJECT.ORG realm. You > should get the realm configuration file installed with the fedora-packager > package. just run: > dnf install fedora-packager > > and you should be good to go. > > I'll review the package shortly Thanks for the review. We will take care of go packages as suggested. However, my Koji issue is still not solved. I tried uninstalling & reinstalling. Still getting same err [root@silpixa00399467 avijayan]# dnf install fedora-packager Last metadata expiration check: 0:57:08 ago on Tue 19 May 2020 23:01:19 IST. Package fedora-packager-0.6.0.4-1.fc32.noarch is already installed. Dependencies resolved. Nothing to do. Complete! [root@silpixa00399467 avijayan]# kinit avija...@fedoraproject.org kinit: Cannot contact any KDC for realm 'FEDORAPROJECT.ORG' while getting initial credentials Could you please help here? I'm able to login to https://admin.fedoraproject.org/ using same username: avijayan. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793
Fabian Affolter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Fabian Affolter ---
- Could you please double check the hashing mismatch for the source before the
import?
- "%global golicenses epl-v10.html" could replace the "%license epl-v10.html"
entry in the %files section. I guess that the go2rpm script was not able to
pick the file up. Not a blocker but would be more aligned with Go spec files.
Otherwise looks good, package APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in
/home/fab/Documents/repos/reviews/1837793-golang-github-xiaq-
persistent/diff.txt
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in
/home/fab/Documents/repos/reviews/1837793-golang-github-xiaq-
persistent/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com(golang-github-dchest-uniuri-devel,
golang-github-gopherjs-devel, golang-github-glycerine-unsnap-stream-
[...]
golang-github-nkovacs-streamquote-devel, golang-github-10gen-escaper-
devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license
[Bug 1834932] Review Request: python-google-i18n-address - Address validation helpers for Google's i18n address database
https://bugzilla.redhat.com/show_bug.cgi?id=1834932
Fabian Affolter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(mail@fabian-affol |
|ter.ch) |
--- Comment #3 from Fabian Affolter ---
Could you please add %{?python_provide:%python_provide python3-%{pypi_name}}
for the Python 3 package before the import?
Other issues were addressed, package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820850] Review Request: golang-github-jpillora-tld - TLD parser
https://bugzilla.redhat.com/show_bug.cgi?id=1820850 --- Comment #4 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
