[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301219



--- Comment #7 from Neal Gompa  ---
You don't need "rm -rf ${RPM_BUILD_ROOT}" in the install step. rpmbuild
automatically cleans the build root before starting %install.

Other than that, I don't see anything standing out to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293156] Review Request: lxqt-sudo - GUI frontend for sudo/su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293156



--- Comment #24 from Fedora Update System  ---
liblxqt-0.10.0-7.fc23 libqtxdg-1.3.0-2.fc23 lxqt-about-0.10.0-4.fc23
lxqt-common-0.10.0-7.fc23 lxqt-config-0.10.0-3.fc23
lxqt-globalkeys-0.10.0-4.fc23 lxqt-notificationd-0.10.0-3.fc23
lxqt-openssh-askpass-0.10.0-3.fc23 lxqt-panel-0.10.0-4.fc23
lxqt-policykit-0.10.0-3.fc23 lxqt-powermanagement-0.10.0-3.fc23
lxqt-runner-0.10.0-3.fc23 lxqt-session-0.10.0-3.fc23 lxqt-sudo-0.10.0-4.fc23
pcmanfm-qt-0.10.0-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d67a0d6bcc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293156] Review Request: lxqt-sudo - GUI frontend for sudo/su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293156

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #6 from Pier Luigi Fiorini  ---
Update:

- License comment
- Desktop file validation
- Less globs

Spec URL:
https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-system-preferences.spec
SRPM URL:
https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-system-preferences-0.5.0-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279175] Review Request: innoextract - Tool to extract installers created by Inno Setup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279175



--- Comment #15 from Alexandre Detiste  ---

I fixed the link on the Wiki

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301219

Neal Gompa  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #8 from Neal Gompa  ---
Also, adding FE-NEEDSPONSOR, since this is your first package review.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299126] Review Request: qt5-qtquickcontrols2 - Qt5 - module with set of QtQuick controls for embedded

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299126

Pier Luigi Fiorini  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-01-24 05:35:21



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279787] Review Request: python-csvkit - Suite of utilities for converting to and working with CSV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279787



--- Comment #3 from Upstream Release Monitoring 
 ---
jujens's scratch build of python-csvkit-0.9.1-3.gitbf18815.fc23.src.rpm for
rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12667549

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293075] Review Request: lximage-qt - The image viewer and screenshot tool for lxqt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293075

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293075] Review Request: lximage-qt - The image viewer and screenshot tool for lxqt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293075



--- Comment #16 from Fedora Update System  ---
lximage-qt-0.4.0-4.fc22 lxqt-runner-0.10.0-3.fc22 has been submitted as an
update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a009b82313

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456



--- Comment #23 from Julien Enselme  ---
> Sorry for the delay with answer.

No problem.

> All issues addressed. Package APPROVED.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301253] Review Request: color - A string colorizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301253



--- Comment #2 from Austin Dunn  ---
(In reply to Brandon Thomas from comment #1)

Thanks for the review!

> * I don't believe that Amusements/Games" is a valid group.
Amusements/Games is a valid group. Try "cat /usr/share/doc/rpm/GROUPS"

> * "make %{?_smp_mflags}" can be replaced with "%make_build".
That was in the vim .spec template, I will fix it in an update.

> * You probably want the install and ln command to be in the "%install"
See above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295255] Review Request: php-container-interop - Promoting the interoperability of container objects (DIC, SL, etc.)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295255



--- Comment #18 from Fedora Update System  ---
php-container-interop-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263821] Review Request: dput-ng - Next generation Debian package upload tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263821

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-24 21:21:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263821] Review Request: dput-ng - Next generation Debian package upload tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263821
Bug 1263821 depends on bug 1278964, which changed state.

Bug 1278964 Summary: Review Request: distro-info - Provides information about 
releases of Debian and Ubuntu
https://bugzilla.redhat.com/show_bug.cgi?id=1278964

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292392] Review Request: libpwiz - ProteoWizard software library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292392



--- Comment #14 from Fedora Update System  ---
libpwiz-3.0.9283-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278963] Review Request: distro-info-data - Information about releases of Debian and Ubuntu (data files)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278963



--- Comment #9 from Fedora Update System  ---
distro-info-0.14-3.fc23, distro-info-data-0.28-3.fc23, dput-ng-1.10-3.fc23 has
been pushed to the Fedora 23 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278964] Review Request: distro-info - Provides information about releases of Debian and Ubuntu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278964



--- Comment #11 from Fedora Update System  ---
distro-info-0.14-3.fc23, distro-info-data-0.28-3.fc23, dput-ng-1.10-3.fc23 has
been pushed to the Fedora 23 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263821] Review Request: dput-ng - Next generation Debian package upload tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263821



--- Comment #11 from Fedora Update System  ---
distro-info-0.14-3.fc23, distro-info-data-0.28-3.fc23, dput-ng-1.10-3.fc23 has
been pushed to the Fedora 23 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295259] Review Request: php-di-symfony2-bridge - PHP-DI integration with Symfony 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295259



--- Comment #16 from Fedora Update System  ---
php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7,
php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7,
php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7
has been pushed to the Fedora EPEL 7 stable repository. If problems still
persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295258] Review Request: php-di - The dependency injection container for humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295258



--- Comment #18 from Fedora Update System  ---
php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7,
php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7,
php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7
has been pushed to the Fedora EPEL 7 stable repository. If problems still
persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295257] Review Request: php-di-invoker - Generic and extensible callable invoker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295257



--- Comment #17 from Fedora Update System  ---
php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7,
php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7,
php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7
has been pushed to the Fedora EPEL 7 stable repository. If problems still
persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295256] Review Request: php-di-phpdoc-reader - Parses @var and @param values in PHP docblocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295256



--- Comment #19 from Fedora Update System  ---
php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7,
php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7,
php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7
has been pushed to the Fedora EPEL 7 stable repository. If problems still
persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295255] Review Request: php-container-interop - Promoting the interoperability of container objects (DIC, SL, etc.)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295255



--- Comment #17 from Fedora Update System  ---
php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7,
php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7,
php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7
has been pushed to the Fedora EPEL 7 stable repository. If problems still
persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295260] Review Request: php-mnapoli-phpunit-easymock - Helpers to build PHPUnit mocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295260



--- Comment #19 from Fedora Update System  ---
php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7,
php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7,
php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7
has been pushed to the Fedora EPEL 7 stable repository. If problems still
persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289760] Review Request: drawtk - A C library to perform efficient 3D drawings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289760



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/drawtk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
msgpuck-1.0.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-577823c5bf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278964] Review Request: distro-info - Provides information about releases of Debian and Ubuntu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278964
Bug 1278964 depends on bug 1278963, which changed state.

Bug 1278963 Summary: Review Request: distro-info-data - Information about 
releases of Debian and Ubuntu (data files)
https://bugzilla.redhat.com/show_bug.cgi?id=1278963

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278964] Review Request: distro-info - Provides information about releases of Debian and Ubuntu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278964

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-24 21:21:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278963] Review Request: distro-info-data - Information about releases of Debian and Ubuntu (data files)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278963

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-24 21:21:51



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279787] Review Request: python-csvkit - Suite of utilities for converting to and working with CSV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279787



--- Comment #4 from Upstream Release Monitoring 
 ---
jujens's scratch build of python-csvkit-0.9.1-4.gitbf18815.fc23.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12667635

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279787] Review Request: python-csvkit - Suite of utilities for converting to and working with CSV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279787



--- Comment #6 from Pavel Alexeev  ---
I have tried on Fedora 23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198498



--- Comment #16 from Fabian Affolter  ---
%changelog
* Sun Jan 24 2016 Fabian Affolter  - 1.6.1-2
- Update to latest upstream release 1.6.1

* Fri Jan 22 2016 Fabian Affolter  - 1.5.1-2
- Update spec file
- Update to latest upstream release 1.5.1

Updated files: 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/libwebsockets.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/libwebsockets-1.6.1-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279787] Review Request: python-csvkit - Suite of utilities for converting to and working with CSV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279787



--- Comment #7 from Julien Enselme  ---
It seems I forgot again to put the link to the proper SRPM:

SRPM: http://dl.jujens.eu/SRPMS/python-csvkit-0.9.1-4.gitbf18815.fc23.src.rpm
SPEC: http://dl.jujens.eu/SPECS/python-csvkit.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279787] Review Request: python-csvkit - Suite of utilities for converting to and working with CSV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279787



--- Comment #8 from Pavel Alexeev  ---
Should it be compiled on Fedora 23 too? Or in rawhide only?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198498



--- Comment #15 from Upstream Release Monitoring 
 ---
fab's scratch build of libwebsockets-1.6.1-1.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12667680

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879928



--- Comment #12 from Upstream Release Monitoring 
 ---
hubbitus's scratch build of rigsofrods-0.4.6.0-0.6.git.3e56c07.fc23.src.rpm for
f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12667538

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111373] Review Request: ant18 - ant version 1.8 for EL6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=373

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111373] Review Request: ant18 - ant version 1.8 for EL6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=373

gil cattaneo  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279755] Review Request: rubygem-racc - LALR(1) parser generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279755

greg.helli...@gmail.com changed:

   What|Removed |Added

 CC||greg.helli...@gmail.com
   Assignee|nob...@fedoraproject.org|greg.helli...@gmail.com



--- Comment #8 from greg.helli...@gmail.com ---
Taking for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279787] Review Request: python-csvkit - Suite of utilities for converting to and working with CSV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279787



--- Comment #5 from Julien Enselme  ---
> It seams your previous koji scratch build also failed.
> Does it ready for review?

It should be. It seems that I forgot to post the link to an updated SRPM that I
made a while back which may explain part of the problems.

SPEC: http://dl.jujens.eu/SPECS/python-csvkit.spec
SRPM: http://dl.jujens.eu/SRPMS/python-csvkit-0.9.1-2.gitbf18815.fc23.src.rpm

Another thing that may explain it is that you are trying to build the package
on fedora 22 and it seems that python-jdcal was never pushed there. I just
opened a bug about it: https://bugzilla.redhat.com/show_bug.cgi?id=1301328

I was also missing a patch for the build to succeed on koji. My last scratch
build on rawhide succeeded, so it should work. Sorry for the inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645



--- Comment #4 from Dmitry Mikhirev  ---
The problem was in parallel running of tests. They need to be executed
sequentially.

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawhide-x86_64/00155479-teem/teem-1.11.0-1.fc24.src.rpm
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/teem.git/plain/teem.spec?id=56c9601b5cb3e8473e5d91747dfe56d8da4e1291

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297821] Review Request: qlcplus - DMX light controller software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297821

Dave Olsthoorn  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2016-01-24 09:42:32



--- Comment #12 from Dave Olsthoorn  ---
After the last two comments from upstream i'll close this review indefinitely,
since i don't think communication with upstream can exist in a normal fashion
after this licensing talk.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #7 from Upstream Release Monitoring 
 ---
plfiorini's scratch build of hawaii-system-preferences-0.5.0-1.fc23.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12667586

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
OK, no more issues. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #21 from Dmitrij S. Kryzhevich  ---
Package Review
==

Issues.

Must be fixed:
1. Latest Changelog version is for 0.1 and current version is 0.3.
2. First Changelog entry is for version 1. Misspell?
3. Script to obtain upstream should be fixed. Your script is for lates
available version. Must be: packed version.
4. Summary and Description for -devel should represent -devel package.
5. Anowned dirs: /usr/share/geany and /usr/share/geany/tags. May be split-out
that geany file and make it Require: geany?

Should be fixed:
1. shared-lib-calls-exit from libscid-ldc.so.0.3.0
2. unstripped-binary-or-object libscid-ldc.so.0.3.0. Is it normal for D
libraris?
3. /usr/share/doc/scid is already processed in %{doc} macros. You could drop
%{_defaultdocdir}/scid.
4. Requires: lapack -- is not neccessary. It would be pulled by auto-requires:
liblapack.so.3
5. ldc already require ldc-druntime-devel and ldc-phobos-devel. If there is a
reason to left them - good, otherwise they should be removed.
6. The same as for 5, but for -devel.



Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable

= MUST items =

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[!]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[!]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[!]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest 

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217



--- Comment #15 from Fedora Update System  ---
msgpuck-1.0.1-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ee5102307f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217



--- Comment #16 from Roman Tsisyk  ---
> build...@fedoraproject.org
> msgpuck has broken dependencies in the rawhide tree:
> On x86_64:
> msgpuck-devel-1.0.1-1.fc24.x86_64 requires msgpuck(x86-64) = 
> 0:1.0.1-1.fc24
> On i386:
> msgpuck-devel-1.0.1-1.fc24.i686 requires msgpuck(x86-32) = 
> >0:1.0.1-1.fc24
> On armhfp:
> msgpuck-devel-1.0.1-1.fc24.armv7hl requires msgpuck(armv7hl-32) = 
> 0:1.0.1-1.fc24
>  Please resolve this as soon as possible.

I accidentally forgot to remove dependency on `msgpuck%{?_isa} =
%{version}-%{release}` after dropping empty `msgpuck` package. Fixed. Sorry for
that.

Is it possible to run the same automated tests before pushing to master?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 969271] Review Request: cometd - A scalable HTTP-based event routing bus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=969271

automat...@ovirt.org changed:

   What|Removed |Added

External Bug ID||oVirt gerrit 52554



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299637] Review Request: pam_wrapper - A tool to test PAM applications and PAM modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299637

Andreas Schneider  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #5 from Andreas Schneider  ---
LGTM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Dmitrij S. Kryzhevich  changed:

   What|Removed |Added

   Assignee|i...@cicku.me  |kryz...@ispms.ru
  Flags|needinfo?(i...@cicku.me)   |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
What about the first part of comment #2?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301219



--- Comment #9 from Brandon Thomas  ---
Thanks. I updated the package:

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/racket/racket.git/plain/racket.spec?id=3fb66397e0661e8c3447306d65bc185597480d65
Patch URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/racket/racket.git/tree/xform-errors-converting-fix.patch?id=3fb66397e0661e8c3447306d65bc185597480d65
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bthomas/racket/fedora-23-x86_64/00155492-racket/racket-6.3-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279755] Review Request: rubygem-racc - LALR(1) parser generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279755



--- Comment #9 from greg.helli...@gmail.com ---
$ rpmlint rubygem-racc.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ./rubygem-racc-1.4.14-1.fc.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/rubygem-racc-1.4.14-1.fc24.x86_64.rpm
 
rubygem-racc.x86_64: E: zero-length
/usr/lib64/gems/ruby/racc-1.4.14/gem.build_complete
rubygem-racc.x86_64: E: incorrect-fsf-address
/usr/share/gems/gems/racc-1.4.14/COPYING
rubygem-racc.x86_64: W: no-manual-page-for-binary racc2y
rubygem-racc.x86_64: W: no-manual-page-for-binary racc
rubygem-racc.x86_64: W: no-manual-page-for-binary y2racc
1 packages and 0 specfiles checked; 2 errors, 3 warnings.

$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/rubygem-racc-debuginfo-1.4.14-1.fc24.x86_64.rpm
 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/rubygem-racc-doc-1.4.14-1.fc24.noarch.rpm
 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ md5sum racc-1.4.14.gem 
ec1c3738429842b7ff1f2f4f52b7e6cc  racc-1.4.14.gem

$ wget -q -O - https://rubygems.org/gems/racc-1.4.14.gem | md5sum
ec1c3738429842b7ff1f2f4f52b7e6cc  -

[+] The package must be named according to the Package Naming Guidelines .
[+] The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
[+] The package must meet the Packaging Guidelines .
[+] The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
[+] The License field in the package spec file must match the actual license.
[+] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %license.
[+] The spec file must be written in American English.
[+] The spec file for the package MUST be legible.
[+] The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use sha256sum for this task as it is
used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
[+] The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[+] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
[+] The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[+] Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
[+] Packages must NOT bundle copies of system libraries.
[+] If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker.
[+] A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
[+] A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
[+] Permissions on files must be set properly. Executables should be set with
executable permissions, for example.
[+] Each package must consistently use macros.
[+] The package must contain code, or permissable content.
[+] Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
[+] If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
[+] Static libraries must be in a -static package.
[+] Development files must be in a -devel package.
[+] In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
[+] Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are 

[Bug 1279755] Review Request: rubygem-racc - LALR(1) parser generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279755

greg.helli...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301285] Review Request: perl-Mock-Sub - Mock package, object and standard subroutines, with unit testing in mind

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301285



--- Comment #2 from Denis Fateyev  ---
The author has recently updated module to 1.06 version.

Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-Mock-Sub.spec
SRPM URL:
http://www.fateyev.com/RPMS/Fedora22/perl-Mock-Sub-1.06-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645



--- Comment #6 from Dmitry Mikhirev  ---
I'm sorry, you are right. I really missed some optional dependencies that are
visible in test log only. Now I added all of them except levmar because the
code using it is broken and does not compile.

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/teem.git/plain/teem.spec?id=10ec5a4ba1e539ed9a2ded6d05de55a56780899d
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawhide-x86_64/00155503-teem/teem-1.11.0-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301285] Review Request: perl-Mock-Sub - Mock package, object and standard subroutines, with unit testing in mind

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301285



--- Comment #1 from Upstream Release Monitoring 
 ---
dfateyev's scratch build of perl-Mock-Sub-1.06-1.fc23.denf.src.rpm for
dist-6E-epel completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12668867

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301129] Review Request: hstr - Suggest box like shell history completion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301129

Brandon Thomas  changed:

   What|Removed |Added

 CC||bthoma...@gmail.com



--- Comment #3 from Brandon Thomas  ---
This is an unofficial review, and does not the status of this review request.
The only thing I see that "%make_build" can be replaced by "make
%{?_smp_mflags}", since it's cleaner, unless you're targeting EPEL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279787] Review Request: python-csvkit - Suite of utilities for converting to and working with CSV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279787



--- Comment #9 from Julien Enselme  ---
> Should it be compiled on Fedora 23 too? Or in rawhide only?

It can be built on either fedora 23 or rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1296792] Review Request: erlang-p1_stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1296792

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rbar...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288651] Review Request: openigtlink - Implementation of the OpenIGTLink network communication protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/openigtlink

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/hawaii-system-preferences

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298715] Review Request: xlogin - Automatic X login service for systemd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298715



--- Comment #8 from Upstream Release Monitoring 
 ---
raphgro's scratch build of xlogin-0-0.1.20160114git97667d7.fc23.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12669706

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289760] Review Request: drawtk - A C library to perform efficient 3D drawings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289760



--- Comment #6 from Dmitry Mikhirev  ---
Well, do I understand correct that the only required change is adding a comment
about source origin?

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/drawtk.git/plain/drawtk.spec?id=56cce00f9179528be0c28cccb56a4aa23be12359
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawhide-x86_64/00155505-drawtk/drawtk-2.0-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231

Pier Luigi Fiorini  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-01-24 14:16:44



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301395] New: Review Request: perl-Sort-MergeSort - Merge pre-sorted input streams

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301395

Bug ID: 1301395
   Summary: Review Request: perl-Sort-MergeSort - Merge pre-sorted
input streams
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: de...@fateyev.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-Sort-MergeSort.spec
SRPM URL:
http://www.fateyev.com/RPMS/Fedora22/perl-Sort-MergeSort-0.31-1.fc24.src.rpm
Description: Given a comparison function and a bunch of iterators that produce
data that is already sorted, mergesort() will provide an iterator that produces
sorted and merged data from all of the input iterators.
Fedora Account System Username: dfateyev

Koji scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=12669658 (Rawhide)
https://koji.fedoraproject.org/koji/taskinfo?taskID=12669623 (EPEL 6)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298715] Review Request: xlogin - Automatic X login service for systemd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298715



--- Comment #9 from Raphael Groner  ---
Sorry for the delay. Updated systemd scriptlets. Links are the same.

Spec URL: https://raphgro.fedorapeople.org/review/locker/xlogin.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/locker/xlogin-0-0.1.20160114git97667d7.fc23.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=12669706

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1300003] Review Request: fleet-commander - Admin interface for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=133

Brandon Thomas  changed:

   What|Removed |Added

 CC||bthoma...@gmail.com



--- Comment #3 from Brandon Thomas  ---
This is an unofficial review, and will not effect the status of this review
request.
* I believe the spec file should be named fleet-commander-admin.spec, since
fleet-commander only exists as two separate projects (fleet-commander-client
and fleet-commander-admin).
* As a corollary to that, since the package "fleet-commander" does not exist,
the subpackage fleet-commander-admin should be the main packages name.
* You probably want more information in your summaries and descriptions, since
a user probably doesn't know what fleet commander is.
* You should probably use "%make_build" over "make".
* It is not necessary to have a "%clean" section.
* Including fonts should be avoided. I'm not sure if this is because of some
technical restriction, but if possible, you should use the fonts provided in
Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295075] Review Request: erlang-cache_tab - Erlang cache table application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295075

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-01-24 13:36:32



--- Comment #13 from Randy Barlow  ---
I see that there is a build in Rawhide, so I think we can close this now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456



--- Comment #24 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-recommonmark

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
+ latest version
+ package name is OK
+ Summary and %description are OK
+ scriptlets are OK
+ builds and installs OK
+ license is acceptable
+ license file is present, %license is used
+ %check is present
+ requires and provides look fine
+ fedora-review is happy
+ rpmlint finds nothing substantial

teem-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libteem.so.1.11.0
exit@GLIBC_2.2.5
You might want to investigate that.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289760] Review Request: drawtk - A C library to perform efficient 3D drawings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289760

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
Yeah, I think everything is fine and you addressed all the relevant comments
from Ranjan and me.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289717] Review Request: viennacl - Linear algebra and solver library using CUDA, OpenCL, and OpenMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289717



--- Comment #5 from Ilya Gradina  ---
New version 1.7.1
Spec URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec
SRPM URL:
https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297094] Review Request: erlang-p1_yaml - An Erlang wrapper for libyaml "C" library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297094

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Randy Barlow  ---
Note, there is one thing to consider fixing below, marked !.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "GPL (v2 or later) (with incorrect FSF
 address)", "Unknown or generated". 4 files have unknown license.
 Detailed output of licensecheck in /home/rbarlow/1297094-erlang-
 p1_yaml/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

rbarlow:
[?]: I'm not sure how this passed a build, but it seems you would need a
 BuildRequires on erlang-eunit. Maybe one of the other BuildRequires
 pulls it in?

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
 Note: Since you packaged this, upstream has released a 1.0.1.
[x]: Package does not 

[Bug 1301253] Review Request: color - A string colorizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301253

Brandon Thomas  changed:

   What|Removed |Added

 CC||bthoma...@gmail.com



--- Comment #1 from Brandon Thomas  ---
This is not an official review, and this does not effect the status of the
review request.
* It looks like a period slipped into the packages Summary.
* I don't believe that Amusements/Games" is a valid group.
* "make %{?_smp_mflags}" can be replaced with "%make_build".
* You don't need to specify the packager.
* You probably want the install and ln command to be in the "%install" section.
* You might want to consider including a change log at the end of your file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299305] Review Request: erlang-p1_tls - TLS / SSL native driver for Erlang / Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299305

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-01-24 17:26:34



--- Comment #3 from Randy Barlow  ---
This is built in Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456



--- Comment #25 from Fedora Update System  ---
python-recommonmark-0.4.0-4.git7ca5247.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3c73fc30e7

--- Comment #26 from Fedora Update System  ---
python-recommonmark-0.4.0-4.git7ca5247.fc22 has been submitted as an update to
Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2cd03bceee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456



--- Comment #25 from Fedora Update System  ---
python-recommonmark-0.4.0-4.git7ca5247.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3c73fc30e7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1296792] Review Request: erlang-p1_stringprep - A framework for preparing Unicode strings to help input and comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1296792

Randy Barlow  changed:

   What|Removed |Added

 CC||jer...@jcline.org
  Flags||needinfo?(jer...@jcline.org
   ||)



--- Comment #1 from Randy Barlow  ---
This package fails to install, I think due to requiring erlang-ert instead of
erlang-erts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298180] Review Request: python-libcnml, a CNML parser library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298180



--- Comment #4 from Fabio Alessandro Locati  ---
1. This is not solved by upstream commit, since the version you are packaging
does not include that commit

2. Please, do fix your changelog. If the package version and release are
0.9.3-1, you can not have a changelog entry for 2.2.1-1

3. The current spec does not compile (see
http://koji.fedoraproject.org/koji/taskinfo?taskID=12670254). It requires
python2-six and python3-six as BuildRequire since you are running the tests.

4. Even adding python2-six and python3-six as for 3., some checks for python3
fails, at least on my machine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299038] Review Request: prunerepo - remove old packages from rpm-md repository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299038



--- Comment #6 from Miroslav Suchý  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
 Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[!]: Spec file according to URL is the same as in SRPM.
 Note: Spec file as given by url is not the same as in SRPM (see
 attached diff).
 See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).


Issues:
* build the package without --test so the name and tar file is canonical.

-- 
You are receiving this mail because:
You are on the CC 

[Bug 1301405] New: Review Request: pulp-python - Support for Python content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301405

Bug ID: 1301405
   Summary: Review Request: pulp-python - Support for Python
content in the Pulp platform
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rbar...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://rbarlow.fedorapeople.org/pulp-python.spec
SRPM URL: https://rbarlow.fedorapeople.org/pulp-python-1.0.1-1.fc24.src.rpm
Description: Provides a collection of platform plugins and client extensions
support for Python packages.
Fedora Account System Username: rbarlow

There is one rpmlint error:

python-pulp-python-common.noarch: E: zero-length
/usr/lib/python2.7/site-packages/pulp_python/common/errors.py
5 packages and 0 specfiles checked; 1 errors, 0 warnings.

I have filed a pull request with upstream to resolve this error in the next
release:

https://github.com/pulp/pulp_python/pull/59

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301405] Review Request: pulp-python - Support for Python content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301405



--- Comment #1 from Upstream Release Monitoring 
 ---
rbarlow's scratch build of pulp-python-1.0.1-1.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12670467

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297094] Review Request: erlang-p1_yaml - An Erlang wrapper for libyaml "C" library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297094

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rbar...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292392] Review Request: libpwiz - ProteoWizard software library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292392

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-24 17:50:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-24 17:50:15



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290530] Review Request: smtpping - Small tool for measuring SMTP parameters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290530

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-24 17:50:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=505154
Bug 505154 depends on bug 1292392, which changed state.

Bug 1292392 Summary: Review Request: libpwiz - ProteoWizard software library
https://bugzilla.redhat.com/show_bug.cgi?id=1292392

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290530] Review Request: smtpping - Small tool for measuring SMTP parameters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290530



--- Comment #16 from Fedora Update System  ---
smtpping-1.1.2-2.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292392] Review Request: libpwiz - ProteoWizard software library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292392



--- Comment #13 from Fedora Update System  ---
libpwiz-3.0.9283-1.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297527] Review Request: perl-WWW-Twilio-API - Accessing Twilio's REST API with Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297527



--- Comment #15 from Fedora Update System  ---
perl-WWW-Twilio-API-0.18-2.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297527] Review Request: perl-WWW-Twilio-API - Accessing Twilio's REST API with Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297527

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-24 17:50:20



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292216



--- Comment #14 from Fedora Update System  ---
libwhirlpool-1.0-1.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198498



--- Comment #17 from Upstream Release Monitoring 
 ---
acooks's scratch build of libwebsockets-1.6.1-2.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12671396

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301316] Review Request: erlang-p1_stun - STUN and TURN library for Erlang / Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301316

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rbar...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198498



--- Comment #18 from Andrew Cooks  ---
(In reply to Upstream Release Monitoring from comment #17)
> acooks's scratch build of libwebsockets-1.6.1-2.fc23.src.rpm for rawhide
> completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12671396

Um, sorry about the noise. I was just trying out koji to understand what Fabian
was doing, and why. I didn't know that it would automagically find this bug and
modify it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review