[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790



--- Comment #33 from Fedora Update System  ---
gnome-shell-extension-freon-23-3.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-021e8661c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790



--- Comment #32 from Fedora Update System  ---
gnome-shell-extension-freon-23-3.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2486ed920e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Created attachment 1267224
  --> https://bugzilla.redhat.com/attachment.cgi?id=1267224=edit
qtdomterm menu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
Created attachment 1267223
  --> https://bugzilla.redhat.com/attachment.cgi?id=1267223=edit
qtdomterm screenshot

I have a HiDPI screen:
XWAYLAND0 connected 2560x1440+0+0 310mm x 170mm
   2560x1440 59.96*+
and the default fonts in qtdomterm don't work out too well.
Also note that unicode characters are not really displayed
properly. It doesn't seem to just a case of missing fonts,
instead multi-byte utf8 characters are converted to some ascii
noise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
 Depends On||1422477
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
I added 1422477 as a dep, mostly to have an easy-to-access link to it. It's
almost complete anyway.

fedora-review says:
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

My advice is to stick to %buildroot (or %{buildroot}). That's the commonly used
modern form.
In fact, it'd be best to replace the make invocation with %make_install, which
expands to
the exact same line.

Those long lines with multiple BuildRequires should be split into
separate lines. It's not required, but in my opinion is makes it
much easier to spot mistakes and diffs look *much* better.

domterm.src:10: W: macro-in-comment %{commit0}
domterm.src:44: W: macro-in-comment %{_bindir}
→ The second one should be replaced with %%{_bindir} to avoid the warning.
The first one can stay, if you want to have a valid link in rpmspec -P output.

https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires
says that you need Requires: javapackages-tools, Requires: java.
(Either directly or indirectly, but I don't see it either way.)

Two big things which is missing, and which is strongly recommended by the
guidelines
are a .desktop file
[https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files]
and an .appdata file [https://fedoraproject.org/wiki/Packaging:AppData].
In this case an appdata file will be particularly useful, advertising
your software and allowing potential users to see how if differers from the 
many other terminal emulators.

In the %description, please add some meat. Why is this package better, what
does it do differently than other terminal emulators, what cool features
does it sport. This text shouldn't be long, just one or two paragraphs to
pique interest. You can reuse most of the text in the appdata file anyway ;)


I built and installed the package, on F25. Seems not to work:
- in the terminal:
$ ldomterm
[9066:9066:0328/230720.355575:ERROR:child_thread_impl.cc(762)] Request for
unknown Channel-associated interface: ui::mojom::GpuMain

and there's also a big blank window which only says "Waiting for localhost..."
in
the lower left corner.

qtdomterm works OK, but it doesn't seem to support HiDPI very well (see
attached
screenshot). From what I know, it's a general problem with Qt, so I don't
expect
you to fix it. Just pointing this out in case you need stuff to improve ;)

--

I can sponsor you. My requirements apart from this package will be two or three
reviews of other packages. Your package is pretty complex, so you'll soak up a
lot of the packaging guidelines just for it, but it's always good to see and
critique what other people are doing. Please see
http://fedoraproject.org/PackageReviewStatus/NEW.html for a list of interesting
candidates. Please set up mock, if you haven't already, and base your reviews
on fedora-review output, but note that fedora-review does get stuff wrong
occasionally and leaves a lot of boxes to be filled manually. In the reviews
make a comment that your review is informal because you are not in the
packagers group yet. After you are, you can finish those reviews, if nobody
else beats you to it.

In case of questions, feel free to query me on IRC (I'm zbyszek in
#fedora-devel), or by
mail.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1422477
[Bug 1422477] libwebsockets-2.2.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790



--- Comment #31 from Fedora Update System  ---
gnome-shell-extension-freon-23-3.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-cb3cb1f22d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Hi, sorry for the long silence. I went away on vacation and then completely
forgot about this. For the future, in such cases, it often helps to send a ping
after a week or two, just to get things going again. Let's get this ball
rolling again!

I looked at your comments on those reviews, but they are a bit scant. Before I
asked you for a fedora-review run on #1388945. I'd like to know that you have
set up mock and can do test builds there. Can you please do a review of one
more package, this time using fedora-review as the starting point?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Dhanesh, do you plan to take this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436912] New: Review Request: nodejs-xmlhttprequest-ssl - XMLHttpRequest for Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436912

Bug ID: 1436912
   Summary: Review Request: nodejs-xmlhttprequest-ssl -
XMLHttpRequest for Node
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1435930 (c9.io)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-xmlhttprequest-ssl/nodejs-xmlhttprequest-ssl.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-xmlhttprequest-ssl/nodejs-xmlhttprequest-ssl-1.5.3-1.fc27.src.rpm
Description: XMLHttpRequest for Node
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1435930
[Bug 1435930] Package tracker for Cloud9.io
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411590] Review Request: ignition-msgs - Common messages for the ignition framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411590



--- Comment #6 from Rich Mattes  ---
Upstream has confirmed the license and added license headers to the proto
files.  I've updated the spec to add the --as-needed CXXFLAGS to fix the unused
lib deps.

Updated package at:
Spec URL:
https://rmattes.fedorapeople.org/RPMS/ignition-msgs/ignition-msgs.spec
SRPM URL:
https://rmattes.fedorapeople.org/RPMS/ignition-msgs/ignition-msgs-0.7.0-3.fc25.src.rpm

scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18652747

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #17 from Fedora Update System  ---
rhash-1.3.4-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #16 from Fedora Update System  ---
openblas-srpm-macros-1-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-28 21:30:57



--- Comment #35 from Fedora Update System  ---
legion-17.02.0-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436907] New: Review Request: nodejs-has-cors - Detects support for Cross-Origin Resource Sharing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436907

Bug ID: 1436907
   Summary: Review Request: nodejs-has-cors - Detects support for
Cross-Origin Resource Sharing
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1435930 (c9.io)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-has-cors/nodejs-has-cors.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-has-cors/nodejs-has-cors-1.1.0-1.fc27.src.rpm
Description: Detects support for Cross-Origin Resource Sharing
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1435930
[Bug 1435930] Package tracker for Cloud9.io
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-28 19:53:06



--- Comment #16 from Fedora Update System  ---
rhash-1.3.4-2.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-28 19:53:03



--- Comment #15 from Fedora Update System  ---
openblas-srpm-macros-1-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436881] New: Review Request: nodejs-engine-dot-io-parser - Parser for the client for the realtime Engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436881

Bug ID: 1436881
   Summary: Review Request: nodejs-engine-dot-io-parser - Parser
for the client for the realtime Engine
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Depends On: 1435929, 1435932, 1435933, 1435935, 1436880
Blocks: 956806 (nodejs-reviews), 1435930 (c9.io)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-engine-dot-io-parser/nodejs-engine-dot-io-parser.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-engine-dot-io-parser/nodejs-engine-dot-io-parser-2.0.2-1.fc27.src.rpm
Description: Parser for the client for the realtime Engine
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1435929
[Bug 1435929] Review Request: nodejs-utf8 - A well-tested UTF-8
encoder/decoder written in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1435930
[Bug 1435930] Package tracker for Cloud9.io
https://bugzilla.redhat.com/show_bug.cgi?id=1435932
[Bug 1435932] Review Request: nodejs-blob - Abstracts out Blob and uses
BlobBulder in cases where it is supported
https://bugzilla.redhat.com/show_bug.cgi?id=1435933
[Bug 1435933] Review Request: nodejs-base64-arraybuffer - Encode/decode
base64 data into ArrayBuffers
https://bugzilla.redhat.com/show_bug.cgi?id=1435935
[Bug 1435935] Review Request: nodejs-arraybuffer-dot-slice - Exports a
function for slicing ArrayBuffers (no polyfilling)
https://bugzilla.redhat.com/show_bug.cgi?id=1436880
[Bug 1436880] Review Request: nodejs-has-binary - Returns true if its
argument contains binary data
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436880] New: Review Request: nodejs-has-binary - Returns true if its argument contains binary data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436880

Bug ID: 1436880
   Summary: Review Request: nodejs-has-binary - Returns true if
its argument contains binary data
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1435930 (c9.io)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-has-binary/nodejs-has-binary.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-has-binary/nodejs-has-binary-0.1.7-1.fc27.src.rpm
Description: Returns true if its argument contains binary data
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1435930
[Bug 1435930] Package tracker for Cloud9.io
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955

Michal Ambroz  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955

Michal Ambroz  changed:

   What|Removed |Added

  Flags|needinfo?(re...@seznam.cz)  |needinfo+



--- Comment #16 from Michal Ambroz  ---
Hello Richard,
package pushed to the testing. Sorry for delays.
Mik

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955



--- Comment #14 from Fedora Update System  ---
fatresize-1.0.3-4.git20161118.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff208d4982

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955



--- Comment #15 from Fedora Update System  ---
fatresize-1.0.3-4.git20161118.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ddc9243067

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955



--- Comment #13 from Fedora Update System  ---
fatresize-1.0.3-4.git20161118.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-82be14e2d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955



--- Comment #12 from Fedora Update System  ---
fatresize-1.0.3-4.git20161118.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-078444383c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #16 from Michal Ambroz  ---
Hello Pavel,
I still see a password in the config, just this time it is literally
"" as a password. Or am I missing something?

You know - things like Mirai are spreading because of default passwords.

Mik.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427341] Review Request: python-gamera - Gamera is a framework for building document analysis applications.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427341



--- Comment #20 from VincentS  ---
Here are new links according to Miro's advises.

Spec URL: https://dl.casperlefantom.net/pub/review/python-gamera.spec
SRPM URL:
https://dl.casperlefantom.net/pub/review/python-gamera-3.4.3-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Daniel Vrátil  changed:

   What|Removed |Added

  Alias||pidgin-save-conv-order



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] New: Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Bug ID: 1436852
   Summary: Review Request: pidgin-save-conv-order - Save and
restore conversation order in Pidgin
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@dvratil.cz
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://dvratil.fedorapeople.org/spec/pidgin-save-conv-order.spec
SRPM URL:
https://dvratil.fedorapeople.org/spec/pidgin-save-conv-order-1.0-1.fc25.src.rpm
Description: This plugin saves the order of chats and IMs and restores it the
next time you open a conversation.
Fedora Account System Username: dvratil
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18650744

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436347] Review Request: python-pystray - Provides system tray integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436347

Christian Dersch  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Christian Dersch  ---
Approved!

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v3 or later)", "GPL (v3)", "Unknown or generated". 14
 files have unknown license. Detailed output of licensecheck in
 /home/lupinix/1436347-python-pystray/licensecheck.txt

===> Fine, GPL(v3) is a false positive

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-pystray , python2-pystray-doc , python3-pystray , python3
 -pystray-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for 

[Bug 1436347] Review Request: python-pystray - Provides system tray integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436347

Christian Dersch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupi...@mailbox.org
   Assignee|nob...@fedoraproject.org|lupi...@mailbox.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421605] Container Review Request: nginx - Platform for running nginx or building nginx-based application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421605

Pavel Zhukov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||pa...@zhukoff.net
   Assignee|nob...@fedoraproject.org|pa...@zhukoff.net



--- Comment #2 from Pavel Zhukov  ---
I'll review it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435550] Review Request: perl-Dist-Zilla-Role-PluginBundle-PluginRemover - Remove plugins from a Dist ::Zilla plugin bundle

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435550



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Role-PluginBundle-PluginRemover

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435542] Review Request: perl-Config-MVP-Slicer - Extract embedded configuration from a parent configuration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435542



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Config-MVP-Slicer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435375] Review Request: perl-Dist-Zilla-Plugin-ReversionOnRelease - Bump and reversion version on release

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435375



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-ReversionOnRelease

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435363] Review Request: perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile - Parse cpanfile for Dist:: Zilla prerequisites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435363



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435353] Review Request: perl-Dist-Zilla-Plugin-NameFromDirectory - Guess distribution name from the current directory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435353



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-NameFromDirectory

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302



--- Comment #21 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libarcus

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436010] Review Request: php-google-apiclient1 - Client library for Google APIs (version 1)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436010



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-google-apiclient1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434997] Review Request: python-openidc-client - A python OpenID Connect client with token caching and management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434997



--- Comment #11 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-openidc-client

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431448] Review Request: avogadro2 - Advanced molecular editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431448



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/avogadro2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435572] Review Request: golang-gopkg-retry-v1 - Provides a framework for retrying actions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435572



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-gopkg-retry-v1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435348] Review Request: perl-Dist-Zilla-Plugin-ModuleBuildTiny - Build a Build.PL that uses Module ::Build::Tiny

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435348



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-ModuleBuildTiny

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435330] Review Request: perl-Dist-Zilla-Plugin-LicenseFromModule - Extract license and copyright from its main module file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435330



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-LicenseFromModule

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435327] Review Request: golang-github-ojii-gettext.go - gettext functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435327



--- Comment #9 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-ojii-gettext.go

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435118] Review Request: perl-Dist-Zilla-Plugin-ReadmeAnyFromPod - Automatically convert POD to a README in any format for Dist ::Zilla

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435118



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-ReadmeAnyFromPod

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435295] Review Request: perl-Dist-Zilla-Plugin-Git - Update your git repository after release

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435295



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-Git

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413646] Review Request: librealsense - Cross-platform camera capture for Intel RealSense

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413646



--- Comment #10 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/librealsense

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431298



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415439] Review Request: nodejs-bunyan - A JSON logging library for node.js services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415439



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-bunyan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #30 from Fedora Update System  ---
gnome-shell-extension-freon-23-3.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e726bb2298

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436347] Review Request: python-pystray - Provides system tray integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436347



--- Comment #3 from Björn "besser82" Esser  ---
Updated package:

Koji Build:

  https://koji.fedoraproject.org/koji/taskinfo?taskID=18648673


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/python-pystray.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/python-pystray-0.14.2-0.2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431528] Container Review Request: redis - Redis in-memory data structure store, used as database, cache and message broker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431528

Honza Horak  changed:

   What|Removed |Added

 CC||container-rev...@lists.fedo
   ||raproject.org
  Component|Package Review  |Container Review
Version|rawhide |26
Product|Fedora  |Fedora Docker Images



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431546] Container Review Request: python - Platform for building and running Python 3.5 applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431546

Honza Horak  changed:

   What|Removed |Added

 CC||container-rev...@lists.fedo
   ||raproject.org
  Component|Package Review  |Container Review
Version|rawhide |26
Product|Fedora  |Fedora Docker Images



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421605] Container Review Request: nginx - Platform for running nginx or building nginx-based application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421605

Honza Horak  changed:

   What|Removed |Added

 CC||container-rev...@lists.fedo
   ||raproject.org
  Component|Package Review  |Container Review
Version|rawhide |26
Product|Fedora  |Fedora Docker Images



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429680] Container Review Request: httpd - Platform for running Apache HTTP Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429680

Honza Horak  changed:

   What|Removed |Added

 CC||container-rev...@lists.fedo
   ||raproject.org
  Component|Package Review  |Container Review
Version|rawhide |26
Product|Fedora  |Fedora Docker Images



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421601] Container Review Request: ruby - Platform for building and running Ruby applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421601

Honza Horak  changed:

   What|Removed |Added

 CC||container-rev...@lists.fedo
   ||raproject.org
  Component|Package Review  |Container Review
Version|rawhide |25
Product|Fedora  |Fedora Docker Images



--- Comment #3 from Honza Horak  ---
(In reply to Vít Ondruch from comment #1)
> Just two quick comments:
> 
> 1) FROM 25/s2i-base - Why is the "25" hardcoded? Isn't this supposed to
> follow the Fedora releases?

Every image will live under a namespace ("25" in this case) in the fedora
registry, see:
https://fedoraproject.org/wiki/Container:Guidelines

> 2) "This image provides a Ruby 2.4 environment" but it seems you later
> install Ruby 2.3.

Particular ruby version will depend on Fedora version. You're right that for
F25 it is ruby 2.3. Fixed now.

> Anyway, where is this going to live? What is the workflow? Why just Ruby 2.3
> and no other Rubies?

It should be compatible with what RHSCL images provide.

It will live in fedore registry, see more at:

https://fedoraproject.org/wiki/Container:Review_Process
https://fedoraproject.org/wiki/Container:Guidelines

(In reply to Vít Ondruch from comment #2)
> And why is it "package review" when you are asking for container/dockerfile
> review?

I guess before it was the same process, now I see different product, so
changing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429680] Container Review Request: httpd - Platform for running Apache HTTP Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429680

Honza Horak  changed:

   What|Removed |Added

 Blocks||1436796




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1436796
[Bug 1436796] Tracker for Container Review Requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421605] Container Review Request: nginx - Platform for running nginx or building nginx-based application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421605

Honza Horak  changed:

   What|Removed |Added

 Blocks||1436796




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1436796
[Bug 1436796] Tracker for Container Review Requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431546] Container Review Request: python - Platform for building and running Python 3.5 applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431546

Honza Horak  changed:

   What|Removed |Added

 Blocks||1436796




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1436796
[Bug 1436796] Tracker for Container Review Requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431528] Container Review Request: redis - Redis in-memory data structure store, used as database, cache and message broker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431528

Honza Horak  changed:

   What|Removed |Added

 Blocks||1436796




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1436796
[Bug 1436796] Tracker for Container Review Requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421601] Container Review Request: ruby - Platform for building and running Ruby applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421601

Honza Horak  changed:

   What|Removed |Added

 Blocks||1436796




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1436796
[Bug 1436796] Tracker for Container Review Requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432955] Review Request: lld - The LLVM linker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432955



--- Comment #1 from Igor Gnatenko  ---
> %setup -q -n %{name}-%{version}.src
> %patch0 -p1 -b .pthread-fix
-> %autosetup -n %{name}-%{version}.src -p1

> mkdir -p _build
-> mkdir %{_target_platform}

> make %{?_smp_mflags}
-> %make_build

> make install DESTDIR=%{buildroot}
-> %make_install

> %post devel -p /sbin/ldconfig
> %postun devel -p /sbin/ldconfig
no need for triggers in devel subpkg

> Summary:  A C language family front-end for LLVM
That sounds very weird.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Peter Lemenkov  changed:

   What|Removed |Added

 Blocks|1436417 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1436417
[Bug 1436417] Enable ac3 with liba52 in alsa-plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436734] New: Review Request: ocfs2-tools - Tools for managing the Oracle Cluster Filesystem 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436734

Bug ID: 1436734
   Summary: Review Request: ocfs2-tools - Tools for managing the
Oracle Cluster Filesystem 2
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: robinlee.s...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://cheeselee.fedorapeople.org/ocfs2-tools.spec
SRPM URL: https://cheeselee.fedorapeople.org/ocfs2-tools-1.8.5-1.fc24.src.rpm
Description: Programs to manage the OCFS2 cluster file system, including
mkfs.ocfs2,
tunefs.ocfs2 and fsck.ocfs2.

OCFS2 is a general purpose extent based shared disk cluster file
system. It supports 64 bit inode numbers, and has automatically
extending metadata groups which may also make it attractive for
non-clustered use. OCFS2 leverages some well tested kernel
technologies, such as JBD - the same journaling subsystem in use by
ext3.

Fedora Account System Username: cheeselee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358293] Review Request: bcg729 - Opensource implementation of the G.729 codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358293

Peter Lemenkov  changed:

   What|Removed |Added

 Whiteboard||NotReady



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357483] Review Request: twinkle - SIP-based VoIP client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357483
Bug 1357483 depends on bug 1358293, which changed state.

Bug 1358293 Summary: Review Request: bcg729 - Opensource implementation of the 
G.729 codec
https://bugzilla.redhat.com/show_bug.cgi?id=1358293

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|NOTABUG |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358293] Review Request: bcg729 - Opensource implementation of the G.729 codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358293

Peter Lemenkov  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|NOTABUG |---
   Keywords||Reopened



--- Comment #25 from Peter Lemenkov  ---
I'd like to reopen this considering recent legal changes mentioned above. Just
to make sure it will be on the radar.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435550] Review Request: perl-Dist-Zilla-Role-PluginBundle-PluginRemover - Remove plugins from a Dist ::Zilla plugin bundle

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435550

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires
perl-Dist-Zilla-Role-PluginBundle-PluginRemover-0.104-1.fc27.noarch.rpm | sort
| uniq -c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(Dist::Zilla::Util)
  1 perl(List::Util) >= 1.45
  1 perl(Moose::Role)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides
perl-Dist-Zilla-Role-PluginBundle-PluginRemover-0.104-1.fc27.noarch.rpm | sort
| uniq -c
  1 perl(Dist::Zilla::Role::PluginBundle::PluginRemover) = 0.104
  1 perl-Dist-Zilla-Role-PluginBundle-PluginRemover = 0.104-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Role-PluginBundle-PluginRemover*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435550] Review Request: perl-Dist-Zilla-Role-PluginBundle-PluginRemover - Remove plugins from a Dist ::Zilla plugin bundle

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435550

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435542] Review Request: perl-Config-MVP-Slicer - Extract embedded configuration from a parent configuration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435542

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Config-MVP-Slicer-0.302-1.fc27.noarch.rpm | sort |
uniq -c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(Carp)
  1 perl(Moose)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Config-MVP-Slicer-0.302-1.fc27.noarch.rpm | sort |
uniq -c
  1 perl(Config::MVP::Slicer) = 0.302
  1 perl-Config-MVP-Slicer = 0.302-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Config-MVP-Slicer*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435542] Review Request: perl-Config-MVP-Slicer - Extract embedded configuration from a parent configuration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435542

Jitka Plesnikova  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jples...@redhat.com
 QA Contact|jples...@redhat.com |extras...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435542] Review Request: perl-Config-MVP-Slicer - Extract embedded configuration from a parent configuration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435542

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
 QA Contact|extras...@fedoraproject.org |jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428974] Review Request: rgbds - A development package for Game Boy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428974



--- Comment #17 from Sanqui (David Labský)  ---
Thank you for help and approving the package!

I have reported failing tests upstream and we'll talk about how to improve them
for the future: https://github.com/rednex/rgbds/issues/144

I will look into attempting some reviews soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435375] Review Request: perl-Dist-Zilla-Plugin-ReversionOnRelease - Bump and reversion version on release

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435375

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires
perl-Dist-Zilla-Plugin-ReversionOnRelease-0.06-1.fc27.noarch.rpm | sort | uniq
-c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(:VERSION) >= 5.8.0
  1 perl(Dist::Zilla) >= 4.2
  1 perl(Dist::Zilla::Role::FileFinderUser)
  1 perl(Dist::Zilla::Role::FileMunger)
  1 perl(Moose)
  1 perl(Version::Next) >= 0.002
  1 perl(strict)
  1 perl(version)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides
perl-Dist-Zilla-Plugin-ReversionOnRelease-0.06-1.fc27.noarch.rpm | sort | uniq
-c
  1 perl(Dist::Zilla::Plugin::ReversionOnRelease) = 0.06
  1 perl-Dist-Zilla-Plugin-ReversionOnRelease = 0.06-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-ReversionOnRelease*
perl-Dist-Zilla-Plugin-ReversionOnRelease.noarch: W: spelling-error
%description -l en_US VersionFromModule -> Oversimplification
perl-Dist-Zilla-Plugin-ReversionOnRelease.noarch: W: spelling-error
%description -l en_US CopyFilesFromRelease
perl-Dist-Zilla-Plugin-ReversionOnRelease.src: W: spelling-error %description
-l en_US VersionFromModule -> Oversimplification
perl-Dist-Zilla-Plugin-ReversionOnRelease.src: W: spelling-error %description
-l en_US CopyFilesFromRelease
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302



--- Comment #20 from Miro Hrončok  ---
(In reply to Miro Hrončok from comment #19)
> (In reply to Jaroslav Škarvada from comment #17)
> > Few comments from me, but none is blocker:
> > > BuildRequires:  python3-sip
> > 
> > This is not needed, because there is already:
> > > BuildRequires:  python3-sip-devel
> > 
> > It's guaranteed by guidelines that it will bring-in the python3-sip package
> > automatically.

Done.

> > > %if "%{_libdir}" == "/usr/lib64"
> > > sed -i 's|DESTINATION lib|DESTINATION lib64|g' CMakeLists.txt
> > > sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR lib64|g'  
> > > CMakeLists.txt
> > > %endif
> > 
> > Maybe simpler way:
> > sed -i 's|DESTINATION lib|DESTINATION %{_lib}|g' CMakeLists.txt
> > sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR %{_lib}|g'

Done.

> > Is the patch needed? Couldn't be the same behavior achieved by e.g.:
> >  cmake -DCMAKE_SKIP_RPATH:BOOL=ON
> Will try.

Works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436010] Review Request: php-google-apiclient1 - Client library for Google APIs (version 1)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436010

Remi Collet  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Remi Collet  ---
+# Package rename (php-google-apiclient => php-google-apiclient1)
+Obsoletes: php-google-apiclient-examples < 2:1.1.7-4
+Provides:  php-google-apiclient-examples = 2:%{version}-%{release}
+


[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.


No more blocker

== APPROVED ==

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414216] Review Request: php-gettext-gettext - PHP gettext manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414216

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #11 from Remi Collet  ---
Sorry for long delay (don't why is doesn't appear to me before...)


[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/php/Gettext(php-
 gettext-languages), which is required.

[!]: Requires correct, justified where necessary.
See phpci-src.log
=> missing php-dom ans php-simplexml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414216] Review Request: php-gettext-gettext - PHP gettext manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414216



--- Comment #10 from Remi Collet  ---
Created attachment 1266921
  --> https://bugzilla.redhat.com/attachment.cgi?id=1266921=edit
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1414216
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414216] Review Request: php-gettext-gettext - PHP gettext manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414216

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com



--- Comment #9 from Remi Collet  ---
Created attachment 1266920
  --> https://bugzilla.redhat.com/attachment.cgi?id=1266920=edit
phpci-src.log

phpCompatInfo version 5.0.6 DB version 1.19.0 built Mar 17 2017 06:44:54 CET
run in "src"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436010] Review Request: php-google-apiclient1 - Client library for Google APIs (version 1)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436010



--- Comment #4 from Shawn Iwinski  ---
(In reply to Remi Collet from comment #3)
> [x]: Package does not generate any conflict.
>   Conflicts present for safe upgrade path
> 
> [-]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.
>   You could have kept epoch = 2 (raising release to 3)
>   BTW, this means you will also have to set epoch to 3 in v2 package
>   Hopefuly, dependent packages should only use composer dep.

I was originally going for release 1 on the new pkg, but to be honest, I don't
know why :/  I took your advise and bumped the release (4, not 3) and kept
epoch 2 in the obsoletes/provides.



>   => Missing "Obsoletes" in the examples sub-package

Added



> [x]: Latest version is packaged.
>   Lastest compatible v1, by design
> 
> 
> Single blocker, missing obsoletes.



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/8407132e85687b5f7765244b0c42d185bc6cf3c1/php-google-apiclient1/php-google-apiclient1.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-google-apiclient1-1.1.7-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435375] Review Request: perl-Dist-Zilla-Plugin-ReversionOnRelease - Bump and reversion version on release

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435375

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435363] Review Request: perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile - Parse cpanfile for Dist:: Zilla prerequisites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435363

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile-0.08-1.fc27.noarch.rpm | sort |
uniq -c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(Dist::Zilla) >= 4.300017
  1 perl(Dist::Zilla::Role::MetaProvider)
  1 perl(Dist::Zilla::Role::PrereqSource)
  1 perl(Module::CPANfile) >= 0.903
  1 perl(Moose)
  1 perl(Try::Tiny) >= 0.1
  1 perl(strict)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile-0.08-1.fc27.noarch.rpm | sort |
uniq -c
  1 perl(Dist::Zilla::Plugin::Prereqs::FromCPANfile) = 0.08
  1 perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile = 0.08-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile*
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.noarch: W: spelling-error
Summary(en_US) cpanfile -> campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.noarch: W: spelling-error
%description -l en_US cpanfile -> campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.noarch: W: spelling-error
%description -l en_US CPANFile -> Campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.src: W: spelling-error
Summary(en_US) cpanfile -> campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.src: W: spelling-error %description
-l en_US cpanfile -> campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.src: W: spelling-error %description
-l en_US CPANFile -> Campanile
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302



--- Comment #19 from Miro Hrončok  ---
(In reply to Jaroslav Škarvada from comment #17)
> Few comments from me, but none is blocker:
> > BuildRequires:  python3-sip
> 
> This is not needed, because there is already:
> > BuildRequires:  python3-sip-devel
> 
> It's guaranteed by guidelines that it will bring-in the python3-sip package
> automatically.
Right.

> 
> > %if "%{_libdir}" == "/usr/lib64"
> > sed -i 's|DESTINATION lib|DESTINATION lib64|g' CMakeLists.txt
> > sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR lib64|g'  
> > CMakeLists.txt
> > %endif
> 
> Maybe simpler way:
> sed -i 's|DESTINATION lib|DESTINATION %{_lib}|g' CMakeLists.txt
> sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR %{_lib}|g'
Sure.

> But maybe better is to patch the cmake files (and persuade upstream) to
> incorporate support for -DLIB_SUFFIX=64, in this way it will work out of the
> box.
Will do later.

> Is the patch needed? Couldn't be the same behavior achieved by e.g.:
>  cmake -DCMAKE_SKIP_RPATH:BOOL=ON
Will try.

Thnak you both.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302

Pavlina Moravcova Varekova  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #18 from Pavlina Moravcova Varekova  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "AGPL (v3 or later)", "Unknown or generated", "*No copyright*
 BSD (3 clause)". 8 files have unknown license. Detailed output of
 licensecheck in
 /home/pavlina/work/review/209/1401302-libarcus/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/cmake(qt5-qtbase)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[-]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python3-arcus , libarcus-debuginfo
[?]: Package functions as described.
[x]: Latest version is 

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302



--- Comment #17 from Jaroslav Škarvada  ---
Few comments from me, but none is blocker:
> BuildRequires:  python3-sip

This is not needed, because there is already:
> BuildRequires:  python3-sip-devel

It's guaranteed by guidelines that it will bring-in the python3-sip package
automatically.

> %if "%{_libdir}" == "/usr/lib64"
> sed -i 's|DESTINATION lib|DESTINATION lib64|g' CMakeLists.txt
> sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR lib64|g'  
> CMakeLists.txt
> %endif

Maybe simpler way:
sed -i 's|DESTINATION lib|DESTINATION %{_lib}|g' CMakeLists.txt
sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR %{_lib}|g'

But maybe better is to patch the cmake files (and persuade upstream) to
incorporate support for -DLIB_SUFFIX=64, in this way it will work out of the
box.

Is the patch needed? Couldn't be the same behavior achieved by e.g.:
 cmake -DCMAKE_SKIP_RPATH:BOOL=ON

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302



--- Comment #15 from Miro Hrončok  ---
(In reply to Jaroslav Škarvada from comment #14)
> > libarcus-devel.x86_64: W: only-non-binary-in-usr-lib
> 
> This one is false positive, probably due to cmake files and DSO symlink (no
> binary content), thus probably also OK.

Exactly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1212242] Review Request: golang-github-edsrzf-mmap-go - A portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1212242

Fabio Valentini  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks|1431740 |
 Resolution|--- |DUPLICATE
Last Closed||2017-03-28 05:28:14



--- Comment #4 from Fabio Valentini  ---
Closing this review request in favor of my new one, since it seems to be dead
and there hasn't been input from the submitter for quite some time.

*** This bug has been marked as a duplicate of bug 1431568 ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1431740
[Bug 1431740] Review Request: golang-github-cznic-internal - Shared
dependencies for other cznic Go libraries
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431568] Review Request: golang-github-edsrzf-mmap-go - Portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431568

Fabio Valentini  changed:

   What|Removed |Added

 CC||ggill...@redhat.com



--- Comment #4 from Fabio Valentini  ---
*** Bug 1212242 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431740

Fabio Valentini  changed:

   What|Removed |Added

 Depends On|1212242 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1212242
[Bug 1212242] Review Request: golang-github-edsrzf-mmap-go - A portable
mmap package for Go
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431568] Review Request: golang-github-edsrzf-mmap-go - Portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431568

Fabio Valentini  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|DUPLICATE   |---
   Keywords||Reopened



--- Comment #3 from Fabio Valentini  ---
Reopening, since the old review request is dead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431740
Bug 1431740 depends on bug 1431568, which changed state.

Bug 1431568 Summary: Review Request: golang-github-edsrzf-mmap-go - Portable 
mmap package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431568

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|DUPLICATE   |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411961] Review Request: golang-github-milochristiansen-axis2 - A simple virtual filesystem API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411961



--- Comment #3 from Fabio Valentini  ---
Pinging submitter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411962] Review Request: golang-github-milochristiansen-lua - A Lua 5.3 VM and compiler written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411962



--- Comment #3 from Fabio Valentini  ---
Pinging submitter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431735



--- Comment #1 from Fabio Valentini  ---
Pinging reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431736] Review Request: golang-github-cznic-strutil - Supplemental utilities for Go' s strings package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431736



--- Comment #1 from Fabio Valentini  ---
Pinging reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435363] Review Request: perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile - Parse cpanfile for Dist:: Zilla prerequisites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435363

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431587] Review Request: golang-github-cznic-mathutil - Supplemental utilities for Go' s rand and math packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431587



--- Comment #12 from Fedora Update System  ---
golang-github-cznic-mathutil-0-0.2.git1447ad2.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-04280ba6b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419361] Review Request: js-jquery-datetimepicker - jQuery Plugin Date and Time Picker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419361



--- Comment #6 from Fedora Update System  ---
js-jquery-datetimepicker-2.5.4-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ae34b54bff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421358] Review Request: js-jquery-noty - A jQuery notification plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421358



--- Comment #5 from Fedora Update System  ---
js-jquery-noty-2.4.1-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d4fd648e9d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org