[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
You should talk with upstream to move tests/ to be a subdirectory of the main
module, and keep the tests installed. Users might want to check the installed
package too (e.g. to see if everything still works in the installed system).

+ package name is OK (it's a python module, but primarily an application).
+ license is acceptable for Fedora
+ license is specified correctly
+ BR / R / P are OK (except one nitpick, see below)
+ modern python packaging template is used
+ %python_provide is used
+ python3 is used
+ %check is present and passes
+ no scriptlets are necessary
+ %license is used

You have BR: git. If you don't need a full-blown installation, git-core might
be better, it provides the more-commonly used tools and has a smaller set of
dependencies.

You might want to extend the %description a bit, to provide a more precise
description of what hatch does and how.

Rpmlint
---
Checking: hatch-0.11.0-1.fc28.noarch.rpm
  hatch-0.11.0-1.fc28.src.rpm
hatch.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy
hatch.noarch: W: spelling-error %description -l en_US workflow -> work flow,
work-flow, workforce
hatch.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/hatch/README.rst
hatch.noarch: W: no-manual-page-for-binary hatch
hatch.src: W: spelling-error Summary(en_US) env -> enc, en, envy
hatch.src: W: spelling-error %description -l en_US workflow -> work flow,
work-flow, workforce
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
All OK.

Rpmlint (installed packages)

hatch.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy
hatch.noarch: W: spelling-error %description -l en_US workflow -> work flow,
work-flow, workforce
hatch.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/hatch/README.rst
hatch.noarch: W: no-manual-page-for-binary hatch
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
All OK.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487877] Review Request: ocaml-result - Compat result type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487877



--- Comment #11 from Fedora Update System  ---
ocaml-result-1.2-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd5440bcc9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487877] Review Request: ocaml-result - Compat result type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487877



--- Comment #10 from Fedora Update System  ---
ocaml-result-1.2-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3317d50274

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467677] Review Request: gluster-block - A framework for gluster block storage management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467677



--- Comment #10 from Fedora Update System  ---
gluster-block-0.2.1-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-96750182d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486592] Review Request: ghc-concurrent-output - Ungarble output from several threads or commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486592



--- Comment #11 from Fedora Update System  ---
ghc-concurrent-output-1.9.2-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-611d5e7c31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426896] Review Request: ghc-file-embed - Use Template Haskell to embed file contents directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426896

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426896] Review Request: ghc-file-embed - Use Template Haskell to embed file contents directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426896



--- Comment #9 from Fedora Update System  ---
ghc-file-embed-0.0.10-5.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-36682cafae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #19 from Alexander Ploumistos  ---
Thank you so much Antonio, it would take me months to figure out the python
bits.

I have amended the spec file, added the new patches and I also added a weak
dependency on the subpackage.


(In reply to Antonio Trande from comment #17)
> Set QWT library.

Was this necessary? This was the original conditional, and the second branch
was what we have in Fedora, no?

system (ls /usr/lib*/libqwt5.so) {
   LIBS+=-lqwt5
} else {
   system (ls /usr/lib*/libqwt5-qt4.so) {
  LIBS+=-lqwt5-qt4
   } else {
 system (ls /usr/lib*/libqwt-qt4.so) {
   LIBS+=-lqwt-qt4
 } else {LIBS+=-lqwt}
   }
}


Spec URL: https://alexpl.fedorapeople.org/packages/SciDAVis/scidavis.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/SciDAVis/scidavis-1.21-4.fc28.src.rpm

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21853986

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487884] Review Request: python-sortedcontainers - Python Sorted Container Types: SortedList, SortedDict, and SortedSet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487884



--- Comment #8 from Fedora Update System  ---
python-sortedcontainers-1.5.7-3.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6a554669de

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487884] Review Request: python-sortedcontainers - Python Sorted Container Types: SortedList, SortedDict, and SortedSet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487884

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487884] Review Request: python-sortedcontainers - Python Sorted Container Types: SortedList, SortedDict, and SortedSet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487884



--- Comment #9 from Fedora Update System  ---
python-sortedcontainers-1.5.7-3.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ed86f49e2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448735] Review Request: nodejs-conventional-commits-filter - Filter out reverted commits parsed by conventional-commits-parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448735



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-conventional-commits-filter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491492] New: Review Request: Coturn - TURN/STUN & ICE Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491492

Bug ID: 1491492
   Summary: Review Request: Coturn - TURN/STUN & ICE Server
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: christian.glom...@rwth-aachen.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://github.com/LorbusChris/coturn-rpm/blob/master/coturn.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/lorbus/coturn/fedora-26-x86_64/00601962-coturn/coturn-4.5.0.6-1.fc26.src.rpm
Description: RPM Packaging for Coturn in Fedora:
https://github.com/LorbusChris/coturn-rpm
https://copr.fedorainfracloud.org/coprs/lorbus/coturn/monitor/
Fedora Account System Username: Lorbus

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448735] Review Request: nodejs-conventional-commits-filter - Filter out reverted commits parsed by conventional-commits-parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448735
Bug 1448735 depends on bug 1448654, which changed state.

Bug 1448654 Summary: Review Request: nodejs-modify-values - Modify the values 
of an object
https://bugzilla.redhat.com/show_bug.cgi?id=1448654

   What|Removed |Added

 Status|RELEASE_PENDING |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448654] Review Request: nodejs-modify-values - Modify the values of an object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448654

Jared Smith  changed:

   What|Removed |Added

 Status|RELEASE_PENDING |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-09-13 19:15:23



--- Comment #4 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448735] Review Request: nodejs-conventional-commits-filter - Filter out reverted commits parsed by conventional-commits-parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448735
Bug 1448735 depends on bug 1448653, which changed state.

Bug 1448653 Summary: Review Request: nodejs-is-subset - Check if an object is 
contained within another one
https://bugzilla.redhat.com/show_bug.cgi?id=1448653

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448653] Review Request: nodejs-is-subset - Check if an object is contained within another one

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448653

Jared Smith  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-09-13 19:12:10



--- Comment #3 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454481] Review Request: grimmer-proggy-squaresz-fonts - Proggy Square with slashed zero programming font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454481



--- Comment #3 from Bojan Smojver  ---
Hopefully fixed package/spec here:

https://www.rexursive.com/pub/grimmer-proggy-squaresz-fonts/grimmer-proggy-squaresz-fonts-1.0-2.fc26.src.rpm
https://www.rexursive.com/pub/grimmer-proggy-squaresz-fonts/grimmer-proggy-squaresz-fonts.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486593] Review Request: ghc-torrent - BitTorrent file parser and generater

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486593

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1491457




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1491457
[Bug 1491457] Enable optional features
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485512] Review Request: ghc-terminal-size - Get terminal window height and width

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485512

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1491457




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1491457
[Bug 1491457] Enable optional features
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485491] Review Request: ghc-network-info - Access the local computer 's basic network configuration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485491

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1491457




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1491457
[Bug 1491457] Enable optional features
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485757] Review Request: ghc-fdo-notify - Desktop Notifications client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485757

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1491457




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1491457
[Bug 1491457] Enable optional features
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485500] Review Request: ghc-network-multicast - Simple multicast library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485500

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1491457




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1491457
[Bug 1491457] Enable optional features
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485487] Review Request: ghc-magic - Interface to C file/ magic library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485487

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1491457




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1491457
[Bug 1491457] Enable optional features
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485757] Review Request: ghc-fdo-notify - Desktop Notifications client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485757

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks|1176888 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1176888
[Bug 1176888] git-annex-6.20170818 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486593] Review Request: ghc-torrent - BitTorrent file parser and generater

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486593

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks|985082  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=985082
[Bug 985082] git annex webapp sub-command missing
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] New: Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456

Bug ID: 1491456
   Summary: Review Request: hatch - A modern project, package, and
virtual env manager for Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lbal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lbalhar.fedorapeople.org/hatch.spec
SRPM URL: https://lbalhar.fedorapeople.org/hatch-0.11.0-1.fc26.src.rpm
Description: Hatch is a productivity tool designed to make your workflow easier
and more efficient, while also reducing the number of other tools you need to
know. It aims to make the 90% use cases as pleasant as possible.
Fedora Account System Username: lbalhar

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21850563

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454481] Review Request: grimmer-proggy-squaresz-fonts - Proggy Square with slashed zero programming font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454481



--- Comment #2 from Bojan Smojver  ---
Thank you very much for reviewing!

I will address and repost the SRPM/spec files. I copied this from my existing
package of tinysz font, so some of the stuff I obviously forgot to edit. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490068] Review Request: python-graphitesend - Easy python bindings to write to Carbon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490068



--- Comment #14 from Fedora Update System  ---
python-graphitesend-0.10.0-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0c2d85973e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490068] Review Request: python-graphitesend - Easy python bindings to write to Carbon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490068



--- Comment #13 from Fedora Update System  ---
python-graphitesend-0.10.0-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-57804d0746

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490068] Review Request: python-graphitesend - Easy python bindings to write to Carbon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490068

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490068] Review Request: python-graphitesend - Easy python bindings to write to Carbon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490068



--- Comment #12 from Fedora Update System  ---
python-graphitesend-0.10.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-05a3ffe8b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438659] Review Request: astroid - A graphical threads-with-tags style fast email client for notmuch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438659



--- Comment #2 from Tristan Cacqueray  ---
Thanks for the review, I'll wait for the upstream port to WebKit2 to update
this review request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438667] Review Request: notmuch-abook - Notmuch addressbook

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438667



--- Comment #2 from Tristan Cacqueray  ---
I've updated the .spec and .src.rpm. Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #18 from Antonio Trande  ---
(In reply to Antonio Trande from comment #17)
> Created attachment 1325592 [details]
> config.pri changes
> 
> Patch for setting Python paths.
> Set QWT library.

There is an error in this patch:

modify

> pythonutils.path = "$$INSTALLBASE/share/scidavis"

with

> pythonutils.path = 
> "$$INSTALLBASE/..$$QMAKE_LIBDIR_QT/python2.7/site-packages/scidavis"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
eosrei-emojione-fonts-1.0-5.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-25da69a47f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467677] Review Request: gluster-block - A framework for gluster block storage management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467677

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
gluster-block-0.2.1-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba009a9b52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
gnome-shell-extension-ibus-font-0.20170217-2.fc27 has been pushed to the Fedora
27 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ddfc7765a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486592] Review Request: ghc-concurrent-output - Ungarble output from several threads or commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486592

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
ghc-concurrent-output-1.9.2-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-50d50823cd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487877] Review Request: ocaml-result - Compat result type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487877

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
ocaml-result-1.2-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cbc702fa43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #17 from Antonio Trande  ---
Created attachment 1325592
  --> https://bugzilla.redhat.com/attachment.cgi?id=1325592=edit
config.pri changes

Patch for setting Python paths.
Set QWT library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #16 from Antonio Trande  ---
Created attachment 1325591
  --> https://bugzilla.redhat.com/attachment.cgi?id=1325591=edit
SPEC file changes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #15 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #13)
> 
> 
> > 
> > > %config(noreplace) %{_sysconfdir}/scidavisrc.py
> > > %exclude %{_sysconfdir}/scidavisrc.pyc
> > > %exclude %{_sysconfdir}/scidavisrc.pyo
> > > %exclude %{_datadir}/%{name}/scidavisUtil.pyc
> > > %exclude %{_datadir}/%{name}/scidavisUtil.pyo
> > 
> > All Python files must be installed in their related paths inside a dedicated
> > python2-scidavis (and/or python3) sub-package:
> > http://fedoraproject.org/wiki/Packaging:Python#Macros
> 
> I don't understand how exactly that is supposed to work. It did seem weird
> to have those python scripts there, but supposedly they are some sort of
> configuration(?) files.
> 
> Should the subpackage place them in the same locations, or do I need to
> patch the makefile to get them to other paths?
> 
> Am I to use %{__python2}, %{python2_sitelib}, %{python2_sitearch} or none of
> them in this case?
> 
> Do I need to keep the byte compiled files as well?
> 
> Do I need extra Provides/Requires in the spec file?
> 
> Can you point me to a package (or more) that has such a subpackage, because
> I'm really lost on that one?
> 
> 
> > 
> > > /usr/bin/update-desktop-database &> /dev/null || :
> > 
> > Deprecated on Fedora > 25.
> 
> I will remove it. I suppose I can ignore the update-mime-database suggested
> by fedora-review as well?
> 
> 

Yes.

> > 
> > - Please, add an appdata file.
> 
> I have submitted a file upstream, which is to be included in 1.22:
> https://github.com/highperformancecoder/scidavis/pull/50
> https://github.com/highperformancecoder/scidavis/pull/52
> 
> I will add it to 1.21 as well.
> 
> 
> > - You can avoid using %find_lang because does not work in this case.
> 
> So I just copy the files over to %{_datadir}/%{name}/translations/ and leave
> it at that, no other declaration in the %files section?

Yes.

> 
> 
> > - Use %doc or %{_docdir}/%{name}, not both.
> 
> There is that CHANGES file that should go to /usr/share/doc/scidavis/ and
> then there is an html manual (under construction) that gets installed there
> from the makefile. If I don't use %doc, CHANGES does not get installed and
> if I use
> %doc CHANGES manual/index.html
> I get an added index.html outside the manual directory. Should I just drop
> %doc and say goodbye to the (unmaintained) CHANGES file?

See attached diff files.

> 
> 
> I'm willing to bet that you are starting to regret picking this up… Please
> bear with me!

It isn't a big deal. ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1225241] Review Request: stlink - STM32 discovery line Linux programmer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225241

Ricky Elrod  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2017-09-13 15:08:54



--- Comment #6 from Ricky Elrod  ---


*** This bug has been marked as a duplicate of bug 1488384 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1488384] Review Request: stlink - STM32 discovery line Linux programmer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1488384

Ricky Elrod  changed:

   What|Removed |Added

 CC||rel...@redhat.com



--- Comment #6 from Ricky Elrod  ---
*** Bug 1225241 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487877] Review Request: ocaml-result - Compat result type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487877



--- Comment #8 from Fedora Update System  ---
ocaml-result-1.2-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd5440bcc9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438667] Review Request: notmuch-abook - Notmuch addressbook

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438667

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - %{_datarootdir} → %{_datadir}

 - Use a more meaningful name for your archive, with:

Source0:   
https://github.com/guyzmo/notmuch-abook/archive/%{commit}/%{name}-%{version}.tar.gz


Other than this, no issue, package accepted.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated". 3 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/notmuch-abook/review-notmuch-
 abook/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: 

[Bug 1448653] Review Request: nodejs-is-subset - Check if an object is contained within another one

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448653



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-is-subset

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487877] Review Request: ocaml-result - Compat result type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487877



--- Comment #7 from Fedora Update System  ---
ocaml-result-1.2-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3317d50274

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448654] Review Request: nodejs-modify-values - Modify the values of an object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448654



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-modify-values

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448654] Review Request: nodejs-modify-values - Modify the values of an object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448654

Jared Smith  changed:

   What|Removed |Added

 Status|POST|RELEASE_PENDING



--- Comment #2 from Jared Smith  ---
Thanks for doing the review.  Yes, it would be nice to have 'ava' in Fedora,
but I'm still working through the long list of dependencies for it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438659] Review Request: astroid - A graphical threads-with-tags style fast email client for notmuch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438659

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,


 - Please bump to latest version 0.9.1

 - Please use a more meaningful name for your archive, just like this:

Source0:   
https://github.com/astroidmail/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

 - You're installing icons in hicolors, you must run gtk-update-icon-cache.
See:
https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache

%post
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

 - You're installing a .desktop file, you must run desktop-file-validate. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage


desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

 - %{_datarootdir} → %{_datadir}

 - webkitgtk and webkitgtk3 have been retired due to security issues. See:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/AKVB363GFCHHJ5MTHGVYHYT6NLLTF5VM/

  Please port the package to WebKit2. This is non-trivial work. It seems to be
in the "project" of upstream:
https://github.com/astroidmail/astroid/projects/1#card-2220439

 Until then, the package can't be included in Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE session settings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476590

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #21 from Robert-André Mauchin  ---
All okay, package accepted.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated", "*No copyright* Public domain", "LGPL (v3 or later)", "GPL
 (v2 or later) (with incorrect FSF address)", "*No copyright* LGPL
 (v2.1 or later)". 369 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/deepin-daemon/review-
 deepin-daemon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/es_419,
 /usr/share/locale/am_ET/LC_MESSAGES, /usr/lib/systemd/logind.conf.d,
 /usr/share/locale/am_ET, /usr/share/locale/es_419/LC_MESSAGES
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/locale/am_ET,
 /usr/share/dbus-1/system-services, /usr/share/dbus-1,
 /usr/lib/systemd/logind.conf.d, /usr/share/dbus-1/services,
 /usr/share/locale/es_419, /usr/share/locale/es_419/LC_MESSAGES,
 /usr/share/locale/am_ET/LC_MESSAGES
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store 

[Bug 1491281] Review Request: python-libsass - python bindings for libsass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491281



--- Comment #4 from Miro Hrončok  ---
15) the tests don't run:

+ /usr/bin/python2 setup.py test
running test
running egg_info
writing requirements to libsass.egg-info/requires.txt
writing libsass.egg-info/PKG-INFO
writing top-level names to libsass.egg-info/top_level.txt
writing dependency_links to libsass.egg-info/dependency_links.txt
writing entry points to libsass.egg-info/entry_points.txt
reading manifest file 'libsass.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.c' under directory 'libsass'
warning: no files found matching '*.cpp' under directory 'libsass'
warning: no files found matching '*.h' under directory 'libsass'
warning: no files found matching '*.hpp' under directory 'libsass'
warning: no files found matching 'libsass/Makefile'
writing manifest file 'libsass.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-x86_64-2.7/_sass.so -> 

--
Ran 0 tests in 0.000s

OK
+ /usr/bin/python3 setup.py test
running test
running egg_info
writing libsass.egg-info/PKG-INFO
writing dependency_links to libsass.egg-info/dependency_links.txt
writing entry points to libsass.egg-info/entry_points.txt
writing requirements to libsass.egg-info/requires.txt
writing top-level names to libsass.egg-info/top_level.txt
reading manifest file 'libsass.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.c' under directory 'libsass'
warning: no files found matching '*.cpp' under directory 'libsass'
warning: no files found matching '*.h' under directory 'libsass'
warning: no files found matching '*.hpp' under directory 'libsass'
warning: no files found matching 'libsass/Makefile'
writing manifest file 'libsass.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-x86_64-3.6/_sass.cpython-36m-x86_64-linux-gnu.so -> 

--
Ran 0 tests in 0.000s

OK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Jonathan Wakely  changed:

   What|Removed |Added

 CC||jwak...@redhat.com



--- Comment #14 from Jonathan Wakely  ---
This code leaks memory and doesn't close sockets.

Fedora already has a number of mature C++ libraries providing similar
functionality (boost-asio, asio, poco-net, ...) so I don't see why we would
want this anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491281] Review Request: python-libsass - python bindings for libsass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491281



--- Comment #3 from Miro Hrončok  ---
14) why does it BuildRequire six, but not require? Is it just needed for tests?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1455899] Review Request: qt5-qtremoteobjects - Qt5 - Qt Remote Objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1455899

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Hello,


 - Same as before, please split your description lines to be under 80
characters per line.

 - You've got a file listed twice:

  Note: warning: File listed twice: /usr/lib64/cmake/Qt5RemoteObjects
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

 - Please bump to version rc2.


All of this is trivial so the package is accepted but please fix them before
import.




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/lib64/cmake/Qt5RemoteObjects
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "GPL (v3)", "LGPL (v2.1 or v3)", "GPL (v3)
 LGPL (v3)", "Unknown or generated". 195 files have unknown license.
 Detailed output of licensecheck in
 /home/bob/packaging/review/qt5-qtremoteobjects/review-
 qt5-qtremoteobjects/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/qt5/bin
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/qt5/examples(qt5
 -qtxmlpatterns-examples, qt5-qt3d-examples, qt5-qtwebchannel-examples,
 qt5-qtserialbus-examples, qt5-qtwebsockets-examples, qt5-qtscript-
 examples, qt5-qtenginio-examples, qt5-qtconnectivity-examples, qt5
 -qtdeclarative-examples, qt5-qtsensors-examples, qt5-qttools-examples,
 qt5-qtmultimedia-examples, qt5-qtdatavis3d-examples, qt5-qtserialport-
 examples, qt5-qtwebengine-examples, qt5-qtwebview-examples, qt5
 -qtcharts-examples, qt5-qtquickcontrols-examples, qt5-qtgamepad-
 examples, qt5-qtlocation-examples, qt5-qtvirtualkeyboard-examples, qt5
 -qtscxml-examples, qt5-qtsvg-examples, qt5-qtbase-examples),
 /usr/lib64/qt5/mkspecs/features(qt5-qtbase-devel),
 /usr/lib64/qt5/mkspecs/modules(qt5-qtbase-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see 

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Charlie Sale  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DEFERRED
Last Closed||2017-09-13 10:39:22



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #13 from Charlie Sale  ---
Hey Neal

I am actually retracting my submission due to C++20 releasing a networking
library, which makes libsocketpp redundant and therefore unnecessary. Thanks
for your time anyways!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392950



--- Comment #11 from Dan Horák  ---
(In reply to IBM Bug Proxy from comment #10)
> --- Comment From m...@de.ibm.com 2017-09-13 09:55 EDT---
> Dan,
> I guess this can be closed "done" as it is part of Fedora 25 already - isn't
> it ?

correct, it's included in F-27 and Rawhide, so all is good

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485458] Review Request: orangefs - parallel network file system ( formerly PVFS2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485458

Jonathan Dieter  changed:

   What|Removed |Added

 CC||jdie...@lesbg.com
  Flags|needinfo?(jdie...@lesbg.com |
   |)   |



--- Comment #7 from Jonathan Dieter  ---
Sorry, just hit the wrong link there.  I am still interested in reviewing this,
but I've just returned home from a summer away, so I'm still getting back into
the swing of things.  Give me a week or so to get this together.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424482] Review Request: sge - Son of Grid Engine - Distributed Computing Management software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424482



--- Comment #11 from Dave Love  ---
By the way, the source tarballs are no longer available from Liverpool, and I
haven't been able to get that fixed.
I'll put source up at Sourceforge soon, and will have to put everything else
there, unfortunately.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424482] Review Request: sge - Son of Grid Engine - Distributed Computing Management software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424482



--- Comment #10 from Dave Love  ---
(In reply to Sidney Markowitz from comment #6)
> Created attachment 1309545 [details]
> alternate sge-rpath.patch that more fully fixes library path problem
> 
> I was not able to run the inst_sge configuration after installing this rpm.
> The problem was that sge-rpath.patch is incomplete fix to its problem. The
> error I get is
> 
> ./utilbin/lx-amd64/spooldefaults: error while loading shared libraries:
> libspoolc.so: cannot open shared object file: No such file or directory
> 
> and ldd spooldefaults confirms that it is not linked properly to let it find
> libspoolc.so.
> 
> This is related to https://arc.liv.ac.uk/trac/SGE/ticket/1494 which is
> marked as closed with a more complete patch, but the patch even though
> committed earlier somehow is not included in the 8.1.9 tarball.

There's a non-trivial issue with sorting out an upgrade path.
The internal rpath is actually fine anyhow, according to the fedora packaging
standard.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491216

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424482] Review Request: sge - Son of Grid Engine - Distributed Computing Management software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424482



--- Comment #9 from Dave Love  ---
(In reply to Julien Nicoulaud from comment #5)
>  - A libdrmaa.so symlink is provided, some other RPM packaging only provide
> libdrmaa.so.1.0, which breaks the JGDI API as the Java code explicitly looks
> for libdrmaa.so. Please keep it that way.

I don't know what packaging that is, but it's required.

> Some small details:
>  - in /etc/profile.d/sge.*, is it possible to export SGE_QMASTER_PORT as
> well ? This is needed by tools that interface with SGE via its API.

That's in my source, but there's a hook to set things anyhow.

>  - Some stuff is named "sge" (eg: service files, profile.d files), some
> "gridengine" (eg: root dir, spool dir, lib dir, sysconfig). Maybe it would
> be more consistent to just name everything "sge" (since environment
> variables start with SGE_ anyway).

I don't see a particular reason to change it, especially if it's going to allow
upgrades.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972



--- Comment #35 from Fabio Valentini  ---
The .spec looks good at first glance, I'll do a comprehensive review once the
last missing dependency hits rawhide mirrors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424482] Review Request: sge - Son of Grid Engine - Distributed Computing Management software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424482



--- Comment #8 from Dave Love  ---
(In reply to Sidney Markowitz from comment #4)
> In my opinion it would be extremely confusing to try to keep this package
> with the same name and versioning as gridengine-2011.11p1 when it is being
> built from the sources of SGE 8.1.9.

I've managed to bury comments while I was on holiday. I'm quite
familiar with the history, but I wanted comments from Orion
specifically as an FPC person. I don't see why it is confusing to
change the basis any more than it was from the Sun distribution. As
far as I know, SGE is sufficiently compatible that you could do an
online upgrade, although there's a fundamental problem with upgrading
tightly coupled distributed systems like this. If that's not so, it's
probably possible to fix the issue simply.

The current distribution should at least be retired for security
reasons. SoGE is basically dead too, but I can probably still address
at least security problems.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467677] Review Request: gluster-block - A framework for gluster block storage management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467677



--- Comment #8 from Fedora Update System  ---
gluster-block-0.2.1-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-96750182d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972



--- Comment #34 from Dusty Mabe  ---
yay! we are so close. thanks for everything and sorry I haven't been much help.
Since Fabio started the review I'll let him finish it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392950



--- Comment #10 from IBM Bug Proxy  ---
--- Comment From m...@de.ibm.com 2017-09-13 09:55 EDT---
Dan,
I guess this can be closed "done" as it is part of Fedora 25 already - isn't it
?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485458] Review Request: orangefs - parallel network file system ( formerly PVFS2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485458

Dave Love  changed:

   What|Removed |Added

 CC||dave.l...@manchester.ac.uk



--- Comment #6 from Dave Love  ---
I just noticed this, and should try to find time to comment in detail
as I put some effort into packaging it.  What I advertised is under
https://copr.fedorainfracloud.org/coprs/loveshack/orangefs/ but I have
an unfinished update against 2.9.5 to tackle at least library sonames
-- I forget what else off-hand, but will take a look.

There are various other problems for packaging that may or not be
helped by more recent code which I haven't followed.  The main one is,
I think, the need for combinatorial builds against tcp and openib
networking and the authentication methods.  I think it should support
EPEL to cater for the bulk of HPC systems (I added dkms support), and
shouldn't assume it's run as a system service since a big feature is
being able to spin up ephemeral filesystems in userspace.

HTH. Prod me if I don't get on it fairly soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972



--- Comment #33 from Athos Ribeiro  ---
They released 0.27.1 today. Package updated:

Spec URL: https://athoscr.fedorapeople.org/packaging/hugo.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/hugo-0.27.1-1.fc26.src.rpm
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21843819

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1455603] Review Request: qt5-qtspeech - Qt5 - Speech component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1455603

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Hello,

It's trivial but rpmlint is complaining because your description has lines over
80 characters:

qt5-qtspeech.src: E: description-line-too-long C The module enables a Qt
application to support accessibility features such as text-to-speech, which is
useful for end-users who are
qt5-qtspeech.src: E: description-line-too-long C visually challenged or cannot
access the application for whatever reason. The most common use case where
text-to-speech comes in handy
qt5-qtspeech.src: E: description-line-too-long C is when the end-user is
driving and cannot attend the incoming messages on the phone. In such a
scenario, the messaging application
qt5-qtspeech.src: E: description-line-too-long C can read out the incoming
message. Qt Serial Port provides the basic functionality, which includes
configuring, I/O operations,

Package has no issues otherwise, but you also need to bump version to RC2.
Package is accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "GPL (v3) LGPL (v3)", "GPL (v2)", "LGPL
 (v3)", "Unknown or generated". 63 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/qt5-qtspeech
 /review-qt5-qtspeech/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/qt5/examples(qt5
 -qtxmlpatterns-examples, qt5-qt3d-examples, qt5-qtwebchannel-examples,
 qt5-qtserialbus-examples, qt5-qtwebsockets-examples, qt5-qtscript-
 examples, qt5-qtenginio-examples, qt5-qtconnectivity-examples, qt5
 -qtdeclarative-examples, qt5-qtsensors-examples, qt5-qttools-examples,
 qt5-qtmultimedia-examples, qt5-qtdatavis3d-examples, qt5-qtserialport-
 examples, qt5-qtwebengine-examples, qt5-qtwebview-examples, qt5
 -qtcharts-examples, qt5-qtquickcontrols-examples, qt5-qtgamepad-
 examples, qt5-qtlocation-examples, qt5-qtvirtualkeyboard-examples, qt5
 -qtscxml-examples, qt5-qtsvg-examples, qt5-qtbase-examples)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of 

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1482202

Tom Gundersen  changed:

   What|Removed |Added

  Flags|needinfo?(tgunders@redhat.c |
   |om) |



--- Comment #18 from Tom Gundersen  ---
srpm: 
spec: 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972



--- Comment #32 from Athos Ribeiro  ---
- Issue #3 is also fixed

- Package was updated to the latest version (0.27)

Spec URL: https://athoscr.fedorapeople.org/packaging/hugo.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/hugo-0.27-1.fc26.src.rpm
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21843578

Sorry for the delay here: upstream releases versions quite fast with new
requirements. It turns out that not bundling golang requirements gets tricky
sometimes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491281] Review Request: python-libsass - python bindings for libsass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491281



--- Comment #2 from Miro Hrončok  ---
1) First of all: Always post links that can be downloaded and viewed as
plaintext / SRPM. There are automated tools here that expect that.

That would be:

Spec URL:
https://github.com/Traceur759/python-libsass/raw/master/python-libsass.spec
SRPM URL:
https://github.com/Traceur759/python-libsass/raw/master/python-libsass-0.13.2-1.fc26.src.rpm


2) You don't need to define a sum macro, just fill in the Summary: line and
then use %{summary} everywhere else.


3) Is suggest to drop the %{libname} macro and hardcode libsass-python in the
URL. It is convenient when one can just copy paste it form the spec. Also, you
can use %{url} in Source0:

URL:https://github.com/dahlia/libsass-python
Source0:   
%{url}/releases/download/%{version}/%{srcname}-%{version}.tar.gz


6) This bundles libsass C/C++ library. That one is packaged in Fedora:
https://apps.fedoraproject.org/packages/libsass

You should make every effort to use that package instead of the bundled code in
the tarball. This might involve patching.

If you absolutely fail (e.g. because the bundled version of libsass is very
diffferent from original (probably not, they use a git submodule), than you
need to indicate bundling by providing bundled(libsass).

See more about bundling at
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries


5) I see you use ExclusiveArch tag. Please, add a comment that explains why is
thet necessary. Or maybe it's not necessary at all? Even the libsass C/C++
package builds for all arches in Fedora.


6) Putting each BuildRequires on a separate line makes them more maintainable.
(But current way works as well and is OK.)


7) sed "1d" -i %{buildroot}/%{python2_sitearch}/sassc.py

I guess this is for shebang? If so:

 - is it possible to get rid of it once in prep?
 - can the command be chanaged to only delete the shebang if it's actually
there?


8) # Note that there is no %%files section for the unversioned python module if
we are building for several python runtimes

This is such common situation, that it might not require this comment any more.


9) README.rst is no license and should not be used with %license tag. Upstream
has a nice LICENSE file in git, maybe propose (pull request) a change to their
MANIFEST.in file to include LICENSE in the tarballs. In the meantime, this
package can live easily without the file.

Note: Somebody did this already:
https://github.com/dahlia/libsass-python/commit/a00117129e0e8a863195c378337fc416ee69b179


10) PKG-INFO is not documentation and does not belong to %doc


11) I see hardcoded 2.7, 3.6 and 36 in the %files section. While this might eb
Ok for 2.7, because theat will be the last version of 2, this is not Ok for
3.6. Use the following macros instead:

https://fedoraproject.org/wiki/Packaging:Python#Macros

%{python3_version_nodots} for 36
%{python3_version} for 3.6
%{python2_version} for 2.7


12) %{python3_sitearch}/__pycache__/

You have this in the files section. It will make your package own the entire
directory, which is not desired, python3-libs owns that directory.

Either use:

%{python3_sitearch}/__pycache__/*

to own everything inside, or be more explicit:

%{python3_sitearch}/__pycache__/sass.*
%{python3_sitearch}/__pycache__/sassc.*
...



13) The bindir section in %files looks like it doesn't belong anywhere, where
in fact it belongs to the python3-package. I suggest moving it more top in the
files list. (But that is not a strong opinion).





Feel free to ping me on #fedora-python for more info.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467677] Review Request: gluster-block - A framework for gluster block storage management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467677

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467677] Review Request: gluster-block - A framework for gluster block storage management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467677



--- Comment #7 from Fedora Update System  ---
gluster-block-0.2.1-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba009a9b52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454925] Review Request: rtags - A indexer for the c language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454925

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,


 - Group: is not used in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Release is missing its dist tag:

Release:3%{?dist}


 - Latest version is no 2.14. Please bump your SPEC accordingly:

Version:2.14
Release:1%{?dist}

> The project's home is on github and releases are done there (via tags), but 
> the project also uses git submodules and these are then not included in the 
> source tarball. 

  You should detail the steps you've made to get to the final archive, or
include a script to achieve this. I used git-archive-all to generate the
tar.gz, since your SRPM is 404ing.

 - You're including a user unit file, you thus must run the systemd scripplets
in %post, %preun, %postun. See:
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd

   First add the special BR/macro for systemd:

%{?systemd_requires}
BuildRequires:systemd

  Then add the scriplets:

%post
%systemd_post %{name}.service

%preun
%systemd_preun %{name}.service

%postun
%systemd_postun_with_restart %{name}.service


Anyhow, I'd like an updated SPEC and SRPM to continue the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491281] Review Request: python-libsass - python bindings for libsass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491281

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mhron...@redhat.com
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Miro Hrončok  ---
Marcel needs a sponsor, so here I come :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #11 from Fedora Update System  ---
eosrei-emojione-fonts-1.0-5.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-25da69a47f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491281] New: Review Request: python-libsass - python bindings for libsass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491281

Bug ID: 1491281
   Summary: Review Request: python-libsass - python bindings for
libsass
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mp...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/Traceur759/python-libsass/blob/master/python-libsass.spec
SRPM URL:
https://github.com/Traceur759/python-libsass/blob/master/python-libsass-0.13.2-1.fc26.src.rpm
Description: This is an RPM package for libsass python bindings.
Fedora Account System Username: dormouse

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #10 from Parag AN(पराग)  ---
(In reply to Bastien Nocera from comment #8)
> (In reply to Bastien Nocera from comment #7)
> > (In reply to Parag AN(पराग) from comment #6)
> > > 2) Good to add appstream metainfo file for this font like we have this
> > > /usr/share/appdata/abattis-cantarell.metainfo.xml
> > 
> > Can you please file a separate bug about this?
> 
> FWIW, I'm not really sure of why we'd need that when both cantarell and
> emojione are pulled in by portion of our default desktop.

Hm, You are right. I am not sure if this can be a new topic of discussion. We
have almost all fonts providing metainfo files and then some fonts are already
present in default desktop installation. Not sure if we want to remove metainfo
files from them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #9 from Parag AN(पराग)  ---
Thanks for confirming output of requires/provides.

For metainfo file here is the new bug ->
https://bugzilla.redhat.com/show_bug.cgi?id=1491265

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1489494] Review Request: mock-core-configs - Mock core config files basic chroots

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489494



--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/mock-core-configs. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467677] Review Request: gluster-block - A framework for gluster block storage management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467677



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/gluster-block. You may commit to the branch
"f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #8 from Bastien Nocera  ---
(In reply to Bastien Nocera from comment #7)
> (In reply to Parag AN(पराग) from comment #6)
> > 2) Good to add appstream metainfo file for this font like we have this
> > /usr/share/appdata/abattis-cantarell.metainfo.xml
> 
> Can you please file a separate bug about this?

FWIW, I'm not really sure of why we'd need that when both cantarell and
emojione are pulled in by portion of our default desktop.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #7 from Bastien Nocera  ---
(In reply to Parag AN(पराग) from comment #6)
> 1) I am not sure if something is wrong on my f27 system but following does
> not give any output to me whereas all other fonts are giving some output.
> 
> sudo dnf repoquery --provides eosrei-emojione-fonts
> sudo dnf repoquery --requires eosrei-emojione-fonts

$ rpm -q --provides eosrei-emojione-fonts
eosrei-emojione-fonts = 1.0-4.fc27
font(emojione)

As expected.

> 2) Good to add appstream metainfo file for this font like we have this
> /usr/share/appdata/abattis-cantarell.metainfo.xml

Can you please file a separate bug about this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||fonts-bugs@lists.fedoraproj
   ||ect.org,
   ||i18n-bugs@lists.fedoraproje
   ||ct.org, panem...@gmail.com



--- Comment #6 from Parag AN(पराग)  ---
1) I am not sure if something is wrong on my f27 system but following does not
give any output to me whereas all other fonts are giving some output.

sudo dnf repoquery --provides eosrei-emojione-fonts
sudo dnf repoquery --requires eosrei-emojione-fonts

2) Good to add appstream metainfo file for this font like we have this
/usr/share/appdata/abattis-cantarell.metainfo.xml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE session settings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476590



--- Comment #20 from sensor@gmail.com ---
Dependency is already available. Let's keep going.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454481] Review Request: grimmer-proggy-squaresz-fonts - Proggy Square with slashed zero programming font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454481

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,


  - You need to validate the appdata file. See
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage

  You need first:

BuildRequires: libappstream-glib

  Then in %install or %check:

appstream-util validate-relax --nonet
%{buildroot}/%{_datadir}/appdata/%{fontname}.metainfo.xml

 - It seems the spec file name is different from the Name:. Shouldn't it be
grimmer-proggy-squaresz-fonts.spec instead of grimmer-proggy-tinysz-fonts.spec
  Rpmlint complains about this. Besides, I've looked at the website and "tiny"
seems to be another font.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 1 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/grimmer-proggy-tinysz-fonts/review-grimmer-
 proggy-squaresz-fonts/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and 

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #14 from Alexander Ploumistos  ---
(In reply to Alexander Ploumistos from comment #13)
> Should the subpackage place them in the same locations, or do I need to
> patch the makefile to get them to other paths?

And a bonus question, if I keep them at the same locations, is there a problem
with
%config(noreplace) %{_sysconfdir}/scidavisrc.py
since it's supposed to be a configuration file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1452985] Review Request: rakudo-zef - Perl6 Module Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1452985

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #21 from Robert-André Mauchin  ---
Hello,


 - https://travis-ci.org/ugexe/zef doesn't seem to be a suitable URL for a
homepage. Check https://github.com/ugexe/zef instead

 - The latest published version on https://github.com/ugexe/zef is 0.1.27, I
guess you should bump the package like this:

URL:https://github.com/ugexe/zef
Source0:%url/archive/v%{version}/%{name}-%{version}.tar.gz


Although the package builds fine on Fedora 27, it fails to build on Rawhide:

>+ /usr/lib64/perl6/bin/mod_inst.pl 
>--to=/builddir/build/BUILDROOT/rakudo-zef-0.1.27-1.fc28.x86_64/usr/lib64/perl6/vendor
> --for=vendor
>Unhandled exception: While looking for 'ModuleLoader.moarvm': no such file or 
>directory
>   at :1  
> (/usr/lib64/perl6/runtime/perl6.moarvm:)
>

I'm not a Perl specialist, maybe you have some insight as to why it fails with
such error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #13 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #12)
> > I have reported the issue upstream:
> > 
> > https://sourceforge.net/p/scidavis/scidavis-bugs/317/
> 
> Okay.

Robert-André Mauchin provided a patch on the devel mailing list. I will send a
PR upstream and submit an updated spec and srpm once we get through the other
issues.


> 
> > %config(noreplace) %{_sysconfdir}/scidavisrc.py
> > %exclude %{_sysconfdir}/scidavisrc.pyc
> > %exclude %{_sysconfdir}/scidavisrc.pyo
> > %exclude %{_datadir}/%{name}/scidavisUtil.pyc
> > %exclude %{_datadir}/%{name}/scidavisUtil.pyo
> 
> All Python files must be installed in their related paths inside a dedicated
> python2-scidavis (and/or python3) sub-package:
> http://fedoraproject.org/wiki/Packaging:Python#Macros

I don't understand how exactly that is supposed to work. It did seem weird to
have those python scripts there, but supposedly they are some sort of
configuration(?) files.

Should the subpackage place them in the same locations, or do I need to patch
the makefile to get them to other paths?

Am I to use %{__python2}, %{python2_sitelib}, %{python2_sitearch} or none of
them in this case?

Do I need to keep the byte compiled files as well?

Do I need extra Provides/Requires in the spec file?

Can you point me to a package (or more) that has such a subpackage, because I'm
really lost on that one?


> 
> > /usr/bin/update-desktop-database &> /dev/null || :
> 
> Deprecated on Fedora > 25.

I will remove it. I suppose I can ignore the update-mime-database suggested by
fedora-review as well?


> 
> - Please, add an appdata file.

I have submitted a file upstream, which is to be included in 1.22:
https://github.com/highperformancecoder/scidavis/pull/50
https://github.com/highperformancecoder/scidavis/pull/52

I will add it to 1.21 as well.


> - You can avoid using %find_lang because does not work in this case.

So I just copy the files over to %{_datadir}/%{name}/translations/ and leave it
at that, no other declaration in the %files section?


> - Use %doc or %{_docdir}/%{name}, not both.

There is that CHANGES file that should go to /usr/share/doc/scidavis/ and then
there is an html manual (under construction) that gets installed there from the
makefile. If I don't use %doc, CHANGES does not get installed and if I use
%doc CHANGES manual/index.html
I get an added index.html outside the manual directory. Should I just drop %doc
and say goodbye to the (unmaintained) CHANGES file?


I'm willing to bet that you are starting to regret picking this up… Please bear
with me!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491216] New: Review Request: 5minute - Give me an instance of mine image on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491216

Bug ID: 1491216
   Summary: Review Request: 5minute - Give me an instance of mine
image on OpenStack
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: pmora...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec
SRPM URL:
https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.x86_64.rpm
Description: Give me an instance of mine image on OpenStack. Hurry!
Fedora Account System Username: pmoravco

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467677] Review Request: gluster-block - A framework for gluster block storage management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467677



--- Comment #5 from Niels de Vos  ---
Thanks!

The repository has been requested:
  https://pagure.io/releng/fedora-scm-requests/issue/1117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #18 from Neal Gompa  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #17 from Hans de Goede  ---
Hi Neal,

Thank you for the review and I understand. 2 weeks ago Virtual Box upstream let
me know that they want to do some cleanups on the vboxguest character device
ioctl API before they are willing to declare it stable and promise they will
not break the API in the future. Virtual Box upstream is currently working on
these cleanups.

Once these cleanups are done, I will need to adjust my kernel patches to match
(*) and then submit a new version of the vbox patches to the upstream Linux
kernel. So for now I'm waiting on Virtual Box upstream. I will let you know
(here in this bug) when there is some progress.

Regards,

Hans


*) and do a new version of the VirtualBox-guest-additions package implementing
the new API)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485458] Review Request: orangefs - parallel network file system ( formerly PVFS2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485458

Neal Gompa  changed:

   What|Removed |Added

  Flags||needinfo?(jdie...@lesbg.com
   ||)



--- Comment #5 from Neal Gompa  ---
I'm willing to sponsor if Jonathan completes the review process.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org