[Bug 1752298] Review Request: python-wurlitzer - Capture C-level output in context managers

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752298

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Elliott Sales de Andrade  ---
Can replace Source0 with %pypi_source.
There appears to be a test in the tarball, but you don't have a %check.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Expat License". 9 files have unknown
 license. Detailed output of licensecheck in
 1752298-python-wurlitzer/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is 

[Bug 1749150] Review Request: rust-dutree - Command line tool to analyze disk usage

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1749150



--- Comment #8 from Fedora Update System  ---
dutree-rolling-3120190908151759.22d7e2a5 has been pushed to the Fedora 31
Modular testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-77b1b6d4ad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1748059

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-09-16 01:10:18



--- Comment #14 from Fedora Update System  ---
python-license-expression-0.999-1.fc30 has been pushed to the Fedora 30 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1714013] Review Request: python-pypcapkit - A Python multi-engine PCAP analyse kit

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1714013

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-09-16 00:01:12



--- Comment #9 from Fedora Update System  ---
python-pypcapkit-0.14.2-1.fc31 has been pushed to the Fedora 31 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1711611

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-09-16 00:01:50



--- Comment #18 from Fedora Update System  ---
pdfarranger-1.3.0-2.fc31 has been pushed to the Fedora 31 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1747852] Review Request: golang-github-aablinov-caddy-geoip - Caddy plugin to resolve user GeoIP data

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1747852

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-09-16 00:01:19



--- Comment #8 from Fedora Update System  ---
golang-github-aablinov-caddy-geoip-0-0.1.20190911gitc06787a.fc31 has been
pushed to the Fedora 31 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1747855] Review Request: golang-github-caddyserver-dnsproviders - DNS providers adapted for use in Caddy to solve the ACME DNS challenge

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1747855

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-09-16 00:01:11



--- Comment #8 from Fedora Update System  ---
golang-github-caddyserver-dnsproviders-0.3.0-1.fc31 has been pushed to the
Fedora 31 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1714001] Review Request: python-pyshark - Python packet parsing using wireshark dissectors

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1714001
Bug 1714001 depends on bug 1714013, which changed state.

Bug 1714013 Summary: Review Request: python-pypcapkit - A Python multi-engine 
PCAP analyse kit
https://bugzilla.redhat.com/show_bug.cgi?id=1714013

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752288] Review Request: Coin4 - High-level 3D visualization library

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752288



--- Comment #4 from Richard Shaw  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> Naming: Coin4 → coin4
> [https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/
> #_general_naming]
> Provides:Coin4 can be added.

I'm not necessarily against this but I was trying to stay consistent with Coin2
and Coin3 already in Fedora...


> Requires:   zlib-devel bzip2-devel
> → one per line please
> 
> %description devel → there should be a dot at the end of the text.

Fixed.


> Looks all nice. Though I wonder one thing: is is worth to bother with
> alternatives?
> Maybe just make coin*-devel packages Conflict with each other? The user
> doesn't get
> much benefit either way: it is still not possible to build against multiple
> Coin versions
> at the same time, and conflicting packages are easier to implement.

Yeah, I considered both but decided to stay consistent with Ralf's packages as
it does let you switch between them if you are actively developing with the
Coin3D stack, but yes, it serves no purpose on Fedora Infra.


(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> fedora-review says:
> - Large documentation must go in a -doc subpackage. Large could be size
>   (~1MB) or number of files.
>   Note: Documentation size is 127211520 bytes in 4678 files.
> 
> Yep, /usr/share/doc/Coin4/html should move to -doc subpackage.

Yeah, the guidelines are somewhat ambiguous here... so -doc or
-devel-doc? :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752292] Review Request: gnome-shell-extension-desktop-icons - GNOME Shell extension for providing desktop icons

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752292



--- Comment #2 from Artem  ---
https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033461-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons.spec

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033461-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons-19.01.4-3.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752139] Review Request: ucblogo - logo programming language

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752139



--- Comment #2 from Josh Cogliati  ---
It was missing g++ as a dependency.  Thank you for looking at it.  I fixed the
dependency.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1326504] Review Request: htslib - C library for high-throughput sequencing data formats (required for `samtools`)

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1326504



--- Comment #20 from Jun Aruga  ---
Hi Dave,

Here is the updated spec file and srpm file after your reviewing.

Spec URL:
https://raw.githubusercontent.com/junaruga/htslib-pkg/hotfix/review/htslib.spec
SRPM URL:
https://github.com/junaruga/htslib-pkg/blob/hotfix/review/htslib-1.9-1.fc32.src.rpm?raw=true

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=37675570
A test to install binary RPMs: ok
A test for rpmlint. There is below warning. But I like to postpone to fix it.

```
htslib.x86_64: W: shared-lib-calls-exit /usr/lib64/libhts.so.1.9
exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the-
error, reporting it to the user, closing files properly, and cleaning up any-
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the-
situation.
```

Below is the response for your review.

> * licensecheck says Expat rather than MIT -- I haven't checked

There is no "Expat" in the short name list used as "License:"'s value.
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

Also below package setting "MIT" is actually detected as "Expat" by
licensecheck command.
https://src.fedoraproject.org/rpms/golang-uber-zap/blob/master/f/golang-uber-zap.spec#_33

I think "MIT" is fine.

> * You could use %make_build in %build

done.

> * Remove the obsolete rm -rf from %install

done

> * To support EPEL, use %ldconfig_scriptlets instead of %post...

done.

I found a good example for that.
https://src.fedoraproject.org/rpms/libmodulemd/c/75a7af962341becaa6a7076e0b1e68c874acc7f9

> * The library needs sorting out.  Its soname is libhts.so.2, but
  it's installed as libhts.so.1.9 with a symlink to libhts.so.2.  I
  haven't checked what's going on.  The %files entry for it should
  be libhts.so.2*, so you know if it changes.  If the version is
  actually taken from the release version -- I dont know -- it
  shouldn't be, and could be set to 0 for Fedora.

I checked the upstream's behavior.

```
$ git clone g...@github.com:samtools/htslib.git
$ cd htslib
$ git checkout 1.9
$ make
$ make install prefix=$(pwd)/dist
```

`make` command creates libhts.so (actual so file) and libhts.so.2 (symbolic
link to libhts.so) on the current directory.
But `make install prefix=$(pwd)/dist` creates below files soname: libhts.so.1.9
and symbolic links: libhts.so and libhts.so.2. libhts.so.1.9 is the actual
soname used in the binary RPM file.

```
$ ls -l dist/lib/
total 10576
-rw-r--r-- 1 jaruga jaruga 7165054 Sep 15 21:54 libhts.a
lrwxrwxrwx 1 jaruga jaruga  13 Sep 15 22:01 libhts.so -> libhts.so.1.9
-rw-r--r-- 1 jaruga jaruga 3653800 Sep 15 21:55 libhts.so.1.9
lrwxrwxrwx 1 jaruga jaruga  13 Sep 15 22:01 libhts.so.2 -> libhts.so.1.9
drwxr-xr-x 2 jaruga jaruga4096 Sep 15 22:01 pkgconfig/
```

Do you have any concerns about this situation?
I suppose that current situation is no problem.

And as an additional change, as Makefile "install" task includes "install-so"
task, I removed "make "install-so" command line in htslib.spec. "make install"
is good enough.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752298] Review Request: python-wurlitzer - Capture C-level output in context managers

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752298



--- Comment #1 from Mukundan Ragavan  ---
koji scratch build -
https://koji.fedoraproject.org/koji/taskinfo?taskID=37674985

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752298] New: Review Request: python-wurlitzer - Capture C-level output in context managers

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752298

Bug ID: 1752298
   Summary: Review Request: python-wurlitzer - Capture C-level
output in context managers
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: nonamed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-wurlitzer/python-wurlitzer.spec
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-wurlitzer/python-wurlitzer-1.0.3-1.fc31.src.rpm


Description: Capture C-level stdout/stderr pipes in Python via os.dup2.

Fedora Account System Username: nonamedotc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752196



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
Yep, it seems this needs the latest mock to be deployed in infra. It's supposed
to happen soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752288] Review Request: Coin4 - High-level 3D visualization library

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752288



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
fedora-review says:
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 127211520 bytes in 4678 files.

Yep, /usr/share/doc/Coin4/html should move to -doc subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752233] Review Request: mle - small, flexible, terminal-based text editor

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752233

a...@php.net changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)
 Depends On|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752158] Review Request: termbox - Legacy-free alternative to ncurses

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752158

a...@php.net changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)
 Depends On|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752292] Review Request: gnome-shell-extension-desktop-icons - GNOME Shell extension for providing desktop icons

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752292



--- Comment #1 from Artem  ---
https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033363-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons.spec

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033363-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons-19.01.4-2.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752210] Review Request: json-table - Command-line tool to transform nested JSON into tabular data

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752210

Raphael Groner  changed:

   What|Removed |Added

Summary|Review Request: json-table  |Review Request: json-table
   |- Commandline tool to   |- Command-line tool to
   |transform nested JSON into  |transform nested JSON into
   |tabular data|tabular data



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 706310] Need EPEL-6 branches for LTSP

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=706310

Warren Togami  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |EOL
Last Closed||2019-09-15 19:01:17



--- Comment #19 from Warren Togami  ---
It appears the purpose of this bug was complete years ago. Closing.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752210] Review Request: json-table - Commandline tool to transform nested JSON into tabular data

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752210

Raphael Groner  changed:

   What|Removed |Added

Summary|Review Request: json-table  |Review Request: json-table
   |- Transform nested JSON |- Commandline tool to
   |data into tabular data in   |transform nested JSON into
   |the shell   |tabular data



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752210] Review Request: json-table - Transform nested JSON data into tabular data in the shell

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752210



--- Comment #4 from Raphael Groner  ---
Thanks. I'll edit the description while importing.

https://pagure.io/releng/fedora-scm-requests/issue/16760
https://pagure.io/releng/fedora-scm-requests/issue/16761
https://pagure.io/releng/fedora-scm-requests/issue/16762
https://pagure.io/releng/fedora-scm-requests/issue/16763

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1751138] Review Request: flamethrower - dnsperf alternative

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1751138



--- Comment #2 from Raphael Groner  ---
I'd even suggest to use:
+ Source0:
https://github.com/DNS-OARC/%{name}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz

https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1751138] Review Request: flamethrower - dnsperf alternative

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1751138

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #1 from Raphael Groner  ---
Some general hints:

Drop this line:
- %global commit v%{version}

Simplify those lines:
- URL:  https://github.com/DNS-OARC/flamethrower
- Source0: 
https://github.com/DNS-OARC/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz
+ URL:  https://github.com/DNS-OARC/%{name}
+ Source0:  %{url}/archive/v%{version}/%{name}-v%{version}.tar.gz

- Patch1:   flamethrower-0.10-libuv.patch
+ Patch1:   %{name}-0.10-libuv.patch

- make %{?_smp_mflags}
+ %make_build

Why does %make_install not work though cmake is used to generate a useful
Makefile?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752292] New: Review Request: gnome-shell-extension-desktop-icons - GNOME Shell extension for providing desktop icons

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752292

Bug ID: 1752292
   Summary: Review Request: gnome-shell-extension-desktop-icons -
GNOME Shell extension for providing desktop icons
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ego.corda...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033352-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033352-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons-19.01.4-1.fc30.src.rpm

Description:
This package provides a GNOME Shell extension for showing the contents
of ~/Desktop on the desktop of the Shell. Common file management operations
such as launching, copy/paste, rename and deleting are supported.

Fedora Account System Username: atim

Working COPR:
https://copr.fedorainfracloud.org/coprs/atim/gnome-shell-extension-desktop-icons

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1748956] Review Request: python-dateparser - A Python parser for human readable dates

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1748956

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard||FTBFS



--- Comment #3 from Raphael Groner  ---
FTBFS
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=37674068

sphinx-build -b html -d _build/doctrees   . _build/html
Running Sphinx v2.1.2
BUILDSTDERR: Configuration error:
BUILDSTDERR: There is a programmable error in your configuration file:
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File "/usr/lib/python3.8/site-packages/sphinx/config.py", line
361, in eval_config_file
BUILDSTDERR: execfile_(filename, namespace)
BUILDSTDERR:   File "/usr/lib/python3.8/site-packages/sphinx/util/pycompat.py",
line 86, in execfile_
BUILDSTDERR: exec(code, _globals)
BUILDSTDERR:   File "/builddir/build/BUILD/dateparser-0.7.1/docs/conf.py", line
34, in 
BUILDSTDERR: import dateparser
BUILDSTDERR:   File
"/builddir/build/BUILD/dateparser-0.7.1/dateparser/__init__.py", line 4, in

BUILDSTDERR: from .date import DateDataParser
BUILDSTDERR:   File
"/builddir/build/BUILD/dateparser-0.7.1/dateparser/date.py", line 11, in

BUILDSTDERR: from dateutil.relativedelta import relativedelta
BUILDSTDERR: ModuleNotFoundError: No module named 'dateutil'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752210] Review Request: json-table - Transform nested JSON data into tabular data in the shell

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752210



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
%description should be wrapped to ~80 columns.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752210] Review Request: json-table - Transform nested JSON data into tabular data in the shell

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752210

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Looks all good.

> Transform nested JSON data into tabular data in the shell
If found this quite confusing: "in the shell" would normally mean that the tool
itself is written
in bash. After all, it can be called anywhere, not just from the shell. I'd
prefer something like:
> Commandline tool to transform nested JSON into tabular data

+ package name is OK
+ latest version
+ license is acceptable (Eclipse 1.0)
+ license is specified correctly
+ builds and installs OK
+ /usr/bin/jt does not conflict with other packages

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752196

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard||FTBFS



--- Comment #3 from Raphael Groner  ---
FTBFS
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=37673990

Processing /builddir/build/BUILD/pytest-harvest-1.7.1
  Created temporary directory: /tmp/pip-req-build-df6cpr3q
  Added file:///builddir/build/BUILD/pytest-harvest-1.7.1 to build tracker
'/tmp/pip-req-tracker-mgpz8ptg'
Preparing wheel metadata: started
BUILDSTDERR: Running command /usr/bin/python3
/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py
prepare_metadata_for_build_wheel /tmp/tmp45fn8bcq
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File "setup.py", line 22, in 
BUILDSTDERR: from setuptools_scm import get_version
BUILDSTDERR: ModuleNotFoundError: No module named 'setuptools_scm'
BUILDSTDERR: The above exception was the direct cause of the following
exception:
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File
"/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 207,
in 
BUILDSTDERR: main()
BUILDSTDERR:   File
"/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 197,
in main
BUILDSTDERR: json_out['return_val'] = hook(**hook_input['kwargs'])
BUILDSTDERR:   File
"/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 69,
in prepare_metadata_for_build_wheel
BUILDSTDERR: return hook(metadata_directory, config_settings)
BUILDSTDERR:   File
"/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 156, in
prepare_metadata_for_build_wheel
BUILDSTDERR: self.run_setup()
BUILDSTDERR:   File
"/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 142, in
run_setup
BUILDSTDERR: exec(compile(code, __file__, 'exec'), locals())
BUILDSTDERR:   File "setup.py", line 24, in 
BUILDSTDERR: raise_from(Exception("Required packages for setup not
found. Please install 'setuptools_scm'"), e)
BUILDSTDERR:   File "", line 3, in raise_from
BUILDSTDERR: Exception: Required packages for setup not found. Please
install 'setuptools_scm'
:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752288] Review Request: Coin4 - High-level 3D visualization library

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752288

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Naming: Coin4 → coin4
[https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_general_naming]
Provides:Coin4 can be added.

Requires:   zlib-devel bzip2-devel
→ one per line please

%description devel → there should be a dot at the end of the text.

Looks all nice. Though I wonder one thing: is is worth to bother with
alternatives?
Maybe just make coin*-devel packages Conflict with each other? The user doesn't
get
much benefit either way: it is still not possible to build against multiple
Coin versions
at the same time, and conflicting packages are easier to implement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752196

Raphael Groner  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752288] New: Review Request: Coin4 - High-level 3D visualization library

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752288

Bug ID: 1752288
   Summary: Review Request: Coin4 - High-level 3D visualization
library
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: hobbes1...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora




Spec URL: https://hobbes1069.fedorapeople.org//Coin4.spec
SRPM URL: https://hobbes1069.fedorapeople.org//Coin4-4.0.0-1.fc30.src.rpm

Description:
Coin is a 3D graphics library with an Application Programming Interface
based on the Open Inventor 2.1 API.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1752288] Review Request: Coin4 - High-level 3D visualization library

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1752288



--- Comment #1 from Richard Shaw  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=37672923

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1709037

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Missing: BR: gcc

Something's off with the spacing in description:
$ rpm -qp --qf '%{description}'
/var/lib/mock/fedora-rawhide-x86_64/result/python3-javabridge-1.0.18-2.20190723git16d6c91.fc32.x86_64.rpm|nl
-ba
 1  
 2  The javabridge Python package makes it easy to start a Java virtual
machine (JVM)
 3  from Python and interact with it. Python code can interact with the JVM
using a
 4  low-level API or a more convenient high-level API.

Also, having a description for the binary package which does not get created is
strange.

My suggestion:

%global _description %{expand:
The javabridge Python package makes it easy to start a Java virtual machine
(JVM)
from Python and interact with it. Python code can interact with the JVM using a
low-level API or a more convenient high-level API.}

%description %_description

%description -n python%{python3_pkgversion}-%{modname} %_description

From %check:
> nose.plugins.cover: ERROR: Coverage not available: unable to import coverage 
> module
→ maybe add BR: python%{python3_pkgversion}-coverage to avoid the warning?

> sh: python: command not found
> Warning: Error loading 
It seems unversioned python is being called.
The call is:
> /bin/sh bin/python -c import sysconfig; from os.path import join; 
> print(join(sysconfig.get_config_var('LIBDIR'), 
> sysconfig.get_config_var('multiarchsubdir')[1:], 
> sysconfig.get_config_var('LDLIBRARY')))
This is going to give wrong results. I think that file needs to be patched to
call
%__python3 instead.

You build twice... I see setup.py manipulates sys.path to do import from $PWD,
which
doesn't work, because the binary module is missing. Too bad, I don't see an
easy way
to avoid this issue. Building twice doesn't seem so bad... OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1440687] Review Request: shc - Shell script compiler

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1440687



--- Comment #5 from Mosaab Alzoubi  ---
Thank You

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1441427] Review Request: smcalc - Matrix Calculator

2019-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1441427



--- Comment #4 from Mosaab Alzoubi  ---
Thank You

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org