[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967

Mattia Verga  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |ERRATA
Last Closed||2021-06-04 08:24:46



--- Comment #11 from Mattia Verga  ---
Package imported and later retired, closing.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #9 from mpr...@redhat.com  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.stg.fedoraproject.org/rpms/fritzing-parts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967

mpr...@redhat.com  changed:

   What|Removed |Added

 CC||mpr...@redhat.com



--- Comment #10 from mpr...@redhat.com  ---
Please ignore the above comment. That was just testing in staging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/fritzing-parts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Robert-André Mauchin  ---
Everything's okay. Package accepted.

Thanks for your work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #6 from Ed Marshall  ---
Ah, good point. I've added a comment about licensing disposition, and both spec
and SRPM have been updated, and the koji task is at:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21285345

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #5 from Robert-André Mauchin  ---
One thing that is missing from your SPEC is the license breakdown: If the
package is under multiple licenses, the licensing breakdown must be documented
in the spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #4 from Ed Marshall  ---
Spec URL: https://fedorapeople.org/~logic/fritzing-parts/fritzing-parts.spec
SRPM URL:
https://fedorapeople.org/~logic/fritzing-parts/fritzing-parts-0.9.3b-1.fc27.src.rpm
Description: Fritzing is a free software tool to support designers, artists and
hobbyists to work creatively with interactive electronics. The fritzing-parts
package contains a library of part definitions, including both meta-data and
related graphics.
Fedora Account System Username: logic

So yeah, Friting asset licensing has not been very well-managed. :( To make
things, simpler, I'm rebasing this to 0.9.3b, since upstream cleaned up a few
things with respect to licensing in that release (and that was going to be my
next step anyway, so might as well just do it now).

An audit by hand shows most assets as not being individually-licensed,
thankfully. A bunch of assets are explicitly licensed CC-BY-SA, (which goes
with the top-level LICENSE.txt), and there's a large number of SVG assets
(which appear to be converted from external sources like gEDA and Kicad) which
are all unversioned GPL (tagged by Fritzing's XML schema, so fedora-review
wasn't catching it).

The two CC0 matches appear to be mistakes; there's no license mentioned at all
in either of those files, which should fall back to the distribution-level
license. These mismatches carry through to 0.9.3b as well.

Also with 0.9.3b, there's a new file that throws a CC0 error, and while it has
an xmlns:cc attribute on the svg element, there's no license actually
specified, so again, we should fall back to the distribution-level license.
This one is weird in that it's not the only file in the distribution with a
ccREL xmlns attribute, although it's the only one that I noticed from a quick
check that didn't have some sort of cc:* element or an rdf section. I think I'm
going to have to chalk this up to a bug somewhere, unless someone has a better
idea of what is happening here.

(Weird that it's all SparkFun SVG files throwing these errors. ;))

Anyway, long story short: I'll update the License tag to "CC-BY-SA and GPL+",
but I'm going to skip adding CC0, since there is already a license on
everything that doesn't explicitly have one here (the top-level license), and
none of the files fedora-review tags as "CC0" explicitly specify any kind of
license (and nothing in the distribution explicitly chooses CC0).

Regarding a "Requires: fritzing = %{version}" tag, I've intentionally avoided
adding an explicit dependency from the parts library to Fritzing itself,
because during this transition phase you have to be able to install this
without explicitly pulling in Fritzing (because the current version of
Fritzing's file conflicts prevent it). Even in the future, there's no explicit
reason why fritzing-parts needs fritzing to be installed, and there's always
the possibility of other software in the future being able to make use of the
parts library.

(fritzing, however, will need to have a Requires on fritzing-parts once it's
been updated, because it's useless without the parts library.)

Anyway, thanks for taking the time to look at this! I've updated the .spec and
SRPM above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #3 from Robert-André Mauchin (afk until next Thu) 
 ---
There are some issues with the licences, some files are GPLv2+ and some other
GPLv3+:

*No copyright* CC0
--
fritzing-parts-0.9.2b/svg/obsolete/pcb/SparkFun-LCC20_SparkFun.svg
fritzing-parts-0.9.2b/svg/obsolete/pcb/SparkFun-LPCC20_SparkFun.svg

CC by
-
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/fullbreadboardgenerator/documentation/resources/guide_style.css

GPL (v2 or later) (with incorrect FSF address)
--
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/footgen/footgen.py

GPL (v3 or later)
-
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/dilPackageGenerator/generator.py
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/fullbreadboardgenerator/generator.py
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/resistorSetGenerator/valuesAndColors_forResistors.py


It should be reflected in the License: tag

 - I think you should add a specific verion of fritzing in the Requires tag
otherwiseit will conflicts with lower version of fritzing.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later) (with incorrect FSF address)", "CC by", "GPL
 (v3 or later)", "Unknown or generated", "*No copyright* CC0". 8576
 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/fritzing-parts/review-fritzing-
 parts/licensecheck.txt
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/fritzing/parts/svg/contrib/breadboard(fritzing),
 /usr/share/fritzing/parts/svg/core/breadboard(fritzing),
 /usr/share/fritzing/parts/svg/obsolete(fritzing),
 /usr/share/fritzing/parts/svg/contrib(fritzing),
 /usr/share/fritzing/parts/svg/user/schematic(fritzing),
 /usr/share/fritzing/parts/obsolete(fritzing),
 /usr/share/fritzing/parts(fritzing),
 /usr/share/fritzing/parts/svg/core/icon(fritzing),
 /usr/share/fritzing/parts/svg/contrib/pcb(fritzing),
 /usr/share/fritzing/parts/svg/core(fritzing),
 /usr/share/fritzing/parts/subparts2d/breadboard(fritzing),
 /usr/share/fritzing/parts/svg/obsolete/icon(fritzing),
 /usr/share/fritzing/parts/svg/contrib/schematic(fritzing),
 /usr/share/fritzing/parts/svg/user(fritzing),
 /usr/share/fritzing/parts/subparts(fritzing),
 /usr/share/fritzing/parts/core(fritzing),
 /usr/share/fritzing/parts/svg/core/pcb(fritzing),
 /usr/share/fritzing(fritzing),
 /usr/share/fritzing/parts/svg/contrib/icon(fritzing),
 /usr/share/fritzing/parts/user(fritzing),
 /usr/share/fritzing/parts/svg/user/icon(fritzing),
 /usr/share/fritzing/parts/svg/obsolete/pcb(fritzing),
 /usr/share/fritzing/parts/svg/core/schematic(fritzing),
 /usr/share/fritzing/parts/subparts2d(fritzing),
 /usr/share/fritzing/parts/svg/obsolete/breadboard(fritzing),
 /usr/share/fritzing/parts/svg/user/breadboard(fritzing),
 /usr/share/fritzing/parts/subparts/breadboard(fritzing),
 /usr/share/fritzing/parts/svg(fritzing),
 /usr/share/fritzing/parts/svg/user/pcb(fritzing),
 /usr/share/fritzing/parts/contrib(fritzing),
 /usr/share/fritzing/parts/svg/obsolete/schematic(fritzing)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #2 from Ed Marshall  ---
Spec URL: https://fedorapeople.org/~logic/fritzing-parts/fritzing-parts.spec
SRPM URL:
https://fedorapeople.org/~logic/fritzing-parts/fritzing-parts-0.9.2b-1.fc27.src.rpm
Description: Fritzing is a free software tool to support designers, artists and
hobbyists to work creatively with interactive electronics. The fritzing-parts
package contains a library of part definitions, including both meta-data and
related graphics.
Fedora Account System Username: logic

Thanks for catching those!

- I've yanked the Group: tag, and I'll pull it from Fritzing itself the next
time I issue an update.
- I've punted entirely on the patches, since as of the next update (which will
follow on the heels of this pretty quickly) those scripts won't even exist
anymore (which was the reason for both patches: fixing hashbang lines, and an
outdated FSF address, to make fedora-review happy). So, I've pulled the
obsolete parts scripts entirely, and both patches.
- I had no idea that URL would work with Github! This is so much better than
the reference trick I was using (which I'm sure I borrowed from an old mailing
list thread at some point), thank you!
- Yanked defattr, will get rid of it in Fritzing itself with the next release
too.

Koji scratch build is at:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21155649

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,


No time to do a full review right now, but here's a preliminary couple of
issues:

 - The tag "Group:" is to be removed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Your patches… what do they do? Have they been reported upstream? Do you have
a bug number for them? See
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

 - Change: 

Source0:  
https://github.com/fritzing/%{name}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
 

to

Source0:  
https://github.com/fritzing/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

 - %defattr(-,root,root,-) is not needed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org