[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-02-03 15:49:18 |2017-06-09 14:53:25



--- Comment #52 from Fedora Update System  ---
tpm2-tools-1.1.0-7.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #51 from Fedora Update System  ---
tpm2-tools-1.1.0-7.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fcf8be3d16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #50 from Fedora Update System  ---
tpm2-tools-1.1.0-7.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fcf8be3d16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #49 from Yunying Sun  ---
I kept receiving emails of broken dependencies in rawhide tree:

"tpm2-tools has broken dependencies in the rawhide tree:
On x86_64:
tpm2-tools-1.1.0-6.fc27.x86_64 requires tpm2-tss(x86-64) = 0:1.0-3.fc27
On i386:
tpm2-tools-1.1.0-6.fc27.i686 requires tpm2-tss(x86-32) = 0:1.0-3.fc27
Please resolve this as soon as possible."

"tpm2-tools has broken dependencies in the rawhide tree:
On x86_64:
tpm2-tools-1.1.0-5.fc26.x86_64 requires tpm2-tss(x86-64) = 0:1.0-2.fc26
On i386:
tpm2-tools-1.1.0-5.fc26.i686 requires tpm2-tss(x86-32) = 0:1.0-2.fc26
Please resolve this as soon as possible."

Seeing package source code:
http://pkgs.fedoraproject.org/cgit/rpms/tpm2-tss.git/
http://pkgs.fedoraproject.org/cgit/rpms/tpm2-tools.git/
It's clear that tpm2-tools fc26/master both has the correct dependency:
tpm2-tools-1.1.0-6  ->  tpm2-tss-1.0-3

But why it's still complaining the dependency below for rawhide/master/fc27:
tpm2-tools-1.1.0-6  ->  tpm2-tss-1.0-3

And why f26 is still using the old dependency?
tpm2-tools-1.1.0-5  ->  tpm2-tss-1.0-2

Anyone could kindly help me understand what's the problem here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #48 from Yunying Sun  ---
Thanks for the info, Dan. I just did a fedpkg build on rawhide/master, koji
build does pass: https://koji.fedoraproject.org/koji/taskinfo?taskID=18243729

So for rawhide, suppose I don't need to do anything more, and the broken deps
report will disappear automatically after some time with latest master repo
being used, right?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #47 from Dan Horák  ---
AFAIK there has been no successful F-26 compose after the branching (and
generally for some time), so even when koji has it right, the public repo, used
to generate the broken deps report, still contains the older/buggy version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #46 from Yunying Sun  ---
I have updated spec file trying to fix the broken dependency issue. Required
tpm2-tss version has been changed to "1.0-3" for master/f26:
http://pkgs.fedoraproject.org/cgit/rpms/tpm2-tools.git/

And seeing at tpm2-tss repo, package release version is also "1.0-3" for
master/f26:
http://pkgs.fedoraproject.org/cgit/rpms/tpm2-tss.git/

But why broken dependency emails still keep coming?
"tpm2-tools has broken dependencies in the rawhide tree:
On x86_64:
tpm2-tools-1.1.0-5.fc26.x86_64 requires tpm2-tss(x86-64) = 0:1.0-2.fc26
On i386:
tpm2-tools-1.1.0-5.fc26.i686 requires tpm2-tss(x86-32) = 0:1.0-2.fc26
Please resolve this as soon as possible."

What is the problem here? Dan, could you help me out?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #45 from Yunying Sun  ---
Hi Dan, please ignore my question in comment 44.
It's the proxy that blocks koji authentication. After unset proxy, fedpkg build
works fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #44 from Yunying Sun  ---
Thanks Dan. I just updated spec as stated in comment 42:
http://pkgs.fedoraproject.org/cgit/rpms/tpm2-tools.git/

"fedpkg local" pass, but "fedpkg build" gets stuck for ever, just hang there
without any output. Are you aware of any known issue like this?

I'm running fedpkg with version "1.26-4.el7" on RHEL 7.3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #43 from Dan Horák  ---
(In reply to Yunying Sun from comment #42)
> Or do I have to update requires dependency in tpm2-tools.spec like below for
> branch f26?
> From:
> Requires: tpm2-tss%{?_isa} = 1.0-2%{?dist} 
> To:
> Requires: tpm2-tss%{?_isa} = 1.0-3%{?dist}

yes, it can be the fix, if the dependency is so strict and dependency on just
the version can't be used.

The value of the Release tag can be changed by rel-eng scripts (like for the
mass rebuild) or by other maintainers (eg. when there are library soname bumps
with rebuilds of dependent packages needed).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #42 from Yunying Sun  ---
Or do I have to update requires dependency in tpm2-tools.spec like below for
branch f26?
From:
Requires: tpm2-tss%{?_isa} = 1.0-2%{?dist} 
To:
Requires: tpm2-tss%{?_isa} = 1.0-3%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #41 from Yunying Sun  ---
I kept getting emails like below:
"tpm2-tools has broken dependencies in the rawhide tree:
On x86_64:
tpm2-tools-1.1.0-5.fc26.x86_64 requires tpm2-tss(x86-64) = 0:1.0-2.fc26
On i386:
tpm2-tools-1.1.0-5.fc26.i686 requires tpm2-tss(x86-32) = 0:1.0-2.fc26
Please resolve this as soon as possible."

It seems tpm2-tss release version has been changed(2 -> 3) automatically for
Fedora_26_Mass_Rebuild:
https://src.fedoraproject.org/cgit/rpms/tpm2-tss.git/commit/?h=f26=ba9e00d48ca59fe472859283e29485fc14138035

While in tpm2-tools spec:
https://src.fedoraproject.org/cgit/rpms/tpm2-tools.git/tree/tpm2-tools.spec?h=f26

currently dependency is hard coded to tpm2-tss version 1.0-2:
# tpm2-tools is heavily depending on TPM2.0-TSS project, matched tss is
required
Requires: tpm2-tss%{?_isa} = 1.0-2%{?dist} 

Is there way or a macro that can be used to fix this issue? Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #40 from Fedora Update System  ---
tpm2-tools-1.1.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-02-03 15:49:18



--- Comment #39 from Fedora Update System  ---
tpm2-tools-1.1.0-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #38 from Yunying Sun  ---
SPEC was updated again to version 4, to fix Requires dependency check failure:
%changelog
* Fri Jan 20 2017 Sun Yunying  - 1.1.0-4
- Dependency check failed for Requires again, here to fix this
- Update release version and changelog

Package is under testing now for F25 & EPEL 7. More details at:
https://admin.fedoraproject.org/pkgdb/package/rpms/tpm2-tools/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #37 from Fedora Update System  ---
tpm2-tools-1.1.0-4.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff0d921e43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #36 from Fedora Update System  ---
tpm2-tools-1.1.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8ca50fc281

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #35 from Fedora Update System  ---
tpm2-tools-1.1.0-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8ca50fc281

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #34 from Fedora Update System  ---
tpm2-tools-1.1.0-4.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff0d921e43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #33 from Yunying Sun  ---
SPEC was updated to version 3, with changes below:

 %changelog
+* Thu Jan 19 2017 Sun Yunying  - 1.1.0-3
+- Change spec file permission to 644 to avoid rpmlint complain
+- Update Requires to fix dependency check error reported in Bodhi
+- Remove tpm2-tss-devel version in BuildRequires comment
+- Update release version and changelog

SCM link: http://pkgs.fedoraproject.org/cgit/rpms/tpm2-tools.git/

Testing update have been submitted for F25 & EPEL7:
https://bodhi.fedoraproject.org/updates/?packages=tpm2-tools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #32 from Fedora Update System  ---
tpm2-tools-1.1.0-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f74e35465b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #31 from Fedora Update System  ---
tpm2-tools-1.1.0-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4facb8a13d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #30 from Fedora Update System  ---
tpm2-tools-1.1.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-feea902234

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #29 from Fedora Update System  ---
tpm2-tools-1.1.0-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1326c8fcee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #28 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/tpm2-tools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #27 from Yunying Sun  ---
Thanks a lot Dan for the formal review and approval. New package request has
been created. I will fix the spec file permission issue before committing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Dan Horák  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #26 from Dan Horák  ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK  source files match upstream:
1d27f0e7564e7bf83b5751e5e9eb3f73c5dc971e  tpm2.0-tools-1.1.0.tar.gz
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  dist tag is present.
OK  license field matches the actual license.
OK  license is open source-compatible (BSD). License text included in
package.
OK  latest version is being packaged.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  package builds in mock (Rawhide/x86_64).
OK  debuginfo package looks complete.
OK* rpmlint is silent.
OK  final provides and requires look sane.
N/A %check is present and all tests pass.
OK  no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  no scriptlets present.
OK  code, not content.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no libtool .la droppings.
OK  not a GUI app.

- rpmlint complains a bit
tpm2-tools.src: W: spelling-error %description -l en_US tss -> ts, toss, ass
tpm2-tools.src: W: strange-permission tpm2-tools.spec 775
tpm2-tools.x86_64: W: spelling-error %description -l en_US tss -> ts, toss, ass
tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_*

Please fix the spec file permission before committing, the missing man pages
are not blocking the review, but would be nice to have at some point.

The package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #25 from Dan Horák  ---
(In reply to Yunying Sun from comment #24)
> Hi Dan, do you have time for a formal review of this package?

yes, I will do the formal review sometime this week

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #24 from Yunying Sun  ---
Hi Dan, do you have time for a formal review of this package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #23 from Yunying Sun  ---
Dan, do you have time for a formal review of this package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720
Bug 1369720 depends on bug 1369708, which changed state.

Bug 1369708 Summary: Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #22 from Yunying Sun  ---
Hi Dan, referring to your review comments to tpm2-tss(1369708), to fix most of
the common issues existing in this package, I've updated the spec & srpm:

%changelog
* Wed Dec 21 2016 Sun Yunying  - 1.1.0-2
- Remove pkg_version to avoid dupliate use of version
- Remove redundant BuildRequires for autoconf/automake/pkgconfig
- Add comments for BuildRequires of sapi/tcti-device/tcti-socket
- Use ExclusiveArch instead of ExcludeArch
- Requires tpm2-tss version updated to 1.0-2
- Updated release version and changelog

Updated SPEC: https://github.com/yunyings/share/raw/master/tpm2-tools.spec
Updated SRPM:
https://github.com/yunyings/share/raw/master/tpm2-tools-1.1.0-2.el7.src.rpm

Succeeded Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17010843
Succeeded COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/491741/

Please help to do a formal review. I will udpate timely if any issues left.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #21 from Yunying Sun  ---
(In reply to Dan Horák from comment #20)
> Taking for review.

Dan, my appreciate for taking this package too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Dan Horák  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||d...@danny.cz
 Blocks|177841 (FE-NEEDSPONSOR) |
   Assignee|nob...@fedoraproject.org|d...@danny.cz
  Flags||fedora-review?



--- Comment #20 from Dan Horák  ---
Taking for review.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #19 from Yunying Sun  ---
Fixed below rpmlint warnings:
tpm2-tools.src: W: summary-not-capitalized C a TPM2.0 testing tool build upon
TPM2.0-TSS
tpm2-tools.src: W: strange-permission tpm2-tools.spec 0775L
tpm2-tools.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 6)

Updated SPEC:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec
Updated SRPM:
https://github.com/yunyings/share/blob/master/tpm2-tools-1.1.0-1.el7.src.rpm?raw=true

Succeeded COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/484002/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #18 from Yunying Sun  ---
(run a fedora-review over this package myself)

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2


= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "BSD (2 clause)". Detailed output of
 licensecheck in /home/test/yunyings/rpmreview/1369720_tpm2-tools
 /review-tpm2-tools/licensecheck.txt
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/sbin, /usr/share/doc,
 /usr/share/licenses, /usr/share, /usr
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
 architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
 

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #17 from Yunying Sun  ---
Done some reviews, see comments in 1385331, 1366047, 1395522, 1394789, 1399648,
1398922. Will try to do more reviews in future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #16 from yunying@intel.com ---
Upstream has released v1.1.0 at early Nov 2016. Here I updated this package
from v1.1-beta_1 to v1.1.0.

Updated SPEC:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec
Updated SRPM:
https://github.com/yunyings/share/blob/master/tpm2-tools-1.1.0-1.el7.src.rpm?raw=true

Succeeded COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/476799/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Janet Morgan  changed:

   What|Removed |Added

 Blocks||1275029



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #15 from yunying@intel.com ---
I manually started a new COPR build for this package, since its dependent
package tpm2-tss has just been updated:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/472426/

No SPEC and SRPM update this time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #14 from yunying@intel.com ---
(In reply to Jared Wallace from comment #13)
> Tried running fedora-review on it, but the build failed...
> 
> Package pkgconfig-1:0.29.1-1.fc25.x86_64 is already installed, skipping.
> No matching package to install: 'pkgconfig(sapi)'
> No matching package to install: 'pkgconfig(tcti-device)'
> No matching package to install: 'pkgconfig(tcti-socket)'
> 
> Not all dependencies satisfied
> Error: Some packages could not be found.
> 
> 
> Given that it builds in copr, may just be my system. I'll take another look
> here in a bit.

Thanks for your comment, Jared.

This package has to be built upon the other new package: tpm2-tss(Bug 1369708).
Tpm2-tss will generate the required packages(sapi/tcti-device/tcti-socket)
which tpm2-tools need for compiling.

On COPR, I add packages "tpm2-tss" & "tpm2-tss-devel" to minimal buildroot of
tpm2-tools, and wait until tpm2-tss package build completed, so that these 2
*tss* packages are available before start building tpm2-tools.

Haven't run fedora-review locally, not sure how it should work..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Jared Wallace  changed:

   What|Removed |Added

 CC||jared-wall...@us.ibm.com



--- Comment #13 from Jared Wallace  ---
Tried running fedora-review on it, but the build failed...

Package pkgconfig-1:0.29.1-1.fc25.x86_64 is already installed, skipping.
No matching package to install: 'pkgconfig(sapi)'
No matching package to install: 'pkgconfig(tcti-device)'
No matching package to install: 'pkgconfig(tcti-socket)'
Not all dependencies satisfied
Error: Some packages could not be found.


Given that it builds in copr, may just be my system. I'll take another look
here in a bit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #12 from yunying@intel.com ---
SPEC updated to use version-release format in SPEC %changelog.

Updated SPEC:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec
Updated SRPMS:
https://github.com/yunyings/share/raw/master/tpm2-tools-1.1-0.1.beta1.el7.src.rpm
COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/459000/

Anyone could kindly help on the review and approve? Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #11 from yunying@intel.com ---
Ping. Could someone help to do further review? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #10 from yunying@intel.com ---
@Igor, would you be able to review this again? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #9 from yunying@intel.com ---
Updated SPEC again, to fix some common issues found in tpm2-tss review:
1. removed rename script
2. updated source url to make sure rpm don't fail at finding downloaded tarball

Updated SPEC:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec
Updated SRPMS:
https://github.com/yunyings/share/raw/master/tpm2-tools-1.1-0.1.beta1.el7.src.rpm
COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/452362/

Please help to review again. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #8 from yunying@intel.com ---
(In reply to Igor Gnatenko from comment #7)
> (In reply to yunying.sun from comment #6)
> > Updated SPEC again, to restrict builds to ix86 & x86_64 only by adding:
> > ExclusiveArch:  %{ix86} x86_64
> > Reason for this change is tool does not support big endian arch, and has
> > been verified only on Intel x86 & x86_64.
> I would recommend to use ExcludeArch and exclude all arches which are big
> endian.

Thanks Igor for the comment. I've updated SPEC to use ExcludeArch instead of
ExclusiveArch.

Besides, there're also some other changes from tpm2-tss comments: updated
Source0 url to match actual upstream package, add a script to rename tarball
when needed, use %autosetup instead of %setup and add "-n" to specify the
uncompressed folder name.

SPEC: https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec
SRPMS:
https://github.com/yunyings/share/raw/master/tpm2-tools-1.1-0.1.beta1.el7.src.rpm
COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/451937/

@Igor, could you help to review again? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #7 from Igor Gnatenko  ---
(In reply to yunying.sun from comment #6)
> Updated SPEC again, to restrict builds to ix86 & x86_64 only by adding:
> ExclusiveArch:  %{ix86} x86_64
> Reason for this change is tool does not support big endian arch, and has
> been verified only on Intel x86 & x86_64.
I would recommend to use ExcludeArch and exclude all arches which are big
endian.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #6 from yunying@intel.com ---
Updated SPEC again, to restrict builds to ix86 & x86_64 only by adding:
ExclusiveArch:  %{ix86} x86_64
Reason for this change is tool does not support big endian arch, and has been
verified only on Intel x86 & x86_64.

SPEC: https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec
SRPMS:
https://github.com/yunyings/share/raw/master/tpm2-tools-1.1-0.1.beta1.el7.src.rpm
COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/450605/

@Igor, could you help to do the review again? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #5 from yunying@intel.com ---
Updated SPEC to address dependencies to some of tpm2-tss generated libs:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec

SRPM updated accordingly:
https://github.com/yunyings/share/raw/master/tpm2-tools-1.1-0.1.beta1.el7.src.rpm

COPR build succeeded:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/449832/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #4 from yunying@intel.com ---
(In reply to Igor Gnatenko from comment #3)
> (In reply to yunying.sun from comment #2)
> > Updated SPEC/SRPM, added Requires/doc/release and some cflags: 
> > SPEC url: https://github.com/yunyings/share/blob/master/tpm2-tools.spec
> > SRPM url:
> > https://github.com/yunyings/share/blob/master/tpm2-tools-1.1-0.1.beta1.el7.
> > src.rpm
> > Koji build:
> > http://koji.fedoraproject.org/koji/taskinfo?taskID=15504011
> > 
> > Koji build still fails since tpm2-tss and tpm2-tss-devel package not
> > available yet.
> 
> you can build both in COPR repository.
> 
> https://copr.fedorainfracloud.org/

Thanks for the remind, Igor. Here are the succeeded COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/449768/

@Igor, could you help to review the SPEC for this package? 
https://github.com/yunyings/share/blob/master/tpm2-tools.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #3 from Igor Gnatenko  ---
(In reply to yunying.sun from comment #2)
> Updated SPEC/SRPM, added Requires/doc/release and some cflags: 
> SPEC url: https://github.com/yunyings/share/blob/master/tpm2-tools.spec
> SRPM url:
> https://github.com/yunyings/share/blob/master/tpm2-tools-1.1-0.1.beta1.el7.
> src.rpm
> Koji build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=15504011
> 
> Koji build still fails since tpm2-tss and tpm2-tss-devel package not
> available yet.

you can build both in COPR repository.

https://copr.fedorainfracloud.org/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #2 from yunying@intel.com ---
Updated SPEC/SRPM, added Requires/doc/release and some cflags: 
SPEC url: https://github.com/yunyings/share/blob/master/tpm2-tools.spec
SRPM url:
https://github.com/yunyings/share/blob/master/tpm2-tools-1.1-0.1.beta1.el7.src.rpm
Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15504011

Koji build still fails since tpm2-tss and tpm2-tss-devel package not available
yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #1 from yunying@intel.com ---
Updated SPEC/SRPM 
SPEC url: https://github.com/yunyings/share/blob/master/tpm2-tools.spec
SRPM url:
https://github.com/yunyings/share/blob/master/tpm2-tools-1.1-0.1.beta1.el7.src.rpm
Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15468903

Please note that koji build fail since it can not find SAPI libs, which should
be installed through another new package - tpm2-tss (bug 1369708).

Currently in SPEC, the line below is commented off:
BuildRequires:pkgconfig(tpm2-tss-1.0-0.1.beta1) 
I will update SPEC and enable it after tpm2-tss package is available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

yunying@intel.com changed:

   What|Removed |Added

 Depends On||1369708




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1369708
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

yunying@intel.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org