https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Hans de Goede changed:
What|Removed |Added
Flags|needinfo?(hdegoede@redhat.c |
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
krcr...@gmail.com changed:
What|Removed |Added
Flags||needinfo?(hdegoede@redhat.c
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Hans de Goede changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Patryk Obara changed:
What|Removed |Added
Flags||needinfo?(hdegoede@redhat.c
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #29 from Mohan Boddu ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/dosbox-staging
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #28 from Hans de Goede ---
p.s. Please let me know (send me an email) if you hit any issues, or if you are
unsure about how to do something. As your sponsor I'm here to answer any
questions about processes / tooling. Please don't
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Hans de Goede changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #27 from
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #26 from Hans de Goede ---
(In reply to Patryk Obara from comment #25)
> Are there any other issues with the spec file that need to be addressed?
No, I its just that I've been somewhat swamped with other stuff. I can make
some
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #25 from Patryk Obara ---
Are there any other issues with the spec file that need to be addressed?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #24 from Patryk Obara ---
(In reply to Kamil Páral from comment #23)
> (In reply to Hans de Goede from comment #18)
> > Oops, I made a copy and paste error in the Provides/Obsoletes bits, the
> > correct lines are:
> >
> >
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #23 from Kamil Páral ---
(In reply to Hans de Goede from comment #18)
> Oops, I made a copy and paste error in the Provides/Obsoletes bits, the
> correct lines are:
>
> Provides: dosbox = %{version}-%{release}
> Obsoletes:
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #22 from Patryk Obara ---
Spec URL:
https://raw.githubusercontent.com/dosbox-staging/dosbox-staging/master/contrib/fedora/dosbox-staging.spec
Spec diff:
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #21 from Kamil Páral ---
> The feature loss is limited to playing audio from physical game CDs, which I
> doubt has a lot of users.
I also see that "windowresolution=X%" option is no longer supported in the
config file. But yes,
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #20 from Hans de Goede ---
(In reply to Kamil Páral from comment #19)
> > ATM the package is using a Conflicts tag, but we generally do not allow
> > Conflicts
> > in Fedora. As discussed by email the plan is for this to replace
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #19 from Kamil Páral ---
> As discussed by email I'm taking over this review from François.
Thanks!
> ATM the package is using a Conflicts tag, but we generally do not allow
> Conflicts
> in Fedora. As discussed by email the
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #18 from Hans de Goede ---
Oops, I made a copy and paste error in the Provides/Obsoletes bits, the correct
lines are:
Provides: dosbox = %{version}-%{release}
Obsoletes: dosbox < %{version}-%{release}
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Hans de Goede changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #15 from Kamil Páral ---
Patryk, at this point I believe you should ask for a different package
reviewer/sponsor on the devel list [1]. I'm sure François means well, but he
clearly isn't responsive enough to move this forward :-/
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Patryk Obara changed:
What|Removed |Added
Flags||needinfo?(f...@fcami.net)
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #14 from Patryk Obara ---
Is there something I can do to push this review forward? It's only a simple
autotools build, really nothing out of ordinary…
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Andy Mender changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #12 from Patryk Obara ---
No problem, glad you're back on it :)
We did release 0.76.0 literally yesterday, but let's keep this review for
0.75.2 (in next version we added FluidSynth 2.x dependency, which is not
available e.g. on
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
François Cami changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|f...@fcami.net
--- Comment #11 from
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #9 from Patryk Obara ---
I decided to explicitly mark SDL BuildRequires as >= 2.0.2. Also, added a
comment to justify -O3 usage to comply with packaging guidelines:
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Kamil Páral changed:
What|Removed |Added
Flags||needinfo?(f...@fcami.net)
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #7 from Patryk Obara ---
@Kamil Páral
Thank you! :)
I wasn't even aware there is "Conflicts:" tag, that can be used.
URL with updated spec:
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #6 from Kamil Páral ---
As a side note, many thanks for bringing dosbox-staging to Fedora, Patryk. Your
project looks great (speaking as a retro gamer myself).
--
You are receiving this mail because:
You are on the CC list for
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #5 from Kamil Páral ---
This happens if a user has 'dosbox' installed and tries to install
'dosbox-staging':
$ sudo dnf install ./dosbox-staging-0.75.2-1.fc33.x86_64.rpm
...
Error: Transaction test error:
file /usr/bin/dosbox
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #4 from Patryk Obara ---
(In reply to François Cami from comment #2)
> Taking. I'm the current DOSBox maintainer and am very interested in this
> package.
Can we start the review process? I believe the spec is in quite good shape
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #3 from Patryk Obara ---
We released 0.75.2 yesterday, I updated the spec file:
Spec URL:
https://raw.githubusercontent.com/dosbox-staging/dosbox-staging/c280beeec011bacf96fa40cfe91260708cefec12/contrib/fedora/dosbox-staging.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
François Cami changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|f...@fcami.net
Doc Type|---
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Patryk Obara changed:
What|Removed |Added
CC||andreas.bierfert@lowlatency
https://bugzilla.redhat.com/show_bug.cgi?id=1884608
Patryk Obara changed:
What|Removed |Added
CC||dreamer.tan+fed...@gmail.co
33 matches
Mail list logo
