https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Petr Menšík changed:
What|Removed |Added
Blocks||2119985
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #83 from Frank Crawford ---
I think I have found the issue with el7. It doesn't have built-in c11 atomics,
so it is the only version that attempts to compile its own atomic_ops
functions, and it has a mistake. It is missing an
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #82 from Simone Caronni ---
(In reply to Frank Crawford from comment #81)
> We probably should look at what is wrong with el7, as it is still a major
> enterprise release, and so some people will probably want to install on it.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #81 from Frank Crawford ---
We probably should look at what is wrong with el7, as it is still a major
enterprise release, and so some people will probably want to install on it.
I suspect it will be pretty easy fix, and will look
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #80 from Simone Caronni ---
Thanks, I've added you as an admin to the package.
I've added small commits after the import:
https://src.fedoraproject.org/rpms/c-icap/commits/rawhide
I've built it on all supported releases, then we
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #79 from Fedora Admin user for bugzilla script actions
---
The Pagure repository was created at https://src.fedoraproject.org/rpms/c-icap
--
You are receiving this mail because:
You are always notified about changes to this
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #78 from
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #77 from Frank Crawford ---
I'm going to approve this, as I don't think there is anything else we need to
do.
However just to cover off the various rpmlint issues there are the reason to
accept:
> c-icap.x86_64: W:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #76 from Simone Caronni ---
Nevermind, I changed my mind. I made an attempt and was not very convinced.
Beside less substitution that can be used in the SPEC file, I think "c-icap" as
the main package and "c-icap-" as the
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #75 from Frank Crawford ---
(In reply to Simone Caronni from comment #70)
> What about renaming the package from "c-icap" to "c-icap-server" so it
> matches the repository name on Github?
I don't have any problem with that, and
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #74 from Simone Caronni ---
I've updated the modules and switched to LMDB at:
https://bugzilla.redhat.com/show_bug.cgi?id=2119984
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #73 from Fedora Review Service
---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5951852
(succeeded)
Review template:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #72 from Fedora Review Service
---
Created attachment 1966627
--> https://bugzilla.redhat.com/attachment.cgi?id=1966627=edit
The .spec file difference from Copr build 5732104 to 5951852
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #71 from Simone Caronni ---
Btw, easier to do the rename now while in review then later after the package
is already in the repositories.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #70 from Simone Caronni ---
What about renaming the package from "c-icap" to "c-icap-server" so it matches
the repository name on Github?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #69 from Simone Caronni ---
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec
SRPM URL:
https://slaanesh.fedorapeople.org/c-icap-0.5.11-11.20230403git1238524.fc38.src.rpm
* Wed May 24 2023 Simone Caronni -
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #68 from Frank Crawford ---
That is okay, I understand life gets in the way. Take as much time as you
need.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags|needinfo?(negativo17@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #65 from Frank Crawford ---
For
> c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap
> c-icap:c-icap 0750
I think the option to add
> su c-icap c-icap
is really the cleaner fix, although the Fedora policy doesn't
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #64 from Jakub Kadlčík ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5732104
(succeeded)
Review template:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #63 from Jakub Kadlčík ---
Created attachment 1954840
--> https://bugzilla.redhat.com/attachment.cgi?id=1954840=edit
The .spec file difference from Copr build 5567273 to 5732104
--
You are receiving this mail because:
You are
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags|needinfo?(negativo17@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #61 from Frank Crawford ---
For the last one
> c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so
> CI_DEBUG_LEVEL (/usr/lib64/c_icap/dnsbl_tables.so)
it may be that you require the libs package
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #60 from Frank Crawford ---
Oh, looking through the rpmlint output attached to the review, there are a
batch of little items that I see need fixing.
> c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap
>
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #57 from Jakub Kadlčík ---
Created attachment 1946539
--> https://bugzilla.redhat.com/attachment.cgi?id=1946539=edit
The .spec file difference from Copr build 5564920 to 5567273
--
You are receiving this mail because:
You are
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #58 from Jakub Kadlčík ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5567273
(succeeded)
Review template:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #56 from Simone Caronni ---
(In reply to Frank Crawford from comment #54)
> Simone, it currently fails to build, as you left off the line
>
> > install -d -m 0755 %{buildroot}/run/%{name}/
>
> Would you please fix and we will
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #55 from Frank Crawford ---
Looked at it all a bit closer and you also probably need to update the %files
line to
> %attr(0755,%{name},%{name}) %dir /run/%{name}/
That will match the actual creation in i-icap.tmpfiles.conf. It
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #54 from Frank Crawford ---
Simone, it currently fails to build, as you left off the line
> install -d -m 0755 %{buildroot}/run/%{name}/
Would you please fix and we will see how we go.
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #52 from Jakub Kadlčík ---
Created attachment 1946261
--> https://bugzilla.redhat.com/attachment.cgi?id=1946261=edit
The .spec file difference from Copr build 5537357 to 5564920
--
You are receiving this mail because:
You are
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #53 from Jakub Kadlčík ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5564920
(failed)
Build log:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #51 from Simone Caronni ---
(In reply to Simone Caronni from comment #50)
> Tried both, it did not help. So the warning comes from rpmlint, which checks
> for the %tmpfiles_create macro. The %tmpfiles_create macros have been
>
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #50 from Simone Caronni ---
(In reply to Frank Crawford from comment #49)
> Ahh, for this issue
>
> > c-icap.x86_64: W: post-without-tmpfile-creation
> > /usr/lib/tmpfiles.d/c-icap.conf
>
> It looks like the standard fix would
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #49 from Frank Crawford ---
Ahh, for this issue
> c-icap.x86_64: W: post-without-tmpfile-creation
> /usr/lib/tmpfiles.d/c-icap.conf
It looks like the standard fix would be to add into the %install section
> install -d -m 0755
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #48 from Jakub Kadlčík ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5537357
(failed)
Build log:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #47 from Simone Caronni ---
(In reply to Jakub Kadlčík from comment #46)
> Copr build:
> https://copr.fedorainfracloud.org/coprs/build/5537259
> (failed)
>
> Build log:
>
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Jakub Kadlčík changed:
What|Removed |Added
URL||http://%{name}.sourceforge.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #45 from Simone Caronni ---
I'll be away on holiday for 5 days starting tonight.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #44 from Simone Caronni ---
I've done some testing with the deprecated configure macros, but even
autoupdate + some manual changes to configure.ac does not meet my expectations,
I need someone a bit more knowledgeable on autotools
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #43 from Frank Crawford ---
Thanks for that.
I'll have a look around about what others do for the tmpfile issue, but
otherwise, I think we should be able to knock this over this week sometime.
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #42 from Simone Caronni ---
I really wish we had some formatting options and an edit button :/
Checking the m4 macros.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #41 from Simone Caronni ---
(In reply to Frank Crawford from comment #35)
> > Patches link to upstream bugs/comments/lists or are otherwise justified.
>
> This really just needs a comment in the spec file.
Done.
> > Package
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags|needinfo?(jonathan@almalinu |
|x.org)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags|needinfo?(negativo17@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #38 from Frank Crawford ---
Any update?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #37 from Simone Caronni ---
Sorry struggling a bit at work the past week. Will pick it up again tonight or
tomorrow.
Thanks for the heads up on the changes in the next release.
--
You are receiving this mail because:
You are
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #36 from Frank Crawford ---
FYI, just got this from upstream:
> Support for lmdb lookup tables exists in latest c-icap master branch.
> Also in latest c-icap-modules the url_check service can use, and by default
> uses, lmdb to
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #35 from Frank Crawford ---
@negativ...@gmail.com I've been through the full review process and found two
items that I'd say are "Fail" but are also easily fixed.
> Patches link to upstream bugs/comments/lists or are otherwise
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #33 from Simone Caronni ---
Ignore the message above, for some reason it did not find the src.rpm
momentarily. Builds fine on epel7 and up.
--
You are receiving this mail because:
You are always notified about changes to this
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #32 from Jakub Kadlčík ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5199014
(failed)
Build log:
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #31 from Simone Caronni ---
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec
SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-7.fc37.src.rpm
* Wed Jan 04 2023 Simone Caronni - 0.5.10-7
- Review fixes: drop
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #30 from Simone Caronni ---
(In reply to Frank Crawford from comment #29)
> As for Perl requirements, it was really just an FYI.
Actually I discovered perl-generators is already available in EPEL as well,
it's subpackage of
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #29 from Frank Crawford ---
Simone,
I'm fine with dropping BDB for now, especially to get it into the system. Once
the new packages/modules for LMDB or equivalent is added upstream, it may be
worth including a Fedora approved
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags|needinfo?(negativo17@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #27 from Frank Crawford ---
For the Perl requirements, you may also want to read
https://pagure.io/fesco/issue/2898 which is approved and upcoming.
--
You are receiving this mail because:
You are on the CC list for the bug.
You
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #26 from Frank Crawford ---
No problem. Thanks for doing the modules.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Benson Muite changed:
What|Removed |Added
Flags|needinfo?(benson_muite@emai |
|lplus.org)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #24 from Frank Crawford ---
I received a note back from the author on adding different DBs:
"Yes there is a small project which uses lmdb databases for both c-icap and
c-icap-modules.
Also there is a second small project to
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(benson_muite@emai
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #22 from Benson Muite ---
There are tests distributed with the code. Maybe some of these should be run in
a %check section?
Using:
./configure --with-perl --with-openssl --with-zlib --with-bzlib --with-ldap
--enable-ipv6
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #21 from Frank Crawford ---
(In reply to Benson Muite from comment #20)
> Based on the discussion https://github.com/c-icap/c-icap-server/issues/43
> Maybe it is easier to make a pull request? It seems changes are needed in
> 2
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Benson Muite changed:
What|Removed |Added
CC||benson_mu...@emailplus.org
---
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|fr...@crawford.emu.id.au
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags||needinfo?(jonathan@almalinu
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags||needinfo?(jonathan@almalinu
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #13 from Frank Crawford ---
Unfortunately, no, just soon, but I don't know how long that may be for them.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #12 from Simone Caronni ---
(In reply to Frank Crawford from comment #11)
> (In reply to Frank Crawford from comment #10)
> > Note, I've added it as a issue in the C-ICAP Github repo that it would be
> > good to move away from
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #11 from Frank Crawford ---
(In reply to Frank Crawford from comment #10)
> Note, I've added it as a issue in the C-ICAP Github repo that it would be
> good to move away from BDB. Will see what comes from it.
And the upstream
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #10 from Frank Crawford ---
Note, I've added it as a issue in the C-ICAP Github repo that it would be good
to move away from BDB. Will see what comes from it.
--
You are receiving this mail because:
You are on the CC list for
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #9 from Simone Caronni ---
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec
SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-6.fc36.src.rpm
I've bundled libdb 5.3.28 (last one with a valid license for Fedora)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags|needinfo?(negativo17@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Jonathan Wright changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #6 from Simone Caronni ---
btw, my time is limited, but if you need reviews in return for your effort
please let me know. Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #5 from Simone Caronni ---
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec
SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-6.fc36.src.rpm
Actually it was pretty easy, the DB support is only for supporting a list
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni changed:
What|Removed |Added
Flags|needinfo?(negativo17@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #3 from Jonathan Wright ---
> > > BuildRequires: libdb-devel
> >
> > This package is deprecated so you cannot depend on it. [4]
>
> I know there can't be newer versions in Fedora/EPEL due to licensing reasons
> (hit the same
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #2 from Simone Caronni ---
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec
SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-5.fc36.src.rpm
Thanks for the review!
I fixed everything except these:
(In reply to
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Jonathan Wright changed:
What|Removed |Added
Flags||fedora-review?
|
85 matches
Mail list logo
