[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047

Vít Ondruch  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||vondr...@redhat.com
 Resolution|--- |DUPLICATE
Last Closed||2018-05-03 03:30:42



--- Comment #9 from Vít Ondruch  ---


*** This bug has been marked as a duplicate of bug 1554033 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047

Bugzilla account termination  changed:

   What|Removed |Added

   Assignee|mmo...@redhat.com   |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047



--- Comment #7 from Nitesh Narayan Lal niteshnara...@fedoraproject.org ---
Hi,
I had modified the spec as  per the suggestions:
SPEC:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-em-websocket-client.spec
SRPMS:niteshnarayan.fedorapeople.org/SRPMS/rubygem-websocket-1.1.2-3.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047

Mo Morsi mmo...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mmo...@redhat.com



--- Comment #5 from Mo Morsi mmo...@redhat.com ---
Hey nitesh, few more things

- You need to include the full url to the spec and srpm in your comment for the
fedora-review tool to pick it up (eg the srpm is missing 'http://'

- Please rm, exclude, or mark the following files as %doc: Gemfile, Rakefile,
websocket.spec

- The package should have a copy of the MIT license, see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

- Remember to bump the release / add a new changelog entry before re-uploading.
Also wouldn't hurt to put the url of the koji scratch build run w/ the latest
version of the package (though not required as the review will run it
theirselves)

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047



--- Comment #6 from Mo Morsi mmo...@redhat.com ---
One additional thing, the 'rubygems' requirements should be 'Requires:
rubygems' and not 'Requires: ruby(rubygems)'

http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems

fedora-review will complain otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047



--- Comment #4 from Nitesh Narayan Lal niteshnara...@fedoraproject.org ---
Hi, 
I had updated the SPECS, thanks for holding on with this and helping.
SPEC:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-em-websocket-client.spec
SRPMS:niteshnarayan.fedorapeople.org/SRPMS/rubygem-websocket-1.1.2-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047



--- Comment #3 from Mo Morsi mmo...@redhat.com ---
Hey Nitesh some more comments:

- Please rename the spec to 'rubygem-em-websocket-client.spec' so fedora-review
will pick it up

- The rspec command in the %check section should be rspec -Ilib spec

- The .document and .rspec %files should be rm'd or %excluded

- Marking files under %files doc as %doc is a bit redundant, though don't
believe this is a blocker

- again Updated as per the comments in your changelog entry is a bit
ambiguous, perhaps some like updated to comply w/ Fedora guidelines would be
more direct

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047



--- Comment #2 from Nitesh Narayan Lal niteshnara...@fedoraproject.org ---
I had made the changes as per the comments .
SPEC:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-em-websocket-client-0.1.2.spec
SRPM:http://niteshnarayan.fedorapeople.org/SRPMS/rubygem-em-websocket-client-0.1.2-2.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047

Mo Morsi mmo...@redhat.com changed:

   What|Removed |Added

 CC||mmo...@redhat.com



--- Comment #1 from Mo Morsi mmo...@redhat.com ---
Hey Nitesh, some comments (similar to em-socksify)

- Gemfile, README, Rakefile, gemspec files should be marked as %doc

- Please rm the .document and .rspec files at some point during the build
process

- Build fails again since you use rspec and assumably eventmachine is needed to
run the test suite, yet neither are listed as Build Requirements on the
package.

- Consider removing the extraneous whitespace / blank lines.

If you could fix these  successfully build the package via koji I'll give you
the official review. Additionally if rspec / eventmachine are BuildRequirements
for the other packages you submitted (noticed it was the case for
eventmachine_httpserver as well) but aren't listed in the specs, please add
them so as to tackle this issue across them all.

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063047] Review Request: rubygem-em-websocket-client - A WebSocket client implementation for EventMachine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1063047

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)
Summary|Review Request: |Review Request:
   |em-websocket-client - A |rubygem-em-websocket-client
   |WebSocket client|- A WebSocket client
   |implementation for  |implementation for
   |EventMachine|EventMachine




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review