[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 gil cattaneo changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||zkclient-0.10-1.fc26 Resolution|--- |RAWHIDE Last Closed||2016-12-02 12:06:55 --- Comment #7 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16708246 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/zkclient -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 --- Comment #5 from gil cattaneo --- create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/9059 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449
--- Comment #4 from gil cattaneo ---
(In reply to Jonny Heggheim from comment #2)
> Review approved!
thanks!
> Comments:
> * Should use the lastest version
Done
> * Consider following the SourceURL package guideline for git tags
> https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags
Used:
Source0:
https://github.com/sgroschupf/zkclient/archive/%{version}/%{name}-%{version}.tar.gz
> * Consider deleting the bundled gradle wrapper in %prep
Already done
> * Consider using %gradle_build
> https://fedora-java.github.io/howto/25/index.html#gradle
Done
Spec URL: https://gil.fedorapeople.org/zkclient.spec
SRPM URL: https://gil.fedorapeople.org/zkclient-0.10-1.fc24.src.rpm
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16700694
(In reply to Jonny Heggheim from comment #3)
> Can you review bug 1399833 ?
Sure!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 --- Comment #3 from Jonny Heggheim --- Can you review bug 1399833 ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 Jonny Heggheim changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Jonny Heggheim --- Review approved! Comments: * Should use the lastest version * Consider following the SourceURL package guideline for git tags https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags * Consider deleting the bundled gradle wrapper in %prep * Consider using %gradle_build https://fedora-java.github.io/howto/25/index.html#gradle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449
--- Comment #1 from Jonny Heggheim ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
(v2.0)". 9 files have unknown license. Detailed output of licensecheck
in /home/jonny/tmp/1331449-zkclient/licensecheck.txt
Buildscript and two tests files are missing header. None of the is
redistributed.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
zkclient-javad
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 Jonny Heggheim changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 Jonny Heggheim changed: What|Removed |Added Status|NEW |ASSIGNED CC||jonnyheggh...@sigaint.org Assignee|nob...@fedoraproject.org|jonnyheggh...@sigaint.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
