[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 Didik Supriadi changed: What|Removed |Added Flags||needinfo?(p...@bothner.com)

needinfo canceled: [Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Zbigniew Jędrzejewski-Szmek 's needinfo: Bug 1424890: Review Request: domterm - terminal emulator based on web technologies https://bugzilla.redhat.com/show_bug.cgi?id=1424890

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Flags|

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #33 from Per Bothner --- "Source0 is wrong. It seems you didn't actually tag 1.0.2?" I've made a habit of updating the version number in domterm.spec when I update the version number in the git repository

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #32 from Per Bothner --- In terms of I reviewing other packages, I'm having trouble finding packages that haven't already gotten the kind of review I'd be qualified to give. There there are some packages in my

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #31 from Zbigniew Jędrzejewski-Szmek --- Hi, sorry for the delay. Please in the future use real links to the spec file and rpm. fedora-review than can download the srpm and spec automatically. In this case it

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #30 from Per Bothner --- I've released DomTerm 1.0 (adn announced it on LWN: https://lwn.net/Articles/750319/) See https://github.com/PerBothner/DomTerm/releases/tag/1.0 which includes rpms. Specfile:

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #29 from Per Bothner --- Updated to deal with the problems you noted, plus some others. The most important is that the Source0 URL is for a release tar-ball (as produced by 'make dist'), rather than a git

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #28 from Zbigniew Jędrzejewski-Szmek --- No idea. Probably best to leave it out for now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #27 from Per Bothner --- Thanks for the feedback! A question about the *.appdata.xml files. I didn't find any real documentation on the tag in either

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #26 from Zbigniew Jędrzejewski-Szmek --- BR: gcc or g++ is also necessary now, see https://fedoraproject.org/wiki/Changes/Remove_GCC_from_BuildRoot. -- You are receiving this mail because: You are on the CC

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #25 from Zbigniew Jędrzejewski-Szmek --- Wow, I have to say that it has come a long way. I tried using both the browser and qt versions, and they work very nicely. Packaging looks good. One thing seems to be

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #24 from Per Bothner --- Sorry it took a while - I needed to re-write focus handling which led to a re-write of "input line editing" http://domterm.org/Input-line-editing.html (kind of a builtin readline

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #23 from Zbigniew Jędrzejewski-Szmek --- Can you post the updated spec and srpm? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #22 from Per Bothner --- Yes, I'm still interested. Since the previous "push" I'm made major changes that effect its packaging, especially the qtdomterm sub-package (which now only handles the UI), and help/man

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #21 from Andrew Toskin --- It's been a while. Per Bothner, are you still interested in working on this package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #20 from Zbigniew Jędrzejewski-Szmek --- (In reply to Per Bothner from comment #19) > "The built domterm package contains the directory /usr/lib/.build-id/ -- > which looks to me like leftovers from the build.

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #19 from Per Bothner --- Updated (same locations): Spec URL: http://per.bothner.com/DomTerm/domterm.spec SRPM URL: http://per.bothner.com/DomTerm/domterm-0.74-1.fc25.src.rpm I'll clean up the Source0 commans

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #18 from Andrew Toskin --- (In reply to Per Bothner from comment #16) > sources file doesn't exist. Source files download skipped. This part you can ignore for the moment. This isn't documented very well, and I'm

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #17 from Per Bothner --- Concerning: "If you're configuring to build with java, shouldn't java be a Requires instead of a Recommends?" - see this comment in the spec file: Java is needed for the

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #16 from Per Bothner --- Concerning setting Source0, the problem is I can't get fedpkg to work if I set Source0 to the github download. I'm probably invoking fedpkg incorrectly - but I'm trying to follow the

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #15 from Andrew Toskin --- Your spec file still has several Source0 tags, all but one commented out. Again, the macro-ized URL we would normally expect for a project hosted on GitHub is this:

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #14 from Per Bothner --- Oops, that should have been 0.74. not 0.75. Hence: Spec URL: http://per.bothner.com/DomTerm/domterm.spec SRPM URL: http://per.bothner.com/DomTerm/domterm-0.74-1.fc25.src.rpm -- You

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #13 from Andrew Toskin --- I can see the spec, but trying to download the SRPM returns Error 404. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #12 from Per Bothner --- I've updated DomTerm to take into account your comments Spec URL: http://per.bothner.com/DomTerm/domterm.spec SRPM URL: http://per.bothner.com/DomTerm/domterm-0.75-1.fc25.src.rpm * It

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 Bug 1424890 depends on bug 1422477, which changed state. Bug 1422477 Summary: libwebsockets-2.2.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1422477 What|Removed |Added

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #11 from Zbigniew Jędrzejewski-Szmek --- Ooops. For some reason I assumed it's unicode. I tested with https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt, and that displays beautifully. -- You are

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #10 from Per Bothner --- Re comments #8 and #9 [Qt font problem]: The Emacs HELLO file is not Unicode. The 'Local Variables' section of the file says it is 'coding: iso-2022-7bit' . ISO 2022 is not terribly

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #9 from Zbigniew Jędrzejewski-Szmek --- Created attachment 1267224 --> https://bugzilla.redhat.com/attachment.cgi?id=1267224=edit qtdomterm menu -- You are receiving this mail because: You are on the CC list

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- Created attachment 1267223 --> https://bugzilla.redhat.com/attachment.cgi?id=1267223=edit qtdomterm screenshot I have a HiDPI screen: XWAYLAND0 connected 2560x1440+0+0

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 Michael Schwendt changed: What|Removed |Added Blocks||177841

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #6 from Andrew Toskin --- (In reply to Per Bothner from comment #5) > No, I don't have a sponsor. Okay. If you haven't already, you'd probably want to post on the "devel" mailing list asking for a sponsor.

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #5 from Per Bothner --- No, I don't have a sponsor. Thanks, I have a few additional changes I've been working on, some of relate to packaging: * It would be helpful to update the libwebsockets package (to

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #4 from Andrew Toskin --- @bothner Do you have a sponsor yet? I can't sponsor you, but DomTerm seems interesting, so I could certainly help with the basic review. -- You are receiving this mail because: You are

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 terrycloth changed: What|Removed |Added CC||and...@tosk.in ---

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #2 from Per Bothner --- Thanks for the comments! I made a number of fixes, available at: Spec URL: http://per.bothner.com/DomTerm/domterm.spec SRPM URL:

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #1 from Michael Schwendt --- > Note I had some problems with "domterm" vs "DomTerm". > For example the command 'fedpkg --release f25 mockbuild' didn't > work because it looks for DomTerm-0.71-1.fc25.src.rpm.