[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-05-30 10:08:58



--- Comment #8 from Fedora Update System  ---
virt-bootstrap-1.0.0-2.fc28 has been pushed to the Fedora 28 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KC4SV5QPSFO6E5BZZIJPKLGJPRAZO7VJ/

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
virt-bootstrap-1.0.0-2.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e35c1ec2b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/O4N3OHJ24ZMIBXMOQO6EBBJEIVEOYVOM/

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GUWEYQICEUWTXDURJ3QCFY36AH6YAXQ7/

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045



--- Comment #6 from Fedora Update System  ---
virt-bootstrap-1.0.0-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e35c1ec2b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HGA66AJ2MTZCL6C3KAW3HJX43DKGPMGG/

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/virt-bootstrap

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LCYYN4MTSPXYRINUVT7F544A25QRRKIA/

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045

Lubomir Rintel  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Lubomir Rintel  ---
This looks much better, thanks. There's one thing you need to fix before
importing the package -- avoid expanding macros in the changelog:

-- Drop "%defattr" tag as it's obsolete
-- Add "BuildRequires: /usr/bin/git" (due to %autosetup -S git)
+- Drop "%%defattr" tag as it's obsolete
+- Add "BuildRequires: /usr/bin/git" (due to %%autosetup -S git)

No need to block the review for this, the package is now APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/G7EOFAIUMETVTW3N74DNREK3Y66V2R4H/

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045



--- Comment #3 from Fabiano Fidêncio  ---
Spec URL: https://fidencio.fedorapeople.org/virt-bootstrap/virt-bootstrap.spec
SRPM URL:
https://fidencio.fedorapeople.org/virt-bootstrap/virt-bootstrap-1.0.0-2.fc28.src.rpm

Patch0001:
https://fidencio.fedorapeople.org/virt-bootstrap/0001-docker-source-Avoid-skopeo-copy-in-cache.patch
Patch0002:
https://fidencio.fedorapeople.org/virt-bootstrap/0002-docker-source-Get-list-of-layers-without-raw.patch
Patch0003:
https://fidencio.fedorapeople.org/virt-bootstrap/0003-docker-source-Support-blobs-without-.tar-ext.patch
Patch0004:
https://fidencio.fedorapeople.org/virt-bootstrap/0004-safe_untar-Check-for-permissions-to-set-attribs.patch

Description:
Provides a way to create the root file system to use for libvirt containers.

Fedora Account System Username: fidencio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MBLAFQLHWUY4XMTGWR24Y2JU4DELZSYX/

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045



--- Comment #2 from Lubomir Rintel  ---
(In reply to Lubomir Rintel from comment #1)
> * Package builds fine in mock -- BRs correct

Spoke too soon. Please add "BuildRequires: /usr/bin/git" for the %autosetup
with git to work.

> 1.) Buildroot tar is obsolete:

tag

Also there's one more thing to fix, rpmlint seems somewhat unhappy:

> virt-bootstrap.noarch: E: wrong-script-interpreter 
> /usr/lib/python3.6/site-packages/virtBootstrap/virt_bootstrap.py /usr/bin/env 
> python
> virt-bootstrap.noarch: E: non-executable-script 
> /usr/lib/python3.6/site-packages/virtBootstrap/virt_bootstrap.py 644 
> /usr/bin/env python

If a shebang is needed, then it should be /usr/bin/python3, not /usr/bin/env
python nor /usr/bin/python. Here it is not needed and should be just dropped --
the file is in /usr/lib and doesn't have an executable bit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045

Lubomir Rintel  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from Lubomir Rintel  ---
This is done rather well overall. Some details need need to be addressed before
this can be imported, see below.

* Package named correctly
* Packaging the most recent upstream release
* License tag is correct
* The license is good for Fedora
* The SPEC file is clean and legible
* Macros are used consistently
* Package builds fine in mock -- BRs correct
* Filelist sane
* Requires/provides look good
* Follows modern Python 3 packaging standards

0.) This is an architecture independent package

You should set "BuildArch: noarch". Then remove this:

> %global debug_package %{nil}

I guess you added that because the rpmbuild complained of empty debuginfo?

1.) Buildroot tar is obsolete:

> BuildRoot: %{_tmppath}/%{name}-%{version}-build

2.) In general, when adding patches, comment on their upstreaming status

> Patch0001: 0001-docker-source-Avoid-skopeo-copy-in-cache.patch
> Patch0002: 0002-docker-source-Get-list-of-layers-without-raw.patch
> Patch0003: 0003-docker-source-Support-blobs-without-.tar-ext.patch
> Patch0004: 0004-safe_untar-Check-for-permissions-to-set-attribs.patch

If they are upstream backports, just say so. If you're involved with upstream
development perhaps you can get new version released?

3.) Drop the %defattr tag

> %defattr(-,root,root)

It's not needed by any of the RPM versions that are relevant these days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045

Lubomir Rintel  changed:

   What|Removed |Added

 CC||lkund...@v3.sk
   Assignee|nob...@fedoraproject.org|lkund...@v3.sk



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1579045] Review Request: virt-bootstrap - System container rootfs creation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579045

Fabiano Fidêncio  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org