[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-06-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #54 from Fedora Update System --- FEDORA-EPEL-2020-ed997a6971 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because:

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-06-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|---

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-06-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #52 from

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-06-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #51 from

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #50 from markusN --- Ah, I see. I have requested there to add PDAL to the list, it was immediately done: https://src.fedoraproject.org/rpms/PDAL/c/0850914050c8e76ca5bd933d0bfe1a58a5d5dfb0?branch=master -- You are receiving

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #49 from Sandro Mani --- That's due to the boost 1.73 rebuild which started 2020-05-28, see [1]. [1] https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/XEHCL2HROZQXQXQUWZF26VVCPAYFEGR5/ -- You

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #48 from markusN --- Well, still some issues - from the new BZ#1843094: Your package (PDAL) Fails To Install in Fedora 33: can't install PDAL-libs: - nothing provides libboost_filesystem.so.1.69.0()(64bit) needed by

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #47 from

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #46 from

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #44 from Sandro Mani --- Two variants: a) If no third-party consumer of libpdal_plugin_* exists (which I would expect), then yes, drop the unversioned symblinks b) Otherwise, drop these two lines # We don't want to provide

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #45 from Sandro Mani --- Note that more than just -%{_libdir}/libpdal_plugin_kernel_fauxplugin.so -%{_libdir}/libpdal_plugin_reader_pgpointcloud.so -%{_libdir}/libpdal_plugin_writer_pgpointcloud.so you'll want to %exlcude or rm

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #43 from markusN --- Just to be sure, you mean to change like this? diff --git a/PDAL.spec b/PDAL.spec index d3a4d94..1a41e56 100644 --- a/PDAL.spec +++ b/PDAL.spec @@ -200,9 +200,6 @@ ctest -V %files devel

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #42 from Sandro Mani --- Oh - just drop the provides filtering in this case, I thought they were .so only, but indeed also the versioned symlinks exist. -- You are receiving this mail because: You are on the CC list for the

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #41 from markusN --- Unfortunately there is still an issue (BZ#1841616): Your package (PDAL) Fails To Install in Fedora 33: can't install PDAL-devel: - nothing provides libpdal_plugin_kernel_fauxplugin.so.10()(64bit) needed by

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #40 from

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #39 from

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #38 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/PDAL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #37 from markusN --- Thanks for all your guidance! https://pagure.io/releng/fedora-scm-requests/issue/25323 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Sandro Mani changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #36 from Sandro Mani

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #35 from markusN --- I have dropped those lines and uploaded the final (?) SPEC file again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 markusN changed: What|Removed |Added Attachment|0 |1 #1692850 is|

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Sandro Mani changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #33 from

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 markusN changed: What|Removed |Added Attachment|0 |1 #1692236 is|

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 markusN changed: What|Removed |Added Attachment|0 |1 #1691395 is|

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #30 from markusN --- Thanks for the updates, much appreciated! New RPMs: https://koji.fedoraproject.org/koji/taskinfo?taskID=45074748 rpmlint only shows a few warnings (see above, two have already been addressed upstream). --

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #29 from Sandro Mani --- > I went through the licensecheck.txt file and verified the unclear extractions > within the files. > Would the following change be ok (twice in the spec file)? > -%license LICENSE.txt > +%license

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #28 from markusN --- (In reply to Sandro Mani from comment #27) > Created attachment 1692463 [details] > licensecheck.txt > > Full review below. Thanks for the new review. > Issues: > > [!]: License field in the package spec

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #27 from Sandro Mani --- Created attachment 1692463 --> https://bugzilla.redhat.com/attachment.cgi?id=1692463=edit licensecheck.txt Full review below. Issues: [!]: License field in the package spec file matches the actual

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #26 from markusN --- (In reply to markusN from comment #5) > (In reply to Sandro Mani from comment #4) > > - PDAL-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpdal_base.so.11 > > exit@GLIBC_2.2.5 > > > > You should report

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 markusN changed: What|Removed |Added Blocks||1672170 Referenced Bugs:

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #25 from Sandro Mani --- Posting links for fedora review: Spec URL: https://smani.fedorapeople.org/review/PDAL.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/806/45000806/PDAL-2.1.0-4.fc33.src.rpm -- You are

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 markusN changed: What|Removed |Added Attachment|0 |1 #1691970 is|

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #23 from markusN --- As suggested, I have modified the test to ignore the test failures on problematic arches. neteler's scratch build of PDAL-2.1.0-4.fc31.src.rpm for f33 completed

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #22 from Sandro Mani --- As for the test, you can ignore the test failures on problematic arches, say %ifarch armv7hl aarch64 s390x ctest || true %else ctest %endif Generally it's not mandatory for tests to pass, but especially

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 markusN changed: What|Removed |Added Attachment|0 |1 #1691203 is|

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #20 from markusN --- Concerning the library versioning (answer by the PDAL maintainer): > The library versioning adopted by PDAL is pretty unusual, i.e. in > CMakeLists.txt This was a bug that is fixed in

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #19 from Sandro Mani --- > OK, but I don't get it running. How so? Are there other errors? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #18 from markusN --- (In reply to Sandro Mani from comment #17) > Is there any other test failing other than pgpointcloudtest? Yes, only this one. FWIW, in the openSuSe PDAL package they doesn't test at all and in Debian

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #17 from Sandro Mani --- Is there any other test failing other than pgpointcloudtest? It would be better to leave out the " || echo "Ignoring test failures"", as otherwise no-one will notice the test failures. Once you believe

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #16 from markusN --- Problem of `pgpointcloudtest` addressed, it now compile successfully: https://koji.fedoraproject.org/koji/taskinfo?taskID=44944553 -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #15 from markusN --- Created attachment 1691769 --> https://bugzilla.redhat.com/attachment.cgi?id=1691769=edit updated PDAL spec file Successfully compiling -- You are receiving this mail because: You are on the CC list for

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #14 from markusN --- Created attachment 1691596 --> https://bugzilla.redhat.com/attachment.cgi?id=1691596=edit updated PDAL spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #13 from markusN --- I have modified the BRs as follows: --- /home/mneteler/rpmbuild/SPECS/PDAL.spec 2020-05-24 19:16:26.794094506 +0200 +++ PDAL.spec 2020-05-24 18:50:52.810157029 +0200 @@ -32,6 +32,7 @@ BuildRequires:

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #12 from Sandro Mani --- Adding BR: /usr/bin/gdalinfo will solve the second one, the first one might be solved by adding BR: postgresql-server. -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #11 from markusN --- Here the link to the scratch built with the respective root.log: https://koji.fedoraproject.org/koji/taskinfo?taskID=44897107 -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #10 from markusN --- Concerning the soname issue, I have asked in the PDAL ticket about the timeline of the next release including the fix. Next I have redone a scratch built, which fails in 2 tests: 98% tests passed, 2 tests

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #9 from Sandro Mani --- > This had been fixed upstream and will be part of the next PDAL release: > https://github.com/PDAL/PDAL/pull/3042 Wonder if it makes sense to package the latest git snapshot of the 2.1-maintenance branch

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #7 from Sandro Mani --- Created attachment 1691395 --> https://bugzilla.redhat.com/attachment.cgi?id=1691395=edit PDAL_unbundle.patch -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #8 from Sandro Mani --- Yes, sure, had forgotten to do so -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #6 from Sandro Mani --- Created attachment 1691394 --> https://bugzilla.redhat.com/attachment.cgi?id=1691394=edit PDAL_tests.patch -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #5 from markusN --- (In reply to Sandro Mani from comment #4) > Created attachment 1691203 [details] > PDAL.spec > > Attached a spec with some fixes: > > - Correctly unbundle eigen3 and gtest > - Correctly build and run tests

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #4 from Sandro Mani --- Created attachment 1691203 --> https://bugzilla.redhat.com/attachment.cgi?id=1691203=edit PDAL.spec Attached a spec with some fixes: - Correctly unbundle eigen3 and gtest - Correctly build and run tests

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #3 from markusN --- Thanks so much for your detailed review. I have addressed most of it but struggle with a few points (since I am not much of an expert here): > => %{_libdir}/libpdal_plugin* look like pdal plugins, which are

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 Sandro Mani changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library

2020-05-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 markusN changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1