Re: [PATCH 1/2] REST: Don't error if a versioned field we would remove is absent

2021-10-28 Thread Daniel Axtens
Konstantin Ryabitsev writes: > On Wed, Oct 27, 2021 at 05:00:34PM +0100, Stephen Finucane wrote: >> v2.2.6 is available now. Let me know if there are any issues. > > Thanks! > >> Somewhat related: are there any large blockers preventing you moving to >> v3.0.x? >> Is it the major version bump or

Re: [PATCH 1/2] REST: Don't error if a versioned field we would remove is absent

2021-10-28 Thread Konstantin Ryabitsev
On Wed, Oct 27, 2021 at 05:00:34PM +0100, Stephen Finucane wrote: > v2.2.6 is available now. Let me know if there are any issues. Thanks! > Somewhat related: are there any large blockers preventing you moving to > v3.0.x? > Is it the major version bump or removal of Python 2.7 support that's >

Re: [PATCH 1/2] REST: Don't error if a versioned field we would remove is absent

2021-10-27 Thread Stephen Finucane
On Fri, 2021-10-22 at 08:28 -0400, Konstantin Ryabitsev wrote: > On Fri, 20 Aug 2021 at 17:59, Stephen Finucane wrote: > > > We remove fields that shouldn't be seen on old versions of the API. > > > This was done with `pop(field name)`, which will throw an exception > > > if the named field is abs

Re: [PATCH 1/2] REST: Don't error if a versioned field we would remove is absent

2021-10-22 Thread Konstantin Ryabitsev
On Fri, 20 Aug 2021 at 17:59, Stephen Finucane wrote: > > We remove fields that shouldn't be seen on old versions of the API. > > This was done with `pop(field name)`, which will throw an exception > > if the named field is absent from the data. However, sometimes if > > a patch request is via an

Re: [PATCH 1/2] REST: Don't error if a versioned field we would remove is absent

2021-08-20 Thread Stephen Finucane
On Sat, 2021-08-21 at 00:57 +1000, Daniel Axtens wrote: > We remove fields that shouldn't be seen on old versions of the API. > This was done with `pop(field name)`, which will throw an exception > if the named field is absent from the data. However, sometimes if > a patch request is via an old API

Re: [PATCH 1/2] REST: Don't error if a versioned field we would remove is absent

2021-08-20 Thread Konstantin Ryabitsev
On Sat, Aug 21, 2021 at 12:57:58AM +1000, Daniel Axtens wrote: > This is odd, but not harmful and we definitely shouldn't 500. I can confirm that it fixes the 500 error and restores previous functionality. Thanks very much! Tested-by: Konstantin Ryabitsev -K

[PATCH 1/2] REST: Don't error if a versioned field we would remove is absent

2021-08-20 Thread Daniel Axtens
We remove fields that shouldn't be seen on old versions of the API. This was done with `pop(field name)`, which will throw an exception if the named field is absent from the data. However, sometimes if a patch request is via an old API version, we hit this line without ever having the field present