[PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-05 Thread katja
On Wed, Oct 5, 2011 at 6:11 AM, Hans-Christoph Steiner h...@at.or.at wrote: So you are saying that the stuff in pd-double is not building using 64-bit floats? I downloaded Pd-0.43.1-double-20111003-macosx106-x86_64.dmg from the auto-build and this one was single precision. Don't know about the

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-05 Thread katja
On Tue, Oct 4, 2011 at 11:38 AM, IOhannes m zmoelnig zmoel...@iem.at wrote: the proper way is to use CPPFLAGS=-DPD_FLOAT_PRECISION=64, But now you undo the CPPFLAGS as defined in the makefile. I didn't know how to add to the CFLAGS from the command line, but found a solution here:

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-05 Thread Hans-Christoph Steiner
On Oct 5, 2011, at 6:40 AM, katja wrote: On Tue, Oct 4, 2011 at 11:38 AM, IOhannes m zmoelnig zmoel...@iem.at wrote: the proper way is to use CPPFLAGS=-DPD_FLOAT_PRECISION=64, But now you undo the CPPFLAGS as defined in the makefile. I didn't know how to add to the CFLAGS from the

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-05 Thread Hans-Christoph Steiner
On Oct 5, 2011, at 5:08 AM, katja wrote: On Wed, Oct 5, 2011 at 6:11 AM, Hans-Christoph Steiner h...@at.or.at wrote: So you are saying that the stuff in pd-double is not building using 64-bit floats? I downloaded Pd-0.43.1-double-20111003-macosx106-x86_64.dmg from the auto-build and

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-05 Thread IOhannes m zmölnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2011 12:40 PM, katja wrote: On Tue, Oct 4, 2011 at 11:38 AM, IOhannes m zmoelnig zmoel...@iem.at wrote: the proper way is to use CPPFLAGS=-DPD_FLOAT_PRECISION=64, But now you undo the CPPFLAGS as defined in the makefile. I didn't know

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-05 Thread Hans-Christoph Steiner
On Wed, 2011-10-05 at 21:37 +0200, IOhannes m zmölnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2011 12:40 PM, katja wrote: On Tue, Oct 4, 2011 at 11:38 AM, IOhannes m zmoelnig zmoel...@iem.at wrote: the proper way is to use CPPFLAGS=-DPD_FLOAT_PRECISION=64,

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-05 Thread katja
2011/10/5 Hans-Christoph Steiner h...@at.or.at: I removed the old build system from pd-double.git and pushed the change. Hopefully that'll reduce confusion. Yeah I was using the old build system all the time because it was so easy to produce local builds by doing make without install. Never

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread katja
On Tue, Oct 4, 2011 at 1:33 AM, Hans-Christoph Steiner h...@at.or.at wrote: And we have our first Pd-double build! http://autobuild.puredata.info/auto-build/2011-10-03/Pd-0.43.1-double-20111003 macosx106-x86_64.dmg Cool Hans! Can't wait to check it out (though I'll have to wait till I get

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread katja
On Tue, Oct 4, 2011 at 9:06 AM, katja katjavet...@gmail.com wrote: By the way for my coreduo 1.83 GHZ I could compile for Debian with SSE by setting -march=prescott, this was the last 32bit adress space SSE enabled CPU. Sorry, correction again: of course coreduo is also 32bit address space

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread Hans-Christoph Steiner
On Oct 4, 2011, at 5:38 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-10-04 09:06, katja wrote: Yesterday I forgot to mention why it should definitely not be built with -O0 (unless for debug purposes): PD_BIGORSMALL is defined an ah yes, this was

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread András Murányi
On Mon, Oct 3, 2011 at 18:26, Hans-Christoph Steiner h...@at.or.at wrote: On Oct 3, 2011, at 12:04 PM, katja wrote: On Mon, Oct 3, 2011 at 4:35 PM, Hans-Christoph Steiner h...@at.or.at wrote: Do you have access to an ARM machine? If not, I could probably get one online with ssh access,

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread Hans-Christoph Steiner
On Oct 4, 2011, at 10:19 AM, András Murányi wrote: On Mon, Oct 3, 2011 at 18:26, Hans-Christoph Steiner h...@at.or.at wrote: On Oct 3, 2011, at 12:04 PM, katja wrote: On Mon, Oct 3, 2011 at 4:35 PM, Hans-Christoph Steiner h...@at.or.at wrote: Do you have access to an ARM machine?

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread András Murányi
2011/10/4 Hans-Christoph Steiner h...@at.or.at On Oct 4, 2011, at 10:19 AM, András Murányi wrote: On Mon, Oct 3, 2011 at 18:26, Hans-Christoph Steiner h...@at.or.atwrote: On Oct 3, 2011, at 12:04 PM, katja wrote: On Mon, Oct 3, 2011 at 4:35 PM, Hans-Christoph Steiner h...@at.or.at

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread Hans-Christoph Steiner
On Oct 4, 2011, at 10:54 AM, András Murányi wrote: 2011/10/4 Hans-Christoph Steiner h...@at.or.at On Oct 4, 2011, at 10:19 AM, András Murányi wrote: On Mon, Oct 3, 2011 at 18:26, Hans-Christoph Steiner h...@at.or.at wrote: On Oct 3, 2011, at 12:04 PM, katja wrote: On Mon, Oct 3,

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread katja
Hello, Happy to see so many test results from IOhannes. The 'perfotest' patches were initially created for function profiling, to check if there are particularly time consuming instructions. To mention a funny example: I was happy to see that fabs() was translated to a single instruction ANDPS /

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread katja
Forgot to mention this: at start up there's a logpost (level 3) 'PD_FLOATPRECISION=32 bits' for single and 'PD_FLOATPRECISION=64 bits' for double build. Ah, so tomorrow a single and double precision build will automatically be made? Cool. It's confusing. At the moment there is vanilla Pd

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-04 Thread Hans-Christoph Steiner
On Oct 4, 2011, at 7:06 PM, katja wrote: Forgot to mention this: at start up there's a logpost (level 3) 'PD_FLOATPRECISION=32 bits' for single and 'PD_FLOATPRECISION=64 bits' for double build. Ah, so tomorrow a single and double precision build will automatically be made? Cool. It's

[PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread katja
On Sun, Oct 2, 2011 at 11:36 PM, Hans-Christoph Steiner h...@at.or.at wrote: I think it makes sense to work off of pure-data.git rather than pd-extended.git since this is a patch targetted at getting into Miller's repo. Right. Even then, we could add some external libs to work on, starting

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread Hans-Christoph Steiner
On Oct 3, 2011, at 8:28 AM, katja wrote: On Sun, Oct 2, 2011 at 11:36 PM, Hans-Christoph Steiner h...@at.or.at wrote: I think it makes sense to work off of pure-data.git rather than pd-extended.git since this is a patch targetted at getting into Miller's repo. Right. Even then, we

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-10-03 16:31, Hans-Christoph Steiner wrote: These all sound like good ideas to try. My only concern is that we might let the deployment issues distract from the issues at hand about getting it actually working first. i'm definitely with

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread katja
Thanks IOhannes for all your comments and suggestions. I just realized that there are several ways in which identical symbols for different function definitions could cause a problem and I did not distinguish them. 1. Pd looks for a setup symbol when trying to load an external binary. 2. A

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-10-03 17:44, katja wrote: Thanks IOhannes for all your comments and suggestions. I just realized that there are several ways in which identical symbols for different function definitions could cause a problem and I did not distinguish

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread katja
On Mon, Oct 3, 2011 at 4:35 PM, Hans-Christoph Steiner h...@at.or.at wrote: Do you have access to an ARM machine?  If not, I could probably get one online with ssh access, if that's useful. I've mailed Joe White with the question if he can patch the code for libpd and check performance on

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-10-03 18:00, Charles Henry wrote: Would you prefer to set the types at configure time through a file--or for example by adding a -DDOUBLE compiler flag? The affected locations of code defining the types could just use #ifdef DOUBLE no,

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread Hans-Christoph Steiner
I think for now, we'll just have Pd-extended-like monolithic builds which will be easy to use on their own and will include enough libraries to be useful. They can be run standalone, and if need be, we can disable things like ~/pd-externals quite easily. These kinds of deployment issues

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread Hans-Christoph Steiner
On Oct 3, 2011, at 12:00 PM, Charles Henry wrote: On Mon, Oct 3, 2011 at 10:19 AM, IOhannes m zmoelnig zmoel...@iem.at wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-10-03 16:31, Hans-Christoph Steiner wrote: These all sound like good ideas to try. My only concern is that

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-10-03 18:04, katja wrote: On Mon, Oct 3, 2011 at 4:35 PM, Hans-Christoph Steiner h...@at.or.at wrote: Do you have access to an ARM machine? If not, I could probably get one online with ssh access, if that's useful. I've mailed Joe

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread Hans-Christoph Steiner
On Oct 3, 2011, at 12:04 PM, katja wrote: On Mon, Oct 3, 2011 at 4:35 PM, Hans-Christoph Steiner h...@at.or.at wrote: Do you have access to an ARM machine? If not, I could probably get one online with ssh access, if that's useful. I've mailed Joe White with the question if he can

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread Hans-Christoph Steiner
More on actually trying the patch. I tried to apply it to the HEAD of pure-data.git, and one section failed: pd@debian-lenny-i386 src $ patch -p1 ../../pd_doubleready/ make_Pd_core_0430_double_ready.patch patching file d_array.c patching file d_math.c patching file d_misc.c Hunk #2

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-10-03 18:32, Hans-Christoph Steiner wrote: More on actually trying the patch. I tried to apply it to the HEAD of pure-data.git, and one section failed: pd@debian-lenny-i386 src $ patch -p1

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread katja
On Mon, Oct 3, 2011 at 6:21 PM, IOhannes m zmoelnig zmoel...@iem.at wrote: apropos performance: on my i5 650 @ 3.2GHz, running debian and trying to osc-delay-perfotest.pd (with only 400 osc-delay abstractions, as 500 would max out the CPU in new double mode) i get: original  : 28% debian    

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-03 Thread katja
On Mon, Oct 3, 2011 at 7:08 PM, katja katjavet...@gmail.com wrote: On Mon, Oct 3, 2011 at 6:21 PM, IOhannes m zmoelnig zmoel...@iem.at wrote: apropos performance: on my i5 650 @ 3.2GHz, running debian and trying to osc-delay-perfotest.pd (with only 400 osc-delay abstractions, as 500 would

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-02 Thread katja
Hi Hans, Thanks for your detailed comments. I will go through the code once again, you're right it's not as clean as could be. Regarding your suggestion to set up a repo, it seems to be the most logical thing to do. This could be considered a temporary branch for the double precision thing, to

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-02 Thread Hans-Christoph Steiner
Sounds great. I'm happy to help setup a git repo if you want me too. github and gitorious are pretty straightforward to get the initial repo, then it would be a matter of pushing the pure-data.git to that repo, and starting work from there. I think it makes sense to work off of

Re: [PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-10-01 Thread Hans-Christoph Steiner
Hey Katja, This is great, just starting to dig into it. Its a great write-up too. I'd like to put together some Pd-extended nightly builds based on this, and start working out a work flow for all the fixes that we will inevitably need to do. To start with, I think you should request SVN commit

[PD-dev] double precision Pd: .patch files, tests and benchmarks

2011-09-30 Thread katja
Hello, Finally my double-precision-Pd efforts resulted in code decent enough to be useful in practice. It's all documented on: http://www.katjaas.nl/doubleprecision/doubleprecision.html From there you can download a .zip with two .patch files to make vanilla Pd 0.43-0 double precision ready. In