Jenkins build is back to normal : pgadmin4-master-python26 #792

2018-06-15 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4][Patch] : Fix PG utilities with Python 2.6

2018-06-15 Thread Dave Page
Thanks, applied. On Fri, Jun 15, 2018 at 2:55 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch for PG utilities - PY 2.6. > > Thanks, > Khushboo > > On Fri, Jun 15, 2018 at 5:08 PM, Dave Page wrote: > >> Thanks, applied. >> >> On Fri, Jun

pgAdmin 4 commit: Further Python 2.6 fixes.

2018-06-15 Thread Dave Page
Further Python 2.6 fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ba8829b64ff6c75aebd823743e8833ab0b531a4f Author: Khushboo Vashi Modified Files -- web/pgadmin/misc/bgprocess/processes.py| 14 ++

Re: [pgAdmin4][Patch] : Fix PG utilities with Python 2.6

2018-06-15 Thread Khushboo Vashi
Hi Dave, Please find the attached patch for PG utilities - PY 2.6. Thanks, Khushboo On Fri, Jun 15, 2018 at 5:08 PM, Dave Page wrote: > Thanks, applied. > > On Fri, Jun 15, 2018 at 12:27 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patc

Build failed in Jenkins: pgadmin4-master-python26 #791

2018-06-15 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix external utilities to run with Python 2.6. -- [...truncated 887.35 KB...] Create partitions o

Re: [pgAdmin4][Patch] : Fix PG utilities with Python 2.6

2018-06-15 Thread Dave Page
Thanks, applied. On Fri, Jun 15, 2018 at 12:27 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch which fixes the PG utilities with python > 2.6. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake Enter

pgAdmin 4 commit: Fix external utilities to run with Python 2.6.

2018-06-15 Thread Dave Page
Fix external utilities to run with Python 2.6. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ab54a6d39a5b53047ef4ed8b9c20ce37a1acd0ce Author: Khushboo Vashi Modified Files -- web/pgadmin/misc/bgprocess/processes.py | 2 +- 1 file

[pgAdmin4][Patch] : Fix PG utilities with Python 2.6

2018-06-15 Thread Khushboo Vashi
Hi, Please find the attached patch which fixes the PG utilities with python 2.6. Thanks, Khushboo pg_utility_py26_fix.patch Description: Binary data

Build failed in Jenkins: pgadmin4-master-python26 #790

2018-06-15 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add Python API tests for execution of external utilities such as -- [...truncated 834.16 KB...] C

pgAdmin 4 commit: Add Python API tests for execution of external utilit

2018-06-15 Thread Dave Page
Add Python API tests for execution of external utilities such as pg_dump. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1902cd63984c42385a19e8c224226fc3c3023c6 Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/backup/_

Re: [pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL

2018-06-15 Thread Dave Page
Thanks, applied. On Fri, Jun 15, 2018 at 7:51 AM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch for RM #3356 pgAdmin 4 does not include schema name > in generated package SQL. Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mo

pgAdmin 4 commit: Include the schema name on RE-SQL for packages. Fixes

2018-06-15 Thread Dave Page
Include the schema name on RE-SQL for packages. Fixes #3356 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=766b389001431bb6e95b53fbb9fd5d198a560fe6 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_1.rst

Re: pgadmin_page functions updated

2018-06-15 Thread Shubham Agarwal
Hi Khushboo, Yes i agree, currently we are not changing the functions that are already written but will use css selectors in all the upcoming new test cases. Thanks and regards, Shubham Agarwal On Fri, Jun 15, 2018 at 11:02 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Shubh

Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

2018-06-15 Thread Dave Page
Thanks, applied. On Thu, Jun 14, 2018 at 10:34 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi > > On Thu, Jun 14, 2018 at 2:48 PM, Dave Page wrote: > >> >> >> On Thu, Jun 14, 2018 at 10:06 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun 14, 2

pgAdmin 4 commit: Add an option to auto-complete keywords in upper case

2018-06-15 Thread Dave Page
Add an option to auto-complete keywords in upper case. Fixes #2686 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b48145f01f7c431a56912fac27e33384ab21bdda Author: Akshay Joshi Modified Files -- .../images/preferences_sql_auto_com

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-15 Thread Aditya Toshniwal
Hi Dave, On Fri, Jun 15, 2018 at 2:08 PM, Dave Page wrote: > Hi > > On Thu, Jun 14, 2018 at 7:05 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> I am sorry I missed the attachment. :( >> PFA. >> > > It looks like the encoding names are getting munged somewhere. I see > you've accounted for t

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

2018-06-15 Thread Dave Page
Hi On Thu, Jun 14, 2018 at 7:05 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > I am sorry I missed the attachment. :( > PFA. > It looks like the encoding names are getting munged somewhere. I see you've accounted for that to some degree in connection.py (you have both SQL_ASC

Re: [pgadmin4][Patch]: Remove extra space from create script for Procedures.

2018-06-15 Thread Dave Page
Thanks, applied. On Fri, Jun 15, 2018 at 7:53 AM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to remove extra space from create script for > Procedures. Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-824

pgAdmin 4 commit: Remove an extra space in Procedure templates.

2018-06-15 Thread Dave Page
Remove an extra space in Procedure templates. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df7b4d55c60cb8408077798e134569b762602af3 Author: Akshay Joshi Modified Files -- .../schemas/functions/templates/procedure/pg/sql/default

Re: Fixed issue on index page of the pgAdmin4 documentation

2018-06-15 Thread Dave Page
Thanks, applied. On Thu, Jun 14, 2018 at 11:49 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > I have observed that index page of pgAdmin4 documentation showing only one > entry (Refer attached screenshot). > > Attached is the patch to fix that. Please review it. > > --

pgAdmin 4 commit: Fix documentation indexing.

2018-06-15 Thread Dave Page
Fix documentation indexing. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a6b6f61f76d5992fc057c3d3b99df8d418f175c Author: Akshay Joshi Modified Files -- docs/en_US/add_restore_point_dialog.rst| 6 +++--- docs/en_US/backup_an

Re: pgadmin_page functions updated

2018-06-15 Thread Dave Page
On Fri, Jun 15, 2018 at 6:32 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Shubham, > > On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> >> I have modified following two functions in pgadmin_page.py :- >> >> 1. click