Re: Patch to remove Python 2.7 support in the macOS Appbundle

Thanks, applied. On Mon, May 4, 2020 at 10:59 AM Akshay Joshi wrote: > Hi Dave > > Patch looks good to me except the below line gets commented by mistake (if > i am not wrong) > > # ./complete-bundle.sh "${BUILDROOT}/${APP_BUNDLE_NAME}" || { echo > complete-bundle.sh failed; exit 1; } > > > On

pgAdmin 4 commit: Refactor pgAdmin4.py so it can be imported and is a l

Refactor pgAdmin4.py so it can be imported and is a lot more readable. Fixes #5455 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=059f1e38cc94b3c8e2659a8751afbd220393b0ef Author: Aditya Toshniwal Modified Files -- docs/en_US/rel

pgAdmin 4 commit: Fixed post-login redirect location when running in se

Fixed post-login redirect location when running in server mode under a non-default root. Fixes #5473 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=370094274c8cfe98c4744e99b00236263a4c4db5 Author: Aditya Toshniwal Modified Files ---

pgAdmin 4 commit: Remove support for Python 2. Fixes #5443

Remove support for Python 2. Fixes #5443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=04d6d4e2ccc129baa698471ce0680ccabe2282be Modified Files -- docs/en_US/release_notes_4_22.rst | 1 + web/pgadmin/utils/driver

pgAdmin 4 commit: Remove support for building the macOS appbundle with

Remove support for building the macOS appbundle with Python 2.7. Refs #5443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf31d0187b6afd7931328b494a04c8b6ece644e0 Modified Files -- pkg/mac/build.sh | 52 --

Re: Patch to remove Python 2.7 support in the macOS Appbundle

Hi Dave Patch looks good to me except the below line gets commented by mistake (if i am not wrong) # ./complete-bundle.sh "${BUILDROOT}/${APP_BUNDLE_NAME}" || { echo complete-bundle.sh failed; exit 1; } On Mon, May 4, 2020 at 3:02 PM Dave Page wrote: > Here's a rebased version. > > On Mon, Ma

pgAdmin 4 commit: Raise an exception under Python < 3.4 for WSGI mode.

Raise an exception under Python < 3.4 for WSGI mode. refs #5443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1963401d6774631ac4880e891b6cd9a1d4e0e85 Modified Files -- web/pgAdmin4.wsgi | 4 1 file changed, 4 insertions(+)

Re: Patch to remove Python 2.7 support in the macOS Appbundle

Here's a rebased version. On Mon, May 4, 2020 at 7:33 AM Akshay Joshi wrote: > Hi Dave > > On Fri, May 1, 2020 at 5:21 PM Dave Page wrote: > >> Akshay, are you happy with this patch? >> > >The patch is not applied to the latest code. > >> >> On Mon, Apr 27, 2020 at 3:30 PM Dave Page wrote:

Re: Cleanup runtime qmake code

Hi On Mon, May 4, 2020 at 10:03 AM Akshay Joshi wrote: > Hi Dave > > Patch looks good to me except one small change in the README file that is > PGADMIN_PYTHON_PATH is mentioned but it should be PGADMIN_PYTHON_DIR > I kept mixing those up :-( I've committed the patch, and made a couple of chan

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

Hi Yogesh The patch is not applied to the master branch. Can you please rebase and send the patch again. On Fri, May 1, 2020 at 12:28 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find updated patch modified according to review comments - > Patch implements below t

pgAdmin 4 commit: Cleanup Python detection in the runtime project file.

Cleanup Python detection in the runtime project file. Fixes #5444 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94bd1f1680db36422443d18ddcfb7a84cc5dbee3 Modified Files -- Make.bat | 2 +- README

Re: Cleanup runtime qmake code

Hi Dave Patch looks good to me except one small change in the README file that is PGADMIN_PYTHON_PATH is mentioned but it should be PGADMIN_PYTHON_DIR On Fri, May 1, 2020 at 8:29 PM Dave Page wrote: > The attached patch tidies up the qmake code for configuring the runtime > build so that it's c

pgAdmin 4 commit: Correct ipv4 "all interfaces" address in the containe

Correct ipv4 "all interfaces" address in the container docs, per Frank Limpert. Fixes #5466 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=908e15611336e78ff6008cd7d0dbabcf29716ace Modified Files -- docs/en_US/container_deployment

Re: [pgAdmin][5469] SSL mode dropdown hover in create server dialog is not consistent with other select2

Thanks, patch applied. On Mon, May 4, 2020 at 11:01 AM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached minor patch to fix the issue with select2 hover > consistency for SSL mode field(SSL tab) in create server dialog. > > Please review. > > Rega

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Thanks, patch applied. On Mon, May 4, 2020 at 12:47 PM Satish V wrote: > Hi Khushboo, > > As we discussed, the database disconnection error message is ignored as it > is getting displayed as expected. Variable name , info_already_connected, > is changed to already_connected. Run all the test cas

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

Thanks, patch applied. On Wed, Apr 29, 2020 at 5:26 PM Yogesh Jain wrote: > Hi all, > > Here is an updated patch as per the review comments mentioned above. > > Please review the updated patch. > PFA. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software Indi

Re: [pgAdmin4] RESQL tests for Column & Type nodes

Thanks, patch applied. On Thu, Apr 30, 2020 at 11:11 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Murtuza, > > Patch looks good to me. > > Thanks! > > On Wed, Apr 29, 2020 at 2:38 PM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> I will review and test it. >>

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

Thanks, patch applied. On Wed, Apr 29, 2020 at 1:29 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Navnath, > > On Wed, Apr 29, 2020 at 12:16 PM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> Patch looks good to me except there are no API tes

pgAdmin 4 commit: Fixed an issue where select2 hover is inconsistent fo

Fixed an issue where select2 hover is inconsistent for the SSL field in create server dialog. Fixes #5469 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fe7813f9fc43bb3e8ff1ccf9f272c8861de0026 Author: Ganesh Jaybhay Modified Files

pgAdmin 4 commit: Gracefully informed the user that the database is alr

Gracefully informed the user that the database is already connected when they click on 'Connect Database...'. Fixes #3694 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d61b8eb1b39f2256a196827d5152f6ac520bb13d Author: Satish V Modified File

pgAdmin 4 commit: Add Reverse Engineered and Modified SQL tests for Col

Add Reverse Engineered and Modified SQL tests for Column and Type. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0fc2afb829bb59f7aa1a7dd33ed0253d6693a0dc Author: Murtuza Zabuawala Modified Files -- .../columns/tests/10_plus/alte

pgAdmin 4 commit: Ensure that file browse home button should point to /

Ensure that file browse home button should point to /Users/akshayjoshi rather than /. Fixes #4279 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc2e3ece7ae412254408a45104a2f0fbeef55647 Author: Yogesh Jain Modified Files -- docs

pgAdmin 4 commit: Ensure that the dependencies tab shows correct inform

Ensure that the dependencies tab shows correct information for Synonyms. Fixes #5422 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5656f756e682cb766acc33346e601e130897a800 Author: Khushboo Vashi Modified Files -- docs/en_US/rel

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi Khushboo, As we discussed, the database disconnection error message is ignored as it is getting displayed as expected. Variable name , info_already_connected, is changed to already_connected. Run all the test cases except the feature test. Number of test case failures before and after the patch