Re: pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t

2019-07-07 Thread Khushboo Vashi
ter > > Details > --- > > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=954c0d31019a6cd19e15ee024f032f92c6654628 > Author: Khushboo Vashi > > Modified Files > -- > web/regression/re_sql/tests/test_resql.py | 30 >

Re: Feature request: Redshift Support

2019-06-30 Thread Khushboo Vashi
Hi Thomas, On Fri, Jun 28, 2019 at 11:07 PM wrote: > Hi > > I'd like to take a moment to say that I am a huge fan of this software. > > I would like to suggest a feature: > As a Postgres user I would like to use PGADMIN4 to connect to Amazon > Redshift. > I chose Redshift because it is pretty mu

Re: Getting Involved

2019-06-26 Thread Khushboo Vashi
On Thu, Jun 27, 2019 at 1:00 AM Alex Kim wrote: > Hi Khushboo, > > Thank you very much! > > You are welcome. Please make sure to change the status of the task to IN PROGRESS on which you will start working. > On Wed, Jun 26, 2019 at 2:11 AM Khushboo Vashi < > khushbo

Re: Getting Involved

2019-06-26 Thread Khushboo Vashi
Hi Alex, On Wed, Jun 26, 2019 at 1:29 PM Alex Kim wrote: > Hello, > > I am currently a college student studying computer science who is > interested in getting involved with the pgadmin community. Is there any > particular functionality or anything I can do to get started and contribute? > > Ple

[pgAdmin4][Patch] - RM 4380 - Table properties dialog - can not edit columns and partitions at the same time

2019-06-20 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #4380 - Table properties dialog - can not edit columns and partitions at the same time. Thanks, Khushboo RM_4380.patch Description: Binary data

Re: Help on pgAgent

2019-06-04 Thread Khushboo Vashi
he > SQL is correct so I don't what is failing > > Please enable logging (Ref: https://www.pgadmin.org/faq/#8) and share the log file after running the job with Run now. > El lun., 3 de jun. de 2019 11:59 p. m., Khushboo Vashi < > khushboo.va...@enterprisedb.com> escribió: &

Re: Help on pgAgent

2019-06-03 Thread Khushboo Vashi
On Tue, Jun 4, 2019 at 1:46 AM John G198 wrote: > Hi im trying to use pgAgent on pgAdmin4 using Windows 10 and i cant see > why but it doesnt work, it doesnt run the jobs created and i just want to > know if it has something to do with my postgreSQL version 11.2 maybe > pgAgent isnt compatible wi

Re: Enhancement request

2019-05-26 Thread Khushboo Vashi
On Sun, May 26, 2019 at 9:12 PM Akshaj Dave wrote: > Hi Team, > > PGAdmin has been wonderful to use and the latest changes with PGAdmin 4 > ver 4.6 are just delightful! > > Would it be possible to show the scratch pad on the SQL tab as well? > Currently it is attached to the connected Query tool

[pgAdmin4][Patch] - RM 3327 - Inconsistent behavior of partition table for the partition type

2019-04-23 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 3327 - Inconsistent behavior of partition table for the partition type. Thanks, Khushboo RM_3327.patch Description: Binary data

[pgAdmin4][Patch] - RM 4087 - Default sequence privileges does not show update grant

2019-04-21 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #4087 - Default sequence privileges does not show update grant. Thanks, Khushboo RM_4087.patch Description: Binary data

[pgAdmin4][Patch] - RM 4160 - (Re-)Edit column properties blocked to "Increment value cannot be empty" error.

2019-04-18 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #4160 - (Re-)Edit column properties blocked to "Increment value cannot be empty" error. Thanks, Khushboo RM_4160.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-17 Thread Khushboo Vashi
ks, Khushboo > On Tue, Apr 16, 2019 at 11:34 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch with some modification discussed at >> Redmine for the RM #2392. >> >> 1. On deletion, strike

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-15 Thread Khushboo Vashi
Delete some rows and >then click on Save button, data is saved in the database but grid is >showing same serial id for two newly created rows. After re-run the query >it shows the correct value. > > Fixed > Can you please fix the above issues. > > On Mon, Apr 8,

Re: [pgAdmin4][Patch]: Psycopg2 v2.8 fixes

2019-04-08 Thread Khushboo Vashi
would be the last fix. :) NOTE: pgAdmin will work with psycopg2* v2.8.1* but not with the *v2.8.* Thanks, Khushboo On Mon, Apr 8, 2019 at 4:28 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. I have disabled the Conn

Re: [pgAdmin4][Patch]: Psycopg2 v2.8 fixes

2019-04-08 Thread Khushboo Vashi
Hi, Please find the attached updated patch. I have disabled the Connection status, so before I didn't receive this issue. Thanks, Khushboo On Mon, Apr 8, 2019 at 11:36 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached p

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-08 Thread Khushboo Vashi
te button is still enabled and save button is disabled even >though newly created row is still there. Apart from that code looks good to >me. Please fix it. > > > Fixed. > On Thu, Apr 4, 2019 at 5:27 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: >

Re: Async queries pretending to be synchronous

2019-04-08 Thread Khushboo Vashi
On Tue, Mar 5, 2019 at 10:13 PM Dave Page wrote: > > > On Tue, Mar 5, 2019 at 6:36 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Mar 4, 2019 at 4:05 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> w

[pgAdmin4][Patch]: Psycopg2 v2.8 fixes

2019-04-07 Thread Khushboo Vashi
Hi, Please find the attached patch to make pgAdmin compatible with psycopg2 v 2.8. I have also made sure, pgAdmin will work with the older version of psycopg2. Thanks, Khushboo psycopg2_2.8_fixes.patch Description: Binary data

[pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-04 Thread Khushboo Vashi
Hi, Please find the attached patch to fix: 1. #3605 - Edit Data: Deleting N number of rows makes first N number of rows disable 2. #2392 - Datagrid: If we delete any row it also saves newly added row Thanks, Khushboo RM_3605_2392.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues

2019-04-03 Thread Khushboo Vashi
On Wed, Apr 3, 2019 at 2:00 PM Dave Page wrote: > > > On Wed, Apr 3, 2019 at 6:43 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Apr 2, 2019 at 9:25 PM Dave Page wrote: >> >>> >>> >

[pgAdmin4][Patch] - RM 4104 & RM 3938 - Partition table fixes

2019-04-03 Thread Khushboo Vashi
Hi, Please find the attached patch to fix: 1. # 4104 - Edit data tables with primary key spanning multiple columns [Partition table] Issue: The partition table having multiple primary keys are not editable from the View data. 2. # 3938 - Properties of table with default partition not displayed

Re: [pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues

2019-04-02 Thread Khushboo Vashi
On Tue, Apr 2, 2019 at 9:25 PM Dave Page wrote: > > > On Tue, Apr 2, 2019 at 4:00 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Apr 2, 2019 at 8:22 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com

Re: [pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues

2019-04-02 Thread Khushboo Vashi
On Tue, Apr 2, 2019 at 8:00 PM Dave Page wrote: > Hi > > On Tue, Apr 2, 2019 at 10:37 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM 4048 - Disable auto-fill on >> all dialogu

[pgAdmin4][Patch] - RM 4048 - Disable auto-fill on all dialogues

2019-04-02 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 4048 - Disable auto-fill on all dialogues. Thanks, Khushboo RM_4048.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 4082 - Download CSV error displayed for procedure and functions with create script

2019-03-31 Thread Khushboo Vashi
On Fri, Mar 29, 2019 at 8:03 PM Dave Page wrote: > Sorry Khushboo - I went with Aditya's patch. > No problem but rejection hurts :( > > On Thu, Mar 28, 2019 at 1:18 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Ple

[pgAdmin4][Patch] - Minor patch to remove javascript debugger

2019-03-28 Thread Khushboo Vashi
Hi, Please find the attached patch to remove the javascript debugger from the code. Thanks, Khushboo remove_debugger.patch Description: Binary data

[pgAdmin4][Patch] - RM 4082 - Download CSV error displayed for procedure and functions with create script

2019-03-28 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #4082 - Download CSV error displayed for procedure and functions with create script. The error message in case of any error while downloading the CSV file was blank, so now it has been displayed. Thanks, Khushboo diff --git a/web/pgadmin/tools/sql

Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised

2019-03-28 Thread Khushboo Vashi
Hi Dave, Please find the attached updated patch. Thanks, Khushboo On Thu, Mar 21, 2019 at 3:57 PM Dave Page wrote: > Hi > > On Thu, Mar 21, 2019 at 9:52 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, M

Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised

2019-03-24 Thread Khushboo Vashi
On Thu, Mar 21, 2019 at 3:22 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Mar 20, 2019 at 8:37 PM Dave Page wrote: > >> Hi >> >> On Wed, Mar 20, 2019 at 7:30 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.c

Re: RM3887 - User storage home folder collision

2019-03-21 Thread Khushboo Vashi
Hi Dave, On Thu, Mar 21, 2019 at 10:41 PM Dave Page wrote: > Here's a patch to fix and repair $SUBJECT. > > Anyone see any issues with it? > > Looks good to me. Thanks, Khushboo > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprise

Re: [pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised

2019-03-21 Thread Khushboo Vashi
Hi Dave, On Wed, Mar 20, 2019 at 8:37 PM Dave Page wrote: > Hi > > On Wed, Mar 20, 2019 at 7:30 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM #4030 - IDENTITY column not >>

[pgAdmin4][Patch] - RM 4030 - IDENTITY column not recognised

2019-03-20 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #4030 - IDENTITY column not recognised. - Added support for IDENTITY column for PostgreSQL >= 10.0 Thanks, Khushboo RM_4030.patch Description: Binary data

Re: pgAdmin 4 commit: Fix naming inconsistency for the column and FTS parse

2019-03-14 Thread Khushboo Vashi
Hi, Please find the attach fix for the regression. Thanks, Khushboo On Thu, Mar 14, 2019 at 10:23 PM Dave Page wrote: > Fix naming inconsistency for the column and FTS parser modules. Fixes #1269 > > Branch > -- > master > > Details > --- > > https://git.postgresql.org/gitweb?p=pgadmin

Re: RM4069 - Append the file suffix to filenames when needed in the File Create dialogue.

2019-03-14 Thread Khushboo Vashi
Hi Dave, On Thu, Mar 14, 2019 at 5:01 PM Dave Page wrote: > Here's a small patch for $SUBJECT. > > I'd normally commit something like this directly but wanted some thoughts > on the fact that it introduces a third method for figuring out what path > separator to use to the file manager code: > >

[pgAdmin4][Patch]: RM 4071 - Download as CSV broken on Firefox

2019-03-12 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 4071 - Download as CSV broken on Firefox. Thanks, Khushboo RM_4071.patch Description: Binary data

[pgAdmin4][Patch] - RM 3995 - SQL view of table with trigger cause ERROR: bogus varno: 2

2019-03-11 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 3995 - SQL view of table with trigger cause ERROR: bogus varno: 2 Thanks, Khushboo RM_3995.patch Description: Binary data

Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React

2019-03-07 Thread Khushboo Vashi
On Thu, Mar 7, 2019 at 4:34 PM Dave Page wrote: > > > On Thu, Mar 7, 2019 at 11:02 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 7, 2019 at 4:23 PM Dave Page wrote: >> >>> Thanks - commi

Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React

2019-03-07 Thread Khushboo Vashi
On Thu, Mar 7, 2019 at 4:23 PM Dave Page wrote: > Thanks - committed. Oddly, having removed a bunch of files and 88 JS > dependencies, the resulting Python package is actually slightly bigger! > And now I have conflicts in around 40 files. :) > > On Thu, Mar 7, 2019 at 9:46 AM Aditya Toshniwal <

Re: Async queries pretending to be synchronous

2019-03-04 Thread Khushboo Vashi
On Mon, Mar 4, 2019 at 4:05 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Mar 4, 2019 at 4:00 PM Dave Page wrote: > >> >> >> On Mon, Mar 4, 2019 at 10:18 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: &g

Re: Async queries pretending to be synchronous

2019-03-04 Thread Khushboo Vashi
On Mon, Mar 4, 2019 at 4:00 PM Dave Page wrote: > > > On Mon, Mar 4, 2019 at 10:18 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Mar 4, 2019 at 3:43 PM Dave Page wrote: >> >>> Hi >>> >

Re: Async queries pretending to be synchronous

2019-03-04 Thread Khushboo Vashi
On Mon, Mar 4, 2019 at 3:43 PM Dave Page wrote: > Hi > > On Mon, Mar 4, 2019 at 5:43 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Fri, Mar 1, 2019 at 10:01 PM Dave Page wrote: >> >>> In investigating #3656 I fo

Re: Async queries pretending to be synchronous

2019-03-03 Thread Khushboo Vashi
On Fri, Mar 1, 2019 at 10:01 PM Dave Page wrote: > In investigating #3656 I found the initial problem to be that when running > in a container, Gunicorn will kill the worker process if a thread doesn't > respond for 30 seconds by default. I fixed that by making the timeout match > the application

Re: [pgAdmin4][Patch] - Encoding Fixes

2019-03-01 Thread Khushboo Vashi
_encoding > AttributeError: 'Connection' object has no attribute 'python_encoding' > > I'm guessing there's a codepath in which connection objects are created > without the python_encoding attribute. > > > > On Fri, Mar 1, 2019 at 1:54 PM Dave Page wro

Re: [pgAdmin4][Patch] - Encoding Fixes

2019-02-28 Thread Khushboo Vashi
Hi, Please find the attached patch to support all the supported encodings by PostgreSQL. Thanks, Khushboo On Thu, Feb 28, 2019 at 10:53 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Feb 27, 2019 at 4:57 PM Dave Page wrote: > >> Hi >> &

Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

2019-02-28 Thread Khushboo Vashi
Hi Dave, Please find the attached fix. Thanks, Khushboo On Thu, Feb 28, 2019 at 6:58 PM Dave Page wrote: > Hi > > On Thu, Feb 28, 2019 at 3:46 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Feb 27, 2019

Re: [pgAdmin4][Patch] - Encoding Fixes

2019-02-27 Thread Khushboo Vashi
On Wed, Feb 27, 2019 at 4:57 PM Dave Page wrote: > Hi > > On Tue, Feb 26, 2019 at 9:01 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the encoding related issues. >> >&g

Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

2019-02-27 Thread Khushboo Vashi
eproduce it. Thanks, Khushboo > > On Wed, Feb 27, 2019 at 5:52 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the attached fix. >> I have added the configurable option to add the extra classes in the >> pane

Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

2019-02-26 Thread Khushboo Vashi
7:08 PM Dave Page wrote: > Hi Khushboo, > > On Wed, Feb 20, 2019 at 10:06 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> Also, the result grid seems to only be rendering itself to use about 50% >>>> of the available vertical

[pgAdmin4][Patch] - Encoding Fixes

2019-02-26 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the encoding related issues. #3992 - View data causes errors with DB encoding EUC_JIS_2004 #3982 - Encoding Problem with PGAdmin 4.2 #3911 - Data output does not display Arabic in WIN1256 encoding database - The CSV download for the same encoding has also

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-20 Thread Khushboo Vashi
> The fix attached. > Thanks! > > Thanks, Khushboo > On Wed, Feb 20, 2019 at 10:06 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >> On Wed, Feb 20, 2019 at 10:56 AM

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-20 Thread Khushboo Vashi
Hi, Please find the attached updated patch. On Wed, Feb 20, 2019 at 10:56 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Feb 19, 2019 at 7:27 PM Dave Page wrote: > >> Hi >> >> I did some testing with this and found a c

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-19 Thread Khushboo Vashi
by Akshay. I will fix along with this RM. > Thanks. > > Thanks, Khushboo > > On Tue, Feb 19, 2019 at 5:39 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Mon, Feb 18, 2019 at 4:49 PM Dave Page wrote: >> >>>

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-18 Thread Khushboo Vashi
Hi Dave, On Mon, Feb 18, 2019 at 4:49 PM Dave Page wrote: > On Mon, Feb 18, 2019 at 10:51 AM Khushboo Vashi > wrote: > > > > > > > > On Mon, Feb 18, 2019 at 3:08 PM Dave Page wrote: > >> > >> On Mon, Feb 18, 2019 at 9:08 AM Khushboo Vashi >

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-18 Thread Khushboo Vashi
On Mon, Feb 18, 2019 at 3:08 PM Dave Page wrote: > On Mon, Feb 18, 2019 at 9:08 AM Khushboo Vashi > wrote: > > > > > > > > On Thu, Feb 14, 2019 at 4:12 PM Dave Page wrote: > >> > >> Hi > >> > >> On Thu, Feb 14, 2019 at 6:56 AM

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-18 Thread Khushboo Vashi
On Thu, Feb 14, 2019 at 4:12 PM Dave Page wrote: > Hi > > On Thu, Feb 14, 2019 at 6:56 AM Khushboo Vashi > wrote: > > > > Hi, > > > > Please find the attached patch to fix the RM #3673 - "Download as .csv" > F8 does NOT work when one of joined fi

Re: RM2233 - Scratch pad

2019-02-15 Thread Khushboo Vashi
On Fri, Feb 15, 2019 at 6:35 PM Dave Page wrote: > Hi > > On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi > wrote: > > > > Hi Dave, > > > > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: > >> > >> Here's a draft patch for adding a sc

Re: RM2233 - Scratch pad

2019-02-15 Thread Khushboo Vashi
Hi Dave, On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: > Here's a draft patch for adding a scratch pad to the Query Tool, > similar to what we had in pgAdmin 3. > > Aside from regular review, can one of our CSS gurus (I'm looking at > you Aditya and Khushboo :-) ) help with the following ques

Re: [pgAdmin4][Patch] - RM 3959 - Properties and Dependents tabs rendering is slow with 1000+ records

2019-02-14 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Thu, Feb 14, 2019 at 3:05 PM Dave Page wrote: > Hi > > On Thu, Feb 14, 2019 at 5:44 AM Khushboo Vashi > wrote: > > > > Hi, > > > > Please find the attached patch to fix the RM #3959 - Proper

[pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-13 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file To fix this issue, used the existing query tool connection instead of a new connection to download the CSV file. Thanks, Khushboo RM_3673.patch Description:

[pgAdmin4][Patch] - RM 3959 - Properties and Dependents tabs rendering is slow with 1000+ records

2019-02-13 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #3959 - Properties and Dependents tabs rendering is slow with 1000+ records. Thanks, Khushboo RM_3959.patch Description: Binary data

[pgAdmin4][Patch]: Backform Switch control clean-up

2019-02-05 Thread Khushboo Vashi
Hi, Please find the attached patch for cleaning up the unwanted extended versions of Backform Switch controls. The Bootstrap Switch Control was extended only for alignment at most of the places. In this patch, I have introduced a configurable option to set the necessary class on the main div and a

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-02-04 Thread Khushboo Vashi
On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi wrote: > Hi Aditya > > On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I tried to simulate, but no luck. It works on my system :( >> > >I have tried and Feature test are failing ra

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

2019-02-04 Thread Khushboo Vashi
Hi Aditya, I have reviewed the patch and it looks good to me except the logic to wait until we get the response from the AJAX request. So, in this case at a time only one request is being sent to the server. @ Dave/Ashesh, if you think this is okay then we can commit the patch. Thanks, Khushboo

[pgAdmin4][Patch] RM 3899 - Unable to Drop Rules for table and foreign table through properties section

2019-01-30 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 3899 - Unable to Drop Rules for table and foreign table through properties section. Another minor issue fixed with this patch is - while adding/editing the foreign table, the foreign server cache level has not getting updated that has been fixed no

Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package

2019-01-30 Thread Khushboo Vashi
The patch looks good to me. On Wed, Jan 30, 2019 at 1:05 PM Akshay Joshi wrote: > Hi Khushboo > > On Wed, Jan 30, 2019 at 10:17 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> The issue has been fixed with this patch bu

Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package

2019-01-29 Thread Khushboo Vashi
Hi Akshay, The issue has been fixed with this patch but I feel we need code refactoring of the existing code especially the loop in which we find the required string. What's your thought? Also, please remove the datagrid/__init__.py file from the patch which I assume you have sent by mistake. Th

Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

2019-01-29 Thread Khushboo Vashi
> Can you please review it. >> >> On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the RM 3664 - Statistic panel >>> hangs when 100

Re: 4.1 bytecompile error on RHEL 7

2019-01-23 Thread Khushboo Vashi
On Wed, Jan 23, 2019 at 8:54 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Jan 23, 2019 at 10:38 PM Devrim Gündüz wrote: > >> >> Hi, >> >> I'm seeing this at the end of the RPM build process on

[pgAdmin4][Patch]: Fix syntax error on pytthon 2.7 for the feature test

2019-01-23 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the syntax error on python 2.7 for the feature test case. The cause of this is the print function is not compatible with python 2.7 which has been fixed. Thanks, Khushboo diff --git a/web/pgadmin/feature_tests/xss_checks_panels_and_query_tool_test.py b/we

Re: 4.1 bytecompile error on RHEL 7

2019-01-23 Thread Khushboo Vashi
On Wed, Jan 23, 2019 at 10:38 PM Devrim Gündüz wrote: > > Hi, > > I'm seeing this at the end of the RPM build process on RHEL 7. Please note > that > 3.6 passes here: > > == > + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 > Bytecompiling .py f

[pgAdmin4][Patch] - RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near

2019-01-22 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near. Thanks, Khushboo RM_3850.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

2019-01-22 Thread Khushboo Vashi
Hi, Please find the attached updated patch. On Tue, Jan 22, 2019 at 4:17 PM Akshay Joshi wrote: > Hi Khushboo > > On Tue, Jan 22, 2019 at 3:51 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the attached up

Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

2019-01-22 Thread Khushboo Vashi
gt; I have tested with Python 3.7 and it is working fine. Please give me the log to reproduce the issue. > > On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the R

Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

2019-01-22 Thread Khushboo Vashi
Hi Harshal, The Selec2Cell and PrivilegeCell are working properly but I think we should also consider below: 1. The Backgrid and sub-node should have accessibility including every button, cell and control. 2. The Backgrid table header is accessible through keyboard but it should be highlighted wh

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

2019-01-22 Thread Khushboo Vashi
The patch looks good to me. On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review it. > > On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached updated patch. >> In this patch I have f

[pgAdmin4][Patch] - RM 3800 - User can not add database with special characters under DB restriction for add server

2019-01-21 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 3800 - User can not add database with special characters under DB restriction for add server Thanks, Khushboo RM_3800.patch Description: Binary data

[pgAdmin4][Patch] - RM 3811 - Backup / restore job launch button needs two click

2019-01-21 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 3811 - Backup / restore job launch button needs two click Thanks, Khushboo RM_3811.patch Description: Binary data

[pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

2019-01-21 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "[" The patch includes the fix as well as the API test case to verify the reverse Engineered SQL. Thanks, Khushboo RM_3853.p

[pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

2019-01-16 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 3664 - Statistic panel hangs when 1000+ tables The statistics tab hangs with more rows. So, now the rows will be pushed in the backgrid collection in bunches on scroll event to fix this issue. Thanks, Khushboo RM_3664.patch Description: Binary d

Re: Help to translate pt-br

2019-01-15 Thread Khushboo Vashi
er > LPIC-1 > SCJP, SE 6 > Novell CLA / DCTS ECR > DBA Postgres > --- > “A caixa dizia: Requer MS Windows ou superior. Então instalei Linux.” - > Sábio Desconhecido > "Alguns prestam serviço/consultoria de Qualidade, os outros vendem > licença!&q

[pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields

2019-01-14 Thread Khushboo Vashi
Hi, Please find the attached patch to fix #3051 - Tables > Properties > Columns tab is slow on tables with a lot of fields The root cause of the issue is bootstrap switch, which has been replaced with bootstrap4-toggle application wide. Thanks, Khushboo RM_3051.patch Description: Binary data

Re: [pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser

2018-12-20 Thread Khushboo Vashi
On Thu, Dec 20, 2018 at 4:01 PM Dave Page wrote: > Hi > > On Tue, Dec 18, 2018 at 9:46 AM Khushboo Vashi > wrote: > > > > Hi, > > > > Please find the attached patch to fix the issue reported in RM #3559 > (Far too many mouse clicks to drill down i

[pgAdmin4][Patch]: RM 3796 - Grant Wizard: Text should be "Please add privileges..." instead of "Please select privileges..

2018-12-19 Thread Khushboo Vashi
Hi, Please find the attached minor patch to fix #3796 - Grant Wizard: Text should be "Please add privileges..." instead of "Please select privileges..." Thanks, Khushboo RM_3796.patch Description: Binary data

[pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser

2018-12-18 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the issue reported in RM #3559 (Far too many mouse clicks to drill down in Browser) related to Tree Save State. This RM was updated by the user with the issues in the browser tree state save functionality with the reproduction steps. These issues have been

[pgAdmin4][Patch] - RM 3823 - Delete/Drop and drop cascade option under properties section is disabled for multiple objects.

2018-12-17 Thread Khushboo Vashi
Hi, Please find the attached minor patch to fix the issue #3823 - Delete/Drop and drop cascade option under properties section is disabled for multiple objects. Thanks, Khushboo RM_3823.patch Description: Binary data

[pgAdmin4][Patch]: RM 3433 - query tool not responsive or showing any tab or window when selected

2018-12-13 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #3433 - query tool not responsive or showing any tab or window when selected. - Put the wait timeout of 2 secs in the select.select call in the Psycopg Async Polling. Thanks, Khushboo RM_3433.patch Description: Binary data

Re: when hostname is non ascii, the application server could not be contacts

2018-12-12 Thread Khushboo Vashi
On Thu, Dec 13, 2018 at 7:10 AM Ioseph Kim wrote: > Hi, > > I'm using PgAdmin4 very well, thanks. > > I found a problem. > > OS: windows7 64bit, (support Korean Language) > > PgAdmin4: v3.6 (pgadmin.org , exe install version) > > When hostname (windows' computer name) is non ascii, I could not ru

[pgAdmin4][Patch] : RM # 3797 - Detele/drop and drop cascade option under properties section should be disabled for pg_catalog

2018-12-12 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM # 3797 - Detele/drop and drop cascade option under properties section should be disabled for pg_catalog - Multiple delete should be disabled for pg_catalog and its child collection nodes. Thanks, Khushboo RM_3797.patch Description: Binary data

Re: Build failed in Jenkins: pgadmin4-master-python27 #825

2018-12-05 Thread Khushboo Vashi
Hi, Please find the attached fix for this failure. Thanks, Khushboo On Wed, Dec 5, 2018 at 9:45 AM pgAdmin 4 Jenkins wrote: > See < > https://jenkins.pgadmin.org/job/pgadmin4-master-python27/825/display/redirect?page=changes > > > > Changes: > > [Dave Page] Allow servers to be pre-loaded int

[pgAdmin4][Patch]: RM #3711 - Problem with encoding (Display wrong characters)

2018-12-04 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #3711 - Problem with encoding (Display wrong characters). Thanks, Khushboo RM_3711.patch Description: Binary data

Re: Help to translate pt-br

2018-11-26 Thread Khushboo Vashi
t; > Em qui, 22 de nov de 2018 às 02:00, Khushboo Vashi < > khushboo.va...@enterprisedb.com> escreveu: > >> On Wed, Nov 21, 2018 at 10:17 PM Bruno Silva >> wrote: >> >>> But is this ok? I send a patch to the email? Why don't use PR, Merge or >>&g

Re: Help to translate pt-br

2018-11-21 Thread Khushboo Vashi
> MBA Gerência de Projetos >> Certified Scrum Master >> LPIC-1 >> SCJP, SE 6 >> Novell CLA / DCTS ECR >> DBA Postgres >> --- >> “A caixa dizia: Requer MS Windows ou superior. Então instalei Linux.” - >> Sábio Desconhecido

Re: Help to translate pt-br

2018-11-21 Thread Khushboo Vashi
Hi, On Wed, Nov 21, 2018 at 6:29 PM Bruno Silva wrote: > I'm using pgAdmin4 and noted that has no translation to portuguese. > I teach Database on college and my students learn to use pgAdmin4, so I > thought > about contributing the pt-br translation, how can I proceed? > > Please refer https:

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

2018-11-01 Thread Khushboo Vashi
Please find attached patch to fix the test case for the resource groups. On Wed, Oct 31, 2018 at 5:07 PM Dave Page wrote: > Ahh - ignore my previous email :-) > > Patch committed! > > On Wed, Oct 31, 2018 at 11:09 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com>

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

2018-10-31 Thread Khushboo Vashi
Please find the patch to fix the test cases. As I can not reproduce the issue, I have fixed as per the logs. On Wed, Oct 31, 2018 at 4:01 PM Dave Page wrote: > Thanks - patch applied! > > On Wed, Oct 31, 2018 at 10:05 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com&

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

2018-10-24 Thread Khushboo Vashi
doc update. >>> >>> Done. >> >>> - I think fa-trash-alt might be better for the Drop icon. >>> >>> Done. >> >>> - I don't like the Drop Cascade icon. Maybe have Chethana create one >>> based on fa-trash-alt, shrunken a l

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

2018-10-09 Thread Khushboo Vashi
Hi Dave, On Mon, Oct 8, 2018 at 5:35 PM Dave Page wrote: > > > On Mon, Oct 8, 2018 at 12:50 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Mon, Oct 8, 2018 at 3:47 PM Dave Page wrote: >> >>>

Re: [pgAdmin4][Patch]: RM #3674 Old session files are not cleared in .pgAdmin session and keep piling up

2018-10-08 Thread Khushboo Vashi
On Mon, Oct 8, 2018 at 6:30 PM Akshay Joshi wrote: > Hi Hackers > > Attached is the patch to fix the RM #3674 "Old session files are not > cleared in .pgAdmin session and keep piling up". Patch contains following > changes: > >- With current implementation we have override *get_expiration_tim

Re: Patch for setting preferences with user id

2018-10-08 Thread Khushboo Vashi
On Mon, Oct 8, 2018 at 4:18 PM Dave Page wrote: > Hi > On Mon, Oct 8, 2018 at 9:08 AM Usman Muzaffar < > usman.muzaf...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find here attached patch for following >> >> "modified the function test_utils/set_preference to accommodate user_id." >>

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

2018-10-08 Thread Khushboo Vashi
Hi Dave, On Mon, Oct 8, 2018 at 3:47 PM Dave Page wrote: > Hi > On Fri, Oct 5, 2018 at 12:28 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch with the fixes. >> > > Whenever I

<    1   2   3   4   5   6   7   8   >