pgAdmin 4 commit: Fixed following issues for Schema Diff:

2022-09-13 Thread Akshay Joshi
Fixed following issues for Schema Diff: 1) When some option from filter is selected, that particular type should be completely removed from top level result instead of showing identical:0 2) Copy button is missing for Difference SQL 3) Throw error when source & target server versions selected a

pgAdmin 4 commit: Fixed following issues for Query Tool (after React Po

2022-04-20 Thread Akshay Joshi
Fixed following issues for Query Tool (after React Porting): 1) Find/Replace both opens the same dialogue box.(by clicking menu option) 2) Add New Server Connection > Server options keep loading(For multiple Server groups & should have some server) 3) Fixed CSS issues of slickgrid at various plac

pgAdmin 4 commit: Fixed following issues for query tool after react por

2022-04-18 Thread Akshay Joshi
Fixed following issues for query tool after react porting: 1) Add New Server Connection > Server options keep loading(For empty Server group). 2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes 3) Check sign beside options in Ex

pgAdmin 4 commit: Fixed following issues related to cloud deployment:

2022-02-28 Thread Akshay Joshi
Fixed following issues related to cloud deployment: 1) The Mumbai region issue has been resolved 2) Display name of regions has been modified appropriately 3) The password field has been validated the same way as AWS 4) Added support for a list of IP addresses in the public IP address range field.

pgAdmin 4 commit: Fixed following issues related to cloud deployment:

2022-02-18 Thread Akshay Joshi
Fixed following issues related to cloud deployment: 1) No options are shown in the instance type. 2) No options for the last 2 types. 3) Unable to change Storage config - size and iops 4) Unable to create an instance when pgAdmin is installed using the installer in Desktop mode 5) Can no

pgAdmin 4 commit: Fixed following code smells reported by SonarQube:

2022-01-21 Thread Akshay Joshi
Fixed following code smells reported by SonarQube: 1) Remove this redundant jump. 2) Remove this commented out code. 3) Variables should not be shadowed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=343c3ee49c8a4e252d0a5a22d59e85325836af1

pgAdmin 4 commit: Fixed following code smells reported by SonarQube:

2022-01-18 Thread Akshay Joshi
Fixed following code smells reported by SonarQube: 1) Immediately return this expression instead of assigning it to the temporary variable. 2) Extract this nested ternary operation into an independent statement. 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration. Br

pgAdmin 4 commit: Fixed following code smells reported by SonarQube:

2022-01-17 Thread Akshay Joshi
Fixed following code smells reported by SonarQube: 1) Boolean checks should not be inverted. 2) Review this redundant assignment. 3) Extract this nested ternary operation into an independent statement. 4) Unexpected empty function. 5) Immediately return this expression instead of assigning it

pgAdmin 4 commit: Fixed following SonarQube code smells:

2022-01-12 Thread Akshay Joshi
Fixed following SonarQube code smells: 1) Remove this useless assignment to a variable. 2) Remove the unused local variable. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e38c38cd581ceaa8c45b622b9bf37204caca9d59 Modified Files -

pgAdmin 4 commit: Fixed following issues after React Porting:

2021-09-23 Thread Akshay Joshi
Fixed following issues after React Porting: 1. Unique constraint should not allow changing values for deferrable, deferred, included columns. 2. Primary keys should not allow changing values for deferrable, deferred, included columns. 3. Foreign keys should not allow changing match type. The ref

pgAdmin 4 commit: Fixed following issues for Type dialog:

2021-09-20 Thread Akshay Joshi
Fixed following issues for Type dialog: 1. Enum Type - Unable to delete rows for Enum type in Create Type dialogue. 2. Range Type - Loading icons are shown in different drop-down tabs. Fixes #6744 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;

pgAdmin 4 commit: Fixed following: - Dropdown selected menu color - Cod

2021-09-09 Thread Akshay Joshi
Fixed following: - Dropdown selected menu color - CodeMirror render on properties tab - Placeholders on select control - Codemirror borders Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=27e446a0b00b83c5ab4876bf513882611b84a648 Author: Aditya

pgAdmin 4 commit: Fixed following issues in ERD:

2021-01-25 Thread Akshay Joshi
Fixed following issues in ERD: 1) After opening an existing project, the first table is already selected but the edit, clone, delete buttons are disabled. 2) ERD project title gets changed when 2 ERD projects are open & anyone of it edited. 3) Closing the ERD tab does not ask for a confirmatio

pgAdmin 4 commit: Fixed following issues in the function module:

2020-10-12 Thread Akshay Joshi
Fixed following issues in the function module: 1) The volatility option is not reflecting. It stays volatile always when creating the function. 2) Set "Returns as set" to true and enter estimated rows like 12. Now set returns as set to false and save. It gives ERROR: ROWS is not applicable whe

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-08-19 Thread Akshay Joshi
Fixed following SonarQube issues: 1. String literals should not be duplicated. 2. Cognitive Complexity of functions should not be too high. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0668a52c6bbc919c33575ebeb3e47dd71ffcb6e6 Author: Yoges

pgAdmin 4 commit: Fixed following schema diff issues:

2020-08-13 Thread Akshay Joshi
Fixed following schema diff issues: 1) Avoid template databases from the Database drop-down list. 2) Exclude system schemas while comparing two databases. 3) Escape group name for XSS. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=63df19ee

pgAdmin 4 commit: Fixed following schema diff issues:

2020-08-11 Thread Akshay Joshi
Fixed following schema diff issues: 1) Wrong SQL generated for the columns having different data type.   2) Added 'castfunc' in the ignore list. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=082b968bbcec2abde196278e111987147ad2fa72 Modifie

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-08-03 Thread Akshay Joshi
Fixed following SonarQube issues: - Remove this assignment to the local variable, the value is never used. - Rename local variables to match the regular expression - Add logic to this except clause or eliminate it and rethrow the exception automatically. - Rename fields to match the regula

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-07-30 Thread Akshay Joshi
Fixed following SonarQube issues: - Refactor functions to not always return the same value. - Rename "cls" to "self" or add the missing "self" parameter. - Remove useless assignment to variables. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitd

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-07-27 Thread Akshay Joshi
Fixed following SonarQube issues:   1) Define a constant instead of duplicating this literal.   2) Reduce cognitive complexity (Patch by Aditya) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb0bc65cedcf00d5e539ae7e4eaad0786438fbb1 Modified

pgAdmin 4 commit: Fixed following SoanrQube issues

2020-07-16 Thread Akshay Joshi
Fixed following SoanrQube issues   1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.   2) Define a constant instead of duplicating this literal. Solution: 1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LAB

pgAdmin 4 commit: Fixed following SoanrQube issues:

2020-07-07 Thread Akshay Joshi
Fixed following SoanrQube issues:   1) Variables should not be shadowed.   2) Variables and functions should not be redeclared. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=776bec0d824eb9187e1a3eff2c401d422002f642 Author: Yogesh Mahajan Mo

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-06-26 Thread Akshay Joshi
Fixed following SonarQube issues: 1) Refactor function to reduce its Cognitive Complexity. 2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=115657a465405be94c8c25dab3f88c9a

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-06-26 Thread Akshay Joshi
Fixed following SonarQube issues: 1. Boolean checks should not be inverted. 2. The comma operator should not be used. 3. Arguments to built-in functions should match documented types. 4. Redundant pairs of parentheses should be removed. 5. A conditionally executed single line should be denoted by i

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-06-26 Thread Akshay Joshi
Fixed following SonarQube issues: 1. Method/Field names should comply with a naming convention. 2. Conditionals should start on new lines Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=830ac1cc9177c8b9ebed2304924cec1db22e45c3 Author: Satish

pgAdmin 4 commit: Fixed following SonarQube issues:

2020-06-24 Thread Akshay Joshi
Fixed following SonarQube issues: 1) TypeError can be thrown as might be null or undefined here. 2) Unexpected duplicate "white-space". 3) Unexpected missing generic font family. 4) Unexpected shorthand "padding" after "padding-left". Branch -- master Details --- https://git.postgresql.o

pgAdmin 4 commit: Fixed following issues reported by SonarQube:

2020-06-16 Thread Akshay Joshi
Fixed following issues reported by SonarQube: 1) Replace this if-then-else statement by a single return statement. (clumsy) 2) 'switch' statements should have at least 3 'case' clauses. (bad practice) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdi

pgAdmin 4 commit: Fixed following issues for 1257:

2020-04-24 Thread Akshay Joshi
Fixed following issues for 1257: 1. For synonyms, the property is shown as "Public Synonym". 2. For system procedure, the flag should be True but it is displaying as False. 3. For both views and materialized views, the property is "System View". 4. For FTS templates, the property is showing as

pgAdmin 4 commit: Fixed following issues for packages:

2020-04-21 Thread Akshay Joshi
Fixed following issues for packages:   1) Removing the package header removes the body as well. 2) Schema is not visible on the properties dialog.   3) Reverse engineering SQL and Create script not showing schema-qualified packages. Fixes #5410 Branch -- master Details --- https://git

pgAdmin 4 commit: Fixed following issues for Procedures:

2020-04-15 Thread Akshay Joshi
Fixed following issues for Procedures: 1) Change comments on the procedure with arguments as a procedure can be overloaded. Note that on EPAS servers, procedure overloading works only for v11+. 2) The save button of a procedure dialog is enabled without any change. 3) Fixed formatting o

pgAdmin 4 commit: Fixed following audit vulnerabilities:

2020-03-19 Thread Akshay Joshi
Fixed following audit vulnerabilities: https://www.npmjs.com/advisories/1179 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=26d0a3e5cb7ee45d65e00c8805620fb0d746e008 Modified Files -- web/yarn.lock | 535 +

pgAdmin 4 commit: Fixed following audit vulnerabilities:

2020-03-16 Thread Akshay Joshi
Fixed following audit vulnerabilities: https://www.npmjs.com/advisories/1488 https://www.npmjs.com/advisories/1490 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3031c5055a8d1449763e6fa46f330beb15e4df1b Modified Files -- web/y

pgAdmin 4 commit: Fixed following issue of schema diff tool:

2020-01-31 Thread Akshay Joshi
Fixed following issue of schema diff tool: 1. Comparison result of 2 exact identical Trigger Functions is different 2. EPAS 12: Table comparison with the compound trigger shown as different, but all SQL panels are blank 3. Compound trigger properties panel is not opening 4. The DDL difference

pgAdmin 4 commit: Fixed following schema diff issues:

2020-01-28 Thread Akshay Joshi
Fixed following schema diff issues: 1) Version mismatch should be displayed if you select EPAS 11 as the source and EPAS 12 as the target. 2) We should handle schema diff if the user stops the server after compare. 3) The data type is not visible for column headers in the query tool/view da

pgAdmin 4 commit: Fixed following issues for feature test:

2019-12-03 Thread Akshay Joshi
Fixed following issues for feature test: 1. Modified the get_chromedriver utility for supporting python version below 3.5. 2. Handled some exceptions getting intermittently on some databases. 3. Generalized some functions with additional parameters. 4. Disabled the auto-expansion of the children n

pgAdmin 4 commit: Fixed following feature tests:

2019-11-21 Thread Akshay Joshi
Fixed following feature tests: 1) Handled click event in query tool due to intermediate clicking issue. 2) Observed that the database is not getting created in a test case, so failed the test case there only. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a

pgAdmin 4 commit: Fixed following feature tests:

2019-11-15 Thread Akshay Joshi
Fixed following feature tests: 1. Process watcher loading logs fix 2. Auto commit/rollback issue in query_tool_tests 3. Fixed the scrolling issue while verifying values in a table. 4. Modified some functions in pgadmin_page.py Branch -- master Details --- https://git.postgresql.org/gitweb

pgAdmin 4 commit: Fixed following issues:

2019-01-15 Thread Akshay Joshi
Fixed following issues: - Process watcher made fixed width with header changes, time details rounded to 2 decimals - Query history will show "No query history" if no query fired. Query editor default size increased. - Fixed a bug where New folder create button not working when in List mode and

pgAdmin 4 commit: Fixed following:

2019-01-02 Thread Akshay Joshi
Fixed following: - Base font size changed from 0.815rem to 0.875rem, for navbar from 0.875rem to 0.925rem. - Dialog sizes made consistent throughout the application. Now there are 3 size options for width and height each - sm, md, lg. Combination of any of these to be used hereafter - Alignment