Re: More RHEL 6 build issues

2017-07-11 Thread Dave Page
On Tue, Jul 11, 2017 at 12:09 PM, Devrim Gündüz wrote: > > Hi, > > Sorry, I missed this part: > > On Tue, 2017-07-11 at 11:44 +0100, Dave Page wrote: > > It was fixed in the code: > > > > # HTMLMIN doesn't work with Python 2.6. > > i

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
log is empty in > C:\Users\username\AppData\Roaming\pgAdmin > > > > The registry key in HKEY_CURRENT_USER\Software\pgadmin\pgadmin4 is blank > with a value not set. > > > > Windows 7 Enterprise 64 bit > > 16GB RAM > > SSD > > Behind the corporate proxy an

pgAdmin 4 commit: Straighten line

2017-07-11 Thread Dave Page
Straighten line Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=68a6c496d9648df2c002f85ad42d34850f773b11 Modified Files -- web/pgadmin/dashboard/static/img/welcome_logo.png | Bin 22526 -> 22603 bytes 1 file changed, 0 insertions(+)

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
gt; > Happy to test > > > > Thanks > > > > Mike > > > > *From:* Dave Page [mailto:dp...@pgadmin.org] > *Sent:* 11 July 2017 13:11 > *To:* McDonaldR > *Cc:* pgadmin-hackers; pgAdmin Support > *Subject:* Re: Windows testing required: Updated runtime > > &

Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

2017-07-11 Thread Dave Page
ions.json - s/PGAdmin/pgAdmin - We can remove the part about using sqlite for the DB. This is a Postgres project after all :-) Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
all is ok again > > > > But I guess it works on your machine so it must be something wrong with my > setup > Hard to see what though, if it's not the zoom. I have tested on Windows 7 as well as Windows 10, so it *should* work. -- Dave Page Blog: http:/

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
is snappy. > > > > I’ll test it some more tomorrow with connections to a production database. > > > > Ross > > > > *From:* Dave Page [mailto:dp...@pgadmin.org] > *Sent:* 11 July 2017 13:52 > *To:* Mike Surcouf > *Cc:* McDonaldR; pgadmin-hackers; pgAdmi

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
> > 3. Will there be a web install package. > There is a source tarball and Python wheel available at http://developer.pgadmin.org/~dpage/1.6/ Thanks! > > > Thanks > > > > Mike > > > > > > *From:* Dave Page [mailto:dp...@pgadmin.org] > *Sent

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
nd that your end users may have issues you don’t. > There are so many environmental factors to consider. > Oh, after over 20 years in IT support and software development, I've become painfully aware of that :-). > > > Mike > > > > *From:* Dave Page [mailto:dp..

pgAdmin 4 commit: Fix a compiler error with older compilers.

2017-07-11 Thread Dave Page
Fix a compiler error with older compilers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de06e63334ba041df6de4ba5a91e1650a9d8f024 Author: Mammoth Power Modified Files -- runtime/splash.png | Bin 28131 -> 13559 bytes 1 file chang

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Dave Page
>>>> >>>>> The last email on this chain from Surinder says that it isn't working on >>>>> IE and he will submit another patch. Are we missing that patch? Would you >>>>> like us to look at the previous patch? >>>> >>>>

Re: More RHEL 6 build issues

2017-07-12 Thread Dave Page
Hi On Tue, Jul 11, 2017 at 5:40 PM, Devrim Gündüz wrote: > > Hi Dave, > > On Tue, 2017-07-11 at 12:26 +0100, Dave Page wrote: > > Anyway; the attached patch fixes the issue for me. I wonder if this is > some > > CentOS weirdness... > > Thanks, that fixed th

pgAdmin 4 commit: Tag REL-1_6 has been created.

2017-07-13 Thread Dave Page
Tag REL-1_6 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_6 Log Message --- Tag 1.6

pgAdmin 4 v1.6 Released!

2017-07-13 Thread Dave Page
https://www.pgadmin.org/docs/pgadmin4/dev/index.html Download: https://www.pgadmin.org/download -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

Re: pgAdmin 4 v1.6 Released!

2017-07-14 Thread Dave Page
Thanks, fixed. On Thu, Jul 13, 2017 at 7:18 PM, Lazaro Garcia wrote: > The download links are wrong, the links downloads 1.5 and not 1.6. > > > > Regards. > > > > *De:* Dave Page [mailto:dp...@pgadmin.org] > *Enviado el:* jueves, 13 de julio de 2017 11:18 a

Re: pgadmin-for-web is going nowhere

2017-07-14 Thread Dave Page
Admin containers on Docker Hub available, few, if any of which were setup with the help of our mailing lists, so it's presumably not that hard to do. Either that or the Docker guys have thicker skins than the Project Atomic guys :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pgAdmin 4 v1.6 Released!

2017-07-14 Thread Dave Page
server address instead of 'localhost'. That was because we found that resolution of 'localhost' to an address can actually be quite slow on Windows in a Qt app. Do you have any kind of unusual network setup where 127.0.0.1 wouldn't work? E.g. *only* IPv6? -- D

Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

2017-07-14 Thread Dave Page
s doesn't actually seem to build for me. I had to make 2 changes to get anywhere: 1) Change the tag in base.html to: 2) Remove the STATIC_ROOT directive from settings.py (so it didn't try to compile to /static) and replace with COMPRESS_ROOT='static/' and SASS_PROCESSOR_ROOT='

pgAdmin 4 commit: Don't continually poll for graph data on the dashboar

2017-07-14 Thread Dave Page
Don't continually poll for graph data on the dashboard if the server is disconnected. Fixes #1165 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da67963094e2bff82af536fc3f341cc7cd53356a Author: Khushboo Vashi Modified Files -- .

Re: [pgAdmin4][Patch]: Fixed RM #1165 - Too many request to update dashboard graphs when server is disconnected.

2017-07-14 Thread Dave Page
Thanks, patch applied. On Tue, Jul 11, 2017 at 5:12 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > please find the attached updated patch. > > Thanks, > Khushboo > > On Mon, Jul 10, 2017 at 6:54 PM, Dave Page wrote: > >> Hi >>

pgAdmin 4 commit: Fix privileges control on IE 10/11. Fixes #1166

2017-07-14 Thread Dave Page
Fix privileges control on IE 10/11. Fixes #1166 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=822e62c238f5cfe862d4580056681b21707efd8a Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/servers/static/js/privi

Re: [pgAdmin4][Patch] To fix the issue in privileges control

2017-07-14 Thread Dave Page
for given role. >>> RM#1166 >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: How to modify font size of displayed view?

2017-07-15 Thread Dave Page
Hi, You can adjust the zoom with Cmd+ (iirc - it's Ctrl on other platforms). You may need shift as well, if + is a shift key. There is a list of shortcut keys in the docs. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprised

Re: pgadmin-for-web is going nowhere

2017-07-17 Thread Dave Page
On Fri, Jul 14, 2017 at 7:17 PM, Josh Berkus wrote: > On 07/14/2017 01:01 AM, Dave Page wrote: > > > Setting up in server mode by following those docs takes just a few > minutes. > > > > > > Six months ago, I jumped on this with the goal of solving it, pa

Re: pgAdmin 4 v1.6 Released!

2017-07-17 Thread Dave Page
o check... > In the web/ subdirectory of the installation, you should find a file called config.py. Please create a file called config_local.py in the same directory, containing the following lines (excluding the lines) : from config import * # Debug mode DEBUG = True # Log CONSOLE_LOG_

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-17 Thread Dave Page
lection/row_selector_spec.js:6727 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/selection/set_staged_rows_spec.js:6198 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/selection/set_staged_rows_spec.js:6198 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/selection/xcell_selection_model_spec.js:7089 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/selection/xcell_selection_model_spec.js:7089 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/slickgrid/cell_selector_spec.js:6434 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/slickgrid/cell_selector_spec.js:6434 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/slickgrid/event_handlers/handle_query_output_keyboard_event_spec.js:6411 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/slickgrid/event_handlers/handle_query_output_keyboard_event_spec.js:6411 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/sqleditor_utils_spec.js:125 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/sqleditor_utils_spec.js:125 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at pgadmin/static/bundle/slickgrid.js:1008 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at pgadmin/static/bundle/slickgrid.js:1008 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [RM2551][pgAdmin4] show tablespace on partitions.

2017-07-17 Thread Dave Page
are Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Show tablespace on partitions. Fixes #2551

2017-07-17 Thread Dave Page
Show tablespace on partitions. Fixes #2551 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07aa74eaf56db72eab55dd735c710a4796abd669 Author: Harshal Dhumal Modified Files -- .../templates/partition/sql/10_plus/create.sql | 8 +

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-17 Thread Dave Page
p down for this, and include some/all of the other Editing options on there? E.g. tab/shift-tab. * I think the docs should say Ctrl+Shift+/ rather than Shift+Ctrl+/, and be ordered in the table to reflect that. It seems more natural to me. Thoughts? -- Dave Page Blog: http://pgsnake.blogspot.

Re: [RM2544][pgAdmin4] Fix for malformed query generated when using custom type

2017-07-17 Thread Dave Page
On Wed, Jul 12, 2017 at 2:01 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix malformed sql for data type. > Can you give me some steps to reproduce this please, as I cannot using either lower or mixed case identifiers.

pgAdmin 4 commit: Prevent the tab bar being hidden when detached tabs a

2017-07-17 Thread Dave Page
Prevent the tab bar being hidden when detached tabs are being closed. Fixes #2558 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fe0d5192537c0fcd6105d0aafff3ab2cb218273 Author: Neel Patel Modified Files -- runtime/TabWindow.cpp

Re: [pgAdmin4][runtime]: Fix RM #2558

2017-07-17 Thread Dave Page
platforms. Do review it and let me know for > comments. > > Thanks, > Neel Patel > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch] Not to display PID comma separated in statistics panel

2017-07-17 Thread Dave Page
Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Remove the comma from PIDs in the statistics panel.

2017-07-17 Thread Dave Page
Remove the comma from PIDs in the statistics panel. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f83780049ed5fbb95ad26c3659e790622736964 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/statistics/static/js/statist

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-17 Thread Dave Page
not be superuser only - regular users should be able to cancel their own queries. - On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-17 Thread Dave Page
Hi On Mon, Jul 17, 2017 at 10:31 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jul 17, 2017 at 2:33 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jul 12, 2017 at 1:16 PM, Murtuza Zabuawala < >> murtuza

pgAdmin 4 commit: Stop tool buttons from changing their styling unexpec

2017-07-17 Thread Dave Page
Stop tool buttons from changing their styling unexpectedly. Fixes #2559 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dcc74af87b2c9fb9484a9349584c704fd39a8579 Author: Neel Patel Modified Files -- runtime/TabWindow.cpp | 9 --

Re: [pgAdmin4][runtime][Patch]: Fix RM #2559

2017-07-17 Thread Dave Page
ew it and let me know for > comments. > > Thanks, > Neel Patel > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix handline of large file uploads and properly show

2017-07-17 Thread Dave Page
Fix handline of large file uploads and properly show any errors that may occur. Fixes #2153 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bbcf0ab364f1ede76da51a1d0d6033799a76d72 Author: Harshal Dhumal Modified Files -- web/pga

Re: [RM2153][pgAdmin4] handle large file uploads

2017-07-17 Thread Dave Page
-- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Testing out font changes in query editor tool

2017-07-17 Thread Dave Page
On Fri, Jul 14, 2017 at 5:06 AM, Murtuza Zabuawala wrote: > Hi Shirley, > > It's easy on the eyes :) > Agreed. As requested, there's a test build for Windows at https://developer.pgadmin.org/~dpage/query_tool_font_test/ -- Dave Page Blog: http://pgsnake.blogspot

Re: [pgAdmin4][runtime][Patch]: Fix RM #2557

2017-07-17 Thread Dave Page
; > Thanks, > Neel Patel > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Tidy up tab styling. Fixes #2557

2017-07-17 Thread Dave Page
Tidy up tab styling. Fixes #2557 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc6a1936f5c13002188addc3b67db80e3ccdf659 Author: Neel Patel Modified Files -- runtime/TabWindow.cpp | 43 +++

pgAdmin 4 commit: Fix typo

2017-07-17 Thread Dave Page
Fix typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=059d671af5b09ffdfa931fd305be8a7aba6f7f68 Author: Khushboo Vashi Modified Files -- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin4][Patch]: Minor patch to fix a typo in README

2017-07-17 Thread Dave Page
Thanks, applied. On Mon, Jul 17, 2017 at 5:14 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find a minor patch to fix a typo in README. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgs

pgAdmin 4 commit: Correct for malformed query generated when using cus

2017-07-17 Thread Dave Page
Correct for malformed query generated when using custom type. Fixes #2544 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3942461c502854aa4075da48dd7dea0570df25f5 Author: Harshal Dhumal Modified Files -- .../schemas/types/templat

Re: [RM2544][pgAdmin4] Fix for malformed query generated when using custom type

2017-07-17 Thread Dave Page
a: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-17 Thread Dave Page
ontent when loaded dynamically, the >> content is not cached.​ >> >>> >>> >>>> *Taks remaining:* >>>> >>>> ​1. ​ >>>> Fix local variables which are declared without using var, have to check >>>> in each file >>>> ​ by​ >>>> running eslint (For now, i will fix only errors which are giving error >>>> in browser). >>>> >>>> ​2. ​ >>>> Move non-template files from ’templates’ to ’static’ directory. List of >>>> ​ pending​ >>>> modules is here: >>>> >>>>- Tools (mostly all modules - 9 modules) >>>>- Browser nodes - 3 modules(resource group, roles, tablespace) >>>>- ​About >>>>​​ >>>> >>>> Also can we move >>>> ​'​ >>>> dashboard, statistic >>>> ​s​ >>>> , preferences and help >>>> ​'​ >>>> modules inside misc to preserve modularity as pgAdmin is modular >>>> ​ ?​ >>>> >>> >>> Is there anything from a organization stance you discussed in the >>> previous email that needs to be done to make this usable and consistent? >>> >> ​No​ >> >>> >>> >>> Thanks, >>> >>> George & Sarah >>> >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

2017-07-17 Thread Dave Page
otal.io> wrote: > >> Hello Dave, >> Instead of using the current library we found another one that compiles >> the SCSS when the application starts. >> We recreated the patches we sent before. >> >> Thanks >> Joao & Sarah >> >> On Fri

pgAdmin 4 commit: Modify the runtime to use time-based timeouts rather

2017-07-17 Thread Dave Page
Modify the runtime to use time-based timeouts rather than retry based. Fixes #2556 This allows for slow vs. fast connection failures (e.g. an active rejection vs. no response). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c5461827894bc99a

pgAdmin 4 commit: Remove change made for debugging and committed in err

2017-07-17 Thread Dave Page
Remove change made for debugging and committed in error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d04ac7656a33e9076b6e2b68ed51dd60a7e8e820 Modified Files -- runtime/pgAdmin4.cpp | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [pgAdmin4][Patch]: RM #2556: Runtime connection retry loop timeout

2017-07-17 Thread Dave Page
Thanks, applied! On Mon, Jul 17, 2017 at 1:53 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for RM #2556: Runtime connection retry loop > timeout > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.

Re: [RM2544][pgAdmin4] Add SSL database connection support in Regression tests

2017-07-17 Thread Dave Page
ction check test with 'prefer' sslmode" I would expect to see: runTest (pgadmin.browser.server_groups.servers.tests.test_check_ssl_connection.TestSSLConnectionCheck) Test SSL Connection ... skipped "Cannot run SSL connection check test with 'prefer' sslmode" Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-17 Thread Dave Page
leElementReferenceException: Message: stale element reference: element is not attached to the page document (Session info: chrome=59.0.3071.115) (Driver info: chromedriver=2.29.461585 (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.5 x86_64) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-18 Thread Dave Page
On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > > On Mon, Jul 17, 2017 at 9:33 PM, Dave Page wrote: > >> Hi >> >> On Mon, Jul 17, 2017 at 1:09 PM, Harshal Dhumal < >> harshal.dhu...@enterpr

Re: [pgadmin-hackers] 10k Tables and more

2017-07-18 Thread Dave Page
n the past. That's still an option of course, though I've yet to find anything better. A more generic solution might be to group tables if there are more than N - e.g. add an extra level into the hierarchy dynamically splitting them up into groups (which would probably also ha

Re: [PATCH] Persist opened nodes in tree

2017-07-18 Thread Dave Page
== > +typeof p.parse||"function"!==typeof p.stringify)throw Error("No JSON > support found, include //cdnjs.cloudflare.com/ajax/ > libs/json2/20110

Re: Testing out font changes in query editor tool

2017-07-18 Thread Dave Page
> On Mon, Jul 17, 2017 at 5:55 AM Dave Page wrote: > >> On Fri, Jul 14, 2017 at 5:06 AM, Murtuza Zabuawala > enterprisedb.com> wrote: >> >>> Hi Shirley, >>> >>> It's easy on the eyes :) >>> >> >> Agreed. &

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Dave Page
anks - applied with some minor styling and layout changes. Please check I didn't break anything. You obviously miss-spelt "colour", but I let that slide :-p -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Dave Page
he only English is en_US (of which there are a surprisingly large amount). > > -- Rob > > On Tue, Jul 18, 2017 at 7:54 AM, Dave Page wrote: > >> >> >> On Mon, Jul 17, 2017 at 7:51 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: &g

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Dave Page
o > > On Tue, Jul 18, 2017 at 8:20 AM, Dave Page wrote: > >> >> >> On Tue, Jul 18, 2017 at 1:15 PM, Robert Eckhardt >> wrote: >> >>> Looks good. >>> >> >> Thanks. I just noticed though, that we're trying to link to github.cs

pgAdmin 4 commit: Webpack all the things! Fixes #2135

2017-07-18 Thread Dave Page
Webpack all the things! Fixes #2135 This significantly speeds up loading of the application; in an average of 3 tests, v1.6 loaded in 11.5s in the runtime on a Mac, whilst the webpacked version of the code loaded in 5.53s. Branch -- master Details --- https://git.postgresql.org/gitweb?

pgAdmin 4 commit: Add missing new files from the previous commit. Ooops

2017-07-18 Thread Dave Page
Add missing new files from the previous commit. Ooops. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6396b8ce1801ebb9b00013b5115ea7851ca094a7 Author: Surinder Kumar Modified Files -- .../index_constraint/static/js/primary_key.js

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-18 Thread Dave Page
find updated patch. > > Thanks > Surinder > > On Mon, Jul 17, 2017 at 6:57 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Mon, Jul 17, 2017 at 4:52 PM, Dave Page wrote: >> >>> Hi >>> >>> No errors now, but d

pgAdmin 4 commit: Support SSL in the regression tests. Fixes #2170

2017-07-18 Thread Dave Page
Support SSL in the regression tests. Fixes #2170 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bab3da24e6a0d82f7be26b7559ee0d6392baaffd Author: Murtuza Zabuawala Modified Files -- .../servers/databases/casts/tests/test_cast_add.

Re: [RM2544][pgAdmin4] Add SSL database connection support in Regression tests

2017-07-18 Thread Dave Page
Thanks, applied. On Tue, Jul 18, 2017 at 6:30 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch for the same. > > > On Mon, Jul 17, 2017 at 8:59 PM, Dave Page wrote: > >> Hi >> >> On Mo

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-18 Thread Dave Page
On Tue, Jul 18, 2017 at 2:40 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Jul 18, 2017 at 1:24 PM, Dave Page wrote: > >> >> >> On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.c

pgAdmin 4 commit: Add a missing dependency.

2017-07-18 Thread Dave Page
Add a missing dependency. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=659aeeb58e6a91f67b546e1d3fa06735cf453c68 Author: Surinder Kumar Modified Files -- web/pgadmin/static/bundle/slickgrid.js | 1 + 1 file changed, 1 insertion(+

pgAdmin 4 commit: Resolve an issue where collection nodes sometimes wou

2017-07-18 Thread Dave Page
Resolve an issue where collection nodes sometimes wouldn't sort properly. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b90d368ee7bf8a029378cd70f577e24e05e1c13f Author: Surinder Kumar Modified Files -- web/pgadmin/static/js/back

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-18 Thread Dave Page
rent collection nodes. > > Please find attached patch. > > Thanks > Surinder > > On Tue, Jul 18, 2017 at 8:20 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Jul 18, 2017 at 7:46 PM, Dave Page wrote: >> >>

Re: Build failed in Jenkins: pgadmin4-master-python27-feature #8

2017-07-19 Thread Dave Page
es> >> >> Changes: >> >> [Dave Page] Use client-side url_for in the sql editor and data grid >> modules. >> >> [Dave Page] Ensure revoked public privileges are displayed in the RE-SQL >> for >> >> [Dave Page] Ensure saved passwords are

pgAdmin 4 commit: Add controls and shortcuts for commenting/uncommentin

2017-07-19 Thread Dave Page
Add controls and shortcuts for commenting/uncommenting code in the SQL Editor. Fixes #2456. Take the opportunity to tidy up the menus and add access keys to appropriate buttons. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1e1a9f2cf4a76a4

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-19 Thread Dave Page
& unindent code in the same drop-down. >> 3) Updated shortcut documents accordingly. >> >> Please review. >> >> On Mon, Jul 17, 2017 at 3:05 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Jul 17, 2017 at 10:31 AM, Murtuza Zabuawala < &

pgAdmin 4 commit: Fix typo in filename.

2017-07-19 Thread Dave Page
Fix typo in filename. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6046be7fba76b0617244f3d8ead1fdf81dddc7ca Author: Surinder Kumar Modified Files -- web/webpack.shim.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-19 Thread Dave Page
Surinder, Load time ~2 sec on browser :) >> >> [image: Inline image 1] >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Tue, Jul 18, 2017 at 9:01 PM, Dave P

pgAdmin 4 commit: Webpacking cleanups

2017-07-19 Thread Dave Page
Webpacking cleanups Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dfa877262d67a9daaff2597d31217d9d3852 Author: Surinder Kumar Modified Files -- .../js/exclusion_constraint.js | 2 - .../templates/foreign_

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-19 Thread Dave Page
surinder.ku...@enterprisedb.com> wrote: > >> On Wed, Jul 19, 2017 at 4:27 PM, Dave Page wrote: >> >>> That was a fun one to spot I'm sure! >>> >> ​Indeed, i had setup pgAdmin evn on Linux(as it works on Mac) and then i >> did `ls path/to/jquery.cont

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-19 Thread Dave Page
rinder has moved >>> all the CodeMirror code into bundle package. >>> >>> On Wed, Jul 19, 2017 at 2:20 PM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA updat

pgAdmin 4 commit: Fix regressions introduced by PG10's partitioning cod

2017-07-20 Thread Dave Page
Fix regressions introduced by PG10's partitioning code. Fixes #2043. Fixes #2324. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d4da6724724e6e24d243e1c3f1ca93ef7c91046 Author: Akshay Joshi Modified Files -- .../servers/databas

pgAdmin 4 commit: More webpack cleanup - add comments liberally and ren

2017-07-20 Thread Dave Page
More webpack cleanup - add comments liberally and rename lib.css to style.css Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2eb151c2d9e261ccd4a157e5f7ac00fc47b97d41 Author: Surinder Kumar Modified Files -- web/pgadmin/static/css

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-20 Thread Dave Page
On Thu, Jul 20, 2017 at 1:02 PM, Dave Page wrote: > Hi > > On Wed, Jul 19, 2017 at 1:58 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Jul 18, 2017 at 8:31 PM, Dave Page wrote: >>> >>> >>&

pgAdmin 4 commit: Don't attempt to render binary data in the query tool

2017-07-20 Thread Dave Page
Don't attempt to render binary data in the query tool result grid. Fixes #2080. Fixes #2074. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54882e061cd1f29e220cfee375586f4e2fe17d5e Author: Harshal Dhumal Modified Files -- .../fe

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-20 Thread Dave Page
On Thu, Jul 20, 2017 at 1:04 PM, Dave Page wrote: > > > On Thu, Jul 20, 2017 at 1:02 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jul 19, 2017 at 1:58 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi Dave,

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Dave Page
m, and was intended to allow session protection in other scenarios. As we are already using Flask-Login, do we need this? See the Session Protection section on https://flask-login.readthedocs.io/en/latest/. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: htt

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Dave Page
indent 219:9 error Expected indentation of 6 spaces but found 8indent Can you please fix that up and double-check the tests pass? Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-20 Thread Dave Page
e PostgreSQL Company > > On Wed, Jul 19, 2017 at 8:00 PM, Dave Page wrote: > >> Except I managed to break a couple of tests :-(. Can you take a look >> please? I've had some other work come up that I need to deal with. >> >> ===

pgAdmin 4 commit: Fix webpacking of loading icon.

2017-07-20 Thread Dave Page
Fix webpacking of loading icon. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae3acbdbbc9e40fde8f085e0291deed2d265a558 Author: Surinder Kumar Modified Files -- web/pgadmin/misc/file_manager/templates/file_manager/index.html |

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-20 Thread Dave Page
ves 404 not found when >> FileManager is opened from Query tool/Backup utility. >> >> Please find attached patch and review. >> >> Thanks, >> Surinder Kumar >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Dave Page
ercome above scenarios, It is not > most necessary thing to include in our project but it will improve the > session security. > > On Thu, Jul 20, 2017 at 5:52 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jul 20, 2017 at 12:59 PM, Murtuza Zabuawala < >> murtuza.za

pgAdmin 4 commit: Remove debug logging of the URL map which is extremel

2017-07-20 Thread Dave Page
Remove debug logging of the URL map which is extremely long now, and not of a great deal of use. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83ac1f3555066322077b1cdc212ee7ff74cf3322 Modified Files -- web/pgadmin/__init__.py |

Unified server/desktop config

2017-07-20 Thread Dave Page
ough. Can anyone see if the patch breaks anything, or if I missed any side effects? Is it likely to break things during upgrades? I suspect so... so maybe this should prompt v2.0? I'd appreciate multiple reviews of this, as it could break things. Note that I haven't yet updated the

Re: Unified server/desktop config

2017-07-20 Thread Dave Page
gt; On Thu, Jul 20, 2017 at 10:22 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Partial patch for feature test got included in you patch :) >> >> >> On Thu, Jul 20, 2017 at 9:33 PM, Dave Page wrote: >> >>> All, >>

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Dave Page
atest version I've received.. > Thanks > Joao > > On Thu, Jul 20, 2017, 8:15 AM Dave Page wrote: > >> Hi >> >> On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer wrote: >> >>> Hi again! >>> >>> Attached are the most updated patches

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-20 Thread Dave Page
tarter.py... > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jul 20, 2017 at 6:04 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> I am working on t

pgAdmin 4 commit: Add the Flask-Paranoid module for a little extra, wel

2017-07-20 Thread Dave Page
Add the Flask-Paranoid module for a little extra, well, paranoia in web mode. Fixes #2584 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64f3a559abadd62b9c49b78e1a937191fb0253ef Author: Murtuza Zabuawala Modified Files -- requir

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Dave Page
Thanks, applied. On Thu, Jul 20, 2017 at 3:38 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > > On Thu, Jul 20, 2017 at 6:17 PM, Dave Page wrote: > >> >> >> On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala < >> murtuza.za

pgAdmin 4 commit: Allow navigation of query history using the arrow key

2017-07-20 Thread Dave Page
Allow navigation of query history using the arrow keys. Fixes #2590 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=21bfcd83f42ba06f146ed1d2010fd66db0ed Author: Matthew Kleiman Modified Files -- .../feature_tests/query_tool_jo

pgAdmin 4 commit: Improve the history UI.

2017-07-20 Thread Dave Page
Improve the history UI. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e29cd8d83dfbb00911caf2c3ea5065a7511bd11c Author: Matthew Kleiman Modified Files -- .../feature_tests/query_tool_journey_test.py | 4 +++ .../jsx/history

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Dave Page
o they both pass the linting test. > > Thanks, > Matt and João > > > On Thu, Jul 20, 2017 at 12:56 PM, Dave Page wrote: > >> >> >> On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>&g

Re: [pgadmin-hackers][pgaweb][patch] Update SCSS of styleguide

2017-07-20 Thread Dave Page
Thanks > Joao && Matt > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

<    1   2   3   4   5   6   7   8   9   10   >