Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

u like. >>>> Thanks >>>> >>>> ------ Forwarded message -- >>>> From: Dave Cramer <davecra...@gmail.com> >>>> Date: Thu, Aug 24, 2017 at 8:34 PM >>>> Subject: Re: [pgadmin4][Patch] Greenplum spec

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

you like. >>> Thanks >>> >>> -- Forwarded message -- >>> From: Dave Cramer <davecra...@gmail.com> >>> Date: Thu, Aug 24, 2017 at 8:34 PM >>> Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard >>> di

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

24, 2017 at 8:34 PM > Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display > To: Teng Zhang <tezh...@pivotal.io> > Cc: Ashesh Vashi <ashesh.va...@enterprisedb.com>, pgadmin-hackers < > pgadmin-hack...@postgresql.org>, Dave Page <dp...@pga

Fwd: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Sure, you can get as much as you like. Thanks -- Forwarded message -- From: Dave Cramer <davecra...@gmail.com> Date: Thu, Aug 24, 2017 at 8:34 PM Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display To: Teng Zhang <tezh...@pivotal.io> Cc:

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

On 22 August 2017 at 16:41, Dave Cramer wrote: > Ok, > > Surely this : > > self.table_template_path = 'table/sql/' + ( > +'#{0}#{1}#'.format(server_type, ver) > +if server_type == 'gpdb' else > +'#{0}#'.format(ver) > +

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Ok, Surely this : self.table_template_path = 'table/sql/' + ( +'#{0}#{1}#'.format(server_type, ver) +if server_type == 'gpdb' else +'#{0}#'.format(ver) +) could be written in a more readable manner ?? Dave Cramer On 22 August 2017

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi, I've been able to get back to this and test it. So far so good. It applies more or less cleanly against 1.6 and everything I've tried so far works I'll update more as I test it. Thanks Dave Cramer On 21 August 2017 at 05:29, Teng Zhang wrote: > Hi, > > Thanks for the

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi, Thanks for the review, here is a fixed patch working for GBDP which shows the appropriate graphs. In this fix, we toke out the changes to diver/psycopg2 and implemented the greenplum version checking process in the ppas way mentioned by Dave Cramer. Regards, Teng Zhang & Hao Wang On Mon,

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

On Mon, Aug 21, 2017 at 1:23 PM, Dave Page wrote: > Ashesh, do you have a recommended way to do this? > > I haven't looked at the patch, but I assume it adds a database driver > module for GPDB? > I have not looked at the patch yet. I will take a look at it. -- Thanks &

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Ashesh, do you have a recommended way to do this? I haven't looked at the patch, but I assume it adds a database driver module for GPDB? On Mon, Aug 21, 2017 at 8:50 AM, Jing Li wrote: > Hi Dave, > > Since we're hoping to get this change working for GPDB we've currently >

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi Dave, Since we're hoping to get this change working for GPDB we've currently using this method to detect if it's gpdb and show the appropriate graphs. Right now it displays errors on the dashboard if it's connected to a gpdb server.For this patch specifically, the goal is to improve the

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi Violet. I don't really like the way this has been implemented. It adds a variable which is only used for gpdb. There are other places in the code where the behaviour is changed if the server is ppas or regular postgres. Candidly I think all of this needs restructuring. Dave Cramer On 15