Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Robert Eckhardt]

Given that Greenplum is going to GA next month can we get that stable OSS
version included in the CI?

Rob

On Aug 25, 2017 8:27 AM, "Akshay Joshi" <akshay.jo...@enterprisedb.com>
wrote:

> Thanks patch applied. I haven't tested it on GPDB.
>
> On Fri, Aug 25, 2017 at 4:55 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Fri, Aug 25, 2017 at 4:53 PM, Dave Cramer <davecra...@gmail.com>
>> wrote:
>>
>>> I'm suggesting that it be pushed
>>>
>> Akshay is already on to it, and currently reviewing it.
>> Will push it once get the confirmation.
>>
>> -- Thanks, Ashesh
>>
>>>
>>> Dave Cramer
>>>
>>> On 24 August 2017 at 23:00, Teng Zhang <tezh...@pivotal.io> wrote:
>>>
>>>> Sure, you can get as much as you like.
>>>> Thanks
>>>>
>>>> ------ Forwarded message --
>>>> From: Dave Cramer <davecra...@gmail.com>
>>>> Date: Thu, Aug 24, 2017 at 8:34 PM
>>>> Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard
>>>> display
>>>> To: Teng Zhang <tezh...@pivotal.io>
>>>> Cc: Ashesh Vashi <ashesh.va...@enterprisedb.com>, pgadmin-hackers <
>>>> pgadmin-hack...@postgresql.org>, Dave Page <dp...@pgadmin.org>, Jing
>>>> Li <jin...@pivotal.io>
>>>>
>>>>
>>>> Can we get some movement on this patch? This seems like a more sane way
>>>> to go to support different "products"
>>>>
>>>> Dave Cramer
>>>>
>>>> On 22 August 2017 at 16:56, Dave Cramer <davecra...@gmail.com> wrote:
>>>>
>>>>>
>>>>> On 22 August 2017 at 16:41, Dave Cramer <davecra...@gmail.com> wrote:
>>>>>
>>>>>> Ok,
>>>>>>
>>>>>> Surely this :
>>>>>>
>>>>>> self.table_template_path = 'table/sql/' + (
>>>>>> +'#{0}#{1}#'.format(server_type, ver)
>>>>>> +if server_type == 'gpdb' else
>>>>>> +'#{0}#'.format(ver)
>>>>>> +)
>>>>>>
>>>>>> could be written in a more readable manner ??
>>>>>>
>>>>>>
>>>>>>
>>>>> Apologies, after reading a bit, this is apparently idiomatic python.
>>>>>
>>>>> Please ignore
>>>>>
>>>>>
>>>>>> Dave Cramer
>>>>>>
>>>>>> On 22 August 2017 at 14:25, Dave Cramer <davecra...@gmail.com> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I've been able to get back to this and test it. So far so good. It
>>>>>>> applies more or less cleanly against 1.6 and everything I've tried so 
>>>>>>> far
>>>>>>> works
>>>>>>>
>>>>>>> I'll update more as I test it.
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> Dave Cramer
>>>>>>>
>>>>>>> On 21 August 2017 at 05:29, Teng Zhang <tezh...@pivotal.io> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Thanks for the review, here is a fixed patch working for GBDP which
>>>>>>>> shows the appropriate graphs.
>>>>>>>> In this fix, we toke out the changes to diver/psycopg2 and
>>>>>>>> implemented the greenplum version checking process in the ppas way
>>>>>>>> mentioned by Dave Cramer.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Teng Zhang & Hao Wang
>>>>>>>>
>>>>>>>> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
>>>>>>>> ashesh.va...@enterprisedb.com> wrote:
>>>>>>>>
>>>>>>>>> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page <dp...@pgadmin.org>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Ashesh, do you have a recommended way to do this?
>>>>>>>>>>
>>>>>>>>>> I haven't looked at the patch, but I assume it adds a database
>>>&

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Akshay Joshi]

Thanks patch applied. I haven't tested it on GPDB.

On Fri, Aug 25, 2017 at 4:55 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com
> wrote:

> On Fri, Aug 25, 2017 at 4:53 PM, Dave Cramer <davecra...@gmail.com> wrote:
>
>> I'm suggesting that it be pushed
>>
> Akshay is already on to it, and currently reviewing it.
> Will push it once get the confirmation.
>
> -- Thanks, Ashesh
>
>>
>> Dave Cramer
>>
>> On 24 August 2017 at 23:00, Teng Zhang <tezh...@pivotal.io> wrote:
>>
>>> Sure, you can get as much as you like.
>>> Thanks
>>>
>>> -- Forwarded message --
>>> From: Dave Cramer <davecra...@gmail.com>
>>> Date: Thu, Aug 24, 2017 at 8:34 PM
>>> Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard
>>> display
>>> To: Teng Zhang <tezh...@pivotal.io>
>>> Cc: Ashesh Vashi <ashesh.va...@enterprisedb.com>, pgadmin-hackers <
>>> pgadmin-hack...@postgresql.org>, Dave Page <dp...@pgadmin.org>, Jing Li
>>> <jin...@pivotal.io>
>>>
>>>
>>> Can we get some movement on this patch? This seems like a more sane way
>>> to go to support different "products"
>>>
>>> Dave Cramer
>>>
>>> On 22 August 2017 at 16:56, Dave Cramer <davecra...@gmail.com> wrote:
>>>
>>>>
>>>> On 22 August 2017 at 16:41, Dave Cramer <davecra...@gmail.com> wrote:
>>>>
>>>>> Ok,
>>>>>
>>>>> Surely this :
>>>>>
>>>>> self.table_template_path = 'table/sql/' + (
>>>>> +'#{0}#{1}#'.format(server_type, ver)
>>>>> +if server_type == 'gpdb' else
>>>>> +'#{0}#'.format(ver)
>>>>> +)
>>>>>
>>>>> could be written in a more readable manner ??
>>>>>
>>>>>
>>>>>
>>>> Apologies, after reading a bit, this is apparently idiomatic python.
>>>>
>>>> Please ignore
>>>>
>>>>
>>>>> Dave Cramer
>>>>>
>>>>> On 22 August 2017 at 14:25, Dave Cramer <davecra...@gmail.com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I've been able to get back to this and test it. So far so good. It
>>>>>> applies more or less cleanly against 1.6 and everything I've tried so far
>>>>>> works
>>>>>>
>>>>>> I'll update more as I test it.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> Dave Cramer
>>>>>>
>>>>>> On 21 August 2017 at 05:29, Teng Zhang <tezh...@pivotal.io> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Thanks for the review, here is a fixed patch working for GBDP which
>>>>>>> shows the appropriate graphs.
>>>>>>> In this fix, we toke out the changes to diver/psycopg2 and
>>>>>>> implemented the greenplum version checking process in the ppas way
>>>>>>> mentioned by Dave Cramer.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Teng Zhang & Hao Wang
>>>>>>>
>>>>>>> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
>>>>>>> ashesh.va...@enterprisedb.com> wrote:
>>>>>>>
>>>>>>>> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page <dp...@pgadmin.org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Ashesh, do you have a recommended way to do this?
>>>>>>>>>
>>>>>>>>> I haven't looked at the patch, but I assume it adds a database
>>>>>>>>> driver module for GPDB?
>>>>>>>>>
>>>>>>>> I have not looked at the patch yet.
>>>>>>>> I will take a look at it.
>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>> Thanks & Regards,
>>>>>>>>
>>>>>>>> Ashesh Vashi
>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>>>> <http://www.enterprisedb.com/>
>>>>>>>>
>

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Dave Cramer]

I'm suggesting that it be pushed

Dave Cramer

On 24 August 2017 at 23:00, Teng Zhang <tezh...@pivotal.io> wrote:

> Sure, you can get as much as you like.
> Thanks
>
> -- Forwarded message --
> From: Dave Cramer <davecra...@gmail.com>
> Date: Thu, Aug 24, 2017 at 8:34 PM
> Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display
> To: Teng Zhang <tezh...@pivotal.io>
> Cc: Ashesh Vashi <ashesh.va...@enterprisedb.com>, pgadmin-hackers <
> pgadmin-hack...@postgresql.org>, Dave Page <dp...@pgadmin.org>, Jing Li <
> jin...@pivotal.io>
>
>
> Can we get some movement on this patch? This seems like a more sane way to
> go to support different "products"
>
> Dave Cramer
>
> On 22 August 2017 at 16:56, Dave Cramer <davecra...@gmail.com> wrote:
>
>>
>> On 22 August 2017 at 16:41, Dave Cramer <davecra...@gmail.com> wrote:
>>
>>> Ok,
>>>
>>> Surely this :
>>>
>>> self.table_template_path = 'table/sql/' + (
>>> +'#{0}#{1}#'.format(server_type, ver)
>>> +if server_type == 'gpdb' else
>>> +'#{0}#'.format(ver)
>>> +)
>>>
>>> could be written in a more readable manner ??
>>>
>>>
>>>
>> Apologies, after reading a bit, this is apparently idiomatic python.
>>
>> Please ignore
>>
>>
>>> Dave Cramer
>>>
>>> On 22 August 2017 at 14:25, Dave Cramer <davecra...@gmail.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I've been able to get back to this and test it. So far so good. It
>>>> applies more or less cleanly against 1.6 and everything I've tried so far
>>>> works
>>>>
>>>> I'll update more as I test it.
>>>>
>>>> Thanks
>>>>
>>>> Dave Cramer
>>>>
>>>> On 21 August 2017 at 05:29, Teng Zhang <tezh...@pivotal.io> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Thanks for the review, here is a fixed patch working for GBDP which
>>>>> shows the appropriate graphs.
>>>>> In this fix, we toke out the changes to diver/psycopg2 and
>>>>> implemented the greenplum version checking process in the ppas way
>>>>> mentioned by Dave Cramer.
>>>>>
>>>>> Regards,
>>>>> Teng Zhang & Hao Wang
>>>>>
>>>>> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
>>>>> ashesh.va...@enterprisedb.com> wrote:
>>>>>
>>>>>> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>>>
>>>>>>> Ashesh, do you have a recommended way to do this?
>>>>>>>
>>>>>>> I haven't looked at the patch, but I assume it adds a database
>>>>>>> driver module for GPDB?
>>>>>>>
>>>>>> I have not looked at the patch yet.
>>>>>> I will take a look at it.
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Thanks & Regards,
>>>>>>
>>>>>> Ashesh Vashi
>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>> <http://www.enterprisedb.com/>
>>>>>>
>>>>>>
>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>>>
>>>>>>>
>>>>>>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li <jin...@pivotal.io> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> Since we're hoping to get this change working for GPDB we've
>>>>>>>> currently using this method to detect if it's gpdb and show the 
>>>>>>>> appropriate
>>>>>>>> graphs. Right now it displays errors on the dashboard if it's 
>>>>>>>> connected to
>>>>>>>> a gpdb server.
>>>>>>>> For this patch specifically, the goal is to improve the experience
>>>>>>>> for greenplum users so they can get the same information as someone
>>>>>>>> connected to a postgres server.
>>>>>>>>
>>>>>>>> I

Fwd: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Teng Zhang]

Sure, you can get as much as you like.
Thanks

-- Forwarded message --
From: Dave Cramer <davecra...@gmail.com>
Date: Thu, Aug 24, 2017 at 8:34 PM
Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display
To: Teng Zhang <tezh...@pivotal.io>
Cc: Ashesh Vashi <ashesh.va...@enterprisedb.com>, pgadmin-hackers <
pgadmin-hack...@postgresql.org>, Dave Page <dp...@pgadmin.org>, Jing Li <
jin...@pivotal.io>


Can we get some movement on this patch? This seems like a more sane way to
go to support different "products"

Dave Cramer

On 22 August 2017 at 16:56, Dave Cramer <davecra...@gmail.com> wrote:

>
> On 22 August 2017 at 16:41, Dave Cramer <davecra...@gmail.com> wrote:
>
>> Ok,
>>
>> Surely this :
>>
>> self.table_template_path = 'table/sql/' + (
>> +'#{0}#{1}#'.format(server_type, ver)
>> +if server_type == 'gpdb' else
>> +'#{0}#'.format(ver)
>> +)
>>
>> could be written in a more readable manner ??
>>
>>
>>
> Apologies, after reading a bit, this is apparently idiomatic python.
>
> Please ignore
>
>
>> Dave Cramer
>>
>> On 22 August 2017 at 14:25, Dave Cramer <davecra...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> I've been able to get back to this and test it. So far so good. It
>>> applies more or less cleanly against 1.6 and everything I've tried so far
>>> works
>>>
>>> I'll update more as I test it.
>>>
>>> Thanks
>>>
>>> Dave Cramer
>>>
>>> On 21 August 2017 at 05:29, Teng Zhang <tezh...@pivotal.io> wrote:
>>>
>>>> Hi,
>>>>
>>>> Thanks for the review, here is a fixed patch working for GBDP which
>>>> shows the appropriate graphs.
>>>> In this fix, we toke out the changes to diver/psycopg2 and
>>>> implemented the greenplum version checking process in the ppas way
>>>> mentioned by Dave Cramer.
>>>>
>>>> Regards,
>>>> Teng Zhang & Hao Wang
>>>>
>>>> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
>>>> ashesh.va...@enterprisedb.com> wrote:
>>>>
>>>>> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>>
>>>>>> Ashesh, do you have a recommended way to do this?
>>>>>>
>>>>>> I haven't looked at the patch, but I assume it adds a database driver
>>>>>> module for GPDB?
>>>>>>
>>>>> I have not looked at the patch yet.
>>>>> I will take a look at it.
>>>>>
>>>>> --
>>>>>
>>>>> Thanks & Regards,
>>>>>
>>>>> Ashesh Vashi
>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>> <http://www.enterprisedb.com/>
>>>>>
>>>>>
>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>>
>>>>>>
>>>>>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li <jin...@pivotal.io> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> Since we're hoping to get this change working for GPDB we've
>>>>>>> currently using this method to detect if it's gpdb and show the 
>>>>>>> appropriate
>>>>>>> graphs. Right now it displays errors on the dashboard if it's connected 
>>>>>>> to
>>>>>>> a gpdb server.
>>>>>>> For this patch specifically, the goal is to improve the experience
>>>>>>> for greenplum users so they can get the same information as someone
>>>>>>> connected to a postgres server.
>>>>>>>
>>>>>>> I do agree that this is a bigger discussion about how we handle
>>>>>>> behavior change overall if it's regular postgres or something else. 
>>>>>>> Let's
>>>>>>> talk about how we can restructure this behavior in a wider context. Are 
>>>>>>> you
>>>>>>> open to meeting about it?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> ~Jing
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi Violet.
>>>>>>>>
>>>>>>>> I don't really like the way this has been implemented. It adds a
>>>>>>>> variable which is only used for gpdb.
>>>>>>>>
>>>>>>>> There are other places in the code where the behaviour is changed
>>>>>>>> if the server is ppas or regular postgres.
>>>>>>>>
>>>>>>>> Candidly I think all of this needs restructuring.
>>>>>>>>
>>>>>>>> Dave Cramer
>>>>>>>>
>>>>>>>> On 15 August 2017 at 23:29, Violet Cheng <vch...@pivotal.io> wrote:
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Any comment on this patch? If no, will it be committed soon?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Violet
>>>>>>>>
>>>>>>>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <smcal...@pivotal.io
>>>>>>>> > wrote:
>>>>>>>>
>>>>>>>> Hi Hackers!
>>>>>>>>
>>>>>>>> This patch enables Greenplum users to see the same charts on the
>>>>>>>> dashboard as postgres users. It also adds some additional information 
>>>>>>>> to
>>>>>>>> the DDL that is Greenplum specific and necessary to create a new table.
>>>>>>>>
>>>>>>>> Thanks!
>>>>>>>> Sarah
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Dave Cramer]

On 22 August 2017 at 16:41, Dave Cramer  wrote:

> Ok,
>
> Surely this :
>
> self.table_template_path = 'table/sql/' + (
> +'#{0}#{1}#'.format(server_type, ver)
> +if server_type == 'gpdb' else
> +'#{0}#'.format(ver)
> +)
>
> could be written in a more readable manner ??
>
>
>
Apologies, after reading a bit, this is apparently idiomatic python.

Please ignore


> Dave Cramer
>
> On 22 August 2017 at 14:25, Dave Cramer  wrote:
>
>> Hi,
>>
>> I've been able to get back to this and test it. So far so good. It
>> applies more or less cleanly against 1.6 and everything I've tried so far
>> works
>>
>> I'll update more as I test it.
>>
>> Thanks
>>
>> Dave Cramer
>>
>> On 21 August 2017 at 05:29, Teng Zhang  wrote:
>>
>>> Hi,
>>>
>>> Thanks for the review, here is a fixed patch working for GBDP which
>>> shows the appropriate graphs.
>>> In this fix, we toke out the changes to diver/psycopg2 and
>>> implemented the greenplum version checking process in the ppas way
>>> mentioned by Dave Cramer.
>>>
>>> Regards,
>>> Teng Zhang & Hao Wang
>>>
>>> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 On Mon, Aug 21, 2017 at 1:23 PM, Dave Page  wrote:

> Ashesh, do you have a recommended way to do this?
>
> I haven't looked at the patch, but I assume it adds a database driver
> module for GPDB?
>
 I have not looked at the patch yet.
 I will take a look at it.

 --

 Thanks & Regards,

 Ashesh Vashi
 EnterpriseDB INDIA: Enterprise PostgreSQL Company
 


 *http://www.linkedin.com/in/asheshvashi*
 

>
> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:
>
>> Hi Dave,
>>
>> Since we're hoping to get this change working for GPDB we've
>> currently using this method to detect if it's gpdb and show the 
>> appropriate
>> graphs. Right now it displays errors on the dashboard if it's connected 
>> to
>> a gpdb server.
>> For this patch specifically, the goal is to improve the experience
>> for greenplum users so they can get the same information as someone
>> connected to a postgres server.
>>
>> I do agree that this is a bigger discussion about how we handle
>> behavior change overall if it's regular postgres or something else. Let's
>> talk about how we can restructure this behavior in a wider context. Are 
>> you
>> open to meeting about it?
>>
>> Thanks,
>> ~Jing
>>
>>
>>
>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:
>>
>>> Hi Violet.
>>>
>>> I don't really like the way this has been implemented. It adds a
>>> variable which is only used for gpdb.
>>>
>>> There are other places in the code where the behaviour is changed if
>>> the server is ppas or regular postgres.
>>>
>>> Candidly I think all of this needs restructuring.
>>>
>>> Dave Cramer
>>>
>>> On 15 August 2017 at 23:29, Violet Cheng  wrote:
>>>
>>> Hi,
>>>
>>> Any comment on this patch? If no, will it be committed soon?
>>>
>>> Thanks,
>>> Violet
>>>
>>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
>>> wrote:
>>>
>>> Hi Hackers!
>>>
>>> This patch enables Greenplum users to see the same charts on the
>>> dashboard as postgres users. It also adds some additional information to
>>> the DDL that is Greenplum specific and necessary to create a new table.
>>>
>>> Thanks!
>>> Sarah
>>>
>>>
>>>
>>>
>>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>
>

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Dave Cramer]

Ok,

Surely this :

self.table_template_path = 'table/sql/' + (
+'#{0}#{1}#'.format(server_type, ver)
+if server_type == 'gpdb' else
+'#{0}#'.format(ver)
+)

could be written in a more readable manner ??


Dave Cramer

On 22 August 2017 at 14:25, Dave Cramer  wrote:

> Hi,
>
> I've been able to get back to this and test it. So far so good. It applies
> more or less cleanly against 1.6 and everything I've tried so far works
>
> I'll update more as I test it.
>
> Thanks
>
> Dave Cramer
>
> On 21 August 2017 at 05:29, Teng Zhang  wrote:
>
>> Hi,
>>
>> Thanks for the review, here is a fixed patch working for GBDP which shows
>> the appropriate graphs.
>> In this fix, we toke out the changes to diver/psycopg2 and
>> implemented the greenplum version checking process in the ppas way
>> mentioned by Dave Cramer.
>>
>> Regards,
>> Teng Zhang & Hao Wang
>>
>> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page  wrote:
>>>
 Ashesh, do you have a recommended way to do this?

 I haven't looked at the patch, but I assume it adds a database driver
 module for GPDB?

>>> I have not looked at the patch yet.
>>> I will take a look at it.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> 
>>>

 On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:

> Hi Dave,
>
> Since we're hoping to get this change working for GPDB we've currently
> using this method to detect if it's gpdb and show the appropriate graphs.
> Right now it displays errors on the dashboard if it's connected to a gpdb
> server.
> For this patch specifically, the goal is to improve the experience for
> greenplum users so they can get the same information as someone connected
> to a postgres server.
>
> I do agree that this is a bigger discussion about how we handle
> behavior change overall if it's regular postgres or something else. Let's
> talk about how we can restructure this behavior in a wider context. Are 
> you
> open to meeting about it?
>
> Thanks,
> ~Jing
>
>
>
> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:
>
>> Hi Violet.
>>
>> I don't really like the way this has been implemented. It adds a
>> variable which is only used for gpdb.
>>
>> There are other places in the code where the behaviour is changed if
>> the server is ppas or regular postgres.
>>
>> Candidly I think all of this needs restructuring.
>>
>> Dave Cramer
>>
>> On 15 August 2017 at 23:29, Violet Cheng  wrote:
>>
>> Hi,
>>
>> Any comment on this patch? If no, will it be committed soon?
>>
>> Thanks,
>> Violet
>>
>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
>> wrote:
>>
>> Hi Hackers!
>>
>> This patch enables Greenplum users to see the same charts on the
>> dashboard as postgres users. It also adds some additional information to
>> the DDL that is Greenplum specific and necessary to create a new table.
>>
>> Thanks!
>> Sarah
>>
>>
>>
>>
>>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Dave Cramer]

Hi,

I've been able to get back to this and test it. So far so good. It applies
more or less cleanly against 1.6 and everything I've tried so far works

I'll update more as I test it.

Thanks

Dave Cramer

On 21 August 2017 at 05:29, Teng Zhang  wrote:

> Hi,
>
> Thanks for the review, here is a fixed patch working for GBDP which shows
> the appropriate graphs.
> In this fix, we toke out the changes to diver/psycopg2 and implemented the
> greenplum version checking process in the ppas way mentioned by Dave
> Cramer.
>
> Regards,
> Teng Zhang & Hao Wang
>
> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page  wrote:
>>
>>> Ashesh, do you have a recommended way to do this?
>>>
>>> I haven't looked at the patch, but I assume it adds a database driver
>>> module for GPDB?
>>>
>> I have not looked at the patch yet.
>> I will take a look at it.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
>>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:
>>>
 Hi Dave,

 Since we're hoping to get this change working for GPDB we've currently
 using this method to detect if it's gpdb and show the appropriate graphs.
 Right now it displays errors on the dashboard if it's connected to a gpdb
 server.
 For this patch specifically, the goal is to improve the experience for
 greenplum users so they can get the same information as someone connected
 to a postgres server.

 I do agree that this is a bigger discussion about how we handle
 behavior change overall if it's regular postgres or something else. Let's
 talk about how we can restructure this behavior in a wider context. Are you
 open to meeting about it?

 Thanks,
 ~Jing



 On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:

> Hi Violet.
>
> I don't really like the way this has been implemented. It adds a
> variable which is only used for gpdb.
>
> There are other places in the code where the behaviour is changed if
> the server is ppas or regular postgres.
>
> Candidly I think all of this needs restructuring.
>
> Dave Cramer
>
> On 15 August 2017 at 23:29, Violet Cheng  wrote:
>
> Hi,
>
> Any comment on this patch? If no, will it be committed soon?
>
> Thanks,
> Violet
>
> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
> wrote:
>
> Hi Hackers!
>
> This patch enables Greenplum users to see the same charts on the
> dashboard as postgres users. It also adds some additional information to
> the DDL that is Greenplum specific and necessary to create a new table.
>
> Thanks!
> Sarah
>
>
>
>
>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Teng Zhang]

Hi,

Thanks for the review, here is a fixed patch working for GBDP which shows
the appropriate graphs.
In this fix, we toke out the changes to diver/psycopg2 and implemented the
greenplum version checking process in the ppas way mentioned by Dave Cramer.

Regards,
Teng Zhang & Hao Wang

On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi  wrote:

> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page  wrote:
>
>> Ashesh, do you have a recommended way to do this?
>>
>> I haven't looked at the patch, but I assume it adds a database driver
>> module for GPDB?
>>
> I have not looked at the patch yet.
> I will take a look at it.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:
>>
>>> Hi Dave,
>>>
>>> Since we're hoping to get this change working for GPDB we've currently
>>> using this method to detect if it's gpdb and show the appropriate graphs.
>>> Right now it displays errors on the dashboard if it's connected to a gpdb
>>> server.
>>> For this patch specifically, the goal is to improve the experience for
>>> greenplum users so they can get the same information as someone connected
>>> to a postgres server.
>>>
>>> I do agree that this is a bigger discussion about how we handle behavior
>>> change overall if it's regular postgres or something else. Let's talk about
>>> how we can restructure this behavior in a wider context. Are you open to
>>> meeting about it?
>>>
>>> Thanks,
>>> ~Jing
>>>
>>>
>>>
>>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:
>>>
 Hi Violet.

 I don't really like the way this has been implemented. It adds a
 variable which is only used for gpdb.

 There are other places in the code where the behaviour is changed if
 the server is ppas or regular postgres.

 Candidly I think all of this needs restructuring.

 Dave Cramer

 On 15 August 2017 at 23:29, Violet Cheng  wrote:

 Hi,

 Any comment on this patch? If no, will it be committed soon?

 Thanks,
 Violet

 On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
 wrote:

 Hi Hackers!

 This patch enables Greenplum users to see the same charts on the
 dashboard as postgres users. It also adds some additional information to
 the DDL that is Greenplum specific and necessary to create a new table.

 Thanks!
 Sarah





>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
diff --git a/web/config.py b/web/config.py
index f4609e4e..90dd4ded 100644
--- a/web/config.py
+++ b/web/config.py
@@ -299,7 +299,8 @@ STORAGE_DIR = os.path.join(DATA_DIR, 'storage')
 ##
 DEFAULT_BINARY_PATHS = {
 "pg":   "",
-"ppas": ""
+"ppas": "",
+"gpdb": ""
 }
 
 ##
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql
new file mode 100644
index ..9bcfd598
--- /dev/null
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql
@@ -0,0 +1,168 @@
+{% import 'macros/schemas/security.macros' as SECLABEL %}
+{% import 'macros/schemas/privilege.macros' as PRIVILEGE %}
+{% import 'macros/variable.macros' as VARIABLE %}
+{% import 'column/macros/security.macros' as COLUMN_SECLABEL %}
+{% import 'column/macros/privilege.macros' as COLUMN_PRIVILEGE %}
+{% import 'table/sql/macros/constraints.macro' as CONSTRAINTS %}
+{% import 'type/macros/get_full_type_sql_format.macros' as GET_TYPE %}
+{#===#}
+{#== MAIN TABLE TEMPLATE STARTS HERE ==#}
+{#===#}
+{#
+ If user has not provided any details but only name then
+ add empty bracket with table name
+#}
+{% set empty_bracket = ""%}
+{% if data.coll_inherits|length == 0 and  data.columns|length == 0 and not 
data.typname and not data.like_relation and data.primary_key|length == 0 and 
data.unique_constraint|length == 0 and data.foreign_key|length == 0 and 
data.check_constraint|length == 0 and data.exclude_constraint|length == 0 %}
+{% set empty_bracket = "\n(\n)"%}
+{% endif %}
+CREATE {% if data.relpersistence %}UNLOGGED {% endif %}TABLE 
{{conn|qtIdent(data.schema, data.name)}}{{empty_bracket}}
+{% if data.typname %}
+OF {{ 

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Ashesh Vashi]

On Mon, Aug 21, 2017 at 1:23 PM, Dave Page  wrote:

> Ashesh, do you have a recommended way to do this?
>
> I haven't looked at the patch, but I assume it adds a database driver
> module for GPDB?
>
I have not looked at the patch yet.
I will take a look at it.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:
>
>> Hi Dave,
>>
>> Since we're hoping to get this change working for GPDB we've currently
>> using this method to detect if it's gpdb and show the appropriate graphs.
>> Right now it displays errors on the dashboard if it's connected to a gpdb
>> server.
>> For this patch specifically, the goal is to improve the experience for
>> greenplum users so they can get the same information as someone connected
>> to a postgres server.
>>
>> I do agree that this is a bigger discussion about how we handle behavior
>> change overall if it's regular postgres or something else. Let's talk about
>> how we can restructure this behavior in a wider context. Are you open to
>> meeting about it?
>>
>> Thanks,
>> ~Jing
>>
>>
>>
>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:
>>
>>> Hi Violet.
>>>
>>> I don't really like the way this has been implemented. It adds a
>>> variable which is only used for gpdb.
>>>
>>> There are other places in the code where the behaviour is changed if the
>>> server is ppas or regular postgres.
>>>
>>> Candidly I think all of this needs restructuring.
>>>
>>> Dave Cramer
>>>
>>> On 15 August 2017 at 23:29, Violet Cheng  wrote:
>>>
>>> Hi,
>>>
>>> Any comment on this patch? If no, will it be committed soon?
>>>
>>> Thanks,
>>> Violet
>>>
>>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
>>> wrote:
>>>
>>> Hi Hackers!
>>>
>>> This patch enables Greenplum users to see the same charts on the
>>> dashboard as postgres users. It also adds some additional information to
>>> the DDL that is Greenplum specific and necessary to create a new table.
>>>
>>> Thanks!
>>> Sarah
>>>
>>>
>>>
>>>
>>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Dave Page]

Ashesh, do you have a recommended way to do this?

I haven't looked at the patch, but I assume it adds a database driver
module for GPDB?

On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:

> Hi Dave,
>
> Since we're hoping to get this change working for GPDB we've currently
> using this method to detect if it's gpdb and show the appropriate graphs.
> Right now it displays errors on the dashboard if it's connected to a gpdb
> server.
> For this patch specifically, the goal is to improve the experience for
> greenplum users so they can get the same information as someone connected
> to a postgres server.
>
> I do agree that this is a bigger discussion about how we handle behavior
> change overall if it's regular postgres or something else. Let's talk about
> how we can restructure this behavior in a wider context. Are you open to
> meeting about it?
>
> Thanks,
> ~Jing
>
>
>
> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:
>
>> Hi Violet.
>>
>> I don't really like the way this has been implemented. It adds a variable
>> which is only used for gpdb.
>>
>> There are other places in the code where the behaviour is changed if the
>> server is ppas or regular postgres.
>>
>> Candidly I think all of this needs restructuring.
>>
>> Dave Cramer
>>
>> On 15 August 2017 at 23:29, Violet Cheng  wrote:
>>
>> Hi,
>>
>> Any comment on this patch? If no, will it be committed soon?
>>
>> Thanks,
>> Violet
>>
>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
>> wrote:
>>
>> Hi Hackers!
>>
>> This patch enables Greenplum users to see the same charts on the
>> dashboard as postgres users. It also adds some additional information to
>> the DDL that is Greenplum specific and necessary to create a new table.
>>
>> Thanks!
>> Sarah
>>
>>
>>
>>
>>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Jing Li]

Hi Dave,
Since we're hoping to get this change working for GPDB we've currently using
this method to detect if it's gpdb and show the appropriate graphs. Right now it
displays errors on the dashboard if it's connected to a gpdb server.For this
patch specifically, the goal is to improve the experience for greenplum users so
they can get the same information as someone connected to a postgres server.
I do agree that this is a bigger discussion about how we handle behavior change
overall if it's regular postgres or something else. Let's talk about how we can
restructure this behavior in a wider context. Are you open to meeting about it?
Thanks,~Jing  






On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com  wrote:
Hi Violet.
I don't really like the way this has been implemented. It adds a variable which
is only used for gpdb.
There are other places in the code where the behaviour is changed if the server
is ppas or regular postgres.
Candidly I think all of this needs restructuring.
Dave Cramer  
On 15 August 2017 at 23:29, Violet Cheng   wrote:

Hi,
Any comment on this patch? If no, will it be committed soon?
Thanks,Violet
On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear   wrote:
Hi Hackers!

This patch enables Greenplum users to see the same charts on the dashboard as
postgres users. It also adds some additional information to the DDL that is
Greenplum specific and necessary to create a new table.
Thanks!
Sarah

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Dave Cramer]

Hi Violet.

I don't really like the way this has been implemented. It adds a variable
which is only used for gpdb.

There are other places in the code where the behaviour is changed if the
server is ppas or regular postgres.

Candidly I think all of this needs restructuring.

Dave Cramer

On 15 August 2017 at 23:29, Violet Cheng  wrote:

> Hi,
>
> Any comment on this patch? If no, will it be committed soon?
>
> Thanks,
> Violet
>
> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
> wrote:
>
>> Hi Hackers!
>>
>> This patch enables Greenplum users to see the same charts on the
>> dashboard as postgres users. It also adds some additional information to
>> the DDL that is Greenplum specific and necessary to create a new table.
>>
>> Thanks!
>> Sarah
>>
>>
>>
>