Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

Hi Dave, > On 01-Jun-2016, at 12:03 am, Ashesh Vashi > wrote: > > On Tue, May 31, 2016 at 11:56 PM, Dave Page > wrote: > > On 31 May 2016, at 19:08, Ashesh Vashi

[pgadmin-hackers] Regarding issue 1241

Hi Dave, Regarding Issue 1241 : We have added header section for parameter tab deliberately so that we can force user to select parameter name (and therefore parameter's data type) before adding new row. This is required because behavior of second cell

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

On Tue, May 31, 2016 at 11:56 PM, Dave Page wrote: > > On 31 May 2016, at 19:08, Ashesh Vashi > wrote: > > On Tue, May 31, 2016 at 8:28 PM, Dave Page wrote: > > Hi >> >> On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala >>

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

> On 31 May 2016, at 19:08, Ashesh Vashi wrote: > >> On Tue, May 31, 2016 at 8:28 PM, Dave Page wrote: > >> Hi >> >> On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala >> wrote: >> > Hi, >> > >> > As

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

On Tue, May 31, 2016 at 8:28 PM, Dave Page wrote: > Hi > > On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala > wrote: > > Hi, > > > > As advised by Ashesh, I have tried flask 'threaded' options for this > issues > > & it fixed the issue. >

[pgadmin-hackers] pgAdmin 4 commit: Fixed a typo in Type node javascript module.

Fixed a typo in Type node javascript module. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4482bbb1ba6a86c1330d341d1124df4771ba232e Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: Minor patch to fix typo in Type node

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, May 31, 2016 at 2:56 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1278 - Load the foreign server node javascript

Fixes #1278 - Load the foreign server node javascript module when databases (not when servers) are being loaded. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4d195aafe40a1f027eb66903a5e5d09ca92cea8 Author: Khushboo Vashi

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Dave, On Tue, May 31, 2016 at 9:29 PM, Dave Page wrote: > Hi, > > On the first run, I get: > > App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin > 4.app > ./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory > Cleaning up > Copying

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi, On the first run, I get: App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin 4.app ./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory Cleaning up Copying data into temporary directory cp: ./../mac-build/pgAdmin 4.app: No such file or directory

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

Hi On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala wrote: > Hi, > > As advised by Ashesh, I have tried flask 'threaded' options for this issues > & it fixed the issue. > > PFA patches to fix long load delay when expanding server if server is > inaccessible.

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Oh - in addition, pgadmin4.db is being shipped. On Tue, May 31, 2016 at 3:04 PM, Dave Page wrote: > Hi > > This still doesn't build for me: > > > make x86 > ... > ... > > Generating Code... > link /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO > /SUBSYSTEM:WINDOWS

[pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

Hi, As advised by Ashesh, I have tried flask 'threaded' options for this issues & it fixed the issue. PFA patches to fix long load delay when expanding server if server is inaccessible. (RM#1185). -- Additional patches to enhance misc validations in menu.js/schema.js/dashboard.js. (There

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Hi This still doesn't build for me: > make x86 ... ... Generating Code... link /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO /SUBSYSTEM:WINDOWS "/MANIFESTDEPENDENCY:type='win32' name='M icrosoft.Windows.Common-Controls' version='6.0.0.0' publicKeyToken='6595b64144ccf1df' language='*'

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Somehow the patch skipped the Makefile changes. Attached is the updated patch. On Mon, May 30, 2016 at 6:00 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Thanks. I have fixed all the issues. > > Regarding the app not running from within the DMG for the first time, I > was

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Tue, May 31, 2016 at 2:45 PM, Dave Page wrote: > > > On Tue, May 31, 2016 at 9:52 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> >> >> On Tue, May 31, 2016 at 1:26 PM, Dave Page wrote: >> >>> Yeah, I was about to reply on this too;

Re: [pgadmin-hackers] PATCH:Treeview item sorting (pgAdmin4)

Hi, PFA patch to add server & client side sorting of nodes when node is renamed or newly added in tree. Bug #1244 *TODO://* Need a way to handle a case on client side when in object is moved out of collection. *[ For time being, I've included workaround that we will close the tree * *till

Re: [pgadmin-hackers] PATCH: Minor patch to fix typo in Type node

++ Patch Attached -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 31, 2016 at 2:55 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Last commit (Link >

[pgadmin-hackers] PATCH: Minor patch to fix typo in Type node

Hi, Last commit (Link ) introduced a typo in code due to which we are not able to open dialog, PFA fix for the same. (RM#1271) -- Regards, Murtuza Zabuawala EnterpriseDB:

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Tue, May 31, 2016 at 9:52 AM, Ashesh Vashi wrote: > > > > On Tue, May 31, 2016 at 1:26 PM, Dave Page wrote: > >> Yeah, I was about to reply on this too; >> >> - Why do we need Marshmallow? >> >> - Why do we need a role system? Perhaps in the

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Tue, May 31, 2016 at 1:26 PM, Dave Page wrote: > Yeah, I was about to reply on this too; > > - Why do we need Marshmallow? > > - Why do we need a role system? Perhaps in the future we might have shared > servers, and roles that cannot modify them, but not now. > Hmm.. He

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Committed - after rebased the patch. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, May 26, 2016 at 4:41 PM, Murtuza Zabuawala <

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

Hi, Please find updated patch with following changes: 1. the sizeHandler is not calculating the position without resizing 2. Apply sizeable columns to history grid in query tool. 3. Table column *Label and Type* should not be in single line. Currently *Backgrid* displays column and type in a

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1262 - Do not allow to delete the default serv

Fixes #1262 - Do not allow to delete the default server group. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=afcb62cfd67ec6c7f9a70a074afb071f5fc50f27 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Yeah, I was about to reply on this too; - Why do we need Marshmallow? - Why do we need a role system? Perhaps in the future we might have shared servers, and roles that cannot modify them, but not now. - Why is the editing not done in-grid? It's only a single line per record. Seems like an

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > PFA comments as below, > > 1) While running setup.py for the first time, We did not

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA updated patch for user management. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Mon, May 30, 2016 at 5:51 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Harshal, > > > Please find the review comments so far: > >

Re: [pgadmin-hackers] PATCH: Do not allow user to delete default server-group

Hi, PFA updated patch I have also included order by when we fetch server-group. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 31, 2016 at 11:35 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com>

[pgadmin-hackers] PATCH: Do not allow user to delete default server-group

Hi, PFA patch to fixed the issue mentioned in RM#1262. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Fixed_ServerGroup_delete_issue.patch Description: Binary data -- Sent via pgadmin-hackers mailing list