Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hello Joao, Thanks for review and suggestions. On Fri, Apr 7, 2017 at 9:08 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > We just looked into this patch and have some questions about it. > > - Where is the JSON file created? Do we need to ca

Re: [pgadmin-hackers][patch] Style updates

Hi On Fri, Apr 7, 2017 at 4:08 PM, Shirley Wang wrote: > Hello > > On Fri, Apr 7, 2017 at 6:04 AM Dave Page wrote: > >> Hi >> >> This introduces a number of display issues for me: >> >> - There are now gaps between the tabs and their content panels. See >> screenshot 1. >> >> > Yes, that gap wi

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hello Hackers, We just looked into this patch and have some questions about it. - Where is the JSON file created? Do we need to call it with some special argument in order for it to be created? - There is a print statement in the line 275 of runtests.py is it supposed to be there? - The function n

[pgadmin-hackers] pgAdmin 4 commit: Adding a delay clearly didn't fix the feature tests :

Adding a delay clearly didn't fix the feature tests :-( Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2c4cb1606713befb897e4ed0e3341a314e4e9b4 Modified Files -- ci/run_python_tests.sh | 2 +- web/regression/fe

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

On Fri, Apr 7, 2017 at 2:49 PM, Atira Odhner wrote: >> The one tweak I made to the patch was to remove the code that disabled >> the Copy button from the top of copy_data.js. I think the button >> should remain enabled to allow the user to copy again, in case they >> use the clipboard for somethin

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi Ashesh! Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work. Thanks! Joao & Sarah On Mon, Apr 3, 2017 at 8:41 AM,

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hi Dave, Please find the revised patch for test result enhancement, which include code to write passed test cases into the JSON file along with skipped and failed. On Tue, Apr 4, 2017 at 11:30 AM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > >

[pgadmin-hackers] pgAdmin 4 commit: Attempt to better catch errors in the CI tests.

Attempt to better catch errors in the CI tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a431937b500f261403dff1c9ca5acdd0c8fa36d6 Modified Files -- ci/build_docs.sh| 4 ++-- ci/build_pip_wheel.sh | 4 ++-- ci/build_

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

The one tweak I made to the patch was to remove the code that disabled > the Copy button from the top of copy_data.js. I think the button > should remain enabled to allow the user to copy again, in case they > use the clipboard for something else and then need to refresh it with > the data. Of cour

[pgadmin-hackers] pgAdmin 4 commit: Add a 0.5 second delay to treeview node expansion in

Add a 0.5 second delay to treeview node expansion in the feature tests, to try to (temporarily) allow for script loading time. Tentatively enable the feature tests in CI to see if it works. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a01c

[pgadmin-hackers] pgAdmin 4 commit: Include an example of running just the feature tests.

Include an example of running just the feature tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de80545400c901e36dcd236c7ecfd4e615ce1192 Modified Files -- web/regression/README | 3 +++ 1 file changed, 3 insertions(+) -- Sen

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

This seems like something we should add 1 or more feature tests for, as it's broken in the past as well. Please look at that. Thanks. On Fri, Apr 7, 2017 at 9:55 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Checking. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: h

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

Hi I was just about to commit this (and was quite please to get it in before next week's release), but unfortunately realised at the last minute that it breaks pasting of rows when the query tool is in edit mode. You should be able to copy 1 or more rows, and then hit the paste button to append th

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

Checking. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Apr 7, 2017 at 2:13 PM, Ashesh Vashi wrote: > Murtuza - please fix it asap. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Compa

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

On Tue, Apr 4, 2017 at 5:37 PM, Matthew Kleiman wrote: > Hi Surinder, > > We looked at your fix for default values in the query tool editor. > > We think the user experience could be further improved by seeing the actual > default value instead of the empty cell. Agreed. > As an intermediate ste

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi On Sat, Apr 1, 2017 at 12:45 PM, Surinder Kumar wrote: > Hi > > Issues fixed: > > 1. If a column is defined with a default modifier, there is now way to > insert the row with those defaults. > The column will be left blank and it will take default value automatically. > > 2. If a column has a

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

Murtuza - please fix it asap. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Apr 7, 2017 at 1:59 PM, Dave Page wrote: > Hmm, I think t

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

Hmm, I think this might have broken adding of new nodes in some cases. I just added two new tables (right-clicking the public schema), and had to refresh the tables node before they showed up. On Fri, Apr 7, 2017 at 4:29 AM, Ashesh Vashi wrote: > Thanks - committed! > > -- > > Thanks & Regards,