Re: [pgadmin-hackers] Patch on roles query for pgAdmin with a Greenplum database

2010-08-04 Thread Chuck McDevitt
A quick test showed no problems for me. > -Original Message- > From: Guillaume Lelarge [mailto:guilla...@lelarge.info] > Sent: Tuesday, August 03, 2010 11:19 PM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Patch on roles query for pgAdmin with a Greenplum data

[pgadmin-hackers] Corrected patch

2010-06-15 Thread Chuck McDevitt
The patch I recently sent it had a problem for PG versions before coerceViaIO existed. This corrects that, and fixes this for PG 8.1, 8.2, and Greenplum Database. patch.diff Description: patch.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to you

[pgadmin-hackers] Patch to frmStatus.cpp

2010-06-10 Thread Chuck McDevitt
This trivial patch fixes two things: 1) Allows this SQL statement to run on Greenplum Database as well as old versions of PostgreSQL. 2) Gets rid of the useless "/32" appended to the client_addr. This is against the trunk version of pgAdmin (1.12) patch.diff Description: patch.diff

[pgadmin-hackers] Bug fix for Greenplum: GPDB release 3.4 column oriented tables

2009-10-06 Thread Chuck McDevitt
Bug fix for Greenplum: GPDB release 3.4 column oriented tables. I originally coded this thinking it was columnstore=true/false, but it turns out it is orientation=row/column. Please apply this fix to pgAdmin greenplum.diff Description: greenplum.diff -- Sent via pgadmin-hackers mailing l

Re: [pgadmin-hackers] reconnecting to DB after connection break

2009-08-21 Thread Chuck McDevitt
> -Original Message- > From: pgadmin-hackers-ow...@postgresql.org [mailto:pgadmin-hackers- > ow...@postgresql.org] On Behalf Of Julius Tuskenis > Sent: Friday, August 21, 2009 3:16 AM > To: pgadmin-hackers@postgresql.org > Subject: [pgadmin-hackers] reconnecting to DB after connection break

[pgadmin-hackers] Patch to add "partition name" to properties display (for GPDB)

2009-07-13 Thread Chuck McDevitt
A minor patch to add the "partition name" to the properties page when viewing partitions of a table. patch.diff Description: patch.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hac

[pgadmin-hackers] last minute one-line patch for GPDB

2009-06-23 Thread Chuck McDevitt
The "View the Data" button on the toolbar doesn't work for GPDB external tables. patch.diff Description: patch.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Patch: Fix bug when using pgAdmin with Greenplum release 3.4

2009-06-19 Thread Chuck McDevitt
This patch fixes a problem when using pgAdmin with the Greenplum database 3.4 release. There was a catalog change on how external tables are identified. The patch allows the code to work with 3.2, 3.3, or 3.4 releases of external tables. patch.diff Description: patch.diff -- Sent via pgadm

Re: [pgadmin-hackers] New patch for bugs in GPDB csv format log handling

2009-06-09 Thread Chuck McDevitt
Forgot to change "Reading log from server." To "Reading log from server..." Here is new diff patch.diff Description: patch.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] New patch for bugs in GPDB csv format log handling

2009-06-08 Thread Chuck McDevitt
Thanks Dave. Some questions: > Hi, > > Some issues with this, 2 minor, one less so: > > - Please rearrange the code in frmStatus.h to remove the class > definition. We try to keep the headers purely for declarations and > only include one-line functions in them. I would suggest a new file in >

Re: [pgadmin-hackers] Supporting CSV format log files

2009-06-06 Thread Chuck McDevitt
> -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Saturday, June 06, 2009 2:29 PM > To: Chuck McDevitt > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] Supporting CSV format log files > > On Fri, Jun 5, 2009 at 8:03 PM

[pgadmin-hackers] Supporting CSV format log files

2009-06-05 Thread Chuck McDevitt
Original Message- > From: pgadmin-hackers-ow...@postgresql.org [mailto:pgadmin-hackers- > ow...@postgresql.org] On Behalf Of Chuck McDevitt > Sent: Thursday, June 04, 2009 7:40 PM > To: pgadmin-hackers@postgresql.org > Subject: [pgadmin-hackers] New patch for bugs in GPDB cs

[pgadmin-hackers] New patch for bugs in GPDB csv format log handling

2009-06-05 Thread Chuck McDevitt
This patch fixes many problems in the handling of GPDB CSV format logs for the frmStatus display. It's also a useful start for supporting PostgreSQL 8.4 CSV format logs. patch.diff Description: patch.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make chang

[pgadmin-hackers] Fix for Status display for Greenplum database.

2009-05-28 Thread Chuck McDevitt
Fix garbled and confusing error log display on status screen for GPDB. patch.diff Description: patch.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Bug fix for Greenplum: Correct how it files the help

2009-05-22 Thread Chuck McDevitt
Two very minor fixes for Greenplum: 1. If html help is available (GPDB 3.3.0 and later), prefer it to the .PDF help. 2. If we can't find local GPDB help, go to Greenplum web site for it. bugfix.diff Description: bugfix.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresq

[pgadmin-hackers] Greenplum patch for beta3

2009-05-02 Thread Chuck McDevitt
This fixes two problems: 1. The new server status display didn't work with Greenplum. 2. The partition display code was not properly showing the hierarchy of partitions if the table had more than one level of partitions. The patch is attached to the e-mail new.diff Description: new.diff

Re: [pgadmin-hackers] Beta 3

2009-05-01 Thread Chuck McDevitt
I have a couple of small ones I was going to send today. > -Original Message- > From: pgadmin-hackers-ow...@postgresql.org [mailto:pgadmin-hackers- > ow...@postgresql.org] On Behalf Of Dave Page > Sent: Friday, May 01, 2009 2:39 AM > To: pgadmin-hackers > Subject: [pgadmin-hackers] Beta 3

[pgadmin-hackers] Greenplum patch for estimated rowcounts being wrong.

2009-04-15 Thread Chuck McDevitt
Greenplum stores the number of rows per segmentDatabase (actually the max of any of the segDBs) in pg_class.reltuples, not the total number of tuples. This causes the stats to display wrong values, and causes pgAdmin to warn that Analyze is needed when it is not. This simple patch multiplies th

Re: [pgadmin-hackers] Minor patch for more GP options.

2009-04-01 Thread Chuck McDevitt
> -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: 2009-04-01 05:13 > To: Chuck McDevitt > Cc: Magnus Hagander; pgadmin-hackers > Subject: Re: [pgadmin-hackers] Minor patch for more GP options. > > On Tue, Mar 31, 2009 at 11:36 PM, Chuck McDe

Re: [pgadmin-hackers] Minor patch for more GP options.

2009-03-31 Thread Chuck McDevitt
What is the schedule for 1.11 ? The 1.10 beta went by so fast most of my users didn't have time to give feedback. > -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: 2009-03-31 00:50 > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re:

[pgadmin-hackers] Minor patch for more GP options.

2009-03-31 Thread Chuck McDevitt
Some minor Greenplum specific stuff. patch.diff Description: patch.diff -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Some notes on pgAdmin

2009-03-10 Thread Chuck McDevitt
I don't think we want to go the pgindent route, but a simple script that takes all files, converts tabs to 4 spaces, and checks back in any changed files, would be a good idea. -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http:/

Re: [pgadmin-hackers] Greenplum patch as a diff file

2009-03-10 Thread Chuck McDevitt
Dave, My apologies for making extra work for you. I've been trying to work on several different projects, all with deadlines happening at nearly the same time, and am still learning the pgAdmin code, so things take me longer than they otherwise would. And our QA team is just getting ready to

Re: [pgadmin-hackers] Some notes on pgAdmin

2009-03-09 Thread Chuck McDevitt
> > Yeah - we generally use 4 spaces, but tabs keep creeping in. I'm > beginning to this we should use tabs instead, and see if we can't run > something akin to pgindent over the code to clean it up nicely. > > What do people prefer - tabs or spaces? I definitely prefer spaces. Too many tools a

Re: [pgadmin-hackers] Greenplum patch for pgAdmin

2009-03-06 Thread Chuck McDevitt
I will work on this over the weekend, and get a new patch to you Monday evening > -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Friday, March 06, 2009 7:08 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Greenplum patch for pgA

Re: [pgadmin-hackers] Greenplum patch for pgAdmin

2009-03-06 Thread Chuck McDevitt
> -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Friday, March 06, 2009 7:08 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Greenplum patch for pgAdmin > > Hi Chuck, > > I've spent the last few hours working on yo

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-03-05 Thread Chuck McDevitt
Sorry... I thought this went out, but I had some e-mail issue. > -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Thursday, March 05, 2009 1:26 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re: pgAdmin for Greenplum database? > >

[pgadmin-hackers] PgAdmin support for Greenplum database

2009-03-02 Thread Chuck McDevitt
I sent in a proposed patch last Friday to include in the beta. So far, no feedback from anyone? Is there a problem with the patch? -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Some notes on pgAdmin

2009-02-27 Thread Chuck McDevitt
1. Going through the code, I noticed that quite a few files use 4 spaces for indent on most of their lines, but have some lines using tab characters. Usually it's newer patches that introduced the tabs, but not always. Mixing both kinds of indents is confusing. 2. Pgadmin3.wxs sh

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-27 Thread Chuck McDevitt
The .xrc and .xpm files > -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Friday, February 27, 2009 2:06 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re: pgAdmin for Greenplum database? > > Hi Chuck, > > Just a quick

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-27 Thread Chuck McDevitt
The .cpp files > -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Friday, February 27, 2009 2:06 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re: pgAdmin for Greenplum database? > > Hi Chuck, > > Just a quick reminde

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-27 Thread Chuck McDevitt
Some notes on the current state of the patch: > > Hi Chuck, > > The patch looks pretty good to me - just a few issues/queries below. > I've only eyeballed it and built it so far though - I'm in the process > of downloading Greenplum so I can test more thoroughly, though it's a > slow download at

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-19 Thread Chuck McDevitt
The .xrc and xpm files > -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Wednesday, February 11, 2009 2:44 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re: pgAdmin for Greenplum database? > > On Tue, Feb 10, 2009 at 8:58 PM,

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-19 Thread Chuck McDevitt
The new cpp files > -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Wednesday, February 11, 2009 2:44 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re: pgAdmin for Greenplum database? > > On Tue, Feb 10, 2009 at 8:58 PM,

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-19 Thread Chuck McDevitt
Here are the new .h files > -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Wednesday, February 11, 2009 2:44 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re: pgAdmin for Greenplum database? > > On Tue, Feb 10, 2009 at 8:58 PM,

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-11 Thread Chuck McDevitt
> -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Wednesday, February 11, 2009 2:44 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re: pgAdmin for Greenplum database? > > On Tue, Feb 10, 2009 at 8:58 PM, Chuck McDevitt > w

Re: [pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-11 Thread Chuck McDevitt
> -Original Message- > From: Dave Page [mailto:dp...@pgadmin.org] > Sent: Tuesday, February 10, 2009 12:39 AM > To: Chuck McDevitt > Cc: pgadmin-hackers > Subject: Re: pgAdmin for Greenplum database? > > On Tue, Feb 10, 2009 at 1:33 AM, Chuck McDevitt > wrot

[pgadmin-hackers] pgAdmin for Greenplum database?

2009-02-09 Thread Chuck McDevitt
I've been working on updating pgAdmin to support the Greenplum database (www.greenplum.com). I'm wondering if the pgAdmin project would want to accept changes to add Greenplum support, or if I should just branch and have my own pgAdmin that is special for Greenplum (gpAdmin ?). I've been makin