Re: [pgadmin-hackers] Migrating this list to PGLister on Friday, June 16th, 1300 UTC

Greetings, again! As an FYI, I am beginning the migration of this list now. You may see emails to this list be paused for a period of time, but none is expected to be lost. Thanks! Stephen * Stephen Frost (sfr...@snowman.net) wrote: > Greetings! > > The PostgreSQL Infrastructure team will be

Re: [pgadmin-hackers] pgAdmin 4 commit: Add support for detachable tabs to the runtime.

Nice! This is awesome. I didn't see it land. -- Rob On Fri, Jun 16, 2017 at 1:57 AM, Dave Page wrote: > Add support for detachable tabs to the runtime. > > This allows the Query Tool, Debugger and web browser tabs to be moved to > different monitors as desired. > > Fixes #1344 > > Branch >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH.

Thanks - patch applied! On Thu, Jun 15, 2017 at 1:24 PM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix #2486: Feature tests use SQLITE_PATH > instead of TEST_SQLITE_PATH. > > While running the feature tests, the separate process of the app does not > honour the config sett

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Dave, Please find attached patch where I have added timeout of 2 seconds before selecting object menu in connect to server function. Note: Apply this patch on top of previous patch for on demand loading feature. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.ent

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

On 05/11/2017 12:54 AM, Devrim Gündüz wrote: > > Hi, > > On Wed, 2017-05-10 at 10:02 -0700, Josh Berkus wrote: >> So to make this work, pgadmin-v1-web needs to be a completely separate >> package, no? > > I don't think so, we can define Requires: part separately. > > Give me some time please, l

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Sounds good, thanks. On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal wrote: > Hi > > On Fri, Jun 16, 2017 at 2:07 AM, Dave Page wrote: >> >> Hi >> >> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal >> wrote: >> > Hi Dave, >> > >> > Please find attached updated patch. >> > >> > On Thu, Jun 15, 2

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi On Fri, Jun 16, 2017 at 2:07 AM, Dave Page wrote: > Hi > > On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal > wrote: > > Hi Dave, > > > > Please find attached updated patch. > > > > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Wed, Jun 14, 2017 at 11:36 PM, Har

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal wrote: > Hi Dave, > > Please find attached updated patch. > > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page wrote: >> >> Hi >> >> On Wed, Jun 14, 2017 at 11:36 PM, Harshal Dhumal >> wrote: >>> >>> Hi Dave, >>> >>> Please find rebased patch for RM2

Re: [pgadmin-hackers][patch] History Detail Pane

Hi We use Qt 5.8 at the moment, with the updated QtWebKit TP5 release from https://github.com/annulen/webkit/releases. The issue occurs on Windows and Mac, and probably Linux as well. Test builds can be found here: https://developer.pgadmin.org/~dpage/debug/ On Thu, Jun 15, 2017 at 2:33 PM, Sara

Re: [pgadmin-hackers] Minor typo in web/config.py

Thanks, patch applied. On Thu, Jun 15, 2017 at 12:24 PM, Johan Van de Wauw wrote: > There is a minor typo in the web/config.py > > patch attached > > Kind Regards, > Johan > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > h

Re: [pgadmin-hackers][patch] History Detail Pane

Hi Dave! Just to verify, which version of QT are you using? The Readme calls for 5.5 at the newest. Could you send us the compiled version of the app? Are you only seeing this on Windows? Thanks, Sarah & Shruti & João On Wed, Jun 14, 2017 at 3:46 PM, Sarah McAlear wrote: > Sounds good! We're l

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

On Thu, Jun 15, 2017 at 4:51 PM, Dave Page wrote: > Thanks, applied. > > When you get some spare time (after the webpacking work that I believe > you're doing), could you please add a feature test (or modify a suitable > existing one) to ensure the various script options work as they should? > ​I

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

Thanks, applied. When you get some spare time (after the webpacking work that I believe you're doing), could you please add a feature test (or modify a suitable existing one) to ensure the various script options work as they should? Thanks again! On Thu, Jun 15, 2017 at 11:55 AM, Surinder Kumar

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

Hi Dave, Please find attached patch. It should work. In previous patch I was unaware that i added untracked file to tracked. On Thu, Jun 15, 2017 at 4:10 PM, Dave Page wrote: > Hi > > Was this patch generated against a WIP branch? I get: > > (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloa

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

Thanks, applied. On Thu, Jun 15, 2017 at 11:47 AM, Murtuza Zabuawala wrote: > HI Dave, > > Please find the patch for the added feature test for handling of RM#1928 > datatype issue, other misc changes are for PEP-8. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

HI Dave, Please find the patch for the added feature test for handling of RM#1928 datatype issue, other misc changes are for PEP-8. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 7:21 PM, Dave Page wrote: > Thank

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Grant wizard

Thanks, applied. On Thu, Jun 15, 2017 at 9:56 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in Grant wizard, In IE browser grant wizard > do not close if user tries to close it by clicking Cancel button or Close > button. > RM#2142 > > -- > Regards, > Murtuza Zabuawala >

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

Hi Was this patch generated against a WIP branch? I get: (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/fix_scripts_in_query_tool.patch error: web/pgadmin/static/js/setup_connection.js: No such file or directory On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar < surinder.ku...@enterprise

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Fri, Jun 9, 2017 at 9:03 AM, Dave Page wrote: > On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear wrote: >>> Thanks. When I run the tests my browser opens in some default size >>> that's always consistent, but doesn't match my normal Chrome sessions, >>> or the 1024x1024 default set in app_starter

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

Hi PFA patch which fixes the issue Harshal reported. Thanks, Surinder On Thu, Jun 15, 2017 at 3:52 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Surinder, > > I guess this broke the script options (Create, Delete, Select, Insert, > Update) > > > VM4124 datagrid.js:440 Uncaught

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

Surinder, I guess this broke the script options (Create, Delete, Select, Insert, Update) VM4124 datagrid.js:440 Uncaught TypeError: self.get_panel_title is not a function at Object.success (VM4124 datagrid.js:440) at fire ( jquery-1.11.2.js:3143) at Object.fireWith [as resolveWith] ( jquery-1.11

Re: [pgadmin-hackers][patch] History Detail Pane

Sounds good! We're looking into it. On Wed, Jun 14, 2017 at 12:15 PM, Robert Eckhardt wrote: > Absolutely makes sense. > > Matt, Sarah, > > Do we understand the issues Dave is mentioning well enough to look into it > and tackle it? > > -- Rob > > On Wed, Jun 14, 2017 at 8:12 AM, Dave Page wrote

Re: [pgadmin-hackers][patch] History Detail Pane

Absolutely makes sense. Matt, Sarah, Do we understand the issues Dave is mentioning well enough to look into it and tackle it? -- Rob On Wed, Jun 14, 2017 at 8:12 AM, Dave Page wrote: > Hi, > > Before I commit anything else for this patch, we need to fix the > existing changes so they work in

Re: [pgadmin-hackers][patch] History Detail Pane

Hi, Before I commit anything else for this patch, we need to fix the existing changes so they work in the desktop runtime (see the previous thread with the patches for the history pane changes). Have any of your team been able to look at that yet? On Wed, Jun 14, 2017 at 4:07 PM, Sarah McAlear w

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On Wed, Jun 14, 2017 at 6:21 PM, Ashesh Vashi wrote: > On Wed, Jun 14, 2017 at 6:19 PM, Dave Page wrote: > >> Hi, >> >> Sorry - it's drifted out again, I suspect because of the work Ashesh >> has been doing. Can you rebase please? Check with Ashesh first though, >> in case he's about ready to co

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On Wed, Jun 14, 2017 at 6:19 PM, Dave Page wrote: > Hi, > > Sorry - it's drifted out again, I suspect because of the work Ashesh > has been doing. Can you rebase please? Check with Ashesh first though, > in case he's about ready to commit another big change. > I am not. :-) -- Thanks & Regards,

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, Sorry - it's drifted out again, I suspect because of the work Ashesh has been doing. Can you rebase please? Check with Ashesh first though, in case he's about ready to commit another big change. Thanks. On Fri, Jun 9, 2017 at 10:08 AM, Harshal Dhumal wrote: > Hi, > > > Please find rebased p

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Wed, Jun 14, 2017 at 1:06 PM, Ashesh Vashi wrote: > On Wed, Jun 14, 2017 at 1:59 PM, Dave Page wrote: > >> >> >> On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> For further implementation following task needs to be work upon: >>>

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Wed, Jun 14, 2017 at 1:59 PM, Dave Page wrote: > > > On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> For further implementation following task needs to be work upon: >> >>- How to parse and show partitions keys. For example user has

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Thanks, patch applied. On Tue, Jun 13, 2017 at 12:30 PM, Surinder Kumar wrote: > Hi > > On Tue, Jun 13, 2017 at 2:54 PM, Dave Page wrote: >> >> On Mon, Jun 12, 2017 at 5:55 PM, Shirley Wang wrote: >> >>> >> >>> >> >>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar >> >>> wrote: >> >>> > Hi >>

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Thanks Surinder. That, along with another fix seems to have got the tests working fully again. On Tue, Jun 13, 2017 at 6:37 PM, Surinder Kumar wrote: > Hi > > PFA patch. > > On Tue, Jun 13, 2017 at 9:54 PM, Dave Page wrote: >> >> Hmm, this seems to have broken the feature tests. Can you look at

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

Thanks, that got it. Applied! On Tue, Jun 13, 2017 at 4:51 PM, Joao Pedro De Almeida Pereira wrote: > Hi Hackers, > > Good catch Dave. > > You can find attached the new diff with the correction of the problem above. > > Thanks > Shruti & Joao > > On Tue, Jun 13, 2017 at 10:35 AM, Dave Page wrote

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi wrote: > Hi All > > For further implementation following task needs to be work upon: > >- How to parse and show partitions keys. For example user has created >below partitioned table > > CREATE TABLE public.sales > ( > country character va

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

On Tue, Jun 13, 2017 at 11:24 PM, Shirley Wang wrote: > > > On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: >> >>> Awesome!! This is super helpful :) >>> >>> Does this affect a new query window

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: > >> Awesome!! This is super helpful :) >> >> Does this affect a new query window (currently the title is 'Query - >> untitled')? >> > ​Yes, in this ca

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: > Awesome!! This is super helpful :) > > Does this affect a new query window (currently the title is 'Query - > untitled')? > ​Yes, in this case the title of query window will be Query - [db_name] on [server_name]. It was showing 'Query - unti

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Hi PFA patch. On Tue, Jun 13, 2017 at 9:54 PM, Dave Page wrote: > Hmm, this seems to have broken the feature tests. Can you look at that > ASAP please? I think it's because the tab text has changed. > ​Yes, now it will search for 'Query -' ​instead of 'Query-1'. > > On Tue, Jun 13, 2017 at 11:

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

To add some interview context - from talking to DBAs, partitioning is the most frequent use case we should account for first. Breaking down child partitions into smaller pieces wasn't something we heard as a need. This is probably not the highest priority work needed now. We should think about whe

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

Akshay, Have you determined the minimum feature set you are shooting for before you commit this? The reason I ask is that we were thinking that some level of simple automation would probably be nice to make this super useful. Basically if you consider a simple example of partitioning 90 days of d

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Awesome!! This is super helpful :) Does this affect a new query window (currently the title is 'Query - untitled')? On Mon, Jun 12, 2017 at 10:25 PM Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Changes: > > 1) When Query tool is opened, right now - panel title is displayed a

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Hmm, this seems to have broken the feature tests. Can you look at that ASAP please? I think it's because the tab text has changed. On Tue, Jun 13, 2017 at 11:34 AM, Dave Page wrote: > Thanks, patch applied. > > On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar > wrote: >> Hi >> >> Changes: >> >> 1

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

Hi Hackers, Good catch Dave. You can find attached the new diff with the correction of the problem above. Thanks Shruti & Joao On Tue, Jun 13, 2017 at 10:35 AM, Dave Page wrote: > Hi > > On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira > wrote: > > Hi Hackers, > > > > Attached

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

Hi On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira wrote: > Hi Hackers, > > Attached you can find the patch that corrects that Bundle tests that was > polluting the os and subprocess modules. > > This patch reverts the commit that skipped the test. This is almost exactly what Ashe

Re: [pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

Hello Hackers, We will create a new patch to solve this issue. Thanks Joao & Shruti On Tue, Jun 13, 2017 at 9:37 AM, Dave Page wrote: > Pivotal team, > > Per the commit below, and the probably many messages you've likely > seen from Jenkins, I've had to disable the JavascriptBundler test. It >

Re: [pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

Pivotal team, Per the commit below, and the probably many messages you've likely seen from Jenkins, I've had to disable the JavascriptBundler test. It works fine if you're testing a single server, but if you have more than one enabled in test_config.json, then it will fail on the second (and I ima

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Hi On Tue, Jun 13, 2017 at 2:54 PM, Dave Page wrote: > On Mon, Jun 12, 2017 at 5:55 PM, Shirley Wang wrote: > >>> > >>> > >>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar > >>> wrote: > >>> > Hi > >>> > > >>> > The current font-family applied to slick-grid is > >>> > 'Verdana,Arial,sans-ser

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 11:47 AM, Surinder Kumar wrote: > On Tue, Jun 13, 2017 at 4:05 PM, Dave Page wrote: >> >> On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar >> wrote: >> > >> > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: >> >> >> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi >>

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 4:05 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar > wrote: > > > > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > >> > >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi > >> wrote: > >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote:

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar wrote: > > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: >> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi >> wrote: >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: >> >> >> >> And then I find a problem. Sigh. >> >> >> >> When runni

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Thanks, patch applied. On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar wrote: > Hi > > Changes: > > 1) When Query tool is opened, right now - panel title is displayed as "Query > - 1 ", instead it should display Query - [db_name] on [server_name] as in > pgAdmin3. > > 2) When Edit grid is opened

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi > wrote: > > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: > >> > >> And then I find a problem. Sigh. > >> > >> When running in the desktop runtime, under QtWekKit (the forked, > >> updated ve

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

-- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vas

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

On Tue, Jun 13, 2017 at 3:57 PM, Dave Page wrote: > > > On Tue, Jun 13, 2017 at 11:25 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Oops. >>> let me revert it back. >>> >> 'web/regres

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi wrote: > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: >> >> And then I find a problem. Sigh. >> >> When running in the desktop runtime, under QtWekKit (the forked, >> updated version that is by far the best of the browser engines we've >> used),

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

On Tue, Jun 13, 2017 at 11:25 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Oops. >> let me revert it back. >> > 'web/regressions/requirements.txt' needs to change as it is not require > for P

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi wrote: > Oops. > let me revert it back. > 'web/regressions/requirements.txt' needs to change as it is not require for Python >= 3.3. Will do the change. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

Oops. let me revert it back. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Jun 13, 2017 at 3:50 PM, Dave Page wrote: > Is mock requir

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: > And then I find a problem. Sigh. > > When running in the desktop runtime, under QtWekKit (the forked, > updated version that is by far the best of the browser engines we've > used), we get the attached error at startup. I don't see this under >

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

Is mock required at runtime, or just for tests? It's already in web/regressions/requirements.txt On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi wrote: > Required mock package for python < 3.3. > It was required for the commit: > 1208206bc0eca2d135469258e8a209b983e668be > > Also, do not fetch the

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

On Tue, Jun 13, 2017 at 2:52 PM, Dave Page wrote: > Nice work! Committed (along with an update to the docs). > > Congratulations on your first C++ patch :-) > > Thanks Dave. :) > On Tue, Jun 13, 2017 at 7:07 AM, Khushboo Vashi > wrote: > > Hi, > > > > On Mon, Jun 12, 2017 at 5:27 PM, Dave Page

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

Thanks, applied. On Mon, Jun 12, 2017 at 8:14 PM, Joao Pedro De Almeida Pereira wrote: > Hello Hackers, > We sent the wrong patch. Attached is the correct one. > > Sorry > > Shruti & Joao > > On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira > wrote: >> >> Hi Hackers, >> >> We were

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

On Mon, Jun 12, 2017 at 5:55 PM, Shirley Wang wrote: >>> >>> >>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar >>> wrote: >>> > Hi >>> > >>> > The current font-family applied to slick-grid is >>> > 'Verdana,Arial,sans-serif'. >>> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

Nice work! Committed (along with an update to the docs). Congratulations on your first C++ patch :-) On Tue, Jun 13, 2017 at 7:07 AM, Khushboo Vashi wrote: > Hi, > > On Mon, Jun 12, 2017 at 5:27 PM, Dave Page wrote: >> >> Hi >> >> On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi >> wrote: >> >

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi On Mon, Jun 12, 2017 at 7:22 PM, Shruti B Iyer wrote: > Hi Dave, > > We regenerated the patch to add new tasks to package.json to compile react > code for development and to not minimize it. This should fix the error you > captured in the screenshot. > > The new task to lint and bundle everyth

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Thanks, applied. On Tue, Jun 13, 2017 at 4:45 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Mon, Jun 12, 2017 at 8:24 PM, Dave Page wrote: > >> Hi Khushboo, >> >> Looks like this patch broke the regressions tests :-(. Can you take a >> look ASAP please? >> >> please f

Re: [pgadmin-hackers] PG Admin 4

Hi On Tue, Jun 13, 2017 at 3:09 AM, Matt Owen wrote: > Hi > > > > PGADMIN4 looks great – > Thanks! > however Is there a way to disable the dashboard stuff – the “remove panel” > option doesn’t seem to work that we can see (you can float it but not close > it). We are accessing an Amazon RDS

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

Hi, On Mon, Jun 12, 2017 at 5:27 PM, Dave Page wrote: > Hi > > On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached patch to reset the zoom level in the desktop > > runtime. > > > > Added the new shortcut CTRL + 0 to reset the zoom level. > > The cod

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Hi, On Mon, Jun 12, 2017 at 8:24 PM, Dave Page wrote: > Hi Khushboo, > > Looks like this patch broke the regressions tests :-(. Can you take a look > ASAP please? > > please find the attached fix. However I didn't get any error while running regression tests. > Thanks! > > 2017-06-12 10:04:11,9

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

Hello Hackers, We sent the wrong patch. Attached is the correct one. Sorry Shruti & Joao On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We were trying to run the feature tests against GreenPlum and one of the > tests was f

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Dave, We regenerated the patch to add new tasks to package.json to compile react code for development and to not minimize it. This should fix the error you captured in the screenshot. The new task to lint and bundle everything for development is: yarn run bundle:dev The new task only bundle e

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

> > >> >> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > The current font-family applied to slick-grid is >> 'Verdana,Arial,sans-serif'. >> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif >> but >> > the font size and spacing between text is red

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

Thanks, applied. On Mon, Jun 12, 2017 at 4:43 PM, Shruti B Iyer wrote: > Hi Hackers! > > Attached is a minor patch that wraps with gettext() the "Select/Deselect > All" text in the top left corner of the query results grid. > > Thanks, > Matt and Shruti > > > -- > Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

To add to that; running the JS tests gives: ERROR in ./regression/javascript/history/query_history_entry_spec.jsx Module not found: Error: Can't resolve 'jasmine-enzyme' in '/Users/dpage/git/pgadmin4/web/regression/javascript/history' @ ./regression/javascript/history/query_history_entry_spec.jsx

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Thanks, applied. On Mon, Jun 12, 2017 at 3:52 PM, Surinder Kumar wrote: > Hi Dave, > > Please find updated patch. > > On Mon, Jun 12, 2017 at 7:58 PM, Dave Page wrote: >> >> Hi >> >> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > I confirm this is updated patch. >>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Hi Khushboo, Looks like this patch broke the regressions tests :-(. Can you take a look ASAP please? Thanks! 2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017 10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 - Traceback (most recent call last): File "/Users

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Dave, Please find updated patch. On Mon, Jun 12, 2017 at 7:58 PM, Dave Page wrote: > Hi > > On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar > wrote: > > Hi > > > > I confirm this is updated patch. > > Thanks. Something else seems to have changed that I can't spot. Only > should be ignored

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Shruti On Mon, Jun 12, 2017 at 3:24 PM, Shruti B Iyer wrote: > > Hello Dave, > > Thanks for making those fixes and sharing them with us. We tried applying > the patch and it looks like there are some missing file changes from your > patch that were present in ours, like the Make.bat file chang

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Shirley and I are in SF this week so we will be even more async that usual. -- Rob On Mon, Jun 12, 2017 at 7:33 AM, Dave Page wrote: > Adding Shirley... > > Hi > > On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar > wrote: > > Hi > > > > The current font-family applied to slick-grid is > 'Verdan

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Adding Shirley... Hi On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar wrote: > Hi > > The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'. > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but > the font size and spacing between text is reduced. so to

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar wrote: > Hi > > I confirm this is updated patch. Thanks. Something else seems to have changed that I can't spot. Only should be ignored if a child control has focus - Escape and F1 should continue to work. I tried moving the: if (panel && pane

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hello Dave, Thanks for making those fixes and sharing them with us. We tried applying the patch and it looks like there are some missing file changes from your patch that were present in ours, like the Make.bat file changes. But we will add them when we send you the new patches. While trying to g

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Role Membership control

Thanks applied. On Mon, Jun 12, 2017 at 1:46 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in Role Membership control, In edit mode > user was unable to toggle grant admin privileges to membership roles. > RM#2086 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: htt

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Hi The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'. I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but the font size and spacing between text is reduced. so to match style I used "Verdana". Also, as per my knowledge, the Helvetica font will work

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi I confirm this is updated patch. PFA patch. On Mon, Jun 12, 2017 at 6:20 PM, Dave Page wrote: > Hi > > Is that the correct patch? Hitting in a comment text area is > still causing the dialogue to close.​ > Thanks. > > On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar > wrote: > > Hi > > >

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Is that the correct patch? Hitting in a comment text area is still causing the dialogue to close. Thanks. On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar wrote: > Hi > > Please find rebased patch > > Thanks > > On Mon, Jun 12, 2017 at 5:20 PM, Dave Page wrote: >> >> Could you rebase this

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Hi Can you update this so that the CSS all follows the standards in the WIP styleguide please? I see that the current patch is using the wrong font for example. http://pgadmin4-styleguide.cfapps.io/ Thanks! On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar wrote: > Hi > > Changes: > > 1) Calcul

Re: [pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

Thanks, patch applied! On Mon, Jun 12, 2017 at 11:48 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where SQL Panel in query tool displays truncated > sql on resize. > RM#2078 > > Steps to re-produce the issue: > 1) Create table provided by user from RM. > 2) Right click on new

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

Thanks, patch applied. On Mon, Jun 12, 2017 at 10:54 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in Table node where it was not displaying > reversed engineered sql for Trigger(s) properly, if trigger function > associated with that trigger has parameters. > RM#2043 > > -- >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

Hi On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to reset the zoom level in the desktop > runtime. > > Added the new shortcut CTRL + 0 to reset the zoom level. The code looks good, however I don't think resetting to the startup value is really wh

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Please find rebased patch Thanks On Mon, Jun 12, 2017 at 5:20 PM, Dave Page wrote: > Could you rebase this please? > > Thanks. > > On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar > wrote: > > Ignore previous patch as it doesn't contains new changes. > > Please find attached patch. > > > >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

Thanks Atul, patch applied. On Fri, Jun 9, 2017 at 1:34 PM, Atul Sharma wrote: > Hi Dave, > > I have made the template search code to work for 10_plus directory name. > Please review the attached patch > > Regards, > Atul. > > > > On Thu, Jun 8, 2017 at 7:55 PM, Dave Page wrote: >> >> Hi Atul, >

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Could you rebase this please? Thanks. On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar wrote: > Ignore previous patch as it doesn't contains new changes. > Please find attached patch. > > > On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar > wrote: >> >> Hi >> >> PFA patch and review. >> >> >> On F

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Thanks, applied. On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for > Table, Column, Foreign Table and Type node. > > Regarding the r

Re: [pgadmin-hackers][patch] Changing the ACI tree font to Helvetica

I'm with you on that. I had to use the browser with Helvetica for about day before I could make a comparison with using Verdana. On Fri, Jun 9, 2017 at 4:11 AM Dave Page wrote: > Thanks - I'm not 100% sure it's as easy to read as it was. Oddly, I > wonder if the size needs reducing a little (to

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

Hi Dave, I have made the template search code to work for 10_plus directory name. Please review the attached patch Regards, Atul. On Thu, Jun 8, 2017 at 7:55 PM, Dave Page wrote: > Hi Atul, > > On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma > wrote: > > Hi, > > > > The issue is fixed now. Adde

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Ignore previous patch as it doesn't contains new changes. Please find attached patch. On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar wrote: > Hi > > PFA patch and review. > > > On Fri, Jun 9, 2017 at 1:47 PM, Dave Page wrote: > >> Hi >> >> Ahh, now we have a bug. In the properties dialogues, i

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi PFA patch and review. On Fri, Jun 9, 2017 at 1:47 PM, Dave Page wrote: > Hi > > Ahh, now we have a bug. In the properties dialogues, if you edit a > comment, as soon as the Save button gets enabled, hitting Return will > Save the changes instead of adding a newline to the comment. That's >

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Thanks, applied. On Fri, Jun 9, 2017 at 8:39 AM, Surinder Kumar wrote: > Hi > > As the patch "Improvements to Query Results" > is merged, the columns width in edit grid needs some adjustments as > 'checkboxes' are removed from columns. > > PFA patch. > > On Thu, Jun 8, 2017 at 5:12 PM, Dave Page

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Ahh, now we have a bug. In the properties dialogues, if you edit a comment, as soon as the Save button gets enabled, hitting Return will Save the changes instead of adding a newline to the comment. That's clearly not right :-( On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar wrote: > Hi > > Ple

Re: [pgadmin-hackers][patch] Changing the ACI tree font to Helvetica

Thanks - I'm not 100% sure it's as easy to read as it was. Oddly, I wonder if the size needs reducing a little (to increase the whitespace around each label), but I think we need more eyes on it to decide if I'm just imagining that so I've committed it for now, and we can tweak later if needed. On

  1   2   3   4   5   6   7   8   9   10   >