Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-12 Thread Dave Page
Thanks, patch applied. On Mon, Apr 10, 2017 at 2:22 PM, Navnath Gadakh wrote: > Hi Dave, > > Please find the revised patch. > > On Mon, Apr 10, 2017 at 1:43 PM, Dave Page > wrote: >> >> Hi >> >> On Fri, Apr 7, 2017 at 8:01 PM, Navnath Gadakh >> wrote: >>> >>> Hello Joao, >>> >>>

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-10 Thread Navnath Gadakh
Hi Dave, Please find the revised patch. On Mon, Apr 10, 2017 at 1:43 PM, Dave Page wrote: > Hi > > On Fri, Apr 7, 2017 at 8:01 PM, Navnath Gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hello Joao, >> >> Thanks for review and suggestions. >> >> On Fri, Apr 7, 2017 at 9:

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-10 Thread Dave Page
Hi On Fri, Apr 7, 2017 at 8:01 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello Joao, > > Thanks for review and suggestions. > > On Fri, Apr 7, 2017 at 9:08 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> We just look

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-07 Thread Navnath Gadakh
Hello Joao, Thanks for review and suggestions. On Fri, Apr 7, 2017 at 9:08 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > We just looked into this patch and have some questions about it. > > - Where is the JSON file created? Do we need to ca

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-07 Thread Joao Pedro De Almeida Pereira
Hello Hackers, We just looked into this patch and have some questions about it. - Where is the JSON file created? Do we need to call it with some special argument in order for it to be created? - There is a print statement in the line 275 of runtests.py is it supposed to be there? - The function n

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-07 Thread Navnath Gadakh
Hi Dave, Please find the revised patch for test result enhancement, which include code to write passed test cases into the JSON file along with skipped and failed. On Tue, Apr 4, 2017 at 11:30 AM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > >

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-03 Thread Navnath Gadakh
Hi Dave, Please find the revised patch for test result enhancement. What's in the patch: 1. The test result summary will store in JSON file. 2. Removed some redundant code from regression/test_utils.py 3. Added the scenario names for feature tests. 4. To print test scenario names in failed a

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-03 Thread Navnath Gadakh
Hi Akshay, Please find the revised patch for test result enhancement. *What's in the patch:* 1. The test result summary will store in JSON file. 2. Removed some redundant code from *regression/test_utils.py* *3. A*dded the scenario names for feature tests. 4. To print test scenario names in

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-31 Thread Akshay Joshi
Hi Navnath I have run the updated patch. It is working fine with Python 2.7 but I am facing following error with Python 3.5, can you please look into it: == ERROR: runTest (pgadmin.feature_tests.connect_to_server_feature_test.Co

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-30 Thread Navnath Gadakh
Hi Dave, Please find the revised patch for test result enhancement. *What's in the patch:* 1. The test result summary will store in JSON file. 2. Removed some redundant code from *regression/test_utils.py* *3. A*dded the scenario names for feature tests. 4. To print test scenario names in fa

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-29 Thread Dave Page
On Wed, Mar 29, 2017 at 4:12 AM, Navnath Gadakh wrote: > Hi, > > On Mon, Mar 27, 2017 at 5:37 PM, Dave Page wrote: >> >> Hi >> >> On Mon, Mar 27, 2017 at 12:15 AM, Navnath Gadakh >> wrote: >> > Hello Dave, >> > >> > On Fri, Mar 24, 2017 at 9:10 PM, Dave Page wrote: >> >> >> >> Hi >> >> >> >> On

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-29 Thread Navnath Gadakh
Hi, On Mon, Mar 27, 2017 at 5:37 PM, Dave Page wrote: > Hi > > On Mon, Mar 27, 2017 at 12:15 AM, Navnath Gadakh > wrote: > > Hello Dave, > > > > On Fri, Mar 24, 2017 at 9:10 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Fri, Mar 24, 2017 at 3:13 PM, Navnath Gadakh > >> wrote: > >> > > >> >>

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-27 Thread Dave Page
Hi On Mon, Mar 27, 2017 at 12:15 AM, Navnath Gadakh wrote: > Hello Dave, > > On Fri, Mar 24, 2017 at 9:10 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Mar 24, 2017 at 3:13 PM, Navnath Gadakh >> wrote: >> > >> >> When running with the patch: >> >> >> >> 1) The browser isn't closed, and the script

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-26 Thread Navnath Gadakh
Hello Dave, On Fri, Mar 24, 2017 at 9:10 PM, Dave Page wrote: > Hi > > On Fri, Mar 24, 2017 at 3:13 PM, Navnath Gadakh > wrote: > > > >> When running with the patch: > >> > >> 1) The browser isn't closed, and the script never exits - it just sits > >> indefinitely at: > >> > >> = > >> Pleas

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-24 Thread Dave Page
Hi On Fri, Mar 24, 2017 at 3:13 PM, Navnath Gadakh wrote: > >> When running with the patch: >> >> 1) The browser isn't closed, and the script never exits - it just sits >> indefinitely at: >> >> = >> Please check output in file: >> /Users/dpage/git/pgadmin4/web/regression/regression.log >> >>

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-24 Thread Navnath Gadakh
Hi Dave, Please find the revised patch. On Wed, Mar 22, 2017 at 5:09 PM, Dave Page wrote: > Hi > > On Wed, Mar 22, 2017 at 6:03 AM, Navnath Gadakh > wrote: > > Hi Dave, > > > >Please find the patch for test result enhancement. > > What's in the patch: > > 1. The test result s

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-22 Thread Dave Page
Hi On Wed, Mar 22, 2017 at 6:03 AM, Navnath Gadakh wrote: > Hi Dave, > >Please find the patch for test result enhancement. > What's in the patch: > 1. The test result summary will store in JSON file. > 2. Removed some redundant code from regression/test_utils.py > 3. To print test sc